dri-devel November 2010

dri-devel@lists.freedesktop.org

74 participants
347 discussions

Re: [PATCH] Add Intel GMA500(Poulsbo) Stub Driver
by Joey Lee 12 Nov '10

12 Nov '10

Hi Rui, First, thank's for your review and take care. 於五，2010-11-12 於 09:31 +0800，Zhang Rui 提到： > Hi, Lee, > > there are several regressions caused by this patch, > http://marc.info/?l=linux-acpi&m=128872402020412&w=2 > http://marc.info/?l=linux-acpi&m=128858111022621&w=2 > > Yes, We can fix it by "select INPUT if ACPI"/"select > VIDEO_OUTPUT_CONTROL if ACPI". > But IMO, STUB_POULSBO should not select ACPI_VIDEO at all, > what do you think? > Yes, I agreed. We can just remove the _select ACPI_VIDEO if ACPI_ because user should select it when they want to use. If CONFIG_ACPI_VIDEO doesn't select, the stub poulsbo just do _not_ thing but will have no any bad thing. So, let's direct remove it from Kconfig. Should I submit patch again? Thank's Joey Lee > thanks, > rui > > On Wed, 2010-11-03 at 09:19 +0800, Zhang Rui wrote: > > Hi, Lee, > > > > Sorry I missed this thread. > > > > On Wed, 2010-10-20 at 13:51 +0800, Lee, Chun-Yi wrote: > > > Currently, there have no GMA500(Poulsbo) native video driver to support > > > intel opregion. So, use this stub driver to enable the acpi backlight > > > control sysfs entry files by requrest acpi_video_register. > > > > > If you want the acpi backlight control, why not set CONFIG_ACPI_VIDEO > > driver directly? > > The reason why i915 driver selects ACPI_VIDEO is that it needs some > > cooperation between these two drivers during initialization, or else the > > system may hang. > > > > thanks, > > rui > > > > > Signed-off-by: Lee, Chun-Yi <jlee(a)novell.com> > > > --- > > > drivers/gpu/Makefile | 2 +- > > > drivers/gpu/stub/Kconfig | 13 +++++++++ > > > drivers/gpu/stub/Makefile | 1 + > > > drivers/gpu/stub/poulsbo.c | 63 ++++++++++++++++++++++++++++++++++++++++++++ > > > drivers/video/Kconfig | 2 + > > > 5 files changed, 80 insertions(+), 1 deletions(-) > > > create mode 100644 drivers/gpu/stub/Kconfig > > > create mode 100644 drivers/gpu/stub/Makefile > > > create mode 100644 drivers/gpu/stub/poulsbo.c > > > > > > diff --git a/drivers/gpu/Makefile b/drivers/gpu/Makefile > > > index 30879df..cc92778 100644 > > > --- a/drivers/gpu/Makefile > > > +++ b/drivers/gpu/Makefile > > > @@ -1 +1 @@ > > > -obj-y += drm/ vga/ > > > +obj-y += drm/ vga/ stub/ > > > diff --git a/drivers/gpu/stub/Kconfig b/drivers/gpu/stub/Kconfig > > > new file mode 100644 > > > index 0000000..8f5a540 > > > --- /dev/null > > > +++ b/drivers/gpu/stub/Kconfig > > > @@ -0,0 +1,13 @@ > > > +config STUB_POULSBO > > > + tristate "Intel GMA500 Stub Driver" > > > + depends on PCI > > > + # Poulsbo stub depends on ACPI_VIDEO when ACPI is enabled > > > + # but for select to work, need to select ACPI_VIDEO's dependencies, ick > > > + select ACPI_VIDEO if ACPI > > > + help > > > + Choose this option if you have a system that has Intel GMA500 > > > + (Poulsbo) integrated graphics. If M is selected, the module will > > > + be called Poulsbo. This driver is a stub driver for Poulsbo that > > > + will call poulsbo.ko to enable the acpi backlight control sysfs > > > + entry file because there have no poulsbo native driver can support > > > + intel opregion. > > > diff --git a/drivers/gpu/stub/Makefile b/drivers/gpu/stub/Makefile > > > new file mode 100644 > > > index 0000000..cd940cc > > > --- /dev/null > > > +++ b/drivers/gpu/stub/Makefile > > > @@ -0,0 +1 @@ > > > +obj-$(CONFIG_STUB_POULSBO) += poulsbo.o > > > diff --git a/drivers/gpu/stub/poulsbo.c b/drivers/gpu/stub/poulsbo.c > > > new file mode 100644 > > > index 0000000..d8aa636 > > > --- /dev/null > > > +++ b/drivers/gpu/stub/poulsbo.c > > > @@ -0,0 +1,63 @@ > > > +/* > > > + * Intel Poulsbo Stub driver > > > + * > > > + * Copyright (C) 2010 Novell <jlee(a)novell.com> > > > + * > > > + * This program is free software; you can redistribute it and/or modify it > > > + * under the terms of the GNU General Public License version 2 as published by > > > + * the Free Software Foundation. > > > + * > > > + */ > > > + > > > +#include <linux/module.h> > > > +#include <linux/pci.h> > > > +#include <acpi/video.h> > > > + > > > +#define DRIVER_NAME "poulsbo" > > > + > > > +enum { > > > + CHIP_PSB_8108 = 0, > > > + CHIP_PSB_8109 = 1, > > > +}; > > > + > > > +static struct pci_device_id pciidlist[] = { > > > + {0x8086, 0x8108, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PSB_8108}, \ > > > + {0x8086, 0x8109, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PSB_8109}, \ > > > + {0, 0, 0} > > > +}; > > > + > > > +static int poulsbo_probe(struct pci_dev *pdev, const struct pci_device_id *id) > > > +{ > > > + return acpi_video_register(); > > > +} > > > + > > > +static void poulsbo_remove(struct pci_dev *pdev) > > > +{ > > > + acpi_video_unregister(); > > > +} > > > + > > > +static struct pci_driver poulsbo_driver = { > > > + .name = DRIVER_NAME, > > > + .id_table = pciidlist, > > > + .probe = poulsbo_probe, > > > + .remove = poulsbo_remove, > > > +}; > > > + > > > +static int __init poulsbo_init(void) > > > +{ > > > + return pci_register_driver(&poulsbo_driver); > > > +} > > > + > > > +static void __exit poulsbo_exit(void) > > > +{ > > > + pci_unregister_driver(&poulsbo_driver); > > > +} > > > + > > > +module_init(poulsbo_init); > > > +module_exit(poulsbo_exit); > > > + > > > +MODULE_AUTHOR("Lee, Chun-Yi <jlee(a)novell.com>"); > > > +MODULE_DESCRIPTION("Poulsbo Stub Driver"); > > > +MODULE_LICENSE("GPL"); > > > + > > > +MODULE_DEVICE_TABLE(pci, pciidlist); > > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > > > index 8b31fdf..8807ae5 100644 > > > --- a/drivers/video/Kconfig > > > +++ b/drivers/video/Kconfig > > > @@ -17,6 +17,8 @@ source "drivers/gpu/vga/Kconfig" > > > > > > source "drivers/gpu/drm/Kconfig" > > > > > > +source "drivers/gpu/stub/Kconfig" > > > + > > > config VGASTATE > > > tristate > > > default n > > > >

1 0

[PATCH] Add Intel GMA500(Poulsbo) Stub Driver
by Lee, Chun-Yi 12 Nov '10

12 Nov '10

Currently, there have no GMA500(Poulsbo) native video driver to support intel opregion. So, use this stub driver to enable the acpi backlight control sysfs entry files by requrest acpi_video_register. Signed-off-by: Lee, Chun-Yi <jlee(a)novell.com> --- drivers/gpu/Makefile | 2 +- drivers/gpu/stub/Kconfig | 13 +++++++++ drivers/gpu/stub/Makefile | 1 + drivers/gpu/stub/poulsbo.c | 63 ++++++++++++++++++++++++++++++++++++++++++++ drivers/video/Kconfig | 2 + 5 files changed, 80 insertions(+), 1 deletions(-) create mode 100644 drivers/gpu/stub/Kconfig create mode 100644 drivers/gpu/stub/Makefile create mode 100644 drivers/gpu/stub/poulsbo.c diff --git a/drivers/gpu/Makefile b/drivers/gpu/Makefile index 30879df..cc92778 100644 --- a/drivers/gpu/Makefile +++ b/drivers/gpu/Makefile @@ -1 +1 @@ -obj-y += drm/ vga/ +obj-y += drm/ vga/ stub/ diff --git a/drivers/gpu/stub/Kconfig b/drivers/gpu/stub/Kconfig new file mode 100644 index 0000000..8f5a540 --- /dev/null +++ b/drivers/gpu/stub/Kconfig @@ -0,0 +1,13 @@ +config STUB_POULSBO + tristate "Intel GMA500 Stub Driver" + depends on PCI + # Poulsbo stub depends on ACPI_VIDEO when ACPI is enabled + # but for select to work, need to select ACPI_VIDEO's dependencies, ick + select ACPI_VIDEO if ACPI + help + Choose this option if you have a system that has Intel GMA500 + (Poulsbo) integrated graphics. If M is selected, the module will + be called Poulsbo. This driver is a stub driver for Poulsbo that + will call poulsbo.ko to enable the acpi backlight control sysfs + entry file because there have no poulsbo native driver can support + intel opregion. diff --git a/drivers/gpu/stub/Makefile b/drivers/gpu/stub/Makefile new file mode 100644 index 0000000..cd940cc --- /dev/null +++ b/drivers/gpu/stub/Makefile @@ -0,0 +1 @@ +obj-$(CONFIG_STUB_POULSBO) += poulsbo.o diff --git a/drivers/gpu/stub/poulsbo.c b/drivers/gpu/stub/poulsbo.c new file mode 100644 index 0000000..d8aa636 --- /dev/null +++ b/drivers/gpu/stub/poulsbo.c @@ -0,0 +1,63 @@ +/* + * Intel Poulsbo Stub driver + * + * Copyright (C) 2010 Novell <jlee(a)novell.com> + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 as published by + * the Free Software Foundation. + * + */ + +#include <linux/module.h> +#include <linux/pci.h> +#include <acpi/video.h> + +#define DRIVER_NAME "poulsbo" + +enum { + CHIP_PSB_8108 = 0, + CHIP_PSB_8109 = 1, +}; + +static struct pci_device_id pciidlist[] = { + {0x8086, 0x8108, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PSB_8108}, \ + {0x8086, 0x8109, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PSB_8109}, \ + {0, 0, 0} +}; + +static int poulsbo_probe(struct pci_dev *pdev, const struct pci_device_id *id) +{ + return acpi_video_register(); +} + +static void poulsbo_remove(struct pci_dev *pdev) +{ + acpi_video_unregister(); +} + +static struct pci_driver poulsbo_driver = { + .name = DRIVER_NAME, + .id_table = pciidlist, + .probe = poulsbo_probe, + .remove = poulsbo_remove, +}; + +static int __init poulsbo_init(void) +{ + return pci_register_driver(&poulsbo_driver); +} + +static void __exit poulsbo_exit(void) +{ + pci_unregister_driver(&poulsbo_driver); +} + +module_init(poulsbo_init); +module_exit(poulsbo_exit); + +MODULE_AUTHOR("Lee, Chun-Yi <jlee(a)novell.com>"); +MODULE_DESCRIPTION("Poulsbo Stub Driver"); +MODULE_LICENSE("GPL"); + +MODULE_DEVICE_TABLE(pci, pciidlist); diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 8b31fdf..8807ae5 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -17,6 +17,8 @@ source "drivers/gpu/vga/Kconfig" source "drivers/gpu/drm/Kconfig" +source "drivers/gpu/stub/Kconfig" + config VGASTATE tristate default n -- 1.6.0.2

3 3

[Bug 30188] New: X server crashes with a SIGBUS on Evergreen
by bugzilla-daemon＠freedesktop.org 12 Nov '10

12 Nov '10

https://bugs.freedesktop.org/show_bug.cgi?id=30188 Summary: X server crashes with a SIGBUS on Evergreen Product: DRI Version: XOrg CVS Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: critical Priority: medium Component: DRM/Radeon AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: tomasz.figa(a)gmail.com I have recently switched my desktop PC with Radeon HD 5770 from fglrx to xf86-video-ati and discovered a problem causing the X server to crash with a SIGBUS signal. I can reproduce this bug by opening a PDF document in Okular and scrolling through several pages back and forth, then mouse cursor hangs and X server crashes. It happens regardless of kernel version. Disabling RenderAccel helps, but it's not a solution since it turns off the acceleration. It's not a duplicate of https://bugs.freedesktop.org/show_bug.cgi?id=29738 , because it still happens with pre-709ea97145c125b3811ff70429e90ebdb0e832e5 kernels. My setup: Linux 2.6.35.4, git drm-fixes or git drm-radeon-testing xorg-server git 09/13 xf86-video-ati git 09/13 libdrm git 09/13 Intel Core 2 Quad Q6600 Processor AMD Radeon HD 5770 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 31

i915 on 2.6.37-rc1: backlight always off after "xset dpms standby"
by Alex Riesen 11 Nov '10

11 Nov '10

Hi, an alternative way to reproduce it, is to just wait for screensaver. Only the backlight is off, it is possible to see the image on LCD matrix if you get the angle right. The system is the by now fairly old Dell XPS M1330, 64 bit kernel, KMS used (and works since 2.6.35), no 3D. There is sadly nothing interesting in dmesg or in XOrg.0.log (attached along with .config anyway). The repo's HEAD is at f6614b7bb405a9b35dd28baea989a749492c46b2.

1 1

[Bug 25005] radeon RV250: xorg locks up when running glxgears
by bugzilla-daemon＠freedesktop.org 11 Nov '10

11 Nov '10

https://bugs.freedesktop.org/show_bug.cgi?id=25005 Jose <braket(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #9 from Jose <braket(a)hotmail.com> 2010-11-11 13:06:26 PST --- I finally got a chance to test and the bug seems to be fixed. There was no need to test mesa from git. I'm running: kernel 2.6.36 xorg-server 1.9.2 xf86-video-ati 6.13.2 mesa 7.8.2 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 31549] New: Commit c2c55547dc36f404e29dbc9253166f90df6783af makes CS checker unhappy and causes rendering issues
by bugzilla-daemon＠freedesktop.org 11 Nov '10

11 Nov '10

https://bugs.freedesktop.org/show_bug.cgi?id=31549 Summary: Commit c2c55547dc36f404e29dbc9253166f90df6783af makes CS checker unhappy and causes rendering issues Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: major Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: mikhail.vorozhtsov(a)gmail.com Commit c2c55547dc36f404e29dbc9253166f90df6783af "r600g: attempt to turn on DXTn formats" makes my dmesg (both 2.6.36 and d-r-t, the hardware is RV730XT) full of radeon 0000:01:00.0: r600_check_texture_resource:1127 texture invalid format 50 [drm:radeon_cs_ioctl] *ERROR* Invalid command stream ! and Compiz plugins like Scale/App switcher are completely broken. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 2

[Bug 31152] New: Please backport r200 fix to r100 and r300c
by bugzilla-daemon＠freedesktop.org 11 Nov '10

11 Nov '10

https://bugs.freedesktop.org/show_bug.cgi?id=31152 Summary: Please backport r200 fix to r100 and r300c Product: Mesa Version: git Platform: All OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/Radeon AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: fabio.ped(a)libero.it The following fix: http://cgit.freedesktop.org/mesa/mesa/commit/?h=7.9&id=6936fbc03999354075da… http://lists.freedesktop.org/archives/mesa-dev/2010-October/003491.html should be backported to master and 7.9 branches in both r100 and r300c. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 8

[PATCH] drm/ttm: Fix up a theoretical deadlock
by Thomas Hellstrom 11 Nov '10

11 Nov '10

A process suspended waiting for a higher sequence or no sequence to unreserve, a bo may be beaten to the reservation by a process with a lower sequence. In that case the first process should give up trying to reserve and return -EAGAIN. In order for that to happen, we must wake waiting processes when we change sequence, so that they have a chance to detect the new sequence. Signed-off-by: Thomas Hellstrom <thellstrom(a)vmware.com> --- drivers/gpu/drm/ttm/ttm_bo.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 3ca77dc..148a322 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -224,6 +224,9 @@ int ttm_bo_reserve_locked(struct ttm_buffer_object *bo, int ret; while (unlikely(atomic_cmpxchg(&bo->reserved, 0, 1) != 0)) { + /** + * Deadlock avoidance for multi-bo reserving. + */ if (use_sequence && bo->seq_valid && (sequence - bo->val_seq < (1 << 31))) { return -EAGAIN; @@ -241,6 +244,14 @@ int ttm_bo_reserve_locked(struct ttm_buffer_object *bo, } if (use_sequence) { + /** + * Wake up waiters that may need to recheck for deadlock, + * if we decreased the sequence number. + */ + if (unlikely((bo->val_seq - sequence < (1 << 31)) + || !bo->seq_valid)) + wake_up_all(&bo->event_queue); + bo->val_seq = sequence; bo->seq_valid = true; } else { -- 1.6.2.5

1 0

[Bug 21351] R600+DRI: glxgears crash
by bugzilla-daemon＠freedesktop.org 11 Nov '10

11 Nov '10

https://bugs.freedesktop.org/show_bug.cgi?id=21351 --- Comment #6 from Alex Deucher <agd5f(a)yahoo.com> 2010-11-10 21:42:17 PST --- Is this still an issue on a newer kernel and mesa? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 21351] R600+DRI: glxgears crash
by bugzilla-daemon＠freedesktop.org 11 Nov '10

11 Nov '10

https://bugs.freedesktop.org/show_bug.cgi?id=21351 Thierry Vignaud <thierry.vignaud(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

← Newer
1
...
26
27
28
29
30
31
32
...
35
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel November 2010