dri-devel June 2010

dri-devel@lists.freedesktop.org

71 participants
237 discussions

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used
by Justin P. Mattock 15 Jun '10

15 Jun '10

On 06/15/2010 04:43 AM, Jean Delvare wrote: > Hi Justin, > > On Mon, 14 Jun 2010 14:06:12 -0700, Justin P. Mattock wrote: >> On 06/14/2010 01:53 PM, Jean Delvare wrote: >>> Hi Justin, >>> >>> On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: >>>> could be a right solution, could be wrong >>>> here is the warning: >>>> CC drivers/i2c/i2c-core.o >>>> drivers/i2c/i2c-core.c: In function 'i2c_register_adapter': >>>> drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy' set but not used >>>> >>>> Signed-off-by: Justin P. Mattock<justinmattock(a)gmail.com> >>>> >>>> --- >>>> drivers/i2c/i2c-core.c | 2 ++ >>>> 1 files changed, 2 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c >>>> index 1cca263..79c6c26 100644 >>>> --- a/drivers/i2c/i2c-core.c >>>> +++ b/drivers/i2c/i2c-core.c >>>> @@ -794,6 +794,8 @@ static int i2c_register_adapter(struct i2c_adapter *adap) >>>> mutex_lock(&core_lock); >>>> dummy = bus_for_each_drv(&i2c_bus_type, NULL, adap, >>>> __process_new_adapter); >>>> + if(!dummy) >>>> + dummy = 0; >>> >>> One word: scripts/checkpatch.pl >> >> it was this, and/or just take the code out >> (since I'm a newbie) > > I was not (yet) arguing on the code itself, but on its format. Any > patch you send should pass the formatting tests performed by > scripts/checkpatch.pl. Thanks. > o.k. I'll make sure I run everything through checkpatch.pl before sending anything. Justin P. Mattock

1 0

[Bug 28490] page allocation failure with 2.6.35-rc2
by bugzilla-daemon＠freedesktop.org 15 Jun '10

15 Jun '10

https://bugs.freedesktop.org/show_bug.cgi?id=28490 --- Comment #1 from Jerome Glisse <glisse(a)freedesktop.org> 2010-06-15 09:47:36 PDT --- Next time it happens please attach output of : cat /proc/dri/0/gem_objects -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 26403] X crashes on startup with KMS (Alpha architecture)
by bugzilla-daemon＠freedesktop.org 15 Jun '10

15 Jun '10

https://bugs.freedesktop.org/show_bug.cgi?id=26403 --- Comment #9 from Michael Cree <mcree(a)orcon.net.nz> 2010-06-15 03:35:23 PDT --- No, there was nothing in dmesg. To add debug output is this a kernel/module option? Or do you mean that debugging output will have to be manually added to the radeon kernel code at strategic places with a recompile of the kernel? I'm prepared to give that a go but I will need guidance. I am not familiar with the radeon kernel code! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 26403] X crashes on startup with KMS (Alpha architecture)
by bugzilla-daemon＠freedesktop.org 15 Jun '10

15 Jun '10

https://bugs.freedesktop.org/show_bug.cgi?id=26403 Michel Dänzer <michel(a)daenzer.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Product|xorg |DRI Version|git |unspecified Component|Driver/Radeon |DRM/Radeon AssignedTo|xorg-driver-ati(a)lists.x.org |dri-devel(a)lists.freedesktop | |.org QAContact|xorg-team(a)lists.x.org | --- Comment #8 from Michel Dänzer <michel(a)daenzer.net> 2010-06-15 03:25:56 PDT --- SIGBUS probably means something went wrong with the mapping in the kernel. See if there's anything in dmesg, but I suspect you'll have to add debugging output in drivers/gpu/drm/{radeon,ttm}/ to find out where it's coming from. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[PATCH ati] Add Gallium (radeong) support via an xorg.conf option, disabled by default.
by Robert Hooker 15 Jun '10

15 Jun '10

The r300 gallium driver in mesa is built as radeong_dri.so and the DDX is hardcoded to use r300 as the DRI driver name for that generation. this patch allows radeong to be used if specified in an xorg.conf with this option: Option "Gallium" "True" This only affects DRI2 since the gallium driver requires it, and has the benefit of being able to coexist with the classic mesa driver. Signed-off-by: Robert Hooker <sarvatt(a)ubuntu.com> diff --git a/src/radeon.h b/src/radeon.h index 56bc076..aede629 100644 --- a/src/radeon.h +++ b/src/radeon.h @@ -224,6 +224,7 @@ typedef enum { OPTION_FORCE_LOW_POWER, OPTION_DYNAMIC_PM, OPTION_NEW_PLL, + OPTION_GALLIUM, OPTION_ZAPHOD_HEADS } RADEONOpts; @@ -917,6 +918,7 @@ typedef struct { /* accel */ Bool RenderAccel; /* Render */ + Bool useGallium; Bool allowColorTiling; Bool tilingEnabled; /* mirror of sarea->tiling_enabled */ struct radeon_accel_state *accel_state; diff --git a/src/radeon_dri2.c b/src/radeon_dri2.c index 7d5205e..5cb5699 100644 --- a/src/radeon_dri2.c +++ b/src/radeon_dri2.c @@ -776,7 +776,9 @@ radeon_dri2_screen_init(ScreenPtr pScreen) if ( (info->ChipFamily >= CHIP_FAMILY_R600) ) { dri2_info.driverName = R600_DRIVER_NAME; - } else if ( (info->ChipFamily >= CHIP_FAMILY_R300) ) { + } else if ( info->ChipFamily >= CHIP_FAMILY_R300 && info->useGallium ) { + dri2_info.driverName = R300G_DRIVER_NAME; + } else if ( info->ChipFamily >= CHIP_FAMILY_R300 ) { dri2_info.driverName = R300_DRIVER_NAME; } else if ( info->ChipFamily >= CHIP_FAMILY_R200 ) { dri2_info.driverName = R200_DRIVER_NAME; diff --git a/src/radeon_driver.c b/src/radeon_driver.c index 7167ea0..563bc88 100644 --- a/src/radeon_driver.c +++ b/src/radeon_driver.c @@ -205,6 +206,7 @@ static const OptionInfoRec RADEONOptions[] = { { OPTION_FORCE_LOW_POWER, "ForceLowPowerMode", OPTV_BOOLEAN, {0}, FALSE }, { OPTION_DYNAMIC_PM, "DynamicPM", OPTV_BOOLEAN, {0}, FALSE }, { OPTION_NEW_PLL, "NewPLL", OPTV_BOOLEAN, {0}, FALSE }, + { OPTION_GALLIUM, "Gallium", OPTV_BOOLEAN, {0}, FALSE }, { OPTION_ZAPHOD_HEADS, "ZaphodHeads", OPTV_STRING, {0}, FALSE }, { -1, NULL, OPTV_NONE, {0}, FALSE } }; diff --git a/src/radeon_kms.c b/src/radeon_kms.c index c6a3df7..42b875e 100644 --- a/src/radeon_kms.c +++ b/src/radeon_kms.c @@ -69,6 +69,7 @@ const OptionInfoRec RADEONOptions_KMS[] = { { OPTION_TVSTD, "TVStandard", OPTV_STRING, {0}, FALSE }, { OPTION_EXA_VSYNC, "EXAVSync", OPTV_BOOLEAN, {0}, FALSE }, { OPTION_EXA_PIXMAPS, "EXAPixmaps", OPTV_BOOLEAN, {0}, FALSE }, + { OPTION_GALLIUM, "Gallium", OPTV_BOOLEAN, {0}, FALSE }, { OPTION_ZAPHOD_HEADS, "ZaphodHeads", OPTV_STRING, {0}, FALSE }, { -1, NULL, OPTV_NONE, {0}, FALSE } }; @@ -426,6 +427,7 @@ Bool RADEONPreInit_KMS(ScrnInfoPtr pScrn, int flags) DevUnion* pPriv; Gamma zeros = { 0.0, 0.0, 0.0 }; Bool colorTilingDefault; + Bool galliumAllowed; xf86DrvMsgVerb(pScrn->scrnIndex, X_INFO, RADEON_LOGLEVEL_DEBUG, "RADEONPreInit_KMS\n"); @@ -482,6 +484,18 @@ Bool RADEONPreInit_KMS(ScrnInfoPtr pScrn, int flags) if (!radeon_alloc_dri(pScrn)) return FALSE; + galliumAllowed = info->ChipFamily >= CHIP_FAMILY_R300 && + info->ChipFamily < CHIP_FAMILY_R600; + + info->useGallium = xf86ReturnOptValBool(info->Options, + OPTION_GALLIUM, FALSE); + + if (info->useGallium && !galliumAllowed) { + xf86DrvMsg(pScrn->scrnIndex, X_WARNING, "Gallium is not supported on this GPU, disabling\n"); + info->useGallium = FALSE; + } else if (info->useGallium) + xf86DrvMsg(pScrn->scrnIndex, X_INFO, "Using Gallium for DRI.\n"); + colorTilingDefault = info->ChipFamily >= CHIP_FAMILY_R300 && info->ChipFamily <= CHIP_FAMILY_RS740; diff --git a/src/radeon_version.h b/src/radeon_version.h index 129046d..d4c4fd5 100644 --- a/src/radeon_version.h +++ b/src/radeon_version.h @@ -37,6 +37,7 @@ #define RADEON_NAME "RADEON" #define RADEON_DRIVER_NAME "radeon" #define R200_DRIVER_NAME "r200" +#define R300G_DRIVER_NAME "radeong" #define R300_DRIVER_NAME "r300" #define R600_DRIVER_NAME "r600" --- a/man/radeon.man +++ b/man/radeon.man @@ -370,6 +370,13 @@ R/RV/RS2xx and RS3xx when usig XAA. The default is to .B enable Render acceleration. .TP +.BI "Option \*qGallium\*q \*q" boolean \*q +Enables or disables the usage of the alternate Gallium DRI driver +(radeong_dri.so). It is supported only on R300-R500 generation cards and +requires KMS/DRI2. This is considered a highly experimental option, don't use +it unless you know what you are doing. The default is +.B off. +.TP .BI "Option \*qAccelMethod\*q \*q" "string" \*q Chooses between available acceleration architectures. Valid options are .B XAA -- 1.7.1

2 1

[Bug 25198] [R6XX] : System hard hangs on launching OpenGL application
by bugzilla-daemon＠freedesktop.org 14 Jun '10

14 Jun '10

https://bugs.freedesktop.org/show_bug.cgi?id=25198 samit vats <hysvats(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #7 from samit vats <hysvats(a)gmail.com> 2010-06-14 03:00:15 PDT --- (In reply to comment #6) > (In reply to comment #5) > > You need kernel 2.6.32 for 3D support on r6xx/r7xx chips. > > > > The issue is the output of "glxinfo" ( "direct rendering: Yes" && "OpenGL > Vendor string: Advance Micro Devices,INC.") is misleading to the end user if 3D > support is not there for kernel version 2.6.31 and R6xx . > > It should clearly say direct rendering: No or Software rasterizer instead of > hard hanging the end user system. fixed with the latest kernel 2.6.32-21 and ddx xf86-video-ati-6.13.0 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 28522] New: power_profile auto consumes more power than power_profile high
by bugzilla-daemon＠freedesktop.org 14 Jun '10

14 Jun '10

https://bugs.freedesktop.org/show_bug.cgi?id=28522 Summary: power_profile auto consumes more power than power_profile high Product: DRI Version: unspecified Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/Radeon AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: Henning.Fleddermann(a)gmx.net Created an attachment (id=36247) --> (https://bugs.freedesktop.org/attachment.cgi?id=36247) my x1900xt's bios Kernel 2.6.35-rc3, Xorg-Server 1.8.1, xf86-video-ati 6.13.0 For some weird reason my system consumes ~15W more when I set the power_profile to auto, compared to all other power-profiles (low, default and high all consume the same amount of power). I measured this with a powermeter. "cat /debug/dri/0/radeon_pm_info" always says: default engine clock: 500000 kHz current engine clock: 499500 kHz default memory clock: 600000 kHz current memory clock: 594000 kHz PCIE lanes: 0 No matter which power_profile I select. My card is a ATi X1900XT. dileX_ on #radeon suggested that I attach my video-card bios, so I'll do that. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 1

[Bug 28154] New: [r300g] Freeorion crash when fleet icon is clicked
by bugzilla-daemon＠freedesktop.org 13 Jun '10

13 Jun '10

https://bugs.freedesktop.org/show_bug.cgi?id=28154 Summary: [r300g] Freeorion crash when fleet icon is clicked Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/r300 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: drakkk(a)centrum.cz Created an attachment (id=35723) --> (https://bugs.freedesktop.org/attachment.cgi?id=35723) terminal output Game Freeorion crash when clicking fleet icon: r300: Bad format r32g32_sscaled in r300_translate_vertex_data_type:419 r300: desc->channel[0].size == 32 r300_state_inlines.h:422:r300_translate_vertex_data_type: Assertion `0' failed. This works fine with r300c. 01:00.0 VGA compatible controller: ATI Technologies Inc M56P [Radeon Mobility X1600] mesa: 0f88ce1b0a98c7cacaa0dc53bbbb1f3c379aaa6a -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 15

[Bug 28399] New: Transparent windows look bad
by bugzilla-daemon＠freedesktop.org 12 Jun '10

12 Jun '10

https://bugs.freedesktop.org/show_bug.cgi?id=28399 Summary: Transparent windows look bad Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/r300 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: attila123456(a)gmail.com Created an attachment (id=36069) --> (https://bugs.freedesktop.org/attachment.cgi?id=36069) Classic mesa Ubuntu Lucid with latest xorg-edgers packages (+2.6.34 kernel), gallium enabled. Performance in general is much better than classic mesa, however, transparent windows and compiz effects look worse (see attached screenshots). Mesa version is 7.9.0+git20100604.89cb314f-0ubuntu0sarvatt~lucid Radeon Mobility x1300 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 2

[PATCH 1/2] drm/radeon/r200: handle more hw tex coord types
by Alex Deucher 12 Jun '10

12 Jun '10

From: Roland Scheidegger <sroland(a)vmware.com> Code did not handle projected 2d and depth coordinates, meaning potentially set 3d or cube special handling might stick. (Not sure what depth coord actually does, but I guess handling it like a normal coordinate is the right thing to do.) Might be related to https://bugs.freedesktop.org/show_bug.cgi?id=26428 Signed-off-by: sroland(a)vmware.com Signed-off-by: Alex Deucher <alexdeucher(a)gmail.com> Cc: stable <stable(a)kernel.org> --- drivers/gpu/drm/radeon/r200.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/radeon/r200.c b/drivers/gpu/drm/radeon/r200.c index a03f893..0266d72 100644 --- a/drivers/gpu/drm/radeon/r200.c +++ b/drivers/gpu/drm/radeon/r200.c @@ -415,6 +415,8 @@ int r200_packet0_check(struct radeon_cs_parser *p, /* 2D, 3D, CUBE */ switch (tmp) { case 0: + case 3: + case 4: case 5: case 6: case 7: -- 1.7.0.1

1 1

← Newer
1
...
13
14
15
16
17
18
19
...
24
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2010