dri-devel July 2010

dri-devel@lists.freedesktop.org

65 participants
269 discussions

[PATCH] drm/i810: fixed coding style issues
by Nicolas Kaiser 14 Jul '10

14 Jul '10

Fixed brace, macro and spacing coding style issues, and a C99 comment. Signed-off-by: Nicolas Kaiser <nikai(a)nikai.net> --- drivers/gpu/drm/i810/i810_dma.c | 81 ++++++++++++++++++-------------------- drivers/gpu/drm/i810/i810_drv.h | 64 ++++++++++++++++--------------- 2 files changed, 71 insertions(+), 74 deletions(-) diff --git a/drivers/gpu/drm/i810/i810_dma.c b/drivers/gpu/drm/i810/i810_dma.c index 997d917..09c86ed 100644 --- a/drivers/gpu/drm/i810/i810_dma.c +++ b/drivers/… [View More]gpu/drm/i810/i810_dma.c @@ -60,9 +60,8 @@ static struct drm_buf *i810_freelist_get(struct drm_device * dev) /* In use is already a pointer */ used = cmpxchg(buf_priv->in_use, I810_BUF_FREE, I810_BUF_CLIENT); - if (used == I810_BUF_FREE) { + if (used == I810_BUF_FREE) return buf; - } } return NULL; } @@ -71,7 +70,7 @@ static struct drm_buf *i810_freelist_get(struct drm_device * dev) * yet, the hardware updates in use for us once its on the ring buffer. */ -static int i810_freelist_put(struct drm_device * dev, struct drm_buf * buf) +static int i810_freelist_put(struct drm_device *dev, struct drm_buf *buf) { drm_i810_buf_priv_t *buf_priv = buf->dev_private; int used; @@ -121,7 +120,7 @@ static const struct file_operations i810_buffer_fops = { .fasync = drm_fasync, }; -static int i810_map_buffer(struct drm_buf * buf, struct drm_file *file_priv) +static int i810_map_buffer(struct drm_buf *buf, struct drm_file *file_priv) { struct drm_device *dev = file_priv->minor->dev; drm_i810_buf_priv_t *buf_priv = buf->dev_private; @@ -152,7 +151,7 @@ static int i810_map_buffer(struct drm_buf * buf, struct drm_file *file_priv) return retcode; } -static int i810_unmap_buffer(struct drm_buf * buf) +static int i810_unmap_buffer(struct drm_buf *buf) { drm_i810_buf_priv_t *buf_priv = buf->dev_private; int retcode = 0; @@ -172,7 +171,7 @@ static int i810_unmap_buffer(struct drm_buf * buf) return retcode; } -static int i810_dma_get_buffer(struct drm_device * dev, drm_i810_dma_t * d, +static int i810_dma_get_buffer(struct drm_device *dev, drm_i810_dma_t *d, struct drm_file *file_priv) { struct drm_buf *buf; @@ -202,7 +201,7 @@ static int i810_dma_get_buffer(struct drm_device * dev, drm_i810_dma_t * d, return retcode; } -static int i810_dma_cleanup(struct drm_device * dev) +static int i810_dma_cleanup(struct drm_device *dev) { struct drm_device_dma *dma = dev->dma; @@ -218,9 +217,8 @@ static int i810_dma_cleanup(struct drm_device * dev) drm_i810_private_t *dev_priv = (drm_i810_private_t *) dev->dev_private; - if (dev_priv->ring.virtual_start) { + if (dev_priv->ring.virtual_start) drm_core_ioremapfree(&dev_priv->ring.map, dev); - } if (dev_priv->hw_status_page) { pci_free_consistent(dev->pdev, PAGE_SIZE, dev_priv->hw_status_page, @@ -242,7 +240,7 @@ static int i810_dma_cleanup(struct drm_device * dev) return 0; } -static int i810_wait_ring(struct drm_device * dev, int n) +static int i810_wait_ring(struct drm_device *dev, int n) { drm_i810_private_t *dev_priv = dev->dev_private; drm_i810_ring_buffer_t *ring = &(dev_priv->ring); @@ -271,11 +269,11 @@ static int i810_wait_ring(struct drm_device * dev, int n) udelay(1); } - out_wait_ring: +out_wait_ring: return iters; } -static void i810_kernel_lost_context(struct drm_device * dev) +static void i810_kernel_lost_context(struct drm_device *dev) { drm_i810_private_t *dev_priv = dev->dev_private; drm_i810_ring_buffer_t *ring = &(dev_priv->ring); @@ -287,7 +285,7 @@ static void i810_kernel_lost_context(struct drm_device * dev) ring->space += ring->Size; } -static int i810_freelist_init(struct drm_device * dev, drm_i810_private_t * dev_priv) +static int i810_freelist_init(struct drm_device *dev, drm_i810_private_t *dev_priv) { struct drm_device_dma *dma = dev->dma; int my_idx = 24; @@ -322,9 +320,9 @@ static int i810_freelist_init(struct drm_device * dev, drm_i810_private_t * dev_ return 0; } -static int i810_dma_initialize(struct drm_device * dev, - drm_i810_private_t * dev_priv, - drm_i810_init_t * init) +static int i810_dma_initialize(struct drm_device *dev, + drm_i810_private_t *dev_priv, + drm_i810_init_t *init) { struct drm_map_list *r_list; memset(dev_priv, 0, sizeof(drm_i810_private_t)); @@ -462,7 +460,7 @@ static int i810_dma_init(struct drm_device *dev, void *data, * Use 'volatile' & local var tmp to force the emitted values to be * identical to the verified ones. */ -static void i810EmitContextVerified(struct drm_device * dev, +static void i810EmitContextVerified(struct drm_device *dev, volatile unsigned int *code) { drm_i810_private_t *dev_priv = dev->dev_private; @@ -495,7 +493,7 @@ static void i810EmitContextVerified(struct drm_device * dev, ADVANCE_LP_RING(); } -static void i810EmitTexVerified(struct drm_device * dev, volatile unsigned int *code) +static void i810EmitTexVerified(struct drm_device *dev, volatile unsigned int *code) { drm_i810_private_t *dev_priv = dev->dev_private; int i, j = 0; @@ -528,7 +526,7 @@ static void i810EmitTexVerified(struct drm_device * dev, volatile unsigned int * /* Need to do some additional checking when setting the dest buffer. */ -static void i810EmitDestVerified(struct drm_device * dev, +static void i810EmitDestVerified(struct drm_device *dev, volatile unsigned int *code) { drm_i810_private_t *dev_priv = dev->dev_private; @@ -563,7 +561,7 @@ static void i810EmitDestVerified(struct drm_device * dev, ADVANCE_LP_RING(); } -static void i810EmitState(struct drm_device * dev) +static void i810EmitState(struct drm_device *dev) { drm_i810_private_t *dev_priv = dev->dev_private; drm_i810_sarea_t *sarea_priv = dev_priv->sarea_priv; @@ -594,7 +592,7 @@ static void i810EmitState(struct drm_device * dev) /* need to verify */ -static void i810_dma_dispatch_clear(struct drm_device * dev, int flags, +static void i810_dma_dispatch_clear(struct drm_device *dev, int flags, unsigned int clear_color, unsigned int clear_zval) { @@ -669,7 +667,7 @@ static void i810_dma_dispatch_clear(struct drm_device * dev, int flags, } } -static void i810_dma_dispatch_swap(struct drm_device * dev) +static void i810_dma_dispatch_swap(struct drm_device *dev) { drm_i810_private_t *dev_priv = dev->dev_private; drm_i810_sarea_t *sarea_priv = dev_priv->sarea_priv; @@ -715,8 +713,8 @@ static void i810_dma_dispatch_swap(struct drm_device * dev) } } -static void i810_dma_dispatch_vertex(struct drm_device * dev, - struct drm_buf * buf, int discard, int used) +static void i810_dma_dispatch_vertex(struct drm_device *dev, + struct drm_buf *buf, int discard, int used) { drm_i810_private_t *dev_priv = dev->dev_private; drm_i810_buf_priv_t *buf_priv = buf->dev_private; @@ -795,7 +793,7 @@ static void i810_dma_dispatch_vertex(struct drm_device * dev, } } -static void i810_dma_dispatch_flip(struct drm_device * dev) +static void i810_dma_dispatch_flip(struct drm_device *dev) { drm_i810_private_t *dev_priv = dev->dev_private; int pitch = dev_priv->pitch; @@ -841,7 +839,7 @@ static void i810_dma_dispatch_flip(struct drm_device * dev) } -static void i810_dma_quiescent(struct drm_device * dev) +static void i810_dma_quiescent(struct drm_device *dev) { drm_i810_private_t *dev_priv = dev->dev_private; RING_LOCALS; @@ -858,7 +856,7 @@ static void i810_dma_quiescent(struct drm_device * dev) i810_wait_ring(dev, dev_priv->ring.Size - 8); } -static int i810_flush_queue(struct drm_device * dev) +static int i810_flush_queue(struct drm_device *dev) { drm_i810_private_t *dev_priv = dev->dev_private; struct drm_device_dma *dma = dev->dma; @@ -891,7 +889,7 @@ static int i810_flush_queue(struct drm_device * dev) } /* Must be called with the lock held */ -static void i810_reclaim_buffers(struct drm_device * dev, +static void i810_reclaim_buffers(struct drm_device *dev, struct drm_file *file_priv) { struct drm_device_dma *dma = dev->dma; @@ -969,9 +967,8 @@ static int i810_clear_bufs(struct drm_device *dev, void *data, LOCK_TEST_WITH_RETURN(dev, file_priv); /* GH: Someone's doing nasty things... */ - if (!dev->dev_private) { + if (!dev->dev_private) return -EINVAL; - } i810_dma_dispatch_clear(dev, clear->flags, clear->clear_color, clear->clear_depth); @@ -1039,7 +1036,7 @@ static int i810_docopy(struct drm_device *dev, void *data, return 0; } -static void i810_dma_dispatch_mc(struct drm_device * dev, struct drm_buf * buf, int used, +static void i810_dma_dispatch_mc(struct drm_device *dev, struct drm_buf *buf, int used, unsigned int last_render) { drm_i810_private_t *dev_priv = dev->dev_private; @@ -1053,9 +1050,8 @@ static void i810_dma_dispatch_mc(struct drm_device * dev, struct drm_buf * buf, i810_kernel_lost_context(dev); u = cmpxchg(buf_priv->in_use, I810_BUF_CLIENT, I810_BUF_HARDWARE); - if (u != I810_BUF_CLIENT) { + if (u != I810_BUF_CLIENT) DRM_DEBUG("MC found buffer that isn't mine!\n"); - } if (used > 4 * 1024) used = 0; @@ -1160,7 +1156,7 @@ static int i810_ov0_flip(struct drm_device *dev, void *data, LOCK_TEST_WITH_RETURN(dev, file_priv); - //Tell the overlay to update + /* Tell the overlay to update */ I810_WRITE(0x30000, dev_priv->overlay_physical | 0x80000000); return 0; @@ -1168,7 +1164,7 @@ static int i810_ov0_flip(struct drm_device *dev, void *data, /* Not sure why this isn't set all the time: */ -static void i810_do_init_pageflip(struct drm_device * dev) +static void i810_do_init_pageflip(struct drm_device *dev) { drm_i810_private_t *dev_priv = dev->dev_private; @@ -1178,7 +1174,7 @@ static void i810_do_init_pageflip(struct drm_device * dev) dev_priv->sarea_priv->pf_current_page = dev_priv->current_page; } -static int i810_do_cleanup_pageflip(struct drm_device * dev) +static int i810_do_cleanup_pageflip(struct drm_device *dev) { drm_i810_private_t *dev_priv = dev->dev_private; @@ -1218,28 +1214,27 @@ int i810_driver_load(struct drm_device *dev, unsigned long flags) return 0; } -void i810_driver_lastclose(struct drm_device * dev) +void i810_driver_lastclose(struct drm_device *dev) { i810_dma_cleanup(dev); } -void i810_driver_preclose(struct drm_device * dev, struct drm_file *file_priv) +void i810_driver_preclose(struct drm_device *dev, struct drm_file *file_priv) { if (dev->dev_private) { drm_i810_private_t *dev_priv = dev->dev_private; - if (dev_priv->page_flipping) { + if (dev_priv->page_flipping) i810_do_cleanup_pageflip(dev); - } } } -void i810_driver_reclaim_buffers_locked(struct drm_device * dev, +void i810_driver_reclaim_buffers_locked(struct drm_device *dev, struct drm_file *file_priv) { i810_reclaim_buffers(dev, file_priv); } -int i810_driver_dma_quiescent(struct drm_device * dev) +int i810_driver_dma_quiescent(struct drm_device *dev) { i810_dma_quiescent(dev); return 0; @@ -1276,7 +1271,7 @@ int i810_max_ioctl = DRM_ARRAY_SIZE(i810_ioctls); * \returns * A value of 1 is always retured to indictate every i810 is AGP. */ -int i810_driver_device_is_agp(struct drm_device * dev) +int i810_driver_device_is_agp(struct drm_device *dev) { return 1; } diff --git a/drivers/gpu/drm/i810/i810_drv.h b/drivers/gpu/drm/i810/i810_drv.h index 21e2691..0743fe9 100644 --- a/drivers/gpu/drm/i810/i810_drv.h +++ b/drivers/gpu/drm/i810/i810_drv.h @@ -115,16 +115,16 @@ typedef struct drm_i810_private { } drm_i810_private_t; /* i810_dma.c */ -extern int i810_driver_dma_quiescent(struct drm_device * dev); -extern void i810_driver_reclaim_buffers_locked(struct drm_device * dev, +extern int i810_driver_dma_quiescent(struct drm_device *dev); +extern void i810_driver_reclaim_buffers_locked(struct drm_device *dev, struct drm_file *file_priv); extern int i810_driver_load(struct drm_device *, unsigned long flags); -extern void i810_driver_lastclose(struct drm_device * dev); -extern void i810_driver_preclose(struct drm_device * dev, +extern void i810_driver_lastclose(struct drm_device *dev); +extern void i810_driver_preclose(struct drm_device *dev, struct drm_file *file_priv); -extern void i810_driver_reclaim_buffers_locked(struct drm_device * dev, +extern void i810_driver_reclaim_buffers_locked(struct drm_device *dev, struct drm_file *file_priv); -extern int i810_driver_device_is_agp(struct drm_device * dev); +extern int i810_driver_device_is_agp(struct drm_device *dev); extern struct drm_ioctl_desc i810_ioctls[]; extern int i810_max_ioctl; @@ -132,39 +132,41 @@ extern int i810_max_ioctl; #define I810_BASE(reg) ((unsigned long) \ dev_priv->mmio_map->handle) #define I810_ADDR(reg) (I810_BASE(reg) + reg) -#define I810_DEREF(reg) *(__volatile__ int *)I810_ADDR(reg) +#define I810_DEREF(reg) (*(__volatile__ int *)I810_ADDR(reg)) #define I810_READ(reg) I810_DEREF(reg) -#define I810_WRITE(reg,val) do { I810_DEREF(reg) = val; } while (0) -#define I810_DEREF16(reg) *(__volatile__ u16 *)I810_ADDR(reg) +#define I810_WRITE(reg, val) do { I810_DEREF(reg) = val; } while (0) +#define I810_DEREF16(reg) (*(__volatile__ u16 *)I810_ADDR(reg)) #define I810_READ16(reg) I810_DEREF16(reg) -#define I810_WRITE16(reg,val) do { I810_DEREF16(reg) = val; } while (0) +#define I810_WRITE16(reg, val) do { I810_DEREF16(reg) = val; } while (0) #define I810_VERBOSE 0 #define RING_LOCALS unsigned int outring, ringmask; \ - volatile char *virt; - -#define BEGIN_LP_RING(n) do { \ - if (I810_VERBOSE) \ - DRM_DEBUG("BEGIN_LP_RING(%d)\n", n); \ - if (dev_priv->ring.space < n*4) \ - i810_wait_ring(dev, n*4); \ - dev_priv->ring.space -= n*4; \ - outring = dev_priv->ring.tail; \ - ringmask = dev_priv->ring.tail_mask; \ - virt = dev_priv->ring.virtual_start; \ + volatile char *virt; + +#define BEGIN_LP_RING(n) do { \ + if (I810_VERBOSE) \ + DRM_DEBUG("BEGIN_LP_RING(%d)\n", n); \ + if (dev_priv->ring.space < n*4) \ + i810_wait_ring(dev, n*4); \ + dev_priv->ring.space -= n*4; \ + outring = dev_priv->ring.tail; \ + ringmask = dev_priv->ring.tail_mask; \ + virt = dev_priv->ring.virtual_start; \ } while (0) -#define ADVANCE_LP_RING() do { \ - if (I810_VERBOSE) DRM_DEBUG("ADVANCE_LP_RING\n"); \ +#define ADVANCE_LP_RING() do { \ + if (I810_VERBOSE) \ + DRM_DEBUG("ADVANCE_LP_RING\n"); \ dev_priv->ring.tail = outring; \ - I810_WRITE(LP_RING + RING_TAIL, outring); \ -} while(0) - -#define OUT_RING(n) do { \ - if (I810_VERBOSE) DRM_DEBUG(" OUT_RING %x\n", (int)(n)); \ - *(volatile unsigned int *)(virt + outring) = n; \ - outring += 4; \ - outring &= ringmask; \ + I810_WRITE(LP_RING + RING_TAIL, outring); \ +} while (0) + +#define OUT_RING(n) do { \ + if (I810_VERBOSE) \ + DRM_DEBUG(" OUT_RING %x\n", (int)(n)); \ + *(volatile unsigned int *)(virt + outring) = n; \ + outring += 4; \ + outring &= ringmask; \ } while (0) #define GFX_OP_USER_INTERRUPT ((0<<29)|(2<<23)) -- 1.7.1 [View Less]

1 0

drm: refresh rate down to 60 Hz in 2.6.35-rc5
by Sven Joachim 14 Jul '10

14 Jul '10

[ Resending to the right mailing list. I looked up in MAINTAINERS, but forgot to run "git bisect reset" and got the wrong address for dri-devel@. Apologies to all who receive this twice. ] After upgrading to 2.6.35-rc5, I noticed that my monitor reports a refresh rate of 60 Hz when nouveau.ko is loaded, rather than the 75 Hz I got on 2.6.34. Graphics card is an NV86 (GeForce 8500 GT), the monitor is a 1280x1024 TFT (Yakumo 19AL) connected via VGA. I bisected this to the following … [View More]

1 0

[Bug 29047] New: [r300g] Unknown opcode DDX with RV350
by bugzilla-daemon＠freedesktop.org 14 Jul '10

14 Jul '10

https://bugs.freedesktop.org/show_bug.cgi?id=29047 Summary: [r300g] Unknown opcode DDX with RV350 Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/r300 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: rankincj(a)googlemail.com Output from piglit's glsl-derivs program: r300 FP: Compiler … [View More]

1 2

[PATCH] drm/radeon/kms: fix possible mis-detection of sideport on rs690/rs740
by Alex Deucher 13 Jul '10

13 Jul '10

Check ulBootUpMemoryClock on AMD IGPs. Fix regression noticed by Torsten Kaiser <just.for.lkml(a)googlemail.com> Signed-off-by: Alex Deucher <alexdeucher(a)gmail.com> Cc: stable(a)kernel.org --- drivers/gpu/drm/radeon/radeon_atombios.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c index 5dd86b9..3f89c9b 100644 --- a/drivers/gpu/drm/radeon/radeon_atombios.c +++ … [View More]

1 0

[RFC] flink_to
by Kristian Høgsberg 13 Jul '10

13 Jul '10

[ Let's try this again... ] Ok, so the flink_to discussion rat-holed a bit on the binary blob attachment issue. But before we even get to that, there are a lot of issues that I'd some feedback on as well. There were a few bugs in the patch that I've fixed, but I don't see the point in sending it out again just yet, as I'd like to see if we can agree on some of the higher level issues. First of, I'm hoping we can get this ready for the next merge window. The patch is written and I've tested … [View More]it here with a libdrm test case and am currently finishing the EGL support for this. One change I might want to do is to add a blob type argument to the ioctls so userspace has a standardized way of indication what the format of the data is (what Keith pointed out). That's a fairly simple change and the patch itself is simple enough to begin with, so I don't expect a lot of tricky issues with the implementation. Along with the flink_to ioctl, I'm proposing that we drop the DRM_AUTH requirement for accessing the gem ioctls. Specifically, for intel, I'm suggesting that we drop the DRM_AUTH requirement on DRM_IOCTL_GEM_FLINK, DRM_IOCTL_GEM_OPEN, DRM_I915_GEM_EXECBUFFER, DRM_I915_GEM_EXECBUFFER2, DRM_I915_GEM_BUSY, DRM_I915_GEM_THROTTLE, DRM_I915_GEM_CREATE, DRM_I915_GEM_PREAD, DRM_I915_GEM_PWRITE, DRM_I915_GEM_MMAP, DRM_I915_GEM_MMAP_GTT, DRM_I915_GEM_SET_DOMAIN, DRM_I915_GEM_SW_FINISH, DRM_I915_GEM_SET_TILING, DRM_I915_GEM_GET_TILING, DRM_I915_GEM_GET_APERTURE, DRM_I915_GEM_MADVISE, which should allow clients to create buffers, submit rendering against them and share them with a priviledged (in the sense that it controls scanout) display server. Access to these ioctls will then only be guarded by the permissions on /dev/dri/cardX, which all distros restrict to the 'local' user (that is, excluding ssh and similar) in one way or another. How do we feel about that? Maybe it's something the master needs to request, so that only X servers that use flink_to will activate this mode? flink_to doesn't in itself solve the security problem, since user space can still submit a batch buffer that reads or writes to an absolute gtt offset (that is, no relocation). The X front buffer location is typically pretty predictable, for example. flink_to does give us the infrastructure to implement a secure system though. There are several ways this could be done: use a sw command checker to reject absolute gtt offsets, unbind buffers from all other clients before running executing the commands or use per-process gtt or similar hw support. Then there's the data passing mechanism part of flink_to. I'm suggesting that we allow applications to attach a blob to an flink_to name, which will be passed to the process calling open_with_data on the name. The format of the blob is defined by userspace, typically libdrm or mesa, and lets us marshal meta data about the buffer along with granting access to the buffer. And just to be clear, the kernel has no need for this meta data, it doesn't even understand the format. But it will make protocoles and user level APIs simpler, and it's not going to be a resource drain in the kernel. There's a 2k max size on the attached data, and a buffer can only have one flink_to name pending per file_priv. I didn't see any strong objections in the thread, but I understand the concerns. We're debating a minimal kernel API with a kludgey userspace vs kernel API with convenience features and much simpler userspace. Anyway, I'll post an update when I get a working userspace on top of this proposal. In the meantime I would much appreciate feedback on the above issues. Kristian [View Less]

3 3

[Bug 27219] drm-radeon-testing branch bisected: Radeon xpress 200m freezes while booting
by bugzilla-daemon＠freedesktop.org 13 Jul '10

13 Jul '10

https://bugs.freedesktop.org/show_bug.cgi?id=27219 Alex Deucher <agd5f(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29044 | -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 27219] drm-radeon-testing branch bisected: Radeon xpress 200m freezes while booting
by bugzilla-daemon＠freedesktop.org 13 Jul '10

13 Jul '10

https://bugs.freedesktop.org/show_bug.cgi?id=27219 Ian Romanick <idr(a)freedesktop.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29044 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 28402] Kernel 2.6.34 freezes randomly
by bugzilla-daemon＠freedesktop.org 13 Jul '10

13 Jul '10

https://bugs.freedesktop.org/show_bug.cgi?id=28402 mrsteven(a)gmx.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrsteven(a)gmx.de --- Comment #9 from mrsteven(a)gmx.de 2010-07-13 05:26:49 PDT --- I seem to have the same problem, see https://bugs.freedesktop.org/show_bug.cgi?id=23660#c23 GPU is the same, I also had the problem with the non-KMS … [View More]

1 0

[Bug 29023] New: [r300g] Stellarium screen is black
by bugzilla-daemon＠freedesktop.org 13 Jul '10

13 Jul '10

https://bugs.freedesktop.org/show_bug.cgi?id=29023 Summary: [r300g] Stellarium screen is black Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: major Priority: medium Component: Drivers/DRI/r300 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: jlp.bugs(a)gmail.com After a recent update of mesa from git Stellarium screen stays … [View More]

1 2

Unit initialization infrastructure
by Jerome Glisse 12 Jul '10

12 Jul '10

So here is something i have been thinking on for a while and never get around to actually code it until recently. I needed|wanted it as i was working on improved GPU reset. Issue i faced is that despite trying hard to make clean code reusable btw asic we ended up with some messy code path (especially in error path) and you basicly have to write for each asic a special function handling initialization+ finalization add 2 other for suspend/resume and finaly add one for reset and one for power … [View More]management. So the idea of unit is to give each unit a set of function : init,fini,suspend,resume,hold,unhold Unit are things like : CP, MC, MemoryManager, GEM, CLK, ... Now instead of writing one init/fini/suspend/resume function you just provide for each asic the following : struct radeon_unit_funcs *r100_units[] = { »······&r100_unit_errata, »······&r100_unit_vga, »······&r100_unit_common, »······&radeon_unit_scratch, »······&radeon_unit_sr, »······&radeon_unit_surface, »······&radeon_unit_reset, »······&radeon_unit_bios, »······&r100_unit_clock, »······&r100_unit_mc, »······&radeon_unit_fence, »······&radeon_unit_irq, »······&radeon_unit_mm, »······&radeon_unit_agp, »······&r100_unit_gart, »······&r100_unit_irq, »······&radeon_unit_gem, »······&r100_unit_cs, »······&r100_unit_cp, »······&r100_unit_ib, »······NULL }; and a common helper function just go through the list and init each unit, for fini it goes in reverse order. resume/suspend are like init/fini, suspend goes in reverse order while resume goes in normal order radeon_unit_sr is a fake helper unit just to know from which point you start/end suspend/resume, same for radeon_unit_reset So with that approach i think it's lot easier to figure out dependency btw unit and in which order things get call. I think it will help to untangle some of the code path that are tricky today to follow. Thought there is a downside any change like this is likely to introduce regression and i hate those like others, anyway i think the longterm benefit are greater than the temporary disturbance we can even have the unit path coexist with current code and allow it to stabilize on its own before switching over and removing old path. So before i go any further what is your opinion on this ? Attached is a patch which shows the approach for r100/r200 asic (tested and it works) as you can see it can be done without touching the old path and we can also add an option to select btw old/new path. Cheers, Jerome [View Less]

3 2

← Newer
1
...
17
18
19
20
21
22
23
...
27
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel July 2010