dri-devel July 2010

dri-devel@lists.freedesktop.org

65 participants
269 discussions

Closed source userspace graphics drivers with an open source kernel component
by Dave Airlie 04 Jul '10

04 Jul '10

Now this is just my opinion as maintainer of the drm, and doesn't reflect anyone or any official policy, I've also no idea if Linus agrees or not. We are going to start to see a number of companies in the embedded space submitting 3D drivers for mobile devices to the kernel. I'd like to clarify my position once so they don't all come asking the same questions. If you aren't going to create an open userspace driver (either MIT or LGPL) then don't waste time submitting a kernel driver to me. My reasons are as follows, the thing is you can probably excuse some of these on a point by point basis, but you need to justify why closed userspace on all points. a) licensing, Alan Cox pointed this out before, if you wrote a GPL kernel driver, then wrote a closed userspace on top, you open up a while world of derived work issues. Can the userspace operate on a non-GPL kernel without major modifications etc. This is a can of worms I'd rather not enter into, and there are a few workarounds. b) verifying the sanity of the userspace API. 1. Security: GPUs can do a lot of damage if left at home alone, since mostly you are submitting command streams unverified into the GPU and won't tell us what they mean, there is little way we can work out if the GPU is going to over-write my passwd file to get 5 fps more in quake. Now newer GPUs have at least started having MMUs, but again we've no idea if that is the only way they work without docs or a lot of trust. 2. General API suitability and versioning. How do we check that API is sane wrt to userspace, if we can't verify the userspace. What happens if the API has lots of 32/64 compat issues or things like that, and when we fix them the binary userspace breaks? How do we know, how do we test etc. What happens if a security issue forces us to break the userspace API? how do we fix the userspace driver and test to confirm? c) supplying docs in lieu of an open userspace If you were to fully document the GPU so we could verify the security/api aspects it leaves us in the position of writing our own driver. Now writing that driver on top of the current kernel driver would probably limit any innovation, and most people would want to write a new kernel driver from scratch. Now we end up with two drivers fighting, how do we pick which one to load at boot? can we ever do a generic distro kernel for that device (assuming ARM ever solves that issue). I've also noticed a trend to just reinvent the whole wheel instead of writing a drm/kms driver and having that as the API, again maintainer nightmares are made of this. Dave.

15 29

Documentation of DRM's API?
by Rafał Miłecki 04 Jul '10

04 Jul '10

Hi, While it's quite easy to track initialization of existing KMS drivers (plus we have http://www.botchco.com/agd5f/?p=50) I am not sure where to find documentation of API. I know driver has to register some outputs/encoders/transmitters related functions that will perform querying and setting. Is this possible to get some info about this? I'm sure there are some functions that are required and other that are optional (like DPMS vs. disable?). I saw there is something like Documentation/DocBook/drm.tmpl but can not use it: # make pdfdocs (...) (/usr/share/texmf/tex/latex/psnfss/t1phv.fd) (/usr/share/texmf/tex/latex/psnfss/t1pcr.fd) [1{/var/lib/texmf/fonts/map/pdftex /updmap/pdftex.map}] (/usr/share/texmf/tex/latex/psnfss/ts1ptm.fd) ! Missing number, treated as zero. <to be read again> p l.225 /> </fo:block></fo:block></fo:flow></fo:page-sequence><fo:page-sequence... ? ! Emergency stop. <to be read again> p l.225 /> </fo:block></fo:block></fo:flow></fo:page-sequence><fo:page-sequence... ! ==> Fatal error occurred, no output PDF file produced! Transcript written on tmp.log. make[1]: *** [Documentation/DocBook/z8530book.pdf] Błąd 1 make: *** [pdfdocs] Błąd 2 Is there any other place to look for docs? -- Rafał

2 4

[Bug 28774] New: RS780: No picture over HDMI
by bugzilla-daemon＠freedesktop.org 04 Jul '10

04 Jul '10

https://bugs.freedesktop.org/show_bug.cgi?id=28774 Summary: RS780: No picture over HDMI Product: DRI Version: XOrg CVS Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: DRM/Radeon AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: zajec5(a)gmail.com This is netbook MSI U230 with RS780 using drm-radeon-testing. When I connect TV using HDMI I can see it's resolutions in xrandr and even enabling it seems to work fine (1920x1080 is selected, my desktop expands) but there is nothing displayed on TV. I've tried KMS radeon, DDX radeon, DDX radeonhd. Same result for each. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 13

[PATCH] drm/ttm: Allocate the page pool manager in the heap.
by Francisco Jerez 04 Jul '10

04 Jul '10

Repeated ttm_page_alloc_init/fini fails noisily because the pool manager kobj isn't zeroed out between uses (we could do just that but statically allocated kobjects are generally considered a bad thing). Move it to kzalloc'ed memory. Note that this patch drops the refcounting behavior of the pool allocator init/fini functions: it would have led to a race condition in its current form, and anyway it was never exploited. Signed-off-by: Francisco Jerez <currojerez(a)riseup.net> --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 68 ++++++++++++++++----------------- include/drm/ttm/ttm_page_alloc.h | 4 -- 2 files changed, 33 insertions(+), 39 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index ef91069..fc68a66 100644 --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c @@ -104,7 +104,6 @@ struct ttm_pool_opts { struct ttm_pool_manager { struct kobject kobj; struct shrinker mm_shrink; - atomic_t page_alloc_inited; struct ttm_pool_opts options; union { @@ -142,7 +141,7 @@ static void ttm_pool_kobj_release(struct kobject *kobj) { struct ttm_pool_manager *m = container_of(kobj, struct ttm_pool_manager, kobj); - (void)m; + kfree(m); } static ssize_t ttm_pool_store(struct kobject *kobj, @@ -214,9 +213,7 @@ static struct kobj_type ttm_pool_kobj_type = { .default_attrs = ttm_pool_attrs, }; -static struct ttm_pool_manager _manager = { - .page_alloc_inited = ATOMIC_INIT(0) -}; +static struct ttm_pool_manager *_manager; #ifndef CONFIG_X86 static int set_pages_array_wb(struct page **pages, int addrinarray) @@ -271,7 +268,7 @@ static struct ttm_page_pool *ttm_get_pool(int flags, if (flags & TTM_PAGE_FLAG_DMA32) pool_index |= 0x2; - return &_manager.pools[pool_index]; + return &_manager->pools[pool_index]; } /* set memory back to wb and free the pages. */ @@ -387,7 +384,7 @@ static int ttm_pool_get_num_unused_pages(void) unsigned i; int total = 0; for (i = 0; i < NUM_POOLS; ++i) - total += _manager.pools[i].npages; + total += _manager->pools[i].npages; return total; } @@ -408,7 +405,7 @@ static int ttm_pool_mm_shrink(int shrink_pages, gfp_t gfp_mask) unsigned nr_free = shrink_pages; if (shrink_pages == 0) break; - pool = &_manager.pools[(i + pool_offset)%NUM_POOLS]; + pool = &_manager->pools[(i + pool_offset)%NUM_POOLS]; shrink_pages = ttm_page_pool_free(pool, nr_free); } /* return estimated number of unused pages in pool */ @@ -576,10 +573,10 @@ static void ttm_page_pool_fill_locked(struct ttm_page_pool *pool, /* If allocation request is small and there is not enough * pages in pool we fill the pool first */ - if (count < _manager.options.small + if (count < _manager->options.small && count > pool->npages) { struct list_head new_pages; - unsigned alloc_size = _manager.options.alloc_size; + unsigned alloc_size = _manager->options.alloc_size; /** * Can't change page caching if in irqsave context. We have to @@ -759,8 +756,8 @@ void ttm_put_pages(struct list_head *pages, unsigned page_count, int flags, pool->npages += page_count; /* Check that we don't go over the pool limit */ page_count = 0; - if (pool->npages > _manager.options.max_size) { - page_count = pool->npages - _manager.options.max_size; + if (pool->npages > _manager->options.max_size) { + page_count = pool->npages - _manager->options.max_size; /* free at least NUM_PAGES_TO_ALLOC number of pages * to reduce calls to set_memory_wb */ if (page_count < NUM_PAGES_TO_ALLOC) @@ -785,33 +782,36 @@ static void ttm_page_pool_init_locked(struct ttm_page_pool *pool, int flags, int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages) { int ret; - if (atomic_add_return(1, &_manager.page_alloc_inited) > 1) - return 0; + + WARN_ON(_manager); printk(KERN_INFO TTM_PFX "Initializing pool allocator.\n"); - ttm_page_pool_init_locked(&_manager.wc_pool, GFP_HIGHUSER, "wc"); + _manager = kzalloc(sizeof(*_manager), GFP_KERNEL); - ttm_page_pool_init_locked(&_manager.uc_pool, GFP_HIGHUSER, "uc"); + ttm_page_pool_init_locked(&_manager->wc_pool, GFP_HIGHUSER, "wc"); - ttm_page_pool_init_locked(&_manager.wc_pool_dma32, GFP_USER | GFP_DMA32, - "wc dma"); + ttm_page_pool_init_locked(&_manager->uc_pool, GFP_HIGHUSER, "uc"); - ttm_page_pool_init_locked(&_manager.uc_pool_dma32, GFP_USER | GFP_DMA32, - "uc dma"); + ttm_page_pool_init_locked(&_manager->wc_pool_dma32, + GFP_USER | GFP_DMA32, "wc dma"); - _manager.options.max_size = max_pages; - _manager.options.small = SMALL_ALLOCATION; - _manager.options.alloc_size = NUM_PAGES_TO_ALLOC; + ttm_page_pool_init_locked(&_manager->uc_pool_dma32, + GFP_USER | GFP_DMA32, "uc dma"); - kobject_init(&_manager.kobj, &ttm_pool_kobj_type); - ret = kobject_add(&_manager.kobj, &glob->kobj, "pool"); + _manager->options.max_size = max_pages; + _manager->options.small = SMALL_ALLOCATION; + _manager->options.alloc_size = NUM_PAGES_TO_ALLOC; + + ret = kobject_init_and_add(&_manager->kobj, &ttm_pool_kobj_type, + &glob->kobj, "pool"); if (unlikely(ret != 0)) { - kobject_put(&_manager.kobj); + kobject_put(&_manager->kobj); + _manager = NULL; return ret; } - ttm_pool_mm_shrink_init(&_manager); + ttm_pool_mm_shrink_init(_manager); return 0; } @@ -820,16 +820,14 @@ void ttm_page_alloc_fini() { int i; - if (atomic_sub_return(1, &_manager.page_alloc_inited) > 0) - return; - printk(KERN_INFO TTM_PFX "Finalizing pool allocator.\n"); - ttm_pool_mm_shrink_fini(&_manager); + ttm_pool_mm_shrink_fini(_manager); for (i = 0; i < NUM_POOLS; ++i) - ttm_page_pool_free(&_manager.pools[i], FREE_ALL_PAGES); + ttm_page_pool_free(&_manager->pools[i], FREE_ALL_PAGES); - kobject_put(&_manager.kobj); + kobject_put(&_manager->kobj); + _manager = NULL; } int ttm_page_alloc_debugfs(struct seq_file *m, void *data) @@ -837,14 +835,14 @@ int ttm_page_alloc_debugfs(struct seq_file *m, void *data) struct ttm_page_pool *p; unsigned i; char *h[] = {"pool", "refills", "pages freed", "size"}; - if (atomic_read(&_manager.page_alloc_inited) == 0) { + if (!_manager) { seq_printf(m, "No pool allocator running.\n"); return 0; } seq_printf(m, "%6s %12s %13s %8s\n", h[0], h[1], h[2], h[3]); for (i = 0; i < NUM_POOLS; ++i) { - p = &_manager.pools[i]; + p = &_manager->pools[i]; seq_printf(m, "%6s %12ld %13ld %8d\n", p->name, p->nrefills, diff --git a/include/drm/ttm/ttm_page_alloc.h b/include/drm/ttm/ttm_page_alloc.h index 8bb4de5..1168214 100644 --- a/include/drm/ttm/ttm_page_alloc.h +++ b/include/drm/ttm/ttm_page_alloc.h @@ -56,10 +56,6 @@ void ttm_put_pages(struct list_head *pages, enum ttm_caching_state cstate); /** * Initialize pool allocator. - * - * Pool allocator is internaly reference counted so it can be initialized - * multiple times but ttm_page_alloc_fini has to be called same number of - * times. */ int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages); /** -- 1.6.4.4

1 0

[Bug 23545] flashing textures in some maps of sauerbraten game
by bugzilla-daemon＠freedesktop.org 04 Jul '10

04 Jul '10

https://bugs.freedesktop.org/show_bug.cgi?id=23545 maximlevitsky(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME --- Comment #11 from maximlevitsky(a)gmail.com 2010-07-03 18:48:20 PDT --- I am closing this, and in my case, textures just appear and disapper, but don't flash with color. Other that that, this is similiar to https://bugs.freedesktop.org/show_bug.cgi?id=25027 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

hardware implementation of Xorg
by Piotr Gluszenia Slawinski 03 Jul '10

03 Jul '10

Hello. While i've been thinking about open-hardware alternatives for Xorg , i started to wonder about if it isn't already time to implement Xorg purely in hardware, i.e. set of FPGA chips. one can find many nice examples of functional 8bit systems able to fit into single chips (i.e. http://zxgate.sourceforge.net/ ) ofcourse at current state of technology Xorg will be unable to fit single chip, yet it's current modular nature and fact that it's (still) completely open-source, and uses pieces of system which are also open-source developed (i.e. http://wiki.opengraphics.org/ ) there are ofcourse C to verilog converters, and almost whole process (except prototyping) could be automated. do you think it is time for it now, or it's better to wait few years until Xorg will reach enough stability, and Xorg foundation will be able to afford fabbing it's own , non-fpga chips ? did anyone already performed any evaluations on how power-efficient such chips could be? perhaps mobile market could use them as more convient alternative to cpu+gpu hybrids, esp. for devices without heavy 3d, ultra-high-resolution, and multihead capability... --

2 2

[Bug 28430] [865G] OOPS when stolen memory set to zero
by bugzilla-daemon＠freedesktop.org 01 Jul '10

01 Jul '10

https://bugs.freedesktop.org/show_bug.cgi?id=28430 Jesse Barnes <jbarnes(a)virtuousgeek.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jbarnes(a)virtuousgeek.org |dri-devel(a)lists.freedesktop | |.org -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 28509] [852] gpu hang
by bugzilla-daemon＠freedesktop.org 01 Jul '10

01 Jul '10

https://bugs.freedesktop.org/show_bug.cgi?id=28509 Jesse Barnes <jbarnes(a)virtuousgeek.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jbarnes(a)virtuousgeek.org |dri-devel(a)lists.freedesktop | |.org -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 26326] [855] Xserver freezing on Toshiba Satellite A10
by bugzilla-daemon＠freedesktop.org 01 Jul '10

01 Jul '10

https://bugs.freedesktop.org/show_bug.cgi?id=26326 Jesse Barnes <jbarnes(a)virtuousgeek.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jbarnes(a)virtuousgeek.org |dri-devel(a)lists.freedesktop | |.org -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 27541] [830M] [KMS] internal display goes nuts during boot
by bugzilla-daemon＠freedesktop.org 01 Jul '10

01 Jul '10

https://bugs.freedesktop.org/show_bug.cgi?id=27541 Jesse Barnes <jbarnes(a)virtuousgeek.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jbarnes(a)virtuousgeek.org |dri-devel(a)lists.freedesktop | |.org -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel July 2010