dri-devel August 2010

dri-devel@lists.freedesktop.org

82 participants
335 discussions

[patch] i915: remove unneed NULL checks
by Dan Carpenter 23 Aug '10

23 Aug '10

We don't need to check the list cursor in a list_for_each_entry(). It's always non-null. Signed-off-by: Dan Carpenter <error27(a)gmail.com> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index cc8131f..8a2bdfc 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -745,7 +745,7 @@ bool intel_pipe_has_type (struct drm_crtc *crtc, int type) struct drm_encoder *l_entry; list_for_each_entry(l_entry, &mode_config->encoder_list, head) { - if (l_entry && l_entry->crtc == crtc) { + if (l_entry->crtc == crtc) { struct intel_encoder *intel_encoder = enc_to_intel_encoder(l_entry); if (intel_encoder->type == type) return true; @@ -3322,7 +3322,7 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc, list_for_each_entry(encoder, &mode_config->encoder_list, head) { - if (!encoder || encoder->crtc != crtc) + if (encoder->crtc != crtc) continue; intel_encoder = enc_to_intel_encoder(encoder);

1 1

2.6.36-rc2 build failure: implicit declaration of function 'seq_printf'
by Sven Joachim 23 Aug '10

23 Aug '10

Commit 6ef3d4278034982c13df87c4a51e0445f762d316 causes a build failure for me: ,---- | CC [M] drivers/gpu/drm/i915/intel_overlay.o | drivers/gpu/drm/i915/intel_overlay.c: In function 'intel_overlay_print_error_state': | drivers/gpu/drm/i915/intel_overlay.c:1467: error: implicit declaration of function 'seq_printf' | make[4]: *** [drivers/gpu/drm/i915/intel_overlay.o] Error 1 `---- Adding a line with #include <linux/seq_file.h> to intel_overlay.c fixes this. Looking at include/drm/*.h, I notice that <linux/seq_file.h> is only #included if CONFIG_DEBUG_FS is set, which is not the case in my configuration. Sven

1 0

[git pull] drm fixes
by Dave Airlie 23 Aug '10

23 Aug '10

Hi Linus, Mostly radeon and nouveau regression fixes + one AGP regression fix, along with the information leak + not possible but should be checked for corruption. Dave. The following changes since commit 31ce4bfdfd10bf5db9bf85c92bbe0cf2edbdcad8: io-mapping: move asm include inside the config option (2010-08-12 11:47:50 +1000) are available in the git repository at: ssh://master.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git drm-core-next Alex Deucher (15): drm/radeon/kms: DCE3/4 AdjustPixelPll updates drm/radeon/kms: rework encoder handling drm/radeon/kms: DCE3/4 transmitter fixes drm/radeon/kms/atom: clean up dig atom handling drm/radeon/kms/pm: bail early if nothing's changing drm/radeon/kms/DCE3+: switch pads to ddc mode when going i2c drm/radeon/kms: add missing asic callback assignment for evergreen drm/radeon/kms: rework radeon_dp_detect() logic drm/radeon/kms: fix agp mode setup on cards that use pcie bridges drm/radeon/kms: don't enable MSIs on AGP boards drm/radeon/kms: add back missing break in info ioctl drm/radeon/kms: set encoder type to DVI for HDMI on evergreen drm/radeon/kms: fix sideport detection on newer rs880 boards drm/radeon/kms: try to detect tv vs monitor for underscan drm/radeon/kms: fix typo in radeon_compute_pll_gain Ben Skeggs (8): drm/nv50: fix minor thinko from nvc0 changes drm/nouveau: fix race condition when under memory pressure drm/nouveau: check for error when allocating/mapping dummy page drm/nouveau: remove warning about unknown tmds table revisions drm/nouveau: punt some more log messages to debug level drm/nv50-nvc0: ramht_size is meant to be in bytes, not entries drm/nvc0: fix thinko in instmem suspend/resume drm/nouveau: fix earlier mistake when fixing merge conflict Dan Carpenter (2): drm: fix end of loop test drm: move dereference below check Dave Airlie (4): drm: stop information leak of old kernel stack. drm: block userspace under allocating buffer and having drivers overwrite it (v2) drm/radeon: fix passing wrong type to gem object create. Merge remote branch 'nouveau/for-airlied' of /ssd/git/drm-nouveau-next into drm-core-next Francisco Jerez (3): drm/nouveau: Don't try DDC on the dummy I2C channel. drm/nouveau: Add TV-out quirk for an MSI nForce2 IGP. drm/nouveau: Workaround missing GPIO tables on an Apple iMac G4 NV18. Jean Delvare (1): drm/radeon: Fix stack data leak Jerome Glisse (1): drm/radeon/kms: fix GTT/VRAM overlapping test drivers/gpu/drm/drm_drv.c | 25 ++- drivers/gpu/drm/drm_fb_helper.c | 3 +- drivers/gpu/drm/drm_vm.c | 2 +- drivers/gpu/drm/i810/i810_dma.c | 30 ++-- drivers/gpu/drm/i830/i830_dma.c | 28 ++-- drivers/gpu/drm/i915/i915_dma.c | 80 ++++---- drivers/gpu/drm/mga/mga_state.c | 26 ++-- drivers/gpu/drm/nouveau/nouveau_bios.c | 42 +++-- drivers/gpu/drm/nouveau/nouveau_bo.c | 15 ++ drivers/gpu/drm/nouveau/nouveau_channel.c | 24 ++-- drivers/gpu/drm/nouveau/nouveau_connector.c | 6 +- drivers/gpu/drm/nouveau/nouveau_drv.h | 1 + drivers/gpu/drm/nouveau/nouveau_gem.c | 36 +++- drivers/gpu/drm/nouveau/nouveau_i2c.c | 2 +- drivers/gpu/drm/nouveau/nouveau_sgdma.c | 12 +- drivers/gpu/drm/nouveau/nv17_tv.c | 8 + drivers/gpu/drm/nouveau/nv50_instmem.c | 2 +- drivers/gpu/drm/nouveau/nvc0_instmem.c | 13 +- drivers/gpu/drm/r128/r128_state.c | 35 ++-- drivers/gpu/drm/radeon/atombios_crtc.c | 51 +++++- drivers/gpu/drm/radeon/atombios_dp.c | 2 +- drivers/gpu/drm/radeon/radeon_agp.c | 8 +- drivers/gpu/drm/radeon/radeon_asic.c | 1 + drivers/gpu/drm/radeon/radeon_atombios.c | 39 +++-- drivers/gpu/drm/radeon/radeon_combios.c | 104 ++++++------ drivers/gpu/drm/radeon/radeon_connectors.c | 26 +-- drivers/gpu/drm/radeon/radeon_device.c | 2 +- drivers/gpu/drm/radeon/radeon_display.c | 15 ++- drivers/gpu/drm/radeon/radeon_encoders.c | 223 ++++++++++++----------- drivers/gpu/drm/radeon/radeon_fb.c | 2 +- drivers/gpu/drm/radeon/radeon_i2c.c | 7 + drivers/gpu/drm/radeon/radeon_irq_kms.c | 5 +- drivers/gpu/drm/radeon/radeon_kms.c | 79 ++++---- drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 2 +- drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 7 +- drivers/gpu/drm/radeon/radeon_mode.h | 3 +- drivers/gpu/drm/radeon/radeon_pm.c | 5 + drivers/gpu/drm/radeon/radeon_state.c | 56 +++--- drivers/gpu/drm/savage/savage_bci.c | 8 +- drivers/gpu/drm/sis/sis_mm.c | 12 +- drivers/gpu/drm/via/via_dma.c | 28 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 34 ++-- include/drm/drmP.h | 6 +- include/drm/i830_drm.h | 28 ++-- include/drm/i915_drm.h | 1 + include/drm/mga_drm.h | 2 +- include/drm/nouveau_drm.h | 13 ++ include/drm/radeon_drm.h | 4 +- include/drm/savage_drm.h | 8 +- 49 files changed, 676 insertions(+), 495 deletions(-)

1 0

[Bug 29689] New: Heroes of Newerth models are rendered as 2D
by bugzilla-daemon＠freedesktop.org 22 Aug '10

22 Aug '10

https://bugs.freedesktop.org/show_bug.cgi?id=29689 Summary: Heroes of Newerth models are rendered as 2D Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: schmaker(a)ifrit.eu Hello there, since 18.8.2010 a Heroes of Newerth models started to being rendered as 2D. Some update made in git screwed it. I can post a screenshot if you need to. Effects are working great. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 4

[Bug 28574] New: [R600] Caster (commercial game) crash.
by bugzilla-daemon＠freedesktop.org 21 Aug '10

21 Aug '10

https://bugs.freedesktop.org/show_bug.cgi?id=28574 Summary: [R600] Caster (commercial game) crash. Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: critical Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: regnak90(a)gmail.com The game crash as soon as 3D is needed, the menu is working fine. Here is the gdb output: gdb caster.bin GNU gdb (GDB) 7.1 Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "i686-pc-linux-gnu". For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>... Reading symbols from /media/data/Jeux/Caster/Files/caster.bin...(no debugging symbols found)...done. (gdb) run Starting program: /media/data/Jeux/Caster/Files/caster.bin [Thread debugging using libthread_db enabled] Beginning Setup. Pre SDL Setup. Added available resolutions. Loaded settings file. Set to safe mode. Pre Initialize sound. [New Thread 0xb7632b70 (LWP 2443)] Post Initialize sound. Testing for support for 640 x 480. Pre video mode set (640 x 480). Video mode set at 640 x 480 with 0 times AA. Finished SDL Setup. OpenGL Version 2.0 Mesa 7.9-devel Supports extensions: GL_ARB_depth_texture GL_ARB_depth_clamp GL_ARB_draw_buffers GL_ARB_fragment_program GL_ARB_fragment_program_shadow GL_ARB_fragment_shader GL_ARB_imaging GL_ARB_multisample GL_ARB_multitexture GL_ARB_occlusion_query GL_ARB_pixel_buffer_object GL_ARB_point_parameters GL_ARB_point_sprite GL_ARB_provoking_vertex GL_ARB_shader_objects GL_ARB_shading_language_100 GL_ARB_shadow GL_ARB_shadow_ambient GL_ARB_texture_border_clamp GL_ARB_texture_compression GL_ARB_texture_cube_map GL_ARB_texture_env_add GL_ARB_texture_env_combine GL_ARB_texture_env_crossbar GL_ARB_texture_env_dot3 GL_MESAX_texture_float GL_ARB_texture_mirrored_repeat GL_ARB_texture_non_power_of_two GL_ARB_texture_rectangle GL_ARB_transpose_matrix GL_ARB_vertex_array_bgra GL_ARB_vertex_buffer_object GL_ARB_vertex_program GL_ARB_vertex_shader GL_ARB_window_pos GL_EXT_abgr GL_EXT_bgra GL_EXT_blend_color GL_EXT_blend_equation_separate GL_EXT_blend_func_separate GL_EXT_blend_logic_op GL_EXT_blend_minmax GL_EXT_blend_subtract GL_EXT_compiled_vertex_array GL_EXT_convolution GL_EXT_copy_texture GL_EXT_draw_range_elements GL_EXT_framebuffer_object GL_EXT_fog_coord GL_EXT_gpu_program_parameters GL_EXT_histogram GL_EXT_multi_draw_arrays GL_EXT_packed_depth_stencil GL_EXT_packed_pixels GL_EXT_pixel_buffer_object GL_EXT_point_parameters GL_EXT_polygon_offset GL_EXT_provoking_vertex GL_EXT_rescale_normal GL_EXT_secondary_color GL_EXT_separate_specular_color GL_EXT_shadow_funcs GL_EXT_stencil_two_side GL_EXT_stencil_wrap GL_EXT_subtexture GL_EXT_texture GL_EXT_texture3D GL_EXT_texture_cube_map GL_EXT_texture_edge_clamp GL_EXT_texture_env_add GL_EXT_texture_env_combine GL_EXT_texture_env_dot3 GL_EXT_texture_filter_anisotropic GL_EXT_texture_lod_bias GL_EXT_texture_mirror_clamp GL_EXT_texture_object GL_EXT_texture_rectangle GL_EXT_texture_sRGB GL_EXT_vertex_array GL_EXT_vertex_array_bgra GL_APPLE_packed_pixels GL_ATI_blend_equation_separate GL_ATI_texture_env_combine3 GL_ATI_texture_mirror_once GL_ATI_separate_stencil GL_IBM_multimode_draw_arrays GL_IBM_rasterpos_clip GL_IBM_texture_mirrored_repeat GL_INGR_blend_func_separate GL_MESA_pack_invert GL_MESA_ycbcr_texture GL_MESA_window_pos GL_NV_blend_square GL_NV_depth_clamp GL_NV_light_max_exponent GL_NV_packed_depth_stencil GL_NV_texture_rectangle GL_NV_texgen_reflection GL_NV_vertex_program GL_OES_read_format GL_SGI_color_matrix GL_SGI_color_table GL_SGIS_generate_mipmap GL_SGIS_texture_border_clamp GL_SGIS_texture_edge_clamp GL_SGIS_texture_lod GL_SUN_multi_draw_arrays Renderer: Mesa DRI R600 (RV635 9591) 20090101 x86/MMX/SSE2 TCL DRI2 Pre init textures. Post init textures . Finished OpenGL Setup. Program received signal SIGSEGV, Segmentation fault. 0xb6c20f5a in radeonEmitVec8 () from /usr/lib/xorg/modules/dri/r600_dri.so Same behavior with Mesa 7.7.1 With Mesa 7.8.1, the gdb output is the same, but there is relevant information in dmesg : radeon 0000:01:00.0: vbo resource seems too big for the bo radeon 0000:01:00.0: vbo resource seems too big for the bo radeon 0000:01:00.0: vbo resource seems too big for the bo radeon 0000:01:00.0: vbo resource seems too big for the bo radeon 0000:01:00.0: vbo resource seems too big for the bo radeon 0000:01:00.0: vbo resource seems too big for the bo radeon 0000:01:00.0: vbo resource seems too big for the bo radeon 0000:01:00.0: vbo resource seems too big for the bo radeon 0000:01:00.0: vbo resource seems too big for the bo radeon 0000:01:00.0: vbo resource seems too big for the bo radeon 0000:01:00.0: vbo resource seems too big for the bo radeon 0000:01:00.0: vbo resource seems too big for the bo radeon 0000:01:00.0: vbo resource seems too big for the bo radeon 0000:01:00.0: vbo resource seems too big for the bo radeon 0000:01:00.0: vbo resource seems too big for the bo -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 5

[PATCH] drm/radeon/kms: add missing scratch update in dp_detect
by Alex Deucher 21 Aug '10

21 Aug '10

Signed-off-by: Alex Deucher <alexdeucher(a)gmail.com> --- drivers/gpu/drm/radeon/radeon_connectors.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c index 31a09cd..1a5ee39 100644 --- a/drivers/gpu/drm/radeon/radeon_connectors.c +++ b/drivers/gpu/drm/radeon/radeon_connectors.c @@ -999,6 +999,7 @@ static enum drm_connector_status radeon_dp_detect(struct drm_connector *connecto } } + radeon_connector_update_scratch_regs(connector, ret); return ret; } -- 1.7.1.1

1 0

[Bug 17902] [830M] need support for DVO-LVDS via na2501
by bugzilla-daemon＠freedesktop.org 21 Aug '10

21 Aug '10

https://bugs.freedesktop.org/show_bug.cgi?id=17902 Chris Wilson <chris(a)chris-wilson.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[830M] need support for |[830M] need support for |DVO-LVDS |DVO-LVDS via na2501 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 27452] Evergreen KMS DRM sets bizarre 1922x1200 resolution
by bugzilla-daemon＠freedesktop.org 20 Aug '10

20 Aug '10

https://bugs.freedesktop.org/show_bug.cgi?id=27452 --- Comment #13 from Dave Witbrodt <dawitbro(a)sbcglobal.net> 2010-08-20 09:49:03 PDT --- (In reply to comment #12) > Fixed with this patch: > http://lists.freedesktop.org/archives/dri-devel/2010-August/003142.html Applied patch. Installed HD 5750 card. Verified that pink vertical line is gone. Thanks Alex! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[PATCH] drm/radeon/kms: fix sideport detection on newer rs880 boards
by Alex Deucher 20 Aug '10

20 Aug '10

The meaning of ucMemoryType changed on recent boards, however, ulBootUpSidePortClock should be set properly across all boards. Signed-off-by: Alex Deucher <alexdeucher(a)gmail.com> Cc: stable(a)kernel.org --- drivers/gpu/drm/radeon/radeon_atombios.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c index 89968f0..c29f5e5 100644 --- a/drivers/gpu/drm/radeon/radeon_atombios.c +++ b/drivers/gpu/drm/radeon/radeon_atombios.c @@ -1179,7 +1179,7 @@ bool radeon_atombios_sideport_present(struct radeon_device *rdev) return true; break; case 2: - if (igp_info->info_2.ucMemoryType & 0x0f) + if (igp_info->info_2.ulBootUpSidePortClock) return true; break; default: -- 1.7.1.1

1 0

[PATCH] drm/radeon/kms: try to detect tv vs monitor for underscan
by Alex Deucher 20 Aug '10

20 Aug '10

When enabling underscan for hdmi monitors, attempt to detect whether we are driving a TV or a monitor. The should hopefully prevent underscan from being enabled on monitors attached via hdmi that do not overscan the image. Only enable underscan if the mode is a common hdtv mode (480p, 720p, etc.). Signed-off-by: Alex Deucher <alexdeucher(a)gmail.com> --- drivers/gpu/drm/radeon/radeon_display.c | 15 ++++++++++++++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c index d49a148..5ca8ce7 100644 --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -1099,6 +1099,18 @@ void radeon_modeset_fini(struct radeon_device *rdev) radeon_i2c_fini(rdev); } +static bool is_hdtv_mode(struct drm_display_mode *mode) +{ + /* try and guess if this is a tv or a monitor */ + if ((mode->vdisplay == 480 && mode->hdisplay == 720) || /* 480p */ + (mode->vdisplay == 576) || /* 576p */ + (mode->vdisplay == 720) || /* 720p */ + (mode->vdisplay == 1080)) /* 1080p */ + return true; + else + return false; +} + bool radeon_crtc_scaling_mode_fixup(struct drm_crtc *crtc, struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode) @@ -1146,7 +1158,8 @@ bool radeon_crtc_scaling_mode_fixup(struct drm_crtc *crtc, if (ASIC_IS_AVIVO(rdev) && ((radeon_encoder->underscan_type == UNDERSCAN_ON) || ((radeon_encoder->underscan_type == UNDERSCAN_AUTO) && - drm_detect_hdmi_monitor(radeon_connector->edid)))) { + drm_detect_hdmi_monitor(radeon_connector->edid) && + is_hdtv_mode(mode)))) { radeon_crtc->h_border = (mode->hdisplay >> 5) + 16; radeon_crtc->v_border = (mode->vdisplay >> 5) + 16; radeon_crtc->rmx_type = RMX_FULL; -- 1.7.1.1

1 0

← Newer
1
...
16
17
18
19
20
21
22
...
34
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel August 2010