There has been periodic evidence that LVDS, on at least some
panels, prefers the dividers selected by the legacy pll algo.
This patch forces the use of the legacy pll algo on RV515
LVDS panels. The old behavior (new pll algo) can be selected
by setting the new_pll module parameter to 1.
Signed-off-by: Alex Deucher <alexdeucher(a)gmail.com>
Cc: stable(a)kernel.org
---
drivers/gpu/drm/radeon/atombios_crtc.c | 14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --…
[View More]git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c
index 577239a..977f5c2 100644
--- a/drivers/gpu/drm/radeon/atombios_crtc.c
+++ b/drivers/gpu/drm/radeon/atombios_crtc.c
@@ -534,6 +534,20 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
pll->algo = PLL_ALGO_LEGACY;
pll->flags |= RADEON_PLL_PREFER_CLOSEST_LOWER;
}
+ /* There is some evidence (often anecdotal) that RV515 LVDS
+ * (on some boards at least) prefers the legacy algo. I'm not
+ * sure whether this should handled generically or on a
+ * case-by-case quirk basis. Both algos should work fine in the
+ * majority of cases.
+ */
+ if ((radeon_encoder->active_device & (ATOM_DEVICE_LCD_SUPPORT)) &&
+ (rdev->family == CHIP_RV515)) {
+ /* allow the user to overrride just in case */
+ if (radeon_new_pll == 1)
+ pll->algo = PLL_ALGO_NEW;
+ else
+ pll->algo = PLL_ALGO_LEGACY;
+ }
} else {
if (encoder->encoder_type != DRM_MODE_ENCODER_DAC)
pll->flags |= RADEON_PLL_NO_ODD_POST_DIV;
--
1.7.1.1
[View Less]
https://bugs.freedesktop.org/show_bug.cgi?id=28402
--- Comment #30 from Da Fox <da_fox(a)mad.scientist.com> 2010-09-01 04:37:38 PDT ---
(In reply to comment #29)
> Thanks for the help.
>
> I managed to compile and boot the kernel with
> 7a9f0dd9c49425e2b0e39ada4757bc7a38c84873 as head.
> ('uname -r' reports "2.6.33-00035-gaa71fa3")
>
> 3,5 hours up and so far no freeze.
That uname report does not match with the version you've compiled, something
must have gone …
[View More]wrong. It should be "2.6.33-00519-7a9f0dd", the first part is
the current 'base' version of the kernel (so 2.6.33, since it's before the
release of 2.6.34), the second part (00035) I do not know the meaning of (so it
could be different for you), and the final part is composed of the letter 'g'
(for git?) followed by the first part of the sha1 id. Revision aa71fa3... is
"Merge remote branch 'nouveau/for-airlied' into drm-next-stage", which is still
a bit before those three commits. So no freeze there is good!
For me 7a9f0dd9c49425e2b0e39ada4757bc7a38c84873 resets the computer when
starting X. This is probably due to a bug in that version, which has been fixed
a few commits later, in 8e36113082821980c60ce89a6c5d45fc9492fc26 -
drm/radeon/kms: fix R3XX/R4XX memory controller intialization.
I've compiled and tested a kernel based on
d594e46ace22afa1621254f6f669e65430048153 with one additionally commit,
8e36113082821980c60ce89a6c5d45fc9492fc26. This again froze within a minute of
starting firefox. So the offending commit definitely must be
d594e46ace22afa1621254f6f669e65430048153 - drm/radeon/kms: simplify memory
controller setup V2.
If you want to test this too you can do it like this:
$ git checkout d594e46ace22afa1621254f6f669e65430048153
$ git cherry-pick -n 8e36113082821980c60ce89a6c5d45fc9492fc26
cherry-pick applies a commit on top of the current state. the -n flag does not
actually commit anything, but only makes local changes. You can now compile and
test this version. To get rid of the local changes again run
$ git reset --hard
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[View Less]
https://bugs.freedesktop.org/show_bug.cgi?id=27407
--- Comment #7 from dE <de.techno(a)gmail.com> 2010-09-01 02:03:38 PDT ---
No, actually I removed that after finding no difference, but I never used
eselect to actually use the classic or gallium drivers.
Right now, I can't enable the gallium USE flag (it's surrounded by () and I
don't know what it means).
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
…
[View More]You are the assignee for the bug.
[View Less]
https://bugs.freedesktop.org/show_bug.cgi?id=27407
--- Comment #6 from Nicolas Kaiser <nikai(a)nikai.net> 2010-09-01 02:00:51 PDT ---
(In reply to comment #5)
> Emerging layman....
You also need a recent version of mesa with gallium use flag.
But from your initial description it looks like you already have that use flag:
media-libs/mesa
Installed versions: 9999 (..) (gallium (..))
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are …
[View More]receiving this mail because: -------
You are the assignee for the bug.
[View Less]