dri-devel February 2011

dri-devel@lists.freedesktop.org

84 participants
466 discussions

[Bug 29851] New: [r300g] HyperZ on RS690 not work correctly
by bugzilla-daemon＠freedesktop.org 28 Feb '11

28 Feb '11

https://bugs.freedesktop.org/show_bug.cgi?id=29851 Summary: [r300g] HyperZ on RS690 not work correctly Product: Mesa Version: unspecified Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/r300 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: d.okias(a)gmail.com Created an attachment (id=38235) --> (https://bugs.freedesktop.org/attachment.cgi?id=38235) glxgears.jpeg Incoretly rendering. Kernel: 2.6.36-rc2 Mesa/libdrm/ddx: git xorg: 1.9.0 ~ $ RADEON_HYPERZ=1 glxgears radeon: Successfully grabbed chipset info from kernel! radeon: DRM version: 2.6.0 ID: 0x791f GB: 1 Z: 1 radeon: GART size: 509 MB VRAM size: 128 MB radeon: HyperZ: YES couldn't open libtxc_dxtn.so, software DXTn compression/decompression unavailable Mesa: Mesa 7.9-devel DEBUG build Aug 28 2010 10:23:14 Mesa warning: couldn't open libtxc_dxtn.so, software DXTn compression/decompression unavailable Running synchronized to the vertical refresh. The framerate should be approximately the same as the monitor refresh rate. 293 frames in 5.0 seconds = 58.480 FPS P.S. On screenshot is glxgears area, only small part fast blinking gear -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 17

[PATCH] drm/radeon/kms: clean up gart dummy page handling
by Alex Deucher 28 Feb '11

28 Feb '11

As per Konrad's original patch, the dummy page used by the gart code and allocated in radeon_gart_init() was not freed properly in radeon_gart_fini(). At the same time r6xx and newer allocated and freed the dummy page on their own. So to do Konrad's patch one better, just remove the allocation and freeing of the dummy page in the r6xx, 7xx, evergreen, and ni code and allocate and free in the gart_init/fini() functions for all asics. Cc: Konrad Rzeszutek Wilk <konrad.wilk(a)oracle.com> Cc: Jerome Glisse <jglisse(a)redhat.com> Signed-off-by: Alex Deucher <alexdeucher(a)gmail.com> --- drivers/gpu/drm/radeon/evergreen.c | 4 ---- drivers/gpu/drm/radeon/r600.c | 4 ---- drivers/gpu/drm/radeon/radeon_gart.c | 2 ++ drivers/gpu/drm/radeon/rv770.c | 4 ---- 4 files changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/radeon/evergreen.c b/drivers/gpu/drm/radeon/evergreen.c index 789441e..9ecb2b6 100644 --- a/drivers/gpu/drm/radeon/evergreen.c +++ b/drivers/gpu/drm/radeon/evergreen.c @@ -3048,9 +3048,6 @@ int evergreen_init(struct radeon_device *rdev) { int r; - r = radeon_dummy_page_init(rdev); - if (r) - return r; /* This don't do much */ r = radeon_gem_init(rdev); if (r) @@ -3162,7 +3159,6 @@ void evergreen_fini(struct radeon_device *rdev) radeon_atombios_fini(rdev); kfree(rdev->bios); rdev->bios = NULL; - radeon_dummy_page_fini(rdev); } static void evergreen_pcie_gen2_enable(struct radeon_device *rdev) diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index 1252198..88eaffc 100644 --- a/drivers/gpu/drm/radeon/r600.c +++ b/drivers/gpu/drm/radeon/r600.c @@ -2510,9 +2510,6 @@ int r600_init(struct radeon_device *rdev) { int r; - r = radeon_dummy_page_init(rdev); - if (r) - return r; if (r600_debugfs_mc_info_init(rdev)) { DRM_ERROR("Failed to register debugfs file for mc !\n"); } @@ -2626,7 +2623,6 @@ void r600_fini(struct radeon_device *rdev) radeon_atombios_fini(rdev); kfree(rdev->bios); rdev->bios = NULL; - radeon_dummy_page_fini(rdev); } diff --git a/drivers/gpu/drm/radeon/radeon_gart.c b/drivers/gpu/drm/radeon/radeon_gart.c index 6501611..dc04c7b 100644 --- a/drivers/gpu/drm/radeon/radeon_gart.c +++ b/drivers/gpu/drm/radeon/radeon_gart.c @@ -269,4 +269,6 @@ void radeon_gart_fini(struct radeon_device *rdev) kfree(rdev->gart.pages_addr); rdev->gart.pages = NULL; rdev->gart.pages_addr = NULL; + + radeon_dummy_page_fini(rdev); } diff --git a/drivers/gpu/drm/radeon/rv770.c b/drivers/gpu/drm/radeon/rv770.c index d8ba676..6a312e6 100644 --- a/drivers/gpu/drm/radeon/rv770.c +++ b/drivers/gpu/drm/radeon/rv770.c @@ -1256,9 +1256,6 @@ int rv770_init(struct radeon_device *rdev) { int r; - r = radeon_dummy_page_init(rdev); - if (r) - return r; /* This don't do much */ r = radeon_gem_init(rdev); if (r) @@ -1373,7 +1370,6 @@ void rv770_fini(struct radeon_device *rdev) radeon_atombios_fini(rdev); kfree(rdev->bios); rdev->bios = NULL; - radeon_dummy_page_fini(rdev); } static void rv770_pcie_gen2_enable(struct radeon_device *rdev) -- 1.7.1.1

1 0

[PATCH] drm/r600: parse the set predication command.
by Dave Airlie 28 Feb '11

28 Feb '11

From: Dave Airlie <airlied(a)redhat.com> This is required for NV_conditional_render and EXT_transform_feedback. Signed-off-by: Dave Airlie <airlied(a)redhat.com> --- drivers/gpu/drm/radeon/r600_cs.c | 32 ++++++++++++++++++++++++++++++++ 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c index 00f153d..0a0848f 100644 --- a/drivers/gpu/drm/radeon/r600_cs.c +++ b/drivers/gpu/drm/radeon/r600_cs.c @@ -1421,6 +1421,38 @@ static int r600_packet3_check(struct radeon_cs_parser *p, idx_value = radeon_get_ib_value(p, idx); switch (pkt->opcode) { + case PACKET3_SET_PREDICATION: + { + int pred_op; + int tmp; + if (pkt->count != 1) { + DRM_ERROR("bad SET PREDICATION\n"); + return -EINVAL; + } + + tmp = radeon_get_ib_value(p, idx + 1); + pred_op = (tmp >> 16) & 0x7; + + /* for the clear predicate operation */ + if (pred_op == 0) + return 0; + + if (pred_op > 2) { + DRM_ERROR("bad SET PREDICATION operation %d\n", pred_op); + return -EINVAL; + } + + r = r600_cs_packet_next_reloc(p, &reloc); + if (r) { + DRM_ERROR("bad SET PREDICATION\n"); + return -EINVAL; + } + + ib[idx + 0] = idx_value + (u32)(reloc->lobj.gpu_offset & 0xffffffff); + ib[idx + 1] = tmp + (upper_32_bits(reloc->lobj.gpu_offset) & 0xff); + } + break; + case PACKET3_START_3D_CMDBUF: if (p->family >= CHIP_RV770 || pkt->count) { DRM_ERROR("bad START_3D\n"); -- 1.7.3.2

2 1

[Bug 33674] New: KMS, kernel, Second Monitor becomes complete blur when loading fullscreen GL
by bugzilla-daemon＠freedesktop.org 27 Feb '11

27 Feb '11

https://bugs.freedesktop.org/show_bug.cgi?id=33674 Summary: KMS, kernel, Second Monitor becomes complete blur when loading fullscreen GL Product: DRI Version: XOrg CVS Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: critical Priority: highest Component: DRM/Radeon AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: oyvinds(a)everdot.org On affected system: 1. Load fullscreen OpenGL something which thinks fullscreen means both attached monitors. This includes kwin and warzone. 2. Kernels 2.6.37-git15 2.6.38-rc1-git2 2.6.38-rc2-git7 show expected on first monitor and complete blur on second monitor. Total messy blur. Everything works perfectly with stable 2.6.37-gentoo kernel. I do not know what happened with <=2.6.37-git15, but I do know 2.6.37-git15 kernels and later are defective. It would be nice if someone could make two monitors work with OpenGL again (working kwin is nice). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 4

[Bug 34583] New: graphics artifacts in Opengl
by bugzilla-daemon＠freedesktop.org 27 Feb '11

27 Feb '11

https://bugs.freedesktop.org/show_bug.cgi?id=34583 Summary: graphics artifacts in Opengl Product: Mesa Version: unspecified Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: himek_imp(a)o2.pl I have graphics artefacts in all OpenGL apps including glxgears using r600g (r600c is unaffected). Attached a screenshot. Testing on Kubuntu 10.10 + edges PPA. Mesa 7.11, Linux 2.6.35-25 x86_64. ATI Technologies Inc RV630 (Radeon HD 2600). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 9

[Bug 34427] New: Graphical corruption when opening windows
by bugzilla-daemon＠freedesktop.org 27 Feb '11

27 Feb '11

https://bugs.freedesktop.org/show_bug.cgi?id=34427 Summary: Graphical corruption when opening windows Product: DRI Version: XOrg CVS Platform: x86-64 (AMD64) OS/Version: All Status: NEW Severity: normal Priority: medium Component: General AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: h.judt(a)gmx.at Created an attachment (id=43507) --> (https://bugs.freedesktop.org/attachment.cgi?id=43507) screenshot of the garbled frame Although it is visible only for a very short moment, I was able to capture it, see the screenshot attached to this bug. It seems something doesn't get initialized correctly like it used to before, part of the garbled area looks like it's previous screen content, just pretty messed. * I think this only happens when using compositing, but did not test it, so I'm not sure. * Is noticable with xfwm4 (the xfce window manager) and compiz. * Is only noticable sometimes (maybe because the other times it's just too fast, but I'll try to capture it with recordmydesktop). * It can be seen on various window types, like the small firefox / thunderbird frame which appears before the normal window appears, or menus. * It is not constrained to window size. * This did not happen some time ago, but I don't know when it started. Before it started, the windows were simply grey. Software and versions: * git vanilla kernel (2.6.38-rc5), certainly happened with 2.6.37 * git mesa (r600g) * git xf86-video-ati * git libdrm -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 16

[Bug 19372] 2.6.36-rc6: WARNING: at drivers/gpu/drm/radeon/radeon_fence.c:235 radeon_fence_wait+0x35a/0x3c0
by bugzilla-daemon＠bugzilla.kernel.org 27 Feb '11

27 Feb '11

https://bugzilla.kernel.org/show_bug.cgi?id=19372 --- Comment #3 from Alexey Dobriyan <adobriyan(a)gmail.com> 2011-02-27 11:29:01 --- Do not use that card anymore, happened once IIRC. -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev -- _______________________________________________ Dri-devel mailing list Dri-devel(a)lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel

1 0

[git pull] drm fixes
by Dave Airlie 27 Feb '11

27 Feb '11

Nothing too major, Two regression fixers (one revert that got fixes properly elsewhere), some timestamp fixes and an agp module reload fix. Dave. The following changes since commit d8204a37baf5474d3154eb536c936369be2bd5c0: Merge branch 'urgent' of git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6 (2011-02-22 09:26:54 -0800) are available in the git repository at: ssh://master.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git drm-fixes Alex Deucher (1): Revert "drm/radeon/kms: switch back to min->max pll post divider iteration" Dave Airlie (2): drm/radeon/kms: align height of fb allocation. drm/radeon: fix regression with AA resolve checking Florian Mickler (1): amd64-agp: fix crash at second module load Mario Kleiner (3): drm/vblank: Use abs64(diff_ns) for s64 diff_ns instead of abs(diff_ns) drm/vblank: Use memory barriers optimized for atomic_t instead of generics. drm/vblank: Enable precise vblank timestamps for interlaced and doublescan modes. Paul Bolle (1): drm: drop commented out code and preceding comment drivers/char/agp/amd64-agp.c | 9 +++++++-- drivers/gpu/drm/drm_irq.c | 26 ++++++++++++++------------ drivers/gpu/drm/radeon/r100.c | 4 +--- drivers/gpu/drm/radeon/radeon_display.c | 2 +- drivers/gpu/drm/radeon/radeon_fb.c | 5 ++++- 5 files changed, 27 insertions(+), 19 deletions(-)

6 12

[PATCH] kms: Fix warning XNFprintf is deprecated
by Sedat Dilek 26 Feb '11

26 Feb '11

Noticed when building ati/radeon ddx against xserver 1.10-rc3. [ build.log ] ../../src/radeon_kms.c:412:5: warning: 'XNFprintf' is deprecated (declared at /usr/include/xorg/os.h:273) Signed-off-by: Sedat Dilek <sedat.dilek(a)gmail.com> --- src/radeon_kms.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/radeon_kms.c b/src/radeon_kms.c index 158dc57..19b0c74 100644 --- a/src/radeon_kms.c +++ b/src/radeon_kms.c @@ -409,7 +409,7 @@ static Bool radeon_open_drm_master(ScrnInfoPtr pScrn) goto out; } - busid = XNFprintf("pci:%04x:%02x:%02x.%d", + busid = XNFasprintf("pci:%04x:%02x:%02x.%d", dev->domain, dev->bus, dev->dev, dev->func); info->dri2.drm_fd = drmOpen("radeon", busid); -- 1.7.4.1

4 5

[patch] drm/radeon/r600_cs: off by one errors
by Dan Carpenter 26 Feb '11

26 Feb '11

There are a bunch of off by one errors in the sanity checks here. Signed-off-by: Dan Carpenter <error27(a)gmail.com> diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c index 79ac676..41da786 100644 --- a/drivers/gpu/drm/radeon/r600_cs.c +++ b/drivers/gpu/drm/radeon/r600_cs.c @@ -159,7 +159,7 @@ static const struct gpu_formats color_formats_table[] = { static inline bool fmt_is_valid_color(u32 format) { - if (format > ARRAY_SIZE(color_formats_table)) + if (format >= ARRAY_SIZE(color_formats_table)) return false; if (color_formats_table[format].valid_color) @@ -170,7 +170,7 @@ static inline bool fmt_is_valid_color(u32 format) static inline bool fmt_is_valid_texture(u32 format) { - if (format > ARRAY_SIZE(color_formats_table)) + if (format >= ARRAY_SIZE(color_formats_table)) return false; if (color_formats_table[format].blockwidth > 0) @@ -181,7 +181,7 @@ static inline bool fmt_is_valid_texture(u32 format) static inline int fmt_get_blocksize(u32 format) { - if (format > ARRAY_SIZE(color_formats_table)) + if (format >= ARRAY_SIZE(color_formats_table)) return 0; return color_formats_table[format].blocksize; @@ -190,7 +190,8 @@ static inline int fmt_get_blocksize(u32 format) static inline int fmt_get_nblocksx(u32 format, u32 w) { unsigned bw; - if (format > ARRAY_SIZE(color_formats_table)) + + if (format >= ARRAY_SIZE(color_formats_table)) return 0; bw = color_formats_table[format].blockwidth; @@ -203,7 +204,8 @@ static inline int fmt_get_nblocksx(u32 format, u32 w) static inline int fmt_get_nblocksy(u32 format, u32 h) { unsigned bh; - if (format > ARRAY_SIZE(color_formats_table)) + + if (format >= ARRAY_SIZE(color_formats_table)) return 0; bh = color_formats_table[format].blockheight; @@ -216,7 +218,8 @@ static inline int fmt_get_nblocksy(u32 format, u32 h) static inline int r600_bpe_from_format(u32 *bpe, u32 format) { unsigned res; - if (format > ARRAY_SIZE(color_formats_table)) + + if (format >= ARRAY_SIZE(color_formats_table)) goto fail; res = color_formats_table[format].blocksize;

1 0

← Newer
1
...
21
22
23
24
25
26
27
...
47
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel February 2011