dri-devel April 2011

dri-devel@lists.freedesktop.org

93 participants
440 discussions

[PATCH] drm/radeon/kms: pll tweaks for r7xx
by Alex Deucher 19 Apr '11

19 Apr '11

Prefer min m to max p only on pre-r7xx asics. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=36197 Signed-off-by: Alex Deucher <alexdeucher(a)gmail.com> Cc: stable(a)kernel.org --- drivers/gpu/drm/radeon/atombios_crtc.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c index 9d516a8..529a3a7 100644 --- a/drivers/gpu/drm/radeon/atombios_crtc.c +++ b/drivers/gpu/drm/radeon/atombios_crtc.c @@ -532,10 +532,7 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc, else pll->flags |= RADEON_PLL_PREFER_LOW_REF_DIV; - if ((rdev->family == CHIP_R600) || - (rdev->family == CHIP_RV610) || - (rdev->family == CHIP_RV630) || - (rdev->family == CHIP_RV670)) + if (rdev->family < CHIP_RV770) pll->flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP; } else { pll->flags |= RADEON_PLL_LEGACY; @@ -565,7 +562,6 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc, if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) { if (ss_enabled) { if (ss->refdiv) { - pll->flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP; pll->flags |= RADEON_PLL_USE_REF_DIV; pll->reference_div = ss->refdiv; if (ASIC_IS_AVIVO(rdev)) -- 1.7.1.1

1 0

[PATCH 0/2] drm: Message logging cleanups
by Joe Perches 19 Apr '11

19 Apr '11

Reduce the text space required and verify debug arguments. Joe Perches (2): drm: Create and use drm_err drm: Verify debug message arguments drivers/gpu/drm/drm_irq.c | 9 +++++---- drivers/gpu/drm/drm_stub.c | 21 +++++++++++++++++++++ drivers/gpu/drm/i915/intel_bios.c | 6 +++--- drivers/gpu/drm/i915/intel_display.c | 8 ++++---- drivers/gpu/drm/radeon/radeon_display.c | 5 +++-- include/drm/drmP.h | 24 +++++++++--------------- 6 files changed, 45 insertions(+), 28 deletions(-) -- 1.7.4.2.g597a6.dirty

4 9

[PATCH] radeon: Fix KMS CP writeback on big endian machines.
by Cédric Cano 19 Apr '11

19 Apr '11

Hi, The following patch fixes interrupt acknowledge when write-back is enabled on big endian platform. The same should be applied on evergreen. Cedric Signed-off-by: Cedric Cano<ccano at interfaceconcept.com> --- diff -Naur linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c --- linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c 2011-04-19 09:52:13.000000000 +0200 +++ linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c 2011-03-27 20:37:20.000000000 +0200 @@ -3227,7 +3227,7 @@ u32 wptr, tmp; if (rdev->wb.enabled) - wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); + wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; else wptr = RREG32(IH_RB_WPTR);

3 5

[PATCH] Big endian support for RV730 (Gallium r600g)
by Cédric Cano 19 Apr '11

19 Apr '11

Hi Here you are a patch that adds big endian support for rv730 in r600 gallium driver. I used the mesa-demos to test the driver status on big endian platform. Except with demos using accumulation buffer, the rendering is the same as on Intel platform. Albeit there are still some artefacts with some demos. I manage to fix accumulation buffer demos but then, glReadPixels demos won't work. I still can figure out (like with r600c) what and when I must enable swap. It will depends on object's domains. That's what I tried to do in r600_cb and r600_create_sampler_view. Reviewing of the patch would be greatly appreciated. Regards, Cedric

2 1

[PATCH] drm/radeon/kms: adjust eDP handling
by Alex Deucher 19 Apr '11

19 Apr '11

eDP is usually used as an LVDS replacement, so treat it more like LVDS from the user perspective. Signed-off-by: Alex Deucher <alexdeucher(a)gmail.com> --- drivers/gpu/drm/radeon/radeon_connectors.c | 30 +++++++++++++++++++++++---- 1 files changed, 25 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c index 5f45fa1..a7bdcc7 100644 --- a/drivers/gpu/drm/radeon/radeon_connectors.c +++ b/drivers/gpu/drm/radeon/radeon_connectors.c @@ -1314,7 +1314,6 @@ radeon_add_atom_connector(struct drm_device *dev, connector->doublescan_allowed = false; break; case DRM_MODE_CONNECTOR_DisplayPort: - case DRM_MODE_CONNECTOR_eDP: radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL); if (!radeon_dig_connector) goto failed; @@ -1324,10 +1323,7 @@ radeon_add_atom_connector(struct drm_device *dev, drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs); if (i2c_bus->valid) { /* add DP i2c bus */ - if (connector_type == DRM_MODE_CONNECTOR_eDP) - radeon_dig_connector->dp_i2c_bus = radeon_i2c_create_dp(dev, i2c_bus, "eDP-auxch"); - else - radeon_dig_connector->dp_i2c_bus = radeon_i2c_create_dp(dev, i2c_bus, "DP-auxch"); + radeon_dig_connector->dp_i2c_bus = radeon_i2c_create_dp(dev, i2c_bus, "DP-auxch"); if (!radeon_dig_connector->dp_i2c_bus) DRM_ERROR("DP: Failed to assign dp ddc bus! Check dmesg for i2c errors.\n"); radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus); @@ -1353,6 +1349,30 @@ radeon_add_atom_connector(struct drm_device *dev, /* in theory with a DP to VGA converter... */ connector->doublescan_allowed = false; break; + case DRM_MODE_CONNECTOR_eDP: + radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL); + if (!radeon_dig_connector) + goto failed; + radeon_dig_connector->igp_lane_info = igp_lane_info; + radeon_connector->con_priv = radeon_dig_connector; + drm_connector_init(dev, &radeon_connector->base, &radeon_dp_connector_funcs, connector_type); + drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs); + if (i2c_bus->valid) { + /* add DP i2c bus */ + radeon_dig_connector->dp_i2c_bus = radeon_i2c_create_dp(dev, i2c_bus, "eDP-auxch"); + if (!radeon_dig_connector->dp_i2c_bus) + DRM_ERROR("DP: Failed to assign dp ddc bus! Check dmesg for i2c errors.\n"); + radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus); + if (!radeon_connector->ddc_bus) + DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n"); + } + drm_connector_attach_property(&radeon_connector->base, + dev->mode_config.scaling_mode_property, + DRM_MODE_SCALE_FULLSCREEN); + subpixel_order = SubPixelHorizontalRGB; + connector->interlace_allowed = false; + connector->doublescan_allowed = false; + break; case DRM_MODE_CONNECTOR_SVIDEO: case DRM_MODE_CONNECTOR_Composite: case DRM_MODE_CONNECTOR_9PinDIN: -- 1.7.1.1

1 0

[PATCH:libdrm] Link dristat with -lrt if appropriate.
by Cyril Brulebois 19 Apr '11

19 Apr '11

The need for -lrt is determined at configure time, let's use the resulting variable for dristat's link, since it uses clock_gettime(). Signed-off-by: Cyril Brulebois <kibi(a)debian.org> --- tests/Makefile.am | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index bf1987f..6f48931 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -10,6 +10,8 @@ check_PROGRAMS = \ dristat \ drmstat +dristat_LDADD = $(CLOCK_LIB) + SUBDIRS = modeprint if HAVE_LIBKMS -- 1.7.4.1

1 0

[Bug 26999] _mesa_reference_renderbuffer: Assertion `oldRb->Magic == 0xaabbccdd' failed
by bugzilla-daemon＠freedesktop.org 18 Apr '11

18 Apr '11

https://bugs.freedesktop.org/show_bug.cgi?id=26999 --- Comment #11 from Julien Viard de Galbert <julien(a)vdg.blogsite.org> 2011-04-18 14:50:47 PDT --- Unfortunately, I didn't get time to work on that yet... I still plan too, but I really don't know when ;) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 26999] _mesa_reference_renderbuffer: Assertion `oldRb->Magic == 0xaabbccdd' failed
by bugzilla-daemon＠freedesktop.org 18 Apr '11

18 Apr '11

https://bugs.freedesktop.org/show_bug.cgi?id=26999 --- Comment #10 from Peter <pva(a)gentoo.org> 2011-04-18 04:11:47 PDT --- Julien, I'm unable to build mesa with provided patch too. Any pointers? Thank you! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[PATCH] drm: Recover DPMS properly after XRandr re-enablement
by Chris Wilson 18 Apr '11

18 Apr '11

From: Takashi Iwai <tiwai(a)suse.de> When the output is turned off via "xrandr --off" and re-enabled again with the same mode, drm doesn't reset DPMS, thus it results in a black screen. A typical example is something like: % xrandr --output LVDS1 --mode 1024x768 % xrandr --output VGA1 --mode 1024x768 % xrandr --output LVDS1 --off % xrandr --output LVDS1 --mode 1024x768 Also, there is another problem with DPMS: the sysfs entries don't match with the actual state. In the case above, LVDS1 shows always Off, while VGA1 shows On. A part of the cause is that there are (still) two places to keep the actual DPMS values. In dpms field of drm_connector and in the device property. Thus we need to sync between them. Another problem is that the DPMS state is always set to ON forcibly in drm_crtc_helper_set_config() (via commit bf9dc102e284a5aa78c73fc9d72e11d5ccd8669f). This results in another inconsistency. For recovering the DPMS, we need to set DPMS actaully ON there. This patch adds a new helper function to manage the drm_connector DPMS so that it can be called commonly in both places. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- drivers/gpu/drm/drm_crtc.c | 25 ++++++++++++++++++------- drivers/gpu/drm/drm_crtc_helper.c | 7 ++++--- include/drm/drm_crtc.h | 1 + 3 files changed, 23 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 2baa670..3a58337 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -2383,6 +2383,18 @@ int drm_mode_connector_update_edid_property(struct drm_connector *connector, } EXPORT_SYMBOL(drm_mode_connector_update_edid_property); +int drm_connector_set_dpms(struct drm_connector *connector, int mode) +{ + if (connector->funcs->dpms) + (*connector->funcs->dpms)(connector, mode); + connector->dpms = mode; + drm_connector_property_set_value(connector, + connector->dev->mode_config.dpms_property, + mode); + return 0; +} +EXPORT_SYMBOL(drm_connector_set_dpms); + int drm_mode_connector_property_set_ioctl(struct drm_device *dev, void *data, struct drm_file *file_priv) { @@ -2440,15 +2452,14 @@ int drm_mode_connector_property_set_ioctl(struct drm_device *dev, /* Do DPMS ourselves */ if (property == connector->dev->mode_config.dpms_property) { - if (connector->funcs->dpms) - (*connector->funcs->dpms)(connector, (int) out_resp->value); + drm_connector_set_dpms(connector, (int) out_resp->value); ret = 0; - } else if (connector->funcs->set_property) + } else if (connector->funcs->set_property) { ret = connector->funcs->set_property(connector, property, out_resp->value); - - /* store the property value if successful */ - if (!ret) - drm_connector_property_set_value(connector, property, out_resp->value); + /* store the property value if successful */ + if (!ret) + drm_connector_property_set_value(connector, property, out_resp->value); + } out: mutex_unlock(&dev->mode_config.mutex); return ret; diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index bede10a..fee755d 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -669,9 +669,10 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set) } DRM_DEBUG_KMS("Setting connector DPMS state to on\n"); for (i = 0; i < set->num_connectors; i++) { - DRM_DEBUG_KMS("\t[CONNECTOR:%d:%s] set DPMS on\n", set->connectors[i]->base.id, - drm_get_connector_name(set->connectors[i])); - set->connectors[i]->dpms = DRM_MODE_DPMS_ON; + struct drm_connector *connector = set->connectors[i]; + DRM_DEBUG_KMS("\t[CONNECTOR:%d:%s] set DPMS on\n", connector->base.id, + drm_get_connector_name(connector)); + drm_connector_set_dpms(connector, DRM_MODE_DPMS_ON); } kfree(save_connectors); diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 029aa68..c9a5a80 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -676,6 +676,7 @@ extern void drm_mode_set_crtcinfo(struct drm_display_mode *p, extern void drm_mode_connector_list_update(struct drm_connector *connector); extern int drm_mode_connector_update_edid_property(struct drm_connector *connector, struct edid *edid); +extern int drm_connector_set_dpms(struct drm_connector *connector, int mode); extern int drm_connector_property_set_value(struct drm_connector *connector, struct drm_property *property, uint64_t value); -- 1.7.3.1

3 3

[Bug 33755] New: System hangs with x-testing and gtkperf tests
by bugzilla-daemon＠freedesktop.org 18 Apr '11

18 Apr '11

https://bugs.freedesktop.org/show_bug.cgi?id=33755 Summary: System hangs with x-testing and gtkperf tests Product: Mesa Version: git Platform: x86 (IA32) OS/Version: All Status: NEW Severity: major Priority: high Component: Drivers/DRI/Radeon AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: mrgkavitha(a)gmail.com Created an attachment (id=42746) --> (https://bugs.freedesktop.org/attachment.cgi?id=42746) Xorg log file KMS Driver Stack Details: ========================= 1) Kernel-2.6.35-22-generic-pae 2) Libdrm-2.4.21 3) Mesa-7.9-rc1 4) Xorg-server-1.9.0 5) ddx: xf86-video-ati-6.13.99 System Environment: =================== O.S. - Ubuntu-10.10(32 bit) ASIC – Juniper LE [HD5750] CPU - Intel(R) Core(TM) 2 CPU 6300 @1.86GHz Steps to Reproduce: =================== 1) Connect display: DFP 2) startx 3) Install phoronix test suite as below a.Down load test suite from the below location http://www.phoronix-test-suite.com/releases/repo/pts.debian/files/phoronix-… b.sudo dpkg -i phoronix-test-suite_2.8.2_all.deb c.Install any dependency related to PHP with synaptic 4) Run X-testing application as below using phoronix-test-suite FORCE_TIMES_TO_RUN=1 phoronix-test-suite run x-testing Observation: Test runs for some time and after that System gets hang. Keyboard and Mouse are not working but able to ping the system IP. Additional Information: ----------------------------------- -->Issue is also observed with Redwood LP -->Issue is also observed with gtkperf test [FORCE_TIMES_TO_RUN=1 phoronix-test-suite run gtkperf] -->Issue is not observed with Cedar Pro [Bass] ASIC -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 4

← Newer
1
...
29
30
31
32
33
34
35
...
44
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2011