dri-devel June 2011

dri-devel@lists.freedesktop.org

101 participants
499 discussions

[Bug 36944] New: Family Farm: misrenders on r600g
by bugzilla-daemon＠freedesktop.org 24 Jun '11

24 Jun '11

https://bugs.freedesktop.org/show_bug.cgi?id=36944 Summary: Family Farm: misrenders on r600g Product: Mesa Version: git Platform: Other URL: http://www.familyfarmgame.com/en/linux-downloads OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: sa(a)whiz.se Created an attachment (id=46434) --> (https://bugs.freedesktop.org/attachment.cgi?id=46434) Screenshot of bug The game "Family Farm" isn't rendering correctly on r600g, I have attached screenshots showing the bug and correct rendering on llvmpipe. System environment: -- system architecture: 32-bit -- Linux distribution: Debian unstable -- GPU: REDWOOD -- Model: XFX Radeon HD 5670 1GB -- Display connector: DVI -- xf86-video-ati: 6.14.1 -- xserver: 1.10.1 -- mesa: 27d3e0b25cc3f2bd9f72778f0c9f54cb90c48622 -- drm: 2.4.25 -- kernel: 2.6.39-rc5 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 4

Re: [PATCH 00/35]: System Firmware and SMBIOS Support
by Arnd Bergmann 24 Jun '11

24 Jun '11

On Thursday 23 June 2011 19:22:06 Prarit Bhargava wrote: > This new patchset reworks the existing DMI code into two separate layers. It is > based off of the feedback I received previously when discussing the SMBIOS > version patch on LKML. Hi Prarit, No objections to the patches, but when you send out a series as long as this one, please ensure that all patches are sent as replies to the introductory mail. Also, do not repeat the one-line patch summary in the body of the email. When using "git send-email --thread --no-chain-reply", this works automatically. It will also let you put the Cc list into the patch description and work out where to send each patch. Arnd

1 0

[PATCH] drm/radeon/kms: increase rom size for atrm method
by Alex Deucher 24 Jun '11

24 Jun '11

The vbios rom is >64k on a lot of modern asics. Increase the fetch size for atrm to make sure we don't miss part of a larger rom. Signed-off-by: Alex Deucher <alexdeucher(a)gmail.com> --- drivers/gpu/drm/radeon/radeon_bios.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c index 1aba85c..3fc5fa1 100644 --- a/drivers/gpu/drm/radeon/radeon_bios.c +++ b/drivers/gpu/drm/radeon/radeon_bios.c @@ -104,7 +104,7 @@ static bool radeon_read_bios(struct radeon_device *rdev) static bool radeon_atrm_get_bios(struct radeon_device *rdev) { int ret; - int size = 64 * 1024; + int size = 256 * 1024; int i; if (!radeon_atrm_supported(rdev->pdev)) -- 1.7.1.1

1 0

[Bug 16721] ATI Mobility Radeon HD 5470 - Boot fails with KMS enabled
by bugzilla-daemon＠bugzilla.kernel.org 24 Jun '11

24 Jun '11

https://bugzilla.kernel.org/show_bug.cgi?id=16721 Jure Repinc <jlp.bugs(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #11 from Jure Repinc <jlp.bugs(a)gmail.com> 2011-06-24 10:19:27 --- Actually close -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 0

[Bug 16721] ATI Mobility Radeon HD 5470 - Boot fails with KMS enabled
by bugzilla-daemon＠bugzilla.kernel.org 24 Jun '11

24 Jun '11

https://bugzilla.kernel.org/show_bug.cgi?id=16721 Jure Repinc <jlp.bugs(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID --- Comment #10 from Jure Repinc <jlp.bugs(a)gmail.com> 2011-06-24 10:17:49 --- I closed as invalid since the problem was on my side and with firmware all works finr for quite some time now -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 0

[git pull] drm radeon fixes
by Dave Airlie 24 Jun '11

24 Jun '11

Two fixes from Alex, one fixes a possible hang on boot on some cards, the other fixes a fusion bug. Dave. The following changes since commit bccaeafd7c117acee36e90d37c7e05c19be9e7bf: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/shaggy/jfs-2.6 (2011-06-22 21:49:07 -0700) are available in the git repository at: ssh://master.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git drm-fixes Alex Deucher (2): drm/radeon/kms: fix num_banks tiling config for fusion drm/radeon/kms: handle special cases for vddc drivers/gpu/drm/radeon/evergreen.c | 4 +- drivers/gpu/drm/radeon/radeon.h | 1 + drivers/gpu/drm/radeon/radeon_atombios.c | 36 ++++++++++++++++++++++++++++++ 3 files changed, 39 insertions(+), 2 deletions(-)

1 0

drm/i915: double unlock in intel_setup_overlay()
by Dan Carpenter 23 Jun '11

23 Jun '11

Smatch complains about the recent locking changes in intel_setup_overlay() that it unlocks twice on an error path. I was also curious if we shouldn't call i915_gem_object_unpin() on that error path. I don't know the drm code well enough to know about unpinning so I'm sending this bug report instead of patching it myself. :) regards, dan carpenter drivers/gpu/drm/i915/intel_overlay.c +1471 intel_setup_overlay(73) error: double unlock 'mutex:&dev->struct_mutex' 1445 mutex_unlock(&dev->struct_mutex); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unlock. 1446 1447 /* init all values */ 1448 overlay->color_key = 0x0101fe; 1449 overlay->brightness = -19; 1450 overlay->contrast = 75; 1451 overlay->saturation = 146; 1452 1453 regs = intel_overlay_map_regs(overlay); 1454 if (!regs) 1455 goto out_free_bo; ^^^^^^^^^^^^^^^^^ we hit this goto here. 1456 1457 memset(regs, 0, sizeof(struct overlay_registers)); 1458 update_polyphase_filter(regs); 1459 update_reg_attrs(overlay, regs); 1460 1461 intel_overlay_unmap_regs(overlay, regs); 1462 1463 dev_priv->overlay = overlay; 1464 DRM_INFO("initialized overlay support\n"); 1465 return; 1466 1467 out_unpin_bo: 1468 i915_gem_object_unpin(reg_bo); 1469 out_free_bo: 1470 drm_gem_object_unreference(&reg_bo->base); 1471 mutex_unlock(&dev->struct_mutex); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ double unlock here. 1472 out_free: 1473 kfree(overlay); 1474 return; 1475 }

2 1

[Bug 33847] New: r600g hangs with WebGL
by bugzilla-daemon＠freedesktop.org 23 Jun '11

23 Jun '11

https://bugs.freedesktop.org/show_bug.cgi?id=33847 Summary: r600g hangs with WebGL Product: Mesa Version: git Platform: All OS/Version: All Status: NEW Severity: major Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: alexandre.f.demers(a)gmail.com Created an attachment (id=42862) --> (https://bugs.freedesktop.org/attachment.cgi?id=42862) r600g hang with Music Visualizer using WebGL I was testing latest chromium version with mesa git version. When testing Music Visualizer from Chromium Blog (http://blog.chromium.org/2010/12/webgl-now-in-beta-here-comes-3d-web.html), the GPU hanged. Dmesg log attached. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 1

Re: Oops in i915 intel_init_clock_gating
by Alan Stern 23 Jun '11

23 Jun '11

The problem of dev_priv->display.init_clock_gating not getting set is still present in 3.0-rc3. On my system this happens because intel_init_display() never gets called in the first place. AFAICT, the normal calling sequence during driver initialization is: i915_driver_load() -> i915_load_modeset_init() -> intel_modeset_init() -> intel_init_display(). But in my case the call to i915_load_modeset_init() doesn't occur because drm_core_check_feature(dev, DRIVER_MODESET) is False. I tested with the following patch: Index: usb-3.0/drivers/gpu/drm/i915/intel_display.c =================================================================== --- usb-3.0.orig/drivers/gpu/drm/i915/intel_display.c +++ usb-3.0/drivers/gpu/drm/i915/intel_display.c @@ -7511,6 +7511,10 @@ void intel_init_clock_gating(struct drm_ { struct drm_i915_private *dev_priv = dev->dev_private; + if (!dev_priv->display.init_clock_gating) { + printk(KERN_WARNING "init_clock_gating not set!\n"); + WARN_ON(1); + } else dev_priv->display.init_clock_gating(dev); if (dev_priv->display.init_pch_clock_gating) Index: usb-3.0/drivers/gpu/drm/i915/i915_dma.c =================================================================== --- usb-3.0.orig/drivers/gpu/drm/i915/i915_dma.c +++ usb-3.0/drivers/gpu/drm/i915/i915_dma.c @@ -2078,7 +2078,9 @@ int i915_driver_load(struct drm_device * intel_detect_pch(dev); +printk(KERN_INFO "Testing drm_core_check_feature DRIVER_MODESET\n"); if (drm_core_check_feature(dev, DRIVER_MODESET)) { +printk(KERN_INFO "Calling i915_load_modeset_init\n"); ret = i915_load_modeset_init(dev); if (ret < 0) { DRM_ERROR("failed to init modeset\n"); Here is the dmesg log showing what happens during "insmod i915.ko": [ 908.129497] pci 0000:00:02.0: setting latency timer to 64 [ 908.179865] [drm] Supports vblank timestamp caching Rev 1 (10.10.2010). [ 908.180633] [drm] No driver support for vblank timestamp query. [ 908.180804] Testing drm_core_check_feature DRIVER_MODESET [ 908.181120] [drm] Initialized i915 1.6.0 20080730 for 0000:00:02.0 on minor 0 The first debugging message is printed but not the second. Here is what happens during a resume from system suspend: [ 943.013656] init_clock_gating not set! [ 943.013790] ------------[ cut here ]------------ [ 943.013954] WARNING: at drivers/gpu/drm/i915/intel_display.c:7516 intel_init_clock_gating+0x30/0x4a [i915]() [ 943.014193] Hardware name: HP dx2000 MT (EE004AA) [ 943.014330] Modules linked in: i915 fbcon font bitblit softcursor drm_kms_helper drm fb fbdev i2c_algo_bit cfbcopyarea i2c_core video backlight cfbimgblt cfbfillrect e100 ohci_hcd mii pcspkr evdev uhci_hcd ehci_hcd fan processor thermal_sys button usbcore [last unloaded: i915] [ 943.015825] Pid: 1678, comm: bash Not tainted 3.0.0-rc3 #2 [ 943.015966] Call Trace: [ 943.016179] [<c1027315>] warn_slowpath_common+0x65/0x7a [ 943.016342] [<f013e716>] ? intel_init_clock_gating+0x30/0x4a [i915] [ 943.016487] [<c1027339>] warn_slowpath_null+0xf/0x13 [ 943.016644] [<f013e716>] intel_init_clock_gating+0x30/0x4a [i915] [ 943.016801] [<f012f1f9>] i915_restore_state+0xf4/0x1bf [i915] [ 943.016989] [<f0124100>] i915_drm_thaw+0x41/0xc1 [i915] [ 943.017141] [<f01242c0>] i915_resume+0x38/0x4b [i915] [ 943.017301] [<f00b0472>] drm_class_resume+0x39/0x3b [drm] [ 943.017447] [<c116b520>] legacy_resume+0x1e/0x46 [ 943.017599] [<f00b0439>] ? drm_class_suspend+0x3d/0x3d [drm] [ 943.017742] [<c116b7de>] device_resume+0x83/0xa0 [ 943.017881] [<c116bdd8>] dpm_resume+0xdc/0x156 [ 943.018020] [<c116bf68>] dpm_resume_end+0xb/0x15 [ 943.018162] [<c1053994>] suspend_devices_and_enter+0x165/0x192 [ 943.018330] [<c1053a93>] enter_state+0xd2/0x123 [ 943.018471] [<c105329f>] state_store+0x95/0xa1 [ 943.018610] [<c105320a>] ? pm_async_store+0x33/0x33 [ 943.018752] [<c1103c15>] kobj_attr_store+0x16/0x22 [ 943.018894] [<c10c7e5b>] sysfs_write_file+0xb3/0xec [ 943.019034] [<c10c7da8>] ? sysfs_open_file+0x1c2/0x1c2 [ 943.019176] [<c108d793>] vfs_write+0x76/0xa2 [ 943.019315] [<c108d8f6>] sys_write+0x3b/0x5d [ 943.019456] [<c11fb610>] sysenter_do_call+0x12/0x36 [ 943.019625] ---[ end trace dc74bd86a8bff7da ]--- What's the right way to fix this? Alan Stern

4 6

[PATCH] drm/radeon/kms: handle special cases for vddc
by Alex Deucher 23 Jun '11

23 Jun '11

A voltage value of 0xff01 requires that the driver look up the max voltage for the board based using the atom SetVoltage command table. Setting the proper voltage should fix stability on some newer asics. Signed-off-by: Alex Deucher <alexdeucher(a)gmail.com> --- drivers/gpu/drm/radeon/radeon.h | 1 + drivers/gpu/drm/radeon/radeon_atombios.c | 36 ++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h index 27f4557..ef0e0e0 100644 --- a/drivers/gpu/drm/radeon/radeon.h +++ b/drivers/gpu/drm/radeon/radeon.h @@ -179,6 +179,7 @@ void radeon_pm_resume(struct radeon_device *rdev); void radeon_combios_get_power_modes(struct radeon_device *rdev); void radeon_atombios_get_power_modes(struct radeon_device *rdev); void radeon_atom_set_voltage(struct radeon_device *rdev, u16 voltage_level, u8 voltage_type); +int radeon_atom_get_max_vddc(struct radeon_device *rdev, u16 *voltage); void rs690_pm_info(struct radeon_device *rdev); extern int rv6xx_get_temp(struct radeon_device *rdev); extern int rv770_get_temp(struct radeon_device *rdev); diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c index 1e725d9..bf2b615 100644 --- a/drivers/gpu/drm/radeon/radeon_atombios.c +++ b/drivers/gpu/drm/radeon/radeon_atombios.c @@ -2320,6 +2320,14 @@ static bool radeon_atombios_parse_pplib_clock_info(struct radeon_device *rdev, le16_to_cpu(clock_info->r600.usVDDC); } + /* patch up vddc if necessary */ + if (rdev->pm.power_state[state_index].clock_info[mode_index].voltage.voltage == 0xff01) { + u16 vddc; + + if (radeon_atom_get_max_vddc(rdev, &vddc) == 0) + rdev->pm.power_state[state_index].clock_info[mode_index].voltage.voltage = vddc; + } + if (rdev->flags & RADEON_IS_IGP) { /* skip invalid modes */ if (rdev->pm.power_state[state_index].clock_info[mode_index].sclk == 0) @@ -2630,7 +2638,35 @@ void radeon_atom_set_voltage(struct radeon_device *rdev, u16 voltage_level, u8 v atom_execute_table(rdev->mode_info.atom_context, index, (uint32_t *)&args); } +int radeon_atom_get_max_vddc(struct radeon_device *rdev, + u16 *voltage) +{ + union set_voltage args; + int index = GetIndexIntoMasterTable(COMMAND, SetVoltage); + u8 frev, crev; + + if (!atom_parse_cmd_header(rdev->mode_info.atom_context, index, &frev, &crev)) + return -EINVAL; + + switch (crev) { + case 1: + return -EINVAL; + case 2: + args.v2.ucVoltageType = SET_VOLTAGE_GET_MAX_VOLTAGE; + args.v2.ucVoltageMode = 0; + args.v2.usVoltageLevel = 0; + + atom_execute_table(rdev->mode_info.atom_context, index, (uint32_t *)&args); + + *voltage = le16_to_cpu(args.v2.usVoltageLevel); + break; + default: + DRM_ERROR("Unknown table version %d, %d\n", frev, crev); + return -EINVAL; + } + return 0; +} void radeon_atom_initialize_bios_scratch_regs(struct drm_device *dev) { -- 1.7.1.1

1 0

← Newer
1
...
32
33
34
35
36
37
38
...
50
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2011