dri-devel January 2012

dri-devel@lists.freedesktop.org

91 participants
570 discussions

[PATCH] drm/omap: fix minimum width/height
by Rob Clark 09 Jan '12

09 Jan '12

From: Rob Clark <rob(a)ti.com> Fix minimum width/height so planes could be used to implement hw mouse cursor. Signed-off-by: Rob Clark <rob(a)ti.com> --- drivers/staging/omapdrm/omap_drv.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/omapdrm/omap_drv.c b/drivers/staging/omapdrm/omap_drv.c index 9a8b00c..163f0ae 100644 --- a/drivers/staging/omapdrm/omap_drv.c +++ b/drivers/staging/omapdrm/omap_drv.c @@ -401,8 +401,8 @@ static int … [View More]

1 0

[PATCH] drm/sis|via: don't return stack garbage from free_mem ioctl
by Daniel Vetter 08 Jan '12

08 Jan '12

Fallout from my "kill drm_sman" refactor. Unfortunately gcc seems to have failed me and not warned about this. Tested-by: Jakob Bornecrantz <wallbraker(a)gmail.com> (on via) Signed-Off-by: Daniel Vetter <daniel.vetter(a)ffwll.ch> --- drivers/gpu/drm/sis/sis_mm.c | 3 +-- drivers/gpu/drm/via/via_mm.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sis/sis_mm.c b/drivers/gpu/drm/sis/sis_mm.c index 46cb2bc..dd4a316 100644 --- a/drivers/… [View More]

1 0

[Bug 38220] New: [wine] Left 4 Dead: Crash in r600_set_constant_buffer with multicore rendering
by bugzilla-daemon＠freedesktop.org 08 Jan '12

08 Jan '12

https://bugs.freedesktop.org/show_bug.cgi?id=38220 Summary: [wine] Left 4 Dead: Crash in r600_set_constant_buffer with multicore rendering Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: sa(a)whiz.se Created an attachment … [View More](id=47874) --> (https://bugs.freedesktop.org/attachment.cgi?id=47874) backtrace of crash The game Left 4 Dead (running in Wine) crashes in r600_set_constant_buffer if the option "Multicore rendering" is enabled. Backtrace from Wine: =>0 0x7b343de7 r600_set_constant_buffer+0x117(ctx=0x7c1b2728, shader=0, index=0, buffer=0x7cc3fbfc) [/home/sa/Programming/gfx/mesa/mesa/src/gallium/drivers/r600/r600_state_common.c:413] in r600_dri.so (0x7c1bd880) 1 0x7b4aecd6 st_upload_constants+0xe5(st=0x651138b8, params=0x7c11d8f8, shader_type=0) [/home/sa/Programming/gfx/mesa/mesa/src/mesa/state_tracker/st_atom_constbuf.c:92] in r600_dri.so (0x00000000) (A backtrace made with gdb is also attached). Not sure if it's a regression or not, the game suffered from recurring GPU hangs until just recently. The following messages are found in the kernel log: [15632.113691] [drm:evergreen_cs_packet_next_reloc] *ERROR* Relocs at 44 after relocations chunk end 32 ! [15632.113695] [drm:evergreen_packet3_check] *ERROR* bad SET_RESOURCE (tex) [15632.113697] [drm:radeon_cs_ioctl] *ERROR* Invalid command stream ! [15632.115005] [drm:evergreen_cs_packet_next_reloc] *ERROR* Relocs at 44 after relocations chunk end 36 ! [15632.115007] [drm:evergreen_packet3_check] *ERROR* bad SET_RESOURCE (tex) [15632.115009] [drm:radeon_cs_ioctl] *ERROR* Invalid command stream ! [15632.118327] [drm:evergreen_cs_packet_next_reloc] *ERROR* Relocs at 44 after relocations chunk end 36 ! [15632.118330] [drm:evergreen_packet3_check] *ERROR* bad SET_RESOURCE (tex) [15632.118331] [drm:radeon_cs_ioctl] *ERROR* Invalid command stream ! [15632.121651] [drm:evergreen_cs_packet_next_reloc] *ERROR* Relocs at 44 after relocations chunk end 36 ! [15632.121654] [drm:evergreen_packet3_check] *ERROR* bad SET_RESOURCE (tex) [15632.121655] [drm:radeon_cs_ioctl] *ERROR* Invalid command stream ! [15632.124992] [drm:evergreen_cs_packet_next_reloc] *ERROR* Relocs at 44 after relocations chunk end 36 ! [15632.124994] [drm:evergreen_packet3_check] *ERROR* bad SET_RESOURCE (tex) [15632.124996] [drm:radeon_cs_ioctl] *ERROR* Invalid command stream ! [15632.128348] [drm:evergreen_cs_packet_next_reloc] *ERROR* Relocs at 44 after relocations chunk end 36 ! [15632.128351] [drm:evergreen_packet3_check] *ERROR* bad SET_RESOURCE (tex) [15632.128352] [drm:radeon_cs_ioctl] *ERROR* Invalid command stream ! [15632.131666] [drm:evergreen_cs_packet_next_reloc] *ERROR* Relocs at 44 after relocations chunk end 36 ! [15632.131668] [drm:evergreen_packet3_check] *ERROR* bad SET_RESOURCE (tex) [15632.131670] [drm:radeon_cs_ioctl] *ERROR* Invalid command stream ! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. [View Less]

1 2

Re: [RFC PATCH v2 8/9] smp: refactor on_each_cpu to void returning func
by Russell King - ARM Linux 08 Jan '12

08 Jan '12

On Sun, Jan 08, 2012 at 03:32:28PM +0200, Gilad Ben-Yossef wrote: > on_each_cpu returns the retunr value of smp_call_function > which is hard coded to 0. > > Refactor on_each_cpu to a void function and the few callers > that check the return value to save compares and branches. > > Signed-off-by: Gilad Ben-Yossef <gilad(a)benyossef.com> > Acked-by: Peter Zijlstra <a.p.zijlstra(a)chello.nl> > Reviewed-by: Michal Nazarewicz <mina86(a)mina86.com> > … [View More]

1 0

[RFC PATCH v2 0/9] Remove useless on_each_cpu return value
by Gilad Ben-Yossef 08 Jan '12

08 Jan '12

on_each_cpu() returns as its own return value the return value of smp_call_function(). smp_call_function() in turn returns a hard coded value of zero. Some callers to on_each_cpu() waste cycles and bloat code space by checking the return value to on_each_cpu(), probably for historical reasons. This patch set refactors callers to not test on_each_cpu() (fixed) return value and then refactors on_each_cpu to return void to avoid confusing future users. In other words, this patch aims to delete … [View More]18 source code lines while not changing any functionality :-) I tested as best as I could the x86 changes and compiled some of the others, but I don't have access to all the needed hardware for testing. Reviewers and testers welcome! The only change from the first version is the addition of a proper Signed-off-by line. This patch set is also available on branch on_each_cpu_ret_v2 at git://github.com/gby/linux.git Signed-off-by: Gilad Ben-Yossef <gilad(a)benyossef.com> Acked-by: Peter Zijlstra <a.p.zijlstra(a)chello.nl> Reviewed-by: Michal Nazarewicz <mina86(a)mina86.com> CC: Michal Nazarewicz <mina86(a)mina86.com> CC: David Airlie <airlied(a)linux.ie> CC: dri-devel(a)lists.freedesktop.org CC: Benjamin Herrenschmidt <benh(a)kernel.crashing.org> CC: Paul Mackerras <paulus(a)samba.org> CC: Grant Likely <grant.likely(a)secretlab.ca> CC: Rob Herring <rob.herring(a)calxeda.com> CC: linuxppc-dev(a)lists.ozlabs.org CC: devicetree-discuss(a)lists.ozlabs.org CC: Richard Henderson <rth(a)twiddle.net> CC: Ivan Kokshaysky <ink(a)jurassic.park.msu.ru> CC: Matt Turner <mattst88(a)gmail.com> CC: linux-alpha(a)vger.kernel.org CC: Thomas Gleixner <tglx(a)linutronix.de> CC: Ingo Molnar <mingo(a)redhat.com> CC: "H. Peter Anvin" <hpa(a)zytor.com> CC: x86(a)kernel.org CC: Tony Luck <tony.luck(a)intel.com> CC: Fenghua Yu <fenghua.yu(a)intel.com> CC: linux-ia64(a)vger.kernel.org CC: Will Deacon <will.deacon(a)arm.com> CC: Peter Zijlstra <a.p.zijlstra(a)chello.nl> CC: Arnaldo Carvalho de Melo <acme(a)ghostprotocols.net> CC: Russell King <linux(a)arm.linux.org.uk> CC: linux-arm-kernel(a)lists.infradead.org Gilad Ben-Yossef (9): arm: avoid using on_each_cpu hard coded ret value ia64: avoid using on_each_cpu hard coded ret value x86: avoid using on_each_cpu hard coded ret value alpha: avoid using on_each_cpu hard coded ret value ppc: avoid using on_each_cpu hard coded ret value agp: avoid using on_each_cpu hard coded ret value drm: avoid using on_each_cpu hard coded ret value smp: refactor on_each_cpu to void returning func x86: refactor wbinvd_on_all_cpus to void function arch/alpha/kernel/smp.c | 7 ++----- arch/arm/kernel/perf_event.c | 2 +- arch/ia64/kernel/perfmon.c | 12 ++---------- arch/powerpc/kernel/rtas.c | 3 +-- arch/x86/include/asm/smp.h | 5 ++--- arch/x86/lib/cache-smp.c | 4 ++-- drivers/char/agp/generic.c | 3 +-- drivers/gpu/drm/drm_cache.c | 3 +-- include/linux/smp.h | 7 +++---- kernel/smp.c | 6 ++---- 10 files changed, 17 insertions(+), 35 deletions(-) [View Less]

1 1

[Bug 44523] New: nexuiz perf regression since u_vbuf: implement another upload codepath which unrolls indices
by bugzilla-daemon＠freedesktop.org 07 Jan '12

07 Jan '12

https://bugs.freedesktop.org/show_bug.cgi?id=44523 Bug #: 44523 Summary: nexuiz perf regression since u_vbuf: implement another upload codepath which unrolls indices Classification: Unclassified Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-… [View More]

1 1

[PATCH] drm/omap: updates for DSS fifomerge API changes
by Rob Clark 07 Jan '12

07 Jan '12

From: Rob Clark <rob(a)ti.com> Signed-off-by: Rob Clark <rob(a)ti.com> --- Greg, this patch updates omapdrm for fifomerge related API changes in omapdss, and would be needed so that omapdrm still compiles after these changes (which are in linux-next) hit Linus's tree. This applies on top of "drm/omap: multiplanar and YUV support" patch. drivers/staging/omapdrm/omap_crtc.c | 2 +- drivers/staging/omapdrm/omap_drv.h | 6 ++++++ drivers/staging/omapdrm/omap_plane.c | 33 +… [View More]+++++++++++++++++++++++--------- 3 files changed, 31 insertions(+), 10 deletions(-) diff --git a/drivers/staging/omapdrm/omap_crtc.c b/drivers/staging/omapdrm/omap_crtc.c index 3cee04e..17ca163 100644 --- a/drivers/staging/omapdrm/omap_crtc.c +++ b/drivers/staging/omapdrm/omap_crtc.c @@ -81,7 +81,7 @@ static int omap_crtc_mode_set(struct drm_crtc *crtc, struct omap_crtc *omap_crtc = to_omap_crtc(crtc); struct drm_plane *plane = omap_crtc->plane; - return plane->funcs->update_plane(plane, crtc, crtc->fb, + return omap_plane_mode_set(plane, crtc, crtc->fb, 0, 0, mode->hdisplay, mode->vdisplay, x << 16, y << 16, mode->hdisplay << 16, mode->vdisplay << 16); diff --git a/drivers/staging/omapdrm/omap_drv.h b/drivers/staging/omapdrm/omap_drv.h index 48f6fce..61fe022 100644 --- a/drivers/staging/omapdrm/omap_drv.h +++ b/drivers/staging/omapdrm/omap_drv.h @@ -69,6 +69,12 @@ struct drm_plane *omap_plane_init(struct drm_device *dev, struct omap_overlay *ovl, unsigned int possible_crtcs, bool priv); int omap_plane_dpms(struct drm_plane *plane, int mode); +int omap_plane_mode_set(struct drm_plane *plane, + struct drm_crtc *crtc, struct drm_framebuffer *fb, + int crtc_x, int crtc_y, + unsigned int crtc_w, unsigned int crtc_h, + uint32_t src_x, uint32_t src_y, + uint32_t src_w, uint32_t src_h); struct drm_encoder *omap_encoder_init(struct drm_device *dev, struct omap_overlay_manager *mgr); diff --git a/drivers/staging/omapdrm/omap_plane.c b/drivers/staging/omapdrm/omap_plane.c index 66eed75..9790912 100644 --- a/drivers/staging/omapdrm/omap_plane.c +++ b/drivers/staging/omapdrm/omap_plane.c @@ -85,7 +85,7 @@ static int commit(struct drm_plane *plane) } } - if (info->enabled) { + if (ovl->is_enabled(ovl)) { omap_framebuffer_flush(plane->fb, info->pos_x, info->pos_y, info->out_width, info->out_height); } @@ -115,7 +115,7 @@ static void update_manager(struct drm_plane *plane) } if (ovl->manager != mgr) { - bool enabled = omap_plane->info.enabled; + bool enabled = ovl->is_enabled(ovl); /* don't switch things around with enabled overlays: */ if (enabled) @@ -168,7 +168,8 @@ static void update_scanout(struct drm_plane *plane) if (ret) { dev_err(plane->dev->dev, "could not pin fb: %d\n", ret); - omap_plane->info.enabled = false; + omap_plane_dpms(plane, DRM_MODE_DPMS_OFF); + return; } omap_framebuffer_update_scanout(plane->fb, @@ -180,7 +181,7 @@ static void update_scanout(struct drm_plane *plane) info->screen_width); } -static int omap_plane_update(struct drm_plane *plane, +int omap_plane_mode_set(struct drm_plane *plane, struct drm_crtc *crtc, struct drm_framebuffer *fb, int crtc_x, int crtc_y, unsigned int crtc_w, unsigned int crtc_h, @@ -195,7 +196,6 @@ static int omap_plane_update(struct drm_plane *plane, src_w = src_w >> 16; src_h = src_h >> 16; - omap_plane->info.enabled = true; omap_plane->info.pos_x = crtc_x; omap_plane->info.pos_y = crtc_y; omap_plane->info.out_width = crtc_w; @@ -214,11 +214,22 @@ static int omap_plane_update(struct drm_plane *plane, update_scanout(plane); update_manager(plane); - commit(plane); return 0; } +static int omap_plane_update(struct drm_plane *plane, + struct drm_crtc *crtc, struct drm_framebuffer *fb, + int crtc_x, int crtc_y, + unsigned int crtc_w, unsigned int crtc_h, + uint32_t src_x, uint32_t src_y, + uint32_t src_w, uint32_t src_h) +{ + omap_plane_mode_set(plane, crtc, fb, crtc_x, crtc_y, crtc_w, crtc_h, + src_x, src_y, src_w, src_h); + return omap_plane_dpms(plane, DRM_MODE_DPMS_ON); +} + static int omap_plane_disable(struct drm_plane *plane) { return omap_plane_dpms(plane, DRM_MODE_DPMS_OFF); @@ -236,18 +247,22 @@ static void omap_plane_destroy(struct drm_plane *plane) int omap_plane_dpms(struct drm_plane *plane, int mode) { struct omap_plane *omap_plane = to_omap_plane(plane); + struct omap_overlay *ovl = omap_plane->ovl; + int r; DBG("%s: %d", omap_plane->ovl->name, mode); if (mode == DRM_MODE_DPMS_ON) { update_scanout(plane); - omap_plane->info.enabled = true; + r = commit(plane); + if (!r) + r = ovl->enable(ovl); } else { - omap_plane->info.enabled = false; + r = ovl->disable(ovl); update_pin(plane, NULL); } - return commit(plane); + return r; } static const struct drm_plane_funcs omap_plane_funcs = { -- 1.7.5.4 [View Less]

1 0

[Bug 44524] [radeon driver] Screen corruption when "Applications" has enough apps to have a scrollbar on Gnome Desktop
by bugzilla-daemon＠freedesktop.org 06 Jan '12

06 Jan '12

https://bugs.freedesktop.org/show_bug.cgi?id=44524 Michel Dänzer <michel(a)daenzer.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |7.11 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 44524] [radeon driver] Screen corruption when "Applications" has enough apps to have a scrollbar on Gnome Desktop
by bugzilla-daemon＠freedesktop.org 06 Jan '12

06 Jan '12

1 0

[PATCH 1/2] drm/radeon/kms: check if vm is supported in VA ioctl
by alexdeucher＠gmail.com 06 Jan '12

06 Jan '12

From: Alex Deucher <alexander.deucher(a)amd.com> Add a VM manager enabled field and use it to check if vm is enabled. Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Cc: jglisse(a)redhat.com --- drivers/gpu/drm/radeon/radeon.h | 2 ++ drivers/gpu/drm/radeon/radeon_cs.c | 4 ++-- drivers/gpu/drm/radeon/radeon_gart.c | 10 +++++++++- drivers/gpu/drm/radeon/radeon_gem.c | 5 +++++ 4 files changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/… [View More]gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h index 7cb63cd..73e05cb 100644 --- a/drivers/gpu/drm/radeon/radeon.h +++ b/drivers/gpu/drm/radeon/radeon.h @@ -668,6 +668,8 @@ struct radeon_vm_manager { unsigned nvm; /* vram base address for page table entry */ u64 vram_base_offset; + /* is vm enabled? */ + bool enabled; }; /* diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c index 17af0e8..435a3d9 100644 --- a/drivers/gpu/drm/radeon/radeon_cs.c +++ b/drivers/gpu/drm/radeon/radeon_cs.c @@ -234,8 +234,8 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data) } if ((p->cs_flags & RADEON_CS_USE_VM) && - (p->rdev->family < CHIP_CAYMAN)) { - DRM_ERROR("VM not supported on asic!\n"); + !p->rdev->vm_manager.enabled) { + DRM_ERROR("VM not active on asic!\n"); if (p->chunk_relocs_idx != -1) kfree(p->chunks[p->chunk_relocs_idx].kdata); if (p->chunk_flags_idx != -1) diff --git a/drivers/gpu/drm/radeon/radeon_gart.c b/drivers/gpu/drm/radeon/radeon_gart.c index 3ef58ca..8597d2c 100644 --- a/drivers/gpu/drm/radeon/radeon_gart.c +++ b/drivers/gpu/drm/radeon/radeon_gart.c @@ -286,6 +286,8 @@ int radeon_vm_manager_init(struct radeon_device *rdev) { int r; + rdev->vm_manager.enabled = false; + /* mark first vm as always in use, it's the system one */ r = radeon_sa_bo_manager_init(rdev, &rdev->vm_manager.sa_manager, rdev->vm_manager.max_pfn * 8, @@ -295,7 +297,12 @@ int radeon_vm_manager_init(struct radeon_device *rdev) (rdev->vm_manager.max_pfn * 8) >> 10); return r; } - return rdev->vm_manager.funcs->init(rdev); + + r = rdev->vm_manager.funcs->init(rdev); + if (r == 0) + rdev->vm_manager.enabled = true; + + return r; } /* cs mutex must be lock */ @@ -334,6 +341,7 @@ void radeon_vm_manager_fini(struct radeon_device *rdev) radeon_vm_manager_suspend(rdev); rdev->vm_manager.funcs->fini(rdev); radeon_sa_bo_manager_fini(rdev, &rdev->vm_manager.sa_manager); + rdev->vm_manager.enabled = false; } int radeon_vm_manager_start(struct radeon_device *rdev) diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/drivers/gpu/drm/radeon/radeon_gem.c index 003eeec..7337850 100644 --- a/drivers/gpu/drm/radeon/radeon_gem.c +++ b/drivers/gpu/drm/radeon/radeon_gem.c @@ -404,6 +404,11 @@ int radeon_gem_va_ioctl(struct drm_device *dev, void *data, u32 invalid_flags; int r = 0; + if (!rdev->vm_manager.enabled) { + args->operation = RADEON_VA_RESULT_ERROR; + return -ENOTTY; + } + /* !! DONT REMOVE !! * We don't support vm_id yet, to be sure we don't have have broken * userspace, reject anyone trying to use non 0 value thus moving -- 1.7.3.4 [View Less]

1 1

← Newer
1
...
50
51
52
53
54
55
56
57
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2012