dri-devel November 2012

dri-devel@lists.freedesktop.org

126 participants
797 discussions

[PATCH] drm: exynos: hdmi: sending AVI and AUI info frames
by Rahul Sharma 23 Nov '12

23 Nov '12

This patch adds code for composing AVI and AUI info frames and send them every VSYNC. This patch is important for hdmi certification. Based on exynos-drm-fixes branch of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git Signed-off-by: Rahul Sharma <rahul.sharma(a)samsung.com> Signed-off-by: Fahad Kunnathadi <fahad.k(a)samsung.com> Signed-off-by: Shirish S <s.shirish(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_hdmi.c | 142 +++++++++++++++++++++++++++++----- drivers/gpu/drm/exynos/exynos_hdmi.h | 23 ++++++ drivers/gpu/drm/exynos/regs-hdmi.h | 17 ++++- 3 files changed, 161 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index ee110c9..5ffedc3 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -185,6 +185,7 @@ struct hdmi_v13_conf { int height; int vrefresh; bool interlace; + int cea_video_id; const u8 *hdmiphy_data; const struct hdmi_v13_preset_conf *conf; }; @@ -356,15 +357,20 @@ static const struct hdmi_v13_preset_conf hdmi_v13_conf_1080p60 = { }; static const struct hdmi_v13_conf hdmi_v13_confs[] = { - { 1280, 720, 60, false, hdmiphy_v13_conf74_25, &hdmi_v13_conf_720p60 }, - { 1280, 720, 50, false, hdmiphy_v13_conf74_25, &hdmi_v13_conf_720p60 }, - { 720, 480, 60, false, hdmiphy_v13_conf27_027, &hdmi_v13_conf_480p }, - { 1920, 1080, 50, true, hdmiphy_v13_conf74_25, &hdmi_v13_conf_1080i50 }, - { 1920, 1080, 50, false, hdmiphy_v13_conf148_5, - &hdmi_v13_conf_1080p50 }, - { 1920, 1080, 60, true, hdmiphy_v13_conf74_25, &hdmi_v13_conf_1080i60 }, - { 1920, 1080, 60, false, hdmiphy_v13_conf148_5, - &hdmi_v13_conf_1080p60 }, + { 1280, 720, 60, false, 4, hdmiphy_v13_conf74_25, + &hdmi_v13_conf_720p60 }, + { 1280, 720, 50, false, 19, hdmiphy_v13_conf74_25, + &hdmi_v13_conf_720p60 }, + { 720, 480, 60, false, 3, hdmiphy_v13_conf27_027, + &hdmi_v13_conf_480p }, + { 1920, 1080, 50, true, 20, hdmiphy_v13_conf74_25, + &hdmi_v13_conf_1080i50 }, + { 1920, 1080, 50, false, 31, hdmiphy_v13_conf148_5, + &hdmi_v13_conf_1080p50 }, + { 1920, 1080, 60, true, 5, hdmiphy_v13_conf74_25, + &hdmi_v13_conf_1080i60 }, + { 1920, 1080, 60, false, 16, hdmiphy_v13_conf148_5, + &hdmi_v13_conf_1080p60 }, }; /* HDMI Version 1.4 */ @@ -482,6 +488,7 @@ struct hdmi_conf { int height; int vrefresh; bool interlace; + int cea_video_id; const u8 *hdmiphy_data; const struct hdmi_preset_conf *conf; }; @@ -937,16 +944,21 @@ static const struct hdmi_preset_conf hdmi_conf_1080p60 = { }; static const struct hdmi_conf hdmi_confs[] = { - { 720, 480, 60, false, hdmiphy_conf27_027, &hdmi_conf_480p60 }, - { 1280, 720, 50, false, hdmiphy_conf74_25, &hdmi_conf_720p50 }, - { 1280, 720, 60, false, hdmiphy_conf74_25, &hdmi_conf_720p60 }, - { 1920, 1080, 50, true, hdmiphy_conf74_25, &hdmi_conf_1080i50 }, - { 1920, 1080, 60, true, hdmiphy_conf74_25, &hdmi_conf_1080i60 }, - { 1920, 1080, 30, false, hdmiphy_conf74_176, &hdmi_conf_1080p30 }, - { 1920, 1080, 50, false, hdmiphy_conf148_5, &hdmi_conf_1080p50 }, - { 1920, 1080, 60, false, hdmiphy_conf148_5, &hdmi_conf_1080p60 }, + { 720, 480, 60, false, 3, hdmiphy_conf27_027, &hdmi_conf_480p60 }, + { 1280, 720, 50, false, 19, hdmiphy_conf74_25, &hdmi_conf_720p50 }, + { 1280, 720, 60, false, 4, hdmiphy_conf74_25, &hdmi_conf_720p60 }, + { 1920, 1080, 50, true, 20, hdmiphy_conf74_25, &hdmi_conf_1080i50 }, + { 1920, 1080, 60, true, 5, hdmiphy_conf74_25, &hdmi_conf_1080i60 }, + { 1920, 1080, 30, false, 34, hdmiphy_conf74_176, &hdmi_conf_1080p30 }, + { 1920, 1080, 50, false, 31, hdmiphy_conf148_5, &hdmi_conf_1080p50 }, + { 1920, 1080, 60, false, 16, hdmiphy_conf148_5, &hdmi_conf_1080p60 }, }; +struct hdmi_infoframe { + enum HDMI_PACKET_TYPE type; + u8 ver; + u8 len; +}; static inline u32 hdmi_reg_read(struct hdmi_context *hdata, u32 reg_id) { @@ -1270,6 +1282,88 @@ static int hdmi_conf_index(struct hdmi_context *hdata, return hdmi_v14_conf_index(mode); } +static u8 hdmi_chksum(struct hdmi_context *hdata, + u32 start, u8 len, u32 hdr_sum) +{ + int i; + /* hdr_sum : header0 + header1 + header2 + * start : start address of packet byte1 + * len : packet bytes - 1 */ + for (i = 0; i < len; ++i) + hdr_sum += 0xff & hdmi_reg_read(hdata, start + i * 4); + + return (u8)(0x100 - (hdr_sum & 0xff)); +} + +void hdmi_reg_infoframe(struct hdmi_context *hdata, + struct hdmi_infoframe *infoframe) +{ + u32 hdr_sum; + u8 chksum; + u32 aspect_ratio; + u32 mod; + u32 vic; + + DRM_DEBUG_KMS("[%d] %s\n", __LINE__, __func__); + + mod = hdmi_reg_read(hdata, HDMI_MODE_SEL); + if (hdata->dvi_mode) { + hdmi_reg_writeb(hdata, HDMI_VSI_CON, + HDMI_VSI_CON_DO_NOT_TRANSMIT); + hdmi_reg_writeb(hdata, HDMI_AVI_CON, + HDMI_AVI_CON_DO_NOT_TRANSMIT); + hdmi_reg_writeb(hdata, HDMI_AUI_CON, HDMI_AUI_CON_NO_TRAN); + return; + } + + switch (infoframe->type) { + + case HDMI_PACKET_TYPE_AVI: + hdmi_reg_writeb(hdata, HDMI_AVI_CON, HDMI_AVI_CON_EVERY_VSYNC); + hdmi_reg_writeb(hdata, HDMI_AVI_HEADER0, infoframe->type); + hdmi_reg_writeb(hdata, HDMI_AVI_HEADER1, infoframe->ver); + hdmi_reg_writeb(hdata, HDMI_AVI_HEADER2, infoframe->len); + hdr_sum = infoframe->type + infoframe->ver + infoframe->len; + /* Output format zero hardcoded ,RGB YBCR selection */ + hdmi_reg_writeb(hdata, HDMI_AVI_BYTE(1), 0 << 5 | + AVI_ACTIVE_FORMAT_VALID | + AVI_UNDERSCANNED_DISPLAY_VALID); + + aspect_ratio = AVI_PIC_ASPECT_RATIO_16_9; + + hdmi_reg_writeb(hdata, HDMI_AVI_BYTE(2), aspect_ratio | + AVI_SAME_AS_PIC_ASPECT_RATIO); + + if (hdata->type == HDMI_TYPE13) + vic = hdmi_v13_confs[hdata->cur_conf].cea_video_id; + else + vic = hdmi_confs[hdata->cur_conf].cea_video_id; + + hdmi_reg_writeb(hdata, HDMI_AVI_BYTE(4), vic); + + chksum = hdmi_chksum(hdata, HDMI_AVI_BYTE(1), + infoframe->len, hdr_sum); + DRM_DEBUG_KMS("AVI checksum = 0x%x\n", chksum); + hdmi_reg_writeb(hdata, HDMI_AVI_CHECK_SUM, chksum); + break; + + case HDMI_PACKET_TYPE_AUI: + hdmi_reg_writeb(hdata, HDMI_AUI_CON, 0x02); + hdmi_reg_writeb(hdata, HDMI_AUI_HEADER0, infoframe->type); + hdmi_reg_writeb(hdata, HDMI_AUI_HEADER1, infoframe->ver); + hdmi_reg_writeb(hdata, HDMI_AUI_HEADER2, infoframe->len); + hdr_sum = infoframe->type + infoframe->ver + infoframe->len; + chksum = hdmi_chksum(hdata, HDMI_AUI_BYTE(1), + infoframe->len, hdr_sum); + DRM_DEBUG_KMS("AUI checksum = 0x%x\n", chksum); + hdmi_reg_writeb(hdata, HDMI_AUI_CHECK_SUM, chksum); + break; + + default: + break; + } +} + static bool hdmi_is_connected(void *ctx) { struct hdmi_context *hdata = ctx; @@ -1544,6 +1638,8 @@ static void hdmi_conf_reset(struct hdmi_context *hdata) static void hdmi_conf_init(struct hdmi_context *hdata) { + struct hdmi_infoframe infoframe; + /* disable HPD interrupts */ hdmi_reg_writemask(hdata, HDMI_INTC_CON, 0, HDMI_INTC_EN_GLOBAL | HDMI_INTC_EN_HPD_PLUG | HDMI_INTC_EN_HPD_UNPLUG); @@ -1578,9 +1674,17 @@ static void hdmi_conf_init(struct hdmi_context *hdata) hdmi_reg_writeb(hdata, HDMI_V13_AUI_CON, 0x02); hdmi_reg_writeb(hdata, HDMI_V13_ACR_CON, 0x04); } else { + infoframe.type = HDMI_PACKET_TYPE_AVI; + infoframe.ver = HDMI_AVI_VERSION; + infoframe.len = HDMI_AVI_LENGTH; + hdmi_reg_infoframe(hdata, &infoframe); + + infoframe.type = HDMI_PACKET_TYPE_AUI; + infoframe.ver = HDMI_AUI_VERSION; + infoframe.len = HDMI_AUI_LENGTH; + hdmi_reg_infoframe(hdata, &infoframe); + /* enable AVI packet every vsync, fixes purple line problem */ - hdmi_reg_writeb(hdata, HDMI_AVI_CON, 0x02); - hdmi_reg_writeb(hdata, HDMI_AVI_BYTE(1), 2 << 5); hdmi_reg_writemask(hdata, HDMI_CON_1, 2, 3 << 5); } } diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.h b/drivers/gpu/drm/exynos/exynos_hdmi.h index 1c3b6d8..fc4de49 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.h +++ b/drivers/gpu/drm/exynos/exynos_hdmi.h @@ -28,6 +28,29 @@ #ifndef _EXYNOS_HDMI_H_ #define _EXYNOS_HDMI_H_ +/* AVI header and aspect ratio */ +#define HDMI_AVI_VERSION 0x02 +#define HDMI_AVI_LENGTH 0x0d +#define AVI_PIC_ASPECT_RATIO_16_9 (2 << 4) +#define AVI_SAME_AS_PIC_ASPECT_RATIO 8 + +/* AUI header info */ +#define HDMI_AUI_VERSION 0x01 +#define HDMI_AUI_LENGTH 0x0a + +/* HDMI infoframe to configure HDMI out packet header, AUI and AVI */ +enum HDMI_PACKET_TYPE { + /** refer to Table 5-8 Packet Type in HDMI specification v1.4a */ + /** InfoFrame packet type */ + HDMI_PACKET_TYPE_INFOFRAME = 0X80, + /** Vendor-Specific InfoFrame */ + HDMI_PACKET_TYPE_VSI = HDMI_PACKET_TYPE_INFOFRAME + 1, + /** Auxiliary Video information InfoFrame */ + HDMI_PACKET_TYPE_AVI = HDMI_PACKET_TYPE_INFOFRAME + 2, + /** Audio information InfoFrame */ + HDMI_PACKET_TYPE_AUI = HDMI_PACKET_TYPE_INFOFRAME + 4 +}; + void hdmi_attach_ddc_client(struct i2c_client *ddc); void hdmi_attach_hdmiphy_client(struct i2c_client *hdmiphy); diff --git a/drivers/gpu/drm/exynos/regs-hdmi.h b/drivers/gpu/drm/exynos/regs-hdmi.h index 9cc7c5e..970cdb5 100644 --- a/drivers/gpu/drm/exynos/regs-hdmi.h +++ b/drivers/gpu/drm/exynos/regs-hdmi.h @@ -298,14 +298,14 @@ #define HDMI_AVI_HEADER1 HDMI_CORE_BASE(0x0714) #define HDMI_AVI_HEADER2 HDMI_CORE_BASE(0x0718) #define HDMI_AVI_CHECK_SUM HDMI_CORE_BASE(0x071C) -#define HDMI_AVI_BYTE(n) HDMI_CORE_BASE(0x0720 + 4 * (n)) +#define HDMI_AVI_BYTE(n) HDMI_CORE_BASE(0x0720 + 4 * (n-1)) #define HDMI_AUI_CON HDMI_CORE_BASE(0x0800) #define HDMI_AUI_HEADER0 HDMI_CORE_BASE(0x0810) #define HDMI_AUI_HEADER1 HDMI_CORE_BASE(0x0814) #define HDMI_AUI_HEADER2 HDMI_CORE_BASE(0x0818) #define HDMI_AUI_CHECK_SUM HDMI_CORE_BASE(0x081C) -#define HDMI_AUI_BYTE(n) HDMI_CORE_BASE(0x0820 + 4 * (n)) +#define HDMI_AUI_BYTE(n) HDMI_CORE_BASE(0x0820 + 4 * (n-1)) #define HDMI_MPG_CON HDMI_CORE_BASE(0x0900) #define HDMI_MPG_CHECK_SUM HDMI_CORE_BASE(0x091C) @@ -338,6 +338,19 @@ #define HDMI_AN_SEED_2 HDMI_CORE_BASE(0x0E60) #define HDMI_AN_SEED_3 HDMI_CORE_BASE(0x0E64) +/* AVI bit definition */ +#define HDMI_AVI_CON_DO_NOT_TRANSMIT (0 << 1) +#define HDMI_AVI_CON_EVERY_VSYNC (1 << 1) + +#define AVI_ACTIVE_FORMAT_VALID (1 << 4) +#define AVI_UNDERSCANNED_DISPLAY_VALID (1 << 1) + +/* AUI bit definition */ +#define HDMI_AUI_CON_NO_TRAN (0 << 0) + +/* VSI bit definition */ +#define HDMI_VSI_CON_DO_NOT_TRANSMIT (0 << 0) + /* HDCP related registers */ #define HDMI_HDCP_SHA1(n) HDMI_CORE_BASE(0x7000 + 4 * (n)) #define HDMI_HDCP_KSV_LIST(n) HDMI_CORE_BASE(0x7050 + 4 * (n)) -- 1.7.0.4

2 1

[Bug 49121] Regression: ATI video card doesn't power down after elapsed time
by bugzilla-daemon＠bugzilla.kernel.org 22 Nov '12

22 Nov '12

https://bugzilla.kernel.org/show_bug.cgi?id=49121 --- Comment #3 from Joseph D. Wagner <joe(a)josephdwagner.info> 2012-11-22 21:43:33 --- Issue appears to be resolved in 3.6.6-1.fc17.x86_64 (gcc version 4.7.2 20120921 (Red Hat 4.7.2-2) (GCC) ). -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 0

Re: i915: black screen after blank when LID is closed on Linux >= 3.1
by Krzysztof Mazur 22 Nov '12

22 Nov '12

On Thu, Nov 22, 2012 at 09:17:54PM +0100, Daniel Vetter wrote: > Hi, > > > Since a dpms ioctl call tends to follow a modeset, this likely only > results in that dpms call enabling the hw again. Can you please add > drm.debug=0xe to your kernel cmdline and boot into a 3.6 with this > hack applied, reproduce the issue and the attach the complete dmesg? > > The below WARNs from 3.7 support that, we've simply improved the > code's ability to detect such problems. Can you please boot into a > kernel with the latest drm-intel-next-queued branch merged in, but no > other patches applied. Again please append drm.debug=0xe and then > attach the complete dmesg after you've reproduced the issue. > > Please also compile your kernels with CONFIG_PRINTK_TIME=y, the > timestamps in dmesg help a lot in figuring things out. In lastest drm-intel-next-queued (v3.7-rc4-323-g9352dce) I got following compile error: /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_lvds.c: In function 'intel_lvds_init': /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_lvds.c:1098:34: error: 'mode' undeclared (first use in this function) /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_lvds.c:1098:34: note: each undeclared identifier is reported only once for each function it appears in Without thinking I fixed it by: diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c index ced06f3..43f0874 100644 --- a/drivers/gpu/drm/i915/intel_lvds.c +++ b/drivers/gpu/drm/i915/intel_lvds.c @@ -1095,7 +1095,7 @@ bool intel_lvds_init(struct drm_device *dev) fixed_mode = intel_crtc_mode_get(dev, crtc); if (fixed_mode) { DRM_DEBUG_KMS("using current (BIOS) mode: "); - drm_mode_debug_printmodeline(&mode); + drm_mode_debug_printmodeline(fixed_mode); fixed_mode->type |= DRM_MODE_TYPE_PREFERRED; goto out; } Thanks, Krzysiek

2 1

[drm-intel:drm-intel-next-queued 31/31] drivers/gpu/drm/i915/intel_lvds.c:1098:34: error: 'mode' undeclared
by kbuild test robot 22 Nov '12

22 Nov '12

tree: git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-next-queued head: 9352dce341352e32a221aabf03f8b7c7b141c96a commit: 9352dce341352e32a221aabf03f8b7c7b141c96a [31/31] drm/i915: Report the origin of the LVDS fixed panel mode config: make ARCH=x86_64 allmodconfig All error/warnings: drivers/gpu/drm/i915/intel_lvds.c: In function 'intel_lvds_init': drivers/gpu/drm/i915/intel_lvds.c:1098:34: error: 'mode' undeclared (first use in this function) drivers/gpu/drm/i915/intel_lvds.c:1098:34: note: each undeclared identifier is reported only once for each function it appears in vim +1098 +/mode drivers/gpu/drm/i915/intel_lvds.c f875c15a Chris Wilson 2010-09-09 1092 crtc = intel_get_crtc_for_pipe(dev, pipe); 79e53945 Jesse Barnes 2008-11-07 1093 79e53945 Jesse Barnes 2008-11-07 1094 if (crtc && (lvds & LVDS_PORT_EN)) { dd06f90e Jani Nikula 2012-10-19 1095 fixed_mode = intel_crtc_mode_get(dev, crtc); dd06f90e Jani Nikula 2012-10-19 1096 if (fixed_mode) { 9352dce3 Chris Wilson 2012-11-21 1097 DRM_DEBUG_KMS("using current (BIOS) mode: "); 9352dce3 Chris Wilson 2012-11-21 @1098 drm_mode_debug_printmodeline(&mode); dd06f90e Jani Nikula 2012-10-19 1099 fixed_mode->type |= DRM_MODE_TYPE_PREFERRED; 565dcd46 Paul Collins 2009-02-04 1100 goto out; 79e53945 Jesse Barnes 2008-11-07 1101 } --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation

1 0

Re: i915: black screen after blank when LID is closed on Linux >= 3.1
by Krzysztof Mazur 22 Nov '12

22 Nov '12

On Thu, Nov 22, 2012 at 09:17:54PM +0100, Daniel Vetter wrote: > Hi, > > Thanks for the report. Now this smells like something which could take > a bit longer to track down, so can you please file this on > bugs.freedesktop.org against DRM -> DRI/Intel to ensure that we dont' > loose track of it? Yes, I will add a bug report there. > > A few questions and things to test below. > > On Thu, Nov 22, 2012 at 7:54 PM, Krzysztof Mazur <krzysiek(a)podlesie.net> wrote: > > since Linux 3.1 I'm having some problems with i915 driver on HP nc6120 > > with 915GM chipset. The display goes black after the kernel tries to > > blank screen while LID is closed (see steps to reproduce to more detailed > > description). > > > > Currently I'm using Linux 3.7-rc6 with KMS enabled and disabled ACPI > > video by something equivalent to (without it the LID, and the whole > > ACPI, does not work): > > Can you be more specific about what does not work? Do the lid events > no longer function, or is something else broken? It's a separate issue, probably not related to i915 driver. However it might be important that I have disabled ACPI video, and it might cause later problems so I added that information. However in < 3.1 kernel I also had disabled ACPI video and everything worked without problems. This ACPI problem started around 2.6.33 (the first workaround I used is on top of 2.6.33.7: commit 1dcdd646523a63a9e6476fd5ef46d82c67bb9a99 Author: Krzysztof Mazur <krzysiek(a)podlesie.net> Date: Wed Aug 11 09:35:35 2010 +0200 disable ACPI video ACPI video causes problem on HP Compaq nc6120. After starting of X lid stops working. diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index b765790..1427cbb 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c @@ -2478,7 +2478,8 @@ static int __init acpi_video_init(void) { dmi_check_system(video_dmi_table); - if (intel_opregion_present()) + /* KM: test for nc6120 */ + if (intel_opregion_present() || 1) return 0; return acpi_video_register(); ) I found similar bug reported on https://bugzilla.redhat.com/show_bug.cgi?id=512958 and I never reported that. I also tried: static int acpi_video_bus_start_devices(struct acpi_video_bus *video) { + return acpi_video_bus_DOS(video, 3, 0); return acpi_video_bus_DOS(video, 0, 0); } but without success. Without ACPI video driver loaded everything works, LID button sends ACPI events, the display is tuned off when LID is pressed. After loading ACPI video driver the LID stops sending ACPI events, and some other really strange issues starts - for instance reading /sys/class/thermal/thermal_zone%d/tempcauses causes displaying "^@" in console. > > > > In Linux 3.1 to 3.6 I've been using following workaround: > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > > index 2163818..51ebb77 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -6000,10 +6000,12 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc, > > x, y, old_fb); > > drm_vblank_post_modeset(dev, pipe); > > > > +#if 0 > > if (ret) > > intel_crtc->dpms_mode = DRM_MODE_DPMS_OFF; > > else > > intel_crtc->dpms_mode = DRM_MODE_DPMS_ON; > > +#endif > > > > return ret; > > } > > Since a dpms ioctl call tends to follow a modeset, this likely only > results in that dpms call enabling the hw again. Can you please add > drm.debug=0xe to your kernel cmdline and boot into a 3.6 with this > hack applied, reproduce the issue and the attach the complete dmesg? > > The below WARNs from 3.7 support that, we've simply improved the > code's ability to detect such problems. Can you please boot into a > kernel with the latest drm-intel-next-queued branch merged in, but no > other patches applied. Again please append drm.debug=0xe and then > attach the complete dmesg after you've reproduced the issue. Thanks, I will check that, but probably I will need to disable ACPI video, because without it the LID does not work so the problem cannot be probably triggered. > > Please also compile your kernels with CONFIG_PRINTK_TIME=y, the > timestamps in dmesg help a lot in figuring things out. > > Yours, Daniel > Thanks, Krzysiek

1 0

Re: [PATCH v3] DRM/KMS/EDID: Consolidate EDID Error Handling (v3)
by Egbert Eich 22 Nov '12

22 Nov '12

Ville Syrj�l� writes: > On Thu, Nov 22, 2012 at 07:28:44PM +0100, Egbert Eich wrote: > > > > Something similar should be done for drm_edid_is_valid() - even if the > > driver doesn't bother (for instance because this function is only called > > once when the device structures are initialized). > > > > The current code ignores the error state for extension blocks i guess it > > should not if we want to avoid having repreated logging of errors in the > > extension blocks. > > I'm not sure. The current code dump all failed extension block, doesn't > it? Maybe we actually do want that to happen, at least w/ debugs > enabled. Yes, it does. It drops them silently. I was a bit unclear - what I meant was: we ignore the result for the final error state we keep to be able to track which errors we still want to log. > > Then there are various retry loops in the code, which may or may not be > necessary. I have a feeling some of them may have been attempts at > papering over a bug that I fixed [1] in the i2c bitbanging code. But if > they are necessary, I'm not sure we really appreciate repeated dumps of > the same block. > > [1] https://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=8e… Right, I know this patch :) I'm also not sure about the retries. I guess for the base block we want at least one retry in case the display is in an intermediate state where it will not send the base block. Apart from this I've seen many EDID failures however I don't recall seeing one which got fixed by repeated reads. However to see if those loops fix any issue we may want to keep all messages enabled for the time being. Cheers, Egbert.

1 0

i915: black screen after blank when LID is closed on Linux >= 3.1
by Krzysztof Mazur 22 Nov '12

22 Nov '12

Hi, since Linux 3.1 I'm having some problems with i915 driver on HP nc6120 with 915GM chipset. The display goes black after the kernel tries to blank screen while LID is closed (see steps to reproduce to more detailed description). Currently I'm using Linux 3.7-rc6 with KMS enabled and disabled ACPI video by something equivalent to (without it the LID, and the whole ACPI, does not work): diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index 0230cb6..40e060b 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c @@ -1782,6 +1797,10 @@ static int __init intel_opregion_present(void) int acpi_video_register(void) { int result = 0; + return -ENODEV; if (register_count) { /* * if the function of acpi_video_register is already called, I also tested this kernel with merged git://people.freedesktop.org/~danvet/drm-intel drm-intel-next. Steps to reproduce: 1. $ setterm -blank 1 2. close LID 3. sleep 90 4. open LID 5. press key 6. close LID nothing happens here, the screen is still turned on, should be turned off 7. open LID backlight is on, but screen is black, but some artifacts are visible so LCD is probably turned off, and the display is not usable anymore I have bisected this problem and it's introduced by commit 120eced9efe7fdb5123db4ea47e9adee9b66284e (drm/i915: Set crtc DPMS mode to ON in intel_crtc_mode_set). In Linux 3.1 to 3.6 I've been using following workaround: diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 2163818..51ebb77 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -6000,10 +6000,12 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc, x, y, old_fb); drm_vblank_post_modeset(dev, pipe); +#if 0 if (ret) intel_crtc->dpms_mode = DRM_MODE_DPMS_OFF; else intel_crtc->dpms_mode = DRM_MODE_DPMS_ON; +#endif return ret; } Thanks, Krzysiek --- # lspci -v ... 00:02.0 VGA compatible controller: Intel Corporation Mobile 915GM/GMS/910GML Express Graphics Controller (rev 03) (prog-if 00 [VGA controller]) Subsystem: Hewlett-Packard Company NX6110/NC6120 Flags: bus master, fast devsel, latency 0, IRQ 16 Memory at d0400000 (32-bit, non-prefetchable) [size=512K] I/O ports at 7000 [size=8] Memory at c0000000 (32-bit, prefetchable) [size=256M] Memory at d0480000 (32-bit, non-prefetchable) [size=256K] Expansion ROM at <unassigned> [disabled] Capabilities: [d0] Power Management version 2 Kernel driver in use: i915 00:02.1 Display controller: Intel Corporation Mobile 915GM/GMS/910GML Express Graphics Controller (rev 03) Subsystem: Hewlett-Packard Company NX6110/NC6120 Flags: bus master, fast devsel, latency 0 Memory at d0500000 (32-bit, non-prefetchable) [size=512K] Capabilities: [d0] Power Management version 2 $ dmesg ... ------------[ cut here ]------------ WARNING: at /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_display.c:3588 intel_modeset_check_state+0x612/0x640() Hardware name: NC6120(EK094ES) active connector not linked to encoder Pid: 420, comm: kworker/0:2 Not tainted 3.7.0-rc6-00003-gddba8b4 #83 Call Trace: [<80131173>] ? warn_slowpath_common+0x73/0xb0 [<80394cc2>] ? intel_modeset_check_state+0x612/0x640 [<80394cc2>] ? intel_modeset_check_state+0x612/0x640 [<80131203>] ? warn_slowpath_fmt+0x33/0x40 [<80394cc2>] ? intel_modeset_check_state+0x612/0x640 [<8032336f>] ? acpi_lid_open+0x25/0x3e [<8039962d>] ? intel_lid_notify+0x8d/0xb0 [<80151fb2>] ? notifier_call_chain+0x42/0x60 [<801522b4>] ? __blocking_notifier_call_chain+0x44/0x60 [<801522e7>] ? blocking_notifier_call_chain+0x17/0x20 [<80322e2a>] ? acpi_lid_send_state+0x7e/0xa2 [<80322e92>] ? acpi_button_notify+0x2f/0xae [<8030511b>] ? acpi_device_notify+0xf/0x11 [<8030f5eb>] ? acpi_ev_notify_dispatch+0x2b/0x40 [<80302f08>] ? acpi_os_execute_deferred+0x18/0x21 [<80147224>] ? process_one_work+0x104/0x380 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80302ef0>] ? acpi_os_wait_events_complete+0x14/0x14 [<80147797>] ? worker_thread+0x107/0x3a0 [<80147690>] ? rescuer_thread+0x1c0/0x1c0 [<8014bd7c>] ? kthread+0x8c/0xa0 [<806097b7>] ? ret_from_kernel_thread+0x1b/0x28 [<8014bcf0>] ? __kthread_parkme+0x60/0x60 ---[ end trace 2fa112e1a3f687cc ]--- ------------[ cut here ]------------ WARNING: at /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_display.c:3590 intel_modeset_check_state+0x5ef/0x640() Hardware name: NC6120(EK094ES) encoder->connectors_active not set Pid: 420, comm: kworker/0:2 Tainted: G W 3.7.0-rc6-00003-gddba8b4 #83 Call Trace: [<80131173>] ? warn_slowpath_common+0x73/0xb0 [<80394c9f>] ? intel_modeset_check_state+0x5ef/0x640 [<80394c9f>] ? intel_modeset_check_state+0x5ef/0x640 [<80131203>] ? warn_slowpath_fmt+0x33/0x40 [<80394c9f>] ? intel_modeset_check_state+0x5ef/0x640 [<8032336f>] ? acpi_lid_open+0x25/0x3e [<8039962d>] ? intel_lid_notify+0x8d/0xb0 [<80151fb2>] ? notifier_call_chain+0x42/0x60 [<801522b4>] ? __blocking_notifier_call_chain+0x44/0x60 [<801522e7>] ? blocking_notifier_call_chain+0x17/0x20 [<80322e2a>] ? acpi_lid_send_state+0x7e/0xa2 [<80322e92>] ? acpi_button_notify+0x2f/0xae [<8030511b>] ? acpi_device_notify+0xf/0x11 [<8030f5eb>] ? acpi_ev_notify_dispatch+0x2b/0x40 [<80302f08>] ? acpi_os_execute_deferred+0x18/0x21 [<80147224>] ? process_one_work+0x104/0x380 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80302ef0>] ? acpi_os_wait_events_complete+0x14/0x14 [<80147797>] ? worker_thread+0x107/0x3a0 [<80147690>] ? rescuer_thread+0x1c0/0x1c0 [<8014bd7c>] ? kthread+0x8c/0xa0 [<806097b7>] ? ret_from_kernel_thread+0x1b/0x28 [<8014bcf0>] ? __kthread_parkme+0x60/0x60 ---[ end trace 2fa112e1a3f687cd ]--- ------------[ cut here ]------------ WARNING: at /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_display.c:3594 intel_modeset_check_state+0x5a9/0x640() Hardware name: NC6120(EK094ES) Pid: 420, comm: kworker/0:2 Tainted: G W 3.7.0-rc6-00003-gddba8b4 #83 Call Trace: [<80131173>] ? warn_slowpath_common+0x73/0xb0 [<80394c59>] ? intel_modeset_check_state+0x5a9/0x640 [<80394c59>] ? intel_modeset_check_state+0x5a9/0x640 [<80131269>] ? warn_slowpath_null+0x19/0x20 [<80394c59>] ? intel_modeset_check_state+0x5a9/0x640 [<8039962d>] ? intel_lid_notify+0x8d/0xb0 [<80151fb2>] ? notifier_call_chain+0x42/0x60 [<801522b4>] ? __blocking_notifier_call_chain+0x44/0x60 [<801522e7>] ? blocking_notifier_call_chain+0x17/0x20 [<80322e2a>] ? acpi_lid_send_state+0x7e/0xa2 [<80322e92>] ? acpi_button_notify+0x2f/0xae [<8030511b>] ? acpi_device_notify+0xf/0x11 [<8030f5eb>] ? acpi_ev_notify_dispatch+0x2b/0x40 [<80302f08>] ? acpi_os_execute_deferred+0x18/0x21 [<80147224>] ? process_one_work+0x104/0x380 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80302ef0>] ? acpi_os_wait_events_complete+0x14/0x14 [<80147797>] ? worker_thread+0x107/0x3a0 [<80147690>] ? rescuer_thread+0x1c0/0x1c0 [<8014bd7c>] ? kthread+0x8c/0xa0 [<806097b7>] ? ret_from_kernel_thread+0x1b/0x28 [<8014bcf0>] ? __kthread_parkme+0x60/0x60 ---[ end trace 2fa112e1a3f687ce ]--- ------------[ cut here ]------------ WARNING: at /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_display.c:6968 intel_modeset_check_state+0x4c8/0x640() Hardware name: NC6120(EK094ES) encoder's hw state doesn't match sw tracking (expected 0, found 1) Pid: 420, comm: kworker/0:2 Tainted: G W 3.7.0-rc6-00003-gddba8b4 #83 Call Trace: [<80131173>] ? warn_slowpath_common+0x73/0xb0 [<80394b78>] ? intel_modeset_check_state+0x4c8/0x640 [<80394b78>] ? intel_modeset_check_state+0x4c8/0x640 [<80131203>] ? warn_slowpath_fmt+0x33/0x40 [<80394b78>] ? intel_modeset_check_state+0x4c8/0x640 [<8039962d>] ? intel_lid_notify+0x8d/0xb0 [<80151fb2>] ? notifier_call_chain+0x42/0x60 [<801522b4>] ? __blocking_notifier_call_chain+0x44/0x60 [<801522e7>] ? blocking_notifier_call_chain+0x17/0x20 [<80322e2a>] ? acpi_lid_send_state+0x7e/0xa2 [<80322e92>] ? acpi_button_notify+0x2f/0xae [<8030511b>] ? acpi_device_notify+0xf/0x11 [<8030f5eb>] ? acpi_ev_notify_dispatch+0x2b/0x40 [<80302f08>] ? acpi_os_execute_deferred+0x18/0x21 [<80147224>] ? process_one_work+0x104/0x380 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80302ef0>] ? acpi_os_wait_events_complete+0x14/0x14 [<80147797>] ? worker_thread+0x107/0x3a0 [<80147690>] ? rescuer_thread+0x1c0/0x1c0 [<8014bd7c>] ? kthread+0x8c/0xa0 [<806097b7>] ? ret_from_kernel_thread+0x1b/0x28 [<8014bcf0>] ? __kthread_parkme+0x60/0x60 ---[ end trace 2fa112e1a3f687cf ]--- ------------[ cut here ]------------ WARNING: at /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_display.c:1225 assert_pipe+0x95/0xa0() Hardware name: NC6120(EK094ES) pipe A assertion failure (expected off, current on) Pid: 420, comm: kworker/0:2 Tainted: G W 3.7.0-rc6-00003-gddba8b4 #83 Call Trace: [<80131173>] ? warn_slowpath_common+0x73/0xb0 [<8038e0d5>] ? assert_pipe+0x95/0xa0 [<8038e0d5>] ? assert_pipe+0x95/0xa0 [<80131203>] ? warn_slowpath_fmt+0x33/0x40 [<8038e0d5>] ? assert_pipe+0x95/0xa0 [<80394a4e>] ? intel_modeset_check_state+0x39e/0x640 [<8039962d>] ? intel_lid_notify+0x8d/0xb0 [<80151fb2>] ? notifier_call_chain+0x42/0x60 [<801522b4>] ? __blocking_notifier_call_chain+0x44/0x60 [<801522e7>] ? blocking_notifier_call_chain+0x17/0x20 [<80322e2a>] ? acpi_lid_send_state+0x7e/0xa2 [<80322e92>] ? acpi_button_notify+0x2f/0xae [<8030511b>] ? acpi_device_notify+0xf/0x11 [<8030f5eb>] ? acpi_ev_notify_dispatch+0x2b/0x40 [<80302f08>] ? acpi_os_execute_deferred+0x18/0x21 [<80147224>] ? process_one_work+0x104/0x380 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80302ef0>] ? acpi_os_wait_events_complete+0x14/0x14 [<80147797>] ? worker_thread+0x107/0x3a0 [<80147690>] ? rescuer_thread+0x1c0/0x1c0 [<8014bd7c>] ? kthread+0x8c/0xa0 [<806097b7>] ? ret_from_kernel_thread+0x1b/0x28 [<8014bcf0>] ? __kthread_parkme+0x60/0x60 ---[ end trace 2fa112e1a3f687d0 ]--- ------------[ cut here ]------------ WARNING: at /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_display.c:3588 intel_modeset_check_state+0x612/0x640() Hardware name: NC6120(EK094ES) active connector not linked to encoder Pid: 420, comm: kworker/0:2 Tainted: G W 3.7.0-rc6-00003-gddba8b4 #83 Call Trace: [<80131173>] ? warn_slowpath_common+0x73/0xb0 [<80394cc2>] ? intel_modeset_check_state+0x612/0x640 [<80394cc2>] ? intel_modeset_check_state+0x612/0x640 [<80131203>] ? warn_slowpath_fmt+0x33/0x40 [<80394cc2>] ? intel_modeset_check_state+0x612/0x640 [<80393728>] ? intel_crtc_update_dpms+0x78/0x90 [<803570d7>] ? drm_fb_helper_dpms.isra.11+0x77/0xc0 [<8035755d>] ? drm_fb_helper_blank+0x4d/0x70 [<802f2f04>] ? fb_blank+0x44/0xb0 [<802fba09>] ? fbcon_blank+0x1d9/0x2d0 [<802314b2>] ? flush_commit_list+0x562/0x620 [<8014683a>] ? __queue_delayed_work+0xaa/0x140 [<801581c9>] ? dequeue_task_fair+0x29/0x1a0 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344ad5>] ? do_unblank_screen+0x95/0x1b0 [<80344ffc>] ? console_callback+0xec/0x110 [<80147224>] ? process_one_work+0x104/0x380 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344f10>] ? poke_blanked_console+0xb0/0xb0 [<80147797>] ? worker_thread+0x107/0x3a0 [<80147690>] ? rescuer_thread+0x1c0/0x1c0 [<8014bd7c>] ? kthread+0x8c/0xa0 [<806097b7>] ? ret_from_kernel_thread+0x1b/0x28 [<8014bcf0>] ? __kthread_parkme+0x60/0x60 ---[ end trace 2fa112e1a3f687d1 ]--- ------------[ cut here ]------------ WARNING: at /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_display.c:3590 intel_modeset_check_state+0x5ef/0x640() Hardware name: NC6120(EK094ES) encoder->connectors_active not set Pid: 420, comm: kworker/0:2 Tainted: G W 3.7.0-rc6-00003-gddba8b4 #83 Call Trace: [<80131173>] ? warn_slowpath_common+0x73/0xb0 [<80394c9f>] ? intel_modeset_check_state+0x5ef/0x640 [<80394c9f>] ? intel_modeset_check_state+0x5ef/0x640 [<80131203>] ? warn_slowpath_fmt+0x33/0x40 [<80394c9f>] ? intel_modeset_check_state+0x5ef/0x640 [<80393728>] ? intel_crtc_update_dpms+0x78/0x90 [<803570d7>] ? drm_fb_helper_dpms.isra.11+0x77/0xc0 [<8035755d>] ? drm_fb_helper_blank+0x4d/0x70 [<802f2f04>] ? fb_blank+0x44/0xb0 [<802fba09>] ? fbcon_blank+0x1d9/0x2d0 [<802314b2>] ? flush_commit_list+0x562/0x620 [<8014683a>] ? __queue_delayed_work+0xaa/0x140 [<801581c9>] ? dequeue_task_fair+0x29/0x1a0 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344ad5>] ? do_unblank_screen+0x95/0x1b0 [<80344ffc>] ? console_callback+0xec/0x110 [<80147224>] ? process_one_work+0x104/0x380 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344f10>] ? poke_blanked_console+0xb0/0xb0 [<80147797>] ? worker_thread+0x107/0x3a0 [<80147690>] ? rescuer_thread+0x1c0/0x1c0 [<8014bd7c>] ? kthread+0x8c/0xa0 [<806097b7>] ? ret_from_kernel_thread+0x1b/0x28 [<8014bcf0>] ? __kthread_parkme+0x60/0x60 ---[ end trace 2fa112e1a3f687d2 ]--- ------------[ cut here ]------------ WARNING: at /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_display.c:3594 intel_modeset_check_state+0x5a9/0x640() Hardware name: NC6120(EK094ES) Pid: 420, comm: kworker/0:2 Tainted: G W 3.7.0-rc6-00003-gddba8b4 #83 Call Trace: [<80131173>] ? warn_slowpath_common+0x73/0xb0 [<80394c59>] ? intel_modeset_check_state+0x5a9/0x640 [<80394c59>] ? intel_modeset_check_state+0x5a9/0x640 [<80131269>] ? warn_slowpath_null+0x19/0x20 [<80394c59>] ? intel_modeset_check_state+0x5a9/0x640 [<80393728>] ? intel_crtc_update_dpms+0x78/0x90 [<803570d7>] ? drm_fb_helper_dpms.isra.11+0x77/0xc0 [<8035755d>] ? drm_fb_helper_blank+0x4d/0x70 [<802f2f04>] ? fb_blank+0x44/0xb0 [<802fba09>] ? fbcon_blank+0x1d9/0x2d0 [<802314b2>] ? flush_commit_list+0x562/0x620 [<8014683a>] ? __queue_delayed_work+0xaa/0x140 [<801581c9>] ? dequeue_task_fair+0x29/0x1a0 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344ad5>] ? do_unblank_screen+0x95/0x1b0 [<80344ffc>] ? console_callback+0xec/0x110 [<80147224>] ? process_one_work+0x104/0x380 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344f10>] ? poke_blanked_console+0xb0/0xb0 [<80147797>] ? worker_thread+0x107/0x3a0 [<80147690>] ? rescuer_thread+0x1c0/0x1c0 [<8014bd7c>] ? kthread+0x8c/0xa0 [<806097b7>] ? ret_from_kernel_thread+0x1b/0x28 [<8014bcf0>] ? __kthread_parkme+0x60/0x60 ---[ end trace 2fa112e1a3f687d3 ]--- ------------[ cut here ]------------ WARNING: at /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_display.c:6968 intel_modeset_check_state+0x4c8/0x640() Hardware name: NC6120(EK094ES) encoder's hw state doesn't match sw tracking (expected 0, found 1) Pid: 420, comm: kworker/0:2 Tainted: G W 3.7.0-rc6-00003-gddba8b4 #83 Call Trace: [<80131173>] ? warn_slowpath_common+0x73/0xb0 [<80394b78>] ? intel_modeset_check_state+0x4c8/0x640 [<80394b78>] ? intel_modeset_check_state+0x4c8/0x640 [<80131203>] ? warn_slowpath_fmt+0x33/0x40 [<80394b78>] ? intel_modeset_check_state+0x4c8/0x640 [<803570d7>] ? drm_fb_helper_dpms.isra.11+0x77/0xc0 [<8035755d>] ? drm_fb_helper_blank+0x4d/0x70 [<802f2f04>] ? fb_blank+0x44/0xb0 [<802fba09>] ? fbcon_blank+0x1d9/0x2d0 [<802314b2>] ? flush_commit_list+0x562/0x620 [<8014683a>] ? __queue_delayed_work+0xaa/0x140 [<801581c9>] ? dequeue_task_fair+0x29/0x1a0 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344ad5>] ? do_unblank_screen+0x95/0x1b0 [<80344ffc>] ? console_callback+0xec/0x110 [<80147224>] ? process_one_work+0x104/0x380 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344f10>] ? poke_blanked_console+0xb0/0xb0 [<80147797>] ? worker_thread+0x107/0x3a0 [<80147690>] ? rescuer_thread+0x1c0/0x1c0 [<8014bd7c>] ? kthread+0x8c/0xa0 [<806097b7>] ? ret_from_kernel_thread+0x1b/0x28 [<8014bcf0>] ? __kthread_parkme+0x60/0x60 ---[ end trace 2fa112e1a3f687d4 ]--- ------------[ cut here ]------------ WARNING: at /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_display.c:1225 assert_pipe+0x95/0xa0() Hardware name: NC6120(EK094ES) pipe A assertion failure (expected off, current on) Pid: 420, comm: kworker/0:2 Tainted: G W 3.7.0-rc6-00003-gddba8b4 #83 Call Trace: [<80131173>] ? warn_slowpath_common+0x73/0xb0 [<8038e0d5>] ? assert_pipe+0x95/0xa0 [<8038e0d5>] ? assert_pipe+0x95/0xa0 [<80131203>] ? warn_slowpath_fmt+0x33/0x40 [<8038e0d5>] ? assert_pipe+0x95/0xa0 [<80394a4e>] ? intel_modeset_check_state+0x39e/0x640 [<803570d7>] ? drm_fb_helper_dpms.isra.11+0x77/0xc0 [<8035755d>] ? drm_fb_helper_blank+0x4d/0x70 [<802f2f04>] ? fb_blank+0x44/0xb0 [<802fba09>] ? fbcon_blank+0x1d9/0x2d0 [<802314b2>] ? flush_commit_list+0x562/0x620 [<8014683a>] ? __queue_delayed_work+0xaa/0x140 [<801581c9>] ? dequeue_task_fair+0x29/0x1a0 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344ad5>] ? do_unblank_screen+0x95/0x1b0 [<80344ffc>] ? console_callback+0xec/0x110 [<80147224>] ? process_one_work+0x104/0x380 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344f10>] ? poke_blanked_console+0xb0/0xb0 [<80147797>] ? worker_thread+0x107/0x3a0 [<80147690>] ? rescuer_thread+0x1c0/0x1c0 [<8014bd7c>] ? kthread+0x8c/0xa0 [<806097b7>] ? ret_from_kernel_thread+0x1b/0x28 [<8014bcf0>] ? __kthread_parkme+0x60/0x60 ---[ end trace 2fa112e1a3f687d5 ]--- ------------[ cut here ]------------ WARNING: at /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_display.c:3588 intel_modeset_check_state+0x612/0x640() Hardware name: NC6120(EK094ES) active connector not linked to encoder Pid: 420, comm: kworker/0:2 Tainted: G W 3.7.0-rc6-00003-gddba8b4 #83 Call Trace: [<80131173>] ? warn_slowpath_common+0x73/0xb0 [<80394cc2>] ? intel_modeset_check_state+0x612/0x640 [<80394cc2>] ? intel_modeset_check_state+0x612/0x640 [<80131203>] ? warn_slowpath_fmt+0x33/0x40 [<80394cc2>] ? intel_modeset_check_state+0x612/0x640 [<803570d7>] ? drm_fb_helper_dpms.isra.11+0x77/0xc0 [<8035755d>] ? drm_fb_helper_blank+0x4d/0x70 [<802f2f04>] ? fb_blank+0x44/0xb0 [<802fba09>] ? fbcon_blank+0x1d9/0x2d0 [<802314b2>] ? flush_commit_list+0x562/0x620 [<8014683a>] ? __queue_delayed_work+0xaa/0x140 [<801581c9>] ? dequeue_task_fair+0x29/0x1a0 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344ad5>] ? do_unblank_screen+0x95/0x1b0 [<80344ffc>] ? console_callback+0xec/0x110 [<80147224>] ? process_one_work+0x104/0x380 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344f10>] ? poke_blanked_console+0xb0/0xb0 [<80147797>] ? worker_thread+0x107/0x3a0 [<80147690>] ? rescuer_thread+0x1c0/0x1c0 [<8014bd7c>] ? kthread+0x8c/0xa0 [<806097b7>] ? ret_from_kernel_thread+0x1b/0x28 [<8014bcf0>] ? __kthread_parkme+0x60/0x60 ---[ end trace 2fa112e1a3f687d6 ]--- ------------[ cut here ]------------ WARNING: at /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_display.c:3590 intel_modeset_check_state+0x5ef/0x640() Hardware name: NC6120(EK094ES) encoder->connectors_active not set Pid: 420, comm: kworker/0:2 Tainted: G W 3.7.0-rc6-00003-gddba8b4 #83 Call Trace: [<80131173>] ? warn_slowpath_common+0x73/0xb0 [<80394c9f>] ? intel_modeset_check_state+0x5ef/0x640 [<80394c9f>] ? intel_modeset_check_state+0x5ef/0x640 [<80131203>] ? warn_slowpath_fmt+0x33/0x40 [<80394c9f>] ? intel_modeset_check_state+0x5ef/0x640 [<803570d7>] ? drm_fb_helper_dpms.isra.11+0x77/0xc0 [<8035755d>] ? drm_fb_helper_blank+0x4d/0x70 [<802f2f04>] ? fb_blank+0x44/0xb0 [<802fba09>] ? fbcon_blank+0x1d9/0x2d0 [<802314b2>] ? flush_commit_list+0x562/0x620 [<8014683a>] ? __queue_delayed_work+0xaa/0x140 [<801581c9>] ? dequeue_task_fair+0x29/0x1a0 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344ad5>] ? do_unblank_screen+0x95/0x1b0 [<80344ffc>] ? console_callback+0xec/0x110 [<80147224>] ? process_one_work+0x104/0x380 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344f10>] ? poke_blanked_console+0xb0/0xb0 [<80147797>] ? worker_thread+0x107/0x3a0 [<80147690>] ? rescuer_thread+0x1c0/0x1c0 [<8014bd7c>] ? kthread+0x8c/0xa0 [<806097b7>] ? ret_from_kernel_thread+0x1b/0x28 [<8014bcf0>] ? __kthread_parkme+0x60/0x60 ---[ end trace 2fa112e1a3f687d7 ]--- ------------[ cut here ]------------ WARNING: at /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_display.c:3594 intel_modeset_check_state+0x5a9/0x640() Hardware name: NC6120(EK094ES) Pid: 420, comm: kworker/0:2 Tainted: G W 3.7.0-rc6-00003-gddba8b4 #83 Call Trace: [<80131173>] ? warn_slowpath_common+0x73/0xb0 [<80394c59>] ? intel_modeset_check_state+0x5a9/0x640 [<80394c59>] ? intel_modeset_check_state+0x5a9/0x640 [<80131269>] ? warn_slowpath_null+0x19/0x20 [<80394c59>] ? intel_modeset_check_state+0x5a9/0x640 [<803570d7>] ? drm_fb_helper_dpms.isra.11+0x77/0xc0 [<8035755d>] ? drm_fb_helper_blank+0x4d/0x70 [<802f2f04>] ? fb_blank+0x44/0xb0 [<802fba09>] ? fbcon_blank+0x1d9/0x2d0 [<802314b2>] ? flush_commit_list+0x562/0x620 [<8014683a>] ? __queue_delayed_work+0xaa/0x140 [<801581c9>] ? dequeue_task_fair+0x29/0x1a0 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344ad5>] ? do_unblank_screen+0x95/0x1b0 [<80344ffc>] ? console_callback+0xec/0x110 [<80147224>] ? process_one_work+0x104/0x380 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344f10>] ? poke_blanked_console+0xb0/0xb0 [<80147797>] ? worker_thread+0x107/0x3a0 [<80147690>] ? rescuer_thread+0x1c0/0x1c0 [<8014bd7c>] ? kthread+0x8c/0xa0 [<806097b7>] ? ret_from_kernel_thread+0x1b/0x28 [<8014bcf0>] ? __kthread_parkme+0x60/0x60 ---[ end trace 2fa112e1a3f687d8 ]--- ------------[ cut here ]------------ WARNING: at /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_display.c:6968 intel_modeset_check_state+0x4c8/0x640() Hardware name: NC6120(EK094ES) encoder's hw state doesn't match sw tracking (expected 0, found 1) Pid: 420, comm: kworker/0:2 Tainted: G W 3.7.0-rc6-00003-gddba8b4 #83 Call Trace: [<80131173>] ? warn_slowpath_common+0x73/0xb0 [<80394b78>] ? intel_modeset_check_state+0x4c8/0x640 [<80394b78>] ? intel_modeset_check_state+0x4c8/0x640 [<80131203>] ? warn_slowpath_fmt+0x33/0x40 [<80394b78>] ? intel_modeset_check_state+0x4c8/0x640 [<803570d7>] ? drm_fb_helper_dpms.isra.11+0x77/0xc0 [<8035755d>] ? drm_fb_helper_blank+0x4d/0x70 [<802f2f04>] ? fb_blank+0x44/0xb0 [<802fba09>] ? fbcon_blank+0x1d9/0x2d0 [<802314b2>] ? flush_commit_list+0x562/0x620 [<8014683a>] ? __queue_delayed_work+0xaa/0x140 [<801581c9>] ? dequeue_task_fair+0x29/0x1a0 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344ad5>] ? do_unblank_screen+0x95/0x1b0 [<80344ffc>] ? console_callback+0xec/0x110 [<80147224>] ? process_one_work+0x104/0x380 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344f10>] ? poke_blanked_console+0xb0/0xb0 [<80147797>] ? worker_thread+0x107/0x3a0 [<80147690>] ? rescuer_thread+0x1c0/0x1c0 [<8014bd7c>] ? kthread+0x8c/0xa0 [<806097b7>] ? ret_from_kernel_thread+0x1b/0x28 [<8014bcf0>] ? __kthread_parkme+0x60/0x60 ---[ end trace 2fa112e1a3f687d9 ]--- ------------[ cut here ]------------ WARNING: at /home/krzysiek/src/linux-2.6/drivers/gpu/drm/i915/intel_display.c:1225 assert_pipe+0x95/0xa0() Hardware name: NC6120(EK094ES) pipe A assertion failure (expected off, current on) Pid: 420, comm: kworker/0:2 Tainted: G W 3.7.0-rc6-00003-gddba8b4 #83 Call Trace: [<80131173>] ? warn_slowpath_common+0x73/0xb0 [<8038e0d5>] ? assert_pipe+0x95/0xa0 [<8038e0d5>] ? assert_pipe+0x95/0xa0 [<80131203>] ? warn_slowpath_fmt+0x33/0x40 [<8038e0d5>] ? assert_pipe+0x95/0xa0 [<80394a4e>] ? intel_modeset_check_state+0x39e/0x640 [<803570d7>] ? drm_fb_helper_dpms.isra.11+0x77/0xc0 [<8035755d>] ? drm_fb_helper_blank+0x4d/0x70 [<802f2f04>] ? fb_blank+0x44/0xb0 [<802fba09>] ? fbcon_blank+0x1d9/0x2d0 [<802314b2>] ? flush_commit_list+0x562/0x620 [<8014683a>] ? __queue_delayed_work+0xaa/0x140 [<801581c9>] ? dequeue_task_fair+0x29/0x1a0 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344ad5>] ? do_unblank_screen+0x95/0x1b0 [<80344ffc>] ? console_callback+0xec/0x110 [<80147224>] ? process_one_work+0x104/0x380 [<8013d963>] ? internal_add_timer+0x13/0x40 [<80344f10>] ? poke_blanked_console+0xb0/0xb0 [<80147797>] ? worker_thread+0x107/0x3a0 [<80147690>] ? rescuer_thread+0x1c0/0x1c0 [<8014bd7c>] ? kthread+0x8c/0xa0 [<806097b7>] ? ret_from_kernel_thread+0x1b/0x28 [<8014bcf0>] ? __kthread_parkme+0x60/0x60 ---[ end trace 2fa112e1a3f687da ]---

1 0

Re: [PATCH v3] DRM/KMS/EDID: Consolidate EDID Error Handling (v3)
by Egbert Eich 22 Nov '12

22 Nov '12

Ville Syrj�l� writes: > > > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > > index dd0df60..aa9b34d 100644 > > --- a/drivers/gpu/drm/drm_edid.c > > +++ b/drivers/gpu/drm/drm_edid.c > > @@ -157,6 +157,17 @@ int drm_edid_header_is_valid(const u8 *raw_edid) > > } > > EXPORT_SYMBOL(drm_edid_header_is_valid); > > > > +static bool drm_edid_is_zero(u8 *in_edid, int length) > > +{ > > + int i; > > + u32 *raw_edid = (u32 *)in_edid; > > + > > + for (i = 0; i < length / 4; i++) > > + if (*(raw_edid + i) != 0) > > + return false; > > + return true; [...] > > You could use memchr_inv() here. But the compiler can't optimize it > since it's not inline, so I suppose it might make it slower. > > + > > +bool > > +drm_edid_block_valid(u8 *raw_edid, int block, unsigned last_error_flags) > > +{ > > + if (!drm_edid_block_check_error(raw_edid, block, last_error_flags)) > > + return true; > > + return false; > > return !drm_edid_block_check_error(); Right. It's stupid anyway. See below. > > > } > > EXPORT_SYMBOL(drm_edid_block_valid); > > > > @@ -241,7 +268,7 @@ bool drm_edid_is_valid(struct edid *edid) > > return false; > > > > for (i = 0; i <= edid->extensions; i++) > > - if (!drm_edid_block_valid(raw + i * EDID_LENGTH, i, true)) > > + if (drm_edid_block_check_error(raw + i * EDID_LENGTH, i, true)) > ^^^^ > > That looks wrong. Also the 's/!drm_edid_block_valid/drm_edid_block_check_error' Oops, right. Leftover from old code. > change seems superfluous since you're not using the more detailed return > value from drm_edid_block_check_error(). This should probably be changed. For the drm_edid_block_valid() I'm already using the previous error state as argument - but I don't tell the result of this read. Doesn't make much sense :( Something similar should be done for drm_edid_is_valid() - even if the driver doesn't bother (for instance because this function is only called once when the device structures are initialized). The current code ignores the error state for extension blocks i guess it should not if we want to avoid having repreated logging of errors in the extension blocks. What should be done is: unsigned err = drm_edid_block_check_error(); result |= err; if (!err) { valid_extensions++; ... } > > - if (drm_edid_block_valid(block + (valid_extensions + 1) * EDID_LENGTH, j, print_bad_edid)) { > > + if (!drm_edid_block_check_error(block + (valid_extensions + 1) * EDID_LENGTH, j, last_error_flags)) { > > Again the change of function seems superfluous. > Exactly. Please see above. Thanks for looking at the patches! Cheers, Egbert.

2 1

[Bug 50881] Error compiling nouveau inside the kernel (not as a module) when ACPI is a module
by bugzilla-daemon＠bugzilla.kernel.org 22 Nov '12

22 Nov '12

https://bugzilla.kernel.org/show_bug.cgi?id=50881 Alan <alan(a)lxorguk.ukuu.org.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alan(a)lxorguk.ukuu.org.uk Component|Video(Other) |Video(DRI - non Intel) AssignedTo|drivers_video-other@kernel- |drivers_video-dri@kernel-bu |bugs.osdl.org |gs.osdl.org --- Comment #2 from Alan <alan(a)lxorguk.ukuu.org.uk> 2012-11-22 14:44:47 --- Looks to be the case: there is a missing depend line I think -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 0

Re: [PATCH v2 13/18] DRM/KMS/EDID: Cache EDID blobs with extensions (v2)
by Egbert Eich 22 Nov '12

22 Nov '12

Ville Syrj�l� writes: > On Thu, Nov 22, 2012 at 05:23:03AM -0500, Egbert Eich wrote: > > > > - /* if there's no extensions, we're done */ > > + /* if there are no extensions, we're done - don't bother caching */ > > if (block[EDID_EXTENSION_FLAG_OFFSET] == 0) > > return block; > > Shouldn't you erase the cache here too? > Indeed. And I had fixed it. It went into the wrong patch however :( Will correct. Thanks, Egbert.

1 0

← Newer
1
...
49
50
51
52
53
54
55
...
80
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel November 2012