dri-devel November 2012

dri-devel@lists.freedesktop.org

126 participants
797 discussions

[PATCH v9 0/6] of: add display helper
by Steffen Trumtrar 14 Nov '12

14 Nov '12

Hi! Changes since v8: - fix memory leaks - change API to be more consistent (foo_from_bar(struct bar, struct foo)) - include headers were necessary - misc minor bufixes Regards, Steffen Steffen Trumtrar (6): video: add display_timing and videomode video: add of helper for videomode fbmon: add videomode helpers fbmon: add of_videomode helpers drm_modes: add videomode helpers drm_modes: add of_videomode helpers .../devicetree/bindings/video/display-timings.txt | 107 ++++++++++ drivers/gpu/drm/drm_modes.c | 69 +++++++ drivers/video/Kconfig | 19 ++ drivers/video/Makefile | 4 + drivers/video/display_timing.c | 24 +++ drivers/video/fbmon.c | 78 ++++++++ drivers/video/of_display_timing.c | 211 ++++++++++++++++++++ drivers/video/of_videomode.c | 47 +++++ drivers/video/videomode.c | 45 +++++ include/drm/drmP.h | 12 ++ include/linux/display_timing.h | 69 +++++++ include/linux/fb.h | 11 + include/linux/of_display_timings.h | 20 ++ include/linux/of_videomode.h | 16 ++ include/linux/videomode.h | 39 ++++ 15 files changed, 771 insertions(+) create mode 100644 Documentation/devicetree/bindings/video/display-timings.txt create mode 100644 drivers/video/display_timing.c create mode 100644 drivers/video/of_display_timing.c create mode 100644 drivers/video/of_videomode.c create mode 100644 drivers/video/videomode.c create mode 100644 include/linux/display_timing.h create mode 100644 include/linux/of_display_timings.h create mode 100644 include/linux/of_videomode.h create mode 100644 include/linux/videomode.h -- 1.7.10.4

2 16

[Bug 50431] drivers/gpu/drm/radeon/atombios_encoders.c:1628: possible bad if test
by bugzilla-daemon＠bugzilla.kernel.org 14 Nov '12

14 Nov '12

https://bugzilla.kernel.org/show_bug.cgi?id=50431 Alex Deucher <alexdeucher(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexdeucher(a)gmail.com --- Comment #1 from Alex Deucher <alexdeucher(a)gmail.com> 2012-11-14 14:13:53 --- Good catch. Thanks! Patch queued. -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 0

[Bug 50091] GeForce 6150SE: system hangs on X-server start with garbled screen
by bugzilla-daemon＠bugzilla.kernel.org 14 Nov '12

14 Nov '12

https://bugzilla.kernel.org/show_bug.cgi?id=50091 --- Comment #1 from schaefer.frank(a)gmx.net 2012-11-14 13:50:31 --- Last good commit is 5787640db6ae722aeadb394d480c7ca21b603e34 drm/nv04-nv40/instmem: remove use of nouveau_gpuobj_new_fake() First bad commit is ebb945a94bba2ce8dff7b0942ff2b3f2a52a0a69 drm/nouveau: port all engines to new engine module format Can't test 16 commits inbetween (70ee6f1cd6911098ddd4c11ee21b69dbe51fb3f9 to ac1499d9573f4aadd1d2beac11fe23af8ce90c24). -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 0

Regression due to "mm: fix-up zone present pages"
by Daniel Vetter 14 Nov '12

14 Nov '12

Hi all, Our QA noticed a regression in one of our i915/GEM testcases in 3.7: https://bugs.freedesktop.org/show_bug.cgi?id=56859 Direct link to dmesg of the machine: https://bugs.freedesktop.org/attachment.cgi?id=70052 Note that the machine is 32bit, which seems to be important since Chris Wilson confirmed the bug on his 32bit Sandybridge machine, whereas mine here with a 64bit kernel works flawlessly. The testcase is gem_tiled_swapping: http://cgit.freedesktop.org/xorg/app/intel-gpu-tools/tree/tests/gem_tiled_s… Quick high-level description of the workload: It allocates a working set larger than available memory, then fills it by writing it through the gpu gart (required to get a linear view of tiled buffers) and afterwards reads it to check whether anything got corrupted. Since the working set is too large to fit into ram, this will force all buffers through swap. We've written this testcase to exercise the reswizzle swapin path since some platforms have a tiling layout depending upon physical pfn (awesome feature btw), but not snb. So within the kernel this workload simply grabs the backing storage from shmemfs with shmem_read_mapping_page_gfp and then binds them into the gpu pagetables (the GTT). This happens in the i915_gem_fault fucntion. Unbinding in this workload happens either directly (if the gem code can't get enough memory) or through our shrinker (i915_gem_inactive_shrink). Swapout is then left to shmemfs to handle. All the above stuff is in drivers/gpu/drm/i915_gem.c Testcase fails because it detects a mismatch between what has been written and what has been read back. Our qa people bisected the regression to commit 7f1290f2f2a4d2c3f1b7ce8e87256e052ca23125 Author: Jianguo Wu <wujianguo(a)huawei.com> Date: Mon Oct 8 16:33:06 2012 -0700 mm: fix-up zone present pages and confirmed the revert on top of the latest drm-intel-nightly branch (which is based on top of 3.7-rc2 and contains the -next stuff for 3.8). They've also tested the for-QA branch which had latest Linus upstream merged in, which did not fix the problem. For reference the intel trees are at (but I don't think it matters really that it's not plain upstream, nothing really changed in the relevant i915/gem paths compared to upstream): http://cgit.freedesktop.org/~danvet/drm-intel I have no idea how that early boot zone init fix could even corrupt swapping in such a fashion, so ideas highly welcome. QA people are cc'ed, and hopefully I haven't missed anyone else on the cc list. Yours, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

2 1

[Bug 50431] drivers/gpu/drm/radeon/atombios_encoders.c:1628: possible bad if test
by bugzilla-daemon＠bugzilla.kernel.org 14 Nov '12

14 Nov '12

https://bugzilla.kernel.org/show_bug.cgi?id=50431 Alan <alan(a)lxorguk.ukuu.org.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alan(a)lxorguk.ukuu.org.uk Component|Other |Video(DRI - non Intel) AssignedTo|drivers_other(a)kernel-bugs.o |drivers_video-dri@kernel-bu |sdl.org |gs.osdl.org -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 0

[PATCH v8 0/6] of: add display helper
by Steffen Trumtrar 14 Nov '12

14 Nov '12

Hi! This is v8 of the display helper series Changes since v7: - move of_xxx to drivers/video - remove non-binding documentation from display-timings.txt - squash display_timings and videomode in one patch - misc minor fixes Regards, Steffen Steffen Trumtrar (6): video: add display_timing and videomode video: add of helper for videomode fbmon: add videomode helpers fbmon: add of_videomode helpers drm_modes: add videomode helpers drm_modes: add of_videomode helpers .../devicetree/bindings/video/display-timings.txt | 107 +++++++++++ drivers/gpu/drm/drm_modes.c | 77 ++++++++ drivers/video/Kconfig | 19 ++ drivers/video/Makefile | 4 + drivers/video/display_timing.c | 22 +++ drivers/video/fbmon.c | 77 ++++++++ drivers/video/of_display_timing.c | 186 ++++++++++++++++++++ drivers/video/of_videomode.c | 47 +++++ drivers/video/videomode.c | 45 +++++ include/drm/drmP.h | 8 + include/linux/display_timing.h | 69 ++++++++ include/linux/fb.h | 5 + include/linux/of_display_timings.h | 19 ++ include/linux/of_videomode.h | 15 ++ include/linux/videomode.h | 39 ++++ 15 files changed, 739 insertions(+) create mode 100644 Documentation/devicetree/bindings/video/display-timings.txt create mode 100644 drivers/video/display_timing.c create mode 100644 drivers/video/of_display_timing.c create mode 100644 drivers/video/of_videomode.c create mode 100644 drivers/video/videomode.c create mode 100644 include/linux/display_timing.h create mode 100644 include/linux/of_display_timings.h create mode 100644 include/linux/of_videomode.h create mode 100644 include/linux/videomode.h -- 1.7.10.4

6 31

[PATCH] drm: exynos: fix for loosing display mode header during mode adjustment
by Rahul Sharma 14 Nov '12

14 Nov '12

This patch is to preserve the display mode header during the mode adjustment. Display mode header is overwritten with the adjusted mode header which is throwing the stack dump. Signed-off-by: Rahul Sharma <rahul.sharma(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_hdmi.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index ee110c9..c7844ea 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -1974,6 +1974,8 @@ static void hdmi_mode_fixup(void *ctx, struct drm_connector *connector, { struct drm_display_mode *m; struct hdmi_context *hdata = ctx; + struct drm_mode_object base; + struct list_head head; int index; DRM_DEBUG_KMS("[%d] %s\n", __LINE__, __func__); @@ -2002,7 +2004,13 @@ static void hdmi_mode_fixup(void *ctx, struct drm_connector *connector, if (index >= 0) { DRM_INFO("desired mode doesn't exist so\n"); DRM_INFO("use the most suitable mode among modes.\n"); + + /* preserve display mode header while copying. */ + head = adjusted_mode->head; + base = adjusted_mode->base; memcpy(adjusted_mode, m, sizeof(*m)); + adjusted_mode->head = head; + adjusted_mode->base = base; break; } } -- 1.7.0.4

2 1

[PATCH 0/2] drm/exynos: fix invalid memory access
by Inki Dae 14 Nov '12

14 Nov '12

This patch releases the fb pended by page flip after fbdev is restored propely. And fixes invalid memory access when drm is released while doing pageflip. This patch makes fb's refcount to be increased when setcrtc and pageflip are requested. In other words, it increases fb's refcount only if dma is going to access memory region to fb and decreases old fb's because the old fb isn't accessed by dma anymore. This could guarantee releasing gem buffer to the fb after dma access to the gem buffer has been completed. Inki Dae (2): drm/exynos: remove unnecessary code. drm/exynos: release fb pended by page flip drivers/gpu/drm/exynos/exynos_drm_crtc.c | 42 ++++++++++++++++++++++++++++- drivers/gpu/drm/exynos/exynos_drm_fb.c | 23 ++++++++++++++++ drivers/gpu/drm/exynos/exynos_drm_fb.h | 6 ++++ drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 9 ++++++ drivers/gpu/drm/exynos/exynos_drm_plane.c | 19 +++++++++++- 5 files changed, 96 insertions(+), 3 deletions(-) -- 1.7.4.1

1 0

[PATCH] drm/radeon: Use hweight32
by Akinobu Mita 14 Nov '12

14 Nov '12

Use hweight32 instead of counting for each bit Signed-off-by: Akinobu Mita <akinobu.mita(a)gmail.com> Cc: David Airlie <airlied(a)linux.ie> Cc: dri-devel(a)lists.freedesktop.org --- drivers/gpu/drm/radeon/r600.c | 8 +------- drivers/gpu/drm/radeon/r600_cp.c | 7 +------ 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index cda280d..169ecc9 100644 --- a/drivers/gpu/drm/radeon/r600.c +++ b/drivers/gpu/drm/radeon/r600.c @@ -1424,13 +1424,7 @@ u32 r6xx_remap_render_backend(struct radeon_device *rdev, int r600_count_pipe_bits(uint32_t val) { - int i, ret = 0; - - for (i = 0; i < 32; i++) { - ret += val & 1; - val >>= 1; - } - return ret; + return hweight32(val); } static void r600_gpu_init(struct radeon_device *rdev) diff --git a/drivers/gpu/drm/radeon/r600_cp.c b/drivers/gpu/drm/radeon/r600_cp.c index 2514123..be85f75 100644 --- a/drivers/gpu/drm/radeon/r600_cp.c +++ b/drivers/gpu/drm/radeon/r600_cp.c @@ -721,12 +721,7 @@ static u32 r600_get_tile_pipe_to_backend_map(u32 num_tile_pipes, static int r600_count_pipe_bits(uint32_t val) { - int i, ret = 0; - for (i = 0; i < 32; i++) { - ret += val & 1; - val >>= 1; - } - return ret; + return hweight32(val); } static void r600_gfx_init(struct drm_device *dev, -- 1.7.11.7

2 3

[PATCH] ttm_get_pages() will OOPS with highmem allocation
by Jonathan Morton 14 Nov '12

14 Nov '12

Reposting from this kernel bug: https://bugzilla.kernel.org/show_bug.cgi?id=50241 I've tested the patch and it solves a highly repeatable OOPS with the CedarView driver that I'm porting. From 3552913d3a1c2d3c4ce158e91dc18cd12b522cb2 Mon Sep 17 00:00:00 2001 From: Yakui Zhao <yakui.zhao(a)intel.com> Date: Tue, 7 Feb 2012 15:33:13 -0500 Subject: [PATCH] Clear the ttm page allocated from high memory zone correctly The TTM page can be allocated from high memory. In such case it is wrong to use the page_address(page) as the virtual address for the high memory page. Signed-off-by: Zhao Yakui <yakui.zhao(a)intel.com> --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index d948575..df976d9 100644 --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c @@ -708,7 +708,10 @@ int ttm_get_pages(struct list_head *pages, int flags, /* clear the pages coming from the pool if requested */ if (flags & TTM_PAGE_FLAG_ZERO_ALLOC) { list_for_each_entry(p, pages, lru) { - clear_page(page_address(p)); + if (PageHighMem(p)) + clear_highpage(p); + else + clear_page(page_address(p)); } } -- 1.7.7.6 -- From: Jonathan Morton jonathan.morton(a)movial.com

2 1

← Newer
1
...
61
62
63
64
65
66
67
...
80
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel November 2012