dri-devel April 2012

dri-devel@lists.freedesktop.org

119 participants
668 discussions

[Bug 46724] New: radeon_drm_winsys compile fail with libdrm in non standard directory
by bugzilla-daemon＠freedesktop.org 02 Apr '12

02 Apr '12

https://bugs.freedesktop.org/show_bug.cgi?id=46724 Bug #: 46724 Summary: radeon_drm_winsys compile fail with libdrm in non standard directory Classification: Unclassified Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: vand2(a)gmx.de Compiling of mesa git fails with libdrm in a non standard directory. libdrm (2.4.31): ./configure \ --prefix=/opt/mesa \ LDFLAGS=-L/opt/mesa/lib \ PKG_CONFIG_PATH=/opt/mesa/lib/pkgconfig \ --enable-nouveau-experimental-api mesa (git a46548e0effa45d31b536c1af97b8dcacbe2db8e): ./configure \ --prefix=/opt/mesa \ --enable-texture-float \ PKG_CONFIG_PATH=/opt/mesa/lib/pkgconfig \ USE_EXTERNAL_DXTN_LIB=1 make -j8 .... gcc -c -I. -I../../../../../src/gallium/include -I../../../../../src/gallium/auxiliary -I../../../../../src/gallium/drivers -I../../../../../include -I/usr/include/libdrm -g -O2 -Wall -std=c99 -Werror=implicit-function-declaration -Werror=missing-prototypes -fno-strict-aliasing -fno-builtin-memcmp -g -O2 -fPIC -DUSE_X86_64_ASM -D_GNU_SOURCE -DPTHREADS -DTEXTURE_FLOAT_ENABLED -DHAVE_POSIX_MEMALIGN -DUSE_XCB -DGLX_INDIRECT_RENDERING -DGLX_DIRECT_RENDERING -DUSE_EXTERNAL_DXTN_LIB=1 -DIN_DRI_DRIVER -DHAVE_ALIAS -DHAVE_MINCORE -D__STDC_CONSTANT_MACROS -DHAVE_LLVM=0x0209 -fvisibility=hidden -I/usr/lib/llvm-2.9/include -D_GNU_SOURCE -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS radeon_drm_winsys.c -o radeon_drm_winsys.o In file included from radeon_drm_winsys.h:33:0, from radeon_drm_bo.h:35, from radeon_drm_cs.h:30, from radeon_drm_bo.c:28: radeon_winsys.h:46:35: fatal error: libdrm/radeon_surface.h: No such file or directory compilation terminated. In file included from radeon_drm_winsys.h:33:0, from radeon_drm_bo.h:35, from radeon_drm_cs.h:30, from radeon_drm_cs.c:65: radeon_winsys.h:46:35: fatal error: libdrm/radeon_surface.h: No such file or directory compilation terminated. In file included from radeon_drm_winsys.h:33:0, from radeon_drm_bo.h:35, from radeon_drm_winsys.c:34: radeon_winsys.h:46:35: fatal error: libdrm/radeon_surface.h: No such file or directory compilation terminated. .... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 3

[Bug 42920] New: Radeon with KMS and UMA works only up to 128MB
by bugzilla-daemon＠bugzilla.kernel.org 02 Apr '12

02 Apr '12

https://bugzilla.kernel.org/show_bug.cgi?id=42920 Summary: Radeon with KMS and UMA works only up to 128MB Product: Drivers Version: 2.5 Kernel Version: 3.3-rc7 Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) AssignedTo: drivers_video-dri(a)kernel-bugs.osdl.org ReportedBy: j.fikar(a)gmail.com Regression: No Hardware: Asus M4A88TD-M EVO with integrated Radeon HD 4250 (RS780) Description: in bios I can choose UMA from 32MB up to 1024MB, but only values up to 128MB work. Higher values lock the console in text mode before switching to KMS. It also happens on older kernels with KMS (2.6.27), but the console is not locked, the radeon module oopses and resolution stays VGA. There is also option to locate UMA "above 4G" or "below 4G" in bios, it doesn't matter. Also it has 128MB of sideport memory, this option doesn't matter neither. (I have it off for now). vramlimit parameter doesn't matter either. System is x86_64, 16GB ECC DDR3 RAM. lspci: 01:05.0 VGA compatible controller: Advanced Micro Devices [AMD] nee ATI RS880 [Radeon HD 4250] (prog-if 00 [VGA controller]) Subsystem: ASUSTeK Computer Inc. M5A88-V EVO Flags: bus master, fast devsel, latency 0, IRQ 18 Memory at f0000000 (32-bit, prefetchable) [size=128M] I/O ports at d000 [size=256] Memory at febe0000 (32-bit, non-prefetchable) [size=64K] Memory at fea00000 (32-bit, non-prefetchable) [size=1M] Expansion ROM at <unassigned> [disabled] Capabilities: [50] Power Management version 3 Capabilities: [a0] MSI: Enable- Count=1/1 Maskable- 64bit+ Kernel driver in use: radeon Kernel modules: radeon dmesg | grep -i -E "drm|radeon" on UMA=128MB; working: [ 0.000000] Kernel command line: root=/dev/md1 md=1,/dev/sda3,/dev/sdb3,/dev/sdc3,/dev/sdd3 rootflags=logbsize=256k,inode64,logbufs=8 mce=bootlog usbcore.autosuspend=1 radeon.benchmark=1 radeon.test=0 radeon.hw_i2c=0 zcache lockd.nlm_udpport=4001 lockd.nlm_tcpport=4001 [ 5.544881] [drm] Initialized drm 1.1.0 20060810 [ 5.644935] [drm] radeon defaulting to kernel modesetting. [ 5.644937] [drm] radeon kernel modesetting enabled. [ 5.644989] radeon 0000:01:05.0: setting latency timer to 64 [ 5.645114] [drm] initializing kernel modesetting (RS880 0x1002:0x9715 0x1043:0x843E). [ 5.645130] [drm] register mmio base: 0xFEBE0000 [ 5.645131] [drm] register mmio size: 65536 [ 5.645707] radeon 0000:01:05.0: VRAM: 128M 0x00000000C0000000 - 0x00000000C7FFFFFF (128M used) [ 5.645709] radeon 0000:01:05.0: GTT: 512M 0x00000000A0000000 - 0x00000000BFFFFFFF [ 5.649847] [drm] Detected VRAM RAM=128M, BAR=128M [ 5.649850] [drm] RAM width 32bits DDR [ 5.649943] [drm] radeon: 128M of VRAM memory ready [ 5.649945] [drm] radeon: 512M of GTT memory ready. [ 5.649958] [drm] Supports vblank timestamp caching Rev 1 (10.10.2010). [ 5.649959] [drm] Driver supports precise vblank timestamp query. [ 5.649976] [drm] radeon: irq initialized. [ 5.649979] [drm] GART: num cpu pages 131072, num gpu pages 131072 [ 5.650514] [drm] radeon: ib pool ready. [ 5.650588] [drm] Loading RS780 Microcode [ 5.812474] [drm] PCIE GART of 512M enabled (table at 0x00000000C0040000). [ 5.812535] radeon 0000:01:05.0: WB enabled [ 5.812537] [drm] fence driver on ring 0 use gpu addr 0xa0000c00 and cpu addr 0xffff88040037ec00 [ 5.844636] [drm] ring test on 0 succeeded in 1 usecs [ 5.844706] [drm] ib test on ring 0 succeeded in 0 usecs [ 6.150041] [drm] radeon: blit 1024 bo moves of 1024 kB from 2 to 4 in 306 ms, throughput: 27408 Mb/s or 3426 MB/s [ 6.455242] [drm] radeon: blit 1024 bo moves of 1024 kB from 4 to 2 in 305 ms, throughput: 27496 Mb/s or 3437 MB/s [ 6.455574] [drm] Radeon Display Connectors [ 6.455576] [drm] Connector 0: [ 6.455577] [drm] VGA [ 6.455578] [drm] DDC: 0x7e40 0x7e40 0x7e44 0x7e44 0x7e48 0x7e48 0x7e4c 0x7e4c [ 6.455579] [drm] Encoders: [ 6.455580] [drm] CRT1: INTERNAL_KLDSCP_DAC1 [ 6.455581] [drm] Connector 1: [ 6.455582] [drm] HDMI-A [ 6.455583] [drm] HPD3 [ 6.455584] [drm] DDC: 0x7e50 0x7e50 0x7e54 0x7e54 0x7e58 0x7e58 0x7e5c 0x7e5c [ 6.455585] [drm] Encoders: [ 6.455586] [drm] DFP3: INTERNAL_KLDSCP_LVTMA [ 6.455604] [drm] radeon: power management initialized [ 6.528664] [drm] fb mappable at 0xF0142000 [ 6.528666] [drm] vram apper at 0xF0000000 [ 6.528667] [drm] size 3932160 [ 6.528668] [drm] fb depth is 24 [ 6.528669] [drm] pitch is 5120 [ 6.528727] fbcon: radeondrmfb (fb0) is primary device [ 6.551936] fb0: radeondrmfb frame buffer device [ 6.551937] drm: registered panic notifier [ 6.551941] [drm] Initialized radeon 2.13.0 20080528 for 0000:01:05.0 on minor 0 dmesg | grep -i -E "drm|radeon" on UMA=256MB; not working: (somehow 3584MB detected). [ 0.000000] Kernel command line: root=/dev/md1 md=1,/dev/sda3,/dev/sdb3,/dev/sdc3,/dev/sdd3 rootflags=logbsize=256k,inode64,logbufs=8 mce=bootlog usbcore.autosuspend=1 radeon.benchmark=1 radeon.test=0 radeon.hw_i2c=0 zcache lockd.nlm_udpport=4001 lockd.nlm_tcpport=4001 [ 6.426011] [drm] Initialized drm 1.1.0 20060810 [ 6.599873] [drm] radeon defaulting to kernel modesetting. [ 6.599875] [drm] radeon kernel modesetting enabled. [ 6.599928] radeon 0000:01:05.0: setting latency timer to 64 [ 6.600040] [drm] initializing kernel modesetting (RS880 0x1002:0x9715 0x1043:0x843E). [ 6.600056] [drm] register mmio base: 0xFEBE0000 [ 6.600057] [drm] register mmio size: 65536 [ 6.600644] radeon 0000:01:05.0: limiting VRAM [ 6.600647] radeon 0000:01:05.0: VRAM: 3584M 0x000000FFFF000000 - 0x00000100DEFFFFFF (3584M used) [ 6.600649] radeon 0000:01:05.0: GTT: 512M 0x00000100DF000000 - 0x00000100FEFFFFFF [ 6.604755] [drm] Detected VRAM RAM=3584M, BAR=256M [ 6.604758] [drm] RAM width 128bits DDR [ 6.604850] [drm] radeon: 3584M of VRAM memory ready [ 6.604852] [drm] radeon: 512M of GTT memory ready. [ 6.604864] [drm] Supports vblank timestamp caching Rev 1 (10.10.2010). [ 6.604865] [drm] Driver supports precise vblank timestamp query. [ 6.604889] [drm] radeon: irq initialized. [ 6.604892] [drm] GART: num cpu pages 131072, num gpu pages 131072 [ 6.605441] [drm] radeon: ib pool ready. [ 6.605505] [drm] Loading RS780 Microcode [ 6.836546] radeon 0000:01:05.0: Wait for MC idle timedout ! [ 7.013520] radeon 0000:01:05.0: Wait for MC idle timedout ! [ 7.028538] [drm] PCIE GART of 512M enabled (table at 0x000000FFFF040000). [ 7.028655] radeon 0000:01:05.0: WB enabled [ 7.028657] [drm] fence driver on ring 0 use gpu addr 0x100df000c00 and cpu addr 0xffff8804080c5c00 [ 7.238041] [drm:r600_ring_test] *ERROR* radeon: ring 0 test failed (scratch(0x8500)=0xFFFFFFFF) [ 7.238043] radeon 0000:01:05.0: disabling GPU acceleration [ 7.239143] radeon 0000:01:05.0: ffff88040821e000 unpin not necessary [ 7.239481] radeon 0000:01:05.0: ffff88040821fc00 unpin not necessary [ 7.239561] WARNING: at drivers/gpu/drm/radeon/radeon_gart.c:184 radeon_gart_bind+0xdc/0xf0 [radeon]() [ 7.239565] Modules linked in: usbhid snd_hda_codec_realtek radeon(+) ttm snd_hda_intel snd_hda_codec drm_kms_helper asus_atk0110 ohci_hcd drm r8169 snd_hwdep i2c_piix4 amd64_edac_mod k10temp [ 7.239598] [<ffffffffa010577c>] ? radeon_gart_bind+0xdc/0xf0 [radeon] [ 7.239610] [<ffffffffa0102f21>] ? radeon_ttm_backend_bind+0x31/0x90 [radeon] [ 7.239648] [<ffffffffa01044cb>] ? radeon_bo_create+0x1ab/0x2b0 [radeon] [ 7.239660] [<ffffffffa01041d0>] ? radeon_bo_clear_va+0xb0/0xb0 [radeon] [ 7.239676] [<ffffffffa0119887>] ? radeon_benchmark_move+0x67/0x2d0 [radeon] [ 7.239696] [<ffffffffa0119b8f>] ? radeon_benchmark+0x9f/0x1d0 [radeon] [ 7.239707] [<ffffffffa00ee654>] ? radeon_device_init+0x564/0x5b0 [radeon] [ 7.239718] [<ffffffffa00efd82>] ? radeon_driver_load_kms+0xa2/0x170 [radeon] [ 7.239729] [<ffffffffa002c496>] ? drm_get_pci_dev+0x186/0x2b0 [drm] [ 7.239765] [drm:radeon_ttm_backend_bind] *ERROR* failed to bind 256 pages at 0x00000000 [ 7.239794] radeon 0000:01:05.0: object_init failed for (1048576, 0x00000002) [ 7.239795] [drm:radeon_benchmark_move] *ERROR* Error while benchmarking BO move. [ 7.239852] WARNING: at drivers/gpu/drm/radeon/radeon_gart.c:184 radeon_gart_bind+0xdc/0xf0 [radeon]() [ 7.239855] Modules linked in: usbhid snd_hda_codec_realtek radeon(+) ttm snd_hda_intel snd_hda_codec drm_kms_helper asus_atk0110 ohci_hcd drm r8169 snd_hwdep i2c_piix4 amd64_edac_mod k10temp [ 7.239880] [<ffffffffa010577c>] ? radeon_gart_bind+0xdc/0xf0 [radeon] [ 7.239892] [<ffffffffa0102f21>] ? radeon_ttm_backend_bind+0x31/0x90 [radeon] [ 7.239926] [<ffffffffa01044cb>] ? radeon_bo_create+0x1ab/0x2b0 [radeon] [ 7.239938] [<ffffffffa01041d0>] ? radeon_bo_clear_va+0xb0/0xb0 [radeon] [ 7.239951] [<ffffffffa01199a7>] ? radeon_benchmark_move+0x187/0x2d0 [radeon] [ 7.239964] [<ffffffffa0119b8f>] ? radeon_benchmark+0x9f/0x1d0 [radeon] [ 7.239975] [<ffffffffa00ee654>] ? radeon_device_init+0x564/0x5b0 [radeon] [ 7.239986] [<ffffffffa00efd82>] ? radeon_driver_load_kms+0xa2/0x170 [radeon] [ 7.239992] [<ffffffffa002c496>] ? drm_get_pci_dev+0x186/0x2b0 [drm] [ 7.240030] [drm:radeon_ttm_backend_bind] *ERROR* failed to bind 256 pages at 0x00000000 [ 7.240058] radeon 0000:01:05.0: object_init failed for (1048576, 0x00000002) [ 7.240373] [drm] Radeon Display Connectors [ 7.240375] [drm] Connector 0: [ 7.240376] [drm] VGA [ 7.240377] [drm] DDC: 0x7e40 0x7e40 0x7e44 0x7e44 0x7e48 0x7e48 0x7e4c 0x7e4c [ 7.240378] [drm] Encoders: [ 7.240379] [drm] CRT1: INTERNAL_KLDSCP_DAC1 [ 7.240380] [drm] Connector 1: [ 7.240381] [drm] HDMI-A [ 7.240382] [drm] HPD3 [ 7.240383] [drm] DDC: 0x7e50 0x7e50 0x7e54 0x7e54 0x7e58 0x7e58 0x7e5c 0x7e5c [ 7.240384] [drm] Encoders: [ 7.240385] [drm] DFP3: INTERNAL_KLDSCP_LVTMA [ 7.240403] [drm] radeon: power management initialized [ 7.426819] [drm] fb mappable at 0xD0142000 [ 7.426821] [drm] vram apper at 0xD0000000 [ 7.426822] [drm] size 3145728 [ 7.426823] [drm] fb depth is 24 [ 7.426824] [drm] pitch is 4096 [ 7.426892] fbcon: radeondrmfb (fb0) is primary device [ 7.826978] fb0: radeondrmfb frame buffer device [ 7.826979] drm: registered panic notifier [ 7.826983] [drm] Initialized radeon 2.13.0 20080528 for 0000:01:05.0 on minor 0 -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 9

[PATCH] drm/i915: disable ppgtt on snb when dmar is enabled
by Daniel Vetter 02 Apr '12

02 Apr '12

Totally unexpected that this regressed. Luckily it sounds like we just need to have dmar disable on the igfx, not the entire system. At least that's what a few days of testing between Tony Vroon and me indicates. Reported-by: Tony Vroon <tony(a)linx.net> Cc: Tony Vroon <tony(a)linx.net> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=43024 Signed-Off-by: Daniel Vetter <daniel.vetter(a)ffwll.ch> --- drivers/char/agp/intel-gtt.c | 1 - drivers/gpu/drm/i915/i915_dma.c | 17 ++++++++++++++++- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 2 +- include/drm/intel-gtt.h | 4 ++++ 5 files changed, 23 insertions(+), 5 deletions(-) diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c index 7e223a2..e086fa5 100644 --- a/drivers/char/agp/intel-gtt.c +++ b/drivers/char/agp/intel-gtt.c @@ -1204,7 +1204,6 @@ static inline int needs_idle_maps(void) { #ifdef CONFIG_INTEL_IOMMU const unsigned short gpu_devid = intel_private.pcidev->device; - extern int intel_iommu_gfx_mapped; /* Query intel_iommu to see if we need the workaround. Presumably that * was loaded first. diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index 4636391..ee06241 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c @@ -1189,6 +1189,21 @@ static bool i915_switcheroo_can_switch(struct pci_dev *pdev) return can_switch; } +static bool +intel_enable_ppgtt(struct drm_device *dev) +{ + if (i915_enable_ppgtt >= 0) + return i915_enable_ppgtt; + +#ifdef CONFIG_INTEL_IOMMU + /* Disable ppgtt on SNB if VT-d is on. */ + if (INTEL_INFO(dev)->gen == 6 && intel_iommu_gfx_mapped) + return false; +#endif + + return true; +} + static int i915_load_gem_init(struct drm_device *dev) { struct drm_i915_private *dev_priv = dev->dev_private; @@ -1203,7 +1218,7 @@ static int i915_load_gem_init(struct drm_device *dev) drm_mm_init(&dev_priv->mm.stolen, 0, prealloc_size); mutex_lock(&dev->struct_mutex); - if (i915_enable_ppgtt && HAS_ALIASING_PPGTT(dev)) { + if (intel_enable_ppgtt(dev) && HAS_ALIASING_PPGTT(dev)) { /* PPGTT pdes are stolen from global gtt ptes, so shrink the * aperture accordingly when using aliasing ppgtt. */ gtt_size -= I915_PPGTT_PD_ENTRIES*PAGE_SIZE; diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 0efc02e..c65907e 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -109,8 +109,8 @@ MODULE_PARM_DESC(enable_hangcheck, "WARNING: Disabling this can cause system wide hangs. " "(default: true)"); -bool i915_enable_ppgtt __read_mostly = 1; -module_param_named(i915_enable_ppgtt, i915_enable_ppgtt, bool, 0600); +int i915_enable_ppgtt __read_mostly = -1; +module_param_named(i915_enable_ppgtt, i915_enable_ppgtt, int, 0600); MODULE_PARM_DESC(i915_enable_ppgtt, "Enable PPGTT (default: true)"); diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index b617cd5..1c8c440 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -1088,7 +1088,7 @@ extern int i915_vbt_sdvo_panel_type __read_mostly; extern int i915_enable_rc6 __read_mostly; extern int i915_enable_fbc __read_mostly; extern bool i915_enable_hangcheck __read_mostly; -extern bool i915_enable_ppgtt __read_mostly; +extern int i915_enable_ppgtt __read_mostly; extern int i915_suspend(struct drm_device *dev, pm_message_t state); extern int i915_resume(struct drm_device *dev); diff --git a/include/drm/intel-gtt.h b/include/drm/intel-gtt.h index 0a0001b..923afb5 100644 --- a/include/drm/intel-gtt.h +++ b/include/drm/intel-gtt.h @@ -44,4 +44,8 @@ void intel_gtt_insert_pages(unsigned int first_entry, unsigned int num_entries, /* flag for GFDT type */ #define AGP_USER_CACHED_MEMORY_GFDT (1 << 3) +#ifdef CONFIG_INTEL_IOMMU +extern int intel_iommu_gfx_mapped; +#endif + #endif -- 1.7.7.6

2 1

[PATCH] nouveau/bios: Fix tracking of BIOS image data
by Benjamin Herrenschmidt 02 Apr '12

02 Apr '12

The code tries various methods for retreiving the BIOS data. However it doesn't clear the bios->data pointer between the iterations. In some cases, the shadow() method will fail and not update bios->data at all, which will cause us to "score" the old data and incorrectly attribute that score to the new method. This can cause double frees later when disposing of the unused data. Additionally, we were not freeing the data for methods that fail the score test (we only freed when a "best" is superseeded, not when the new method has a lower score than the exising "best"). Fix that as well. Signed-off-by: Benjamin Herrenschmidt <benh(a)kernel.crashing.org> --- This was found by code inspection while chasing a different bug, I do not hit the problem path on my machine. drivers/gpu/drm/nouveau/nouveau_bios.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c index 80963d0..1947d61 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bios.c +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c @@ -273,6 +273,7 @@ bios_shadow(struct drm_device *dev) mthd->score = score_vbios(bios, mthd->rw); mthd->size = bios->length; mthd->data = bios->data; + bios->data = NULL; } while (mthd->score != 3 && (++mthd)->shadow); mthd = shadow_methods; @@ -281,7 +282,8 @@ bios_shadow(struct drm_device *dev) if (mthd->score > best->score) { kfree(best->data); best = mthd; - } + } else + kfree(mthd->data); } while ((++mthd)->shadow); if (best->score) { -- 1.7.9.5

1 0

[PATCH] nouveau: Fix crash when pci_ram_rom() returns a size of 0
by Benjamin Herrenschmidt 02 Apr '12

02 Apr '12

>From b15b244d6e6e20964bd4b85306722cb60c3c0809 Mon Sep 17 00:00:00 2001 From: Benjamin Herrenschmidt <benh(a)kernel.crashing.org> Date: Mon, 2 Apr 2012 13:28:18 +1000 Subject: Under some circumstances, pci_map_rom() can return a valid mapping but a size of 0 (if it cannot find an image in the header). This causes nouveau to try to kmalloc() a 0 sized pointer and dereference it, which crashes. Signed-off-by: Benjamin Herrenschmidt <benh(a)kernel.crashing.org> --- Please send to Linus asap, without this, it crashes on the G5 drivers/gpu/drm/nouveau/nouveau_bios.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c index 637afe7..80963d0 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bios.c +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c @@ -177,14 +177,15 @@ bios_shadow_pci(struct nvbios *bios) if (!pci_enable_rom(pdev)) { void __iomem *rom = pci_map_rom(pdev, &length); - if (rom) { + if (rom && length) { bios->data = kmalloc(length, GFP_KERNEL); if (bios->data) { memcpy_fromio(bios->data, rom, length); bios->length = length; } - pci_unmap_rom(pdev, rom); } + if (rom) + pci_unmap_rom(pdev, rom); pci_disable_rom(pdev); } -- 1.7.9.5

1 0

[ANNOUNCE] kmscon: Lazy-web's DRM based terminal emulator
by David Herrmann 01 Apr '12

01 Apr '12

Hi Motivated by Jesse's letter to the lazyweb [1] I worked on a kmscon program. It provides a terminal-emulator similar to the in-kernel terminal-emulator based on DRM. It is written from scratch and needs as external dependencies only mesa (libdrm, libgbm, libEGL, libGLESv2), udev, xproto (build-time dep), libxkbcommon, freetype2 and currently glib (only for unicode support). It uses a very recent version of libxkbcommon but it should be easy to fix ./src/kbd_xkb.c if you use an older version (or use --disable-xkbcommon to use a very basic keyboard handler). If you're curious check it out at github [2]. "./autogen && ./configure --enable-debug [--disable-xkbcommon] && make && ./kmscon --debug --switchvt" should be enough to get it running. "./kmscon --help" shows some usage information. Current state: - Supports multiple displays through DRM (hotplugging works) - Full input support through libxkbcommon (thanks to Ran Benita for that) - Opens a separate VT and can run together with X, wayland, etc. - VTE layer is *very limited* and under development. You can use bash but programs like vim will fail. - only one terminal is currently supported which is cloned to all displays It needs some more work in the VTE layer and on the UI but it's getting close to a first release. I had several issues while writing it but most of them are fixed. One thing I remember is a performance issue running it on my Intel Atom N450. With 80x24 it works barely fine, but more glyphs per frame are are not possible. I currently use one texture for every glyph I draw, that is, one screen-update draws 80x24 = 1920 textures. "perf" shows me 19% in my matrix-multiplication code (which is, I have to admit, not optimized in any way) but also 21% in libdricore.so + 6% in i915_core.so at some unknwon address. Plus about 10% in _mesa_execute_program, _tnl_draw_prims, _tnl_run_pipeline, _mesa_update_state_locked and some others. Even if I optimize my matrix-code, I will never get decent performance. Is it recommended to use cairo (or similar 2D renderer) on machines like the Atom N450 or slower? And then simply render a single texture? On faster machines I don't have this problem. Feedback is welcome! Regards David [1] http://virtuousgeek.org/blog/index.php/jbarnes/2011/10/31/writing_stanalone… [2] http://github.com/dvdhrm/kmscon

4 7

[Bug 47007] New: HDMI monitor polling causing 100ms rendering stalls
by bugzilla-daemon＠freedesktop.org 01 Apr '12

01 Apr '12

https://bugs.freedesktop.org/show_bug.cgi?id=47007 Bug #: 47007 Summary: HDMI monitor polling causing 100ms rendering stalls Classification: Unclassified Product: DRI Version: unspecified Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: DRM/Radeon AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: tvrtko.ursulin(a)onelan.co.uk I am experiencing rendering stalls every ten seconds (drm_kms_helper output connector poll interval) on a AMD G-T56N (Radeon HD 6310) box connected to the monitor via HDMI connector. Kernel is kernel.org's 3.3.0-rc6 kernel. I've delved into the code a bit, sprayed some printks around, and found that the culprit is the drm_get_edid call from radeon_dvi_detect where the former takes more than 100ms. I suspect I2C transfers there are disabling interrupts because I don't see any locks other than drm_device mode mutex being help at that at least sounds harmless. This function (radeon_dvi_detect) is a bit advanced for a newcomer in this area, but, looking at the accompanying comment and the code, I am not sure it could not be improved? For example if monitor is connected, and we know it is a digital monitor, do we need to discard and re-fetch complete EDID every time? Couldn't we just do a quick probe to check for disconnection instead? This is if I understand correctly that EDID probing must be done for disconnection check? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 49

[Bug 48137] New: video hans every few seconds
by bugzilla-daemon＠freedesktop.org 01 Apr '12

01 Apr '12

https://bugs.freedesktop.org/show_bug.cgi?id=48137 Bug #: 48137 Summary: video hans every few seconds Classification: Unclassified Product: DRI Version: XOrg CVS Platform: Other OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/Radeon AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: tcwardrobe(a)gmail.com Created attachment 59319 --> https://bugs.freedesktop.org/attachment.cgi?id=59319 Xorg.0.log after setting the kernel boot parameter it doesn't matter if I try to play h264, xvid or flash-content, video hangs every few seconds. Booting with "drm_kms_helper.poll=0" fixes the issue here. System specs: AMD E-350 CPU in a Zotac Zbox Nano AD10 Plus with "VGA compatible controller [0300]: ATI Technologies Inc Wrestler [Radeon HD 6310] [1002:9802]" Software specs: Debian GNU/Linux "wheezy" (testing), Linux kernel 3.2.12 (Debian kernel image), Xserver 1.11.4, libdrm-radeon 2.4.30, mesa-utils 8.0.1, libgl1-mesa-dri 7.11.2. regards Michael -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2012