dri-devel August 2012

dri-devel@lists.freedesktop.org

145 participants
811 discussions

[REVIEW][PATCH 12/15] userns: Convert drm to use kuid and kgid and struct pid where appropriate
by ebiederm＠xmission.com 13 Sep '12

13 Sep '12

Blink Blink this had not been converted to use struct pid ages ago? - On drm open capture the openers kuid and struct pid. - On drm close release the kuid and struct pid - When reporting the uid and pid convert the kuid and struct pid into values in the appropriate namespace. Cc: David Airlie <airlied(a)linux.ie> Cc: dri-devel(a)lists.freedesktop.org Acked-by: Serge Hallyn <serge.hallyn(a)canonical.com> Signed-off-by: Eric W. Biederman <ebiederm(a)xmission.com> --- drivers/gpu/drm/drm_fops.c | 3 ++- drivers/gpu/drm/drm_info.c | 5 +++-- drivers/gpu/drm/drm_ioctl.c | 4 ++-- include/drm/drmP.h | 4 ++-- init/Kconfig | 1 - 5 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_fops.c b/drivers/gpu/drm/drm_fops.c index 5062eec..433d2fa 100644 --- a/drivers/gpu/drm/drm_fops.c +++ b/drivers/gpu/drm/drm_fops.c @@ -251,7 +251,7 @@ static int drm_open_helper(struct inode *inode, struct file *filp, filp->private_data = priv; priv->filp = filp; priv->uid = current_euid(); - priv->pid = task_pid_nr(current); + priv->pid = get_pid(task_pid(current)); priv->minor = idr_find(&drm_minors_idr, minor_id); priv->ioctl_count = 0; /* for compatibility root is always authenticated */ @@ -524,6 +524,7 @@ int drm_release(struct inode *inode, struct file *filp) if (drm_core_check_feature(dev, DRIVER_PRIME)) drm_prime_destroy_file_private(&file_priv->prime); + put_pid(file_priv->pid); kfree(file_priv); /* ======================================================== diff --git a/drivers/gpu/drm/drm_info.c b/drivers/gpu/drm/drm_info.c index 8928edb..eb0af39 100644 --- a/drivers/gpu/drm/drm_info.c +++ b/drivers/gpu/drm/drm_info.c @@ -191,8 +191,9 @@ int drm_clients_info(struct seq_file *m, void *data) seq_printf(m, "%c %3d %5d %5d %10u %10lu\n", priv->authenticated ? 'y' : 'n', priv->minor->index, - priv->pid, - priv->uid, priv->magic, priv->ioctl_count); + pid_vnr(priv->pid), + from_kuid_munged(seq_user_ns(m), priv->uid), + priv->magic, priv->ioctl_count); } mutex_unlock(&dev->struct_mutex); return 0; diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index 64a62c6..39a4383 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c @@ -215,8 +215,8 @@ int drm_getclient(struct drm_device *dev, void *data, list_for_each_entry(pt, &dev->filelist, lhead) { if (i++ >= idx) { client->auth = pt->authenticated; - client->pid = pt->pid; - client->uid = pt->uid; + client->pid = pid_vnr(pt->pid); + client->uid = from_kuid_munged(current_user_ns(), pt->uid); client->magic = pt->magic; client->iocs = pt->ioctl_count; mutex_unlock(&dev->struct_mutex); diff --git a/include/drm/drmP.h b/include/drm/drmP.h index d6b67bb..9bc5c6a 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -426,8 +426,8 @@ struct drm_prime_file_private { /** File private data */ struct drm_file { int authenticated; - pid_t pid; - uid_t uid; + struct pid *pid; + kuid_t uid; drm_magic_t magic; unsigned long ioctl_count; struct list_head lhead; diff --git a/init/Kconfig b/init/Kconfig index d849ba2..2a388e5 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -930,7 +930,6 @@ config UIDGID_CONVERTED depends on FS_POSIX_ACL = n depends on QUOTA = n depends on QUOTACTL = n - depends on DRM = n # Networking depends on NET_9P = n -- 1.7.5.4

2 3

[Bug 28550] New: [UMS vs KMS]: Openarena performance drops by half with KMS enabled
by bugzilla-daemon＠freedesktop.org 12 Sep '12

12 Sep '12

https://bugs.freedesktop.org/show_bug.cgi?id=28550 Summary: [UMS vs KMS]: Openarena performance drops by half with KMS enabled Product: Mesa Version: unspecified Platform: x86 (IA32) OS/Version: other Status: NEW Severity: major Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: hysvats(a)gmail.com Created an attachment (id=36284) --> (https://bugs.freedesktop.org/attachment.cgi?id=36284) Xorg.log KMS Driver Stack details : ========================= 1) Kernel-2.6.32-21-generic-pae 2) Libdrm-2.4.19 3) Mesa-7.8-rc2 4) Xorg-server-1.7.4 5) ddx: xf86-video-ati-6.13.0 System Environment : =================== O.S. - Ubuntu-10.04(32bit) Asic - RV790XT CPU - Intel(R) Core(TM)@ 1.86GHz Steps to Reproduce: =================== 1) Install Phoronix-test-suite from http://www.phoronix-test-suite.com/releases/repo/pts.debian/files/phoronix-… 2) Install openarena game phoronix-test-suite install openarena 3) Run the game with 1920x1080 phoronix-test-suite run openarena Observation : ============= 1) FPS observed is 60.2 2) Disable KMS and run the test again with the same resolution With UMS FPS is 118.4 3) Bloom option is disabled before running both the tests. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 4

[Bug 30122] New: r600 scrambled render when using 2d texture sample for 1d texture co-ord in fragment shader
by bugzilla-daemon＠freedesktop.org 12 Sep '12

12 Sep '12

https://bugs.freedesktop.org/show_bug.cgi?id=30122 Summary: r600 scrambled render when using 2d texture sample for 1d texture co-ord in fragment shader Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: thomas.jones(a)utoronto.ca Created an attachment (id=38612) --> (https://bugs.freedesktop.org/attachment.cgi?id=38612) small program that triggers the bug Using a shader like this results in a strange scrambled rendering: uniform sampler2D src; uniform sampler1D pal; void main() { gl_FragColor = texture1D(pal, texture2D(src, gl_TexCoord[0].xy).x); } it looks like in addition to just being messed up it also gets the texture co-ordinates wrong (I'm rending with GL_QUADS, the two triangles that make up the quad seem to be interpolating differently across the middle) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 6

[Bug 31246] New: Reproducible hangs on piglit tests with 5850
by bugzilla-daemon＠freedesktop.org 12 Sep '12

12 Sep '12

https://bugs.freedesktop.org/show_bug.cgi?id=31246 Summary: Reproducible hangs on piglit tests with 5850 Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: temp9476-freedesktop(a)yahoo.no Ignoring the occasional random hang, I have found that the following tests create a lockup of the system every time: glsl-fs-main-return glsl-vs-main-return glsl-max-varyings glsl-fs-vec4-indexing-temp-dst-in-nested-loop-combined glsl-vs-vec4-indexing-temp-dst-in-nested-loop-combined How would I go about debugging these further? It would be very nice if the piglit tests would at least fail, not hang... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 9

[Bug 30693] New: [R600c KWin 4.5.2] Blur does not work with RV670 (it works with RV710)
by bugzilla-daemon＠freedesktop.org 12 Sep '12

12 Sep '12

https://bugs.freedesktop.org/show_bug.cgi?id=30693 Summary: [R600c KWin 4.5.2] Blur does not work with RV670 (it works with RV710) Product: DRI Version: XOrg CVS Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: DRM/Radeon AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: darkbasic4(a)gmail.com Created an attachment (id=39272) --> (https://bugs.freedesktop.org/attachment.cgi?id=39272) Blur not working Hi, with 2.6.36-rc7|drm-radeon-testing and latest graphic stack snapshot kwin's 4.5.2 blur effect does not work. I have an HD3870, but someone else told me it works with RV710 (http://www.phoronix.com/forums/showthread.php?t=26221). I attached a screenshot. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 13

[Bug 51344] New: massive corruption on RV515
by bugzilla-daemon＠freedesktop.org 12 Sep '12

12 Sep '12

https://bugs.freedesktop.org/show_bug.cgi?id=51344 Bug #: 51344 Summary: massive corruption on RV515 Classification: Unclassified Product: DRI Version: XOrg CVS Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/Radeon AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: bugzi11.fdo.tormod(a)xoxy.net Created attachment 63356 --> https://bugs.freedesktop.org/attachment.cgi?id=63356 Xorg.0.log This happened early May on drm-next somewhere between 4f256e8..d3029b4, and is still there in 3.5rc3 (and in current drm-next). Things are smeared out vertically. Looks like desktop background is not corrupted. By turning off "EXABitmaps" there is less corruption. I haven't done git bisecting, only download bisecting from http://kernel.ubuntu.com/~kernel-ppa/mainline/drm-next/ and v3.4-rc6-295-g4f256e8 from May 8th was good and v3.4-rc6-315-gd3029b4 from May 10th was bad. Unfortunately the build from May 9th has been deleted in the meantime so I can not narrow it down further this way. So the commits in question should be: d3029b4 drm/radeon/kms: fix warning on 32-bit in atomic fence printing f2e3922 drm/radeon: make the ib an inline object f237750 drm/radeon: remove r600 blit mutex v2 68470ae drm/radeon: move the semaphore from the fence into the ib 7c0d409 drm/radeon: immediately free ttm-move semaphore c507f7e drm/radeon: rip out the ib pool a8c0594 drm/radeon: simplify semaphore handling v2 c3b7fe8 drm/radeon: multiple ring allocator v3 0085c950 drm/radeon: use one wait queue for all rings add fence_wait_any v2 557017a drm/radeon: define new SA interface v3 2e0d991 drm/radeon: make sa bo a stand alone object e6661a9 drm/radeon: keep start and end offset in the SA 711a972 drm/radeon: add sub allocator debugfs file a651c55 drm/radeon: add proper locking to the SA v3 dd8bea2 drm/radeon: use inline functions to calc sa_bo addr 8a47cc9 drm/radeon: rework locking ring emission mutex in fence deadlock detection v2 3b7a2b2 drm/radeon: rework fence handling, drop fence list v7 bb63556 drm/radeon: convert fence to uint64_t v4 d6999bc drm/radeon: replace the per ring mutex with a global one 133f4cb drm/radeon: fix possible lack of synchronization btw ttm and other ring 01:00.0 VGA compatible controller [0300]: Advanced Micro Devices [AMD] nee ATI Radeon Mobility X700 (PCIE) [1002:5653] -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 13

[Bug 27937] New: SEGV in r700_assembler.c next_ins() with RV670 kms
by bugzilla-daemon＠freedesktop.org 11 Sep '12

11 Sep '12

https://bugs.freedesktop.org/show_bug.cgi?id=27937 Summary: SEGV in r700_assembler.c next_ins() with RV670 kms Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: a.heider(a)gmail.com the game 0ad crashes when just starting a single player game. ubuntu lucid, mainline 2.6.34-rc6, xorg-edgers #0 0x00007fffea2926e3 in next_ins (pAsm=0x7fffe11b4690) at r700_assembler.c:2619 No locals. #1 0x00007fffea292f4b in assemble_MOV (pAsm=0x7fffe11b4690) at r700_assembler.c:3874 No locals. #2 0x00007fffea297b4d in AssembleInstr (uiFirstInst=1, uiIL_Shift=256, uiNumberInsts=4, pILInst=0x7fffe11b6550, pR700AsmCode=0x7fffe11b4690) at r700_assembler.c:5622 No locals. #3 0x00007fffea299678 in r700TranslateFragmentShader (fp=0x7fffe11b03e0, mesa_fp=0x7fffe11b03e0, ctx=0xb615d0) at r700_fragprog.c:412 number_of_colors_exported = <value optimized out> z_enabled = <value optimized out> shadow_unit = <value optimized out> i = 126 inst = 0x0 shadow_ambient = {STATE_INTERNAL, STATE_SHADOW_AMBIENT, 0, 0, 0} #4 0x00007fffea2a4ac7 in r700UpdateShaders (ctx=0x7fffe11b4690) at r700_state.c:73 No locals. #5 0x00007fffea2a6097 in r700TryDrawPrims (ctx=0xb615d0, arrays=<value optimized out>, prim=<value optimized out>, nr_prims=<value optimized out>, ib=0x7fffffffdfe0, index_bounds_valid=<value optimized out>, min_index=0, max_index=126) at r700_render.c:904 i = <value optimized out> rrb = <value optimized out> emit_end = <value optimized out> #6 r700DrawPrims (ctx=0xb615d0, arrays=<value optimized out>, prim=<value optimized out>, nr_prims=<value optimized out>, ib=0x7fffffffdfe0, index_bounds_valid=<value optimized out>, min_index=0, max_index=126) at r700_render.c:993 No locals. #7 0x00007fffea350dec in vbo_validated_drawrangeelements (ctx=0xb615d0, mode=4, index_bounds_valid=<value optimized out>, start=0, end=126, count=126, type=5123, indices=0x7fffe110b010, basevertex=0, primcount=1) at vbo/vbo_exec_array.c:721 ib = {count = 126, type = 5123, obj = 0xb03e80, ptr = 0x7fffe110b010} prim = {{mode = 4, indexed = 1, begin = 1, end = 1, weak = 0, pad = 0, start = 0, count = 126, basevertex = 0, num_instances = 1}} #8 0x00007fffea35107d in vbo_exec_DrawRangeElementsBaseVertex ( mode=<value optimized out>, start=0, end=126, count=126, type=5123, indices=0x7fffe110b010, basevertex=0) at vbo/vbo_exec_array.c:829 warnCount = 0 ctx = 0xb615d0 __PRETTY_FUNCTION__ = "vbo_exec_DrawRangeElementsBaseVertex" #9 0x00007fffea351170 in vbo_exec_DrawRangeElements (mode=3776661136, start=256, end=7, count=-518298288, type=256, indices=0x3) at vbo/vbo_exec_array.c:846 No locals. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 10

-next queue and EDID stuff
by Dave Airlie 11 Sep '12

11 Sep '12

Hi guys (but mainly ajax) I have a bunch of EDID and quirk stuff outstanding, I've made a bundle on patchwork for it https://patchwork.kernel.org/bundle/airlied/edid-review/ Dave.

7 16

[Bug 31423] New: Stars in Celestia misrendered
by bugzilla-daemon＠freedesktop.org 11 Sep '12

11 Sep '12

https://bugs.freedesktop.org/show_bug.cgi?id=31423 Summary: Stars in Celestia misrendered Product: Mesa Version: 7.9 Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: bio_tube(a)yahoo.com Created an attachment (id=40076) --> (https://bugs.freedesktop.org/attachment.cgi?id=40076) Misrenderd stars from Celestia All the stars in Celestia are rendered as yellow dots(zooming in on one gives something that looks correct, however); r600g gets the colors right(if not the shape, but that's another bug), so this seems to be a driver issue. I've tested it on a Radeon HD 3450 and the bug was originally reported on #radeon today by djzn, who tested with an HD 3200 and HD 2600XT and got the same result. Celestia mentions loading a number of ARB shaders, but with no error and gives no indication of problems(output below). Initializing ARB vertex programs . . . Loading ARB vertex program: shaders/diffuse_arb.vp Loading ARB vertex program: shaders/specular_arb.vp Loading ARB vertex program: shaders/haze_arb.vp Loading ARB vertex program: shaders/bumpdiffuse_arb.vp Loading ARB vertex program: shaders/bumphaze_arb.vp Loading ARB vertex program: shaders/shadowtex_arb.vp Loading ARB vertex program: shaders/diffuse_texoff_arb.vp Loading ARB vertex program: shaders/rings_arb.vp Loading ARB vertex program: shaders/ringshadow_arb.vp Loading ARB vertex program: shaders/night_arb.vp Loading ARB vertex program: shaders/glossmap_arb.vp Loading ARB vertex program: shaders/diffuse2_arb.vp Loading ARB vertex program: shaders/haze2_arb.vp Loading ARB vertex program: shaders/diffuse_texoff2_arb.vp Loading ARB vertex program: shaders/specular2_arb.vp Loading ARB vertex program: shaders/night2_arb.vp Loading ARB vertex program: shaders/star_arb.vp Loading ARB vertex program: shaders/multishadow_arb.vp Loading ARB vertex program: shaders/texphong_arb.vp Loading ARB vertex program: shaders/texphong_alpha_arb.vp Loading ARB vertex program: shaders/ell_galaxy_arb.vp All ARB vertex programs loaded successfully. render path: 8 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 3

[Bug 29691] New: Lightsmark isnt rendering textures
by bugzilla-daemon＠freedesktop.org 11 Sep '12

11 Sep '12

https://bugs.freedesktop.org/show_bug.cgi?id=29691 Summary: Lightsmark isnt rendering textures Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: schmaker(a)ifrit.eu Hello there, Lightsmark isnt rendering textures on R600 driver. I guess its some extension missing or something. Screenshot is included. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 1

← Newer
1
...
40
41
42
43
44
45
46
...
82
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel August 2012