dri-devel August 2012

dri-devel@lists.freedesktop.org

145 participants
811 discussions

[Bug 20142] enabling underscan by default behaves badly with so many monitors.
by bugzilla-daemon＠bugzilla.kernel.org 14 Aug '12

14 Aug '12

https://bugzilla.kernel.org/show_bug.cgi?id=20142 Alan <alan(a)lxorguk.ukuu.org.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |contact+kernel(a)toniob.net --- Comment #10 from Alan <alan(a)lxorguk.ukuu.org.uk> 2012-08-14 11:21:05 --- *** Bug 20982 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 0

[Bug 20752] [KMS] radeon not working reliable with X1300
by bugzilla-daemon＠bugzilla.kernel.org 14 Aug '12

14 Aug '12

https://bugzilla.kernel.org/show_bug.cgi?id=20752 Alan <alan(a)lxorguk.ukuu.org.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alan(a)lxorguk.ukuu.org.uk Kernel Version|2.6.35 |2.6.38 -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 0

[Bug 20142] enabling underscan by default behaves badly with so many monitors.
by bugzilla-daemon＠bugzilla.kernel.org 14 Aug '12

14 Aug '12

https://bugzilla.kernel.org/show_bug.cgi?id=20142 Alan <alan(a)lxorguk.ukuu.org.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |alan(a)lxorguk.ukuu.org.uk Resolution| |CODE_FIX -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 0

[PATCH] drm: Initialize object type when using DRM_MODE() macro
by ville.syrjala＠linux.intel.com 14 Aug '12

14 Aug '12

From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> DRM_MODE() macro doesn't initialize the type of the base drm object. When a copy is made of the mode, the object type is overwritten with zero, and the the object can no longer be found by drm_mode_object_find() due to the type check failing. Signed-off-by: Ville Syrjälä <ville.syrjala(a)linux.intel.com> --- include/drm/drm_crtc.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index a1a0386..8469ee0 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -118,7 +118,8 @@ enum drm_mode_status { .hdisplay = (hd), .hsync_start = (hss), .hsync_end = (hse), \ .htotal = (ht), .hskew = (hsk), .vdisplay = (vd), \ .vsync_start = (vss), .vsync_end = (vse), .vtotal = (vt), \ - .vscan = (vs), .flags = (f), .vrefresh = 0 + .vscan = (vs), .flags = (f), .vrefresh = 0, \ + .base.type = DRM_MODE_OBJECT_MODE #define CRTC_INTERLACE_HALVE_V 0x1 /* halve V values for interlacing */ -- 1.7.8.6

1 0

[Patch v2 1/4] Replace i2f() in r600_blit.c with an optimized version.
by Steven Fuerst 14 Aug '12

14 Aug '12

We use __fls() to find the most significant bit. Using that, the loop can be avoided. A second trick is to use the behaviour of the rotate instructions to expand the range of the unsigned int to float conversion to the full 32 bits in a branchless way. The routine is now exact up to 2^24. Above that, we truncate which is equivalent to rounding towards zero. Signed-off-by: Steven Fuerst <svfuerst(a)gmail.com> --- drivers/gpu/drm/radeon/r600_blit.c | 50 ++++++++++++++++++++---------------- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_blit.c b/drivers/gpu/drm/radeon/r600_blit.c index 3c031a4..326a8da 100644 --- a/drivers/gpu/drm/radeon/r600_blit.c +++ b/drivers/gpu/drm/radeon/r600_blit.c @@ -489,29 +489,35 @@ set_default_state(drm_radeon_private_t *dev_priv) ADVANCE_RING(); } -static uint32_t i2f(uint32_t input) +/* 23 bits of float fractional data */ +#define I2F_FRAC_BITS 23 +#define I2F_MASK ((1 << I2F_FRAC_BITS) - 1) + +/* + * Converts unsigned integer into 32-bit IEEE floating point representation. + * Will be exact from 0 to 2^24. Above that, we round towards zero + * as the fractional bits will not fit in a float. (It would be better to + * round towards even as the fpu does, but that is slower.) + */ +static uint32_t i2f(uint32_t x) { - u32 result, i, exponent, fraction; - - if ((input & 0x3fff) == 0) - result = 0; /* 0 is a special case */ - else { - exponent = 140; /* exponent biased by 127; */ - fraction = (input & 0x3fff) << 10; /* cheat and only - handle numbers below 2^^15 */ - for (i = 0; i < 14; i++) { - if (fraction & 0x800000) - break; - else { - fraction = fraction << 1; /* keep - shifting left until top bit = 1 */ - exponent = exponent - 1; - } - } - result = exponent << 23 | (fraction & 0x7fffff); /* mask - off top bit; assumed 1 */ - } - return result; + uint32_t msb, exponent, fraction; + + /* Zero is special */ + if (!x) return 0; + + /* Get location of the most significant bit */ + msb = __fls(x); + + /* + * Use a rotate instead of a shift because that works both leftwards + * and rightwards due to the mod(32) behaviour. This means we don't + * need to check to see if we are above 2^24 or not. + */ + fraction = ror32(x, (msb - I2F_FRAC_BITS) & 0x1f) & I2F_MASK; + exponent = (127 + msb) << I2F_FRAC_BITS; + + return fraction + exponent; } -- 1.7.10.4

2 4

Re: [pull] -fixes for 3.6
by Daniel Vetter 14 Aug '12

14 Aug '12

Meh, I've again forgotten about all the cc's ... /me needs coffee On Tue, Aug 14, 2012 at 10:28 AM, Daniel Vetter <daniel(a)ffwll.ch> wrote: > Hi Dave, > > A few important fixers: > - fix various lvds backlight issues, regressed in 3.6 (Takashi Iwai) > - make the retina mbp work (ignore bogus edp bpc value in vbt) > - fix a gmbus regression introduced in (iirc) 3.4 (Jani Nikula) > - fix an edp panel power sequence regression, fixes the new macbook air > - apply the tlb invalidate w/a > > Otherwise we still have another gmbus regression (patches are awaiting > tested-bys) and there's something odd going with some rare systems not > entering rc6 often enough (and hence blowing through too much power). It > seems to be a timing-related issue and can be mitigated by frobbing the > magic tuning parameters. We're still working on that one. Also, we still > have some fallout from the hw context support, but you can only hit that > with mesa master. > > Yours, Daniel > > > The following changes since commit 9830605d4c070b16ec5c24a75503877cc7698409: > > drm/mgag200: fix G200ER pll picking algorithm (2012-08-10 20:31:37 +1000) > > are available in the git repository at: > > git://people.freedesktop.org/~danvet/drm-intel drm-intel-fixes > > for you to fetch changes up to 7d54a904285b6e780291b91a518267bec5591913: > > drm/i915: Apply post-sync write for pipe control invalidates (2012-08-14 09:47:45 +0200) > > ---------------------------------------------------------------- > Chris Wilson (1): > drm/i915: Apply post-sync write for pipe control invalidates > > Daniel Vetter (2): > drm/i915: ignore eDP bpc settings from vbt > drm/i915: reorder edp disabling to fix ivb MacBook Air > > Jani Nikula (1): > drm/i915: ensure i2c adapter is all set before adding it > > Takashi Iwai (1): > drm/i915: Fix blank panel at reopening lid > > drivers/gpu/drm/i915/intel_display.c | 11 --------- > drivers/gpu/drm/i915/intel_dp.c | 14 +++++------ > drivers/gpu/drm/i915/intel_i2c.c | 7 +++--- > drivers/gpu/drm/i915/intel_panel.c | 13 +++++++--- > drivers/gpu/drm/i915/intel_ringbuffer.c | 41 +++++++++++++++++-------------- > 5 files changed, 43 insertions(+), 43 deletions(-) > -- > Daniel Vetter > Mail: daniel(a)ffwll.ch > Mobile: +41 (0)79 365 57 48 -- Daniel Vetter daniel.vetter(a)ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch

1 0

[Bug 43477] New: rendering errors in unigine tropics and sanctuary (regression)
by bugzilla-daemon＠freedesktop.org 14 Aug '12

14 Aug '12

https://bugs.freedesktop.org/show_bug.cgi?id=43477 Bug #: 43477 Summary: rendering errors in unigine tropics and sanctuary (regression) Classification: Unclassified Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: aaalmosss(a)gmail.com Some shaders fail to compile with mesa 7.12-dev, this is printed to console a couple of times: GLShader::loadFragment(): error in "core/shaders/meshes/fragment_base_light_omni.shader" file defines: UNKNOWN,QUALITY_LOW,QUALITY_MEDIUM,QUALITY_HIGH,MULTISAMPLE_0,USE_INSTANCING,USE_TEXTURE_ARRAY,USE_DEFERRED,USE_TRANSLUCENT,USE_PARALLAX,USE_REFLECTION,OPENGL,USE_PSEUDO_INSTANCING,USE_PSEUDO_TRANSFORM,BASE_LIGHT_OMNI,OMNI,SHADOW,PHONG_RIM 0:460(18): error: syntax error, unexpected NEW_IDENTIFIER In tropics the night scenes are rendered incorrectly, in sanctuary almost everything is gray. With 7.11 these demos render correctly. Tested on hd6850. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 6

[git pull] drm fixes
by Dave Airlie 13 Aug '12

13 Aug '12

Hi Linus, radeon and intel fixes mostly, one fix to the mgag200 driver to not hang on certain server variants. Dave. The following changes since commit 0d7614f09c1ebdbaa1599a5aba7593f147bf96ee: Linux 3.6-rc1 (2012-08-02 16:38:10 -0700) are available in the git repository at: git://people.freedesktop.org/~airlied/linux.git drm-fixes for you to fetch changes up to 7bac6b46607f2f44075cb45dd5b0b4d2e7c80695: Merge branch 'drm-fixes-3.6' of git://people.freedesktop.org/~agd5f/linux into drm-fixes (2012-08-14 09:25:01 +1000) ---------------------------------------------------------------- Alan Cox (3): vlv: it might be wise if we initialised the flag value... i915: fix error path leak in intel_sdvo_write_cmd i915: Remove silly test Alex Deucher (9): drm/radeon: fix handling for ddc type 5 on combios drm/radeon/dce4+: set a more reasonable cursor watermark drm/radeon: properly handle SS overrides on TN (v2) drm/radeon: properly handle crtc powergating drm/radeon: fix bank tiling parameters on evergreen drm/radeon: fix bank tiling parameters on cayman drm/radeon: fix ordering in pll picking on dce4+ drm/radeon: add some new SI pci ids drm/radeon: fix some missing parens in asic macros Alexey Khoroshilov (1): drm/edid: Fix potential memory leak in edid_load() Chris Wilson (1): drm/i915: Workaround hang with BSD and forcewake on SandyBridge Christian König (1): drm/radeon: fix bank tiling parameters on SI Daniel Vetter (2): drm/i915: fix forcewake related hangs on snb drm/i915: correctly order the ring init sequence Dave Airlie (4): i915: don't map imported dma-bufs for dmar. Merge branch 'drm-intel-fixes' of git://people.freedesktop.org/~danvet/drm-intel into drm-next drm/mgag200: fix G200ER pll picking algorithm Merge branch 'drm-fixes-3.6' of git://people.freedesktop.org/~agd5f/linux into drm-fixes Devendra Naga (1): drm/i915: remove unused variable Dmitrii Cherkasov (1): drm/radeon: fix typo in function header comment Eric Anholt (1): drm/i915: Don't forget to apply SNB PIPE_CONTROL GTT workaround. Hunt Xu (1): drm/i915: make rc6 in sysfs functions conditional Jerome Glisse (2): drm/radeon: do not reenable crtc after moving vram start address drm/radeon: fence virtual address and free it once idle v4 Marek Olšák (4): drm/radeon/kms: allow "invalid" DB formats as a means to disable DB drm/radeon/kms: reorder code in r600_check_texture_resource drm/radeon/kms: add MSAA texture support for r600-evergreen drm/radeon/kms: implement timestamp userspace query (v2) Paulo Zanoni (1): drm/i915: add more Haswell PCI IDs Stéphane Marchesin (1): drm/i915: Make intel_panel_get_backlight static. Thomas Meyer (1): drm/udl: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(.. [1] drivers/char/agp/intel-agp.h | 39 +++++++++++++-- drivers/char/agp/intel-gtt.c | 60 +++++++++++++++++++++- drivers/gpu/drm/drm_edid_load.c | 8 +-- drivers/gpu/drm/i915/i915_drv.c | 31 +++++++++++- drivers/gpu/drm/i915/i915_gem_context.c | 1 - drivers/gpu/drm/i915/i915_gem_execbuffer.c | 20 ++++---- drivers/gpu/drm/i915/i915_gem_gtt.c | 3 +- drivers/gpu/drm/i915/i915_sysfs.c | 12 +++++ drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 20 ++++---- drivers/gpu/drm/i915/intel_i2c.c | 3 -- drivers/gpu/drm/i915/intel_panel.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 6 ++- drivers/gpu/drm/i915/intel_ringbuffer.c | 7 ++- drivers/gpu/drm/i915/intel_sdvo.c | 5 +- drivers/gpu/drm/mgag200/mgag200_mode.c | 12 +++-- drivers/gpu/drm/radeon/atombios_crtc.c | 22 ++++++--- drivers/gpu/drm/radeon/evergreen.c | 71 +++++---------------------- drivers/gpu/drm/radeon/evergreen_cs.c | 13 ++++- drivers/gpu/drm/radeon/evergreend.h | 2 + drivers/gpu/drm/radeon/ni.c | 14 ++++-- drivers/gpu/drm/radeon/r600.c | 20 ++++++++ drivers/gpu/drm/radeon/r600_cs.c | 65 +++++++++++++----------- drivers/gpu/drm/radeon/r600d.h | 3 ++ drivers/gpu/drm/radeon/radeon.h | 12 +++-- drivers/gpu/drm/radeon/radeon_asic.h | 10 ++-- drivers/gpu/drm/radeon/radeon_atombios.c | 49 +++++++++++++----- drivers/gpu/drm/radeon/radeon_combios.c | 57 +++++++++++++-------- drivers/gpu/drm/radeon/radeon_cs.c | 32 ++++++++++-- drivers/gpu/drm/radeon/radeon_cursor.c | 6 ++- drivers/gpu/drm/radeon/radeon_device.c | 1 + drivers/gpu/drm/radeon/radeon_drv.c | 5 +- drivers/gpu/drm/radeon/radeon_gart.c | 26 ++++++++-- drivers/gpu/drm/radeon/radeon_gem.c | 13 +---- drivers/gpu/drm/radeon/radeon_kms.c | 35 ++++++++++--- drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 4 ++ drivers/gpu/drm/radeon/radeon_mode.h | 1 + drivers/gpu/drm/radeon/radeon_object.c | 6 +-- drivers/gpu/drm/radeon/rv515.c | 13 ----- drivers/gpu/drm/radeon/si.c | 35 +++++++++++-- drivers/gpu/drm/radeon/sid.h | 3 ++ drivers/gpu/drm/udl/udl_gem.c | 2 +- include/drm/drm_pciids.h | 3 ++ include/drm/radeon_drm.h | 2 + 44 files changed, 516 insertions(+), 239 deletions(-)

1 0

[BUG] Intel xorg driver 2.20.2 overlay off-by-one bug
by Russell King - ARM Linux 13 Aug '12

13 Aug '12

While reading through the Intel driver code, I spotted this in I830SetPortAttributeOverlay: } else if (attribute == xvPipe) { xf86CrtcConfigPtr xf86_config = XF86_CRTC_CONFIG_PTR(scrn); if ((value < -1) || (value > xf86_config->num_crtc)) return BadValue; if (value < 0) adaptor_priv->desired_crtc = NULL; else adaptor_priv->desired_crtc = xf86_config->crtc[value]; This allows value == xf86_config->num_crtc to be valid, which would be the CRTC number _after_ the last one in the array. Presumably this is not desired, and the test should be ">=".

2 1

[PATCH] drm/radeon: Include swiotlb.h if SWIOTLB configured.
by Huacai Chen 13 Aug '12

13 Aug '12

When SWIOTLB is configured, if without this patch kernel compilation fails with such error messages: drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_ttm_tt_populate': drivers/gpu/drm/radeon/radeon_ttm.c:606:2: error: implicit declaration of function 'swiotlb_nr_tbl' drivers/gpu/drm/radeon/radeon_ttm.c:607:3: warning: passing argument 2 of 'ttm_dma_populate' from incompatible pointer type include/drm/ttm/ttm_page_alloc.h:81:12: note: expected 'struct device *' but argument is of type 'struct device *' drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_ttm_tt_unpopulate': drivers/gpu/drm/radeon/radeon_ttm.c:653:3: warning: passing argument 2 of 'ttm_dma_unpopulate' from incompatible pointer type include/drm/ttm/ttm_page_alloc.h:82:13: note: expected 'struct device *' but argument is of type 'struct device *' Signed-off-by: Huacai Chen <chenhc(a)lemote.com> Signed-off-by: Hongliang Tao <taohl(a)lemote.com> Signed-off-by: Hua Yan <yanh(a)lemote.com> Cc: dri-devel(a)lists.freedesktop.org --- drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index 5b71c71..fc3ac22 100644 --- a/drivers/gpu/drm/radeon/radeon_ttm.c +++ b/drivers/gpu/drm/radeon/radeon_ttm.c @@ -41,6 +41,10 @@ #include "radeon_reg.h" #include "radeon.h" +#ifdef CONFIG_SWIOTLB +#include <linux/swiotlb.h> +#endif + #define DRM_FILE_PAGE_OFFSET (0x100000000ULL >> PAGE_SHIFT) static int radeon_ttm_debugfs_init(struct radeon_device *rdev); -- 1.7.7.3

2 1

← Newer
1
...
65
66
67
68
69
70
71
...
82
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel August 2012