dri-devel August 2012

dri-devel@lists.freedesktop.org

145 participants
811 discussions

[Bug 48131] New: Very large 2D texture is sometimes corrupted
by bugzilla-daemon＠freedesktop.org 08 Aug '12

08 Aug '12

https://bugs.freedesktop.org/show_bug.cgi?id=48131 Bug #: 48131 Summary: Very large 2D texture is sometimes corrupted Classification: Unclassified Product: Mesa Version: unspecified Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: bjacob(a)mozilla.com This WebGL testcase just creates a huge blank texture and draws a quad with it: http://people.mozilla.org/~bjacob/webgltexture2D5k.html You should see only black. But here I occasionally see some corruption with vertical yellow stripes on a rectangular part of the image. Reloading the page a few times makes the problem go away. The testcase uses webgl.texImage2D with null pixel data, which causes the browser to calloc() a buffer and pass it to glTexImage2D. So it's not just an uninitialized texture. The application is doing what's right to properly initialize the texture with zero'd image data. If there is any risk that this might be exposing uninitialized texture memory, then please treat this as a high priority, as we'd have to find a work around. FWIW, on a different proprietary platform, this does expose video memory and forced us to artificially limit the max texture size to 4k. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 7

[Bug 40296] New: Bad rendering on madebyevan.com/webgl-water/
by bugzilla-daemon＠freedesktop.org 08 Aug '12

08 Aug '12

https://bugs.freedesktop.org/show_bug.cgi?id=40296 Summary: Bad rendering on madebyevan.com/webgl-water/ Product: Mesa Version: unspecified Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: jeff(a)infidigm.net 03:00.0 VGA compatible controller: ATI Technologies Inc Redwood [Radeon HD 5670] You can see the problem in the screenshot. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 3

[Bug 37047] New: [RADEON:KMS:R600G] broadbandmap.gov crashes firefox/iceweasel when webgl is enabled
by bugzilla-daemon＠freedesktop.org 08 Aug '12

08 Aug '12

https://bugs.freedesktop.org/show_bug.cgi?id=37047 Summary: [RADEON:KMS:R600G] broadbandmap.gov crashes firefox/iceweasel when webgl is enabled Product: Mesa Version: git Platform: All OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: bpaterni(a)gmail.com broadbandmap.gov does appear to be making use of webgl if it is exposed. Running iceweasel in debug mode produces the following: Mesa: User error: GL_INVALID_ENUM in glGetIntegerv(pname=GL_MAX_VERTEX_OUTPUT_COMPONENTS) Mesa: User error: GL_INVALID_ENUM in glGetIntegerv(pname=GL_MAX_VERTEX_OUTPUT_COMPONENTS) [New Thread 0x7fffbf7ff700 (LWP 25412)] [New Thread 0x7fffbeffe700 (LWP 25413)] Mesa: User error: GL_INVALID_ENUM in glGetIntegerv(pname=GL_MAX_VERTEX_OUTPUT_COMPONENTS) Program received signal SIGSEGV, Segmentation fault. 0x00007fffc17be5df in dri2FlushFrontBuffer (driDrawable=0x7fffc51bb420, loaderPrivate=0x7fffc2cb7cc0) at dri2_glx.c:460 460 struct glx_display *priv = __glXInitialize(pdraw->base.psc->dpy); (gdb) bt #0 0x00007fffc17be5df in dri2FlushFrontBuffer (driDrawable=0x7fffc51bb420, loaderPrivate=0x7fffc2cb7cc0) at dri2_glx.c:460 #1 0x00007fffc03bd400 in dri_st_framebuffer_flush_front (stfbi=<value optimized out>, statt=<value optimized out>) at dri_drawable.c:104 #2 0x00007fffc03bca34 in dri_unbind_context (cPriv=<value optimized out>) at dri_context.c:152 #3 0x00007fffc039f676 in driUnbindContext (pcp=0x7fffc4b31640) at ../../../../src/mesa/drivers/dri/common/dri_util.c:117 #4 0x00007fffc17be089 in dri2_unbind_context (context=0x7fffc4859a20, new=0x7fffd1d93840) at dri2_glx.c:172 #5 0x00007fffc1795c05 in MakeContextCurrent (dpy=0x7ffff6d76000, draw=25168521, read=25168521, gc_user=0x7fffd1d93840) at glxcurrent.c:258 #6 0x00007ffff56a9b17 in ?? () from /usr/lib/xulrunner-2.0/libxul.so #7 0x00007ffff56a8fd1 in ?? () from /usr/lib/xulrunner-2.0/libxul.so #8 0x00007ffff56a9159 in mozilla::gl::GLContextProviderGLX::CreateOffscreen(gfxIntSize const&, mozilla::gl::ContextFormat const&) () from /usr/lib/xulrunner-2.0/libxul.so #9 0x00007ffff4fe525e in ?? () from /usr/lib/xulrunner-2.0/libxul.so #10 0x00007ffff502b1af in ?? () from /usr/lib/xulrunner-2.0/libxul.so #11 0x00007ffff502b6ba in ?? () from /usr/lib/xulrunner-2.0/libxul.so #12 0x00007ffff5361e78 in ?? () from /usr/lib/xulrunner-2.0/libxul.so #13 0x00007ffff666e9eb in ?? () from /usr/lib/xulrunner-2.0/libmozjs.so #14 0x00007ffff6677fc5 in ?? () from /usr/lib/xulrunner-2.0/libmozjs.so #15 0x00007ffff6679b05 in ?? () from /usr/lib/xulrunner-2.0/libmozjs.so #16 0x00007ffff65f2584 in JS_EvaluateUCScriptForPrincipalsVersion () from /usr/lib/xulrunner-2.0/libmozjs.so #17 0x00007ffff50d954e in ?? () from /usr/lib/xulrunner-2.0/libxul.so #18 0x00007ffff4fbbc2b in ?? () from /usr/lib/xulrunner-2.0/libxul.so #19 0x00007ffff4fbc684 in ?? () from /usr/lib/xulrunner-2.0/libxul.so #20 0x00007ffff4fbd72b in ?? () from /usr/lib/xulrunner-2.0/libxul.so #21 0x00007ffff4fbda54 in ?? () from /usr/lib/xulrunner-2.0/libxul.so #22 0x00007ffff4d43733 in ?? () from /usr/lib/xulrunner-2.0/libxul.so #23 0x00007ffff5640a8b in NS_InvokeByIndex_P () from /usr/lib/xulrunner-2.0/libxul.so #24 0x00007ffff531e216 in ?? () from /usr/lib/xulrunner-2.0/libxul.so #25 0x00007ffff5323402 in ?? () from /usr/lib/xulrunner-2.0/libxul.so #26 0x00007ffff666e9eb in ?? () from /usr/lib/xulrunner-2.0/libmozjs.so #27 0x00007ffff6677fc5 in ?? () from /usr/lib/xulrunner-2.0/libmozjs.so #28 0x00007ffff6678462 in ?? () from /usr/lib/xulrunner-2.0/libmozjs.so #29 0x00007ffff6679313 in ?? () from /usr/lib/xulrunner-2.0/libmozjs.so #30 0x00007ffff65f2011 in JS_CallFunctionValue () from /usr/lib/xulrunner-2.0/libmozjs.so #31 0x00007ffff53190f5 in ?? () from /usr/lib/xulrunner-2.0/libxul.so #32 0x00007ffff5314aa1 in ?? () from /usr/lib/xulrunner-2.0/libxul.so #33 0x00007ffff5641625 in ?? () from /usr/lib/xulrunner-2.0/libxul.so #34 0x00007ffff5640b13 in ?? () from /usr/lib/xulrunner-2.0/libxul.so #35 0x00007fffc70a6720 in ?? () #36 0x00007fffc1c7c850 in ?? () #37 0x00007fffc6da9ce0 in ?? () #38 0x0000000000000000 in ?? () ----System Info---- Debian unstable/experimental running distro provided Linux 2.6.39-rc5-amd64 iceweasel version: 4.0.1-2 libdrm, xf86-video-ati @ git OpenGL renderer string: Gallium 0.4 on AMD RV770 OpenGL version string: 2.1 Mesa 7.11-devel (git-9d792d0) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 2

[Bug 33255] New: Crash using webgl (firefox 4b9)
by bugzilla-daemon＠freedesktop.org 08 Aug '12

08 Aug '12

https://bugs.freedesktop.org/show_bug.cgi?id=33255 Summary: Crash using webgl (firefox 4b9) Product: Mesa Version: 7.9 Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r300 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: 0enjolras0(a)laposte.net hy, I get this error : *********************************WARN_ONCE********************************* File r300_state.c function r300SetupRSUnit line 1521 Don't know how to satisfy InputsRead=0x00004000 *************************************************************************** trying MOZ_GLX_IGNORE_BLACKLIST=1 firefox -P -no-remote on gentoo. setting layers.accelerate-all true in about:config * firefox : Mozilla Firefox 4.0b9 Mozilla i386 build for linux. * OpenGL vendor string: X.Org R300 Project OpenGL renderer string: Gallium 0.4 on RS690 * kernel 2.6.36 vanilla. regards. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 7

[Bug 49321] New: Khronos WebGL conformance test and shadertoy failure
by bugzilla-daemon＠freedesktop.org 08 Aug '12

08 Aug '12

https://bugs.freedesktop.org/show_bug.cgi?id=49321 Bug #: 49321 Summary: Khronos WebGL conformance test and shadertoy failure Classification: Unclassified Product: Mesa Version: unspecified Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: erno(a)iki.fi Full report @ http://groups.google.com/group/webgl-driver-testing/browse_thread/thread/14… Partial paste from above: This run was on Ubuntu 10.10 amd64 with self compiled Mesa 3.0.2 (+deps, like libdrm 2.4.33 and llvm 3.0), Firefox nightly 15.0~a1~hg20120428r92608-0ubuntu1~umd1~lucid from http://ppa.launchpad.net/ubuntu-mozilla-daily/ppa/ubuntu and Linux 3.1.0. Also I notice about half of the shaders at http://www.iquilezles.org/apps/shadertoy/ fail (eg. Motion Blur shows just two brown rectangles, Flower a flashing green box) WebGL Conformance Test Runner Version 1.0.1 Results: (8827 of 8863 passed) WebGL Conformance Test Results Version 1.0.1 ------------------- User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:15.0) Gecko/20120425 Firefox/15.0a1 WebGL VENDOR: Mozilla WebGL VERSION: WebGL 1.0 WebGL RENDERER: Mozilla Unmasked VENDOR: undefined Unmasked RENDERER: undefined WebGL R/G/B/A/Depth/Stencil bits (default config): 8/8/8/8/24/0 ------------------- Test Summary (8863 total tests): Tests PASSED: 8827 Tests FAILED: 36 Tests TIMED OUT: 0 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 4

[Bug 33635] New: RV620 : Webgl : conformance-tests : 5248/5325 , firefox 4b10
by bugzilla-daemon＠freedesktop.org 08 Aug '12

08 Aug '12

https://bugs.freedesktop.org/show_bug.cgi?id=33635 Summary: RV620 : Webgl : conformance-tests : 5248/5325 , firefox 4b10 Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: aderumier(a)odiso.com Hi, not sure is the good place to post result of WebGL Conformance Test Runner, but it's my results with RV620 chipset, r600g with all git from today. Results: (5248 of 5325 passed, 3 timed out) conformance/context-lost-restored.html(*timeout*) conformance/gl-get-active-attribute.html (15 of 16 passed) failed: successfullyParsed should be true. Threw exception ReferenceError: successfullyParsed is not defined conformance/gl-get-calls.html (72 of 75 passed) failed: context.getParameter(context.MAX_FRAGMENT_UNIFORM_VECTORS) >= 16 should be true. Was false. failed: context.getParameter(context.MAX_VARYING_VECTORS) >= 8 should be true. Was false. failed: context.getParameter(context.MAX_VERTEX_UNIFORM_VECTORS) >= 128 should be true. Was false. conformance/gl-getshadersource.html (1 of 3 passed) failed: source should be abc//defＮＯＴＡＳＣＩＩ. Was . failed: getError expected: NO_ERROR. Was INVALID_VALUE : Should be no errors. conformance/gl-min-attribs.html (2 of 3 passed) failed: Should render 255,127,64,32 conformance/gl-min-uniforms.html (4 of 6 passed) failed: Should render 255,127,64,32 failed: Should render 32,64,127,255 conformance/gl-uniform-arrays.html (68 of 76 passed) failed: value put in (15) matches value pulled out (16) failed: value put in (14) matches value pulled out (16) failed: value put in ([14, 13]) matches value pulled out ([16, 15]) failed: value put in ([12, 11]) matches value pulled out ([16, 15]) failed: value put in ([13, 12, 11]) matches value pulled out ([16, 15, 14]) failed: value put in ([10, 9, 8]) matches value pulled out ([16, 15, 14]) failed: value put in ([12, 11, 10, 9]) matches value pulled out ([16, 15, 14, 13]) failed: value put in ([8, 7, 6, 5]) matches value pulled out ([16, 15, 14, 13]) conformance/glsl-conformance.html (102 of 104 passed) failed: [vshader/fshaderWith256CharacterIdentifier]: shared that uses 256 character identifier should succeed failed: [shaders/misc/non-ascii-comments.vert/fshader]: Non ascii comments in source should succeed conformance/invalid-passed-params.html (50 of 74 passed) failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. failed: context.getError() should be 1281. Was 0. conformance/oes-standard-derivatives.html (7 of 8 passed) failed: successfullyParsed should be true. Threw exception ReferenceError: successfullyParsed is not defined conformance/point-size.html (1 of 2 passed) failed: Drawing a point of size 1 touched pixels that should not be touched conformance/read-pixels-test.html (121 of 125 passed) failed: getError expected: INVALID_OPERATION. Was INVALID_ENUM : Should not be able to read as RGB / UNSIGNED_BYTE failed: getError expected: INVALID_OPERATION. Was INVALID_ENUM : Should not be able to read as RGBA / UNSIGNED_SHORT_5_5_5_1 failed: getError expected: INVALID_OPERATION. Was INVALID_ENUM : Should not be able to read as RGBA / UNSIGNED_SHORT_4_4_4_4 failed: getError expected: INVALID_OPERATION. Was INVALID_ENUM : Should not be able to read as ALPHA / UNSIGNED_BYTE conformance/tex-image-and-sub-image-2d-with-video.html(*timeout*) conformance/texture-npot.html (25 of 26 passed) failed: POT cubemap with TEXTURE_MIN_FILTER set to LINEAR_MIPMAP_LINEAR should draw conformance/uniform-location.html (24 of 25 passed) failed: contextA.getUniform(programS, locationArray1) should be 5. Was 4. conformance/uninitialized-test.html (16 of 19 passed) failed: non-zero pixel values are wrong failed: non-zero pixel values are wrong failed: non-zero pixel values are wrong conformance/webgl-specific.html (31 of 40 passed) failed: gl.stencilMaskSeparate(gl.FRONT, 1) expected: NO_ERROR. Was INVALID_OPERATION. failed: gl.drawArrays(gl.TRIANGLES, 0, 0) expected: INVALID_OPERATION. Was NO_ERROR. failed: gl.stencilMaskSeparate(gl.BACK, 1) expected: NO_ERROR. Was INVALID_OPERATION. failed: gl.stencilFuncSeparate(gl.BACK, gl.ALWAYS, 1, 255) expected: NO_ERROR. Was INVALID_OPERATION. failed: gl.drawArrays(gl.TRIANGLES, 0, 0) expected: INVALID_OPERATION. Was NO_ERROR. failed: gl.stencilFuncSeparate(gl.FRONT, gl.ALWAYS, 1, 255) expected: NO_ERROR. Was INVALID_OPERATION. failed: gl.stencilFuncSeparate(gl.BACK, gl.ALWAYS, 1, 1) expected: NO_ERROR. Was INVALID_OPERATION. failed: gl.drawArrays(gl.TRIANGLES, 0, 0) expected: INVALID_OPERATION. Was NO_ERROR. failed: gl.stencilFuncSeparate(gl.FRONT, gl.ALWAYS, 1, 1) expected: NO_ERROR. Was INVALID_OPERATION. more/conformance/quickCheckAPI.html (0 of 1 passed) failed: testValidArgs more/conformance/webGLArrays.html(*timeout*) more/functions/copyTexImage2D.html (1 of 2 passed) failed: testRoundtrip more/functions/copyTexSubImage2D.html (1 of 2 passed) failed: testRoundtrip more/functions/copyTexSubImage2DBadArgs.html (0 of 1 passed) failed: testTexImage2D more/functions/deleteBufferBadArgs.html (0 of 1 passed) failed: testDeleteBuffer more/functions/texImage2DBadArgs.html (0 of 1 passed) failed: testTexImage2D more/functions/texSubImage2DBadArgs.html (0 of 1 passed) failed: testTexImage2D more/functions/texSubImage2DHTMLBadArgs.html (0 of 1 passed) failed: testTexImage2D more/functions/uniformiBadArgs.html (0 of 1 passed) failed: testUniformf more/functions/uniformMatrixBadArgs.html (0 of 1 passed) failed: testUniformf more/functions/vertexAttribBadArgs.html (0 of 1 passed) failed: testVertexAttrib -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 1

[Bug 48935] New: [r600g] WebGL conformance test textures/texture-mips.html fails
by bugzilla-daemon＠freedesktop.org 08 Aug '12

08 Aug '12

https://bugs.freedesktop.org/show_bug.cgi?id=48935 Bug #: 48935 Summary: [r600g] WebGL conformance test textures/texture-mips.html fails Classification: Unclassified Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: jlp.bugs(a)gmail.com I'm using Mesa 8.1-devel (git-e1a173f) with Linux 3.4.0-rc2 and Mobility Radeon HD 5470 and Firefox nightly 20120419030644 If I run the WebGL conformance tests from here: https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/conformance-s… one of the failing tests is conformance/textures/texture-mips.html Error says: failed: texture that is only using the smallest 2 mips should draw with green failed: texture that is only using smallest mips should draw with cyan -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 2

[Bug 48933] New: [r600g] WebGL conformance test context/context-attributes-alpha-depth-stencil-antialias.html fails
by bugzilla-daemon＠freedesktop.org 08 Aug '12

08 Aug '12

https://bugs.freedesktop.org/show_bug.cgi?id=48933 Bug #: 48933 Summary: [r600g] WebGL conformance test context/context-attributes-alpha-depth-stencil-antiali as.html fails Classification: Unclassified Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: jlp.bugs(a)gmail.com I'm using Mesa 8.1-devel (git-e1a173f) with Linux 3.4.0-rc2 and Mobility Radeon HD 5470 and Firefox nightly 20120419030644 If I run the WebGL conformance tests from here: https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/conformance-s… one of the failing tests is conformance/context/context-attributes-alpha-depth-stencil-antialias.html Error says: failed: pixel[0] != 255 && pixel[0] != 0 should be true. Was false. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 1

[Bug 48934] New: [r600g] WebGL conformance test programs/program-test.html fails
by bugzilla-daemon＠freedesktop.org 08 Aug '12

08 Aug '12

https://bugs.freedesktop.org/show_bug.cgi?id=48934 Bug #: 48934 Summary: [r600g] WebGL conformance test programs/program-test.html fails Classification: Unclassified Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: jlp.bugs(a)gmail.com I'm using Mesa 8.1-devel (git-e1a173f) with Linux 3.4.0-rc2 and Mobility Radeon HD 5470 and Firefox nightly 20120419030644 If I run the WebGL conformance tests from here: https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/conformance-s… one of the failing tests is conformance/programs/program-test.html Error says: failed: getError expected: NO_ERROR. Was INVALID_OPERATION : drawing with a valid program shouldn't generate a GL error -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 1

[PATCH] drm/radeon: delay virtual address destruction to bo destruction
by j.glisse＠gmail.com 08 Aug '12

08 Aug '12

From: Jerome Glisse <jglisse(a)redhat.com> Use the ttm bo delayed destruction queue so that we don't block userspace when destroying bo. The virtual address destruction will happen at same time as the real bo destruction when everythings using the bo is done. Signed-off-by: Jerome Glisse <jglisse(a)redhat.com> --- drivers/gpu/drm/radeon/radeon_drv.c | 2 +- drivers/gpu/drm/radeon/radeon_gem.c | 20 -------------------- 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index dcea6f0..38443e7 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c @@ -368,7 +368,7 @@ static struct drm_driver kms_driver = { .gem_init_object = radeon_gem_object_init, .gem_free_object = radeon_gem_object_free, .gem_open_object = radeon_gem_object_open, - .gem_close_object = radeon_gem_object_close, + .gem_close_object = NULL, .dma_ioctl = radeon_dma_ioctl_kms, .dumb_create = radeon_mode_dumb_create, .dumb_map_offset = radeon_mode_dumb_mmap, diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/drivers/gpu/drm/radeon/radeon_gem.c index 1b57b00..b5835c8 100644 --- a/drivers/gpu/drm/radeon/radeon_gem.c +++ b/drivers/gpu/drm/radeon/radeon_gem.c @@ -127,26 +127,6 @@ int radeon_gem_object_open(struct drm_gem_object *obj, struct drm_file *file_pri return 0; } -void radeon_gem_object_close(struct drm_gem_object *obj, - struct drm_file *file_priv) -{ - struct radeon_bo *rbo = gem_to_radeon_bo(obj); - struct radeon_device *rdev = rbo->rdev; - struct radeon_fpriv *fpriv = file_priv->driver_priv; - struct radeon_vm *vm = &fpriv->vm; - - if (rdev->family < CHIP_CAYMAN) { - return; - } - - if (radeon_bo_reserve(rbo, false)) { - dev_err(rdev->dev, "leaking bo va because we fail to reserve bo\n"); - return; - } - radeon_vm_bo_rmv(rdev, vm, rbo); - radeon_bo_unreserve(rbo); -} - static int radeon_gem_handle_lockup(struct radeon_device *rdev, int r) { if (r == -EDEADLK) { -- 1.7.10.4

3 3

← Newer
1
...
71
72
73
74
75
76
77
...
82
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel August 2012