dri-devel January 2013

dri-devel@lists.freedesktop.org

147 participants
795 discussions

[Bug 26891] Radeon KMS fails with inaccessible AtomBIOS on systems with (U)EFI boot
by bugzilla-daemon＠freedesktop.org 03 Jan '13

03 Jan '13

https://bugs.freedesktop.org/show_bug.cgi?id=26891 --- Comment #51 from Anonymous Helper <anonymous(a)dodgeit.com> --- (In reply to comment #50) > You'll need to use vga-switcheroo to select the card you want to use. Then > you should be able to start X without any config and it will start on the > one selected by vga-switcheroo. Having two device sections as your config > does will force X to try and start on both devices. I tried without the BusID but all I got was a black screen. For some reason when I switch to the intel GPU I get a black screen also, though it did work when I booted from grub-efi earlier with the well documented outb commands to disable AMD (no BIOS from EFI w/o efistub). Not sure if it's an issue with vga-switcheroo, intel driver or something else. I don't know if it's a problem, but both cards are powered on at boot. I can switch back and forth between the GPUs (though it's tricky doing so blind when on intel graphics). Any other suggestions? Thanks. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH 0/4] drm/exynos: add support for extra resolutions to exynos5
by Rahul Sharma 03 Jan '13

03 Jan '13

This patch set adds support for more resolutions and refresh rates to Samsung Exynos5 SoC series which contains hdmi transmitter (hdmi v1.4a compliant). Given resolution will be supported or not, is decided by two factors: 1) Corresponding pixel clock is supported by hdmi PHY. 2) Mixer supports the display mode. This patch series is based on branch "exynos-drm-next" at http://git.kernel.org/?p=linux/kernel/git/daeinki/drm-exynos.git Rahul Sharma (3): drm/exynos: add display-mode-check operation to exynos_mixer_ops struct drm/exynos: implement display-mode-check callback in mixer driver drm/exynos: mixer: set correct mode for range of resolutions Sean Paul (1): drm/exynos: hdmi: support extra resolutions using drm_display_mode timings drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 12 + drivers/gpu/drm/exynos/exynos_drm_hdmi.h | 3 + drivers/gpu/drm/exynos/exynos_hdmi.c | 1022 +++++++++++------------------- drivers/gpu/drm/exynos/exynos_mixer.c | 38 +- 4 files changed, 423 insertions(+), 652 deletions(-) -- 1.8.0

3 11

[Bug 26891] Radeon KMS fails with inaccessible AtomBIOS on systems with (U)EFI boot
by bugzilla-daemon＠freedesktop.org 03 Jan '13

03 Jan '13

https://bugs.freedesktop.org/show_bug.cgi?id=26891 --- Comment #50 from Alex Deucher <agd5f(a)yahoo.com> --- (In reply to comment #49) > > Is the BusID line in the intel device section not needed? What is needed for > X to automatically detect multiple GPUs properly and show some video output > from the correct card? You'll need to use vga-switcheroo to select the card you want to use. Then you should be able to start X without any config and it will start on the one selected by vga-switcheroo. Having two device sections as your config does will force X to try and start on both devices. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 52231] New: possible circular locking dependency detected in radeon driver
by bugzilla-daemon＠bugzilla.kernel.org 03 Jan '13

03 Jan '13

https://bugzilla.kernel.org/show_bug.cgi?id=52231 Summary: possible circular locking dependency detected in radeon driver Product: Drivers Version: 2.5 Kernel Version: 3.8-rc2 Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) AssignedTo: drivers_video-dri(a)kernel-bugs.osdl.org ReportedBy: casteyde.christian(a)free.fr Regression: Yes Kernel 3.8-rc2 Slackware64 14 Core i7, 6 GB RAM, 64 bit mode Since kernel 3.8-rc2 with kmemcheck and lockdep hacking options turned on, I get the following lockdep warning: EXT4-fs (sda3): re-mounted. Opts: discard,commit=0 ====================================================== [ INFO: possible circular locking dependency detected ] 3.8.0-rc2 #21 Not tainted ------------------------------------------------------- 99video/2835 is trying to acquire lock: ((fb_notifier_list).rwsem){.+.+.+}, at: [<ffffffff8109f2f4>] __blocking_notifier_call_chain+0x54/0xd0 but task is already holding lock: (console_lock){+.+.+.}, at: [<ffffffff81344a65>] store_fbstate+0x55/0x80 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (console_lock){+.+.+.}: [<ffffffff810c9eaa>] lock_acquire+0x5a/0x70 [<ffffffff810756e7>] console_lock+0x57/0x60 [<ffffffff813a1874>] register_con_driver+0x34/0x140 [<ffffffff813a2fe9>] take_over_console+0x29/0x60 [<ffffffff8134a90b>] fbcon_takeover+0x5b/0xb0 [<ffffffff8134f7ad>] fbcon_event_notify+0x72d/0x830 [<ffffffff8109f00e>] notifier_call_chain+0x5e/0x150 [<ffffffff8109f30d>] __blocking_notifier_call_chain+0x6d/0xd0 [<ffffffff8109f381>] blocking_notifier_call_chain+0x11/0x20 [<ffffffff81340df6>] fb_notifier_call_chain+0x16/0x20 [<ffffffff8134301d>] register_framebuffer+0x1bd/0x2f0 [<ffffffff813adf43>] drm_fb_helper_single_fb_probe+0x1d3/0x2f0 [<ffffffff813ae231>] drm_fb_helper_initial_config+0x1d1/0x240 [<ffffffff81417b1a>] radeon_fbdev_init+0xba/0x110 [<ffffffff81412a01>] radeon_modeset_init+0x501/0xb60 [<ffffffff813f00d0>] radeon_driver_load_kms+0xe0/0x150 [<ffffffff813bb5ce>] drm_get_pci_dev+0x17e/0x2b0 [<ffffffff813d643a>] radeon_pci_probe+0xaa/0xe0 [<ffffffff8132f196>] local_pci_probe+0x46/0x80 [<ffffffff8132f7c1>] pci_device_probe+0x101/0x110 [<ffffffff8146cb86>] driver_probe_device+0x76/0x220 [<ffffffff8146cdd3>] __driver_attach+0xa3/0xb0 [<ffffffff8146ae4d>] bus_for_each_dev+0x4d/0x90 [<ffffffff8146c6d9>] driver_attach+0x19/0x20 [<ffffffff8146c2a0>] bus_add_driver+0x1a0/0x270 [<ffffffff8146d442>] driver_register+0x72/0x170 [<ffffffff8132f89f>] __pci_register_driver+0x5f/0x70 [<ffffffff813bb815>] drm_pci_init+0x115/0x130 [<ffffffff820a7460>] radeon_init+0xe7/0xe9 [<ffffffff810002da>] do_one_initcall+0x11a/0x170 [<ffffffff81811aec>] kernel_init+0x11c/0x290 [<ffffffff8182ffec>] ret_from_fork+0x7c/0xb0 -> #0 ((fb_notifier_list).rwsem){.+.+.+}: [<ffffffff810c96f0>] __lock_acquire+0x1a20/0x1ca0 [<ffffffff810c9eaa>] lock_acquire+0x5a/0x70 [<ffffffff8182ca39>] down_read+0x39/0x8c [<ffffffff8109f2f4>] __blocking_notifier_call_chain+0x54/0xd0 [<ffffffff8109f381>] blocking_notifier_call_chain+0x11/0x20 [<ffffffff81340df6>] fb_notifier_call_chain+0x16/0x20 [<ffffffff81341516>] fb_set_suspend+0x46/0x60 [<ffffffff81344a70>] store_fbstate+0x60/0x80 [<ffffffff81468493>] dev_attr_store+0x13/0x20 [<ffffffff811b813b>] sysfs_write_file+0xdb/0x150 [<ffffffff81148b86>] vfs_write+0xa6/0x160 [<ffffffff81148e90>] sys_write+0x50/0xa0 [<ffffffff81830092>] system_call_fastpath+0x16/0x1b other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(console_lock); lock((fb_notifier_list).rwsem); lock(console_lock); lock((fb_notifier_list).rwsem); *** DEADLOCK *** 4 locks held by 99video/2835: #0: (&buffer->mutex){+.+.+.}, at: [<ffffffff811b80a3>] sysfs_write_file+0x43/0x150 #1: (s_active#124){.+.+.+}, at: [<ffffffff811b8123>] sysfs_write_file+0xc3/0x150 #2: (&fb_info->lock){+.+.+.}, at: [<ffffffff813412c1>] lock_fb_info+0x21/0x60 #3: (console_lock){+.+.+.}, at: [<ffffffff81344a65>] store_fbstate+0x55/0x80 stack backtrace: Pid: 2835, comm: 99video Not tainted 3.8.0-rc2 #21 Call Trace: [<ffffffff81823b11>] print_circular_bug+0x28e/0x29f [<ffffffff810c96f0>] __lock_acquire+0x1a20/0x1ca0 [<ffffffff810c9eaa>] lock_acquire+0x5a/0x70 [<ffffffff8109f2f4>] ? __blocking_notifier_call_chain+0x54/0xd0 [<ffffffff810c4e0f>] ? __lock_is_held+0x5f/0x90 [<ffffffff8182ca39>] down_read+0x39/0x8c [<ffffffff8109f2f4>] ? __blocking_notifier_call_chain+0x54/0xd0 [<ffffffff8109f2f4>] __blocking_notifier_call_chain+0x54/0xd0 [<ffffffff8109f2f4>] __blocking_notifier_call_chain+0x54/0xd0 [<ffffffff8109f381>] blocking_notifier_call_chain+0x11/0x20 [<ffffffff81340df6>] fb_notifier_call_chain+0x16/0x20 [<ffffffff81341516>] fb_set_suspend+0x46/0x60 [<ffffffff810756e7>] ? console_lock+0x57/0x60 [<ffffffff81344a65>] ? store_fbstate+0x55/0x80 [<ffffffff81344a70>] store_fbstate+0x60/0x80 [<ffffffff81468493>] dev_attr_store+0x13/0x20 [<ffffffff811b813b>] sysfs_write_file+0xdb/0x150 [<ffffffff81148b86>] vfs_write+0xa6/0x160 [<ffffffff81148e90>] sys_write+0x50/0xa0 [<ffffffff81830092>] system_call_fastpath+0x16/0x1b PM: Syncing filesystems ... done. WARNING: kmemcheck: Caught 16-bit read from uninitialized memory (ffff8801c52bbc20) 010000000000000001000000000000000000000000000000b0bb2bc50188ffff u u u u u u u u u u u u u u u u u u u u u u u u u u u u u u u u ^ Pid: 2256, comm: X Not tainted 3.8.0-rc2 #21 Acer Aspire 7750G/JE70_HR RIP: 0010:[<ffffffff813ac091>] [<ffffffff813ac091>] drm_fb_helper_setcmap+0x111/0x400 RSP: 0018:ffff8801c0c35978 EFLAGS: 00010206 RAX: ffff8801c52bbc00 RBX: ffff8801c476e800 RCX: 0000000000000000 RDX: 000000000000000f RSI: ffff8801c52bb850 RDI: 00000000000000ff RBP: ffff8801c0c35a48 R08: 00000000001d5300 R09: 0000000000ffffff R10: 0000000000000000 R11: 000000000000ffff R12: 0000000000000000 R13: 0000000000000010 R14: 0000000000000010 R15: ffff8801c52bb800 FS: 00007f34900ed8c0(0000) GS:ffff8801c7e00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffff8801c644bf10 CR3: 00000001c30d3000 CR4: 00000000000407f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff4ff0 DR7: 0000000000000400 [<ffffffff81344375>] fb_set_cmap+0x65/0x140 [<ffffffff81341dff>] fb_set_var+0x1cf/0x480 [<ffffffff8134be21>] fbcon_blank+0x1e1/0x2e0 [<ffffffff813a3f79>] do_unblank_screen+0xa9/0x1d0 [<ffffffff81399744>] complete_change_console+0x64/0xf0 [<ffffffff8139aa32>] vt_ioctl+0x1262/0x1350 [<ffffffff8138fd98>] tty_ioctl+0x2c8/0xd10 [<ffffffff8115aae7>] do_vfs_ioctl+0x97/0x5a0 [<ffffffff8115b03b>] sys_ioctl+0x4b/0x90 [<ffffffff81830092>] system_call_fastpath+0x16/0x1b [<ffffffffffffffff>] 0xffffffffffffffff WARNING: kmemcheck: Caught 16-bit read from uninitialized memory (ffff8801c52bbe20) ea00000077000000260000000b00000002000000040000000100000001000000 u u u u u u u u u u u u u u u u u u u u u u u u u u u u u u u u ^ Pid: 2256, comm: X Not tainted 3.8.0-rc2 #21 Acer Aspire 7750G/JE70_HR RIP: 0010:[<ffffffff813ac0af>] [<ffffffff813ac0af>] drm_fb_helper_setcmap+0x12f/0x400 RSP: 0018:ffff8801c0c35978 EFLAGS: 00010246 RAX: ffff8801c52bbe00 RBX: ffff8801c476e800 RCX: 0000000000000000 RDX: 0000000000000010 RSI: ffff8801c52bb850 RDI: 00000000000000ff RBP: ffff8801c0c35a48 R08: 00000000001d5300 R09: 0000000000ffffff R10: 0000000000000000 R11: 0000000000000001 R12: 0000000000000010 R13: 0000000000000010 R14: 0000000000000010 R15: ffff8801c52bb800 FS: 00007f34900ed8c0(0000) GS:ffff8801c7e00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffff8801c644bf10 CR3: 00000001c30d3000 CR4: 00000000000407f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff4ff0 DR7: 0000000000000400 [<ffffffff81344375>] fb_set_cmap+0x65/0x140 [<ffffffff81341dff>] fb_set_var+0x1cf/0x480 [<ffffffff8134be21>] fbcon_blank+0x1e1/0x2e0 [<ffffffff813a3f79>] do_unblank_screen+0xa9/0x1d0 [<ffffffff81399744>] complete_change_console+0x64/0xf0 [<ffffffff8139aa32>] vt_ioctl+0x1262/0x1350 [<ffffffff8138fd98>] tty_ioctl+0x2c8/0xd10 [<ffffffff8115aae7>] do_vfs_ioctl+0x97/0x5a0 [<ffffffff8115b03b>] sys_ioctl+0x4b/0x90 [<ffffffff81830092>] system_call_fastpath+0x16/0x1b [<ffffffffffffffff>] 0xffffffffffffffff WARNING: kmemcheck: Caught 16-bit read from uninitialized memory (ffff8801c4778020) 000000000000000010fa0881ffffffff00000000000000000000000000000000 u u u u u u u u u u u u u u u u u u u u u u u u u u u u u u u u ^ Pid: 2256, comm: X Not tainted 3.8.0-rc2 #21 Acer Aspire 7750G/JE70_HR RIP: 0010:[<ffffffff813ac0b8>] [<ffffffff813ac0b8>] drm_fb_helper_setcmap+0x138/0x400 RSP: 0018:ffff8801c0c35978 EFLAGS: 00010246 RAX: ffff8801c4778000 RBX: ffff8801c476e800 RCX: 0000000000000000 RDX: 0000000000000010 RSI: ffff8801c52bb850 RDI: 00000000000000ff RBP: ffff8801c0c35a48 R08: 00000000001d5300 R09: 00000000000000ea R10: 0000000000000000 R11: 0000000000000001 R12: 0000000000000010 R13: 0000000000000010 R14: 0000000000000010 R15: ffff8801c52bb800 FS: 00007f34900ed8c0(0000) GS:ffff8801c7e00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffff8801c644bf10 CR3: 00000001c30d3000 CR4: 00000000000407f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff4ff0 DR7: 0000000000000400 [<ffffffff81344375>] fb_set_cmap+0x65/0x140 [<ffffffff81341dff>] fb_set_var+0x1cf/0x480 [<ffffffff8134be21>] fbcon_blank+0x1e1/0x2e0 [<ffffffff813a3f79>] do_unblank_screen+0xa9/0x1d0 [<ffffffff81399744>] complete_change_console+0x64/0xf0 [<ffffffff8139aa32>] vt_ioctl+0x1262/0x1350 [<ffffffff8138fd98>] tty_ioctl+0x2c8/0xd10 [<ffffffff8115aae7>] do_vfs_ioctl+0x97/0x5a0 [<ffffffff8115b03b>] sys_ioctl+0x4b/0x90 [<ffffffff81830092>] system_call_fastpath+0x16/0x1b etc. (uninitialized read is already reported in another bugzilla entry). -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 1

[Bug 36522] Caught 16-bit read from uninitialized memory in drm_fb_helper_setcmap
by bugzilla-daemon＠bugzilla.kernel.org 03 Jan '13

03 Jan '13

https://bugzilla.kernel.org/show_bug.cgi?id=36522 --- Comment #11 from Christian Casteyde <casteyde.christian(a)free.fr> 2013-01-03 12:55:07 --- Udpate: Still present in 3.8-rc2 -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 0

[PATCH] drm/exynos: Add device tree based discovery support for Exynos G2D
by Ajay Kumar 03 Jan '13

03 Jan '13

This patch adds device tree match table for Exynos G2D controller. Signed-off-by: Ajay Kumar <ajaykumar.rs(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index 6ffa076..aa3d2e4 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c @@ -19,6 +19,7 @@ #include <linux/workqueue.h> #include <linux/dma-mapping.h> #include <linux/dma-attrs.h> +#include <linux/of.h> #include <drm/drmP.h> #include <drm/exynos_drm.h> @@ -1240,6 +1241,14 @@ static int g2d_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume); +#ifdef CONFIG_OF +static const struct of_device_id exynos_g2d_match[] = { + { .compatible = "samsung,exynos-g2d-41" }, + {}, +}; +MODULE_DEVICE_TABLE(of, exynos_g2d_match); +#endif + struct platform_driver g2d_driver = { .probe = g2d_probe, .remove = __devexit_p(g2d_remove), @@ -1247,5 +1256,6 @@ struct platform_driver g2d_driver = { .name = "s5p-g2d", .owner = THIS_MODULE, .pm = &g2d_pm_ops, + .of_match_table = of_match_ptr(exynos_g2d_match), }, }; -- 1.8.0

3 2

[PATCH] drm/exynos: move finish page flip to a common place
by Rahul Sharma 03 Jan '13

03 Jan '13

This patch implements the exynos_drm_crtc_finish_pageflip in exynos_drm_crtc.c. This avoids the duplication of same code in mixer, fimd and vidi. Signed-off-by: Rahul Sharma <rahul.sharma(a)samsung.com> --- This patch is based on branch "exynos-drm-next" at http://git.kernel.org/?p=linux/kernel/git/daeinki/drm-exynos.git drivers/gpu/drm/exynos/exynos_drm_crtc.c | 32 +++++++++++++++++++++++++++++++ drivers/gpu/drm/exynos/exynos_drm_crtc.h | 1 + drivers/gpu/drm/exynos/exynos_drm_fimd.c | 30 +---------------------------- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 30 +---------------------------- drivers/gpu/drm/exynos/exynos_mixer.c | 33 +++----------------------------- 5 files changed, 38 insertions(+), 88 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c index d59a03a..e29f262 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c @@ -393,3 +393,35 @@ void exynos_drm_crtc_disable_vblank(struct drm_device *dev, int crtc) exynos_drm_fn_encoder(private->crtc[crtc], &crtc, exynos_drm_disable_vblank); } + +void exynos_drm_crtc_finish_pageflip(struct drm_device *dev, int crtc) +{ + struct exynos_drm_private *dev_priv = dev->dev_private; + struct drm_pending_vblank_event *e, *t; + struct timeval now; + unsigned long flags; + + DRM_DEBUG_KMS("%s\n", __FILE__); + + spin_lock_irqsave(&dev->event_lock, flags); + + list_for_each_entry_safe(e, t, &dev_priv->pageflip_event_list, + base.link) { + /* if event's pipe isn't same as crtc then ignore it. */ + if (crtc != e->pipe) + continue; + + do_gettimeofday(&now); + e->event.sequence = 0; + e->event.tv_sec = now.tv_sec; + e->event.tv_usec = now.tv_usec; + + list_move_tail(&e->base.link, &e->base.file_priv->event_list); + wake_up_interruptible(&e->base.file_priv->event_wait); + drm_vblank_put(dev, crtc); + } + + spin_unlock_irqrestore(&dev->event_lock, flags); +} + + diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.h b/drivers/gpu/drm/exynos/exynos_drm_crtc.h index 8ac3969..3e197e6 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.h +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.h @@ -18,5 +18,6 @@ int exynos_drm_crtc_create(struct drm_device *dev, unsigned int nr); int exynos_drm_crtc_enable_vblank(struct drm_device *dev, int crtc); void exynos_drm_crtc_disable_vblank(struct drm_device *dev, int crtc); +void exynos_drm_crtc_finish_pageflip(struct drm_device *dev, int crtc); #endif diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index bf0d9ba..6dda825 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -663,34 +663,6 @@ static struct exynos_drm_manager fimd_manager = { .display_ops = &fimd_display_ops, }; -static void fimd_finish_pageflip(struct drm_device *drm_dev, int crtc) -{ - struct exynos_drm_private *dev_priv = drm_dev->dev_private; - struct drm_pending_vblank_event *e, *t; - struct timeval now; - unsigned long flags; - - spin_lock_irqsave(&drm_dev->event_lock, flags); - - list_for_each_entry_safe(e, t, &dev_priv->pageflip_event_list, - base.link) { - /* if event's pipe isn't same as crtc then ignore it. */ - if (crtc != e->pipe) - continue; - - do_gettimeofday(&now); - e->event.sequence = 0; - e->event.tv_sec = now.tv_sec; - e->event.tv_usec = now.tv_usec; - - list_move_tail(&e->base.link, &e->base.file_priv->event_list); - wake_up_interruptible(&e->base.file_priv->event_wait); - drm_vblank_put(drm_dev, crtc); - } - - spin_unlock_irqrestore(&drm_dev->event_lock, flags); -} - static irqreturn_t fimd_irq_handler(int irq, void *dev_id) { struct fimd_context *ctx = (struct fimd_context *)dev_id; @@ -710,7 +682,7 @@ static irqreturn_t fimd_irq_handler(int irq, void *dev_id) goto out; drm_handle_vblank(drm_dev, manager->pipe); - fimd_finish_pageflip(drm_dev, manager->pipe); + exynos_drm_crtc_finish_pageflip(drm_dev, manager->pipe); /* set wait vsync event to zero and wake up queue. */ if (atomic_read(&ctx->wait_vsync_event)) { diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c index 3260035..b192308 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -379,34 +379,6 @@ static struct exynos_drm_manager vidi_manager = { .display_ops = &vidi_display_ops, }; -static void vidi_finish_pageflip(struct drm_device *drm_dev, int crtc) -{ - struct exynos_drm_private *dev_priv = drm_dev->dev_private; - struct drm_pending_vblank_event *e, *t; - struct timeval now; - unsigned long flags; - - spin_lock_irqsave(&drm_dev->event_lock, flags); - - list_for_each_entry_safe(e, t, &dev_priv->pageflip_event_list, - base.link) { - /* if event's pipe isn't same as crtc then ignore it. */ - if (crtc != e->pipe) - continue; - - do_gettimeofday(&now); - e->event.sequence = 0; - e->event.tv_sec = now.tv_sec; - e->event.tv_usec = now.tv_usec; - - list_move_tail(&e->base.link, &e->base.file_priv->event_list); - wake_up_interruptible(&e->base.file_priv->event_wait); - drm_vblank_put(drm_dev, crtc); - } - - spin_unlock_irqrestore(&drm_dev->event_lock, flags); -} - static void vidi_fake_vblank_handler(struct work_struct *work) { struct vidi_context *ctx = container_of(work, struct vidi_context, @@ -431,7 +403,7 @@ static void vidi_fake_vblank_handler(struct work_struct *work) mutex_unlock(&ctx->lock); - vidi_finish_pageflip(subdrv->drm_dev, manager->pipe); + exynos_drm_crtc_finish_pageflip(subdrv->drm_dev, manager->pipe); } static int vidi_subdrv_probe(struct drm_device *drm_dev, struct device *dev) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index 21db895..e9dbf79 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers/gpu/drm/exynos/exynos_mixer.c @@ -35,6 +35,7 @@ #include <drm/exynos_drm.h> #include "exynos_drm_drv.h" +#include "exynos_drm_crtc.h" #include "exynos_drm_hdmi.h" #include "exynos_drm_iommu.h" @@ -949,35 +950,6 @@ static struct exynos_mixer_ops mixer_ops = { .win_disable = mixer_win_disable, }; -/* for pageflip event */ -static void mixer_finish_pageflip(struct drm_device *drm_dev, int crtc) -{ - struct exynos_drm_private *dev_priv = drm_dev->dev_private; - struct drm_pending_vblank_event *e, *t; - struct timeval now; - unsigned long flags; - - spin_lock_irqsave(&drm_dev->event_lock, flags); - - list_for_each_entry_safe(e, t, &dev_priv->pageflip_event_list, - base.link) { - /* if event's pipe isn't same as crtc then ignore it. */ - if (crtc != e->pipe) - continue; - - do_gettimeofday(&now); - e->event.sequence = 0; - e->event.tv_sec = now.tv_sec; - e->event.tv_usec = now.tv_usec; - - list_move_tail(&e->base.link, &e->base.file_priv->event_list); - wake_up_interruptible(&e->base.file_priv->event_wait); - drm_vblank_put(drm_dev, crtc); - } - - spin_unlock_irqrestore(&drm_dev->event_lock, flags); -} - static irqreturn_t mixer_irq_handler(int irq, void *arg) { struct exynos_drm_hdmi_context *drm_hdmi_ctx = arg; @@ -1006,7 +978,8 @@ static irqreturn_t mixer_irq_handler(int irq, void *arg) } drm_handle_vblank(drm_hdmi_ctx->drm_dev, ctx->pipe); - mixer_finish_pageflip(drm_hdmi_ctx->drm_dev, ctx->pipe); + exynos_drm_crtc_finish_pageflip(drm_hdmi_ctx->drm_dev, + ctx->pipe); /* set wait vsync event to zero and wake up queue. */ if (atomic_read(&ctx->wait_vsync_event)) { -- 1.8.0

1 0

[PATCH] drm/exynos: consider buffer allocation without iommu
by Inki Dae 03 Jan '13

03 Jan '13

This patch fixes the issue that when buffer allocation is requested without iommu, the allocation is failed. Without iommu, dma_alloc_attrs function allocates some memory region and returns cpu address so this patch makes the cpu address to be set to buf->kvaddr correctly. Signed-off-by: Inki Dae <inki.dae(a)samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_buf.c | 50 +++++++++++++++++++++++++++---- 1 files changed, 44 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_buf.c b/drivers/gpu/drm/exynos/exynos_drm_buf.c index 9601bad..22fb574 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_buf.c +++ b/drivers/gpu/drm/exynos/exynos_drm_buf.c @@ -29,6 +29,7 @@ #include "exynos_drm_drv.h" #include "exynos_drm_gem.h" #include "exynos_drm_buf.h" +#include "exynos_drm_iommu.h" static int lowlevel_buffer_allocate(struct drm_device *dev, unsigned int flags, struct exynos_drm_gem_buf *buf) @@ -66,14 +67,45 @@ static int lowlevel_buffer_allocate(struct drm_device *dev, dma_set_attr(attr, &buf->dma_attrs); dma_set_attr(DMA_ATTR_NO_KERNEL_MAPPING, &buf->dma_attrs); - buf->pages = dma_alloc_attrs(dev->dev, buf->size, - &buf->dma_addr, GFP_KERNEL, &buf->dma_attrs); - if (!buf->pages) { - DRM_ERROR("failed to allocate buffer.\n"); - return -ENOMEM; + nr_pages = buf->size >> PAGE_SHIFT; + + if (!is_drm_iommu_supported(dev)) { + dma_addr_t start_addr; + unsigned int i = 0; + + buf->pages = kzalloc(sizeof(struct page) * nr_pages, + GFP_KERNEL); + if (!buf->pages) { + DRM_ERROR("failed to allocate pages.\n"); + return -ENOMEM; + } + + buf->kvaddr = dma_alloc_attrs(dev->dev, buf->size, + &buf->dma_addr, GFP_KERNEL, + &buf->dma_attrs); + if (!buf->kvaddr) { + DRM_ERROR("failed to allocate buffer.\n"); + kfree(buf->pages); + return -ENOMEM; + } + + start_addr = buf->dma_addr; + while (i < nr_pages) { + buf->pages[i] = phys_to_page(start_addr); + start_addr += PAGE_SIZE; + i++; + } + } else { + + buf->pages = dma_alloc_attrs(dev->dev, buf->size, + &buf->dma_addr, GFP_KERNEL, + &buf->dma_attrs); + if (!buf->pages) { + DRM_ERROR("failed to allocate buffer.\n"); + return -ENOMEM; + } } - nr_pages = buf->size >> PAGE_SHIFT; buf->sgt = drm_prime_pages_to_sg(buf->pages, nr_pages); if (!buf->sgt) { DRM_ERROR("failed to get sg table.\n"); @@ -92,6 +124,9 @@ err_free_attrs: (dma_addr_t)buf->dma_addr, &buf->dma_attrs); buf->dma_addr = (dma_addr_t)NULL; + if (!is_drm_iommu_supported(dev)) + kfree(buf->pages); + return ret; } @@ -117,6 +152,9 @@ static void lowlevel_buffer_deallocate(struct drm_device *dev, dma_free_attrs(dev->dev, buf->size, buf->pages, (dma_addr_t)buf->dma_addr, &buf->dma_attrs); buf->dma_addr = (dma_addr_t)NULL; + + if (!is_drm_iommu_supported(dev)) + kfree(buf->pages); } struct exynos_drm_gem_buf *exynos_drm_init_buf(struct drm_device *dev, -- 1.7.4.1

1 1

[Bug 26891] Radeon KMS fails with inaccessible AtomBIOS on systems with (U)EFI boot
by bugzilla-daemon＠freedesktop.org 03 Jan '13

03 Jan '13

https://bugs.freedesktop.org/show_bug.cgi?id=26891 --- Comment #49 from Anonymous Helper <anonymous(a)dodgeit.com> --- (In reply to comment #48) > What do you mean by "make sure you add the PCI IDs to the xorg for both > cards"? The driver should autodetect the cards fine. However for systems > with multiple VGA cards, you may have to manually specify which ones you > want to start X on. Currently my xorg.conf.d directory contains the following config: $ cat /etc/X11/xorg.conf.d/* Section "Device" Identifier "Radeon Graphics" BusID "PCI:1:0:0" EndSection Section "Device" Identifier "Intel Graphics" BusID "PCI:0:2:0" Driver "intel" Option "AccelMethod" "sna" #Option "AccelMethod" "uxa" #Option "AccelMethod" "xaa" EndSection Is the BusID line in the intel device section not needed? What is needed for X to automatically detect multiple GPUs properly and show some video output from the correct card? -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 58959] New: kernel 3.6.4 and r600_dri.so from mesa 8.0.5 are incompatible
by bugzilla-daemon＠freedesktop.org 03 Jan '13

03 Jan '13

https://bugs.freedesktop.org/show_bug.cgi?id=58959 Priority: medium Bug ID: 58959 Assignee: dri-devel(a)lists.freedesktop.org Summary: kernel 3.6.4 and r600_dri.so from mesa 8.0.5 are incompatible Severity: normal Classification: Unclassified OS: All Reporter: aaalmosss(a)gmail.com Hardware: Other Status: NEW Version: git Component: Drivers/Gallium/r600 Product: Mesa It results in massive amounts of this printout: radeon: The kernel rejected CS, see dmesg for more information. dmesg says: [ 824.623357] radeon 0000:01:00.0: evergreen_surface_check_2d:285 cb height 1088 invalid must be aligned with 128 [ 824.623362] radeon 0000:01:00.0: evergreen_cs_track_validate_cb:427 cb[0] invalid (0x000000df 0x000076ff 0x00090c80 0x01088468) [ 824.623364] radeon 0000:01:00.0: evergreen_packet3_check:2136 invalid cmd stream 607 [ 824.623365] [drm:radeon_cs_ib_chunk] *ERROR* Invalid command stream ! I've got the kernel from vanilla source, and mesa from package (debian unstable). Mesa 9.1-dev works fine. I've got libdrm 2.4.40+ from git (0980633afd9c7eecc0c75ef3bea4d3c6b7aa1898) installed in /usr/local/lib. -- You are receiving this mail because: You are the assignee for the bug.

1 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2013