dri-devel February 2013

dri-devel@lists.freedesktop.org

130 participants
696 discussions

[PATCH v3 0/1] Adds display-timing node parsing to exynos drm fimd
by Vikas Sajjan 01 Feb '13

01 Feb '13

This patch adds display-timing node parsing to drm fimd, this depends on the display helper patchset at http://lists.freedesktop.org/archives/dri-devel/2013-January/033998.html It also adds pinctrl support for drm fimd. changes since v2: - moved 'devm_pinctrl_get_select_default' function call under 'if (pdev->dev.of_node)', this makes NON-DT code unchanged. (reported by: Rahul Sharma <r.sh.open(a)gmail.com>) changes since v1: - addressed comments from Sean Paul <seanpaul(a)chromium.org> patch is based on branch "exynos-drm-next" at http://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git Is tested on Exynos5250 and Exynos4412 by applying dependent patches available at http://lists.freedesktop.org/archives/dri-devel/2013-January/033998.html Vikas Sajjan (1): video: drm: exynos: Adds display-timing node parsing using video helper function drivers/gpu/drm/exynos/exynos_drm_fimd.c | 39 +++++++++++++++++++++++++++--- 1 file changed, 35 insertions(+), 4 deletions(-) -- 1.7.9.5

2 2

Re: [PATCH 0/4] Fix acpi_bus_get_device() check
by Yasuaki Ishimatsu 01 Feb '13

01 Feb '13

acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_FAILURE() to the return value of acpi_bus_get_device(). Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki(a)jp.fujitsu.com> --- drivers/gpu/drm/i915/intel_opregion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-pm/drivers/gpu/drm/i915/intel_opregion.c =================================================================== --- linux-pm.orig/drivers/gpu/drm/i915/intel_opregion.c 2013-01-31 11:39:37.075849905 +0900 +++ linux-pm/drivers/gpu/drm/i915/intel_opregion.c 2013-01-31 11:52:18.796850274 +0900 @@ -347,7 +347,7 @@ static void intel_didl_outputs(struct dr int i = 0; handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev); - if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) + if (!handle || acpi_bus_get_device(handle, &acpi_dev)) return; if (acpi_is_video_device(acpi_dev))

2 6

Re: [PATCH v17 4/7] fbmon: add videomode helpers
by Jingoo Han 01 Feb '13

01 Feb '13

On Friday, January 25, 2013 6:02 PM, Steffen Trumtrar wrote > > Add a function to convert from the generic videomode to a fb_videomode. > > Signed-off-by: Steffen Trumtrar <s.trumtrar(a)pengutronix.de> > Reviewed-by: Thierry Reding <thierry.reding(a)avionic-design.de> > Acked-by: Thierry Reding <thierry.reding(a)avionic-design.de> > Tested-by: Thierry Reding <thierry.reding(a)avionic-design.de> > Tested-by: Philipp Zabel <p.zabel(a)pengutronix.de> > Reviewed-by: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> > Acked-by: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> > Tested-by: Afzal Mohammed <Afzal(a)ti.com> > Tested-by: Rob Clark <robclark(a)gmail.com> > Tested-by: Leela Krishna Amudala <leelakrishna.a(a)gmail.com> > --- > drivers/video/fbmon.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/fb.h | 4 ++++ > 2 files changed, 56 insertions(+) > > diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c > index cef6557..17ce135 100644 > --- a/drivers/video/fbmon.c > +++ b/drivers/video/fbmon.c > @@ -31,6 +31,7 @@ > #include <linux/pci.h> > #include <linux/slab.h> > #include <video/edid.h> > +#include <video/videomode.h> > #ifdef CONFIG_PPC_OF > #include <asm/prom.h> > #include <asm/pci-bridge.h> > @@ -1373,6 +1374,57 @@ int fb_get_mode(int flags, u32 val, struct fb_var_screeninfo *var, struct fb_inf > kfree(timings); > return err; > } > + > +#if IS_ENABLED(CONFIG_VIDEOMODE) > +int fb_videomode_from_videomode(const struct videomode *vm, > + struct fb_videomode *fbmode) > +{ > + unsigned int htotal, vtotal; > + > + fbmode->xres = vm->hactive; > + fbmode->left_margin = vm->hback_porch; > + fbmode->right_margin = vm->hfront_porch; > + fbmode->hsync_len = vm->hsync_len; > + > + fbmode->yres = vm->vactive; > + fbmode->upper_margin = vm->vback_porch; > + fbmode->lower_margin = vm->vfront_porch; > + fbmode->vsync_len = vm->vsync_len; > + > + /* prevent division by zero in KHZ2PICOS macro */ > + fbmode->pixclock = vm->pixelclock ? > + KHZ2PICOS(vm->pixelclock / 1000) : 0; > + > + fbmode->sync = 0; > + fbmode->vmode = 0; > + if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH) > + fbmode->sync |= FB_SYNC_HOR_HIGH_ACT; > + if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH) Hi Steffen Trumtrar, Um, it seems to be a type. 'H'SYNC -> 'V'SYNC Thus, it would be changed as below: VESA_DMT_HSYNC_HIGH -> VESA_DMT_VSYNC_HIGH Best regards, Jingoo Han > + fbmode->sync |= FB_SYNC_VERT_HIGH_ACT; > + if (vm->data_flags & DISPLAY_FLAGS_INTERLACED) > + fbmode->vmode |= FB_VMODE_INTERLACED; > + if (vm->data_flags & DISPLAY_FLAGS_DOUBLESCAN) > + fbmode->vmode |= FB_VMODE_DOUBLE; > + fbmode->flag = 0; > + > + htotal = vm->hactive + vm->hfront_porch + vm->hback_porch + > + vm->hsync_len; > + vtotal = vm->vactive + vm->vfront_porch + vm->vback_porch + > + vm->vsync_len; > + /* prevent division by zero */ > + if (htotal && vtotal) { > + fbmode->refresh = vm->pixelclock / (htotal * vtotal); > + /* a mode must have htotal and vtotal != 0 or it is invalid */ > + } else { > + fbmode->refresh = 0; > + return -EINVAL; > + } > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(fb_videomode_from_videomode); > +#endif > + > #else > int fb_parse_edid(unsigned char *edid, struct fb_var_screeninfo *var) > { > diff --git a/include/linux/fb.h b/include/linux/fb.h > index c7a9571..100a176 100644 > --- a/include/linux/fb.h > +++ b/include/linux/fb.h > @@ -19,6 +19,7 @@ struct vm_area_struct; > struct fb_info; > struct device; > struct file; > +struct videomode; > > /* Definitions below are used in the parsed monitor specs */ > #define FB_DPMS_ACTIVE_OFF 1 > @@ -714,6 +715,9 @@ extern void fb_destroy_modedb(struct fb_videomode *modedb); > extern int fb_find_mode_cvt(struct fb_videomode *mode, int margins, int rb); > extern unsigned char *fb_ddc_read(struct i2c_adapter *adapter); > > +extern int fb_videomode_from_videomode(const struct videomode *vm, > + struct fb_videomode *fbmode); > + > /* drivers/video/modedb.c */ > #define VESA_MODEDB_SIZE 34 > extern void fb_var_to_videomode(struct fb_videomode *mode, > -- > 1.7.10.4 > > _______________________________________________ > dri-devel mailing list > dri-devel(a)lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel

1 0

Re: [PATCH v16 RESEND 0/7] of: add display helper
by Jingoo Han 01 Feb '13

01 Feb '13

Hi Steffen, You can add my tested-by for this series. I have tested them for Exynos: smdk4210 board. Beat regards, Jingoo Han On Wednesday, January 23, 2013 6:12 PM, Steffen Trumtrar wrote > On Tue, Jan 22, 2013 at 03:50:48PM -0600, Rob Clark wrote: > > On Mon, Jan 21, 2013 at 5:07 AM, Steffen Trumtrar > > <s.trumtrar(a)pengutronix.de> wrote: > > > Hi! > > > > > > There was still no maintainer, that commented, ack'd, nack'd, apply'd the > > > series. So, this is just a resend. > > > The patches were tested with: > > > > > > - v15 on Tegra by Thierry > > > - sh-mobile-lcdcfb by Laurent > > > - MX53QSB by Marek > > > - Exynos: smdk5250 by Leela > > > - AM335X EVM & AM335X EVM-SK by Afzal > > > - imx6q: sabrelite, sabresd by Philipp and me > > > - imx53: tqma53/mba53 by me > > > > > > btw, you can add my tested-by for this series.. I've been using them > > for the tilcdc lcd-panel output driver support. > > > > Thanks. The more drivers the merrier ;-) > > Steffen > > > > > > > > > > Changes since v15: > > > - move include/linux/{videomode,display_timing}.h to include/video > > > - move include/linux/of_{videomode,display_timing}.h to include/video > > > - reimplement flags: add VESA flags and data flags > > > - let pixelclock in struct videomode be unsigned long > > > - rename of_display_timings_exists to of_display_timings_exist > > > - revise logging/error messages: replace __func__ with np->full_name > > > - rename pixelclk-inverted to pixelclk-active > > > - revise comments in code > > > > > > Changes since v14: > > > - fix "const struct *" warning > > > (reported by: Leela Krishna Amudala <l.krishna(a)samsung.com>) > > > - return -EINVAL when htotal or vtotal are zero > > > - remove unreachable code in of_get_display_timings > > > - include headers in .c files and not implicit in .h > > > - sort includes alphabetically > > > - fix lower/uppercase in binding documentation > > > - rebase onto v3.7-rc7 > > > > > > Changes since v13: > > > - fix "const struct *" warning > > > (reported by: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com>) > > > - prevent division by zero in fb_videomode_from_videomode > > > > > > Changes since v12: > > > - rename struct display_timing to via_display_timing in via subsystem > > > - fix refreshrate calculation > > > - fix "const struct *" warnings > > > (reported by: Manjunathappa, Prakash <prakash.pm(a)ti.com>) > > > - some CodingStyle fixes > > > - rewrite parts of commit messages and display-timings.txt > > > - let display_timing_get_value get all values instead of just typical > > > > > > Changes since v11: > > > - make pointers const where applicable > > > - add reviewed-by Laurent Pinchart > > > > > > Changes since v10: > > > - fix function name (drm_)display_mode_from_videomode > > > - add acked-by, reviewed-by, tested-by > > > > > > Changes since v9: > > > - don't leak memory when previous timings were correct > > > - CodingStyle fixes > > > - move blank lines around > > > > > > Changes since v8: > > > - fix memory leaks > > > - change API to be more consistent (foo_from_bar(struct bar, struct foo)) > > > - include headers were necessary > > > - misc minor bugfixes > > > > > > Changes since v7: > > > - move of_xxx to drivers/video > > > - remove non-binding documentation from display-timings.txt > > > - squash display_timings and videomode in one patch > > > - misc minor fixes > > > > > > Changes since v6: > > > - get rid of some empty lines etc. > > > - move functions to their subsystems > > > - split of_ from non-of_ functions > > > - add at least some kerneldoc to some functions > > > > > > Changes since v5: > > > - removed all display stuff and just describe timings > > > > > > Changes since v4: > > > - refactored functions > > > > > > Changes since v3: > > > - print error messages > > > - free alloced memory > > > - general cleanup > > > > > > Changes since v2: > > > - use hardware-near property-names > > > - provide a videomode structure > > > - allow ranges for all properties (<min,typ,max>) > > > - functions to get display_mode or fb_videomode > > > > > > > > > Regards, > > > Steffen > > > > > > > > > Steffen Trumtrar (7): > > > viafb: rename display_timing to via_display_timing > > > video: add display_timing and videomode > > > video: add of helper for display timings/videomode > > > fbmon: add videomode helpers > > > fbmon: add of_videomode helpers > > > drm_modes: add videomode helpers > > > drm_modes: add of_videomode helpers > > > > > > .../devicetree/bindings/video/display-timing.txt | 109 +++++++++ > > > drivers/gpu/drm/drm_modes.c | 70 ++++++ > > > drivers/video/Kconfig | 21 ++ > > > drivers/video/Makefile | 4 + > > > drivers/video/display_timing.c | 24 ++ > > > drivers/video/fbmon.c | 94 ++++++++ > > > drivers/video/of_display_timing.c | 239 ++++++++++++++++++++ > > > drivers/video/of_videomode.c | 54 +++++ > > > drivers/video/via/hw.c | 6 +- > > > drivers/video/via/hw.h | 2 +- > > > drivers/video/via/lcd.c | 2 +- > > > drivers/video/via/share.h | 2 +- > > > drivers/video/via/via_modesetting.c | 8 +- > > > drivers/video/via/via_modesetting.h | 6 +- > > > drivers/video/videomode.c | 39 ++++ > > > include/drm/drmP.h | 9 + > > > include/linux/fb.h | 8 + > > > include/video/display_timing.h | 124 ++++++++++ > > > include/video/of_display_timing.h | 20 ++ > > > include/video/of_videomode.h | 18 ++ > > > include/video/videomode.h | 48 ++++ > > > 21 files changed, 894 insertions(+), 13 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/video/display-timing.txt > > > create mode 100644 drivers/video/display_timing.c > > > create mode 100644 drivers/video/of_display_timing.c > > > create mode 100644 drivers/video/of_videomode.c > > > create mode 100644 drivers/video/videomode.c > > > create mode 100644 include/video/display_timing.h > > > create mode 100644 include/video/of_display_timing.h > > > create mode 100644 include/video/of_videomode.h > > > create mode 100644 include/video/videomode.h > > > > > > -- > > > 1.7.10.4 > > > > > >

1 0

[Bug 53111] New: [bisected] lockups since added support for virtual address space on cayman v11
by bugzilla-daemon＠freedesktop.org 01 Feb '13

01 Feb '13

https://bugs.freedesktop.org/show_bug.cgi?id=53111 Bug #: 53111 Summary: [bisected] lockups since added support for virtual address space on cayman v11 Classification: Unclassified Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: alexandre.f.demers(a)gmail.com When running RendererFeatTest64, it always locks at the same test. Lockups also happen when running piglit r600.test, locking always near the same test (sanity tests are OK). If we disable virtual address space as explained under bug 45018, no lockups happen. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 29

[PATCH] drm/exynos: Get HDMI version from device tree
by Sean Paul 01 Feb '13

01 Feb '13

Add a property to the hdmi node so we can specify the HDMI version in the device tree instead of just defaulting to v1.4 with the existence of the dt node. Signed-off-by: Sean Paul <seanpaul(a)chromium.org> --- .../devicetree/bindings/drm/exynos/hdmi.txt | 3 +++ drivers/gpu/drm/exynos/exynos_hdmi.c | 19 ++++++++++--------- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmi.txt b/Documentation/devicetree/bindings/drm/exynos/hdmi.txt index 589edee..d1c7d91 100644 --- a/Documentation/devicetree/bindings/drm/exynos/hdmi.txt +++ b/Documentation/devicetree/bindings/drm/exynos/hdmi.txt @@ -11,6 +11,8 @@ Required properties: c) pin function mode. d) optional flags and pull up/down. e) drive strength. +- samsung,supports-hdmi-1.4: Define if device supports HDMI v1.4 +- samsung,supports-hdmi-1.3: Define if device supports HDMI v1.3 Example: @@ -19,4 +21,5 @@ Example: reg = <0x14530000 0x100000>; interrupts = <0 95 0>; hpd-gpio = <&gpx3 7 0xf 1 3>; + samsung,supports-hdmi-1.4; }; diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 2c46b6c..9834ae5 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -2444,7 +2444,6 @@ static struct platform_device_id hdmi_driver_types[] = { static struct of_device_id hdmi_match_types[] = { { .compatible = "samsung,exynos5-hdmi", - .data = (void *)HDMI_TYPE14, }, { /* end node */ } @@ -2498,16 +2497,18 @@ static int __devinit hdmi_probe(struct platform_device *pdev) platform_set_drvdata(pdev, drm_hdmi_ctx); - if (dev->of_node) { - const struct of_device_id *match; - match = of_match_node(of_match_ptr(hdmi_match_types), - pdev->dev.of_node); - if (match == NULL) - return -ENODEV; - hdata->type = (enum hdmi_type)match->data; - } else { + if (!dev->of_node) { hdata->type = (enum hdmi_type)platform_get_device_id (pdev)->driver_data; + } else if (of_get_property(dev->of_node, "samsung,supports-hdmi-1.4", + NULL)) { + hdata->type = HDMI_TYPE14; + } else if (of_get_property(dev->of_node, "samsung,supports-hdmi-1.3", + NULL)) { + hdata->type = HDMI_TYPE13; + } else { + DRM_ERROR("Could not resolve HDMI version support\n"); + return -ENODEV; } hdata->hpd_gpio = pdata->hpd_gpio; -- 1.7.7.3

8 22

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel February 2013