dri-devel September 2013

dri-devel@lists.freedesktop.org

153 participants
824 discussions

[patch] drm/i915: cleanup a min_t() cast
by Dan Carpenter 20 Sep '13

20 Sep '13

The lower layers of sysfs will not allow an "offset" of more than GEN7_L3LOG_SIZE and also l3_access_valid() caps it a second time. But it's a little easier to audit if we don't have to worry that the subtraction will result in negative values. Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c index d572435..b3f62b4 100644 --- a/drivers/gpu/drm/i915/i915_sysfs.c +++ b/drivers/gpu/drm/i915/i915_sysfs.c @@ -127,7 +127,7 @@ i915_l3_read(struct file *filp, struct kobject *kobj, if (ret) return ret; - count = min_t(int, GEN7_L3LOG_SIZE-offset, count); + count = min_t(size_t, GEN7_L3LOG_SIZE - offset, count); ret = i915_mutex_lock_interruptible(drm_dev); if (ret)

2 1

gma500: remove double free in psbfb_create
by Dave Jones 20 Sep '13

20 Sep '13

This code appears to be calling psb_gtt_free_range twice with the same args. (The second call didn't appear in the diff output, it's right after the mutex_unlock) Spotted with Coverity, not tested due to lack of hardware. Signed-off-by: Dave Jones <davej(a)fedoraproject.org> diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index 01dd7d2..d35ffc4 100644 --- a/drivers/gpu/drm/gma500/framebuffer.c +++ b/drivers/gpu/drm/gma500/framebuffer.c @@ -479,9 +479,7 @@ static int psbfb_create(struct psb_fbdev *fbdev, mutex_unlock(&dev->struct_mutex); return 0; out_unref: - if (backing->stolen) - psb_gtt_free_range(dev, backing); - else + if (!backing->stolen) drm_gem_object_unreference(&backing->gem); out_err1: mutex_unlock(&dev->struct_mutex);

2 1

[Bug 66738] System freeze randomly with latest kernel 3.10 (also 3.11-rc4)
by bugzilla-daemon＠freedesktop.org 20 Sep '13

20 Sep '13

https://bugs.freedesktop.org/show_bug.cgi?id=66738 --- Comment #14 from lh <jarryson(a)gmail.com> --- problem still exist in kernel git 20130918 -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] radeon: fix pitch alignment for non-power-of-two mipmaps on SI
by Marek Olšák 20 Sep '13

20 Sep '13

This fixes VM protection faults. I have a new piglit test which can iterate over all possible widths, heights, and depths (including NPOT) and tests mipmapping with various texture targets. After this is committed, I'll make a new release of libdrm and bump the libdrm version requirement in Mesa. --- radeon/radeon_surface.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/radeon/radeon_surface.c b/radeon/radeon_surface.c index 1710e34..d5c45c4 100644 --- a/radeon/radeon_surface.c +++ b/radeon/radeon_surface.c @@ -1412,7 +1412,11 @@ static void si_surf_minify(struct radeon_surface *surf, uint32_t xalign, uint32_t yalign, uint32_t zalign, uint32_t slice_align, unsigned offset) { - surflevel->npix_x = mip_minify(surf->npix_x, level); + if (level == 0) { + surflevel->npix_x = surf->npix_x; + } else { + surflevel->npix_x = mip_minify(next_power_of_two(surf->npix_x), level); + } surflevel->npix_y = mip_minify(surf->npix_y, level); surflevel->npix_z = mip_minify(surf->npix_z, level); @@ -1434,7 +1438,7 @@ static void si_surf_minify(struct radeon_surface *surf, if (level == 0 && surf->last_level == 0) /* Non-mipmap pitch padded to slice alignment */ xalign = MAX2(xalign, slice_align / surf->bpe); - else + else if (surflevel->mode == RADEON_SURF_MODE_LINEAR_ALIGNED) /* Small rows evenly distributed across slice */ xalign = MAX2(xalign, slice_align / surf->bpe / surflevel->nblk_y); @@ -1456,7 +1460,11 @@ static void si_surf_minify_2d(struct radeon_surface *surf, { unsigned mtile_pr, mtile_ps; - surflevel->npix_x = mip_minify(surf->npix_x, level); + if (level == 0) { + surflevel->npix_x = surf->npix_x; + } else { + surflevel->npix_x = mip_minify(next_power_of_two(surf->npix_x), level); + } surflevel->npix_y = mip_minify(surf->npix_y, level); surflevel->npix_z = mip_minify(surf->npix_z, level); -- 1.8.1.2

2 5

[git pull] drm radeon/nouveau/core fixes
by Dave Airlie 20 Sep '13

20 Sep '13

Hi Linus, mostly radeon fixes, with some nouveau bios parser, ttm fix and a fix for AST driver. Dave. The following changes since commit 01172772c7c973debf5b4881fcb9463891ea97ec: drm/nouveau: fix oops on runtime suspend/resume (2013-09-10 12:38:53 +1000) are available in the git repository at: git://people.freedesktop.org/~airlied/linux drm-fixes for you to fetch changes up to 928c2f0c006bf7f381f58af2b2786d2a858ae311: drm/fb-helper: don't sleep for screen unblank when an oops is in progress (2013-09-19 11:54:34 +1000) ---------------------------------------------------------------- Alex Deucher (24): drm/radeon/cik: properly handle internal cp ints drm/radeon/si: properly handle internal cp ints drm/radeon/dce6/audio: make sure pin is valid before accessing it drm/radeon: add a connector property for audio drm/radeon: dpm updates for KV drm/radeon: protect concurrent smc register access with a spinlock drm/radeon: add spinlocks for indirect register accesss drm/radeon/cik: update gpu_init for an additional berlin gpu drm/radeon: add some additional berlin pci ids drm/radeon: fix typo in PG flags drm/radeon/r6xx: add a stubbed out set_uvd_clocks callback drm/radeon/dpm: fix fallback for empty UVD clocks drm/radeon/atom: workaround vbios bug in transmitter table on rs880 (v2) drm/radeon/dpm: handle bapm on trinity drm/radeon/dpm: handle bapm on kb/kv drm/radeon/dpm: add infrastructure to properly handle bapm drm/radeon/dpm: add bapm callback for trinity drm/radeon/dpm: add bapm callback for kb/kv drm/radeon/dpm/rs780: use drm_mode_vrefresh() drm/radeon/dpm/rs780: add some sanity checking to sclk scaling drm/radeon/dpm/rs780: don't enable sclk scaling if not required drm/radeon/dpm/rs780: fix force_performance state for same sclks drm/radeon/dpm: rework auto performance level enable drm/radeon: fix panel scaling with eDP and LVDS bridges Anthoine Bourgeois (1): drm/radeon/dpm: implement force performance levels for rs780 (v2) Ben Skeggs (5): drm/nouveau/bios/init: stub opcode 0xaa drm/nouveau/kms: enable for non-vga pci classes drm/nouveau/bios/init: fix thinko in INIT_CONFIGURE_MEM drm/nouveau/ttm: prevent double-free in nouveau_sgdma_create_ttm() failure path drm/ttm: fix the tt_populated check in ttm_tt_destroy() Christian König (3): drm/radeon: remove stale radeon_fence_retire tracepoint drm/radeon: add command submission tracepoint drm/radeon: avoid UVD corruptions on AGP cards Damien Lespiau (1): drm/radeon: Fix hmdi typo Dan Carpenter (2): drm/radeon: clean up r600_free_extended_power_table() drm/radeon: signedness bug in kv_dpm.c Daniel Vetter (2): drm/udl: rip out set_need_resched drm/fb-helper: don't sleep for screen unblank when an oops is in progress Dave Airlie (4): drm/ast: fix the ast open key function Merge branch 'drm-fixes-3.12' of git://people.freedesktop.org/~agd5f/linux into drm-fixes Merge branch 'drm-fixes-3.12' of git://people.freedesktop.org/~agd5f/linux into drm-fixes Merge branch 'drm-nouveau-next' of git://anongit.freedesktop.org/git/nouveau/linux-2.6 into drm-fixes Jean Delvare (2): drm/radeon: simplify driver data retrieval drm/radeon: expose DPM thermal thresholds through sysfs Prarit Bhargava (1): drm, ttm Fix uninitialized warning drivers/gpu/drm/ast/ast_drv.h | 2 +- drivers/gpu/drm/drm_fb_helper.c | 8 ++ drivers/gpu/drm/nouveau/core/subdev/bios/init.c | 21 ++- drivers/gpu/drm/nouveau/nouveau_display.c | 35 +++-- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 3 +- drivers/gpu/drm/nouveau/nouveau_sgdma.c | 4 +- drivers/gpu/drm/radeon/atombios_encoders.c | 23 ++-- drivers/gpu/drm/radeon/btc_dpm.c | 6 - drivers/gpu/drm/radeon/ci_dpm.c | 6 - drivers/gpu/drm/radeon/ci_smc.c | 39 ++++-- drivers/gpu/drm/radeon/cik.c | 36 +++++- drivers/gpu/drm/radeon/cypress_dpm.c | 6 - drivers/gpu/drm/radeon/dce6_afmt.c | 12 +- drivers/gpu/drm/radeon/kv_dpm.c | 164 +++++++++++++++++++----- drivers/gpu/drm/radeon/kv_dpm.h | 1 + drivers/gpu/drm/radeon/kv_smc.c | 8 ++ drivers/gpu/drm/radeon/ni_dpm.c | 6 - drivers/gpu/drm/radeon/ppsmc.h | 2 + drivers/gpu/drm/radeon/r100.c | 7 + drivers/gpu/drm/radeon/r420.c | 7 + drivers/gpu/drm/radeon/r600.c | 19 +++ drivers/gpu/drm/radeon/r600_dpm.c | 38 ++---- drivers/gpu/drm/radeon/r600d.h | 2 +- drivers/gpu/drm/radeon/radeon.h | 82 +++++++++++- drivers/gpu/drm/radeon/radeon_asic.c | 11 +- drivers/gpu/drm/radeon/radeon_asic.h | 5 + drivers/gpu/drm/radeon/radeon_connectors.c | 69 +++++++++- drivers/gpu/drm/radeon/radeon_cs.c | 11 +- drivers/gpu/drm/radeon/radeon_device.c | 11 ++ drivers/gpu/drm/radeon/radeon_display.c | 12 ++ drivers/gpu/drm/radeon/radeon_drv.c | 2 +- drivers/gpu/drm/radeon/radeon_mode.h | 9 ++ drivers/gpu/drm/radeon/radeon_pm.c | 81 +++++++++--- drivers/gpu/drm/radeon/radeon_trace.h | 27 +++- drivers/gpu/drm/radeon/rs400.c | 7 + drivers/gpu/drm/radeon/rs600.c | 12 +- drivers/gpu/drm/radeon/rs690.c | 7 + drivers/gpu/drm/radeon/rs780_dpm.c | 112 +++++++++++++--- drivers/gpu/drm/radeon/rv515.c | 8 ++ drivers/gpu/drm/radeon/rv6xx_dpm.c | 2 - drivers/gpu/drm/radeon/rv770_dpm.c | 16 +-- drivers/gpu/drm/radeon/rv770_smc.c | 44 ++++--- drivers/gpu/drm/radeon/rv770_smc.h | 2 - drivers/gpu/drm/radeon/rv770d.h | 2 +- drivers/gpu/drm/radeon/si.c | 21 ++- drivers/gpu/drm/radeon/si_dpm.c | 6 - drivers/gpu/drm/radeon/si_smc.c | 43 ++++--- drivers/gpu/drm/radeon/sumo_dpm.c | 2 - drivers/gpu/drm/radeon/trinity_dpm.c | 17 ++- drivers/gpu/drm/radeon/trinity_dpm.h | 2 + drivers/gpu/drm/radeon/trinity_smc.c | 8 ++ drivers/gpu/drm/ttm/ttm_object.c | 2 +- drivers/gpu/drm/ttm/ttm_tt.c | 2 +- drivers/gpu/drm/udl/udl_gem.c | 1 - include/drm/drm_pciids.h | 3 + 55 files changed, 835 insertions(+), 259 deletions(-)

4 4

[edid-decode] Finish the list of 3D layouts 3D_Structure_ALL can code for
by Damien Lespiau 20 Sep '13

20 Sep '13

Signed-off-by: Damien Lespiau <damien.lespiau(a)intel.com> --- edid-decode.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/edid-decode.c b/edid-decode.c index bf0c3da..d3e3118 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -829,12 +829,26 @@ cea_hdmi_block(unsigned char *x) if (len_3d) { if (formats) { + /* 3D_Structure_ALL_15..8 */ + if (x[9 + b] & 0x80) + printf(" 3D: Side-by-side (half, quincunx)\n"); if (x[9 + b] & 0x01) - printf(" Side-by-side 3D supported\n"); + printf(" 3D: Side-by-side (half, horizontal)\n"); + /* 3D_Structure_ALL_7..0 */ if (x[10 + b] & 0x40) - printf(" Top-and-bottom 3D supported\n"); + printf(" 3D: Top-and-bottom\n"); + if (x[10 + b] & 0x20) + printf(" 3D: L + depth + gfx + gfx-depth\n"); + if (x[10 + b] & 0x10) + printf(" 3D: L + depth\n"); + if (x[10 + b] & 0x08) + printf(" 3D: Side-by-side (full)\n"); + if (x[10 + b] & 0x04) + printf(" 3D: Line-alternative\n"); + if (x[10 + b] & 0x02) + printf(" 3D: Field-alternative\n"); if (x[10 + b] & 0x01) - printf(" Frame-packing 3D supported\n"); + printf(" 3D: Frame-packing\n"); b += 2; } if (mask) { -- 1.8.3.1

1 0

[drm/exynos-fimd] Display regression in v3.12-rc1
by Sachin Kamat 20 Sep '13

20 Sep '13

Hi Andrzej , I was testing the latest Linux kernel release (v3.12-rc1) on Exynos4210 based Origen board. I found a display regression with that. I do not get any display on the LCD (other than backlight) with the latest kernel. Git bisect pointed me to the following commit: 111e6055d4e0d35c6a4b6cd37d7bb00a88eaffb4 ("drm/exynos: fimd: replace struct fb_videomode with videomode"). Reverting this patch does not cause the issue. Let me know if you need any other info to help identify the problem. -- With warm regards, Sachin

2 4

linux-next: manual merge of the drm-intel tree with the drm-intel-fixes tree
by Stephen Rothwell 20 Sep '13

20 Sep '13

Hi all, Today's linux-next merge of the drm-intel tree got a conflict in drivers/gpu/drm/i915/intel_display.c between commit cc173961a680 ("drm/i915: do not update cursor in crtc mode set") from the drm-intel-fixes tree and commit e9fd1c02aca7 ("drm/i915: don't enable DPLL for DSI") from the drm-intel tree. I fixed it up (see below) and can carry the fix as necessary (no action is required). -- Cheers, Stephen Rothwell sfr(a)canb.auug.org.au diff --cc drivers/gpu/drm/i915/intel_display.c index d8a1d98,2ed974e..0000000 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@@ -4863,21 -4915,27 +4915,24 @@@ static int i9xx_crtc_mode_set(struct dr refclk = i9xx_get_refclk(crtc, num_connectors); - /* - * Returns a set of divisors for the desired target clock with the given - * refclk, or FALSE. The returned values represent the clock equation: - * reflck * (5 * (m1 + 2) + (m2 + 2)) / (n + 2) / p1 / p2. - */ - limit = intel_limit(crtc, refclk); - ok = dev_priv->display.find_dpll(limit, crtc, - intel_crtc->config.port_clock, - refclk, NULL, &clock); - if (!ok && !intel_crtc->config.clock_set) { - DRM_ERROR("Couldn't find PLL settings for mode!\n"); - return -EINVAL; + if (!is_dsi && !intel_crtc->config.clock_set) { + /* + * Returns a set of divisors for the desired target clock with + * the given refclk, or FALSE. The returned values represent + * the clock equation: reflck * (5 * (m1 + 2) + (m2 + 2)) / (n + + * 2) / p1 / p2. + */ + limit = intel_limit(crtc, refclk); + ok = dev_priv->display.find_dpll(limit, crtc, + intel_crtc->config.port_clock, + refclk, NULL, &clock); + if (!ok && !intel_crtc->config.clock_set) { + DRM_ERROR("Couldn't find PLL settings for mode!\n"); + return -EINVAL; + } } - if (is_lvds && dev_priv->lvds_downclock_avail) { - /* Ensure that the cursor is valid for the new mode before changing... */ - intel_crtc_update_cursor(crtc, true); - + if (!is_dsi && is_lvds && dev_priv->lvds_downclock_avail) { /* * Ensure we match the reduced clock's P to the target clock. * If the clocks don't match, we can't switch the display clock @@@ -8199,11 -8377,11 +8371,12 @@@ static void intel_dump_pipe_config(stru pipe_config->gmch_pfit.control, pipe_config->gmch_pfit.pgm_ratios, pipe_config->gmch_pfit.lvds_border_bits); - DRM_DEBUG_KMS("pch pfit: pos: 0x%08x, size: 0x%08x\n", + DRM_DEBUG_KMS("pch pfit: pos: 0x%08x, size: 0x%08x, %s\n", pipe_config->pch_pfit.pos, - pipe_config->pch_pfit.size); + pipe_config->pch_pfit.size, + pipe_config->pch_pfit.enabled ? "enabled" : "disabled"); DRM_DEBUG_KMS("ips: %i\n", pipe_config->ips_enabled); + DRM_DEBUG_KMS("double wide: %i\n", pipe_config->double_wide); } static bool check_encoder_cloning(struct drm_crtc *crtc)

1 0

Re: Regression: bisected: commit 7c510133d93 breaks video
by Dave Airlie 19 Sep '13

19 Sep '13

On Thu, Sep 19, 2013 at 12:02 PM, Paul Zimmerman <Paul.Zimmerman(a)synopsys.com> wrote: > I have an ASUS P6X58D-Premium mobo with a GeForce 9400GT PCIe video card. > With kernel 3.12-rc1, I get scrambled video on boot. Kernel 3.11 works > fine. > > Bisecting this, I found 7c510133d93dd6f15ca040733ba7b2891ed61fd1 "drm: > mark context support as a legacy subsystem" is the guilty commit. If I > revert that commit, the video works fine. > > Is there any more info I can provide? Full dmesg, and what driver you are using. Dave.

3 7

[Bug 49603] New: [regression] Fullscreen video no longer smooth with GPU in low power mode
by bugzilla-daemon＠freedesktop.org 19 Sep '13

19 Sep '13

https://bugs.freedesktop.org/show_bug.cgi?id=49603 Bug #: 49603 Summary: [regression] Fullscreen video no longer smooth with GPU in low power mode Classification: Unclassified Product: Mesa Version: 8.0 Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: sa(a)whiz.se With Mesa 8.0 I can watch fullscreen videos using Totem (and other players that uses an OpenGL sink) with my GPU set to "low" power mode without problems. With 8.0.1 (and later) this is no longer possible. Every so often I get stalls and what looks like dropped frames. It's a blink and you'll miss it kind of thing, but over a longer period of time (such as watching a movie) it's quite noticeable and annoying. Setting the card to "mid" or higher works around this, but as it's a passive card I would prefer to keep it running in low as much as possible. Bisecting for this bug turns up the below commit, I have confirmed it by reverting this change. (I'm not sure if adding the patch author to the cc list is considered good practice or not?) System environment: -- system architecture: 32-bit -- Linux distribution: Debian unstable -- GPU: REDWOOD -- Model: XFX Radeon HD 5670 1GB -- Display connector: DVI -- xf86-video-ati: 6.14.4 -- xserver: 1.12.1 -- mesa: 8.0.2 -- drm: 2.4.33 -- kernel: 3.3.4 106ea10d1b246aba1a0f4e171fd7d21268f3960f is the first bad commit commit 106ea10d1b246aba1a0f4e171fd7d21268f3960f Author: Simon Farnsworth <simon.farnsworth(a)onelan.co.uk> Date: Tue Feb 14 12:06:20 2012 +0000 r600g: Use a fake reloc to sleep for fences r300g is able to sleep until a fence completes rather than busywait because it creates a special buffer object and relocation that stays busy until the CS containing the fence is finished. Copy the idea into r600g, and use it to sleep if the user asked for an infinite wait, falling back to busywaiting if the user provided a timeout. Signed-off-by: Simon Farnsworth <simon.farnsworth(a)onelan.co.uk> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> (cherry picked from commit 8cd03b933cf868ff867e2db4a0937005a02fd0e4) Conflicts: src/gallium/drivers/r600/r600_pipe.c :040000 040000 390170e370f86ee323dce284906ed21693ed9d09 cccea412e6be4f3619422196231e02b375ab4772 M src -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 7

← Newer
1
...
66
67
68
69
70
71
72
...
83
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2013