dri-devel September 2013

dri-devel@lists.freedesktop.org

153 participants
824 discussions

Suspect code in drm_crtc_helper.c
by Giovanni Campagna 15 Sep '13

15 Sep '13

Hello all I was reading through the drm code to get an understanding of how it works, and stumbled upon some really strange code in drm_crtc_helper_set_config(), where it computes then new encoder for each connector (drm_crtc_helper.c:705 in linux-next/master, aka f03a594). There is a comment there saying "don't break so the fail path works correctly", but then immediately after it breaks unconditionally, also leaving a block of code unreachable. Btw, the break and the comment are from f453ba04 ("DRM: add mode setting support"), while the block after is from 25f397a4 ("drm/crtc-helper: explicit DPMS on after modeset") I don't have enough knowledge of DRM internals to know if this is correct or not, but I think I should point it out, and then you'll know. At least, the unreachable code looks like a bug to me. Cheers Giovanni

2 1

[Bug 69341] [radeonsi] KDE 4.11 is EXTREMELY slow with Raster QT backend
by bugzilla-daemon＠freedesktop.org 15 Sep '13

15 Sep '13

1 0

[Bug 69341] [radeonsi] KDE 4.11 is EXTREMELY slow with Raster QT backend while X11/XRender has graphical glitches
by bugzilla-daemon＠freedesktop.org 15 Sep '13

15 Sep '13

https://bugs.freedesktop.org/show_bug.cgi?id=69341 --- Comment #5 from darkbasic <darkbasic(a)linuxsystems.it> --- Card is AMD Radeon HD 7950. The graphical glitches with the X11/XRender backend seems to be a known issue (https://bugs.freedesktop.org/show_bug.cgi?id=64297) so I modified the bug to track just the issues with the Raster backend. Actually the KDE overall desktop experience is so bad that I had to switch back to the integrated Ivy Bridge graphic :( -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 69341] [radeonsi] KDE 4.11 is EXTREMELY slow with Raster QT backend while X11/XRender has graphical glitches
by bugzilla-daemon＠freedesktop.org 15 Sep '13

15 Sep '13

1 0

[Bug 69340] New: Recent mesa git revisions cause frequent gpu hangs on radeonsi
by bugzilla-daemon＠freedesktop.org 15 Sep '13

15 Sep '13

https://bugs.freedesktop.org/show_bug.cgi?id=69340 Priority: medium Bug ID: 69340 Assignee: dri-devel(a)lists.freedesktop.org Summary: Recent mesa git revisions cause frequent gpu hangs on radeonsi Severity: normal Classification: Unclassified OS: Linux (All) Reporter: j.suarez.agapito(a)gmail.com Hardware: x86-64 (AMD64) Status: NEW Version: git Component: Drivers/Gallium/radeonsi Product: Mesa After installing mesa git 395b9410 (from oibaf's ppa on Kubuntu raring) I am experiencing gpu hangs and kernel panics when launching "somewhat complex" 3D games. For example, glxgears and supertuxkart do not produce the gpu hang, but speed-dreams2 (it hangs when the game should show your car in order to drive), L4D2 (just after the Valve logo-video, just when the game intro movie should start playing) and Crusader Kings II (just at the very beginning, when the loading screen should come up). The last mesa git version I had installed was 505fad04, which works correctly. Moreover, the crashes happen both with radeon.dpm=1 and radeon.dpm=0. I have managed to get some dmesg outputs of the crashes: Crash #1 [ 334.162270] radeon 0000:01:00.0: GPU lockup CP stall for more than 10000msec [ 334.162280] radeon 0000:01:00.0: GPU lockup (waiting for 0x00000000000160ea) [ 334.162289] radeon 0000:01:00.0: failed to get a new IB (-35) [ 334.162291] [TTM] Failed to expire sync object before buffer eviction [ 334.162299] [drm:radeon_cs_ib_vm_chunk] *ERROR* Failed to get ib ! [ 334.162378] [TTM] Failed to expire sync object before buffer eviction [ 334.172123] radeon 0000:01:00.0: sa_manager is not empty, clearing anyway [ 334.381742] radeon 0000:01:00.0: Saved 97917 dwords of commands on ring 0. [ 334.381879] radeon 0000:01:00.0: GPU softreset: 0x00000049 [ 334.381882] radeon 0000:01:00.0: GRBM_STATUS = 0xE5D04028 [ 334.381884] radeon 0000:01:00.0: GRBM_STATUS_SE0 = 0xEE400000 [ 334.381886] radeon 0000:01:00.0: GRBM_STATUS_SE1 = 0xEE400000 [ 334.381889] radeon 0000:01:00.0: SRBM_STATUS = 0x200000C0 [ 334.382000] radeon 0000:01:00.0: SRBM_STATUS2 = 0x00000000 [ 334.382002] radeon 0000:01:00.0: R_008674_CP_STALLED_STAT1 = 0x00000000 [ 334.382004] radeon 0000:01:00.0: R_008678_CP_STALLED_STAT2 = 0x00018000 [ 334.382006] radeon 0000:01:00.0: R_00867C_CP_BUSY_STAT = 0x00408002 [ 334.382009] radeon 0000:01:00.0: R_008680_CP_STAT = 0x84038643 [ 334.382011] radeon 0000:01:00.0: R_00D034_DMA_STATUS_REG = 0x44C83D57 [ 334.382013] radeon 0000:01:00.0: R_00D834_DMA_STATUS_REG = 0x44C83D57 [ 334.382016] radeon 0000:01:00.0: VM_CONTEXT1_PROTECTION_FAULT_ADDR 0x00000000 [ 334.382018] radeon 0000:01:00.0: VM_CONTEXT1_PROTECTION_FAULT_STATUS 0x00000000 [ 334.386528] radeon 0000:01:00.0: GRBM_SOFT_RESET=0x0000DDFF [ 334.386582] radeon 0000:01:00.0: SRBM_SOFT_RESET=0x00000100 [ 334.387728] radeon 0000:01:00.0: GRBM_STATUS = 0x00003028 [ 334.387730] radeon 0000:01:00.0: GRBM_STATUS_SE0 = 0x00000006 [ 334.387731] radeon 0000:01:00.0: GRBM_STATUS_SE1 = 0x00000006 [ 334.387733] radeon 0000:01:00.0: SRBM_STATUS = 0x200000C0 [ 334.387844] radeon 0000:01:00.0: SRBM_STATUS2 = 0x00000000 [ 334.387846] radeon 0000:01:00.0: R_008674_CP_STALLED_STAT1 = 0x00000000 [ 334.387848] radeon 0000:01:00.0: R_008678_CP_STALLED_STAT2 = 0x00000000 [ 334.387850] radeon 0000:01:00.0: R_00867C_CP_BUSY_STAT = 0x00000000 [ 334.387852] radeon 0000:01:00.0: R_008680_CP_STAT = 0x00000000 [ 334.387854] radeon 0000:01:00.0: R_00D034_DMA_STATUS_REG = 0x44C83D57 [ 334.387856] radeon 0000:01:00.0: R_00D834_DMA_STATUS_REG = 0x44C83D57 [ 334.387981] radeon 0000:01:00.0: GPU reset succeeded, trying to resume [ 334.415260] [drm] probing gen 2 caps for device 1002:5a16 = 31cd02/0 [ 334.415264] [drm] PCIE gen 2 link speeds already enabled [ 334.417417] [drm] PCIE GART of 512M enabled (table at 0x0000000000276000). [ 334.417520] radeon 0000:01:00.0: WB enabled [ 334.417522] radeon 0000:01:00.0: fence driver on ring 0 use gpu addr 0x0000000080000c00 and cpu addr 0xffff880412af4c00 [ 334.417524] radeon 0000:01:00.0: fence driver on ring 1 use gpu addr 0x0000000080000c04 and cpu addr 0xffff880412af4c04 [ 334.417526] radeon 0000:01:00.0: fence driver on ring 2 use gpu addr 0x0000000080000c08 and cpu addr 0xffff880412af4c08 [ 334.417528] radeon 0000:01:00.0: fence driver on ring 3 use gpu addr 0x0000000080000c0c and cpu addr 0xffff880412af4c0c [ 334.417530] radeon 0000:01:00.0: fence driver on ring 4 use gpu addr 0x0000000080000c10 and cpu addr 0xffff880412af4c10 [ 334.418521] radeon 0000:01:00.0: fence driver on ring 5 use gpu addr 0x0000000000075a18 and cpu addr 0xffffc90011db5a18 [ 334.436919] [drm] ring test on 0 succeeded in 3 usecs [ 334.436924] [drm] ring test on 1 succeeded in 1 usecs [ 334.436929] [drm] ring test on 2 succeeded in 1 usecs [ 334.436992] [drm] ring test on 3 succeeded in 2 usecs [ 334.437003] [drm] ring test on 4 succeeded in 1 usecs [ 334.612443] [drm] ring test on 5 succeeded in 2 usecs [ 334.612447] [drm] UVD initialized successfully. [ 334.657863] [drm] ib test on ring 0 succeeded in 0 usecs [ 334.658379] [drm] ib test on ring 1 succeeded in 0 usecs [ 334.658543] [drm] ib test on ring 2 succeeded in 0 usecs [ 334.658587] [drm] ib test on ring 3 succeeded in 0 usecs [ 334.658627] [drm] ib test on ring 4 succeeded in 1 usecs Crash #2 [ 768.143440] radeon 0000:01:00.0: GPU lockup CP stall for more than 10000msec [ 768.143452] radeon 0000:01:00.0: GPU lockup (waiting for 0x00000000000015f1 last fence id 0x00000000000015ed) [ 768.642649] radeon 0000:01:00.0: GPU lockup CP stall for more than 10500msec [ 768.642659] radeon 0000:01:00.0: GPU lockup (waiting for 0x0000000000073db9) [ 768.642666] radeon 0000:01:00.0: failed to get a new IB (-35) [ 768.642689] BUG: unable to handle kernel paging request at 0000100000000018 [ 768.642756] IP: [<ffffffffa014f13d>] radeon_ib_sync_to+0x1d/0x40 [radeon] [ 768.642862] PGD 0 [ 768.642883] Oops: 0000 [#1] SMP [ 768.642915] Modules linked in: snd_hrtimer parport_pc ppdev bnep rfcomm bluetooth binfmt_misc snd_hda_codec_hdmi snd_hda_codec_realtek sp5100_tco eeepc_wmi asus_wmi sparse_keymap video snd_hda_intel snd_hda_codec snd_hwdep snd_pcm snd_page_alloc arc4 snd_seq_midi snd_seq_midi_event rt61pci snd_rawmidi rt2x00pci rt2x00mmio rt2x00lib mac80211 snd_seq snd_seq_device snd_timer cfg80211 edac_core snd psmouse eeprom_93cx6 edac_mce_amd crc_itu_t serio_raw fam15h_power k10temp i2c_piix4 ohci_pci soundcore mac_hid it87 hwmon_vid lp parport hid_generic usbhid hid mxm_wmi radeon i2c_algo_bit ttm e1000e drm_kms_helper ahci ptp drm pps_core libahci wmi [ 768.643499] CPU: 4 PID: 3886 Comm: ck2 Not tainted 3.11.0-031100-generic #201309021735 [ 768.643565] Hardware name: To be filled by O.E.M. To be filled by O.E.M./Crosshair V Formula, BIOS 1605 09/21/2012 [ 768.643650] task: ffff8803c7cac650 ti: ffff88037be68000 task.ti: ffff88037be68000 [ 768.643712] RIP: 0010:[<ffffffffa014f13d>] [<ffffffffa014f13d>] radeon_ib_sync_to+0x1d/0x40 [radeon] [ 768.643830] RSP: 0018:ffff88037be69a08 EFLAGS: 00210206 [ 768.643875] RAX: 0000100000000000 RBX: ffff880415251900 RCX: 0000000000000000 [ 768.643934] RDX: 0000000000000000 RSI: ffff88037bdca8c0 RDI: ffff88037be69a30 [ 768.643992] RBP: ffff88037be69a08 R08: 0000000000000006 R09: 0000000000001000 [ 768.644051] R10: 0000000000000005 R11: 0000000000000000 R12: ffff88037c644ea0 [ 768.644109] R13: ffff88041218c000 R14: 0000000000000000 R15: 0000000000000000 [ 768.644169] FS: 00007ff86a366740(0000) GS:ffff88042ed00000(0000) knlGS:00000000e7a5fb40 [ 768.644236] CS: 0010 DS: 002b ES: 002b CR0: 000000008005003b [ 768.644283] CR2: 0000100000000018 CR3: 00000003cb38d000 CR4: 00000000000407e0 [ 768.644342] Stack: [ 768.644360] ffff88037be69ad8 ffffffffa013cb35 ffff880400000016 ffff88042ecd4580 [ 768.644428] ffff88037be69a48 0000000000000000 ffff880300000010 ffff8804130ba6e8 [ 768.644496] ffff88037be69a58 ffffffff8106a164 003fe00024200002 0000006000000000 [ 768.644563] Call Trace: [ 768.644624] [<ffffffffa013cb35>] radeon_vm_bo_update_pte+0x165/0x270 [radeon] [ 768.644691] [<ffffffff8106a164>] ? local_bh_enable+0x94/0xa0 [ 768.644776] [<ffffffffa013cc9b>] radeon_vm_bo_rmv+0x5b/0xf0 [radeon] [ 768.644870] [<ffffffffa014e203>] radeon_gem_object_close+0xf3/0x110 [radeon] [ 768.644951] [<ffffffffa0028502>] drm_gem_object_release_handle+0x72/0xf0 [drm] [ 768.645016] [<ffffffff81368051>] idr_for_each+0xa1/0xf0 [ 768.645079] [<ffffffffa0028490>] ? drm_gem_handle_create+0xf0/0xf0 [drm] [ 768.645140] [<ffffffff81728c6d>] ? mutex_lock+0x1d/0x41 [ 768.645203] [<ffffffffa0028a14>] drm_gem_release+0x24/0x40 [drm] [ 768.645271] [<ffffffffa00270e2>] drm_release+0x482/0x520 [drm] [ 768.645326] [<ffffffff811b3f1a>] __fput+0xba/0x240 [ 768.645371] [<ffffffff811b40ee>] ____fput+0xe/0x10 [ 768.645415] [<ffffffff81085848>] task_work_run+0xc8/0xf0 [ 768.645463] [<ffffffff81067ede>] do_exit+0x19e/0x480 [ 768.645510] [<ffffffff81068254>] do_group_exit+0x44/0xa0 [ 768.645558] [<ffffffff810782a1>] get_signal_to_deliver+0x231/0x480 [ 768.645615] [<ffffffff81013be7>] do_signal+0x47/0x140 [ 768.645662] [<ffffffff81712eda>] ? is_prefetch.isra.12.part.13+0x1a4/0x1ff [ 768.645724] [<ffffffff8109d134>] ? vtime_account_user+0x74/0x90 [ 768.645777] [<ffffffff81013d68>] do_notify_resume+0x88/0xc0 [ 768.645827] [<ffffffff8172cdbc>] retint_signal+0x48/0x8c [ 768.645873] Code: 5d f0 4c 8b 65 f8 c9 c3 66 0f 1f 44 00 00 66 66 66 66 90 55 48 85 f6 48 89 e5 74 25 8b 4e 18 89 ca 48 8b 44 d7 40 48 85 c0 74 1b <3b> 48 18 75 1b 48 8b 48 10 48 39 4e 10 48 0f 47 c6 48 89 44 d7 [ 768.646149] RIP [<ffffffffa014f13d>] radeon_ib_sync_to+0x1d/0x40 [radeon] [ 768.646246] RSP <ffff88037be69a08> [ 768.646276] CR2: 0000100000000018 [ 768.666026] ---[ end trace 50e00cc0d778d510 ]--- [ 768.666030] Fixing recursive fault but reboot is needed! [ 769.141752] radeon 0000:01:00.0: GPU lockup CP stall for more than 11000msec [ 769.141760] radeon 0000:01:00.0: GPU lockup (waiting for 0x0000000000073db9) [ 769.141768] radeon 0000:01:00.0: failed to get a new IB (-35) [ 769.141772] [drm:radeon_cs_ib_vm_chunk] *ERROR* Failed to get ib ! Crash #3 [ 125.411256] radeon 0000:01:00.0: GPU lockup CP stall for more than 10000msec [ 125.411265] radeon 0000:01:00.0: GPU lockup (waiting for 0x0000000000014894) [ 125.411273] radeon 0000:01:00.0: failed to get a new IB (-35) [ 125.411278] [drm:radeon_cs_ib_vm_chunk] *ERROR* Failed to get ib ! [ 125.430578] radeon 0000:01:00.0: sa_manager is not empty, clearing anyway [ 125.640276] radeon 0000:01:00.0: Saved 96301 dwords of commands on ring 0. [ 125.640416] radeon 0000:01:00.0: GPU softreset: 0x000000CD [ 125.640418] radeon 0000:01:00.0: GRBM_STATUS = 0xE5D04028 [ 125.640420] radeon 0000:01:00.0: GRBM_STATUS_SE0 = 0xEE400000 [ 125.640423] radeon 0000:01:00.0: GRBM_STATUS_SE1 = 0xEE400000 [ 125.640425] radeon 0000:01:00.0: SRBM_STATUS = 0x200046C0 [ 125.640535] radeon 0000:01:00.0: SRBM_STATUS2 = 0x00000000 [ 125.640538] radeon 0000:01:00.0: R_008674_CP_STALLED_STAT1 = 0x00000000 [ 125.640540] radeon 0000:01:00.0: R_008678_CP_STALLED_STAT2 = 0x00018000 [ 125.640542] radeon 0000:01:00.0: R_00867C_CP_BUSY_STAT = 0x00408002 [ 125.640544] radeon 0000:01:00.0: R_008680_CP_STAT = 0x84038643 [ 125.640546] radeon 0000:01:00.0: R_00D034_DMA_STATUS_REG = 0x60C83146 [ 125.640548] radeon 0000:01:00.0: R_00D834_DMA_STATUS_REG = 0x44C83D57 [ 125.640551] radeon 0000:01:00.0: VM_CONTEXT1_PROTECTION_FAULT_ADDR 0x00000000 [ 125.640553] radeon 0000:01:00.0: VM_CONTEXT1_PROTECTION_FAULT_STATUS 0x00000000 [ 125.645027] radeon 0000:01:00.0: GRBM_SOFT_RESET=0x0000DDFF [ 125.645080] radeon 0000:01:00.0: SRBM_SOFT_RESET=0x00108100 [ 125.646226] radeon 0000:01:00.0: GRBM_STATUS = 0x00003028 [ 125.646228] radeon 0000:01:00.0: GRBM_STATUS_SE0 = 0x00000006 [ 125.646230] radeon 0000:01:00.0: GRBM_STATUS_SE1 = 0x00000006 [ 125.646232] radeon 0000:01:00.0: SRBM_STATUS = 0x200008C0 [ 125.646343] radeon 0000:01:00.0: SRBM_STATUS2 = 0x00000000 [ 125.646345] radeon 0000:01:00.0: R_008674_CP_STALLED_STAT1 = 0x00000000 [ 125.646347] radeon 0000:01:00.0: R_008678_CP_STALLED_STAT2 = 0x00000000 [ 125.646349] radeon 0000:01:00.0: R_00867C_CP_BUSY_STAT = 0x00000000 [ 125.646351] radeon 0000:01:00.0: R_008680_CP_STAT = 0x00000000 [ 125.646353] radeon 0000:01:00.0: R_00D034_DMA_STATUS_REG = 0x44C83D57 [ 125.646355] radeon 0000:01:00.0: R_00D834_DMA_STATUS_REG = 0x44C83D57 [ 125.646479] radeon 0000:01:00.0: GPU reset succeeded, trying to resume Although the last log stated the GPU reset was successful, the system never recovered from the crash. Between those two mesa commits, based on the kernel log output, I only see a possible culprit, which could be a81beee37e0dd7b75422448420e8e8b0b4b76c1e. My PC specs are as follows (taken from steam's system info): Información sobre el procesador: Fabricante: AuthenticAMD CPU Family: 0x15 CPU Model: 0x1 CPU Stepping: 0x2 CPU Type: 0x0 Velocidad: 3600 Mhz Procesadores lógicos 8 Procesadores físicos 8 HyperThreading: No compatible FCMOV: Compatible SSE2: Compatible SSE3: Compatible SSSE3: Compatible SSE4a: Compatible SSE41: Compatible SSE42: Compatible Información sobre la red: Velocidad de la red: Versión del sistema operativo: Ubuntu 13.04 (64 bits) Nombre de kernel: Linux Versión de kernel: 3.11.0-031100-generic Editor de X Server: The X.Org Foundation Versión de X Server: 11303000 Gestor X Window: KWin Versión del runtime de Steam: steam-runtime-release_2013-09-05 Tarjeta de vídeo: Controlador: X.Org Gallium 0.4 on AMD PITCAIRN Versión de controlador: 2.1 Mesa 9.3.0-devel (git-505fad0 raring-oibaf-ppa) OpenGL Version: 2.1 Densidad de color del escritorio: 24 bits por píxel Frecuencia de actualización del monitor: 60 Hz Identificador del fabricante: 0x1002 Identificador del dispositivo: 0x6818 Número de monitores: 1 Número de tarjetas de vídeo lógicas: 1 Resolución de pantalla principal: 1920 x 1080 Resolución de escritorio: 1920 x 1080 Tamaño de pantalla principal: 18,78" x 10,55" (21,54" diag) 47,7cm x 26,8cm (54,7cm diag) No se ha detectado la memoria VRAM principal Tarjeta de sonido: Dispositivo de sonido: Realtek ALC889 Memoria: RAM: 15993 Mb Varios: Idioma de la IU: Español LANG: es_ES.UTF-8 Micrófono: Not set Espacio total en disco disponible: 469324 MB Bloque libre más grande en el disco: 187784 MB Software Instalado: Informes de fallos recientes: The GPU is a Radeon HD 7870. VRAM is 2 GB. llvm's version is 3.3-5ubuntu1~r~gd, and libdrm is at version 2.4.46+git1309121700.b6da44, both installed from oibaf's ppa. -- You are receiving this mail because: You are the assignee for the bug.

1 13

Re: [Linaro-mm-sig] [RFC 0/1] drm/pl111: Initial drm/kms driver for pl111
by Daniel Stone 14 Sep '13

14 Sep '13

Hi, On Tue, 2013-08-06 at 12:31 +0100, Tom Cooksey wrote: > > >> On Fri, Jul 26, 2013 at 11:58 AM, Tom Cooksey <tom.cooksey(a)arm.com> > > >> wrote: > > that was part of the reason to punt this problem to userspace ;-) > > > > In practice, the kernel drivers doesn't usually know too much about > > the dimensions/format/etc.. that is really userspace level knowledge. > > There are a few exceptions when the kernel needs to know how to setup > > GTT/etc for tiled buffers, but normally this sort of information is up > > at the next level up (userspace, and drm_framebuffer in case of > > scanout). Userspace media frameworks like GStreamer already have a > > concept of format/caps negotiation. For non-display<->gpu sharing, I > > think this is probably where this sort of constraint negotiation > > should be handled. Egads. GStreamer's caps negotiation is already close to unbounded time; seems like most of the optimisation work that goes into it these days is all about _reducing_ the complexity of caps negotiation! > I agree that user-space will know which devices will access the buffer > and thus can figure out at least a common pixel format. Hm, are you sure about that? The answer is yes for 'userspace' as a broad handwave, but not necessarily for individual processes. Take, for instance, media decode through GStreamer, being displayed by Wayland using a KMS plane/overlay/sprite/cursor/etc. The media player knows that the buffers are coming from the decode engine, and Wayland knows that the buffers are going to a KMS plane, but neither of them knows the full combination of the two. Though this kinda feeds into an idea I've been kicking around for a while, which is an 'optimal hint' mechanism in the Wayland protocol. So for our hypothetical dmabuf-using protocol, we'd start off with buffers which satisfied all the constraints of our media decode engine, but perhaps just the GPU rather than display controller. At this point, we'd note that we could place the video in a plane if only the buffers were better-allocated, and send an event to the client letting it know how to tweak its buffer allocation for more optimal display. But ... > Though I'm not > so sure userspace can figure out more low-level details like alignment > and placement in physical memory, etc. > > Anyway, assuming user-space can figure out how a buffer should be > stored in memory, how does it indicate this to a kernel driver and > actually allocate it? Which ioctl on which device does user-space > call, with what parameters? Are you suggesting using something like > ION which exposes the low-level details of how buffers are laid out in > physical memory to userspace? If not, what? ... this is still rather unresolved. ;) Cheers, Daniel > > Cheers, > > Tom > > > > > > > _______________________________________________ > Linaro-mm-sig mailing list > Linaro-mm-sig(a)lists.linaro.org > http://lists.linaro.org/mailman/listinfo/linaro-mm-sig

1 0

[Patch] drm/nouveau: nouveau/nouveau_abi16.c does not return offset of allocated notifier
by Bob Gleitsmann 14 Sep '13

14 Sep '13

Hi, The following patch fixes problems retrieving query results. I have tested it on nv40 - 6800 Ultra. Best Wishes, Bob --- a/drivers/gpu/drm/nouveau/nouveau_abi16.c +++ b/drivers/gpu/drm/nouveau/nouveau_abi16.c @@ -445,6 +445,7 @@ nouveau_abi16_ioctl_notifierobj_alloc(ABI16_IOCTL_ARGS) sizeof(args), &object); if (ret) goto done; + info->offset = ntfy->node->offset; done: if (ret)

1 0

[PATCH] drm/radeon: fix panel scaling with eDP and LVDS bridges
by Alex Deucher 13 Sep '13

13 Sep '13

We were using the wrong set_properly callback so we always ended up with Full scaling even if something else (Center or Full aspect) was selected. Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Cc: stable(a)vger.kernel.org --- drivers/gpu/drm/radeon/radeon_connectors.c | 34 +++++++++++++++++++++++++++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c index f7c8c6e..79159b5 100644 --- a/drivers/gpu/drm/radeon/radeon_connectors.c +++ b/drivers/gpu/drm/radeon/radeon_connectors.c @@ -1504,6 +1504,24 @@ static const struct drm_connector_funcs radeon_dp_connector_funcs = { .force = radeon_dvi_force, }; +static const struct drm_connector_funcs radeon_edp_connector_funcs = { + .dpms = drm_helper_connector_dpms, + .detect = radeon_dp_detect, + .fill_modes = drm_helper_probe_single_connector_modes, + .set_property = radeon_lvds_set_property, + .destroy = radeon_dp_connector_destroy, + .force = radeon_dvi_force, +}; + +static const struct drm_connector_funcs radeon_lvds_bridge_connector_funcs = { + .dpms = drm_helper_connector_dpms, + .detect = radeon_dp_detect, + .fill_modes = drm_helper_probe_single_connector_modes, + .set_property = radeon_lvds_set_property, + .destroy = radeon_dp_connector_destroy, + .force = radeon_dvi_force, +}; + void radeon_add_atom_connector(struct drm_device *dev, uint32_t connector_id, @@ -1595,8 +1613,6 @@ radeon_add_atom_connector(struct drm_device *dev, goto failed; radeon_dig_connector->igp_lane_info = igp_lane_info; radeon_connector->con_priv = radeon_dig_connector; - drm_connector_init(dev, &radeon_connector->base, &radeon_dp_connector_funcs, connector_type); - drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs); if (i2c_bus->valid) { /* add DP i2c bus */ if (connector_type == DRM_MODE_CONNECTOR_eDP) @@ -1613,6 +1629,10 @@ radeon_add_atom_connector(struct drm_device *dev, case DRM_MODE_CONNECTOR_VGA: case DRM_MODE_CONNECTOR_DVIA: default: + drm_connector_init(dev, &radeon_connector->base, + &radeon_dp_connector_funcs, connector_type); + drm_connector_helper_add(&radeon_connector->base, + &radeon_dp_connector_helper_funcs); connector->interlace_allowed = true; connector->doublescan_allowed = true; radeon_connector->dac_load_detect = true; @@ -1625,6 +1645,10 @@ radeon_add_atom_connector(struct drm_device *dev, case DRM_MODE_CONNECTOR_HDMIA: case DRM_MODE_CONNECTOR_HDMIB: case DRM_MODE_CONNECTOR_DisplayPort: + drm_connector_init(dev, &radeon_connector->base, + &radeon_dp_connector_funcs, connector_type); + drm_connector_helper_add(&radeon_connector->base, + &radeon_dp_connector_helper_funcs); drm_object_attach_property(&radeon_connector->base.base, rdev->mode_info.underscan_property, UNDERSCAN_OFF); @@ -1652,6 +1676,10 @@ radeon_add_atom_connector(struct drm_device *dev, break; case DRM_MODE_CONNECTOR_LVDS: case DRM_MODE_CONNECTOR_eDP: + drm_connector_init(dev, &radeon_connector->base, + &radeon_lvds_bridge_connector_funcs, connector_type); + drm_connector_helper_add(&radeon_connector->base, + &radeon_dp_connector_helper_funcs); drm_object_attach_property(&radeon_connector->base.base, dev->mode_config.scaling_mode_property, DRM_MODE_SCALE_FULLSCREEN); @@ -1830,7 +1858,7 @@ radeon_add_atom_connector(struct drm_device *dev, goto failed; radeon_dig_connector->igp_lane_info = igp_lane_info; radeon_connector->con_priv = radeon_dig_connector; - drm_connector_init(dev, &radeon_connector->base, &radeon_dp_connector_funcs, connector_type); + drm_connector_init(dev, &radeon_connector->base, &radeon_edp_connector_funcs, connector_type); drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs); if (i2c_bus->valid) { /* add DP i2c bus */ -- 1.8.3.1

1 0

Moving a bug upstream per downstream request, emailing the maintainers
by John Hupp 13 Sep '13

13 Sep '13

[1.] One line summary of the problem: Flash 11.2 content displays in shades of green and purple only, and in a horizontally compressed space [2.] Full description of the problem/report: The full downstream bug report is at https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1212455 , but my description from there: In my testing with the Intel driver using its default acceleration: - Flash 11.2 works on Quantal with the 3.5 kernel - Flash 11.2 works on Raring with the 3.5.0-17 kernel (though it boots to a low-res desktop with a frozen pointer) - Flash 11.2 works on Raring also with the 3.6.11-030611 or 3.7.10-030710 mainline kernels - Flash 11.8 works on Raring with the 3.8 kernel (in Chrome) - Flash 11.2 fails on Raring with the 3.8 kernel - Flash 11.2 fails on Raring with the latest mainline kernel, 3.11.0-031100rc5 - Flash 11.2 fails on Saucy alpha 2 with its default kernel Disabling Flash *hardware* acceleration altogether (via R-click in the Flash display window: Settings: General tab) did not fix the problem. WORKAROUND: Setting the Intel driver's acceleration method to UXA rather than its default SNA *always* fixes the Flash problem, but causes a garbled login screen under LightDM that so far has no workaround. I also tried one possible fix for the default Intel SNA acceleration using the TearFree option. I created /etc/X11/xorg.conf.d/20-intel.conf with contents: Section "Device" Identifier "Intel Graphics" Driver "intel" Option "AccelMethod" "sna" Option "TearFree" "true" EndSection But this had no effect. [3.] Keywords (i.e., modules, networking, kernel): I'm a newbie hanging on by my fingernails here -- I have no idea about appropriate keywords. [4.] Kernel version (from /proc/version): Linux version 3.11.0-031100rc5-generic (apw@gomeisa) (gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) ) #201308112135 SMP Mon Aug 12 01:44:44 UTC 2013 [5.] Output of Oops.. message (if applicable) with symbolic information resolved (see Documentation/oops-tracing.txt) [6.] A small shell script or example program which triggers the problem (if possible) [7.] Environment Description: Ubuntu 13.04 Release: 13.04 [7.1.] Software (add the output of the ver_linux script here) If some fields are empty or look unusual you may have an old version. Compare to the current minimal requirements in Documentation/Changes. Linux Dimension 3.11.0-031100rc5-generic #201308112135 SMP Mon Aug 12 01:44:44 UTC 2013 i686 i686 i686 GNU/Linux Gnu C /usr/src/linux-headers-3.11.0-031100rc5-generic/scripts/ver_linux: binutils util-linux 2.20.1 mount support module-init-tools 9 e2fsprogs 1.42.5 PPP 2.4.5 Linux C Library 2.17 Dynamic linker (ldd) 2.17 Procps 3.3.3 Net-tools 1.60 Kbd 1.15.5 Sh-utils 8.20 wireless-tools 30 Modules Loaded nls_iso8859_1 usb_storage snd_intel8x0 snd_ac97_codec ac97_bus bnep snd_pcm rfcomm bluetooth ppdev snd_page_alloc gpio_ich snd_seq_midi snd_seq_midi_event snd_rawmidi snd_seq dcdbas snd_seq_device i915 snd_timer video snd psmouse drm_kms_helper serio_raw soundcore drm i2c_algo_bit parport_pc lpc_ich shpchp lp mac_hid parport b44 ssb mii floppy [7.2.] Processor information (from /proc/cpuinfo): processor : 0 vendor_id : GenuineIntel cpu family : 15 model : 2 model name : Intel(R) Celeron(R) CPU 2.40GHz stepping : 9 microcode : 0x17 cpu MHz : 2392.420 cache size : 128 KB fdiv_bug : no f00f_bug : no coma_bug : no fpu : yes fpu_exception : yes cpuid level : 2 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe pebs bts cid xtpr bogomips : 4784.84 clflush size : 64 cache_alignment : 128 address sizes : 36 bits physical, 32 bits virtual power management: [7.3.] Module information (from /proc/modules): nls_iso8859_1 12617 1 - Live 0x00000000 usb_storage 48631 1 - Live 0x00000000 snd_intel8x0 33458 1 - Live 0x00000000 snd_ac97_codec 110295 1 snd_intel8x0, Live 0x00000000 ac97_bus 12642 1 snd_ac97_codec, Live 0x00000000 bnep 19143 2 - Live 0x00000000 snd_pcm 94597 2 snd_intel8x0,snd_ac97_codec, Live 0x00000000 rfcomm 58965 0 - Live 0x00000000 bluetooth 337841 10 bnep,rfcomm, Live 0x00000000 ppdev 17423 0 - Live 0x00000000 snd_page_alloc 18398 2 snd_intel8x0,snd_pcm, Live 0x00000000 gpio_ich 13278 0 - Live 0x00000000 snd_seq_midi 13132 0 - Live 0x00000000 snd_seq_midi_event 14475 1 snd_seq_midi, Live 0x00000000 snd_rawmidi 25157 1 snd_seq_midi, Live 0x00000000 snd_seq 55716 2 snd_seq_midi,snd_seq_midi_event, Live 0x00000000 dcdbas 14456 0 - Live 0x00000000 snd_seq_device 14137 3 snd_seq_midi,snd_rawmidi,snd_seq, Live 0x00000000 i915 606994 2 - Live 0x00000000 snd_timer 28930 2 snd_pcm,snd_seq, Live 0x00000000 video 19046 1 i915, Live 0x00000000 snd 61270 10 snd_intel8x0,snd_ac97_codec,snd_pcm,snd_seq_midi,snd_rawmidi,snd_seq,snd_seq_device,snd_timer, Live 0x00000000 psmouse 92607 0 - Live 0x00000000 drm_kms_helper 47306 1 i915, Live 0x00000000 serio_raw 13189 0 - Live 0x00000000 soundcore 12600 1 snd, Live 0x00000000 drm 247743 3 i915,drm_kms_helper, Live 0x00000000 i2c_algo_bit 13316 1 i915, Live 0x00000000 parport_pc 32114 1 - Live 0x00000000 lpc_ich 16987 0 - Live 0x00000000 shpchp 32265 0 - Live 0x00000000 lp 13359 0 - Live 0x00000000 mac_hid 13077 0 - Live 0x00000000 parport 40930 3 ppdev,parport_pc,lp, Live 0x00000000 b44 31223 0 - Live 0x00000000 ssb 56410 1 b44, Live 0x00000000 mii 13693 1 b44, Live 0x00000000 floppy 60183 0 - Live 0x00000000 [7.4.] Loaded driver and hardware information (/proc/ioports, /proc/iomem) 0000-001f : dma1 0020-0021 : pic1 0040-0043 : timer0 0050-0053 : timer1 0060-0060 : keyboard 0064-0064 : keyboard 0070-007f : rtc0 0080-008f : dma page reg 00a0-00a1 : pic2 00c0-00df : dma2 00f0-00ff : fpu 0170-0177 : 0000:00:1f.1 0170-0177 : ata_piix 01f0-01f7 : 0000:00:1f.1 01f0-01f7 : ata_piix 0376-0376 : 0000:00:1f.1 0376-0376 : ata_piix 0378-037a : parport0 03f2-03f2 : floppy 03f4-03f5 : floppy 03f6-03f6 : 0000:00:1f.1 03f6-03f6 : ata_piix 03f7-03f7 : floppy 03f8-03ff : serial 0778-077a : parport0 0800-0803 : ACPI PM1a_EVT_BLK 0804-0805 : ACPI PM1a_CNT_BLK 0808-080b : ACPI PM_TMR 0810-0815 : ACPI CPU throttle 0828-082f : ACPI GPE0_BLK 0830-0833 : iTCO_wdt 0860-087f : iTCO_wdt 0880-08bf : gpio_ich 0880-08bf : 0000:00:1f.0 0c00-0c7f : pnp 00:0a 0cf8-0cff : PCI conf1 d000-dfff : PCI Bus 0000:01 de00-deff : 0000:01:05.0 de08-de0f : serial de10-de17 : serial de18-de1f : serial de20-de27 : serial de28-de2f : serial de60-de67 : serial eda0-edbf : 0000:00:1f.3 edc0-edff : 0000:00:1f.5 edc0-edff : Intel 82801DB-ICH4 ee00-eeff : 0000:00:1f.5 ee00-eeff : Intel 82801DB-ICH4 ff40-ff5f : 0000:00:1d.2 ff40-ff5f : uhci_hcd ff60-ff7f : 0000:00:1d.1 ff60-ff7f : uhci_hcd ff80-ff9f : 0000:00:1d.0 ff80-ff9f : uhci_hcd ffa0-ffaf : 0000:00:1f.1 ffa0-ffaf : ata_piix 00000000-00000fff : reserved 00001000-0009ffff : System RAM 000a0000-000bffff : Video RAM area 000c0000-000cb7ff : Video ROM 000cd000-000cffff : Adapter ROM 000f0000-000fffff : reserved 000f0000-000fffff : System ROM 00100000-3f773fff : System RAM 01000000-016691e2 : Kernel code 016691e3-019bcfbf : Kernel data 01aa1000-01b94fff : Kernel bss 3f774000-3f775fff : ACPI Non-volatile Storage 3f776000-3f796fff : ACPI Tables 3f797000-3f7fffff : reserved 3f800000-3fffffff : RAM buffer e8000000-efffffff : 0000:00:02.0 f0000000-f7ffffff : 0000:00:00.0 fe900000-feafffff : PCI Bus 0000:01 fe9fd000-fe9fdfff : 0000:01:05.0 fe9fe000-fe9fffff : 0000:01:09.0 fe9fe000-fe9fffff : b44 fea00000-fea03fff : 0000:01:09.0 feb7f900-feb7f9ff : 0000:00:1f.5 feb7f900-feb7f9ff : Intel 82801DB-ICH4 feb7fa00-feb7fbff : 0000:00:1f.5 feb7fa00-feb7fbff : Intel 82801DB-ICH4 feb7fc00-feb7ffff : 0000:00:1f.1 feb80000-febfffff : 0000:00:02.0 fec00000-fec0ffff : reserved fec00000-fec003ff : IOAPIC 0 fecf0000-fecf0fff : pnp 00:00 fee00000-fee0ffff : reserved fee00000-fee0ffff : pnp 00:00 fee00000-fee00fff : Local APIC ffa80800-ffa80bff : 0000:00:1d.7 ffa80800-ffa80bff : ehci_hcd ffb00000-ffffffff : reserved ffb00000-ffbfffff : pnp 00:00 ffc00000-ffffffff : pnp 00:00 [7.5.] PCI information ('lspci -vvv' as root) 00:00.0 Host bridge: Intel Corporation 82845G/GL[Brookdale-G]/GE/PE DRAM Controller/Host-Hub Interface (rev 01) Subsystem: Dell Device 0160 Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort+ >SERR- <PERR- INTx- Latency: 0 Region 0: Memory at f0000000 (32-bit, prefetchable) [size=128M] Capabilities: [e4] Vendor Specific Information: Len=05 <?> Kernel driver in use: agpgart-intel 00:02.0 VGA compatible controller: Intel Corporation 82845G/GL[Brookdale-G]/GE Chipset Integrated Graphics Device (rev 01) (prog-if 00 [VGA controller]) Subsystem: Dell Device 0160 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0 Interrupt: pin A routed to IRQ 16 Region 0: Memory at e8000000 (32-bit, prefetchable) [size=128M] Region 1: Memory at feb80000 (32-bit, non-prefetchable) [size=512K] Expansion ROM at <unassigned> [disabled] Capabilities: [d0] Power Management version 1 Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Kernel driver in use: i915 00:1d.0 USB controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #1 (rev 01) (prog-if 00 [UHCI]) Subsystem: Dell Device 0160 Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0 Interrupt: pin A routed to IRQ 16 Region 4: I/O ports at ff80 [size=32] Kernel driver in use: uhci_hcd 00:1d.1 USB controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #2 (rev 01) (prog-if 00 [UHCI]) Subsystem: Dell Device 0160 Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0 Interrupt: pin B routed to IRQ 19 Region 4: I/O ports at ff60 [size=32] Kernel driver in use: uhci_hcd 00:1d.2 USB controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #3 (rev 01) (prog-if 00 [UHCI]) Subsystem: Dell Device 0160 Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0 Interrupt: pin C routed to IRQ 18 Region 4: I/O ports at ff40 [size=32] Kernel driver in use: uhci_hcd 00:1d.7 USB controller: Intel Corporation 82801DB/DBM (ICH4/ICH4-M) USB2 EHCI Controller (rev 01) (prog-if 20 [EHCI]) Subsystem: Dell Device 0160 Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0 Interrupt: pin D routed to IRQ 23 Region 0: Memory at ffa80800 (32-bit, non-prefetchable) [size=1K] Capabilities: [50] Power Management version 2 Flags: PMEClk- DSI- D1- D2- AuxCurrent=375mA PME(D0+,D1-,D2-,D3hot+,D3cold+) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME+ Capabilities: [58] Debug port: BAR=1 offset=0080 Kernel driver in use: ehci-pci 00:1e.0 PCI bridge: Intel Corporation 82801 PCI Bridge (rev 81) (prog-if 00 [Normal decode]) Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort+ <TAbort- <MAbort- >SERR- <PERR+ INTx- Latency: 0 Bus: primary=00, secondary=01, subordinate=01, sec-latency=32 I/O behind bridge: 0000d000-0000dfff Memory behind bridge: fe900000-feafffff Prefetchable memory behind bridge: fff00000-000fffff Secondary status: 66MHz- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- <SERR- <PERR- BridgeCtl: Parity- SERR+ NoISA- VGA- MAbort- >Reset- FastB2B- PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn- 00:1f.0 ISA bridge: Intel Corporation 82801DB/DBL (ICH4/ICH4-L) LPC Interface Bridge (rev 01) Control: I/O+ Mem+ BusMaster+ SpecCycle+ MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0 Kernel driver in use: lpc_ich 00:1f.1 IDE interface: Intel Corporation 82801DB (ICH4) IDE Controller (rev 01) (prog-if 8a [Master SecP PriP]) Subsystem: Dell Device 0160 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0 Interrupt: pin A routed to IRQ 18 Region 0: I/O ports at 01f0 [size=8] Region 1: I/O ports at 03f4 [size=1] Region 2: I/O ports at 0170 [size=8] Region 3: I/O ports at 0374 [size=1] Region 4: I/O ports at ffa0 [size=16] Region 5: Memory at feb7fc00 (32-bit, non-prefetchable) [size=1K] Kernel driver in use: ata_piix 00:1f.3 SMBus: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) SMBus Controller (rev 01) Subsystem: Dell Device 0160 Control: I/O+ Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Interrupt: pin B routed to IRQ 3 Region 4: I/O ports at eda0 [size=32] 00:1f.5 Multimedia audio controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Audio Controller (rev 01) Subsystem: Dell Device 0160 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0 Interrupt: pin B routed to IRQ 17 Region 0: I/O ports at ee00 [size=256] Region 1: I/O ports at edc0 [size=64] Region 2: Memory at feb7fa00 (32-bit, non-prefetchable) [size=512] Region 3: Memory at feb7f900 (32-bit, non-prefetchable) [size=256] Capabilities: [50] Power Management version 2 Flags: PMEClk- DSI- D1- D2- AuxCurrent=375mA PME(D0+,D1-,D2-,D3hot+,D3cold+) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Kernel driver in use: snd_intel8x0 01:05.0 Modem: Intel Corporation FA82537EP 56K V.92 Data/Fax Modem PCI (rev 04) (prog-if 00 [Generic]) Subsystem: Dell Device 1000 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping+ SERR+ FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 64 (250ns min, 15500ns max), Cache Line Size: 64 bytes Interrupt: pin A routed to IRQ 17 Region 0: Memory at fe9fd000 (32-bit, non-prefetchable) [size=4K] Region 1: I/O ports at de00 [size=256] Capabilities: [80] Power Management version 2 Flags: PMEClk- DSI- D1- D2- AuxCurrent=55mA PME(D0+,D1-,D2-,D3hot+,D3cold+) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Kernel driver in use: serial 01:09.0 Ethernet controller: Broadcom Corporation BCM4401 100Base-T (rev 01) Subsystem: Dell Device 8127 Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort+ <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 64 Interrupt: pin A routed to IRQ 17 Region 0: Memory at fe9fe000 (32-bit, non-prefetchable) [size=8K] Expansion ROM at fea00000 [disabled] [size=16K] Capabilities: [40] Power Management version 2 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA PME(D0+,D1+,D2+,D3hot+,D3cold+) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=2 PME- Kernel driver in use: b44 [7.6.] SCSI information (from /proc/scsi/scsi) Attached devices: Host: scsi0 Channel: 00 Id: 00 Lun: 00 Vendor: ATA Model: WDC WD300EB-75CP Rev: 06.0 Type: Direct-Access ANSI SCSI revision: 05 Host: scsi1 Channel: 00 Id: 00 Lun: 00 Vendor: SONY Model: DVD-ROM DDU1615 Rev: FDS1 Type: CD-ROM ANSI SCSI revision: 05 Host: scsi2 Channel: 00 Id: 00 Lun: 00 Vendor: Simple Model: Bonzai Xpress Rev: 0.00 Type: Direct-Access ANSI SCSI revision: 02 [7.7.] Other information that might be relevant to the problem (please look in /proc and include all information that you think to be relevant): ls /proc: 1 10 1007 1016 1018 11 1109 12 1220 13 1334 135 1381 14 1421 1424 1425 1438 1445 1449 1453 1458 1459 1463 1465 1467 1470 1475 1480 1494 15 1509 1511 1516 1523 1526 1529 1541 1546 1550 1564 1566 1571 1586 16 1611 1614 1615 1616 1617 1618 1642 1645 1646 1647 17 18 19 1944 1952 1962 1970 1981 1989 1992 2 20 21 22 223 224 225 23 24 25 26 27 28 29 3 30 307 318 323 4 41 43 44 46 47 5 531 66 667 67 684 687 7 706 736 759 775 8 802 885 894 9 906 910 915 951 971 983 994 996 998 acpi asound buddyinfo bus cgroups cmdline consoles cpuinfo crypto devices diskstats dma dri driver execdomains fb filesystems fs interrupts iomem ioports irq kallsyms kcore key-users kmsg kpagecount kpageflags latency_stats loadavg locks mdstat meminfo misc modules mounts mtrr net pagetypeinfo partitions sched_debug schedstat scsi self slabinfo softirqs stat swaps sys sysrq-trigger sysvipc timer_list timer_stats tty uptime version vmallocinfo vmstat zoneinfo [X.] Other notes, patches, fixes, workarounds:

2 3

[PATCH] drm/radeon/dpm: rework auto performance level enable
by Alex Deucher 13 Sep '13

13 Sep '13

Calling force_performance_level() from set_power_state() doesn't work on some asics because the current power state pointer has not been properly updated at that point. Move the calls to force_performance_level() out of the asic specific set_power_state() functions and into the main power state sequence. Fixes dpm resume on SI. Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> --- drivers/gpu/drm/radeon/btc_dpm.c | 6 ------ drivers/gpu/drm/radeon/ci_dpm.c | 6 ------ drivers/gpu/drm/radeon/cypress_dpm.c | 6 ------ drivers/gpu/drm/radeon/kv_dpm.c | 1 - drivers/gpu/drm/radeon/ni_dpm.c | 6 ------ drivers/gpu/drm/radeon/radeon_pm.c | 14 +++++++++----- drivers/gpu/drm/radeon/rv6xx_dpm.c | 2 -- drivers/gpu/drm/radeon/rv770_dpm.c | 6 ------ drivers/gpu/drm/radeon/si_dpm.c | 6 ------ drivers/gpu/drm/radeon/sumo_dpm.c | 2 -- drivers/gpu/drm/radeon/trinity_dpm.c | 1 - 11 files changed, 9 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/drm/radeon/btc_dpm.c b/drivers/gpu/drm/radeon/btc_dpm.c index 084e694..05ff315 100644 --- a/drivers/gpu/drm/radeon/btc_dpm.c +++ b/drivers/gpu/drm/radeon/btc_dpm.c @@ -2340,12 +2340,6 @@ int btc_dpm_set_power_state(struct radeon_device *rdev) return ret; } - ret = rv770_dpm_force_performance_level(rdev, RADEON_DPM_FORCED_LEVEL_AUTO); - if (ret) { - DRM_ERROR("rv770_dpm_force_performance_level failed\n"); - return ret; - } - return 0; } diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c index 3cce533..8996274 100644 --- a/drivers/gpu/drm/radeon/ci_dpm.c +++ b/drivers/gpu/drm/radeon/ci_dpm.c @@ -4748,12 +4748,6 @@ int ci_dpm_set_power_state(struct radeon_device *rdev) if (pi->pcie_performance_request) ci_notify_link_speed_change_after_state_change(rdev, new_ps, old_ps); - ret = ci_dpm_force_performance_level(rdev, RADEON_DPM_FORCED_LEVEL_AUTO); - if (ret) { - DRM_ERROR("ci_dpm_force_performance_level failed\n"); - return ret; - } - cik_update_cg(rdev, (RADEON_CG_BLOCK_GFX | RADEON_CG_BLOCK_MC | RADEON_CG_BLOCK_SDMA | diff --git a/drivers/gpu/drm/radeon/cypress_dpm.c b/drivers/gpu/drm/radeon/cypress_dpm.c index 95a66db..91bb470 100644 --- a/drivers/gpu/drm/radeon/cypress_dpm.c +++ b/drivers/gpu/drm/radeon/cypress_dpm.c @@ -2014,12 +2014,6 @@ int cypress_dpm_set_power_state(struct radeon_device *rdev) if (eg_pi->pcie_performance_request) cypress_notify_link_speed_change_after_state_change(rdev, new_ps, old_ps); - ret = rv770_dpm_force_performance_level(rdev, RADEON_DPM_FORCED_LEVEL_AUTO); - if (ret) { - DRM_ERROR("rv770_dpm_force_performance_level failed\n"); - return ret; - } - return 0; } diff --git a/drivers/gpu/drm/radeon/kv_dpm.c b/drivers/gpu/drm/radeon/kv_dpm.c index b98b9c9..7139906 100644 --- a/drivers/gpu/drm/radeon/kv_dpm.c +++ b/drivers/gpu/drm/radeon/kv_dpm.c @@ -1854,7 +1854,6 @@ int kv_dpm_set_power_state(struct radeon_device *rdev) RADEON_CG_BLOCK_BIF | RADEON_CG_BLOCK_HDP), true); - rdev->pm.dpm.forced_level = RADEON_DPM_FORCED_LEVEL_AUTO; return 0; } diff --git a/drivers/gpu/drm/radeon/ni_dpm.c b/drivers/gpu/drm/radeon/ni_dpm.c index f7b625c..6c398a4 100644 --- a/drivers/gpu/drm/radeon/ni_dpm.c +++ b/drivers/gpu/drm/radeon/ni_dpm.c @@ -3865,12 +3865,6 @@ int ni_dpm_set_power_state(struct radeon_device *rdev) return ret; } - ret = ni_dpm_force_performance_level(rdev, RADEON_DPM_FORCED_LEVEL_AUTO); - if (ret) { - DRM_ERROR("ni_dpm_force_performance_level failed\n"); - return ret; - } - return 0; } diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c index d41ac8a..87e1d69 100644 --- a/drivers/gpu/drm/radeon/radeon_pm.c +++ b/drivers/gpu/drm/radeon/radeon_pm.c @@ -917,10 +917,13 @@ static void radeon_dpm_change_power_state_locked(struct radeon_device *rdev) radeon_dpm_post_set_power_state(rdev); - /* force low perf level for thermal */ - if (rdev->pm.dpm.thermal_active && - rdev->asic->dpm.force_performance_level) { - radeon_dpm_force_performance_level(rdev, RADEON_DPM_FORCED_LEVEL_LOW); + if (rdev->asic->dpm.force_performance_level) { + if (rdev->pm.dpm.thermal_active) + /* force low perf level for thermal */ + radeon_dpm_force_performance_level(rdev, RADEON_DPM_FORCED_LEVEL_LOW); + else + /* otherwise, enable auto */ + radeon_dpm_force_performance_level(rdev, RADEON_DPM_FORCED_LEVEL_AUTO); } done: @@ -1149,9 +1152,10 @@ static int radeon_pm_init_dpm(struct radeon_device *rdev) { int ret; - /* default to performance state */ + /* default to balanced state */ rdev->pm.dpm.state = POWER_STATE_TYPE_BALANCED; rdev->pm.dpm.user_state = POWER_STATE_TYPE_BALANCED; + rdev->pm.dpm.forced_level = RADEON_DPM_FORCED_LEVEL_AUTO; rdev->pm.default_sclk = rdev->clock.default_sclk; rdev->pm.default_mclk = rdev->clock.default_mclk; rdev->pm.current_sclk = rdev->clock.default_sclk; diff --git a/drivers/gpu/drm/radeon/rv6xx_dpm.c b/drivers/gpu/drm/radeon/rv6xx_dpm.c index ab1f201..5811d27 100644 --- a/drivers/gpu/drm/radeon/rv6xx_dpm.c +++ b/drivers/gpu/drm/radeon/rv6xx_dpm.c @@ -1758,8 +1758,6 @@ int rv6xx_dpm_set_power_state(struct radeon_device *rdev) rv6xx_set_uvd_clock_after_set_eng_clock(rdev, new_ps, old_ps); - rdev->pm.dpm.forced_level = RADEON_DPM_FORCED_LEVEL_AUTO; - return 0; } diff --git a/drivers/gpu/drm/radeon/rv770_dpm.c b/drivers/gpu/drm/radeon/rv770_dpm.c index 7282ce7..913b025 100644 --- a/drivers/gpu/drm/radeon/rv770_dpm.c +++ b/drivers/gpu/drm/radeon/rv770_dpm.c @@ -2064,12 +2064,6 @@ int rv770_dpm_set_power_state(struct radeon_device *rdev) rv770_program_dcodt_after_state_switch(rdev, new_ps, old_ps); rv770_set_uvd_clock_after_set_eng_clock(rdev, new_ps, old_ps); - ret = rv770_dpm_force_performance_level(rdev, RADEON_DPM_FORCED_LEVEL_AUTO); - if (ret) { - DRM_ERROR("rv770_dpm_force_performance_level failed\n"); - return ret; - } - return 0; } diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c index 5be9b4e..cfe5d4d 100644 --- a/drivers/gpu/drm/radeon/si_dpm.c +++ b/drivers/gpu/drm/radeon/si_dpm.c @@ -6075,12 +6075,6 @@ int si_dpm_set_power_state(struct radeon_device *rdev) return ret; } - ret = si_dpm_force_performance_level(rdev, RADEON_DPM_FORCED_LEVEL_AUTO); - if (ret) { - DRM_ERROR("si_dpm_force_performance_level failed\n"); - return ret; - } - si_update_cg(rdev, (RADEON_CG_BLOCK_GFX | RADEON_CG_BLOCK_MC | RADEON_CG_BLOCK_SDMA | diff --git a/drivers/gpu/drm/radeon/sumo_dpm.c b/drivers/gpu/drm/radeon/sumo_dpm.c index 864761c..96ea6db8 100644 --- a/drivers/gpu/drm/radeon/sumo_dpm.c +++ b/drivers/gpu/drm/radeon/sumo_dpm.c @@ -1319,8 +1319,6 @@ int sumo_dpm_set_power_state(struct radeon_device *rdev) if (pi->enable_dpm) sumo_set_uvd_clock_after_set_eng_clock(rdev, new_ps, old_ps); - rdev->pm.dpm.forced_level = RADEON_DPM_FORCED_LEVEL_AUTO; - return 0; } diff --git a/drivers/gpu/drm/radeon/trinity_dpm.c b/drivers/gpu/drm/radeon/trinity_dpm.c index 4beb999..7f998bf 100644 --- a/drivers/gpu/drm/radeon/trinity_dpm.c +++ b/drivers/gpu/drm/radeon/trinity_dpm.c @@ -1236,7 +1236,6 @@ int trinity_dpm_set_power_state(struct radeon_device *rdev) trinity_force_level_0(rdev); trinity_unforce_levels(rdev); trinity_set_uvd_clock_after_set_eng_clock(rdev, new_ps, old_ps); - rdev->pm.dpm.forced_level = RADEON_DPM_FORCED_LEVEL_AUTO; } trinity_release_mutex(rdev); -- 1.8.3.1

1 0

← Newer
1
...
71
72
73
74
75
76
77
...
83
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2013