dri-devel October 2014

dri-devel@lists.freedesktop.org

139 participants
947 discussions

[Bug 71051] Cannot suspend with radeon drivers.
by bugzilla-daemon＠bugzilla.kernel.org 10 Oct '14

10 Oct '14

https://bugzilla.kernel.org/show_bug.cgi?id=71051 --- Comment #15 from Hin-Tak Leung <htl10(a)users.sourceforge.net> --- (In reply to Hin-Tak Leung from comment #14) ... > To answer my own question, attachment 150801 [details] is in 3.17-rcX, so > will be in 3.17 proper... besides v3.17-rc6, it is also in v3.16.4 . -- You are receiving this mail because: You are watching the assignee of the bug.

1 0

[Bug 82050] New: R9270X pyrit benchmark perf regressions with latest kernel/llvm
by bugzilla-daemon＠freedesktop.org 10 Oct '14

10 Oct '14

https://bugs.freedesktop.org/show_bug.cgi?id=82050 Priority: medium Bug ID: 82050 Assignee: dri-devel(a)lists.freedesktop.org Summary: R9270X pyrit benchmark perf regressions with latest kernel/llvm Severity: normal Classification: Unclassified OS: All Reporter: adf.lists(a)gmail.com Hardware: Other Status: NEW Version: git Component: Drivers/Gallium/radeonsi Product: Mesa Don't really have time to bisect this but posting FYI. Maybe pyrit benchmark is the glxgears of benchmarks - if so please say so and I'll ignore it :-) Status Que for my R9 270X pyrit 0.3.0 since I got it in May has been around - Computed 75761.96 PMKs/s total. #1: 'OpenCL-Device 'AMD PITCAIRN'': 73256.9 PMKs/s (RTT 0.8) #2: 'CPU-Core (SSE2)': 743.3 PMKs/s (RTT 2.9) #3: 'CPU-Core (SSE2)': 741.3 PMKs/s (RTT 2.8) #4: 'CPU-Core (SSE2)': 740.2 PMKs/s (RTT 2.9) #5: 'Network-Clients': 0.0 PMKs/s (RTT 0.0) This was kernel agd5f drm-fixes-3.16-wip I noticed yesterday after trying agd5f drm-next-3.17-rebased-on-fixes that I lost around 10,000 PMKs/s with the newer kernel. Both were with yesterdays mesa but llvm was older say a couple of weeks. Updated llvm and mesa today and it's regressed more on both kernels - drm-fixes-3.16-wip Computed 58233.89 PMKs/s total. #1: 'OpenCL-Device 'AMD PITCAIRN'': 56076.6 PMKs/s (RTT 1.1) #2: 'CPU-Core (SSE2)': 753.6 PMKs/s (RTT 2.9) #3: 'CPU-Core (SSE2)': 754.5 PMKs/s (RTT 2.9) #4: 'CPU-Core (SSE2)': 753.0 PMKs/s (RTT 2.9) #5: 'Network-Clients': 0.0 PMKs/s (RTT 0.0) drm-next-3.17-rebased-on-fixes Computed 52379.38 PMKs/s total. #1: 'OpenCL-Device 'AMD PITCAIRN'': 48822.1 PMKs/s (RTT 1.2) #2: 'CPU-Core (SSE2)': 753.8 PMKs/s (RTT 2.9) #3: 'CPU-Core (SSE2)': 754.9 PMKs/s (RTT 3.0) #4: 'CPU-Core (SSE2)': 754.8 PMKs/s (RTT 2.9) #5: 'Network-Clients': 0.0 PMKs/s (RTT 0.0) -- You are receiving this mail because: You are the assignee for the bug.

1 80

[PATCH] drm/radeon: flush HDP in DMA ring test v2
by Christian König 10 Oct '14

10 Oct '14

From: Christian König <christian.koenig(a)amd.com> v1: Flush VRAM cache before each read when polling (r600_dma_ring_test only). v2 (chk): rebased on current drm-fixes, apply to CIK as well. Signed-off-by: Alexander Fyodorov <halcy at yandex.ru> Signed-off-by: Christian König <christian.koenig(a)amd.com> --- drivers/gpu/drm/radeon/cik_sdma.c | 1 + drivers/gpu/drm/radeon/r600_dma.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/radeon/cik_sdma.c b/drivers/gpu/drm/radeon/cik_sdma.c index c4ffa54..4c442a6 100644 --- a/drivers/gpu/drm/radeon/cik_sdma.c +++ b/drivers/gpu/drm/radeon/cik_sdma.c @@ -631,6 +631,7 @@ int cik_sdma_ring_test(struct radeon_device *rdev, radeon_ring_write(ring, upper_32_bits(rdev->vram_scratch.gpu_addr)); radeon_ring_write(ring, 1); /* number of DWs to follow */ radeon_ring_write(ring, 0xDEADBEEF); + cik_sdma_hdp_flush_ring_emit(rdev, ring->idx); radeon_ring_unlock_commit(rdev, ring, false); for (i = 0; i < rdev->usec_timeout; i++) { diff --git a/drivers/gpu/drm/radeon/r600_dma.c b/drivers/gpu/drm/radeon/r600_dma.c index a908daa..cef647a 100644 --- a/drivers/gpu/drm/radeon/r600_dma.c +++ b/drivers/gpu/drm/radeon/r600_dma.c @@ -255,6 +255,7 @@ int r600_dma_ring_test(struct radeon_device *rdev, radeon_ring_unlock_commit(rdev, ring, false); for (i = 0; i < rdev->usec_timeout; i++) { + r600_mmio_hdp_flush(rdev); tmp = readl(ptr); if (tmp == 0xDEADBEEF) break; -- 1.9.1

1 0

[Bug 81546] New: Radeon 7990: Output of most applications garbled, Gnome shell mosly fine
by bugzilla-daemon＠freedesktop.org 10 Oct '14

10 Oct '14

https://bugs.freedesktop.org/show_bug.cgi?id=81546 Priority: medium Bug ID: 81546 Assignee: dri-devel(a)lists.freedesktop.org Summary: Radeon 7990: Output of most applications garbled, Gnome shell mosly fine Severity: normal Classification: Unclassified OS: Linux (All) Reporter: mail(a)marcelschaal.de Hardware: x86-64 (AMD64) Status: NEW Version: unspecified Component: Drivers/Gallium/radeonsi Product: Mesa Created attachment 103116 --> https://bugs.freedesktop.org/attachment.cgi?id=103116&action=edit Screenshot of Gnome shell Please have a look at the screenshots. Rendering of most windows is totally garbled including window decoration. This is not about Crossfire/SLI/Multi GPU rendering, just plain single GPU. Gnome-shell's own rendering is mostly fine. Panel, lock screen animations, menus and dashboard don't show distortions. KDE's/Kwin is worse, even the panel's are broken, but it's able to draw window decorations. glxgears's rendering is fine. Linux console (no X11) is also fine. Hardware: PowerColor AX7990 6GBD5-2DHJ, which is one of those fake 7990s that actually use 2x7970 Tahiti XT on a single PCB and not 2x Malta. Other GPUs (6950/7950) were working fine with that system. Software: Fedora 19/20 (From stock LiveCD image to current updates incl. Kernel 3.15.4) There were no (drawing!) issues when I was using catalyst. -- You are receiving this mail because: You are the assignee for the bug.

1 7

[Bug 81678] X crashes on start (integrated 7640G + discrete 7500M/7600M)
by bugzilla-daemon＠freedesktop.org 10 Oct '14

10 Oct '14

https://bugs.freedesktop.org/show_bug.cgi?id=81678 --- Comment #10 from Andrey Volkov <jezekulfur(a)gmail.com> --- On 3.16.x kernels this bug also present -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] drm/core: make ida allocation and de-allocation consistent
by Andrzej Hajda 10 Oct '14

10 Oct '14

Connector type id is allocated using ida_simple_get, its counterpart is ida_simple_remove, so we should use it instead of ida_remove. Signed-off-by: Andrzej Hajda <a.hajda(a)samsung.com> --- drivers/gpu/drm/drm_crtc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index ecd4e0b..6bf9fdb 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -904,6 +904,8 @@ void drm_connector_cleanup(struct drm_connector *connector) { struct drm_device *dev = connector->dev; struct drm_display_mode *mode, *t; + struct ida *connector_ida = + &drm_connector_enum_list[connector->connector_type].ida; list_for_each_entry_safe(mode, t, &connector->probed_modes, head) drm_mode_remove(connector, mode); @@ -911,8 +913,7 @@ void drm_connector_cleanup(struct drm_connector *connector) list_for_each_entry_safe(mode, t, &connector->modes, head) drm_mode_remove(connector, mode); - ida_remove(&drm_connector_enum_list[connector->connector_type].ida, - connector->connector_type_id); + ida_simple_remove(connector_ida, connector->connector_type_id); drm_mode_object_put(dev, &connector->base); kfree(connector->name); -- 1.9.1

1 0

drm_kms_helper.edid_firmware=DVI-I-1 - resume(S3) - DVI-I-2: EDID broken
by poma 10 Oct '14

10 Oct '14

[ 0.000000] Linux version 3.18.0-0.rc0.git2.1.fc22.x86_64 (mockbuild(a)bkernel01.phx2.fedoraproject.org) (gcc version 4.9.1 20140930 (Red Hat 4.9.1-11) (GCC) ) #1 SMP Thu Oct 9 13:57:38 UTC 2014 [ 0.000000] Command line: BOOT_IMAGE=/vmlinuz-3.18.0-0.rc0.git2.1.fc22.x86_64 root=UUID=a07556d2-6fe2-417f-8202-c54c07fd9386 drm_kms_helper.edid_firmware=DVI-I-1:edid/848x480.bin initrd=/initramfs-3.18.0-0.rc0.git2.1.fc22.x86_64.img [ 4.396325] usb 1-6: new high-speed USB device number 7 using ehci-pci [ 4.520203] usb 1-6: New USB device found, idVendor=17e9, idProduct=019e [ 4.520357] usb 1-6: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 4.520499] usb 1-6: Product: FY USB-DVI [ 4.520629] usb 1-6: Manufacturer: DisplayLink [ 4.520761] usb 1-6: SerialNumber: USB_FY1704 [ 23.261365] [drm] Initialized drm 1.1.0 20060810 [ 24.415915] [drm] vendor descriptor length:1b data:1b 5f 01 00 19 05 00 01 03 00 04 [ 24.734381] [drm] Got external EDID base block and 0 extensions from "edid/848x480.bin" for connector "DVI-I-1" [ 24.749973] open /dev/fb0 user=0 fb_info=ffff8800c68ae000 count=1 [ 24.762202] [drm] write mode info 153 [ 24.785148] Console: switching to colour frame buffer device 106x30 [ 24.799662] udl 1-6:1.0: fb0: udldrmfb frame buffer device [ 24.799731] udl 1-6:1.0: registered panic notifier [ 24.808392] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 24.810304] [drm] No driver support for vblank timestamp query. [ 24.812697] [drm] Initialized udl 0.0.1 20120220 on minor 0 [ 24.815622] usbcore: registered new interface driver udl [ 35.269700] [drm] Got external EDID base block and 0 extensions from "edid/848x480.bin" for connector "DVI-I-1" [ 35.275096] [drm] Got external EDID base block and 0 extensions from "edid/848x480.bin" for connector "DVI-I-1" [ 35.344093] [drm] write mode info 153 [ 36.950930] [drm] Got external EDID base block and 0 extensions from "edid/848x480.bin" for connector "DVI-I-1" [ 325.799612] PM: Preparing system for mem sleep [ 326.067140] PM: Entering mem sleep [ 326.068158] Suspending console(s) (use no_console_suspend to debug) [ 329.397361] PM: suspend of devices complete after 3323.665 msecs [ 329.397371] PM: suspend devices took 3.329 seconds [ 329.409465] PM: late suspend of devices complete after 12.074 msecs [ 329.420591] ehci-pci 0000:00:04.1: System wakeup enabled by ACPI [ 329.431399] PM: noirq suspend of devices complete after 21.916 msecs [ 329.431455] ACPI: Preparing to enter system sleep state S3 [ 329.840517] PM: Saving platform NVS memory [ 329.905021] ACPI: Low-level resume complete [ 329.905021] PM: Restoring platform NVS memory [ 329.976500] ACPI: Waking up from system sleep state S3 [ 329.999944] ehci-pci 0000:00:04.1: System wakeup disabled by ACPI [ 330.003489] PM: noirq resume of devices complete after 19.016 msecs [ 330.012769] PM: early resume of devices complete after 9.022 msecs [ 332.101657] PM: resume of devices complete after 2088.867 msecs [ 332.113620] [drm] vendor descriptor length:1b data:1b 5f 01 00 19 05 00 01 03 00 04 [ 332.246592] Raw EDID: [ 332.246599] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.246603] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.246606] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.246609] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.246612] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.246615] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.246619] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.246622] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.246632] udl 1-6:1.0: DVI-I-2: EDID invalid. [ 332.262425] udl 1-6:1.0: fb2: udldrmfb frame buffer device [ 332.262492] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 332.262495] [drm] No driver support for vblank timestamp query. [ 332.262507] [drm] Initialized udl 0.0.1 20120220 on minor 2 [ 332.274311] PM: resume devices took 2.262 seconds [ 332.320387] PM: Finishing wakeup. [ 332.661252] Raw EDID: [ 332.661267] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.661277] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.661287] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.661296] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.661306] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.661317] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.661326] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.661336] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.661350] udl 1-6:1.0: DVI-I-2: EDID invalid. [ 332.791128] Raw EDID: [ 332.791148] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.791159] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.791169] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.791178] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.791188] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.791198] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.791208] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.791218] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 332.791234] udl 1-6:1.0: DVI-I-2: EDID invalid. [ 342.072576] [drm] wait for urb interrupted: ffffffc2 available: 4 [ 342.578079] Raw EDID: [ 342.578096] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.578103] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.578108] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.578114] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.578119] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.578125] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.578130] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.578136] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.578147] udl 1-6:1.0: DVI-I-2: EDID invalid. [ 342.707077] Raw EDID: [ 342.707093] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.707100] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.707105] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.707111] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.707116] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.707122] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.707127] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.707133] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 342.707144] udl 1-6:1.0: DVI-I-2: EDID invalid. [ 342.746100] [drm] write mode info 153 [ 343.346381] Raw EDID: [ 343.346399] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 343.346406] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 343.346412] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 343.346417] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 343.346423] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 343.346428] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 343.346434] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 343.346440] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 343.346452] udl 1-6:1.0: DVI-I-2: EDID invalid.

1 0

AMD GPU new API for new module
by Jerome Glisse 10 Oct '14

10 Oct '14

Hi, So if i do not start the discussion now it might be already too late. Given plan to converge open source driver and closed source driver to use a single common kernel driver and that this would be a new kernel driver. This is an opportunity to fix some of the radeon design issues (at least things that i would have done differently if only i could get some gas for my DeLorean). Among the thing that i will not do is the chunk stuff associated with cs ioctl. I find it ugly, if my memory serve me well i was trying to be future proof and allow the cs ioctl to be extended. While this original aim have been somewhat successfully, i think it was the wrong day to do it. My lastest (and what i still believe to be a good idea until proven wrong), is to change the way we do ioctl and use a little trick. This idea was also spark by the continuous additions we do to info ioctl which is getting ugly. So idea is simple, each ioctl would use some struct like : struct radeon_ioctl { u32 version; u32 size; }; The version field is the key here, think of it as an index into an array of ioctl dispatch functions. So something like : struct radeon_ioctls { int (*iotcl)[MAX_IOCTL_NUM](void *data, ...); }; struct radeon_ioctls rdispatch_ioctls[N]; And now all ioctl go through this single entry point : int radeon_ioctl_stub(int ioctl, void *data, ...) { struct radeon_ioctl *rio = data; return rdispatch_ioctls[rio->version][ioctl](data, ...); } So this is rough idea but the point is that we can do proper ioctl versioning and have separate functions for each new versions and avoid ioctl cruft, or at least this is the theory. The two things this gave us, is feedback from userspace as we the version the kernel will know which version of userspace it is dealing with. The others one is that it does allow you to introduce a completely new API either for new generation of hardware or just as an evolution. And small bonus is that it does allow to slowly phase out API that we consider broken (ioctl per ioctl). So this is the main design change that i would do. I should probably rought up something that goes deeper for the cs ioctl. Cheers, Jérôme

7 16

[PATCH] drm: sti: remove gpio for HDMI hot plug detection
by Benjamin Gaignard 09 Oct '14

09 Oct '14

gpio used for HDMI hot plug detection is useless, HDMI_STI register contains an hot plug detection status bit. Fix binding documentation. Signed-off-by: Benjamin Gaignard <benjamin.gaignard(a)linaro.org> --- Documentation/devicetree/bindings/gpu/st,stih4xx.txt | 2 -- drivers/gpu/drm/sti/sti_hdmi.c | 11 ++--------- drivers/gpu/drm/sti/sti_hdmi.h | 5 +++-- 3 files changed, 5 insertions(+), 13 deletions(-) diff --git a/Documentation/devicetree/bindings/gpu/st,stih4xx.txt b/Documentation/devicetree/bindings/gpu/st,stih4xx.txt index 8885d9e..32cfc7b 100644 --- a/Documentation/devicetree/bindings/gpu/st,stih4xx.txt +++ b/Documentation/devicetree/bindings/gpu/st,stih4xx.txt @@ -68,7 +68,6 @@ STMicroelectronics stih4xx platforms number of clocks may depend of the SoC type. - clock-names: names of the clocks listed in clocks property in the same order. - - hdmi,hpd-gpio: gpio id to detect if an hdmi cable is plugged or not. - ddc: phandle of an I2C controller used for DDC EDID probing sti-hda: @@ -174,7 +173,6 @@ Example: interrupt-names = "irq"; clock-names = "pix", "tmds", "phy", "audio"; clocks = <&clockgen_c_vcc CLK_S_PIX_HDMI>, <&clockgen_c_vcc CLK_S_TMDS_HDMI>, <&clockgen_c_vcc CLK_S_HDMI_REJECT_PLL>, <&clockgen_b1 CLK_S_PCM_0>; - hdmi,hpd-gpio = <&PIO2 5>; }; sti-hda@fe85a000 { diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index 7673189..09f39c5 100644 --- a/drivers/gpu/drm/sti/sti_hdmi.c +++ b/drivers/gpu/drm/sti/sti_hdmi.c @@ -130,8 +130,7 @@ static irqreturn_t hdmi_irq_thread(int irq, void *arg) /* Hot plug/unplug IRQ */ if (hdmi->irq_status & HDMI_INT_HOT_PLUG) { - /* read gpio to get the status */ - hdmi->hpd = gpio_get_value(hdmi->hpd_gpio); + hdmi->hpd = readl(hdmi->regs + HDMI_STA) & HDMI_STA_HOT_PLUG; if (hdmi->drm_dev) drm_helper_hpd_irq_event(hdmi->drm_dev); } @@ -767,13 +766,7 @@ static int sti_hdmi_probe(struct platform_device *pdev) return PTR_ERR(hdmi->clk_audio); } - hdmi->hpd_gpio = of_get_named_gpio(np, "hdmi,hpd-gpio", 0); - if (hdmi->hpd_gpio < 0) { - DRM_ERROR("Failed to get hdmi hpd-gpio\n"); - return -EIO; - } - - hdmi->hpd = gpio_get_value(hdmi->hpd_gpio); + hdmi->hpd = readl(hdmi->regs + HDMI_STA) & HDMI_STA_HOT_PLUG; init_waitqueue_head(&hdmi->wait_event); diff --git a/drivers/gpu/drm/sti/sti_hdmi.h b/drivers/gpu/drm/sti/sti_hdmi.h index d00a3e0..3d22390 100644 --- a/drivers/gpu/drm/sti/sti_hdmi.h +++ b/drivers/gpu/drm/sti/sti_hdmi.h @@ -14,6 +14,9 @@ #define HDMI_STA 0x0010 #define HDMI_STA_DLL_LCK BIT(5) +#define HDMI_STA_HOT_PLUG_SHIFT 4 +#define HDMI_STA_HOT_PLUG (1 << HDMI_STA_HOT_PLUG_SHIFT) + struct sti_hdmi; struct hdmi_phy_ops { @@ -37,7 +40,6 @@ struct hdmi_phy_ops { * @irq_status: interrupt status register * @phy_ops: phy start/stop operations * @enabled: true if hdmi is enabled else false - * @hpd_gpio: hdmi hot plug detect gpio number * @hpd: hot plug detect status * @wait_event: wait event * @event_received: wait event status @@ -57,7 +59,6 @@ struct sti_hdmi { u32 irq_status; struct hdmi_phy_ops *phy_ops; bool enabled; - int hpd_gpio; bool hpd; wait_queue_head_t wait_event; bool event_received; -- 1.9.1

2 2

[PATCH 02/10] drm/i915: Add counters in the drm_dp_aux struct for I2C NACKs and DEFERs
by Todd Previte 09 Oct '14

09 Oct '14

These counters are used for Displayort complinace testing to detect error conditions when executing certain compliance tests. Currently these are used in the EDID tests to determine if the video mode needs to be set to the preferred mode or the failsafe mode. Cc: dri-devel(a)lists.freedesktop.org Signed-off-by: Todd Previte <tprevite(a)gmail.com> --- drivers/gpu/drm/drm_dp_helper.c | 2 ++ include/drm/drm_dp_helper.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 08e33b8..8353051 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -654,10 +654,12 @@ static int drm_dp_i2c_do_msg(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg) case DP_AUX_I2C_REPLY_NACK: DRM_DEBUG_KMS("I2C nack\n"); + aux->i2c_nack_count++; return -EREMOTEIO; case DP_AUX_I2C_REPLY_DEFER: DRM_DEBUG_KMS("I2C defer\n"); + aux->i2c_defer_count++; usleep_range(400, 500); continue; diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 8edeed0..45f3ee8 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -551,6 +551,7 @@ struct drm_dp_aux { struct mutex hw_mutex; ssize_t (*transfer)(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg); + uint8_t i2c_nack_count, i2c_defer_count; }; ssize_t drm_dp_dpcd_read(struct drm_dp_aux *aux, unsigned int offset, -- 1.9.1

1 1

← Newer
1
...
86
87
88
89
90
91
92
...
95
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2014