dri-devel March 2014

dri-devel@lists.freedesktop.org

144 participants
926 discussions

[PATCH 1/1] drm/gma500: Code cleanup - remove double variable assignment
by Arthur Borsboom 20 Mar '14

20 Mar '14

The same assignment has already been taken place before in the drm_driver struct Signed-off-by: Arthur Borsboom <arthurborsboom(a)gmail.com> --- drivers/gpu/drm/gma500/psb_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c index b686e56..edb903b 100644 --- a/drivers/gpu/drm/gma500/psb_drv.c +++ b/drivers/gpu/drm/gma500/psb_drv.c @@ -358,7 +358,6 @@ static int psb_driver_load(struct drm_device *dev, unsigned long flags) dev->vblank_disable_allowed = true; dev->max_vblank_count = 0xffffff; /* only 24 bits of frame count */ - dev->driver->get_vblank_counter = psb_get_vblank_counter; psb_modeset_init(dev); psb_fbdev_init(dev); -- 1.9.0

1 0

[Bug 75494] Kabini [Radeon HD 8240] Xorg segfault on resume from suspend with glamor and radeonsi
by bugzilla-daemon＠freedesktop.org 20 Mar '14

20 Mar '14

https://bugs.freedesktop.org/show_bug.cgi?id=75494 Jarno Leppänen <jarno.leppanen(a)iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 75494] Kabini [Radeon HD 8240] Xorg segfault on resume from suspend with glamor and radeonsi
by bugzilla-daemon＠freedesktop.org 20 Mar '14

20 Mar '14

https://bugs.freedesktop.org/show_bug.cgi?id=75494 --- Comment #7 from Jarno Leppänen <jarno.leppanen(a)iki.fi> --- This problem seems to be fixed in mainline kernel version 3.14-rc7. Closing bug. Thanks! -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] drm/mm: Fix search for smallest hole satisfying constraints
by Michel Dänzer 20 Mar '14

20 Mar '14

From: Michel Dänzer <michel.daenzer(a)amd.com> entry->size is the size of the node, not the size of the hole after it. So the code would actually find the hole which can satisfy the constraints and which is preceded by the smallest node, not the smallest hole satisfying the constraints. Reported-by: "Huang, FrankR" <FrankR.Huang(a)amd.com> Signed-off-by: Michel Dänzer <michel.daenzer(a)amd.com> --- drivers/gpu/drm/drm_mm.c | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index af93cc5..5d921e5 100644 --- a/drivers/gpu/drm/drm_mm.c +++ b/drivers/gpu/drm/drm_mm.c @@ -306,8 +306,8 @@ static struct drm_mm_node *drm_mm_search_free_generic(const struct drm_mm *mm, { struct drm_mm_node *entry; struct drm_mm_node *best; - unsigned long adj_start; - unsigned long adj_end; + unsigned long hole_start; + unsigned long hole_end; unsigned long best_size; BUG_ON(mm->scanned_blocks); @@ -315,7 +315,10 @@ static struct drm_mm_node *drm_mm_search_free_generic(const struct drm_mm *mm, best = NULL; best_size = ~0UL; - drm_mm_for_each_hole(entry, mm, adj_start, adj_end) { + drm_mm_for_each_hole(entry, mm, hole_start, hole_end) { + unsigned long adj_start = hole_start; + unsigned long adj_end = hole_end; + if (mm->color_adjust) { mm->color_adjust(entry, color, &adj_start, &adj_end); if (adj_end <= adj_start) @@ -328,9 +331,9 @@ static struct drm_mm_node *drm_mm_search_free_generic(const struct drm_mm *mm, if (!(flags & DRM_MM_SEARCH_BEST)) return entry; - if (entry->size < best_size) { + if ((hole_end - hole_start) < best_size) { best = entry; - best_size = entry->size; + best_size = hole_end - hole_start; } } @@ -341,14 +344,14 @@ static struct drm_mm_node *drm_mm_search_free_in_range_generic(const struct drm_ unsigned long size, unsigned alignment, unsigned long color, - unsigned long start, - unsigned long end, + unsigned long range_start, + unsigned long range_end, enum drm_mm_search_flags flags) { struct drm_mm_node *entry; struct drm_mm_node *best; - unsigned long adj_start; - unsigned long adj_end; + unsigned long hole_start; + unsigned long hole_end; unsigned long best_size; BUG_ON(mm->scanned_blocks); @@ -356,11 +359,9 @@ static struct drm_mm_node *drm_mm_search_free_in_range_generic(const struct drm_ best = NULL; best_size = ~0UL; - drm_mm_for_each_hole(entry, mm, adj_start, adj_end) { - if (adj_start < start) - adj_start = start; - if (adj_end > end) - adj_end = end; + drm_mm_for_each_hole(entry, mm, hole_start, hole_end) { + unsigned long adj_start = max(hole_start, range_start); + unsigned long adj_end = min(hole_end, range_end); if (mm->color_adjust) { mm->color_adjust(entry, color, &adj_start, &adj_end); @@ -374,9 +375,9 @@ static struct drm_mm_node *drm_mm_search_free_in_range_generic(const struct drm_ if (!(flags & DRM_MM_SEARCH_BEST)) return entry; - if (entry->size < best_size) { + if ((hole_end - hole_start) < best_size) { best = entry; - best_size = entry->size; + best_size = hole_end - hole_start; } } -- 1.9.0

2 5

[GIT PULL] exynos-drm-fixes
by Inki Dae 20 Mar '14

20 Mar '14

Hi Dave, Just fixed resource release issue at open fail. Thanks, Inki Dae The following changes since commit 27410e8248c64f5c6d28891389083b1022c15a10: drm: Fix use-after-free in the shadow-attache exit code (2014-03-18 13:09:03 +1000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos exynos-drm-fixes for you to fetch changes up to 85d898bf8f638b7a23af95dc7d32b4a72c178637: drm/exynos: Fix (more) freeing issues in exynos_drm_drv.c (2014-03-20 11:42:24 +0900) ---------------------------------------------------------------- Daniel Kurtz (1): drm/exynos: Fix (more) freeing issues in exynos_drm_drv.c drivers/gpu/drm/exynos/exynos_drm_drv.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)

1 0

[PATCH 4/4] output: Drop display output class support
by Jean Delvare 19 Mar '14

19 Mar '14

It was only ever used by the ACPI video driver, and that only use case vanished over 3 years ago (see commit 677bd810, "ACPI video: remove output switching control".) So this is dead code and I guess we can remove it now. Signed-off-by: Jean Delvare <jdelvare(a)suse.de> Cc: Zhang Rui <rui.zhang(a)intel.com> Cc: Len Brown <lenb(a)kernel.org> Cc: "Rafael J. Wysocki" <rjw(a)rjwysocki.net> --- drivers/video/Kconfig | 6 - drivers/video/Makefile | 2 drivers/video/output.c | 133 ------------------------------------------- include/linux/video_output.h | 57 ------------------ 4 files changed, 198 deletions(-) --- linux-3.14-rc7.orig/drivers/video/Kconfig 2014-02-17 15:22:14.704636928 +0100 +++ linux-3.14-rc7/drivers/video/Kconfig 2014-03-17 14:37:39.274887482 +0100 @@ -27,12 +27,6 @@ config VGASTATE tristate default n -config VIDEO_OUTPUT_CONTROL - tristate "Lowlevel video output switch controls" - help - This framework adds support for low-level control of the video - output switch. - config VIDEOMODE_HELPERS bool --- linux-3.14-rc7.orig/drivers/video/Makefile 2014-02-09 16:53:05.791694131 +0100 +++ linux-3.14-rc7/drivers/video/Makefile 2014-03-17 14:37:56.910247231 +0100 @@ -172,8 +172,6 @@ obj-$(CONFIG_FB_SIMPLE) += sim # the test framebuffer is last obj-$(CONFIG_FB_VIRTUAL) += vfb.o -#video output switch sysfs driver -obj-$(CONFIG_VIDEO_OUTPUT_CONTROL) += output.o obj-$(CONFIG_VIDEOMODE_HELPERS) += display_timing.o videomode.o ifeq ($(CONFIG_OF),y) obj-$(CONFIG_VIDEOMODE_HELPERS) += of_display_timing.o of_videomode.o --- linux-3.14-rc7.orig/drivers/video/output.c 2014-01-20 03:40:07.000000000 +0100 +++ /dev/null 1970-01-01 00:00:00.000000000 +0000 @@ -1,133 +0,0 @@ -/* - * output.c - Display Output Switch driver - * - * Copyright (C) 2006 Luming Yu <luming.yu(a)intel.com> - * - * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or (at - * your option) any later version. - * - * This program is distributed in the hope that it will be useful, but - * WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA. - * - * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - */ -#include <linux/module.h> -#include <linux/video_output.h> -#include <linux/slab.h> -#include <linux/err.h> -#include <linux/ctype.h> - - -MODULE_DESCRIPTION("Display Output Switcher Lowlevel Control Abstraction"); -MODULE_LICENSE("GPL"); -MODULE_AUTHOR("Luming Yu <luming.yu(a)intel.com>"); - -static ssize_t state_show(struct device *dev, struct device_attribute *attr, - char *buf) -{ - ssize_t ret_size = 0; - struct output_device *od = to_output_device(dev); - if (od->props) - ret_size = sprintf(buf,"%.8x\n",od->props->get_status(od)); - return ret_size; -} - -static ssize_t state_store(struct device *dev, struct device_attribute *attr, - const char *buf,size_t count) -{ - char *endp; - struct output_device *od = to_output_device(dev); - int request_state = simple_strtoul(buf,&endp,0); - size_t size = endp - buf; - - if (isspace(*endp)) - size++; - if (size != count) - return -EINVAL; - - if (od->props) { - od->request_state = request_state; - od->props->set_state(od); - } - return count; -} -static DEVICE_ATTR_RW(state); - -static void video_output_release(struct device *dev) -{ - struct output_device *od = to_output_device(dev); - kfree(od); -} - -static struct attribute *video_output_attrs[] = { - &dev_attr_state.attr, - NULL, -}; -ATTRIBUTE_GROUPS(video_output); - -static struct class video_output_class = { - .name = "video_output", - .dev_release = video_output_release, - .dev_groups = video_output_groups, -}; - -struct output_device *video_output_register(const char *name, - struct device *dev, - void *devdata, - struct output_properties *op) -{ - struct output_device *new_dev; - int ret_code = 0; - - new_dev = kzalloc(sizeof(struct output_device),GFP_KERNEL); - if (!new_dev) { - ret_code = -ENOMEM; - goto error_return; - } - new_dev->props = op; - new_dev->dev.class = &video_output_class; - new_dev->dev.parent = dev; - dev_set_name(&new_dev->dev, "%s", name); - dev_set_drvdata(&new_dev->dev, devdata); - ret_code = device_register(&new_dev->dev); - if (ret_code) { - kfree(new_dev); - goto error_return; - } - return new_dev; - -error_return: - return ERR_PTR(ret_code); -} -EXPORT_SYMBOL(video_output_register); - -void video_output_unregister(struct output_device *dev) -{ - if (!dev) - return; - device_unregister(&dev->dev); -} -EXPORT_SYMBOL(video_output_unregister); - -static void __exit video_output_class_exit(void) -{ - class_unregister(&video_output_class); -} - -static int __init video_output_class_init(void) -{ - return class_register(&video_output_class); -} - -postcore_initcall(video_output_class_init); -module_exit(video_output_class_exit); --- linux-3.14-rc7.orig/include/linux/video_output.h 2014-01-20 03:40:07.000000000 +0100 +++ /dev/null 1970-01-01 00:00:00.000000000 +0000 @@ -1,57 +0,0 @@ -/* - * - * Copyright (C) 2006 Luming Yu <luming.yu(a)intel.com> - * - * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or (at - * your option) any later version. - * - * This program is distributed in the hope that it will be useful, but - * WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA. - * - * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - */ -#ifndef _LINUX_VIDEO_OUTPUT_H -#define _LINUX_VIDEO_OUTPUT_H -#include <linux/device.h> -#include <linux/err.h> -struct output_device; -struct output_properties { - int (*set_state)(struct output_device *); - int (*get_status)(struct output_device *); -}; -struct output_device { - int request_state; - struct output_properties *props; - struct device dev; -}; -#define to_output_device(obj) container_of(obj, struct output_device, dev) -#if defined(CONFIG_VIDEO_OUTPUT_CONTROL) || defined(CONFIG_VIDEO_OUTPUT_CONTROL_MODULE) -struct output_device *video_output_register(const char *name, - struct device *dev, - void *devdata, - struct output_properties *op); -void video_output_unregister(struct output_device *dev); -#else -static struct output_device *video_output_register(const char *name, - struct device *dev, - void *devdata, - struct output_properties *op) -{ - return ERR_PTR(-ENODEV); -} -static void video_output_unregister(struct output_device *dev) -{ - return; -} -#endif -#endif -- Jean Delvare SUSE L3 Support

1 1

[GIT PULL] PCI updates for v3.14
by Bjorn Helgaas 19 Mar '14

19 Mar '14

Hi Linus, This is a fix for an AGP regression exposed by e501b3d87f00 ("agp: Support 64-bit APBASE"), which we merged in v3.14-rc1. We've warned about the conflict between the GART and PCI resources and cleared out the PCI resource for a long time, but after e501b3d87f00, we still *use* that cleared-out PCI resource. I think the GART resource is incorrect, so this patch removes it. The following changes since commit ac93ac7403493f8707b7734de9f40d5cb5db9045: PCI: Don't check resource_size() in pci_bus_alloc_resource() (2014-03-12 11:19:20 -0600) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git tags/pci-v3.14-fixes-3 for you to fetch changes up to 707d4eefbdb31f8e588277157056b0ce637d6c68: Revert "[PATCH] Insert GART region into resource map" (2014-03-18 14:26:12 -0600) ---------------------------------------------------------------- PCI updates for v3.14: Resource management - Revert "Insert GART region into resource map" ---------------------------------------------------------------- Bjorn Helgaas (1): Revert "[PATCH] Insert GART region into resource map" arch/x86/kernel/aperture_64.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-)

1 0

[PULL] drm-intel-fixes
by Jani Nikula 19 Mar '14

19 Mar '14

Hi Dave - Two additional fixes on top of my last pull as promised, one for a 3.14 specific regression, one cc: stable. This clears up my backlog, at least of anything non-controversial. BR, Jani. The following changes since commit 5c673b60a9b3b23486f4eda75c72e91d31d26a2b: drm/i915: Don't enable display error interrupts from the start (2014-03-12 17:20:34 +0200) are available in the git repository at: git://anongit.freedesktop.org/drm-intel tags/drm-intel-fixes-2014-03-19 for you to fetch changes up to 0f4706d2740f2a221cd502922b22e522009041d9: drm/i915: Disable stolen memory when DMAR is active (2014-03-19 10:05:38 +0200) ---------------------------------------------------------------- Chris Wilson (1): drm/i915: Disable stolen memory when DMAR is active Jani Nikula (1): Revert "drm/i915: don't touch the VDD when disabling the panel" drivers/gpu/drm/i915/i915_gem_stolen.c | 7 +++++++ drivers/gpu/drm/i915/intel_ddi.c | 1 + drivers/gpu/drm/i915/intel_dp.c | 10 +++++++++- 3 files changed, 17 insertions(+), 1 deletion(-) -- Jani Nikula, Intel Open Source Technology Center

1 0

[PATCH 1/3] drm/dp: make aux retries less chatty
by Alex Deucher 19 Mar '14

19 Mar '14

Switch to debug only to avoid flooding the logs. This mirrors the behavior in some other drivers. Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> --- drivers/gpu/drm/drm_dp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 35251af..74724aa 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -402,7 +402,7 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request, } } - DRM_ERROR("too many retries, giving up\n"); + DRM_DEBUG_KMS("too many retries, giving up\n"); return -EIO; } @@ -656,7 +656,7 @@ static int drm_dp_i2c_do_msg(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg) } } - DRM_ERROR("too many retries, giving up\n"); + DRM_DEBUG_KMS("too many retries, giving up\n"); return -EREMOTEIO; } -- 1.8.3.1

3 7

[PATCH 1/4] ACPI: fix ACPI_VIDEO dependencies
by Jean Delvare 19 Mar '14

19 Mar '14

From: Jean Delvare <jdelvare(a)suse.de> Subject: ACPI: fix ACPI_VIDEO dependencies ACPI_VIDEO stopped depending on VIDEO_OUTPUT_CONTROL over 3 years ago (see commit 677bd810, "ACPI video: remove output switching control".) So it's about time to remove the Kconfig dependency between these two options. Signed-off-by: Jean Delvare <jdelvare(a)suse.de> Cc: Zhang Rui <rui.zhang(a)intel.com> Cc: Len Brown <lenb(a)kernel.org> Cc: "Rafael J. Wysocki" <rjw(a)rjwysocki.net> --- It would be great if this patch could go upstream quickly, as system-wide cleanups depend on it. drivers/acpi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-3.14-rc7.orig/drivers/acpi/Kconfig 2014-01-20 03:40:07.000000000 +0100 +++ linux-3.14-rc7/drivers/acpi/Kconfig 2014-03-17 14:13:33.312716554 +0100 @@ -115,7 +115,7 @@ config ACPI_BUTTON config ACPI_VIDEO tristate "Video" - depends on X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL + depends on X86 && BACKLIGHT_CLASS_DEVICE depends on INPUT select THERMAL help -- Jean Delvare SUSE L3 Support

2 4

← Newer
1
...
72
73
74
75
76
77
78
...
93
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel March 2014