dri-devel April 2014

dri-devel@lists.freedesktop.org

153 participants
962 discussions

[PATCH] drm/radeon: fix endian swap on hawaii clear state buffer setup
by Alex Deucher 02 Apr '14

02 Apr '14

Need to swap on BE. Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Cc: stable(a)vger.kernel.org --- drivers/gpu/drm/radeon/cik.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c index 9bfd3d3..dd545521 100644 --- a/drivers/gpu/drm/radeon/cik.c +++ b/drivers/gpu/drm/radeon/cik.c @@ -6542,8 +6542,8 @@ void cik_get_csb_buffer(struct radeon_device *rdev, volatile u32 *buffer) buffer[count++] = cpu_to_le32(0x00000000); break; case CHIP_HAWAII: - buffer[count++] = 0x3a00161a; - buffer[count++] = 0x0000002e; + buffer[count++] = cpu_to_le32(0x3a00161a); + buffer[count++] = cpu_to_le32(0x0000002e); break; default: buffer[count++] = cpu_to_le32(0x00000000); -- 1.8.3.1

1 1

Re: X.org doesn't start with 3.14: [KMS] drm report modesetting isn't supported
by Bruno Prémont 02 Apr '14

02 Apr '14

Hi Justin, CC-ing dri-devel as more KMS/radeon people will see it there. On Mon, 31 March 2014 "Justin Piszcz" <jpiszcz(a)lucidpixels.com> wrote: > Do I need some updated ATI firmware (I believe this might have happened in > the past)..? > I booted back to 3.13.6, Xorg starts up fine, but with 3.14 it does not > start. Could you include all the drm/kms/radeon related output from your kernel log as well as your /proc/cmdline? Also, are /sys/class/drm/card0* entries present with proper contents (modes, enabled, status attributes present and with sensible values)? What exact AMD/ATI GPU is present in your system (lspci)? Are your graphics drivers built-in or built as a module? Bruno > Thoughts? > > 3.13.6: > $ ps auxww|grep X > root 4368 5.3 0.0 296648 37364 tty7 Ssl+ 18:23 0:00 /usr/bin/X > :0 vt7 -nolisten tcp > > 3.14: > [ 346.490] (**) ModulePath set to "/usr/lib/xorg/modules" > [ 346.490] (WW) Hotplugging is on, devices using drivers 'kbd', 'mouse' or > 'vmmouse' will be disabled. > [ 346.490] (WW) Disabling Mouse0 > [ 346.490] (WW) Disabling Keyboard0 > [ 346.490] (II) [KMS] drm report modesetting isn't supported. > [ 346.490] (EE) > [ 346.490] (EE) Backtrace: > [ 346.490] (EE) 0: Xorg (xorg_backtrace+0x48) [0x7fbbbd731c58] > [ 346.490] (EE) 1: Xorg (0x7fbbbd58a000+0x1ab949) [0x7fbbbd735949] > [ 346.490] (EE) 2: /lib/x86_64-linux-gnu/libpthread.so.0 > (0x7fbbbc3c5000+0xf880) [0x7fbbbc3d4880] > [ 346.490] (EE) > [ 346.490] (EE) Segmentation fault at address 0x0 > [ 346.490] (EE) > Fatal server error: > [ 346.491] (EE) Caught signal 11 (Segmentation fault). Server aborting > [ 346.491] (EE) > [ 346.491] (EE) > Please consult the The X.Org Foundation support > at http://wiki.x.org > for help. > [ 346.491] (EE) Please also check the log file at "/var/log/Xorg.0.log" > for additional information. > [ 346.491] (EE) > > Kernel config: > http://home.comcast.net/~jpiszcz/20140331/3.14.txt > > Kernel diffs: > > $ diff -u config-20140331.1396303540 config-20140320.1395308867 | grep \^+ > +++ config-20140320.1395308867 2014-03-20 05:47:47.508584015 -0400 > +# Linux/x86 3.13.6 Kernel Configuration > +CONFIG_UIDGID_STRICT_TYPE_CHECKS=y > +CONFIG_MICROCODE_INTEL_LIB=y > +# CONFIG_CC_STACKPROTECTOR is not set > +# CONFIG_SCSI_AIC7XXX_OLD is not set > +# CONFIG_CPU_THERMAL is not set > +# CONFIG_GENERIC_PHY is not set > > $ diff -u config-20140331.1396303540 config-20140320.1395308867 | grep \^- > --- config-20140331.1396303540 2014-03-31 18:05:40.775863929 -0400 > -# Linux/x86 3.14.0 Kernel Configuration > -CONFIG_HAVE_CC_STACKPROTECTOR=y > -# CONFIG_CC_STACKPROTECTOR is not set > -CONFIG_CC_STACKPROTECTOR_NONE=y > -# CONFIG_CC_STACKPROTECTOR_REGULAR is not set > -# CONFIG_CC_STACKPROTECTOR_STRONG is not set > -# CONFIG_ZSMALLOC is not set > -# CONFIG_NETFILTER_XT_MATCH_IPCOMP is not set > -# CONFIG_NETFILTER_XT_MATCH_L2TP is not set > -# CONFIG_GENWQE is not set > -# CONFIG_I40EVF is not set > -CONFIG_ARCH_MIGHT_HAVE_PC_SERIO=y > -# CONFIG_I2C_DESIGNWARE_PLATFORM is not set > -# CONFIG_I2C_ROBOTFUZZ_OSIF is not set > -# CONFIG_ACPI_INT3403_THERMAL is not set > -# CONFIG_DW_WATCHDOG is not set > -# CONFIG_MFD_MAX14577 is not set > -# CONFIG_MFD_LP3943 is not set > -# CONFIG_DRM_I915 is not set > -# CONFIG_DRM_BOCHS is not set > -# CONFIG_FB_OPENCORES is not set > -# CONFIG_USB_MUSB_HDRC is not set > -# CONFIG_USB_DWC2 is not set > -# CONFIG_USB_SERIAL_MXUPORT is not set > -# CONFIG_USB_OTG_FSM is not set > -# CONFIG_RTC_DRV_ISL12057 is not set > -# CONFIG_HP_WIRELESS is not set > -CONFIG_GENERIC_PHY=y > -# CONFIG_BCM_KONA_USB2_PHY is not set > -CONFIG_DMI_SCAN_MACHINE_NON_EFI_FALLBACK=y > -CONFIG_PANIC_TIMEOUT=0 > > > > Justin.

2 1

[PATCH 1/4] drm: Optionally create mm blocks from top-to-bottom
by Lauri Kasanen 02 Apr '14

02 Apr '14

Clients like i915 need to segregate cache domains within the GTT which can lead to small amounts of fragmentation. By allocating the uncached buffers from the bottom and the cacheable buffers from the top, we can reduce the amount of wasted space and also optimize allocation of the mappable portion of the GTT to only those buffers that require CPU access through the GTT. For other drivers, allocating small bos from one end and large ones from the other helps improve the quality of fragmentation. Original patch by Chris Wilson. v2 by Ben: Update callers in i915_gem_object_bind_to_gtt() Turn search flags and allocation flags into separate enums Make checkpatch happy where logical/easy v3 by Ben: Rebased on top of the many drm_mm changes since the original patches Remove ATOMIC from allocator flags (Chris) Reverse order of TOPDOWN and BOTTOMUP v4 by Lauri: Remove i915 parts, they don't apply Respin on top of drm-next Signed-off-by: Lauri Kasanen <cand(a)gmx.com> --- drivers/gpu/drm/drm_mm.c | 56 +++++++++++++++++++++++++++++++++++------------- include/drm/drm_mm.h | 29 +++++++++++++++++++++---- 2 files changed, 66 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index a2d45b74..1728bcc 100644 --- a/drivers/gpu/drm/drm_mm.c +++ b/drivers/gpu/drm/drm_mm.c @@ -102,7 +102,8 @@ static struct drm_mm_node *drm_mm_search_free_in_range_generic(const struct drm_ static void drm_mm_insert_helper(struct drm_mm_node *hole_node, struct drm_mm_node *node, unsigned long size, unsigned alignment, - unsigned long color) + unsigned long color, + enum drm_mm_allocator_flags flags) { struct drm_mm *mm = hole_node->mm; unsigned long hole_start = drm_mm_hole_node_start(hole_node); @@ -115,12 +116,22 @@ static void drm_mm_insert_helper(struct drm_mm_node *hole_node, if (mm->color_adjust) mm->color_adjust(hole_node, color, &adj_start, &adj_end); + if (flags & DRM_MM_CREATE_TOP) + adj_start = adj_end - size; + if (alignment) { unsigned tmp = adj_start % alignment; - if (tmp) - adj_start += alignment - tmp; + if (tmp) { + if (flags & DRM_MM_CREATE_TOP) + adj_start -= tmp; + else + adj_start += alignment - tmp; + } } + BUG_ON(adj_start < hole_start); + BUG_ON(adj_end > hole_end); + if (adj_start == hole_start) { hole_node->hole_follows = 0; list_del(&hole_node->hole_stack); @@ -215,16 +226,17 @@ EXPORT_SYMBOL(drm_mm_reserve_node); int drm_mm_insert_node_generic(struct drm_mm *mm, struct drm_mm_node *node, unsigned long size, unsigned alignment, unsigned long color, - enum drm_mm_search_flags flags) + enum drm_mm_search_flags sflags, + enum drm_mm_allocator_flags aflags) { struct drm_mm_node *hole_node; hole_node = drm_mm_search_free_generic(mm, size, alignment, - color, flags); + color, sflags); if (!hole_node) return -ENOSPC; - drm_mm_insert_helper(hole_node, node, size, alignment, color); + drm_mm_insert_helper(hole_node, node, size, alignment, color, aflags); return 0; } EXPORT_SYMBOL(drm_mm_insert_node_generic); @@ -233,7 +245,8 @@ static void drm_mm_insert_helper_range(struct drm_mm_node *hole_node, struct drm_mm_node *node, unsigned long size, unsigned alignment, unsigned long color, - unsigned long start, unsigned long end) + unsigned long start, unsigned long end, + enum drm_mm_allocator_flags flags) { struct drm_mm *mm = hole_node->mm; unsigned long hole_start = drm_mm_hole_node_start(hole_node); @@ -248,13 +261,20 @@ static void drm_mm_insert_helper_range(struct drm_mm_node *hole_node, if (adj_end > end) adj_end = end; + if (flags & DRM_MM_CREATE_TOP) + adj_start = adj_end - size; + if (mm->color_adjust) mm->color_adjust(hole_node, color, &adj_start, &adj_end); if (alignment) { unsigned tmp = adj_start % alignment; - if (tmp) - adj_start += alignment - tmp; + if (tmp) { + if (flags & DRM_MM_CREATE_TOP) + adj_start -= tmp; + else + adj_start += alignment - tmp; + } } if (adj_start == hole_start) { @@ -271,6 +291,8 @@ static void drm_mm_insert_helper_range(struct drm_mm_node *hole_node, INIT_LIST_HEAD(&node->hole_stack); list_add(&node->node_list, &hole_node->node_list); + BUG_ON(node->start < start); + BUG_ON(node->start < adj_start); BUG_ON(node->start + node->size > adj_end); BUG_ON(node->start + node->size > end); @@ -298,21 +320,23 @@ static void drm_mm_insert_helper_range(struct drm_mm_node *hole_node, * 0 on success, -ENOSPC if there's no suitable hole. */ int drm_mm_insert_node_in_range_generic(struct drm_mm *mm, struct drm_mm_node *node, - unsigned long size, unsigned alignment, unsigned long color, + unsigned long size, unsigned alignment, + unsigned long color, unsigned long start, unsigned long end, - enum drm_mm_search_flags flags) + enum drm_mm_search_flags sflags, + enum drm_mm_allocator_flags aflags) { struct drm_mm_node *hole_node; hole_node = drm_mm_search_free_in_range_generic(mm, size, alignment, color, - start, end, flags); + start, end, sflags); if (!hole_node) return -ENOSPC; drm_mm_insert_helper_range(hole_node, node, size, alignment, color, - start, end); + start, end, aflags); return 0; } EXPORT_SYMBOL(drm_mm_insert_node_in_range_generic); @@ -391,7 +415,8 @@ static struct drm_mm_node *drm_mm_search_free_generic(const struct drm_mm *mm, best = NULL; best_size = ~0UL; - drm_mm_for_each_hole(entry, mm, adj_start, adj_end) { + __drm_mm_for_each_hole(entry, mm, adj_start, adj_end, + flags & DRM_MM_SEARCH_BELOW) { if (mm->color_adjust) { mm->color_adjust(entry, color, &adj_start, &adj_end); if (adj_end <= adj_start) @@ -432,7 +457,8 @@ static struct drm_mm_node *drm_mm_search_free_in_range_generic(const struct drm_ best = NULL; best_size = ~0UL; - drm_mm_for_each_hole(entry, mm, adj_start, adj_end) { + __drm_mm_for_each_hole(entry, mm, adj_start, adj_end, + flags & DRM_MM_SEARCH_BELOW) { if (adj_start < start) adj_start = start; if (adj_end > end) diff --git a/include/drm/drm_mm.h b/include/drm/drm_mm.h index 8b6981a..f2bc79b 100644 --- a/include/drm/drm_mm.h +++ b/include/drm/drm_mm.h @@ -47,8 +47,17 @@ enum drm_mm_search_flags { DRM_MM_SEARCH_DEFAULT = 0, DRM_MM_SEARCH_BEST = 1 << 0, + DRM_MM_SEARCH_BELOW = 1 << 1, }; +enum drm_mm_allocator_flags { + DRM_MM_CREATE_DEFAULT = 0, + DRM_MM_CREATE_TOP = 1 << 0, +}; + +#define DRM_MM_BOTTOMUP DRM_MM_SEARCH_DEFAULT, DRM_MM_CREATE_DEFAULT +#define DRM_MM_TOPDOWN DRM_MM_SEARCH_BELOW, DRM_MM_CREATE_TOP + struct drm_mm_node { struct list_head node_list; struct list_head hole_stack; @@ -195,6 +204,14 @@ static inline unsigned long drm_mm_hole_node_end(struct drm_mm_node *hole_node) 1 : 0; \ entry = list_entry(entry->hole_stack.next, struct drm_mm_node, hole_stack)) +#define __drm_mm_for_each_hole(entry, mm, hole_start, hole_end, backwards) \ + for (entry = list_entry((backwards) ? (mm)->hole_stack.prev : (mm)->hole_stack.next, struct drm_mm_node, hole_stack); \ + &entry->hole_stack != &(mm)->hole_stack ? \ + hole_start = drm_mm_hole_node_start(entry), \ + hole_end = drm_mm_hole_node_end(entry), \ + 1 : 0; \ + entry = list_entry((backwards) ? entry->hole_stack.prev : entry->hole_stack.next, struct drm_mm_node, hole_stack)) + /* * Basic range manager support (drm_mm.c) */ @@ -205,7 +222,8 @@ int drm_mm_insert_node_generic(struct drm_mm *mm, unsigned long size, unsigned alignment, unsigned long color, - enum drm_mm_search_flags flags); + enum drm_mm_search_flags sflags, + enum drm_mm_allocator_flags aflags); /** * drm_mm_insert_node - search for space and insert @node * @mm: drm_mm to allocate from @@ -228,7 +246,8 @@ static inline int drm_mm_insert_node(struct drm_mm *mm, unsigned alignment, enum drm_mm_search_flags flags) { - return drm_mm_insert_node_generic(mm, node, size, alignment, 0, flags); + return drm_mm_insert_node_generic(mm, node, size, alignment, 0, flags, + DRM_MM_CREATE_DEFAULT); } int drm_mm_insert_node_in_range_generic(struct drm_mm *mm, @@ -238,7 +257,8 @@ int drm_mm_insert_node_in_range_generic(struct drm_mm *mm, unsigned long color, unsigned long start, unsigned long end, - enum drm_mm_search_flags flags); + enum drm_mm_search_flags sflags, + enum drm_mm_allocator_flags aflags); /** * drm_mm_insert_node_in_range - ranged search for space and insert @node * @mm: drm_mm to allocate from @@ -266,7 +286,8 @@ static inline int drm_mm_insert_node_in_range(struct drm_mm *mm, enum drm_mm_search_flags flags) { return drm_mm_insert_node_in_range_generic(mm, node, size, alignment, - 0, start, end, flags); + 0, start, end, flags, + DRM_MM_CREATE_DEFAULT); } void drm_mm_remove_node(struct drm_mm_node *node); -- 1.8.3.1

2 1

[Bug 73911] Color Banding on radeon
by bugzilla-daemon＠freedesktop.org 02 Apr '14

02 Apr '14

https://bugs.freedesktop.org/show_bug.cgi?id=73911 --- Comment #22 from Paula Breton <paula(a)parashep.com> --- (In reply to comment #20) > Created attachment 96751 [details] [review] > testing patch > > Does this patch help? it doesn't look like it helps. same problem as before. my cursor has also disappeared, but that might be a problem of that I haven't worked with the kernel before at all. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 73911] Color Banding on radeon
by bugzilla-daemon＠freedesktop.org 02 Apr '14

02 Apr '14

https://bugs.freedesktop.org/show_bug.cgi?id=73911 --- Comment #21 from Paula Breton <paula(a)parashep.com> --- (In reply to comment #20) > Created attachment 96751 [details] [review] > testing patch > > Does this patch help? unfortunately I can't test it as of now, I don't have enough disk space to compile the patched kernel. didn't know it would eat up my last 12GB. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PULL] Universal plane support
by Matt Roper 02 Apr '14

02 Apr '14

Hi, Here's the latest iteration of the universal planes work, which I believe is finally ready for merging. Aside from the minor driver patches to use the new drm_for_each_legacy_plane() macro for plane loops, these should all have an r-b from Rob Clark now. Actual userspace-visibility is currently hidden behind a drm.universal_planes module parameter so that we can do some experimental testing of this before flipping it on universally. Thanks, Matt The following changes since commit c32fc9c803f8ed90a7548810de48ca33a3020168: Merge tag 'vmwgfx-next-2014-03-28' of git://people.freedesktop.org/~thomash/linux into drm-next (2014-03-31 11:29:38 +1000) are available in the git repository at: git://people.freedesktop.org/~robclark/linux primary-plane for you to fetch changes up to 6efa1f2f5417e628572a75e667a9d8c63d21bd17: drm/doc: Update plane documentation and add plane helper library (2014-04-01 20:18:29 -0400) ---------------------------------------------------------------- Matt Roper (13): drm: Add support for multiple plane types (v2) drm/exynos: Restrict plane loops to only operate on overlay planes (v2) drm/i915: Restrict plane loops to only operate on overlay planes (v2) drm/shmobile: Restrict plane loops to only operate on legacy planes drm: Make drm_crtc_check_viewport non-static drm: Add primary plane helpers (v3) drm: Add drm_universal_plane_init() drm: Add drm_crtc_init_with_planes() (v2) drm/msm: Switch to universal plane API's drm: Replace crtc fb with primary plane fb (v3) drm: Remove unused drm_crtc->fb drm: Allow userspace to ask for universal plane list (v2) drm/doc: Update plane documentation and add plane helper library Rob Clark (1): drm: Add plane type property (v2) Documentation/DocBook/drm.tmpl | 50 +++- drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/armada/armada_crtc.c | 23 +- drivers/gpu/drm/ast/ast_mode.c | 12 +- drivers/gpu/drm/bochs/bochs_kms.c | 4 +- drivers/gpu/drm/cirrus/cirrus_mode.c | 10 +- drivers/gpu/drm/drm_crtc.c | 189 +++++++++++---- drivers/gpu/drm/drm_crtc_helper.c | 20 +- drivers/gpu/drm/drm_fb_helper.c | 9 +- drivers/gpu/drm/drm_ioctl.c | 7 + drivers/gpu/drm/drm_plane_helper.c | 333 +++++++++++++++++++++++++++ drivers/gpu/drm/drm_stub.c | 5 + drivers/gpu/drm/exynos/exynos_drm_crtc.c | 22 +- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 2 +- drivers/gpu/drm/gma500/cdv_intel_display.c | 2 +- drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 +- drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 +- drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 +- drivers/gpu/drm/gma500/gma_display.c | 16 +- drivers/gpu/drm/gma500/mdfld_dsi_output.c | 2 +- drivers/gpu/drm/gma500/mdfld_intel_display.c | 16 +- drivers/gpu/drm/gma500/oaktrail_crtc.c | 12 +- drivers/gpu/drm/gma500/psb_intel_display.c | 2 +- drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 +- drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 4 +- drivers/gpu/drm/i915/i915_irq.c | 4 +- drivers/gpu/drm/i915/intel_display.c | 62 ++--- drivers/gpu/drm/i915/intel_dp.c | 4 +- drivers/gpu/drm/i915/intel_overlay.c | 4 +- drivers/gpu/drm/i915/intel_pm.c | 38 +-- drivers/gpu/drm/mgag200/mgag200_mode.c | 26 +-- drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 33 +-- drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c | 8 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 27 ++- drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 8 +- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 20 +- drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +- drivers/gpu/drm/nouveau/nouveau_display.c | 8 +- drivers/gpu/drm/nouveau/nv50_display.c | 17 +- drivers/gpu/drm/omapdrm/omap_crtc.c | 13 +- drivers/gpu/drm/omapdrm/omap_fb.c | 2 +- drivers/gpu/drm/qxl/qxl_display.c | 10 +- drivers/gpu/drm/radeon/atombios_crtc.c | 20 +- drivers/gpu/drm/radeon/r100.c | 4 +- drivers/gpu/drm/radeon/radeon_connectors.c | 2 +- drivers/gpu/drm/radeon/radeon_device.c | 2 +- drivers/gpu/drm/radeon/radeon_display.c | 4 +- drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 16 +- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 10 +- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 16 +- drivers/gpu/drm/tegra/dc.c | 16 +- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 8 +- drivers/gpu/drm/udl/udl_modeset.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 14 +- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 8 +- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 8 +- drivers/staging/imx-drm/ipuv3-crtc.c | 6 +- include/drm/drmP.h | 6 + include/drm/drm_crtc.h | 50 +++- include/drm/drm_plane_helper.h | 49 ++++ include/uapi/drm/drm.h | 8 + 62 files changed, 941 insertions(+), 347 deletions(-) create mode 100644 drivers/gpu/drm/drm_plane_helper.c create mode 100644 include/drm/drm_plane_helper.h -- Matt Roper Graphics Software Engineer ISG Platform Enabling & Development Intel Corporation (916) 356-2795

1 0

Re: Framebuffer corruption in QEMU or Linux's cirrus driver
by Andy Lutomirski 01 Apr '14

01 Apr '14

On Tue, Apr 1, 2014 at 3:09 PM, Andy Lutomirski <luto(a)amacapital.net> wrote: > Running: > > ./virtme-run --installed-kernel > > from this virtme commit: > > https://git.kernel.org/cgit/utils/kernel/virtme/virtme.git/commit/?id=2b409… > > results in a bunch of missing lines of text once bootup finishes. > Pressing enter a few times gradually fixes it. > > I don't know whether this is a qemu bug or a Linux bug. > > I'm seeing this on Fedora's 3.13.7 kernel and on a fairly recent > 3.14-rc kernel. For the latter, cirrus is built-in (not a module), > I'm running: > > virtme-run --kimg arch/x86/boot/bzImage > > and I see more profound corruption. I'm guessing this is a cirrus drm bug. bochs-drm (using virtme-run --installed-kernel --qemu-opts -vga std) does not appear to have the same issue. Neither does qxl. (qxl is painfully slow, though, and it doesn't seem to be using UC memory.) --Andy

1 0

[PATCHv5 00/14] Universal plane preparation patches
by Matt Roper 01 Apr '14

01 Apr '14

Previous series revisions & explanation at [1], [2], [3], and [4] Just a few minor changes in this revision based on Daniel's feedback; I think this should be pretty close to being ready for merging: * Docbook integration for primary plane helpers and new functions (and a few minor updates to existing plane documentation). * Dropped the max width/height property patch for now; actual hardware limitations can be more complex than a constant min/max and how to address this is still being discussed on the mailing list. * drm_crtc_init() moves to the helper library to ensure nothing in the core depends on helpers. * The cursor parameter to drm_crtc_init_with_planes() has been made a void* for now until we actually start adding cursor support. * The client capability bit to enable userspace visibility of universal planes is back, but hidden behind a drm.universal_planes module parameter. [1] http://lists.freedesktop.org/archives/dri-devel/2014-March/056424.html [2] http://lists.freedesktop.org/archives/dri-devel/2014-March/055855.html [3] http://lists.freedesktop.org/archives/dri-devel/2014-March/055222.html [4] http://lists.freedesktop.org/archives/dri-devel/2014-February/054719.html Matt Roper (14): drm: Add support for multiple plane types (v2) drm/exynos: Restrict plane loops to only operate on overlay planes (v2) drm/i915: Restrict plane loops to only operate on overlay planes (v2) drm/shmobile: Restrict plane loops to only operate on legacy planes drm: Make drm_crtc_check_viewport non-static drm: Add primary plane helpers (v3) drm: Add drm_universal_plane_init() drm: Add plane type property (v2) drm: Add drm_crtc_init_with_planes() (v2) drm/msm: Switch to universal plane API's drm: Replace crtc fb with primary plane fb (v3) drm: Remove unused drm_crtc->fb drm: Allow userspace to ask for universal plane list (v2) drm/doc: Update plane documentation and add plane helper library Documentation/DocBook/drm.tmpl | 50 +++- drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/armada/armada_crtc.c | 23 +- drivers/gpu/drm/ast/ast_mode.c | 12 +- drivers/gpu/drm/bochs/bochs_kms.c | 4 +- drivers/gpu/drm/cirrus/cirrus_mode.c | 10 +- drivers/gpu/drm/drm_crtc.c | 189 +++++++++++---- drivers/gpu/drm/drm_crtc_helper.c | 20 +- drivers/gpu/drm/drm_fb_helper.c | 9 +- drivers/gpu/drm/drm_ioctl.c | 7 + drivers/gpu/drm/drm_plane_helper.c | 333 +++++++++++++++++++++++++++ drivers/gpu/drm/drm_stub.c | 5 + drivers/gpu/drm/exynos/exynos_drm_crtc.c | 22 +- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 2 +- drivers/gpu/drm/gma500/cdv_intel_display.c | 2 +- drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 +- drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 +- drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 +- drivers/gpu/drm/gma500/gma_display.c | 16 +- drivers/gpu/drm/gma500/mdfld_dsi_output.c | 2 +- drivers/gpu/drm/gma500/mdfld_intel_display.c | 16 +- drivers/gpu/drm/gma500/oaktrail_crtc.c | 12 +- drivers/gpu/drm/gma500/psb_intel_display.c | 2 +- drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 +- drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 4 +- drivers/gpu/drm/i915/i915_irq.c | 4 +- drivers/gpu/drm/i915/intel_display.c | 148 ++++++------ drivers/gpu/drm/i915/intel_dp.c | 4 +- drivers/gpu/drm/i915/intel_fbdev.c | 6 +- drivers/gpu/drm/i915/intel_overlay.c | 4 +- drivers/gpu/drm/i915/intel_pm.c | 38 +-- drivers/gpu/drm/mgag200/mgag200_mode.c | 26 +-- drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 33 +-- drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c | 8 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 27 ++- drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 8 +- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 20 +- drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +- drivers/gpu/drm/nouveau/nouveau_display.c | 8 +- drivers/gpu/drm/nouveau/nv50_display.c | 17 +- drivers/gpu/drm/omapdrm/omap_crtc.c | 10 +- drivers/gpu/drm/omapdrm/omap_fb.c | 2 +- drivers/gpu/drm/qxl/qxl_display.c | 10 +- drivers/gpu/drm/radeon/atombios_crtc.c | 20 +- drivers/gpu/drm/radeon/r100.c | 4 +- drivers/gpu/drm/radeon/radeon_connectors.c | 2 +- drivers/gpu/drm/radeon/radeon_device.c | 2 +- drivers/gpu/drm/radeon/radeon_display.c | 4 +- drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 16 +- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 10 +- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 16 +- drivers/gpu/drm/tegra/dc.c | 16 +- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 8 +- drivers/gpu/drm/udl/udl_modeset.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 14 +- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 8 +- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 8 +- drivers/staging/imx-drm/ipuv3-crtc.c | 6 +- include/drm/drmP.h | 6 + include/drm/drm_crtc.h | 50 +++- include/drm/drm_plane_helper.h | 49 ++++ include/uapi/drm/drm.h | 8 + 63 files changed, 985 insertions(+), 392 deletions(-) create mode 100644 drivers/gpu/drm/drm_plane_helper.c create mode 100644 include/drm/drm_plane_helper.h -- 1.8.5.1

1 14

[PATCHv4 00/13] Universal plane preparation patches
by Matt Roper 01 Apr '14

01 Apr '14

Previous series revisions & explanation at [1], [2], and [3] This version of the patch series focuses on isolating the DRM core changes from individual driver changes to (hopefully) make this a bit easier to merge. New plane and crtc initialization functions have been added to allow drivers to migrate to the new infrastructure at their own pace; existing drivers that do not update should continue to function as expected. The one remaining painful patch here is patch #12, which replaces crtc->fb with crtc->primary->fb. That patch is now auto-generated via a Coccinelle semantic patch with the rules described in the commit message; hopefully that will make life slightly easier for tree maintainers who want to pull it in. Daniel mentioned that we should try to merge the underlying infrastructure here without the actual userspace-facing capability bit to make sure things continue to run as expected without breaking; I've dropped the capability bit patch for now, but the previous version from [4] should work on top of this patch set. I've also dropped the i915 cursor support for the moment to keep the patch set simple. I believe the only userspace-visible changes in this series are the plane type property (which will always return "overlay" since there's no switch to turn on the other plane types) and max width/height plane properties. I figured properties were a little bit cleaner than extending GetPlane() to return additional information, although I can change that if people feel differently. Presumably we're still going to need a lot more properties that describe the limits and capabilities of planes as we go forward (stride, scaling, tiling, etc.) [1] http://lists.freedesktop.org/archives/dri-devel/2014-March/055855.html [2] http://lists.freedesktop.org/archives/dri-devel/2014-March/055222.html [3] http://lists.freedesktop.org/archives/dri-devel/2014-February/054719.html [4] http://lists.freedesktop.org/archives/dri-devel/2014-March/055216.html Matt Roper (13): drm: Add support for multiple plane types (v2) drm/exynos: Restrict plane loops to only operate on overlay planes (v2) drm/i915: Restrict plane loops to only operate on overlay planes (v2) drm/shmobile: Restrict plane loops to only operate on legacy planes drm: Make drm_crtc_check_viewport non-static drm: Add primary plane helpers (v2) drm: Add drm_universal_plane_init() drm: Add plane type property (v2) drm: Add plane max width/height properties drm: Add drm_crtc_init_with_planes() drm/msm: Switch to universal plane API's drm: Replace crtc fb with primary plane fb (v3) drm: Remove unused drm_crtc->fb drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/armada/armada_crtc.c | 23 +- drivers/gpu/drm/ast/ast_mode.c | 12 +- drivers/gpu/drm/bochs/bochs_kms.c | 4 +- drivers/gpu/drm/cirrus/cirrus_mode.c | 10 +- drivers/gpu/drm/drm_crtc.c | 228 ++++++++++++++++---- drivers/gpu/drm/drm_crtc_helper.c | 20 +- drivers/gpu/drm/drm_fb_helper.c | 9 +- drivers/gpu/drm/drm_plane_helper.c | 312 +++++++++++++++++++++++++++ drivers/gpu/drm/exynos/exynos_drm_crtc.c | 22 +- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 2 +- drivers/gpu/drm/gma500/cdv_intel_display.c | 2 +- drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 +- drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 +- drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 +- drivers/gpu/drm/gma500/gma_display.c | 16 +- drivers/gpu/drm/gma500/mdfld_dsi_output.c | 2 +- drivers/gpu/drm/gma500/mdfld_intel_display.c | 16 +- drivers/gpu/drm/gma500/oaktrail_crtc.c | 12 +- drivers/gpu/drm/gma500/psb_intel_display.c | 2 +- drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 +- drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 4 +- drivers/gpu/drm/i915/i915_irq.c | 4 +- drivers/gpu/drm/i915/intel_display.c | 148 +++++++------ drivers/gpu/drm/i915/intel_dp.c | 4 +- drivers/gpu/drm/i915/intel_fbdev.c | 6 +- drivers/gpu/drm/i915/intel_overlay.c | 4 +- drivers/gpu/drm/i915/intel_pm.c | 38 ++-- drivers/gpu/drm/mgag200/mgag200_mode.c | 26 +-- drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 33 +-- drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c | 8 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 27 +-- drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 8 +- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 20 +- drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +- drivers/gpu/drm/nouveau/nouveau_display.c | 8 +- drivers/gpu/drm/nouveau/nv50_display.c | 17 +- drivers/gpu/drm/omapdrm/omap_crtc.c | 10 +- drivers/gpu/drm/omapdrm/omap_fb.c | 2 +- drivers/gpu/drm/qxl/qxl_display.c | 10 +- drivers/gpu/drm/radeon/atombios_crtc.c | 20 +- drivers/gpu/drm/radeon/r100.c | 4 +- drivers/gpu/drm/radeon/radeon_connectors.c | 2 +- drivers/gpu/drm/radeon/radeon_device.c | 2 +- drivers/gpu/drm/radeon/radeon_display.c | 4 +- drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 16 +- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 10 +- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 16 +- drivers/gpu/drm/tegra/dc.c | 16 +- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 8 +- drivers/gpu/drm/udl/udl_modeset.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 14 +- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 8 +- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 8 +- drivers/staging/imx-drm/ipuv3-crtc.c | 6 +- include/drm/drm_crtc.h | 52 ++++- include/drm/drm_plane_helper.h | 49 +++++ 58 files changed, 940 insertions(+), 381 deletions(-) create mode 100644 drivers/gpu/drm/drm_plane_helper.c create mode 100644 include/drm/drm_plane_helper.h Cc: Intel Graphics Development <intel-gfx(a)lists.freedesktop.org> -- 1.8.5.1

5 34

[Bug 73911] Color Banding on radeon
by bugzilla-daemon＠freedesktop.org 01 Apr '14

01 Apr '14

https://bugs.freedesktop.org/show_bug.cgi?id=73911 Alex Deucher <agd5f(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93321|0 |1 is obsolete| | --- Comment #20 from Alex Deucher <agd5f(a)yahoo.com> --- Created attachment 96751 --> https://bugs.freedesktop.org/attachment.cgi?id=96751&action=edit testing patch Does this patch help? -- You are receiving this mail because: You are the assignee for the bug.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2014