dri-devel October 2015

dri-devel@lists.freedesktop.org

201 participants
1170 discussions

[Bug 91998] Object rendered completely black in The Book of Unwritten Tales: The Critter Chronicles
by bugzilla-daemon＠freedesktop.org 01 Oct '15

01 Oct '15

https://bugs.freedesktop.org/show_bug.cgi?id=91998 Bug ID: 91998 Summary: Object rendered completely black in The Book of Unwritten Tales: The Critter Chronicles Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: minor Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: daniel(a)constexpr.org QA Contact: dri-devel(a)lists.freedesktop.org apitrace: http://constexpr.org/tmp/BOUT-CC-radeonsi.1.trace.xz (95 MiB) The pipe behind the character is rendered completely black. The object is rendered without any shader but with fixed-function lighting enabled. Relevant draw call: 2336877 (in frame 1699) Disabling GL_LIGHTING, GL_LIGHT3 or setting the GL_DIFFUSE material to [0, 0, 0, 0] (including alpha) causes the pipe to be rendered correctly. Disabling the other lights has no effect. The GL_EMISSION material is set to [1, 1, 1, 1] for this draw call so the other lighting parameters should have no effect (unless they result in NaNs or negative values). GPU; Radeon HD 7950 (TAHITI) Mesa 11.1.0-devel (git-0337a9b) LLVM r247497 Linux 4.2.0-gentoo-r1 Everything is rendered correctly with llvmpipe. So far I have only found one object in the game affected by this. -- You are receiving this mail because: You are the assignee for the bug.

1 6

[RFC v3 0/7] MT8173 DRM support
by Philipp Zabel 01 Oct '15

01 Oct '15

Hi, this is an update to the MT8173 DRM support RFC. These patches have a build dependency on two other patches on top of v4.3-rc1: https://patchwork.kernel.org/patch/6914941 ("iommu: Implement common IOMMU ops for DMA mapping"), and https://patchwork.kernel.org/patch/6928621 ("memory: mediatek: Add SMI driver"). I have changed the device tree bindings to group the display function blocks under a display-subsystem node. I'm not happy with this organisation as the display-subsystem node is not really a physical bus. I'd much prefer connecting the function blocks with an of-graph, if it is acceptable for just the graph to cost >8 KiB dtb size. The added HDMI driver still directly accesses an undocumented register in the apmixedsys (clock-controller) register space to set a divider of the TVDPLL. That will be fixed as soon as I understand what this clock is connected to. Changes since v2: - Grouped DISP function block nodes under the display-subsystem node - Added of-graph ports to binding documentation - Dropped legacy framebuffer support - Dropped plane zpos property - Update plane->disp_size in atomic_update instead of atomic_check - Added asynchronous commit support - Split DSI and MIPI TX (MIPI D-PHY) drivers - Added DPI driver - Added HDMI driver - Added HDMI DDC I2C master driver - Added HDMI PHY driver CK Hu (3): dt-bindings: drm/mediatek: Add Mediatek display subsystem dts binding drm/mediatek: Add DRM Driver for Mediatek SoC MT8173. drm/mediatek: Add DSI sub driver Daniel Kurtz (1): drm/mediatek: Add HDMI support Jie Qiu (2): drm/mediatek: Add DPI sub driver drm/mediatek: enable hdmi output control bit Philipp Zabel (1): dt-bindings: drm/mediatek: Add Mediatek HDMI dts binding .../bindings/drm/mediatek/mediatek,disp.txt | 133 +++ .../bindings/drm/mediatek/mediatek,dpi.txt | 41 + .../bindings/drm/mediatek/mediatek,dsi.txt | 53 ++ .../bindings/drm/mediatek/mediatek,hdmi.txt | 117 +++ drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/mediatek/Kconfig | 22 + drivers/gpu/drm/mediatek/Makefile | 20 + drivers/gpu/drm/mediatek/mtk_dpi.c | 703 ++++++++++++++++ drivers/gpu/drm/mediatek/mtk_dpi.h | 83 ++ drivers/gpu/drm/mediatek/mtk_dpi_regs.h | 228 ++++++ drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 521 ++++++++++++ drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 84 ++ drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 218 +++++ drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 39 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 373 +++++++++ drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 61 ++ drivers/gpu/drm/mediatek/mtk_drm_drv.c | 546 +++++++++++++ drivers/gpu/drm/mediatek/mtk_drm_drv.h | 59 ++ drivers/gpu/drm/mediatek/mtk_drm_fb.c | 151 ++++ drivers/gpu/drm/mediatek/mtk_drm_fb.h | 29 + drivers/gpu/drm/mediatek/mtk_drm_gem.c | 207 +++++ drivers/gpu/drm/mediatek/mtk_drm_gem.h | 56 ++ drivers/gpu/drm/mediatek/mtk_drm_hdmi_drv.c | 648 +++++++++++++++ drivers/gpu/drm/mediatek/mtk_drm_plane.c | 175 ++++ drivers/gpu/drm/mediatek/mtk_drm_plane.h | 38 + drivers/gpu/drm/mediatek/mtk_dsi.c | 797 ++++++++++++++++++ drivers/gpu/drm/mediatek/mtk_dsi.h | 54 ++ drivers/gpu/drm/mediatek/mtk_hdmi.c | 521 ++++++++++++ drivers/gpu/drm/mediatek/mtk_hdmi.h | 120 +++ drivers/gpu/drm/mediatek/mtk_hdmi_ddc_drv.c | 362 ++++++++ drivers/gpu/drm/mediatek/mtk_hdmi_hw.c | 906 +++++++++++++++++++++ drivers/gpu/drm/mediatek/mtk_hdmi_hw.h | 76 ++ drivers/gpu/drm/mediatek/mtk_hdmi_phy.c | 320 ++++++++ drivers/gpu/drm/mediatek/mtk_hdmi_phy.h | 20 + drivers/gpu/drm/mediatek/mtk_hdmi_regs.h | 355 ++++++++ drivers/gpu/drm/mediatek/mtk_mipi_tx.c | 375 +++++++++ drivers/gpu/drm/mediatek/mtk_mipi_tx.h | 21 + include/drm/mediatek/mtk_hdmi_audio.h | 150 ++++ 39 files changed, 8685 insertions(+) create mode 100644 Documentation/devicetree/bindings/drm/mediatek/mediatek,disp.txt create mode 100644 Documentation/devicetree/bindings/drm/mediatek/mediatek,dpi.txt create mode 100644 Documentation/devicetree/bindings/drm/mediatek/mediatek,dsi.txt create mode 100644 Documentation/devicetree/bindings/drm/mediatek/mediatek,hdmi.txt create mode 100644 drivers/gpu/drm/mediatek/Kconfig create mode 100644 drivers/gpu/drm/mediatek/Makefile create mode 100644 drivers/gpu/drm/mediatek/mtk_dpi.c create mode 100644 drivers/gpu/drm/mediatek/mtk_dpi.h create mode 100644 drivers/gpu/drm/mediatek/mtk_dpi_regs.h create mode 100644 drivers/gpu/drm/mediatek/mtk_drm_crtc.c create mode 100644 drivers/gpu/drm/mediatek/mtk_drm_crtc.h create mode 100644 drivers/gpu/drm/mediatek/mtk_drm_ddp.c create mode 100644 drivers/gpu/drm/mediatek/mtk_drm_ddp.h create mode 100644 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c create mode 100644 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h create mode 100644 drivers/gpu/drm/mediatek/mtk_drm_drv.c create mode 100644 drivers/gpu/drm/mediatek/mtk_drm_drv.h create mode 100644 drivers/gpu/drm/mediatek/mtk_drm_fb.c create mode 100644 drivers/gpu/drm/mediatek/mtk_drm_fb.h create mode 100644 drivers/gpu/drm/mediatek/mtk_drm_gem.c create mode 100644 drivers/gpu/drm/mediatek/mtk_drm_gem.h create mode 100644 drivers/gpu/drm/mediatek/mtk_drm_hdmi_drv.c create mode 100644 drivers/gpu/drm/mediatek/mtk_drm_plane.c create mode 100644 drivers/gpu/drm/mediatek/mtk_drm_plane.h create mode 100644 drivers/gpu/drm/mediatek/mtk_dsi.c create mode 100644 drivers/gpu/drm/mediatek/mtk_dsi.h create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi.c create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi.h create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi_ddc_drv.c create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi_hw.c create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi_hw.h create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi_phy.c create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi_phy.h create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi_regs.h create mode 100644 drivers/gpu/drm/mediatek/mtk_mipi_tx.c create mode 100644 drivers/gpu/drm/mediatek/mtk_mipi_tx.h create mode 100644 include/drm/mediatek/mtk_hdmi_audio.h -- 2.5.3

2 9

[PATCH] vgaarb: use kzalloc in vga_arbiter_add_pci_device()
by Rasmus Villemoes 01 Oct '15

01 Oct '15

Signed-off-by: Rasmus Villemoes <linux(a)rasmusvillemoes.dk> --- drivers/gpu/vga/vgaarb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c index a0b433456107..3166e4bc4eb6 100644 --- a/drivers/gpu/vga/vgaarb.c +++ b/drivers/gpu/vga/vgaarb.c @@ -531,7 +531,7 @@ static bool vga_arbiter_add_pci_device(struct pci_dev *pdev) return false; /* Allocate structure */ - vgadev = kmalloc(sizeof(struct vga_device), GFP_KERNEL); + vgadev = kzalloc(sizeof(struct vga_device), GFP_KERNEL); if (vgadev == NULL) { pr_err("failed to allocate pci device\n"); /* @@ -541,8 +541,6 @@ static bool vga_arbiter_add_pci_device(struct pci_dev *pdev) return false; } - memset(vgadev, 0, sizeof(*vgadev)); - /* Take lock & check for duplicates */ spin_lock_irqsave(&vga_lock, flags); if (vgadev_find(pdev) != NULL) { -- 2.1.3

3 2

[PATCH 0/6] scripts/kernel-doc: Kernel-doc improvements
by Danilo Cesar Lemes de Paula 01 Oct '15

01 Oct '15

The following series contains: * kernel-doc: markdown support and improvements. * Fixing kernel-doc highlights. * Improve doc support for functions and structs with same name. * misc small fixes for drm docbook. Signed-off-by: Danilo Cesar Lemes de Paula <danilo.cesar(a)collabora.co.uk> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Cc: Jonathan Corbet <corbet(a)lwn.net> Cc: Andrew Morton <akpm(a)linux-foundation.org> Cc: Johannes Berg <johannes.berg(a)intel.com> Cc: linux-kernel(a)vger.kernel.org Cc: linux-doc(a)vger.kernel.org Cc: intel-gfx <intel-gfx(a)lists.freedesktop.org> Cc: dri-devel <dri-devel(a)lists.freedesktop.org> Danilo Cesar Lemes de Paula (6): scripts/kernel-doc: Replacing highlights hash by an array scripts/kernel-doc: Adding infrastructure for markdown support drm/doc: Convert to markdown drm/doc: Fixing xml documentation warning scripts/kernel-doc: Improve Markdown results scripts/kernel-doc: Processing -nofunc for functions only Documentation/DocBook/Makefile | 25 +++-- Documentation/DocBook/drm.tmpl | 86 --------------- drivers/gpu/drm/drm_modes.c | 12 +-- drivers/gpu/drm/drm_modeset_lock.c | 14 ++- drivers/gpu/drm/drm_prime.c | 16 ++- drivers/gpu/drm/i915/i915_reg.h | 48 ++++----- include/drm/drm_modeset_lock.h | 10 +- include/drm/drm_vma_manager.h | 10 +- scripts/docproc.c | 54 +++++++--- scripts/kernel-doc | 216 ++++++++++++++++++++++++++----------- 10 files changed, 264 insertions(+), 227 deletions(-) -- 2.4.3

5 14

[PATCH] drm: Don't zero vblank timestamps from the irq handler
by ville.syrjala＠linux.intel.com 01 Oct '15

01 Oct '15

From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> If we couldn't get a high precisions vblank timestamp, we currently store a zeroed timestamp instead and assume the next vblank irq to get us something better. This makes sense when trying to update the timestamp from eg. vblank enable. But if we do this from the vblank irq we will never get a vblank timestamp unless we high precision timestamps are available and succeeded. This break weston for instance on drivers lacking high precision timestamps. To fix this, zero the timestamp only when not called from vbl irq. When called from the irq, we still want the timestamp, even if not perfect. This fixes a regression from 4dfd64862ff852df drm: Use vblank timestamps to guesstimate how many vblanks were missed Cc: Mario Kleiner <mario.kleiner.de(a)gmail.com> Cc: Thierry Reding <thierry.reding(a)gmail.com> Reported-by: Thierry Reding <thierry.reding(a)gmail.com> Signed-off-by: Ville Syrjälä <ville.syrjala(a)linux.intel.com> --- drivers/gpu/drm/drm_irq.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index f24c57c..1b9faa0 100644 --- a/drivers/gpu/drm/drm_irq.c +++ b/drivers/gpu/drm/drm_irq.c @@ -232,10 +232,11 @@ static void drm_update_vblank_count(struct drm_device *dev, unsigned int pipe, /* * Only reinitialize corresponding vblank timestamp if high-precision query - * available and didn't fail. Otherwise reinitialize delayed at next vblank - * interrupt and assign 0 for now, to mark the vblanktimestamp as invalid. + * available and didn't fail, or we were called from the vblank interrupt. + * Otherwise reinitialize delayed at next vblank interrupt and assign 0 + * for now, to mark the vblanktimestamp as invalid. */ - if (!rc) + if (!rc && (flags & DRM_CALLED_FROM_VBLIRQ) == 0) t_vblank = (struct timeval) {0, 0}; store_vblank(dev, pipe, diff, &t_vblank, cur_vblank); -- 2.4.6

3 2

[PATCH 1/2] drm: Add DRM_ROTATE_MASK and DRM_REFLECT_MASK
by Joonas Lahtinen 01 Oct '15

01 Oct '15

Makes it cleaner to separate the two from rotation variable. Cc: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Signed-off-by: Joonas Lahtinen <joonas.lahtinen(a)linux.intel.com> --- include/drm/drm_crtc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 683f142..33ddedd 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -86,10 +86,12 @@ static inline uint64_t I642U64(int64_t val) } /* rotation property bits */ +#define DRM_ROTATE_MASK 0x0f #define DRM_ROTATE_0 0 #define DRM_ROTATE_90 1 #define DRM_ROTATE_180 2 #define DRM_ROTATE_270 3 +#define DRM_REFLECT_MASK (~DRM_ROTATE_MASK) #define DRM_REFLECT_X 4 #define DRM_REFLECT_Y 5 -- 2.4.3

2 2

linux-next: build failure after merge of the drm-misc tree
by Stephen Rothwell 01 Oct '15

01 Oct '15

Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this: ERROR: "drm_agp_release" [drivers/gpu/drm/radeon/radeon.ko] undefined! ERROR: "drm_agp_acquire" [drivers/gpu/drm/radeon/radeon.ko] undefined! ERROR: "drm_agp_enable" [drivers/gpu/drm/radeon/radeon.ko] undefined! ERROR: "drm_agp_info" [drivers/gpu/drm/radeon/radeon.ko] undefined! ERROR: "drm_agp_release" [drivers/gpu/drm/mga/mga.ko] undefined! ERROR: "drm_agp_acquire" [drivers/gpu/drm/mga/mga.ko] undefined! ERROR: "drm_agp_free" [drivers/gpu/drm/mga/mga.ko] undefined! ERROR: "drm_agp_bind" [drivers/gpu/drm/mga/mga.ko] undefined! ERROR: "drm_agp_unbind" [drivers/gpu/drm/mga/mga.ko] undefined! ERROR: "drm_agp_alloc" [drivers/gpu/drm/mga/mga.ko] undefined! ERROR: "drm_agp_enable" [drivers/gpu/drm/mga/mga.ko] undefined! ERROR: "drm_agp_info" [drivers/gpu/drm/mga/mga.ko] undefined! ERROR: "drm_agp_unbind_ioctl" [drivers/gpu/drm/drm.ko] undefined! ERROR: "drm_agp_init" [drivers/gpu/drm/drm.ko] undefined! ERROR: "drm_agp_alloc_ioctl" [drivers/gpu/drm/drm.ko] undefined! ERROR: "drm_agp_clear" [drivers/gpu/drm/drm.ko] undefined! ERROR: "drm_agp_info_ioctl" [drivers/gpu/drm/drm.ko] undefined! ERROR: "drm_agp_enable_ioctl" [drivers/gpu/drm/drm.ko] undefined! ERROR: "drm_agp_release_ioctl" [drivers/gpu/drm/drm.ko] undefined! ERROR: "drm_agp_bind_ioctl" [drivers/gpu/drm/drm.ko] undefined! ERROR: "drm_agp_acquire_ioctl" [drivers/gpu/drm/drm.ko] undefined! ERROR: "drm_agp_free_ioctl" [drivers/gpu/drm/drm.ko] undefined! Not quite sure which commit caused this, but I have used the drm-misc tree from next-20150930 for today. -- Cheers, Stephen Rothwell sfr(a)canb.auug.org.au

2 1

[GIT PULL] exynos-drm-fixes
by Inki Dae 01 Oct '15

01 Oct '15

Hi Dave, This pull request includes regression fixups, build warnings, and trivial cleanups which mostly remove some codes not used anymore. Please, kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit fd03420b5624617a708fb9b13634b41b37c22cfa: Merge tag 'drm-intel-fixes-2015-09-24' of git://anongit.freedesktop.org/drm-intel into drm-fixes (2015-09-25 06:52:37 +1000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos exynos-drm-fixes for you to fetch changes up to cda374253f862bd0f43edda6935a48294fe8ed3e: drm/exynos: Staticize local function in exynos_drm_gem.c (2015-10-01 14:29:51 +0900) ---------------------------------------------------------------- Daniel Kurtz (1): drm/exynos: Remove useless EXPORT_SYMBOL_GPLs Gustavo Padovan (4): drm/exynos: remove fimd_mode_fixup() drm/exynos: remove decon_mode_fixup() drm/exynos: remove unused mode_fixup() code drm/exynos: fimd: actually disable dp clock Inki Dae (1): drm/exynos: dp: remove suspend/resume functions Joonyoung Shim (8): drm/exynos: fix layering violation of address drm/exynos: fix missed calling of drm_prime_gem_destroy() drm/exynos: remove unnecessary NULL assignment drm/exynos: staticize exynos_drm_gem_init() drm/exynos: cleanup function calling written twice drm/exynos: cleanup line feed in exynos_drm_gem_get_ioctl drm/exynos: remove call to drm_gem_free_mmap_offset() drm/exynos: create a fake mmap offset with gem creation Krzysztof Kozlowski (1): drm/exynos: Staticize local function in exynos_drm_gem.c Thierry Reding (3): drm/exynos: Suspend/resume is unused if !PM drm/exynos: fimc: Clock control is unused if !PM drm/exynos: rotator: Clock control is unused if !PM drivers/gpu/drm/exynos/exynos7_drm_decon.c | 12 ---- drivers/gpu/drm/exynos/exynos_dp_core.c | 23 ------- drivers/gpu/drm/exynos/exynos_drm_core.c | 6 -- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 15 ----- drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 + drivers/gpu/drm/exynos/exynos_drm_drv.h | 4 -- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 36 +++++------ drivers/gpu/drm/exynos/exynos_drm_fimd.c | 14 +---- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 - drivers/gpu/drm/exynos/exynos_drm_gem.c | 94 +++++++++++++---------------- drivers/gpu/drm/exynos/exynos_drm_gem.h | 6 +- drivers/gpu/drm/exynos/exynos_drm_rotator.c | 2 +- 12 files changed, 65 insertions(+), 152 deletions(-)

1 0

[RESEND] drm/exynos: Staticize local function in exynos_drm_gem.c
by Krzysztof Kozlowski 01 Oct '15

01 Oct '15

The exynos_drm_gem_mmap_buffer() is not used outside so make it static. Signed-off-by: Krzysztof Kozlowski <k.kozlowski(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c index f12fbc36b120..ba9cadb9acef 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c @@ -313,7 +313,7 @@ void exynos_drm_gem_put_dma_addr(struct drm_device *dev, drm_gem_object_unreference_unlocked(obj); } -int exynos_drm_gem_mmap_buffer(struct exynos_drm_gem_obj *exynos_gem_obj, +static int exynos_drm_gem_mmap_buffer(struct exynos_drm_gem_obj *exynos_gem_obj, struct vm_area_struct *vma) { struct drm_device *drm_dev = exynos_gem_obj->base.dev; -- 1.9.1

1 0

[PATCH 1/2] drm/dp_mst: make functions that always return 0 return void.
by Dave Airlie 01 Oct '15

01 Oct '15

This just drops the return and assigning it to a len variable that never gets used. Signed-off-by: Dave Airlie <airlied(a)redhat.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 29 ++++++++++------------------- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index e23df5f..294d904 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -631,7 +631,7 @@ static bool drm_dp_sideband_parse_req(struct drm_dp_sideband_msg_rx *raw, } } -static int build_dpcd_write(struct drm_dp_sideband_msg_tx *msg, u8 port_num, u32 offset, u8 num_bytes, u8 *bytes) +static void build_dpcd_write(struct drm_dp_sideband_msg_tx *msg, u8 port_num, u32 offset, u8 num_bytes, u8 *bytes) { struct drm_dp_sideband_msg_req_body req; @@ -641,20 +641,17 @@ static int build_dpcd_write(struct drm_dp_sideband_msg_tx *msg, u8 port_num, u32 req.u.dpcd_write.num_bytes = num_bytes; req.u.dpcd_write.bytes = bytes; drm_dp_encode_sideband_req(&req, msg); - - return 0; } -static int build_link_address(struct drm_dp_sideband_msg_tx *msg) +static void build_link_address(struct drm_dp_sideband_msg_tx *msg) { struct drm_dp_sideband_msg_req_body req; req.req_type = DP_LINK_ADDRESS; drm_dp_encode_sideband_req(&req, msg); - return 0; } -static int build_enum_path_resources(struct drm_dp_sideband_msg_tx *msg, int port_num) +static void build_enum_path_resources(struct drm_dp_sideband_msg_tx *msg, int port_num) { struct drm_dp_sideband_msg_req_body req; @@ -662,10 +659,9 @@ static int build_enum_path_resources(struct drm_dp_sideband_msg_tx *msg, int por req.u.port_num.port_number = port_num; drm_dp_encode_sideband_req(&req, msg); msg->path_msg = true; - return 0; } -static int build_allocate_payload(struct drm_dp_sideband_msg_tx *msg, int port_num, +static void build_allocate_payload(struct drm_dp_sideband_msg_tx *msg, int port_num, u8 vcpi, uint16_t pbn) { struct drm_dp_sideband_msg_req_body req; @@ -676,7 +672,6 @@ static int build_allocate_payload(struct drm_dp_sideband_msg_tx *msg, int port_n req.u.allocate_payload.pbn = pbn; drm_dp_encode_sideband_req(&req, msg); msg->path_msg = true; - return 0; } static int drm_dp_mst_assign_payload_id(struct drm_dp_mst_topology_mgr *mgr, @@ -1461,7 +1456,6 @@ static void drm_dp_queue_down_tx(struct drm_dp_mst_topology_mgr *mgr, static int drm_dp_send_link_address(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_branch *mstb) { - int len; struct drm_dp_sideband_msg_tx *txmsg; int ret; @@ -1470,7 +1464,7 @@ static int drm_dp_send_link_address(struct drm_dp_mst_topology_mgr *mgr, return -ENOMEM; txmsg->dst = mstb; - len = build_link_address(txmsg); + build_link_address(txmsg); drm_dp_queue_down_tx(mgr, txmsg); @@ -1510,7 +1504,6 @@ static int drm_dp_send_enum_path_resources(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_branch *mstb, struct drm_dp_mst_port *port) { - int len; struct drm_dp_sideband_msg_tx *txmsg; int ret; @@ -1519,7 +1512,7 @@ static int drm_dp_send_enum_path_resources(struct drm_dp_mst_topology_mgr *mgr, return -ENOMEM; txmsg->dst = mstb; - len = build_enum_path_resources(txmsg, port->port_num); + build_enum_path_resources(txmsg, port->port_num); drm_dp_queue_down_tx(mgr, txmsg); @@ -1547,7 +1540,7 @@ static int drm_dp_payload_send_msg(struct drm_dp_mst_topology_mgr *mgr, { struct drm_dp_sideband_msg_tx *txmsg; struct drm_dp_mst_branch *mstb; - int len, ret; + int ret; mstb = drm_dp_get_validated_mstb_ref(mgr, port->parent); if (!mstb) @@ -1560,9 +1553,8 @@ static int drm_dp_payload_send_msg(struct drm_dp_mst_topology_mgr *mgr, } txmsg->dst = mstb; - len = build_allocate_payload(txmsg, port->port_num, - id, - pbn); + build_allocate_payload(txmsg, port->port_num, + id, pbn); drm_dp_queue_down_tx(mgr, txmsg); @@ -1772,7 +1764,6 @@ static int drm_dp_send_dpcd_write(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, int offset, int size, u8 *bytes) { - int len; int ret; struct drm_dp_sideband_msg_tx *txmsg; struct drm_dp_mst_branch *mstb; @@ -1787,7 +1778,7 @@ static int drm_dp_send_dpcd_write(struct drm_dp_mst_topology_mgr *mgr, goto fail_put; } - len = build_dpcd_write(txmsg, port->port_num, offset, size, bytes); + build_dpcd_write(txmsg, port->port_num, offset, size, bytes); txmsg->dst = mstb; drm_dp_queue_down_tx(mgr, txmsg); -- 2.4.3

2 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2015