dri-devel April 2015

dri-devel@lists.freedesktop.org

175 participants
1044 discussions

[pull] radeon drm-next-4.1
by Alex Deucher 13 Apr '15

13 Apr '15

Hi Dave, Some final bits for 4.1. Some fixes for userptrs and allow a new packet for VCE to enable some new features in mesa. The following changes since commit 1d8ac08d498d579aae36221a80b4b724b2f52f39: Merge tag 'v4.0-rc7' into drm-next (2015-04-09 07:48:27 +1000) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-next-4.1 for you to fetch changes up to 49ecb10e01c68b05dcb73005a54430c15caa05d0: drm/radeon: allow creating overlapping userptrs (2015-04-13 11:17:59 -0400) ---------------------------------------------------------------- Christian König (2): drm/radeon: add userptr config option drm/radeon: allow creating overlapping userptrs Leo Liu (1): drm/radeon: add video usability info support for VCE drivers/gpu/drm/radeon/Kconfig | 8 +++ drivers/gpu/drm/radeon/radeon.h | 2 +- drivers/gpu/drm/radeon/radeon_drv.c | 3 +- drivers/gpu/drm/radeon/radeon_mn.c | 102 ++++++++++++++++++++++++++---------- drivers/gpu/drm/radeon/radeon_vce.c | 1 + 5 files changed, 87 insertions(+), 29 deletions(-)

1 0

[PATCH] drm/exynos: fimd: fix buffer size calculation
by Marek Szyprowski 13 Apr '15

13 Apr '15

Commit adacb228d72b9529f8de0769cc33414c3012054d ("drm: Exynos: Respect framebuffer pitch for FIMD/Mixer") changed the way of buffer size calcularion: it replaced fb_width by fb_pitch entry. fb_pitch however already contains '(win_data->bpp >> 3)' factor, so it should be removed from final buffer size calculation formula. This patch fixes this issue, solving possible IOMMU page fault caused by FIMD module accessing memory outside of the given display buffer. Signed-off by: Marek Szyprowski <m.szyprowski(a)samsung.com> CC: stable(a)vger.kernel.org # v4.0+ --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 0e93ed792224..f29a13e0524c 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -689,7 +689,7 @@ static void fimd_win_commit(struct exynos_drm_crtc *crtc, unsigned int win) writel(val, ctx->regs + VIDWx_BUF_START(win, 0)); /* buffer end address */ - size = plane->pitch * plane->crtc_height * (plane->bpp >> 3); + size = plane->pitch * plane->crtc_height; val = (unsigned long)(dma_addr + size); writel(val, ctx->regs + VIDWx_BUF_END(win, 0)); -- 1.9.2

3 2

Valve games for Mesa/DRI developers
by Daniel Stone 13 Apr '15

13 Apr '15

Hi, At Collabora (my lovely dayjob), we've been working with Valve on SteamOS. Valve are keen to give back to the community, and we've been discussing ways they can help do that, including providing free access to Valve games on Steam to Debian developers last year. We're happy to say that this has been extended to Mesa developers as well, to say thanks for all the great work. If you have 25 commits or more (an arbitrary number) to Mesa[0] in the past five years, please drop me an email (with 'Steam' in the subject) with your freedesktop username and Steam username. We can then get you access to all past and future Valve-produced games available on Steam[1]. Thanks for all the great work, and enjoy. Cheers, Daniel [0]: Or DRI-type stuff in the kernel too. [1]: Currently this looks like https://store.steampowered.com/search/?snr=1_4_4__12&term=#category1=998&pu…

2 2

[PATCH RESEND] drm/edid: add #defines for ELD versions
by Jani Nikula 13 Apr '15

13 Apr '15

Add ELD versions according to HDA Specification v1.0a. 2 indicates version 2, which supports CEA_Ver 861D or below. Maximum Baseline ELD size of 80 bytes (15 SAD count). 31 indicates an ELD that has been partially populated through implementation specific mean of default programming before an external graphics driver is loaded. Only the field that is called out as "canned" field will be populated, and audio driver should ignore the non "canned" field. Signed-off-by: Jani Nikula <jani.nikula(a)intel.com> --- include/drm/drm_edid.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h index 87d85e81d3a7..799050198323 100644 --- a/include/drm/drm_edid.h +++ b/include/drm/drm_edid.h @@ -215,6 +215,8 @@ struct detailed_timing { #define DRM_ELD_VER 0 # define DRM_ELD_VER_SHIFT 3 # define DRM_ELD_VER_MASK (0x1f << 3) +# define DRM_ELD_VER_CEA861D (2 << 3) /* supports 861D or below */ +# define DRM_ELD_VER_CANNED (0x1f << 3) #define DRM_ELD_BASELINE_ELD_LEN 2 /* in dwords! */ -- 2.1.4

3 2

[PATCH libdrm 1/5] modetest: fix Segmentation fault
by Joonyoung Shim 13 Apr '15

13 Apr '15

If use -P option without -s option, we meet Segmentation fault error when modetest is terminated. Check whether dev.mode.bo is NULL. Signed-off-by: Joonyoung Shim <jy0922.shim(a)samsung.com> --- tests/modetest/modetest.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 5f46efd..b59f6b5 100644 --- a/tests/modetest/modetest.c +++ b/tests/modetest/modetest.c @@ -1113,6 +1113,12 @@ static void set_mode(struct device *dev, struct pipe_arg *pipes, unsigned int co dev->mode.fb_id = fb_id; } +static void clear_mode(struct device *dev) +{ + if (dev->mode.bo) + bo_destroy(dev->mode.bo); +} + static void set_planes(struct device *dev, struct plane_arg *p, unsigned int count) { unsigned int i; @@ -1636,7 +1642,8 @@ int main(int argc, char **argv) if (test_cursor) clear_cursors(&dev); - bo_destroy(dev.mode.bo); + if (count) + clear_mode(&dev); } free_resources(dev.resources); -- 1.9.1

1 4

[PATCH 1/3] drm/radeon: constify more struct drm_*_helper funcs pointers
by Jani Nikula 13 Apr '15

13 Apr '15

Some non-const pointers were added since the last constification, fix them. Signed-off-by: Jani Nikula <jani.nikula(a)intel.com> --- drivers/gpu/drm/radeon/radeon_connectors.c | 4 ++-- drivers/gpu/drm/radeon/radeon_dp_mst.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c index f150c2495fa4..cebb65e07e1d 100644 --- a/drivers/gpu/drm/radeon/radeon_connectors.c +++ b/drivers/gpu/drm/radeon/radeon_connectors.c @@ -751,7 +751,7 @@ static int radeon_connector_set_property(struct drm_connector *connector, struct if (connector->encoder) radeon_encoder = to_radeon_encoder(connector->encoder); else { - struct drm_connector_helper_funcs *connector_funcs = connector->helper_private; + const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private; radeon_encoder = to_radeon_encoder(connector_funcs->best_encoder(connector)); } @@ -762,7 +762,7 @@ static int radeon_connector_set_property(struct drm_connector *connector, struct if (connector->encoder->crtc) { struct drm_crtc *crtc = connector->encoder->crtc; - struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private; + const struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private; struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc); radeon_crtc->output_csc = radeon_encoder->output_csc; diff --git a/drivers/gpu/drm/radeon/radeon_dp_mst.c b/drivers/gpu/drm/radeon/radeon_dp_mst.c index 5952ff2bb647..1017338a49d9 100644 --- a/drivers/gpu/drm/radeon/radeon_dp_mst.c +++ b/drivers/gpu/drm/radeon/radeon_dp_mst.c @@ -604,7 +604,7 @@ radeon_dp_create_fake_mst_encoder(struct radeon_connector *connector) struct radeon_encoder *radeon_encoder; struct radeon_encoder_mst *mst_enc; struct drm_encoder *encoder; - struct drm_connector_helper_funcs *connector_funcs = connector->base.helper_private; + const struct drm_connector_helper_funcs *connector_funcs = connector->base.helper_private; struct drm_encoder *enc_master = connector_funcs->best_encoder(&connector->base); DRM_DEBUG_KMS("enc master is %p\n", enc_master); -- 2.1.4

2 4

[PATCH] Revert "drm/i915: Performed deferred clflush inside set-cache-level"
by Sudip Mukherjee 13 Apr '15

13 Apr '15

This reverts commit <0f71979ab7fbd0c71c41c2798de3d33937915434>. my display was getting garbled for a moment very frequently. it looked like when the screen was getting refreshed then something was going wrong. git bisect gave this as the first bad commit, and after reverting it now display is not having that problem. Signed-off-by: Sudip Mukherjee <sudip(a)vectorindia.org> --- my system is x86_64. lspci -k gives: "VGA compatible controller: Intel Corporation Xeon E3-1200 v2/3rd Gen Core processor Graphics Controller (rev 09) Subsystem: Foxconn International, Inc. Device 0d74 Kernel driver in use: i915" This is my bisect log: # bad: [e42391cd048809d903291d07f86ed3934ce138e9] Linux 4.0-rc6 # good: [b7392d2247cfe6771f95d256374f1a8e6a6f48d6] Linux 3.19-rc2 git bisect start 'v4.0-rc6' 'v3.19-rc2' '--' 'drivers/gpu/drm/i915/' # good: [d2182a660808d9053a605e3ebc8c46a323ec6e5d] drm/i915: Don't register HDMI connectors for eDP ports on VLV/CHV git bisect good d2182a660808d9053a605e3ebc8c46a323ec6e5d # bad: [36d21f4c557a2b18ed7c9d254060d4ca07a6c5c7] drm/i915/dsi: remove unnecessary dsi device callbacks git bisect bad 36d21f4c557a2b18ed7c9d254060d4ca07a6c5c7 # good: [72f95afa5faaf899f7344879b6ccd5f0cb271b28] drm/i915: Removed duplicate members from submit_request git bisect good 72f95afa5faaf899f7344879b6ccd5f0cb271b28 # good: [2844a9214759901f382086644842e39ad6f7d894] drm/i915: Use pipe_name() in the get_plane_config() functions git bisect good 2844a9214759901f382086644842e39ad6f7d894 # bad: [1b842c89bd8eb0e9619e1aba071c9a5529b7a179] drm/i915: Fix kzalloc() smatch warnings in get_initial_plane_config() git bisect bad 1b842c89bd8eb0e9619e1aba071c9a5529b7a179 # good: [8d360dffd6d8634868e433128d5178bea14cc42c] drm/i915: Specify bsd rings through exec flag git bisect good 8d360dffd6d8634868e433128d5178bea14cc42c # good: [1197b4f230fb7c8fe3a9b549596fe130b09a0db2] drm/i915: Balance context pinning on reset cleanup git bisect good 1197b4f230fb7c8fe3a9b549596fe130b09a0db2 # bad: [0f71979ab7fbd0c71c41c2798de3d33937915434] drm/i915: Performed deferred clflush inside set-cache-level git bisect bad 0f71979ab7fbd0c71c41c2798de3d33937915434 # good: [a7cbedec8317a5cacecb567674fdbc1c3fb22de8] drm/i915: Rename unpin_count to pin_count git bisect good a7cbedec8317a5cacecb567674fdbc1c3fb22de8 drivers/gpu/drm/i915/i915_drv.h | 1 - drivers/gpu/drm/i915/i915_gem.c | 31 ++++++++++++++++++++++--------- 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 8727086..abe6c16 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -2054,7 +2054,6 @@ struct drm_i915_gem_object { */ unsigned long gt_ro:1; unsigned int cache_level:3; - unsigned int cache_dirty:1; unsigned int has_dma_mapping:1; diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 27ea6bd..e9341e9 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -3647,14 +3647,11 @@ i915_gem_clflush_object(struct drm_i915_gem_object *obj, * snooping behaviour occurs naturally as the result of our domain * tracking. */ - if (!force && cpu_cache_is_coherent(obj->base.dev, obj->cache_level)) { - obj->cache_dirty = true; + if (!force && cpu_cache_is_coherent(obj->base.dev, obj->cache_level)) return false; - } trace_i915_gem_object_clflush(obj); drm_clflush_sg(obj->pages); - obj->cache_dirty = false; return true; } @@ -3836,11 +3833,27 @@ int i915_gem_object_set_cache_level(struct drm_i915_gem_object *obj, vma->node.color = cache_level; obj->cache_level = cache_level; - if (obj->cache_dirty && - obj->base.write_domain != I915_GEM_DOMAIN_CPU && - cpu_write_needs_clflush(obj)) { - if (i915_gem_clflush_object(obj, true)) - i915_gem_chipset_flush(obj->base.dev); + if (cpu_write_needs_clflush(obj)) { + u32 old_read_domains, old_write_domain; + + /* If we're coming from LLC cached, then we haven't + * actually been tracking whether the data is in the + * CPU cache or not, since we only allow one bit set + * in obj->write_domain and have been skipping the clflushes. + * Just set it to the CPU cache for now. + */ + i915_gem_object_retire(obj); + WARN_ON(obj->base.write_domain & ~I915_GEM_DOMAIN_CPU); + + old_read_domains = obj->base.read_domains; + old_write_domain = obj->base.write_domain; + + obj->base.read_domains = I915_GEM_DOMAIN_CPU; + obj->base.write_domain = I915_GEM_DOMAIN_CPU; + + trace_i915_gem_object_change_domain(obj, + old_read_domains, + old_write_domain); } return 0; -- 1.8.1.2

2 3

[GIT PULL] exynos-drm-next
by Inki Dae 13 Apr '15

13 Apr '15

Hi Dave, This pull request contains just cleanup for atomic pageflip/modeset support, and some fixeups. We wanted to merge atomic pageflip/modeset feature support, new drivers - MIC and DECON for exynos5433 SoC - and relevant patches this time. However, I'd found that these features are not only safe enough but also aren't tested yet. So for them, I'd like to have enough times for the reviews. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 1d8ac08d498d579aae36221a80b4b724b2f52f39: Merge tag 'v4.0-rc7' into drm-next (2015-04-09 07:48:27 +1000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos exynos-drm-next for you to fetch changes up to 68a2913407d8defac36f381e4877507a06e57c8e: drm/exynos: Fix FIMD buffer size calculation (2015-04-13 11:48:20 +0900) ---------------------------------------------------------------- Beata Michalska (1): drm/exynos/ipp: Validate buffer enqueue requests Daniel Stone (1): drm/exynos: Fix FIMD buffer size calculation Gustavo Padovan (7): drm/exynos: fimd: fix alpha setting for XR24 pixel format drm/exynos: remove unused exynos_crtc->win_enable() callback drm/exynos: remove struct *_win_data abstraction on planes drm/exynos: preset zpos value for overlay planes drm/exynos: make zpos property immutable drm/exynos: remove exynos_plane_destroy() drm/exynos: remove leftover functions declarations Hyungwon Hwang (2): drm/exynos: dsi: remove the empty mode_valid callback drm/exynos: fimd: check whether exynos_drm_crtc_create succeed or not Joonyoung Shim (2): drm/exynos: use src_x and src_y instead of fb_x and fb_y drm/exynos: add ratio calculation Krzysztof Kozlowski (1): drm/exynos: Enable DP clock to fix display on Exynos5250 and other Mandeep Singh Baines (1): drm/exynos: track vblank events on a per crtc basis Tobias Jakobi (3): drm/exynos: fix typos in hdmi and mixer drm/exynos: remove superfluous error messages drm/exynos: mixer: add 2x scaling to mixer_graph_buffer drivers/gpu/drm/exynos/exynos7_drm_decon.c | 178 +++++++------------ drivers/gpu/drm/exynos/exynos_dp_core.c | 10 ++ drivers/gpu/drm/exynos/exynos_drm_crtc.c | 101 +++++------ drivers/gpu/drm/exynos/exynos_drm_crtc.h | 7 +- drivers/gpu/drm/exynos/exynos_drm_drv.c | 27 --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 40 ++--- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 7 - drivers/gpu/drm/exynos/exynos_drm_fb.c | 10 +- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 251 ++++++++++++--------------- drivers/gpu/drm/exynos/exynos_drm_fimd.h | 15 ++ drivers/gpu/drm/exynos/exynos_drm_ipp.c | 44 +++++ drivers/gpu/drm/exynos/exynos_drm_plane.c | 78 +++------ drivers/gpu/drm/exynos/exynos_drm_plane.h | 7 +- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 136 ++++----------- drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +- drivers/gpu/drm/exynos/exynos_mixer.c | 260 ++++++++++++---------------- drivers/gpu/drm/exynos/regs-mixer.h | 2 +- include/video/samsung_fimd.h | 11 ++ 18 files changed, 495 insertions(+), 691 deletions(-) create mode 100644 drivers/gpu/drm/exynos/exynos_drm_fimd.h

1 0

[Bug 89995] error 6 in libgallium.so.0.0.0 (Kodi Crashed when playing LiveTV using TVHeadend)
by bugzilla-daemon＠freedesktop.org 13 Apr '15

13 Apr '15

https://bugs.freedesktop.org/show_bug.cgi?id=89995 --- Comment #1 from Andrew <andrew.wiebe(a)gmail.com> --- Upgraded to MESA 10.6. Still seeing a similar issue but the error message has changed a bit. The error now seems to be with r600_dri.so. kernel: [ 7024.893799] DVDPlayerVideo[3655]: segfault at 7f5a688e8000 ip 00007f5a824798bb sp 00007f5a323ad490 error 7 in r600_dri.so[7f5a821aa000+808000] -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 89995] error 6 in libgallium.so.0.0.0 (Kodi Crashed when playing LiveTV using TVHeadend)
by bugzilla-daemon＠freedesktop.org 12 Apr '15

12 Apr '15

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2015