dri-devel May 2015

dri-devel@lists.freedesktop.org

191 participants
1132 discussions

Re: [PATCH] gma500:Remove functions that are now deprecated and move to the newer functions in drm_dp_helper.c
by Patrik Jakobsson 11 May '15

11 May '15

On Sun, May 10, 2015 at 9:50 PM, Nicholas Krause <xerofoify(a)gmail.com> wrote: > > > On May 10, 2015 3:45:36 PM EDT, patrik.r.jakobsson(a)gmail.com wrote: >>On Sun, May 10, 2015 at 02:40:40PM -0400, nick wrote: >>> >>> >>> On 2015-05-10 02:35 PM, patrik.r.jakobsson(a)gmail.com wrote: >>> > On Sun, May 10, 2015 at 01:48:14PM -0400, nick wrote: >>> >> >>> >> >>> >> On 2015-05-10 01:04 PM, patrik.r.jakobsson(a)gmail.com wrote: >>> >>> On Tue, May 05, 2015 at 11:17:07AM -0400, nick wrote: >>> >>>> >>> >>>> >>> >>>> On 2015-05-05 09:06 AM, Patrik Jakobsson wrote: >>> >>>>> On Tue, May 5, 2015 at 12:29 AM, Nicholas Krause >><xerofoify(a)gmail.com> wrote: >>> >>>>>> This removes the deprecated functions,i2c_dp_aux_add_bus and >>> >>>>>> i2c_dp_aux_prepare_bus and the only call in the function, >>> >>>>>> cdv_intel_dp_i2c_init to i2c_dp_aux_add_bus respectfully. >>> >>>>>> The call and use of these functions is now replaced alongside >>> >>>>>> the removal of setting other values in the >>function,cdv_intel_dp_i2c_init >>> >>>>>> to use the helper function, drm_dp_aux_register that can >>handle all this >>> >>>>>> work internally. >>> >>>>> >>> >>>>> You need to fill in the drm_dp_aux structure and implement a >>proper transfer >>> >>>>> function. This patch would only break things. But the cdv dp >>output is already >>> >>>>> broken on my system so it needs fixing first. >>> >>>>> >>> >>>>> -Patrik >>> >>>>> >>> >>>> Patrik, >>> >>>> Due to me not being an expert in this area of the kernel I based >>my work off the similar function, >>> >>>> intel_dp_aux_init for i915. I was unsure of which helper >>functions for i915 need to be written >>> >>>> differently for gma500 based solutions as I don't known the >>differences between these two in the >>> >>>> graphics specs area. >>> >>>> Thanks, >>> >>>> Nick >>> >>> >>> >>> Hi Nick >>> >>> You are _required_ to know what your patches are doing before >>sending them. If >>> >>> you don't test your code and don't know what it's doing then we >>will not accept >>> >>> it. You're expected to read the available documentation and >>relevant literature >>> >>> before sending patches and asking questions. Otherwise someone >>else is doing the >>> >>> work for you, which I assume is not the purpose of you patch >>submission. >>> >>> >>> >>> Thanks >>> >>> Patrik >>> >>> >> Patrik, >>> >> Sorry about that my question is actually this ,I am unsure of what >>parts of the function,intel_dp_aux_init >>> >> need to be ported for the gma500 gpu driver. Furthermore I will >>list what parts for certain I known need to >>> >> be ported over above the lines of code in the function definition >>I have pasted below. Please let me known >>> >> if there are any areas I am missing. This is more just of a double >>check to make sure I don't miss something >>> >> critical:)(I like to verify something before I code it). >>> >> Sorry for the misunderstanding, >>> > >>> > You can figure this out by reading the drm dp helpers docs and >>looking at >>> > cdv_intel_dp.c. For instance, in gma500 we initialize DP_B and >>DP_C. >>> > >>> > My point is that _you_ need to read the code and understand it. I >>cannot help >>> > you with that. >>> > >>> > But as I said in my first reply. DP on CDV is broken (at least on >>my machine) so >>> > that should be fixed first. >>> > >>> > Cheers >>> > Patrik >>> > >>> Patrik, >>> Sorry about that :). Your right it's a bad habit :(, I will start >>working on it. >>> Further more by "broken" you mean what. This is very vague and if you >>would like >>> some help with it, I am willing to if you can give me a detailed >>response of what >>> is wrong. >>> Nick >> >>Vague? Both DP and LVDS displays are black after boot when DP is >>connected. What >>additional information do you need? >> > That sounds broken to me. This seems like a good place to start helping a new with your permission. > Nick Sorry but I'm no teacher and cannot help you with that. Patrik >>> >> Nick >>> >> static void >>> >> 1002 intel_dp_aux_init(struct intel_dp *intel_dp, struct >>intel_connector *connector) >>> >> 1003 { >>> >> /*Unsure about how to port this over the functions in these lines >>a.k.a any differences between i915 and gma500 related to these >>functions? >>> >> I read through these function definitions but would like to >>double check*/ >>> >> 1004 struct drm_device *dev = intel_dp_to_dev(intel_dp); >>> >> 1005 struct intel_digital_port *intel_dig_port = >>dp_to_dig_port(intel_dp); >>> >> 1006 enum port port = intel_dig_port->port; >>> >> /*Port these lines*/ >>> >> 1007 const char *name = NULL; >>> >> 1008 int ret; >>> >> /*Port this switch statement */ >>> >> 1009 >>> >> 1010 switch (port) { >>> >> 1011 case PORT_A: >>> >> 1012 intel_dp->aux_ch_ctl_reg = DPA_AUX_CH_CTL; >>> >> 1013 name = "DPDDC-A"; >>> >> 1014 break; >>> >> 1015 case PORT_B: >>> >> 1016 intel_dp->aux_ch_ctl_reg = >>PCH_DPB_AUX_CH_CTL; >>> >> 1017 name = "DPDDC-B"; >>> >> 1018 break; >>> >> 1019 case PORT_C: >>> >> 1020 intel_dp->aux_ch_ctl_reg = >>PCH_DPC_AUX_CH_CTL; >>> >> 1021 name = "DPDDC-C"; >>> >> 1022 break; >>> >> 1023 case PORT_D: >>> >> 1024 intel_dp->aux_ch_ctl_reg = >>PCH_DPD_AUX_CH_CTL; >>> >> 1025 name = "DPDDC-D"; >>> >> 1026 break; >>> >> 1027 default: >>> >> 1028 BUG(); >>> >> 1029 } >>> >> 1030 >>> >> 1031 /* >>> >> 1032 * The AUX_CTL register is usually DP_CTL + 0x10. >>> >> 1033 * >>> >> 1034 * On Haswell and Broadwell though: >>> >> 1035 * - Both port A DDI_BUF_CTL and DDI_AUX_CTL are on >>the CPU >>> >> 1036 * - Port B/C/D AUX channels are on the PCH, >>DDI_BUF_CTL on the CPU >>> >> 1037 * >>> >> 1038 * Skylake moves AUX_CTL back next to DDI_BUF_CTL, on >>the CPU. >>> >> 1039 */ >>> >> 1040 if (!IS_HASWELL(dev) && !IS_BROADWELL(dev)) >>> >> 1041 intel_dp->aux_ch_ctl_reg = >>intel_dp->output_reg + 0x10; >>> >> 1042 >>> >> /*Port these lines*/ >>> >> 1043 intel_dp->aux.name = name; >>> >> 1044 intel_dp->aux.dev = dev->dev; >>> >> 1045 intel_dp->aux.transfer = intel_dp_aux_transfer; >>> >> 1046 >>> >> /*Port this devugging message */ >>> >> 1047 DRM_DEBUG_KMS("registering %s bus for %s\n", name, >>> >> 1048 connector->base.kdev->kobj.name); >>> >> 1049 >>> >> /*Port these lines*/ >>> >> 1050 ret = drm_dp_aux_register(&intel_dp->aux); >>> >> 1051 if (ret < 0) { >>> >> 1052 DRM_ERROR("drm_dp_aux_register() for %s >>failed (%d)\n", >>> >> 1053 name, ret); >>> >> 1054 return; >>> >> 1055 } >>> >> 1056 >>> >> /*Port the of the function */ >>> >> 1057 ret = sysfs_create_link(&connector->base.kdev->kobj, >>> >> 1058 &intel_dp->aux.ddc.dev.kobj, >>> >> 1059 >>intel_dp->aux.ddc.dev.kobj.name); >>> >> 1060 if (ret < 0) { >>> >> 1061 DRM_ERROR("sysfs_create_link() for %s failed >>(%d)\n", name, ret); >>> >> 1062 drm_dp_aux_unregister(&intel_dp->aux); >>> >> 1063 } >>> >> 1064 } >>> >> 1065 >>> >>> >>> >>>>>> Signed-off-by: Nicholas Krause <xerofoify(a)gmail.com> >>> >>>>>> --- >>> >>>>>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 42 >>++--------------------------------- >>> >>>>>> 1 file changed, 2 insertions(+), 40 deletions(-) >>> >>>>>> >>> >>>>>> diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c >>b/drivers/gpu/drm/gma500/cdv_intel_dp.c >>> >>>>>> index 0fafb8e..c8c20fc 100644 >>> >>>>>> --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c >>> >>>>>> +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c >>> >>>>>> @@ -200,38 +200,6 @@ static const struct i2c_algorithm >>i2c_dp_aux_algo = { >>> >>>>>> .functionality = i2c_algo_dp_aux_functionality, >>> >>>>>> }; >>> >>>>>> >>> >>>>>> -static void >>> >>>>>> -i2c_dp_aux_reset_bus(struct i2c_adapter *adapter) >>> >>>>>> -{ >>> >>>>>> - (void) i2c_algo_dp_aux_address(adapter, 0, false); >>> >>>>>> - (void) i2c_algo_dp_aux_stop(adapter, false); >>> >>>>>> -} >>> >>>>>> - >>> >>>>>> -static int >>> >>>>>> -i2c_dp_aux_prepare_bus(struct i2c_adapter *adapter) >>> >>>>>> -{ >>> >>>>>> - adapter->algo = &i2c_dp_aux_algo; >>> >>>>>> - adapter->retries = 3; >>> >>>>>> - i2c_dp_aux_reset_bus(adapter); >>> >>>>>> - return 0; >>> >>>>>> -} >>> >>>>>> - >>> >>>>>> -/* >>> >>>>>> - * FIXME: This is the old dp aux helper, gma500 is the last >>driver that needs to >>> >>>>>> - * be ported over to the new helper code in drm_dp_helper.c >>like i915 or radeon. >>> >>>>>> - */ >>> >>>>>> -static int __deprecated >>> >>>>>> -i2c_dp_aux_add_bus(struct i2c_adapter *adapter) >>> >>>>>> -{ >>> >>>>>> - int error; >>> >>>>>> - >>> >>>>>> - error = i2c_dp_aux_prepare_bus(adapter); >>> >>>>>> - if (error) >>> >>>>>> - return error; >>> >>>>>> - error = i2c_add_adapter(adapter); >>> >>>>>> - return error; >>> >>>>>> -} >>> >>>>>> - >>> >>>>>> #define _wait_for(COND, MS, W) ({ \ >>> >>>>>> unsigned long timeout__ = jiffies + >>msecs_to_jiffies(MS); \ >>> >>>>>> int ret__ = 0; >> \ >>> >>>>>> @@ -275,6 +243,7 @@ struct cdv_intel_dp { >>> >>>>>> int backlight_on_delay; >>> >>>>>> int backlight_off_delay; >>> >>>>>> struct drm_display_mode *panel_fixed_mode; /* for eDP >>*/ >>> >>>>>> + struct drm_dp_aux aux; >>> >>>>>> bool panel_on; >>> >>>>>> }; >>> >>>>>> >>> >>>>>> @@ -855,18 +824,11 @@ cdv_intel_dp_i2c_init(struct >>gma_connector *connector, >>> >>>>>> intel_dp->algo.running = false; >>> >>>>>> intel_dp->algo.address = 0; >>> >>>>>> intel_dp->algo.aux_ch = cdv_intel_dp_i2c_aux_ch; >>> >>>>>> - >>> >>>>>> memset(&intel_dp->adapter, '\0', sizeof >>(intel_dp->adapter)); >>> >>>>>> - intel_dp->adapter.owner = THIS_MODULE; >>> >>>>>> - intel_dp->adapter.class = I2C_CLASS_DDC; >>> >>>>>> - strncpy (intel_dp->adapter.name, name, >>sizeof(intel_dp->adapter.name) - 1); >>> >>>>>> - intel_dp->adapter.name[sizeof(intel_dp->adapter.name) >>- 1] = '\0'; >>> >>>>>> - intel_dp->adapter.algo_data = &intel_dp->algo; >>> >>>>>> - intel_dp->adapter.dev.parent = connector->base.kdev; >>> >>>>>> >>> >>>>>> if (is_edp(encoder)) >>> >>>>>> cdv_intel_edp_panel_vdd_on(encoder); >>> >>>>>> - ret = i2c_dp_aux_add_bus(&intel_dp->adapter); >>> >>>>>> + ret = drm_dp_aux_register(&intel_dp->aux); >>> >>>>>> if (is_edp(encoder)) >>> >>>>>> cdv_intel_edp_panel_vdd_off(encoder); >>> >>>>>> >>> >>>>>> -- >>> >>>>>> 2.1.4 >>> >>>>>> > > -- > Sent from my Android device with K-9 Mail. Please excuse my brevity.

1 0

[Bug 85320] New: GPU hangs using hardware acceleration
by bugzilla-daemon＠freedesktop.org 11 May '15

11 May '15

https://bugs.freedesktop.org/show_bug.cgi?id=85320 Bug ID: 85320 Summary: GPU hangs using hardware acceleration Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 Assignee: dri-devel(a)lists.freedesktop.org Reporter: ken20001(a)ukr.net With new kernel 3.18RC1 trying hardware acceleraton I discovered GPU hangs. Running 'mpv -vo vdpau --hwdec vdpau filename' starts to play movie and all it seems ok. But if we try to rewind forward/backward first it, playing, hangs. Than all system hangs. Switching to another VT in dmesg appears: [drm:r600_ib_test] *ERROR* radeon: fence wait failed (-35). [drm:radeon_ib_ring_tests] *ERROR* radeon: failed testing IB on GFX ring (-35). Switching back to VT7 we can watch that image appears and disappears. Restarting ligtdm service allowed me to log in to account. But anyway all system switched to XRender and no OpenGL until I fully reboot. mpv --version mpv git-f5a19f6 (C) 2000-2014 mpv/MPlayer/mplayer2 projects built on 2014-10-18T11:58:42 ffmpeg library versions: libavutil 54.7.100 libavcodec 56.1.100 libavformat 56.4.101 libswscale 3.0.100 libavfilter 5.1.100 libavresample 2.1.0 vdpauinfo 0.1-1 mesa-vdpau-drivers 10.4~git1410211930.ef280c~gd~t libgl1-mesa-glx 10.4~git1410211930.ef280c~gd~t Kubuntu 14.04.1 Linux: 3.18RC1 x86_64 Graphics: Radeon HD2600 XT -- You are receiving this mail because: You are the assignee for the bug.

1 57

[Bug 88152] 720p and 1080 H.264 videos lock-up on playback with vlc / vdpau on Radeon 3850HD
by bugzilla-daemon＠freedesktop.org 11 May '15

11 May '15

https://bugs.freedesktop.org/show_bug.cgi?id=88152 Bug ID: 88152 Summary: 720p and 1080 H.264 videos lock-up on playback with vlc / vdpau on Radeon 3850HD Product: DRI Version: XOrg git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: major Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: arthur.marsh(a)internode.on.net Created attachment 111903 --> https://bugs.freedesktop.org/attachment.cgi?id=111903&action=edit dmesg output Running Debian unstable x86/64 on AMD64 (4 cores) using a Radeon 3850HD graphics card with Linus git head kernel. H.264 videos at 720p or 1080p resolution cause lock-up with VLC (but not with mpv --vo vdpau). Using: mesa-vdpau-drivers:amd64 10.3.2-1 libdrm-radeon1:amd64 2.4.58-2 xserver-xorg-video-radeon 1:7.5.0-1 vlc 2.2.0~rc2-1 I don't have any short non-commercial videos to demonstrate the problem, but it does appear more likely with encodes from broadcast sources than blu-rays, suggesting that corrupt video gets fed through to where it causes a gpu lock-up while audio playback and other processes continue. $ lspci 00:00.0 Host bridge: Advanced Micro Devices, Inc. [AMD] RS780 Host Bridge 00:02.0 PCI bridge: Advanced Micro Devices, Inc. [AMD] RS780 PCI to PCI bridge (ext gfx port 0) 00:06.0 PCI bridge: Advanced Micro Devices, Inc. [AMD] RS780 PCI to PCI bridge (PCIE port 2) 00:11.0 SATA controller: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0/SB8x0/SB9x0 SATA Controller [AHCI mode] 00:12.0 USB controller: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0/SB8x0/SB9x0 USB OHCI0 Controller 00:12.1 USB controller: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0 USB OHCI1 Controller 00:12.2 USB controller: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0/SB8x0/SB9x0 USB EHCI Controller 00:13.0 USB controller: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0/SB8x0/SB9x0 USB OHCI0 Controller 00:13.1 USB controller: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0 USB OHCI1 Controller 00:13.2 USB controller: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0/SB8x0/SB9x0 USB EHCI Controller 00:14.0 SMBus: Advanced Micro Devices, Inc. [AMD/ATI] SBx00 SMBus Controller (rev 3a) 00:14.1 IDE interface: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0/SB8x0/SB9x0 IDE Controller 00:14.2 Audio device: Advanced Micro Devices, Inc. [AMD/ATI] SBx00 Azalia (Intel HDA) 00:14.3 ISA bridge: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0/SB8x0/SB9x0 LPC host controller 00:14.4 PCI bridge: Advanced Micro Devices, Inc. [AMD/ATI] SBx00 PCI to PCI Bridge 00:14.5 USB controller: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0/SB8x0/SB9x0 USB OHCI2 Controller 00:18.0 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 10h Processor HyperTransport Configuration 00:18.1 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 10h Processor Address Map 00:18.2 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 10h Processor DRAM Controller 00:18.3 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 10h Processor Miscellaneous Control 00:18.4 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 10h Processor Link Control 01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] RV670 [Radeon HD 3690/3850] 01:00.1 Audio device: Advanced Micro Devices, Inc. [AMD/ATI] RV670/680 HDMI Audio [Radeon HD 3690/3800 Series] 02:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 02) # vdpauinfo display: :0 screen: 0 API version: 1 Information string: G3DVL VDPAU Driver Shared Library version 1.0 Video surface: name width height types ------------------------------------------- 420 8192 8192 NV12 YV12 422 8192 8192 UYVY YUYV 444 8192 8192 Y8U8V8A8 V8U8Y8A8 Decoder capabilities: name level macbs width height ------------------------------------------- MPEG1 0 9216 2048 1152 MPEG2_SIMPLE 3 9216 2048 1152 MPEG2_MAIN 3 9216 2048 1152 H264_BASELINE 41 9216 2048 1152 H264_MAIN 41 9216 2048 1152 H264_HIGH 41 9216 2048 1152 VC1_ADVANCED 4 9216 2048 1152 Output surface: name width height nat types ---------------------------------------------------- B8G8R8A8 8192 8192 y NV12 YV12 UYVY YUYV Y8U8V8A8 V8U8Y8A8 R8G8B8A8 8192 8192 y NV12 YV12 UYVY YUYV Y8U8V8A8 V8U8Y8A8 R10G10B10A2 8192 8192 y NV12 YV12 UYVY YUYV Y8U8V8A8 V8U8Y8A8 B10G10R10A2 8192 8192 y NV12 YV12 UYVY YUYV Y8U8V8A8 V8U8Y8A8 Bitmap surface: name width height ------------------------------ B8G8R8A8 8192 8192 R8G8B8A8 8192 8192 R10G10B10A2 8192 8192 B10G10R10A2 8192 8192 A8 8192 8192 Video mixer: feature name sup ------------------------------------ DEINTERLACE_TEMPORAL y DEINTERLACE_TEMPORAL_SPATIAL - INVERSE_TELECINE - NOISE_REDUCTION y SHARPNESS y LUMA_KEY - HIGH QUALITY SCALING - L1 - HIGH QUALITY SCALING - L2 - HIGH QUALITY SCALING - L3 - HIGH QUALITY SCALING - L4 - HIGH QUALITY SCALING - L5 - HIGH QUALITY SCALING - L6 - HIGH QUALITY SCALING - L7 - HIGH QUALITY SCALING - L8 - HIGH QUALITY SCALING - L9 - parameter name sup min max ----------------------------------------------------- VIDEO_SURFACE_WIDTH y 48 2048 VIDEO_SURFACE_HEIGHT y 48 1152 CHROMA_TYPE y LAYERS y 0 4 attribute name sup min max ----------------------------------------------------- BACKGROUND_COLOR y CSC_MATRIX y NOISE_REDUCTION_LEVEL y 0.00 1.00 SHARPNESS_LEVEL y -1.00 1.00 LUMA_KEY_MIN_LUMA y LUMA_KEY_MAX_LUMA y I am happy to supply additional information or try things to narrow down the source of the problem. -- You are receiving this mail because: You are the assignee for the bug.

1 42

[git pull] drm fixes
by Dave Airlie 10 May '15

10 May '15

Hi Linus, really need to get back to sending these on my Friday, instead of my Monday morning, but nothing too amazing in here, a few amdkfd fixes, a few radeon fixes, i915 fixes, one tegra fix and one core fix. Dave. The following changes since commit 5ebe6afaf0057ac3eaeb98defd5456894b446d22: Linux 4.1-rc2 (2015-05-03 19:22:23 -0700) are available in the git repository at: git://people.freedesktop.org/~airlied/linux drm-fixes for you to fetch changes up to 332545b3016cbff066c17037d32ec8aae8e4cfb5: Merge tag 'drm-intel-fixes-2015-05-08' of git://anongit.freedesktop.org/drm-intel into drm-fixes (2015-05-11 06:06:22 +1000) ---------------------------------------------------------------- Alex Deucher (1): drm/radeon: don't setup audio on asics that don't support it Chris Wilson (1): drm/i915: Drop PIPE-A quirk for 945GSE HP Mini Christian König (6): drm/radeon: disable semaphores for UVD V1 (v2) drm/radeon: fix userptr lockup drm/radeon: make VCE handle check more strict drm/radeon: make UVD handle checking more strict drm/radeon: more strictly validate the UVD codec drm/radeon: stop trying to suspend UVD sessions Dave Airlie (3): Merge branch 'drm-fixes-4.1' of git://people.freedesktop.org/~agd5f/linux into drm-fixes Merge tag 'drm-amdkfd-fixes-2015-05-07' of git://people.freedesktop.org/~gabbayo/linux into drm-fixes Merge tag 'drm-intel-fixes-2015-05-08' of git://anongit.freedesktop.org/drm-intel into drm-fixes Jani Nikula (1): drm/i915/dp: there is no audio on port A Lukas Wunner (2): drm/i915: Assume dual channel LVDS if pixel clock necessitates it drm/i915: Add missing MacBook Pro models with dual channel LVDS Mario Kleiner (2): drm/tegra: Don't use vblank_disable_immediate on incapable driver. drm: Zero out invalid vblank timestamp in drm_update_vblank_count. Oded Gabbay (2): drm/amdkfd: allow unregister process with queues drm/amdkfd: Don't report local memory size Sonika Jindal (1): drm/i915: Sink rate read should be saved in deca-kHz Xihan Zhang (1): drm/amdkfd: Initialize sdma vm when creating sdma queue monk.liu (1): drm/radeon: fix userptr BO unpin bug v3 .../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 7 +- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 +- drivers/gpu/drm/drm_irq.c | 9 +- drivers/gpu/drm/i915/intel_display.c | 3 - drivers/gpu/drm/i915/intel_dp.c | 9 +- drivers/gpu/drm/i915/intel_lvds.c | 26 +++- drivers/gpu/drm/radeon/radeon.h | 1 - drivers/gpu/drm/radeon/radeon_asic.c | 2 +- drivers/gpu/drm/radeon/radeon_asic.h | 4 + drivers/gpu/drm/radeon/radeon_audio.c | 4 + drivers/gpu/drm/radeon/radeon_mn.c | 3 + drivers/gpu/drm/radeon/radeon_ttm.c | 8 +- drivers/gpu/drm/radeon/radeon_uvd.c | 144 +++++++++++++-------- drivers/gpu/drm/radeon/radeon_vce.c | 65 +++++++--- drivers/gpu/drm/radeon/rv770d.h | 3 + drivers/gpu/drm/radeon/uvd_v1_0.c | 14 +- drivers/gpu/drm/radeon/uvd_v2_2.c | 29 +++++ drivers/gpu/drm/tegra/drm.c | 1 - 18 files changed, 230 insertions(+), 106 deletions(-)

1 0

Re: [PATCH] gma500:Remove functions that are now deprecated and move to the newer functions in drm_dp_helper.c
by patrik.r.jakobsson＠gmail.com 10 May '15

10 May '15

On Sun, May 10, 2015 at 02:40:40PM -0400, nick wrote: > > > On 2015-05-10 02:35 PM, patrik.r.jakobsson(a)gmail.com wrote: > > On Sun, May 10, 2015 at 01:48:14PM -0400, nick wrote: > >> > >> > >> On 2015-05-10 01:04 PM, patrik.r.jakobsson(a)gmail.com wrote: > >>> On Tue, May 05, 2015 at 11:17:07AM -0400, nick wrote: > >>>> > >>>> > >>>> On 2015-05-05 09:06 AM, Patrik Jakobsson wrote: > >>>>> On Tue, May 5, 2015 at 12:29 AM, Nicholas Krause <xerofoify(a)gmail.com> wrote: > >>>>>> This removes the deprecated functions,i2c_dp_aux_add_bus and > >>>>>> i2c_dp_aux_prepare_bus and the only call in the function, > >>>>>> cdv_intel_dp_i2c_init to i2c_dp_aux_add_bus respectfully. > >>>>>> The call and use of these functions is now replaced alongside > >>>>>> the removal of setting other values in the function,cdv_intel_dp_i2c_init > >>>>>> to use the helper function, drm_dp_aux_register that can handle all this > >>>>>> work internally. > >>>>> > >>>>> You need to fill in the drm_dp_aux structure and implement a proper transfer > >>>>> function. This patch would only break things. But the cdv dp output is already > >>>>> broken on my system so it needs fixing first. > >>>>> > >>>>> -Patrik > >>>>> > >>>> Patrik, > >>>> Due to me not being an expert in this area of the kernel I based my work off the similar function, > >>>> intel_dp_aux_init for i915. I was unsure of which helper functions for i915 need to be written > >>>> differently for gma500 based solutions as I don't known the differences between these two in the > >>>> graphics specs area. > >>>> Thanks, > >>>> Nick > >>> > >>> Hi Nick > >>> You are _required_ to know what your patches are doing before sending them. If > >>> you don't test your code and don't know what it's doing then we will not accept > >>> it. You're expected to read the available documentation and relevant literature > >>> before sending patches and asking questions. Otherwise someone else is doing the > >>> work for you, which I assume is not the purpose of you patch submission. > >>> > >>> Thanks > >>> Patrik > > >> Patrik, > >> Sorry about that my question is actually this ,I am unsure of what parts of the function,intel_dp_aux_init > >> need to be ported for the gma500 gpu driver. Furthermore I will list what parts for certain I known need to > >> be ported over above the lines of code in the function definition I have pasted below. Please let me known > >> if there are any areas I am missing. This is more just of a double check to make sure I don't miss something > >> critical:)(I like to verify something before I code it). > >> Sorry for the misunderstanding, > > > > You can figure this out by reading the drm dp helpers docs and looking at > > cdv_intel_dp.c. For instance, in gma500 we initialize DP_B and DP_C. > > > > My point is that _you_ need to read the code and understand it. I cannot help > > you with that. > > > > But as I said in my first reply. DP on CDV is broken (at least on my machine) so > > that should be fixed first. > > > > Cheers > > Patrik > > > Patrik, > Sorry about that :). Your right it's a bad habit :(, I will start working on it. > Further more by "broken" you mean what. This is very vague and if you would like > some help with it, I am willing to if you can give me a detailed response of what > is wrong. > Nick Vague? Both DP and LVDS displays are black after boot when DP is connected. What additional information do you need? > >> Nick > >> static void > >> 1002 intel_dp_aux_init(struct intel_dp *intel_dp, struct intel_connector *connector) > >> 1003 { > >> /*Unsure about how to port this over the functions in these lines a.k.a any differences between i915 and gma500 related to these functions? > >> I read through these function definitions but would like to double check*/ > >> 1004 struct drm_device *dev = intel_dp_to_dev(intel_dp); > >> 1005 struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); > >> 1006 enum port port = intel_dig_port->port; > >> /*Port these lines*/ > >> 1007 const char *name = NULL; > >> 1008 int ret; > >> /*Port this switch statement */ > >> 1009 > >> 1010 switch (port) { > >> 1011 case PORT_A: > >> 1012 intel_dp->aux_ch_ctl_reg = DPA_AUX_CH_CTL; > >> 1013 name = "DPDDC-A"; > >> 1014 break; > >> 1015 case PORT_B: > >> 1016 intel_dp->aux_ch_ctl_reg = PCH_DPB_AUX_CH_CTL; > >> 1017 name = "DPDDC-B"; > >> 1018 break; > >> 1019 case PORT_C: > >> 1020 intel_dp->aux_ch_ctl_reg = PCH_DPC_AUX_CH_CTL; > >> 1021 name = "DPDDC-C"; > >> 1022 break; > >> 1023 case PORT_D: > >> 1024 intel_dp->aux_ch_ctl_reg = PCH_DPD_AUX_CH_CTL; > >> 1025 name = "DPDDC-D"; > >> 1026 break; > >> 1027 default: > >> 1028 BUG(); > >> 1029 } > >> 1030 > >> 1031 /* > >> 1032 * The AUX_CTL register is usually DP_CTL + 0x10. > >> 1033 * > >> 1034 * On Haswell and Broadwell though: > >> 1035 * - Both port A DDI_BUF_CTL and DDI_AUX_CTL are on the CPU > >> 1036 * - Port B/C/D AUX channels are on the PCH, DDI_BUF_CTL on the CPU > >> 1037 * > >> 1038 * Skylake moves AUX_CTL back next to DDI_BUF_CTL, on the CPU. > >> 1039 */ > >> 1040 if (!IS_HASWELL(dev) && !IS_BROADWELL(dev)) > >> 1041 intel_dp->aux_ch_ctl_reg = intel_dp->output_reg + 0x10; > >> 1042 > >> /*Port these lines*/ > >> 1043 intel_dp->aux.name = name; > >> 1044 intel_dp->aux.dev = dev->dev; > >> 1045 intel_dp->aux.transfer = intel_dp_aux_transfer; > >> 1046 > >> /*Port this devugging message */ > >> 1047 DRM_DEBUG_KMS("registering %s bus for %s\n", name, > >> 1048 connector->base.kdev->kobj.name); > >> 1049 > >> /*Port these lines*/ > >> 1050 ret = drm_dp_aux_register(&intel_dp->aux); > >> 1051 if (ret < 0) { > >> 1052 DRM_ERROR("drm_dp_aux_register() for %s failed (%d)\n", > >> 1053 name, ret); > >> 1054 return; > >> 1055 } > >> 1056 > >> /*Port the of the function */ > >> 1057 ret = sysfs_create_link(&connector->base.kdev->kobj, > >> 1058 &intel_dp->aux.ddc.dev.kobj, > >> 1059 intel_dp->aux.ddc.dev.kobj.name); > >> 1060 if (ret < 0) { > >> 1061 DRM_ERROR("sysfs_create_link() for %s failed (%d)\n", name, ret); > >> 1062 drm_dp_aux_unregister(&intel_dp->aux); > >> 1063 } > >> 1064 } > >> 1065 > >>> > >>>>>> Signed-off-by: Nicholas Krause <xerofoify(a)gmail.com> > >>>>>> --- > >>>>>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 42 ++--------------------------------- > >>>>>> 1 file changed, 2 insertions(+), 40 deletions(-) > >>>>>> > >>>>>> diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c > >>>>>> index 0fafb8e..c8c20fc 100644 > >>>>>> --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c > >>>>>> +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c > >>>>>> @@ -200,38 +200,6 @@ static const struct i2c_algorithm i2c_dp_aux_algo = { > >>>>>> .functionality = i2c_algo_dp_aux_functionality, > >>>>>> }; > >>>>>> > >>>>>> -static void > >>>>>> -i2c_dp_aux_reset_bus(struct i2c_adapter *adapter) > >>>>>> -{ > >>>>>> - (void) i2c_algo_dp_aux_address(adapter, 0, false); > >>>>>> - (void) i2c_algo_dp_aux_stop(adapter, false); > >>>>>> -} > >>>>>> - > >>>>>> -static int > >>>>>> -i2c_dp_aux_prepare_bus(struct i2c_adapter *adapter) > >>>>>> -{ > >>>>>> - adapter->algo = &i2c_dp_aux_algo; > >>>>>> - adapter->retries = 3; > >>>>>> - i2c_dp_aux_reset_bus(adapter); > >>>>>> - return 0; > >>>>>> -} > >>>>>> - > >>>>>> -/* > >>>>>> - * FIXME: This is the old dp aux helper, gma500 is the last driver that needs to > >>>>>> - * be ported over to the new helper code in drm_dp_helper.c like i915 or radeon. > >>>>>> - */ > >>>>>> -static int __deprecated > >>>>>> -i2c_dp_aux_add_bus(struct i2c_adapter *adapter) > >>>>>> -{ > >>>>>> - int error; > >>>>>> - > >>>>>> - error = i2c_dp_aux_prepare_bus(adapter); > >>>>>> - if (error) > >>>>>> - return error; > >>>>>> - error = i2c_add_adapter(adapter); > >>>>>> - return error; > >>>>>> -} > >>>>>> - > >>>>>> #define _wait_for(COND, MS, W) ({ \ > >>>>>> unsigned long timeout__ = jiffies + msecs_to_jiffies(MS); \ > >>>>>> int ret__ = 0; \ > >>>>>> @@ -275,6 +243,7 @@ struct cdv_intel_dp { > >>>>>> int backlight_on_delay; > >>>>>> int backlight_off_delay; > >>>>>> struct drm_display_mode *panel_fixed_mode; /* for eDP */ > >>>>>> + struct drm_dp_aux aux; > >>>>>> bool panel_on; > >>>>>> }; > >>>>>> > >>>>>> @@ -855,18 +824,11 @@ cdv_intel_dp_i2c_init(struct gma_connector *connector, > >>>>>> intel_dp->algo.running = false; > >>>>>> intel_dp->algo.address = 0; > >>>>>> intel_dp->algo.aux_ch = cdv_intel_dp_i2c_aux_ch; > >>>>>> - > >>>>>> memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter)); > >>>>>> - intel_dp->adapter.owner = THIS_MODULE; > >>>>>> - intel_dp->adapter.class = I2C_CLASS_DDC; > >>>>>> - strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1); > >>>>>> - intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0'; > >>>>>> - intel_dp->adapter.algo_data = &intel_dp->algo; > >>>>>> - intel_dp->adapter.dev.parent = connector->base.kdev; > >>>>>> > >>>>>> if (is_edp(encoder)) > >>>>>> cdv_intel_edp_panel_vdd_on(encoder); > >>>>>> - ret = i2c_dp_aux_add_bus(&intel_dp->adapter); > >>>>>> + ret = drm_dp_aux_register(&intel_dp->aux); > >>>>>> if (is_edp(encoder)) > >>>>>> cdv_intel_edp_panel_vdd_off(encoder); > >>>>>> > >>>>>> -- > >>>>>> 2.1.4 > >>>>>>

1 0

Re: [PATCH] gma500:Remove functions that are now deprecated and move to the newer functions in drm_dp_helper.c
by patrik.r.jakobsson＠gmail.com 10 May '15

10 May '15

On Sun, May 10, 2015 at 01:48:14PM -0400, nick wrote: > > > On 2015-05-10 01:04 PM, patrik.r.jakobsson(a)gmail.com wrote: > > On Tue, May 05, 2015 at 11:17:07AM -0400, nick wrote: > >> > >> > >> On 2015-05-05 09:06 AM, Patrik Jakobsson wrote: > >>> On Tue, May 5, 2015 at 12:29 AM, Nicholas Krause <xerofoify(a)gmail.com> wrote: > >>>> This removes the deprecated functions,i2c_dp_aux_add_bus and > >>>> i2c_dp_aux_prepare_bus and the only call in the function, > >>>> cdv_intel_dp_i2c_init to i2c_dp_aux_add_bus respectfully. > >>>> The call and use of these functions is now replaced alongside > >>>> the removal of setting other values in the function,cdv_intel_dp_i2c_init > >>>> to use the helper function, drm_dp_aux_register that can handle all this > >>>> work internally. > >>> > >>> You need to fill in the drm_dp_aux structure and implement a proper transfer > >>> function. This patch would only break things. But the cdv dp output is already > >>> broken on my system so it needs fixing first. > >>> > >>> -Patrik > >>> > >> Patrik, > >> Due to me not being an expert in this area of the kernel I based my work off the similar function, > >> intel_dp_aux_init for i915. I was unsure of which helper functions for i915 need to be written > >> differently for gma500 based solutions as I don't known the differences between these two in the > >> graphics specs area. > >> Thanks, > >> Nick > > > > Hi Nick > > You are _required_ to know what your patches are doing before sending them. If > > you don't test your code and don't know what it's doing then we will not accept > > it. You're expected to read the available documentation and relevant literature > > before sending patches and asking questions. Otherwise someone else is doing the > > work for you, which I assume is not the purpose of you patch submission. > > > > Thanks > > Patrik > Patrik, > Sorry about that my question is actually this ,I am unsure of what parts of the function,intel_dp_aux_init > need to be ported for the gma500 gpu driver. Furthermore I will list what parts for certain I known need to > be ported over above the lines of code in the function definition I have pasted below. Please let me known > if there are any areas I am missing. This is more just of a double check to make sure I don't miss something > critical:)(I like to verify something before I code it). > Sorry for the misunderstanding, You can figure this out by reading the drm dp helpers docs and looking at cdv_intel_dp.c. For instance, in gma500 we initialize DP_B and DP_C. My point is that _you_ need to read the code and understand it. I cannot help you with that. But as I said in my first reply. DP on CDV is broken (at least on my machine) so that should be fixed first. Cheers Patrik > Nick > static void > 1002 intel_dp_aux_init(struct intel_dp *intel_dp, struct intel_connector *connector) > 1003 { > /*Unsure about how to port this over the functions in these lines a.k.a any differences between i915 and gma500 related to these functions? > I read through these function definitions but would like to double check*/ > 1004 struct drm_device *dev = intel_dp_to_dev(intel_dp); > 1005 struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); > 1006 enum port port = intel_dig_port->port; > /*Port these lines*/ > 1007 const char *name = NULL; > 1008 int ret; > /*Port this switch statement */ > 1009 > 1010 switch (port) { > 1011 case PORT_A: > 1012 intel_dp->aux_ch_ctl_reg = DPA_AUX_CH_CTL; > 1013 name = "DPDDC-A"; > 1014 break; > 1015 case PORT_B: > 1016 intel_dp->aux_ch_ctl_reg = PCH_DPB_AUX_CH_CTL; > 1017 name = "DPDDC-B"; > 1018 break; > 1019 case PORT_C: > 1020 intel_dp->aux_ch_ctl_reg = PCH_DPC_AUX_CH_CTL; > 1021 name = "DPDDC-C"; > 1022 break; > 1023 case PORT_D: > 1024 intel_dp->aux_ch_ctl_reg = PCH_DPD_AUX_CH_CTL; > 1025 name = "DPDDC-D"; > 1026 break; > 1027 default: > 1028 BUG(); > 1029 } > 1030 > 1031 /* > 1032 * The AUX_CTL register is usually DP_CTL + 0x10. > 1033 * > 1034 * On Haswell and Broadwell though: > 1035 * - Both port A DDI_BUF_CTL and DDI_AUX_CTL are on the CPU > 1036 * - Port B/C/D AUX channels are on the PCH, DDI_BUF_CTL on the CPU > 1037 * > 1038 * Skylake moves AUX_CTL back next to DDI_BUF_CTL, on the CPU. > 1039 */ > 1040 if (!IS_HASWELL(dev) && !IS_BROADWELL(dev)) > 1041 intel_dp->aux_ch_ctl_reg = intel_dp->output_reg + 0x10; > 1042 > /*Port these lines*/ > 1043 intel_dp->aux.name = name; > 1044 intel_dp->aux.dev = dev->dev; > 1045 intel_dp->aux.transfer = intel_dp_aux_transfer; > 1046 > /*Port this devugging message */ > 1047 DRM_DEBUG_KMS("registering %s bus for %s\n", name, > 1048 connector->base.kdev->kobj.name); > 1049 > /*Port these lines*/ > 1050 ret = drm_dp_aux_register(&intel_dp->aux); > 1051 if (ret < 0) { > 1052 DRM_ERROR("drm_dp_aux_register() for %s failed (%d)\n", > 1053 name, ret); > 1054 return; > 1055 } > 1056 > /*Port the of the function */ > 1057 ret = sysfs_create_link(&connector->base.kdev->kobj, > 1058 &intel_dp->aux.ddc.dev.kobj, > 1059 intel_dp->aux.ddc.dev.kobj.name); > 1060 if (ret < 0) { > 1061 DRM_ERROR("sysfs_create_link() for %s failed (%d)\n", name, ret); > 1062 drm_dp_aux_unregister(&intel_dp->aux); > 1063 } > 1064 } > 1065 > > > >>>> Signed-off-by: Nicholas Krause <xerofoify(a)gmail.com> > >>>> --- > >>>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 42 ++--------------------------------- > >>>> 1 file changed, 2 insertions(+), 40 deletions(-) > >>>> > >>>> diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c > >>>> index 0fafb8e..c8c20fc 100644 > >>>> --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c > >>>> +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c > >>>> @@ -200,38 +200,6 @@ static const struct i2c_algorithm i2c_dp_aux_algo = { > >>>> .functionality = i2c_algo_dp_aux_functionality, > >>>> }; > >>>> > >>>> -static void > >>>> -i2c_dp_aux_reset_bus(struct i2c_adapter *adapter) > >>>> -{ > >>>> - (void) i2c_algo_dp_aux_address(adapter, 0, false); > >>>> - (void) i2c_algo_dp_aux_stop(adapter, false); > >>>> -} > >>>> - > >>>> -static int > >>>> -i2c_dp_aux_prepare_bus(struct i2c_adapter *adapter) > >>>> -{ > >>>> - adapter->algo = &i2c_dp_aux_algo; > >>>> - adapter->retries = 3; > >>>> - i2c_dp_aux_reset_bus(adapter); > >>>> - return 0; > >>>> -} > >>>> - > >>>> -/* > >>>> - * FIXME: This is the old dp aux helper, gma500 is the last driver that needs to > >>>> - * be ported over to the new helper code in drm_dp_helper.c like i915 or radeon. > >>>> - */ > >>>> -static int __deprecated > >>>> -i2c_dp_aux_add_bus(struct i2c_adapter *adapter) > >>>> -{ > >>>> - int error; > >>>> - > >>>> - error = i2c_dp_aux_prepare_bus(adapter); > >>>> - if (error) > >>>> - return error; > >>>> - error = i2c_add_adapter(adapter); > >>>> - return error; > >>>> -} > >>>> - > >>>> #define _wait_for(COND, MS, W) ({ \ > >>>> unsigned long timeout__ = jiffies + msecs_to_jiffies(MS); \ > >>>> int ret__ = 0; \ > >>>> @@ -275,6 +243,7 @@ struct cdv_intel_dp { > >>>> int backlight_on_delay; > >>>> int backlight_off_delay; > >>>> struct drm_display_mode *panel_fixed_mode; /* for eDP */ > >>>> + struct drm_dp_aux aux; > >>>> bool panel_on; > >>>> }; > >>>> > >>>> @@ -855,18 +824,11 @@ cdv_intel_dp_i2c_init(struct gma_connector *connector, > >>>> intel_dp->algo.running = false; > >>>> intel_dp->algo.address = 0; > >>>> intel_dp->algo.aux_ch = cdv_intel_dp_i2c_aux_ch; > >>>> - > >>>> memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter)); > >>>> - intel_dp->adapter.owner = THIS_MODULE; > >>>> - intel_dp->adapter.class = I2C_CLASS_DDC; > >>>> - strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1); > >>>> - intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0'; > >>>> - intel_dp->adapter.algo_data = &intel_dp->algo; > >>>> - intel_dp->adapter.dev.parent = connector->base.kdev; > >>>> > >>>> if (is_edp(encoder)) > >>>> cdv_intel_edp_panel_vdd_on(encoder); > >>>> - ret = i2c_dp_aux_add_bus(&intel_dp->adapter); > >>>> + ret = drm_dp_aux_register(&intel_dp->aux); > >>>> if (is_edp(encoder)) > >>>> cdv_intel_edp_panel_vdd_off(encoder); > >>>> > >>>> -- > >>>> 2.1.4 > >>>>

1 0

Re: [PATCH] gma500:Remove functions that are now deprecated and move to the newer functions in drm_dp_helper.c
by patrik.r.jakobsson＠gmail.com 10 May '15

10 May '15

On Tue, May 05, 2015 at 11:17:07AM -0400, nick wrote: > > > On 2015-05-05 09:06 AM, Patrik Jakobsson wrote: > > On Tue, May 5, 2015 at 12:29 AM, Nicholas Krause <xerofoify(a)gmail.com> wrote: > >> This removes the deprecated functions,i2c_dp_aux_add_bus and > >> i2c_dp_aux_prepare_bus and the only call in the function, > >> cdv_intel_dp_i2c_init to i2c_dp_aux_add_bus respectfully. > >> The call and use of these functions is now replaced alongside > >> the removal of setting other values in the function,cdv_intel_dp_i2c_init > >> to use the helper function, drm_dp_aux_register that can handle all this > >> work internally. > > > > You need to fill in the drm_dp_aux structure and implement a proper transfer > > function. This patch would only break things. But the cdv dp output is already > > broken on my system so it needs fixing first. > > > > -Patrik > > > Patrik, > Due to me not being an expert in this area of the kernel I based my work off the similar function, > intel_dp_aux_init for i915. I was unsure of which helper functions for i915 need to be written > differently for gma500 based solutions as I don't known the differences between these two in the > graphics specs area. > Thanks, > Nick Hi Nick You are _required_ to know what your patches are doing before sending them. If you don't test your code and don't know what it's doing then we will not accept it. You're expected to read the available documentation and relevant literature before sending patches and asking questions. Otherwise someone else is doing the work for you, which I assume is not the purpose of you patch submission. Thanks Patrik > >> Signed-off-by: Nicholas Krause <xerofoify(a)gmail.com> > >> --- > >> drivers/gpu/drm/gma500/cdv_intel_dp.c | 42 ++--------------------------------- > >> 1 file changed, 2 insertions(+), 40 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c > >> index 0fafb8e..c8c20fc 100644 > >> --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c > >> +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c > >> @@ -200,38 +200,6 @@ static const struct i2c_algorithm i2c_dp_aux_algo = { > >> .functionality = i2c_algo_dp_aux_functionality, > >> }; > >> > >> -static void > >> -i2c_dp_aux_reset_bus(struct i2c_adapter *adapter) > >> -{ > >> - (void) i2c_algo_dp_aux_address(adapter, 0, false); > >> - (void) i2c_algo_dp_aux_stop(adapter, false); > >> -} > >> - > >> -static int > >> -i2c_dp_aux_prepare_bus(struct i2c_adapter *adapter) > >> -{ > >> - adapter->algo = &i2c_dp_aux_algo; > >> - adapter->retries = 3; > >> - i2c_dp_aux_reset_bus(adapter); > >> - return 0; > >> -} > >> - > >> -/* > >> - * FIXME: This is the old dp aux helper, gma500 is the last driver that needs to > >> - * be ported over to the new helper code in drm_dp_helper.c like i915 or radeon. > >> - */ > >> -static int __deprecated > >> -i2c_dp_aux_add_bus(struct i2c_adapter *adapter) > >> -{ > >> - int error; > >> - > >> - error = i2c_dp_aux_prepare_bus(adapter); > >> - if (error) > >> - return error; > >> - error = i2c_add_adapter(adapter); > >> - return error; > >> -} > >> - > >> #define _wait_for(COND, MS, W) ({ \ > >> unsigned long timeout__ = jiffies + msecs_to_jiffies(MS); \ > >> int ret__ = 0; \ > >> @@ -275,6 +243,7 @@ struct cdv_intel_dp { > >> int backlight_on_delay; > >> int backlight_off_delay; > >> struct drm_display_mode *panel_fixed_mode; /* for eDP */ > >> + struct drm_dp_aux aux; > >> bool panel_on; > >> }; > >> > >> @@ -855,18 +824,11 @@ cdv_intel_dp_i2c_init(struct gma_connector *connector, > >> intel_dp->algo.running = false; > >> intel_dp->algo.address = 0; > >> intel_dp->algo.aux_ch = cdv_intel_dp_i2c_aux_ch; > >> - > >> memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter)); > >> - intel_dp->adapter.owner = THIS_MODULE; > >> - intel_dp->adapter.class = I2C_CLASS_DDC; > >> - strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1); > >> - intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0'; > >> - intel_dp->adapter.algo_data = &intel_dp->algo; > >> - intel_dp->adapter.dev.parent = connector->base.kdev; > >> > >> if (is_edp(encoder)) > >> cdv_intel_edp_panel_vdd_on(encoder); > >> - ret = i2c_dp_aux_add_bus(&intel_dp->adapter); > >> + ret = drm_dp_aux_register(&intel_dp->aux); > >> if (is_edp(encoder)) > >> cdv_intel_edp_panel_vdd_off(encoder); > >> > >> -- > >> 2.1.4 > >>

1 0

Re: Some issues with the new amdgpu driver
by Brian Paterni 10 May '15

10 May '15

On 05/09/2015 03:34 AM, Michel Dänzer wrote: > On 09.05.2015 11:44, Brian Paterni wrote: >> On 05/07/2015 04:07 AM, Michel Dänzer wrote: >>> On 06.05.2015 12:12, Brian Paterni wrote: >>>> >>>> I was on irc a few days ago trying to get the new amdgpu driver up and >>>> running on my system. I am able to get the kernel booted successfully, >>>> however X via amdgpu is turning out to be a real roadblock. It is the >>>> problem with amdgpu_drv.so seeing gbm_create_device as an undefined >>>> symbol. From what little I understand, I may be needing a more recent >>>> xserver to resolve this... >>> >>> I don't think that would help. >>> >>> Does the attached xf86-video-amdgpu patch fix the problem? >>> >>> If not, you can manually load the glamoregl module in /etc/X11/xorg.conf >>> to pull in libgbm: >>> >>> Section "Module" >>> Load "glamoregl" >>> EndSection >>> >>> >> >> Hi Michel, thanks for the reply. I got around to recompiling the stack >> from the latest trees as noted by Alex earlier. However, I'm afraid >> something may have changed recently and I may be needing a newer xserver >> after all. Loading amdgpu_drv.so now results in: >> >> [ 1122.347] (EE) module ABI major version (19) doesn't match the >> server's version (18) > > That just means the driver it's trying to load wasn't built against the > same version of xserver. Make sure the xf86-video-amdgpu build is > picking up the xorg-server.pc and header files of the same version of > xserver you're trying to run. > > Oops! Looks like I forgot to cc the mailing list. I think my version mismatch issues above may have been resolved by a recent upload of xserver-xorg-core 2:1.17.1-2 to debian unstable(?)... As a result, I could finally test Michel's patch, and I am happy to say that X via amdgpu is now working for me! Thanks to Michel! :) However, the two additional issues mentioned in my initial post are still present: *) Non-working DVI-I-0 -- even if I use xrandr to turn it off and on again, a signal is never acquired. *) System lockup on xen boot (even magic sysrq is not recognized)

1 1

[PATCH] MAINTAINERS: update amdkfd Oded's email address
by Oded Gabbay 10 May '15

10 May '15

Leaving AMD soon so need to update my email address to @gmail.com Signed-off-by: Oded Gabbay <oded.gabbay(a)gmail.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 781e099..d68df93 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -631,7 +631,7 @@ F: drivers/iommu/amd_iommu*.[ch] F: include/linux/amd-iommu.h AMD KFD -M: Oded Gabbay <oded.gabbay(a)amd.com> +M: Oded Gabbay <oded.gabbay(a)gmail.com> L: dri-devel(a)lists.freedesktop.org T: git git://people.freedesktop.org/~gabbayo/linux.git S: Supported -- 1.9.1

1 0

[PATCH v2 0/9] Add Interrupts & Events modules to amdkfd
by Oded Gabbay 10 May '15

10 May '15

This is the second version of this patch-set. Only two patches were changed from the first version: - drm/amdkfd: add events IOCTL set definitions - drm/amdkfd: Add the events module Please review, Thanks Oded Alexey Skidanov (2): drm/amdkfd: Add memory exception handling drm/amdkfd: Add bad opcode exception handling Andrew Lewycky (3): drm/amdkfd: Add interrupt handling module drm/amdkfd: add events IOCTL set definitions drm/amdkfd: Implement events IOCTLs Oded Gabbay (4): drm/radeon: Add init interrupt kfd->kgd interface drm/amdkfd: Add the events module drm/amdkfd: Add module parameter of send_sigterm drm/amdkfd: change driver version to 0.7.2 drivers/gpu/drm/amd/amdkfd/Makefile | 1 + drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 66 ++ drivers/gpu/drm/amd/amdkfd/cik_int.h | 41 + drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 87 +- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 52 +- .../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 15 + drivers/gpu/drm/amd/amdkfd/kfd_events.c | 954 +++++++++++++++++++++ drivers/gpu/drm/amd/amdkfd/kfd_events.h | 84 ++ drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c | 188 ++++ drivers/gpu/drm/amd/amdkfd/kfd_module.c | 9 +- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 75 ++ drivers/gpu/drm/amd/amdkfd/kfd_process.c | 24 + drivers/gpu/drm/amd/include/kgd_kfd_interface.h | 2 + drivers/gpu/drm/radeon/cik_reg.h | 2 + drivers/gpu/drm/radeon/cikd.h | 1 + drivers/gpu/drm/radeon/radeon_kfd.c | 21 +- include/uapi/linux/kfd_ioctl.h | 96 ++- 17 files changed, 1710 insertions(+), 8 deletions(-) create mode 100644 drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c create mode 100644 drivers/gpu/drm/amd/amdkfd/cik_int.h create mode 100644 drivers/gpu/drm/amd/amdkfd/kfd_events.c create mode 100644 drivers/gpu/drm/amd/amdkfd/kfd_events.h create mode 100644 drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c -- 1.9.1

1 9

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2015