dri-devel May 2015

dri-devel@lists.freedesktop.org

191 participants
1132 discussions

[PATCH] drm/vgem: drop DRIVER_PRIME (v2)
by Rob Clark 26 May '15

26 May '15

For actual sharing of buffers with other drivers (ie. actual hardware) we'll need to pimp things out a bit better to deal w/ caching, multiple memory domains, etc. See thread: http://lists.freedesktop.org/archives/dri-devel/2015-May/083160.html But for the llvmpipe use-case this isn't a problem. Nor do we really need prime/dri3 (dri2 is sufficient). So until the other issues are sorted lets remove DRIVER_PRIME. v2: also drop the dead code Signed-off-by: Rob Clark <robdclark(a)gmail.com> --- drivers/gpu/drm/vgem/Makefile | 2 +- drivers/gpu/drm/vgem/vgem_dma_buf.c | 94 ------------------------------------- drivers/gpu/drm/vgem/vgem_drv.c | 11 +---- drivers/gpu/drm/vgem/vgem_drv.h | 11 ----- 4 files changed, 2 insertions(+), 116 deletions(-) delete mode 100644 drivers/gpu/drm/vgem/vgem_dma_buf.c diff --git a/drivers/gpu/drm/vgem/Makefile b/drivers/gpu/drm/vgem/Makefile index 1055cb7..3f4c7b8 100644 --- a/drivers/gpu/drm/vgem/Makefile +++ b/drivers/gpu/drm/vgem/Makefile @@ -1,4 +1,4 @@ ccflags-y := -Iinclude/drm -vgem-y := vgem_drv.o vgem_dma_buf.o +vgem-y := vgem_drv.o obj-$(CONFIG_DRM_VGEM) += vgem.o diff --git a/drivers/gpu/drm/vgem/vgem_dma_buf.c b/drivers/gpu/drm/vgem/vgem_dma_buf.c deleted file mode 100644 index 0254438..0000000 --- a/drivers/gpu/drm/vgem/vgem_dma_buf.c +++ /dev/null @@ -1,94 +0,0 @@ -/* - * Copyright © 2012 Intel Corporation - * Copyright © 2014 The Chromium OS Authors - * - * Permission is hereby granted, free of charge, to any person obtaining a - * copy of this software and associated documentation files (the "Software"), - * to deal in the Software without restriction, including without limitation - * the rights to use, copy, modify, merge, publish, distribute, sublicense, - * and/or sell copies of the Software, and to permit persons to whom the - * Software is furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice (including the next - * paragraph) shall be included in all copies or substantial portions of the - * Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL - * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS - * IN THE SOFTWARE. - * - * Authors: - * Ben Widawsky <ben(a)bwidawsk.net> - * - */ - -#include <linux/dma-buf.h> -#include "vgem_drv.h" - -struct sg_table *vgem_gem_prime_get_sg_table(struct drm_gem_object *gobj) -{ - struct drm_vgem_gem_object *obj = to_vgem_bo(gobj); - BUG_ON(obj->pages == NULL); - - return drm_prime_pages_to_sg(obj->pages, obj->base.size / PAGE_SIZE); -} - -int vgem_gem_prime_pin(struct drm_gem_object *gobj) -{ - struct drm_vgem_gem_object *obj = to_vgem_bo(gobj); - return vgem_gem_get_pages(obj); -} - -void vgem_gem_prime_unpin(struct drm_gem_object *gobj) -{ - struct drm_vgem_gem_object *obj = to_vgem_bo(gobj); - vgem_gem_put_pages(obj); -} - -void *vgem_gem_prime_vmap(struct drm_gem_object *gobj) -{ - struct drm_vgem_gem_object *obj = to_vgem_bo(gobj); - BUG_ON(obj->pages == NULL); - - return vmap(obj->pages, obj->base.size / PAGE_SIZE, 0, PAGE_KERNEL); -} - -void vgem_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr) -{ - vunmap(vaddr); -} - -struct drm_gem_object *vgem_gem_prime_import(struct drm_device *dev, - struct dma_buf *dma_buf) -{ - struct drm_vgem_gem_object *obj = NULL; - int ret; - - obj = kzalloc(sizeof(*obj), GFP_KERNEL); - if (obj == NULL) { - ret = -ENOMEM; - goto fail; - } - - ret = drm_gem_object_init(dev, &obj->base, dma_buf->size); - if (ret) { - ret = -ENOMEM; - goto fail_free; - } - - get_dma_buf(dma_buf); - - obj->base.dma_buf = dma_buf; - obj->use_dma_buf = true; - - return &obj->base; - -fail_free: - kfree(obj); -fail: - return ERR_PTR(ret); -} diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index cb3b435..7a207ca 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c @@ -302,22 +302,13 @@ static const struct file_operations vgem_driver_fops = { }; static struct drm_driver vgem_driver = { - .driver_features = DRIVER_GEM | DRIVER_PRIME, + .driver_features = DRIVER_GEM, .gem_free_object = vgem_gem_free_object, .gem_vm_ops = &vgem_gem_vm_ops, .ioctls = vgem_ioctls, .fops = &vgem_driver_fops, .dumb_create = vgem_gem_dumb_create, .dumb_map_offset = vgem_gem_dumb_map, - .prime_handle_to_fd = drm_gem_prime_handle_to_fd, - .prime_fd_to_handle = drm_gem_prime_fd_to_handle, - .gem_prime_export = drm_gem_prime_export, - .gem_prime_import = vgem_gem_prime_import, - .gem_prime_pin = vgem_gem_prime_pin, - .gem_prime_unpin = vgem_gem_prime_unpin, - .gem_prime_get_sg_table = vgem_gem_prime_get_sg_table, - .gem_prime_vmap = vgem_gem_prime_vmap, - .gem_prime_vunmap = vgem_gem_prime_vunmap, .name = DRIVER_NAME, .desc = DRIVER_DESC, .date = DRIVER_DATE, diff --git a/drivers/gpu/drm/vgem/vgem_drv.h b/drivers/gpu/drm/vgem/vgem_drv.h index 57ab4d8..e9f92f7 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.h +++ b/drivers/gpu/drm/vgem/vgem_drv.h @@ -43,15 +43,4 @@ struct drm_vgem_gem_object { extern void vgem_gem_put_pages(struct drm_vgem_gem_object *obj); extern int vgem_gem_get_pages(struct drm_vgem_gem_object *obj); -/* vgem_dma_buf.c */ -extern struct sg_table *vgem_gem_prime_get_sg_table( - struct drm_gem_object *gobj); -extern int vgem_gem_prime_pin(struct drm_gem_object *gobj); -extern void vgem_gem_prime_unpin(struct drm_gem_object *gobj); -extern void *vgem_gem_prime_vmap(struct drm_gem_object *gobj); -extern void vgem_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr); -extern struct drm_gem_object *vgem_gem_prime_import(struct drm_device *dev, - struct dma_buf *dma_buf); - - #endif -- 2.4.1

5 5

drivers/gpu/drm/i915/i915_gem_gtt.c
by Andrew Morton 26 May '15

26 May '15

I'm not sure what's happened to the drm code in linux-next - it's exploding all over the place. Did someone turn on -Werror without doing anywhere near enough testing? Anyway, I don't know how to fix this i386 build error: drivers/gpu/drm/i915/i915_gem_gtt.c: In function 'gen8_ppgtt_init': drivers/gpu/drm/i915/i915_gem_gtt.c:954:2: error: large integer implicitly truncated to unsigned type [-Werror=overflow] ppgtt->base.total = 1ULL << 32; i915_address_space.total is a ulong: 32-bit.

4 4

[Bug 89034] Firefox crashing xserver and some major rendering bugs
by bugzilla-daemon＠freedesktop.org 26 May '15

26 May '15

https://bugs.freedesktop.org/show_bug.cgi?id=89034 Bug ID: 89034 Summary: Firefox crashing xserver and some major rendering bugs Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: critical Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: smoki00790(a)gmail.com QA Contact: dri-devel(a)lists.freedesktop.org Created attachment 113269 --> https://bugs.freedesktop.org/attachment.cgi?id=113269&action=edit valley_artifacts Well i put this as radeosi bug as i am not sure if happens elsewhere. It is LLVM bug actually which happens once subreg liveness is enabled, so svn 228228 is bisected as bad. I running current llvm with subreg liveness disabled, as this is major/grave one bug for me. Same issue was present in Tom's perf branches last month once subreg liveness is enabled too. Hardware is kabini (Athlon 5350), current Debian Sid 64bit, kernel 3.19.0, xserver git, mesa git, etc... Attached is screenshot from Unigine Valley for example, there are major rendering issues in many other GL apps. For Firefox crashing xserver not sure how to debug that (btw it crashed X immidiate at starting FF) , if i build llvm with debug and assertations screen/monitor somehow looks like it goes sleep mode (without any messages in logs) and only hard reset helps. If i build llvm without those it just crashing xserver, but there is not enough info in Xorg.0.log :( -- You are receiving this mail because: You are the assignee for the bug.

1 50

[Bug 90439] Xonotic render green (bisected)
by bugzilla-daemon＠freedesktop.org 26 May '15

26 May '15

https://bugs.freedesktop.org/show_bug.cgi?id=90439 Bug ID: 90439 Summary: Xonotic render green (bisected) Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: smoki00790(a)gmail.com QA Contact: dri-devel(a)lists.freedesktop.org Created attachment 115745 --> https://bugs.freedesktop.org/attachment.cgi?id=115745&action=edit Good llvm r237140 bisected where Xonotic start to render mostly green artifacts on textures. Attached R600_DEBUG=ps,vs,gs outputs from good on llvm r237139 -- You are receiving this mail because: You are the assignee for the bug.

1 16

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass
by bugzilla-daemon＠freedesktop.org 25 May '15

25 May '15

https://bugs.freedesktop.org/show_bug.cgi?id=90056 Bug ID: 90056 Summary: Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: adf.lists(a)gmail.com QA Contact: dri-devel(a)lists.freedesktop.org R9270X Since commit c6d79ed289a75f13c65f011be870f7e43a0fedc7 Author: Tom Stellard <thomas.stellard(a)amd.com> Date: Fri Apr 10 17:07:16 2015 +0000 radeon/llvm: Run LLVM's instruction combining pass This should improve code quality in general and will help with some future changes to how we emit kill instructions. shader-db shows a few regressions, but these don't seem to be the result of deficiencies in instcombine. They're mostly caused by the scheduler making different decisions than before. Unigine Valley quits saying - Unhandled loop condition! UNREACHABLE executed at SIAnnotateControlFlow.cpp:267! Only tried my normal settings on valley which are quality ultra + 8x AA -- You are receiving this mail because: You are the assignee for the bug.

1 19

block_all_signals() usage in DRM
by Richard Weinberger 25 May '15

25 May '15

Hi! drivers/gpu/drm/drm_lock.c is the only remaining user of block_all_signals(): /* don't set the block all signals on the master process for now * really probably not the correct answer but lets us debug xkb * xserver for now */ if (!file_priv->is_master) { sigemptyset(&dev->sigmask); sigaddset(&dev->sigmask, SIGSTOP); sigaddset(&dev->sigmask, SIGTSTP); sigaddset(&dev->sigmask, SIGTTIN); sigaddset(&dev->sigmask, SIGTTOU); dev->sigdata.context = lock->context; dev->sigdata.lock = master->lock.hw_lock; block_all_signals(drm_notifier, dev, &dev->sigmask); } Is this functionality still in use/needed? Otherwise we could get rid of block_all_signals() and unpuzzle the signaling code a bit. :-) Thanks, //richard

3 4

[PATCH] drm/i2c: tda998x: Use '%zd' for printing 'ssize_t' format
by Fabio Estevam 25 May '15

25 May '15

Use '%zd' for printing 'ssize_t' format in order to fix the following build warning on ARM64: drivers/gpu/drm/i2c/tda998x_drv.c: In function 'tda998x_write_avi': drivers/gpu/drm/i2c/tda998x_drv.c:647:3: warning: format '%d' expects argument of type 'int', but argument 3 has type 'ssize_t' [-Wformat=] Reported-by: Olof's autobuilder <build(a)lixom.net> Signed-off-by: Fabio Estevam <fabio.estevam(a)freescale.com> --- drivers/gpu/drm/i2c/tda998x_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index 011e1ca..d5dc8aa 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -644,7 +644,8 @@ tda998x_write_avi(struct tda998x_priv *priv, struct drm_display_mode *mode) len = hdmi_avi_infoframe_pack(&frame, buf, sizeof(buf)); if (len < 0) { - dev_err(&priv->hdmi->dev, "hdmi_avi_infoframe_pack() failed: %d\n", len); + dev_err(&priv->hdmi->dev, "hdmi_avi_infoframe_pack() failed: %zd\n", + len); return; } -- 1.9.1

2 1

[GIT PULL FOR v4.1] ADV7511 driver fixes
by Laurent Pinchart 25 May '15

25 May '15

1 1

[GIT PULL FOR v4.2] R-Car DU driver fixes
by Laurent Pinchart 25 May '15

25 May '15

Hi Dave, The following changes since commit bdcddf95e82b1c4e370fc1196b1f4f50f775dab4: Backmerge v4.1-rc4 into into drm-next (2015-05-20 16:23:53 +1000) are available in the git repository at: git://linuxtv.org/pinchartl/fbdev.git drm/next/rcar-du for you to fetch changes up to 2610abfb3a72f6e5444a710b695c9460138f9326: drm: rcar-du: Split planes pre-association 4/4 between CRTCs (2015-05-25 15:34:13 +0300) ---------------------------------------------------------------- Laurent Pinchart (10): drm: rcar-du: Document the rcar_du_crtc structure drm: rcar-du: Document the rcar_du_plane_state structure drm: rcar-du: Move properties from rcar_du_planes to rcar_du_device drm: rcar-du: Embed rcar_du_planes structure into rcar_du_group drm: rcar-du: Rename to_rcar_du_plane_state to to_rcar_plane_state drm: rcar-du: Add plane allocation debugging drm: rcar-du: Keep plane to CRTC associations when disabling a plane drm: rcar-du: Consider plane to CRTC associations in the plane allocator drm: rcar-du: Store the number of CRTCs per group in the group structure drm: rcar-du: Split planes pre-association 4/4 between CRTCs drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 61 ++++++++++++----------- drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 14 ++++++ drivers/gpu/drm/rcar-du/rcar_du_drv.h | 6 +++ drivers/gpu/drm/rcar-du/rcar_du_group.c | 6 +++ drivers/gpu/drm/rcar-du/rcar_du_group.h | 8 ++- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 105 ++++++++++++++++++++++++++---- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 71 +++++++++------------------ drivers/gpu/drm/rcar-du/rcar_du_plane.h | 21 ++++---- 8 files changed, 195 insertions(+), 97 deletions(-) -- Regards, Laurent Pinchart

1 0

[RESEND PATCH v1 0/2] Add dw_hdmi i2s audio driver support
by Yakir Yang 25 May '15

25 May '15

As Russell have send an series patches for dw_hdmi audio, it make us upload dw_hdmi audio patch more easier, and most important it works well on rockchip platform, so I make this patch that try to add another audio interface support in dw_hdmi driver. Here are the list that I have make in my series: - rename dw_hdmi-ahb-audio.h to dw_hdmi-audio.h - add dw_hdmi i2s audio driver Here are the series patches that I depends on: * drm: bridge/dw_hdmi: fixed codec style [Yakir Yang] * drm: bridge/dw_hdmi_rockchip: improve hdmi eye-diagram test * drm: bridge/dw_hdmi: improve hdmi single-end test * drm: imx/dw_hdmi: move phy comments [Russell King] * drm: bridge/dw_hdmi: clean up phy configuration * drm: bridge/dw_hdmi: combine hdmi_set_clock_regenerator_n() and hdmi_regenerate_cts() * drm: bridge/dw_hdmi: protect n/cts setting with a mutex * drm: bridge/dw_hdmi: adjust n/cts setting order * drm: bridge/dw_hdmi: clean up hdmi_set_clk_regenerator() * drm: bridge/dw_hdmi: use drm_hdmi_avi_infoframe_from_display_mode() * drm: bridge/dw_hdmi: simplify hdmi_config_AVI() a little * drm: bridge/dw_hdmi: remove mhsyncpolarity/mvsyncpolarity/minterlaced * drm: bridge/dw_hdmi: introduce interface to setting sample rate * drm: bridge/dw_hdmi: introduce interfaces to enable and disable audio * drm/edid: add function to help find SADs * sound/core: add DRM ELD helper * sound/core: add IEC958 channel status helper * drm: bridge/dw_hdmi-ahb-audio: add audio driver * drm: bridge/dw_hdmi-ahb-audio: parse ELD from HDMI driver Best regards, Yakir Yang Yakir Yang (2): drm: bridge/dw_hdmi: rename dw_hdmi-ahb-audio.h to dw_hdmi-audio.h drm: bridge/dw_hdmi-i2s-audio: add audio driver drivers/gpu/drm/bridge/Kconfig | 9 + drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge/dw_hdmi-ahb-audio.c | 2 +- .../{dw_hdmi-ahb-audio.h => dw_hdmi-audio.h} | 0 drivers/gpu/drm/bridge/dw_hdmi-i2s-audio.c | 412 +++++++++++++++++++++ drivers/gpu/drm/bridge/dw_hdmi.c | 26 +- drivers/gpu/drm/bridge/dw_hdmi.h | 3 + 7 files changed, 442 insertions(+), 11 deletions(-) rename drivers/gpu/drm/bridge/{dw_hdmi-ahb-audio.h => dw_hdmi-audio.h} (100%) create mode 100644 drivers/gpu/drm/bridge/dw_hdmi-i2s-audio.c -- 2.1.2

3 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2015