dri-devel May 2015

dri-devel@lists.freedesktop.org

191 participants
1132 discussions

[PATCH v2 02/17] drm/atomic: Allow drivers to subclass drm_atomic_state, v2
by Maarten Lankhorst 18 May '15

18 May '15

Drivers may need to store the state of shared resources, such as PLLs or FIFO space, into the atomic state. Allow this by making it possible to subclass drm_atomic_state. Changes since v1: - Change member names for functions to atomic_state_(alloc,clear) - Change __drm_atomic_state_new to drm_atomic_state_init - Allow free function to be overridden too, in case extra memory is allocated in alloc. Cc: dri-devel(a)lists.freedesktop.org Acked-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira(a)intel.com> Signed-off-by: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> --- drivers/gpu/drm/drm_atomic.c | 116 ++++++++++++++++++++++++++++++++----------- include/drm/drm_atomic.h | 5 ++ include/drm/drm_crtc.h | 6 +++ 3 files changed, 99 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index c6277a4a1f2f..47364f244dc0 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -30,7 +30,15 @@ #include <drm/drm_atomic.h> #include <drm/drm_plane_helper.h> -static void kfree_state(struct drm_atomic_state *state) +/** + * drm_atomic_state_default_free - + * free memory initialized by drm_atomic_state_init + * @state: atomic state + * + * Free all the memory allocated by drm_atomic_state_init. + * This is useful for drivers that subclass the atomic state. + */ +void drm_atomic_state_default_free(struct drm_atomic_state *state) { kfree(state->connectors); kfree(state->connector_states); @@ -38,24 +46,20 @@ static void kfree_state(struct drm_atomic_state *state) kfree(state->crtc_states); kfree(state->planes); kfree(state->plane_states); - kfree(state); } +EXPORT_SYMBOL(drm_atomic_state_default_free); /** - * drm_atomic_state_alloc - allocate atomic state + * drm_atomic_state_init - init new atomic state * @dev: DRM device + * @state: atomic state * - * This allocates an empty atomic state to track updates. + * Default implementation for filling in a new atomic state. + * This is useful for drivers that subclass the atomic state. */ -struct drm_atomic_state * -drm_atomic_state_alloc(struct drm_device *dev) +int +drm_atomic_state_init(struct drm_device *dev, struct drm_atomic_state *state) { - struct drm_atomic_state *state; - - state = kzalloc(sizeof(*state), GFP_KERNEL); - if (!state) - return NULL; - /* TODO legacy paths should maybe do a better job about * setting this appropriately? */ @@ -92,31 +96,50 @@ drm_atomic_state_alloc(struct drm_device *dev) state->dev = dev; - DRM_DEBUG_ATOMIC("Allocate atomic state %p\n", state); + DRM_DEBUG_ATOMIC("Allocated atomic state %p\n", state); - return state; + return 0; fail: - kfree_state(state); + drm_atomic_state_default_free(state); + return -ENOMEM; +} +EXPORT_SYMBOL(drm_atomic_state_init); + +/** + * drm_atomic_state_alloc - allocate atomic state + * @dev: DRM device + * + * This allocates an empty atomic state to track updates. + */ +struct drm_atomic_state * +drm_atomic_state_alloc(struct drm_device *dev) +{ + struct drm_mode_config *config = &dev->mode_config; + struct drm_atomic_state *state; + + if (!config->funcs->atomic_state_alloc) { + state = kzalloc(sizeof(*state), GFP_KERNEL); + if (!state) + return NULL; + if (drm_atomic_state_init(dev, state) < 0) { + kfree(state); + return NULL; + } + return state; + } - return NULL; + return config->funcs->atomic_state_alloc(dev); } EXPORT_SYMBOL(drm_atomic_state_alloc); /** - * drm_atomic_state_clear - clear state object + * drm_atomic_state_default_clear - clear base atomic state * @state: atomic state * - * When the w/w mutex algorithm detects a deadlock we need to back off and drop - * all locks. So someone else could sneak in and change the current modeset - * configuration. Which means that all the state assembled in @state is no - * longer an atomic update to the current state, but to some arbitrary earlier - * state. Which could break assumptions the driver's ->atomic_check likely - * relies on. - * - * Hence we must clear all cached state and completely start over, using this - * function. + * Default implementation for clearing atomic state. + * This is useful for drivers that subclass the atomic state. */ -void drm_atomic_state_clear(struct drm_atomic_state *state) +void drm_atomic_state_default_clear(struct drm_atomic_state *state) { struct drm_device *dev = state->dev; struct drm_mode_config *config = &dev->mode_config; @@ -162,6 +185,32 @@ void drm_atomic_state_clear(struct drm_atomic_state *state) state->plane_states[i] = NULL; } } +EXPORT_SYMBOL(drm_atomic_state_default_clear); + +/** + * drm_atomic_state_clear - clear state object + * @state: atomic state + * + * When the w/w mutex algorithm detects a deadlock we need to back off and drop + * all locks. So someone else could sneak in and change the current modeset + * configuration. Which means that all the state assembled in @state is no + * longer an atomic update to the current state, but to some arbitrary earlier + * state. Which could break assumptions the driver's ->atomic_check likely + * relies on. + * + * Hence we must clear all cached state and completely start over, using this + * function. + */ +void drm_atomic_state_clear(struct drm_atomic_state *state) +{ + struct drm_device *dev = state->dev; + struct drm_mode_config *config = &dev->mode_config; + + if (config->funcs->atomic_state_clear) + config->funcs->atomic_state_clear(state); + else + drm_atomic_state_default_clear(state); +} EXPORT_SYMBOL(drm_atomic_state_clear); /** @@ -173,14 +222,25 @@ EXPORT_SYMBOL(drm_atomic_state_clear); */ void drm_atomic_state_free(struct drm_atomic_state *state) { + struct drm_device *dev; + struct drm_mode_config *config; + if (!state) return; + dev = state->dev; + config = &dev->mode_config; + drm_atomic_state_clear(state); DRM_DEBUG_ATOMIC("Freeing atomic state %p\n", state); - kfree_state(state); + if (config->funcs->atomic_state_free) { + config->funcs->atomic_state_free(state); + } else { + drm_atomic_state_default_free(state); + kfree(state); + } } EXPORT_SYMBOL(drm_atomic_state_free); diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index d78543067700..6445970535ec 100644 --- a/include/drm/drm_atomic.h +++ b/include/drm/drm_atomic.h @@ -35,6 +35,11 @@ drm_atomic_state_alloc(struct drm_device *dev); void drm_atomic_state_clear(struct drm_atomic_state *state); void drm_atomic_state_free(struct drm_atomic_state *state); +int __must_check +drm_atomic_state_init(struct drm_device *dev, struct drm_atomic_state *state); +void drm_atomic_state_default_clear(struct drm_atomic_state *state); +void drm_atomic_state_default_free(struct drm_atomic_state *state); + struct drm_crtc_state * __must_check drm_atomic_get_crtc_state(struct drm_atomic_state *state, struct drm_crtc *crtc); diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 840e9e62878c..bff25b0cada9 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -985,6 +985,9 @@ struct drm_mode_set { * @atomic_check: check whether a given atomic state update is possible * @atomic_commit: commit an atomic state update previously verified with * atomic_check() + * @atomic_state_alloc: allocate a new atomic state + * @atomic_state_clear: clear the atomic state + * @atomic_state_free: free the atomic state * * Some global (i.e. not per-CRTC, connector, etc) mode setting functions that * involve drivers. @@ -1000,6 +1003,9 @@ struct drm_mode_config_funcs { int (*atomic_commit)(struct drm_device *dev, struct drm_atomic_state *a, bool async); + struct drm_atomic_state *(*atomic_state_alloc)(struct drm_device *dev); + void (*atomic_state_clear)(struct drm_atomic_state *state); + void (*atomic_state_free)(struct drm_atomic_state *state); }; /** -- 2.1.0

2 2

[Bug 90370] [radeonsi] dota2 suffers from many glitches
by bugzilla-daemon＠freedesktop.org 18 May '15

18 May '15

https://bugs.freedesktop.org/show_bug.cgi?id=90370 Bug ID: 90370 Summary: [radeonsi] dota2 suffers from many glitches Product: Mesa Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: sylvain.bertrand(a)gmail.com QA Contact: dri-devel(a)lists.freedesktop.org While playing dota2, I can see a lot of artifacts, and I get a lot of mini hangs on tahiti xt gpu (radeonsi). llvm f194367792d7c43f0476e11e7c0d171b8bfbc601 15/04/2015 linux 4.0.0 mesa a7d018accfd0161510a75ba685e056256de494c2 08/04/2015 (no glx-tls/dri3 is on) libdrm 0d78b37b1cac304ce5e84d1207f0a43abd29c000 15/04-22015 -- You are receiving this mail because: You are the assignee for the bug.

1 17

[PULL] drm-intel-next
by Daniel Vetter 18 May '15

18 May '15

Hi Dave, drm-intel-next-2015-05-08: - skl plane scaler support (Chandra Kondru) - enable hsw cmd parser (Daniel and fix from Rebecca Palmer) - skl dc5/6 support (low power display modes) from Suketu&Sunil - dp compliance testing patches (Todd Previte) - dp link training optimization (Mika Kahola) - fixes to make skl resume work (Damien) - rework modeset code to fully use atomic state objects (Ander&Maarten) - pile of bxt w/a patchs from Nick Hoath - (linear) partial gtt mmap support (Joonas Lahtinen) Cheers, Daniel The following changes since commit e1dee1973c74a0408b108d88c57a15be8a2d6d84: Merge tag 'drm-intel-next-2015-04-23-fixed' of git://anongit.freedesktop.org/drm-intel into drm-next (2015-05-08 20:51:06 +1000) are available in the git repository at: git://anongit.freedesktop.org/drm-intel tags/drm-intel-next-2015-05-08 for you to fetch changes up to 214a2b7fab215b1e979fbae51225b01b8fc58288: drm/i915: Update DRIVER_DATE to 20150508 (2015-05-08 17:38:19 +0200) ---------------------------------------------------------------- - skl plane scaler support (Chandra Kondru) - enable hsw cmd parser (Daniel and fix from Rebecca Palmer) - skl dc5/6 support (low power display modes) from Suketu&Sunil - dp compliance testing patches (Todd Previte) - dp link training optimization (Mika Kahola) - fixes to make skl resume work (Damien) - rework modeset code to fully use atomic state objects (Ander&Maarten) - pile of bxt w/a patchs from Nick Hoath - (linear) partial gtt mmap support (Joonas Lahtinen) ---------------------------------------------------------------- A.Sunil Kamath (2): drm/i915/skl: Implement enable/disable for Display C5 state. Implement enable/disable for Display C6 state Ander Conselvan de Oliveira (28): drm/i915: Don't check for NULL before freeing state drm/i915: Call drm helpers when duplicating crtc and plane states drm/i915: Use for_each_connector_in_state helper macro drm/i915: Extract mode_changed computation out of stage_output_config() drm/i915: Add crtc states before calling compute_config() drm/i915: Don't pretend we can calculate multiple pipe_configs drm/i915: Calculate a new pipe_config based on new enabled state drm/i915: Remove all *_pipes flags from modeset drm/i915: Remove saved_mode from __intel_set_mode() drm/i915: Move compute part of __intel_set_mode() to separate function drm/i915: Simplify error handling in __intel_set_mode() drm/i915: Don't modeset with old mode when set_crtc fails drm/i915: Add primary plane to atomic state in legacy modeset drm/i915: Delete fb, x and y parameters from mode set functions drm/i915: Don't use struct intel_set_config *_changed flags drm/i915: Don't use staged config to calculate mode_changed flags drm/i915: Unify modeset and flip paths of intel_crtc_set_config() drm/i915: Simplify intel_set_config_compute_mode_changes() a bit drm/i915: Stage new modeset state straight into atomic state drm/i915: Remove save/restore logic from intel_crtc_set_config() drm/i915: Update crtc state active flag based on DPMS drm/atomic: Make mode_fixup() optional for check_modeset() drm/i915: Use atomic helpers for computing changed flags drm/i915: Take ownership of atomic state on success in intel_set_mode() drm/i915: Preserve shared DPLL information in new pipe_config drm/i915: Don't use plane update helper in legacy mode set drm/i915: Swap atomic state in legacy modeset drm/i915: Get rid of intel_crtc_set_state() Chandra Konduru (2): drm/i915: skylake primary plane scaling using shared scalers drm/i915: skylake sprite plane scaling using shared scalers Chris Wilson (3): drm/i915: Add RPS thresholds to debugfs/i915_frequency_info drm/i915: Remove incorrect restriction on 32bit offsets in ppGTT backend drm/i915: Remove locking for get-caching query Damien Lespiau (7): drm/i915/skl: Add the INIT power domain to the MISC I/O power well drm/i915/skl: Fix the CTRL typo in the DPLL_CRTL1 defines drm/i915: Re-order the PCU opcodes drm/i915: Merge the GEN9 memory latency PCU opcode with its friends drm/i915/skl: Make the Misc I/O power well part of the PLLS domain drm/i915/skl: Fix WaDisableChickenBitTSGBarrierAckForFFSliceCS drm/i915/skl: Re-indent part of skl_ddi_calculate_wrpll() Dan Carpenter (1): drm/i915: checking IS_ERR() instead of NULL Daniel Vetter (4): drm/i915: Simplify cmd-parser DISPATCH_SECURE check drm/i915/skl: Add support to load SKL CSR firmware. drm/edid: Kerneldoc for newly added edid_corrupt drm/i915: Update DRIVER_DATE to 20150508 Deepak S (1): drm/i915: Setup static bias for GPU Fabian Frederick (1): drm/i915: use ERR_CAST instead of ERR_PTR/PTR_ERR Jani Nikula (2): drm/i915: make drm_crtc_helper_funcs const data drm/i915/audio: do not mess with audio registers if port is invalid Jesse Barnes (1): drm/i915/vlv: remove wait for previous GFX clk disable request Joonas Lahtinen (6): drm/i915: Do not clear mappings beyond VMA size drm/i915: Do not make assumptions on GGTT VMA sizes drm/i915: Consider object pinned if any VMA is pinned drm/i915: Add a partial GGTT view type drm/i915: Use partial view in mmap fault handler drm/i915: Reject huge tiled objects Maarten Lankhorst (7): drm/i915: Remove implicitly disabling primary plane for now drm/i915: Add a way to disable planes without updating state drm/i915: Use the disable callback for disabling planes. drm/i915: get rid of primary_enabled and use atomic state drm/i915: Move intel_(pre_disable/post_enable)_primary to intel_display.c, and use it there. drm/i915: Rename intel_crtc_dpms_overlay. drm/i915: Move toggling planes out of crtc enable/disable. Matt Roper (1): drm/i915: Set crtc_state->active to false when CRTC is disabled (v2) Michel Thierry (1): drm/i915: Fix 32b overflow check in gen8_ppgtt_alloc_page_directories Mika Kahola (2): drm/i915: eDP link training optimization drm/i915: DP link training optimization Mika Kuoppala (2): drm/i915: Clear vma->bound on unbinding drm/i915: Free wa_batchbuffer when freeing error state Nick Hoath (12): drm/i915/bxt: Add WaDisableThreadStallDopClockGating drm/i915/bxt: Add WaDisableSbeCacheDispatchPortSharing drm/i915/bxt: Add WaForceContextSaveRestoreNonCoherent drm/i915/bxt: Mark WaDisablePartialInstShootdown as for Broxton also. drm/i915/bxt: Mark workaround as for Skylake & Broxton drm/i915/bxt: Enable WaDisableDgMirrorFixInHalfSliceChicken5 for Broxton drm/i915/bxt: Enable WaSetDisablePixMaskCammingAndRhwoInCommonSliceChicken for Broxton drm/i915/bxt: Enable WaEnableYV12BugFixInHalfSliceChicken7 for Broxton drm/i915/bxt: Move WaForceEnableNonCoherent to Skylake only drm/i915/bxt: Mark Wa4x4STCOptimizationDisable as for Broxton also. drm/i915/bxt: Mark WaDisablePartialResolveInVc as for Broxton also. drm/i915/bxt: Mark WaCcsTlbPrefetchDisable as for Broxton also. Rebecca N. Palmer (1): drm/i915: Fix possible security hole in command parsing Sonika Jindal (2): drm/i915/skl: Add module parameter to select edp vswing table drm/i915: Rename dp rates array as per platform Suketu Shah (5): drm/i915/skl: Add DC5 Trigger Sequence drm/i915/skl: Assert the requirements to enter or exit DC5. drm/i915/skl: Add DC6 Trigger sequence. drm/i915/skl: Assert the requirements to enter or exit DC6. drm/i915/skl: Enable runtime PM Todd Previte (4): drm/i915: Move Displayport test request and sink IRQ logic to intel_dp_detect() drm: Add edid_corrupt flag for Displayport Link CTS 4.2.2.6 drm/i915: Implement the intel_dp_autotest_edid function for DP EDID complaince tests drm/i915: Add debugfs test control files for Displayport compliance testing Vandana Kannan (1): drm/i915/bxt: BLC implementation Ville Syrjälä (7): drm/i915: Use POSTING_READ() in intel_sdvo_write_sdvox() drm/i915: s/9/intel_freq_opcode(450)/ drm/i915: Add missing POSTING_READ()s to BXT dbuf enable sequence drm/i915: Implement chv display PHY lane stagger setup drm/i915: Work around DISPLAY_PHY_CONTROL register corruption on CHV Revert "drm/i915: Hack to tie both common lanes together on chv" drm/i915: Only wait for required lanes in vlv_wait_port_ready() drivers/gpu/drm/drm_atomic_helper.c | 5 + drivers/gpu/drm/drm_edid.c | 32 +- drivers/gpu/drm/drm_edid_load.c | 7 +- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/i915_debugfs.c | 240 +++- drivers/gpu/drm/i915/i915_dma.c | 11 +- drivers/gpu/drm/i915/i915_drv.c | 64 +- drivers/gpu/drm/i915/i915_drv.h | 42 +- drivers/gpu/drm/i915/i915_gem.c | 174 ++- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 32 +- drivers/gpu/drm/i915/i915_gem_gtt.c | 87 +- drivers/gpu/drm/i915/i915_gem_gtt.h | 20 +- drivers/gpu/drm/i915/i915_gpu_error.c | 1 + drivers/gpu/drm/i915/i915_params.c | 8 + drivers/gpu/drm/i915/i915_reg.h | 89 +- drivers/gpu/drm/i915/intel_atomic.c | 13 +- drivers/gpu/drm/i915/intel_atomic_plane.c | 20 +- drivers/gpu/drm/i915/intel_audio.c | 20 +- drivers/gpu/drm/i915/intel_bios.c | 9 +- drivers/gpu/drm/i915/intel_csr.c | 414 +++++++ drivers/gpu/drm/i915/intel_ddi.c | 101 +- drivers/gpu/drm/i915/intel_display.c | 1774 +++++++++++++--------------- drivers/gpu/drm/i915/intel_dp.c | 151 ++- drivers/gpu/drm/i915/intel_dp_mst.c | 13 +- drivers/gpu/drm/i915/intel_drv.h | 46 +- drivers/gpu/drm/i915/intel_fbc.c | 2 +- drivers/gpu/drm/i915/intel_hdmi.c | 46 +- drivers/gpu/drm/i915/intel_lrc.c | 7 +- drivers/gpu/drm/i915/intel_panel.c | 87 +- drivers/gpu/drm/i915/intel_pm.c | 19 +- drivers/gpu/drm/i915/intel_ringbuffer.c | 67 +- drivers/gpu/drm/i915/intel_runtime_pm.c | 251 +++- drivers/gpu/drm/i915/intel_sdvo.c | 6 +- drivers/gpu/drm/i915/intel_sprite.c | 262 ++-- include/drm/drm_crtc.h | 9 +- 35 files changed, 2664 insertions(+), 1468 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_csr.c -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

1 0

[PATCH] drm/atomic: remove duplicated assignment of old_plane_state
by Gustavo Padovan 18 May '15

18 May '15

From: Gustavo Padovan <gustavo.padovan(a)collabora.co.uk> old_plane_state is already assigned to old_state->plane_states[i] inside for_each_plane_in_state(). Here we remove an the extra assignment. Signed-off-by: Gustavo Padovan <gustavo.padovan(a)collabora.co.uk> --- drivers/gpu/drm/drm_atomic_helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 5d30592..c9af027 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -1130,8 +1130,6 @@ void drm_atomic_helper_commit_planes(struct drm_device *dev, if (!funcs) continue; - old_plane_state = old_state->plane_states[i]; - /* * Special-case disabling the plane if drivers support it. */ -- 2.1.0

2 1

[PATCH] drm/dp: Fix comment in DP helper
by Jon Hunter 18 May '15

18 May '15

Commit 4f71d0cb76339 ("drm/dp: add a hw mutex around the transfer functions. (v2)"), renamed the functions drm_dp_aux_register_i2c_bus() and drm_dp_aux_unregister_i2c_bus() to drm_dp_aux_register() and drm_dp_aux_unregister(), respectively. However, a comment referring to the original names was not updated in the DP helper header file. Hence, correct these names. Signed-off-by: Jon Hunter <jonathanh(a)nvidia.com> --- include/drm/drm_dp_helper.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 523f04c90dea..2e86f642fc33 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -679,9 +679,9 @@ struct drm_dp_aux_msg { * An AUX channel can also be used to transport I2C messages to a sink. A * typical application of that is to access an EDID that's present in the * sink device. The .transfer() function can also be used to execute such - * transactions. The drm_dp_aux_register_i2c_bus() function registers an - * I2C adapter that can be passed to drm_probe_ddc(). Upon removal, drivers - * should call drm_dp_aux_unregister_i2c_bus() to remove the I2C adapter. + * transactions. The drm_dp_aux_register() function registers an I2C + * adapter that can be passed to drm_probe_ddc(). Upon removal, drivers + * should call drm_dp_aux_unregister() to remove the I2C adapter. * The I2C adapter uses long transfers by default; if a partial response is * received, the adapter will drop down to the size given by the partial * response for this transaction only. -- 1.9.1

2 1

Product Ideas & Inventions Wanted
by Davison Inventing 18 May '15

18 May '15

Have an invention or product idea? Davison. Pursue your idea before someone else does: http://www.hypath.co/j/daaii861n7G8dNmvdNOXOyFyvnVn0smOONOnxVjk0jmtd5c We build your idea into a product sample and present it to corporations using our exclusive development process. Want to turn your idea into a product today? Click here: http://www.hypath.co/j/daaii861n7G8dNmvdNOXOyFyvnVn0smOONOnxVjk0jmtd5c "We help people discover the potential in their new product ideas." - Founder and CEO, Mr. Davison Davison products have sold in over 1,000 stores and online retailers: http://www.hypath.co/j/daaii861n7G8dNmvdNOXOyFyvnVn0smOONOnxVjk0jmtd5c Davison's research, development and presentation services are provided for an upfront fee paid by the client and contingent fee (which is a percentage of royalties obtained by the client, if any). New product development is an uncertain endeavor and the use of Davison's services typically does not result in a license agreement, sales on any market or profit to the inventor. Davison does not perform analysis of the feasibility, marketability, patentability or profitability of ideas submitted to it. Davison - 595 Alpha Drive, Pittsburgh, PA 15238 If you wish to stop receiving there messages, please go here: http://www.hypath.co/be7u86FH178eNmvdNOXOyFyvnVn0smOONOnxVjk0jmtea5/been/22

1 0

[PATCH 0/2] drm: bridge/dw_hdmi: add I2C bus adapter support
by Vladimir Zapolskiy 17 May '15

17 May '15

This change adds support of internal HDMI I2C master controller, originally the controller has its own separate driver written from scratch http://patchwork.ozlabs.org/patch/405100 but due to shared register space and interrupt with HDMI driver, it makes sense to merge the code of both drivers. The main purpose of this functionality is to support reading EDID from an HDMI monitor on boards, which don't have an I2C bus connected to DDC pins. To use/test the change "ddc-i2c-bus" DT property must be omitted and pin settings must be updated accordingly, here is an example for iMX6 SabreLite: -----------8<----------- diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi index 0b28a9d..22d4431 100644 --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi @@ -174,7 +174,6 @@ }; &hdmi { - ddc-i2c-bus = <&i2c2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_hdmi>; status = "okay"; }; @@ -193,13 +192,6 @@ }; }; -&i2c2 { - clock-frequency = <100000>; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_i2c2>; - status = "okay"; -}; - &i2c3 { clock-frequency = <100000>; pinctrl-names = "default"; @@ -284,10 +276,10 @@ >; }; - pinctrl_i2c2: i2c2grp { + pinctrl_hdmi: hdmigrp { fsl,pins = < - MX6QDL_PAD_KEY_COL3__I2C2_SCL 0x4001b8b1 - MX6QDL_PAD_KEY_ROW3__I2C2_SDA 0x4001b8b1 + MX6QDL_PAD_KEY_COL3__HDMI_TX_DDC_SCL 0x4001b8b1 + MX6QDL_PAD_KEY_ROW3__HDMI_TX_DDC_SDA 0x4001b8b1 >; }; -----------8<----------- Vladimir Zapolskiy (2): drm: bridge: fix register I2CM_ADDRESS register name drm: bridge: add dw hdmi i2c bus adapter support drivers/gpu/drm/bridge/dw_hdmi.c | 332 ++++++++++++++++++++++++++++++++++++++- drivers/gpu/drm/bridge/dw_hdmi.h | 8 +- 2 files changed, 330 insertions(+), 10 deletions(-) -- 2.1.4

1 3

[pull] drm/msm: fixes for 4.1
by Rob Clark 15 May '15

15 May '15

Sorry for lagging on this a bit (been a bit distracted bring up a new device and other things). Here are the set of fixes for the next 4.1-rc BR, -R The following changes since commit 332545b3016cbff066c17037d32ec8aae8e4cfb5: Merge tag 'drm-intel-fixes-2015-05-08' of git://anongit.freedesktop.org/drm-intel into drm-fixes (2015-05-11 06:06:22 +1000) are available in the git repository at: git://people.freedesktop.org/~robclark/linux msm-fixes-4.1 for you to fetch changes up to 774449ebcb18bae146e2b6f6d012b46e64a095b9: drm/msm: fix locking inconsistencies in gpu->destroy() (2015-05-15 09:28:27 -0400) ---------------------------------------------------------------- Archit Taneja (1): drm: msm: Fix build when legacy fbdev support isn't set Hai Li (3): drm/msm/dsi: Fixup missing *break* statement during cmd rx drm/msm: Attach assigned encoder to eDP and DSI connectors drm/msm/dsi: Simplify the code to get the number of read byte Julia Lawall (1): drm/msm/dp: fix error return code Rob Clark (3): drm/msm/dsi: use pr_err_ratelimited drm/msm: setup vram after component_bind_all() drm/msm: fix locking inconsistencies in gpu->destroy() Stephane Viau (3): drm/msm/dsi: Fix a couple more 64-bit build warnings drm/msm/mdp5: Fix iteration on INTF config array drm/msm: fix unbalanced DRM framebuffer init/destroy Thierry Reding (1): drm/msm: Fix a couple of 64-bit build warnings drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- drivers/gpu/drm/msm/dsi/dsi.c | 10 +++++----- drivers/gpu/drm/msm/dsi/dsi_host.c | 21 ++++++++------------ drivers/gpu/drm/msm/dsi/dsi_manager.c | 6 +++++- drivers/gpu/drm/msm/edp/edp_aux.c | 4 ++-- drivers/gpu/drm/msm/edp/edp_connector.c | 2 ++ drivers/gpu/drm/msm/edp/edp_ctrl.c | 3 ++- drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c | 34 ++++++++++++++++----------------- drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h | 9 ++++++--- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 12 ++++++------ drivers/gpu/drm/msm/msm_drv.c | 24 +++++++++++++---------- drivers/gpu/drm/msm/msm_fb.c | 7 +++---- drivers/gpu/drm/msm/msm_gem.c | 2 +- drivers/gpu/drm/msm/msm_iommu.c | 4 ++-- drivers/gpu/drm/msm/msm_ringbuffer.c | 2 +- 15 files changed, 75 insertions(+), 67 deletions(-)

1 0

[PATCH 0/3] drm/msm/dsi: Add DSI PLL driver under common clock framework
by Hai Li 15 May '15

15 May '15

DSI PLL driver can work with common clock framework and provide source of DSI byte clock and pixel clock, as a clock provider. Hai Li (3): drm/msm/dsi: Add DSI PLL clock driver support drm/msm/dsi: Enable PLL driver in MSM DSI drm/msm/dsi: Separate PHY to another platform device Documentation/devicetree/bindings/drm/msm/dsi.txt | 59 +- drivers/gpu/drm/msm/Kconfig | 7 + drivers/gpu/drm/msm/Makefile | 5 + drivers/gpu/drm/msm/dsi/dsi.c | 43 +- drivers/gpu/drm/msm/dsi/dsi.h | 61 +- drivers/gpu/drm/msm/dsi/dsi_host.c | 83 ++- drivers/gpu/drm/msm/dsi/dsi_manager.c | 79 ++- drivers/gpu/drm/msm/dsi/dsi_phy.c | 311 ++++++++++- drivers/gpu/drm/msm/dsi/pll/dsi_pll.c | 164 ++++++ drivers/gpu/drm/msm/dsi/pll/dsi_pll.h | 89 +++ drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm.c | 652 ++++++++++++++++++++++ 11 files changed, 1448 insertions(+), 105 deletions(-) create mode 100644 drivers/gpu/drm/msm/dsi/pll/dsi_pll.c create mode 100644 drivers/gpu/drm/msm/dsi/pll/dsi_pll.h create mode 100644 drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm.c -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation

1 3

Re: drm/exynos: Add atomic modesetting support
by Tobias Jakobi 15 May '15

15 May '15

Hello, I've just tested 'modetest' with the fix applied, and while the nullptr deference goes away, I now get a division by zero. modetest output: Encoders: id crtc type possible crtcs possible clones 22 0 TMDS 0x00000001 0x00000000 30 29 TMDS 0x00000002 0x00000000 36 0 TMDS 0x00000004 0x00000000 Connectors: id encoder status type size (mm) modes encoders 23 0 disconnected Virtual 0x0 0 22 props: 2 DPMS: flags: enum enums: On=0 Standby=1 Suspend=2 Off=3 value: 0 31 30 connected VGA 0x0 1 30 modes: name refresh (Hz) hdisp hss hse htot vdisp vss vse vtot) 1366x768 0 1366 1414 1446 1526 768 771 776 790 flags: phsync, pvsync; type: preferred, driver props: 1 EDID: flags: immutable blob blobs: value: 2 DPMS: flags: enum enums: On=0 Standby=1 Suspend=2 Off=3 value: 0 37 0 disconnected HDMI-A 0x0 0 36 props: 1 EDID: flags: immutable blob blobs: value: 2 DPMS: flags: enum enums: On=0 Standby=1 Suspend=2 Off=3 value: 0 CRTCs: id fb pos size 21 0 (0,0) (0x0) 0 0 0 0 0 0 0 0 0 flags: ; type: props: 29 40 (0,0) (1366x768) 1366x768 0 1366 1414 1446 1526 768 771 776 790 flags: phsync, pvsync; type: preferred, driver props: 35 0 (0,0) (0x0) 0 0 0 0 0 0 0 0 0 flags: ; type: props: Planes: id crtc fb CRTC x,y x,y gamma size possible crtcs 17 21 0 0,0 0,0 0 0x00000001 formats: XR24 AR24 NV12 props: 5 type: flags: immutable enum enums: Overlay=0 Primary=1 Cursor=2 value: 1 18 0 0 0,0 0,0 0 0x00000001 formats: XR24 AR24 NV12 props: 5 type: flags: immutable enum enums: Overlay=0 Primary=1 Cursor=2 value: 0 19 zpos: flags: immutable range values: 0 4 value: 1 20 0 0 0,0 0,0 0 0x00000001 formats: XR24 AR24 NV12 props: 5 type: flags: immutable enum enums: Overlay=0 Primary=1 Cursor=2 value: 0 19 zpos: flags: immutable range values: 0 4 value: 2 24 29 40 0,0 0,0 0 0x00000002 formats: XR24 AR24 NV12 props: 5 type: flags: immutable enum enums: Overlay=0 Primary=1 Cursor=2 value: 1 25 0 0 0,0 0,0 0 0x00000002 formats: XR24 AR24 NV12 props: 5 type: flags: immutable enum enums: Overlay=0 Primary=1 Cursor=2 value: 0 19 zpos: flags: immutable range values: 0 4 value: 1 26 0 0 0,0 0,0 0 0x00000002 formats: XR24 AR24 NV12 props: 5 type: flags: immutable enum enums: Overlay=0 Primary=1 Cursor=2 value: 0 19 zpos: flags: immutable range values: 0 4 value: 2 27 0 0 0,0 0,0 0 0x00000002 formats: XR24 AR24 NV12 props: 5 type: flags: immutable enum enums: Overlay=0 Primary=1 Cursor=2 value: 0 19 zpos: flags: immutable range values: 0 4 value: 3 28 0 0 0,0 0,0 0 0x00000002 formats: XR24 AR24 NV12 props: 5 type: flags: immutable enum enums: Overlay=0 Primary=1 Cursor=2 value: 0 19 zpos: flags: immutable range values: 0 4 value: 4 32 35 0 0,0 0,0 0 0x00000004 formats: XR24 AR24 NV12 props: 5 type: flags: immutable enum enums: Overlay=0 Primary=1 Cursor=2 value: 1 33 0 0 0,0 0,0 0 0x00000004 formats: XR24 AR24 NV12 props: 5 type: flags: immutable enum enums: Overlay=0 Primary=1 Cursor=2 value: 0 19 zpos: flags: immutable range values: 0 4 value: 1 34 0 0 0,0 0,0 0 0x00000004 formats: XR24 AR24 NV12 props: 5 type: flags: immutable enum enums: Overlay=0 Primary=1 Cursor=2 value: 0 19 zpos: flags: immutable range values: 0 4 value: 2 Frame buffers: id size pitch kernel output: [ 46.808858] Division by zero in kernel. [ 46.808888] CPU: 2 PID: 2611 Comm: lt-modetest Not tainted 4.1.0-rc3-debug+ #2 [ 46.808902] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) [ 46.808912] Backtrace: [ 46.808951] [<c00132b0>] (dump_backtrace) from [<c00134c8>] (show_stack+0x18/0x1c) [ 46.808963] r6:c06f9a08 r5:ffffffff r4:00000000 r3:dc8ba300 [ 46.809008] [<c00134b0>] (show_stack) from [<c04f2138>] (dump_stack+0x88/0xc8) [ 46.809030] [<c04f20b0>] (dump_stack) from [<c0013434>] (__div0+0x1c/0x20) [ 46.809040] r6:00000003 r5:00000000 r4:ed975010 r3:00000000 [ 46.809080] [<c0013418>] (__div0) from [<c020dc14>] (Ldiv0+0x8/0x10) [ 46.809106] [<c02b5e08>] (fimd_commit) from [<c02b6200>] (fimd_poweron.part.9+0xd4/0x19c) [ 46.809116] r9:ee14cc00 r8:c06ffcbc r7:c0748f94 r6:ed975a70 r5:ed975010 r4:00000005 [ 46.809159] [<c02b612c>] (fimd_poweron.part.9) from [<c02b6354>] (fimd_dpms+0x8c/0xb4) [ 46.809170] r6:ee14cc00 r5:00000000 r4:c0748f94 r3:00000001 [ 46.809206] [<c02b62c8>] (fimd_dpms) from [<c02b1bf4>] (exynos_drm_crtc_enable+0x34/0x7c) [ 46.809216] r6:ed3e5340 r5:ed975020 r4:ee14cc00 r3:c02b62c8 [ 46.809260] [<c02b1bc0>] (exynos_drm_crtc_enable) from [<c028c0e8>] (drm_atomic_helper_commit_modeset_enables+0x98/0x1c8) [ 46.809271] r5:ee14cc00 r4:00000001 [ 46.809300] [<c028c050>] (drm_atomic_helper_commit_modeset_enables) from [<c028e6ac>] (drm_atomic_helper_commit+0x124/0x170) [ 46.809311] r8:00000000 r7:ee248000 r6:00000000 r5:ed3e5340 r4:0000000b r3:00000000 [ 46.809354] [<c028e588>] (drm_atomic_helper_commit) from [<c02b2794>] (exynos_atomic_commit+0x14/0x18) [ 46.809364] r8:ee14cc00 r7:00000000 r6:ed86f728 r5:ee248000 r4:ed3e5340 r3:c02b2780 [ 46.809405] [<c02b2780>] (exynos_atomic_commit) from [<c02af928>] (drm_atomic_commit+0x4c/0x6c) [ 46.809425] [<c02af8dc>] (drm_atomic_commit) from [<c028d250>] (drm_atomic_helper_set_config+0x31c/0x428) [ 46.809435] r5:ed3e5340 r4:00000003 [ 46.809469] [<c028cf34>] (drm_atomic_helper_set_config) from [<c029f14c>] (drm_mode_set_config_internal+0x60/0xdc) [ 46.809480] r10:00000000 r9:ee248000 r8:ed86f200 r7:ee14cc00 r6:00000002 r5:00000050 [ 46.809514] r4:ed832c00 [ 46.809540] [<c029f0ec>] (drm_mode_set_config_internal) from [<c0290c2c>] (drm_fb_helper_restore_fbdev_mode_unlocked+0xec/0x140) [ 46.809550] r7:ed86f728 r6:00000002 r5:00000050 r4:00000000 [ 46.809588] [<c0290b40>] (drm_fb_helper_restore_fbdev_mode_unlocked) from [<c02b2658>] (exynos_drm_fbdev_restore_mode+0x28/0x2c) [ 46.809599] r10:ee24814c r9:ed190780 r8:ee248034 r7:ee248000 r6:ee248058 r5:c0748f94 [ 46.809632] r4:ee248000 [ 46.809653] [<c02b2630>] (exynos_drm_fbdev_restore_mode) from [<c02b1068>] (exynos_drm_lastclose+0x10/0x14) [ 46.809671] [<c02b1058>] (exynos_drm_lastclose) from [<c0294564>] (drm_lastclose+0x3c/0x10c) [ 46.809687] [<c0294528>] (drm_lastclose) from [<c0294974>] (drm_release+0x340/0x4e0) [ 46.809697] r6:ee248058 r5:ec6404a8 r4:ec640400 r3:00000000 [ 46.809738] [<c0294634>] (drm_release) from [<c0103ca8>] (__fput+0xa0/0x1e4) [ 46.809748] r10:00000000 r9:00000008 r8:ee11a5b0 r7:edc0d720 r6:eda71410 r5:ee11a5b0 [ 46.809781] r4:ec640d00 [ 46.809803] [<c0103c08>] (__fput) from [<c0103e58>] (____fput+0x10/0x14) [ 46.809813] r10:00000000 r9:ec6ea000 r8:c000fc04 r7:ed8fb9c0 r6:c0718ef8 r5:00000000 [ 46.809847] r4:ed8fbdc4 [ 46.809872] [<c0103e48>] (____fput) from [<c00473b0>] (task_work_run+0xb8/0xfc) [ 46.809895] [<c00472f8>] (task_work_run) from [<c0012ec8>] (do_work_pending+0x88/0xa8) [ 46.809905] r7:00000006 r6:ec6ebfb0 r5:c000fc04 r4:ec6ea000 [ 46.809943] [<c0012e40>] (do_work_pending) from [<c000faa4>] (work_pending+0xc/0x20) [ 46.809953] r6:00000000 r5:00000001 r4:00000003 r3:00000000 [ 46.809992] Division by zero in kernel. [ 46.810010] CPU: 2 PID: 2611 Comm: lt-modetest Not tainted 4.1.0-rc3-debug+ #2 [ 46.810021] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) [ 46.810030] Backtrace: [ 46.810054] [<c00132b0>] (dump_backtrace) from [<c00134c8>] (show_stack+0x18/0x1c) [ 46.810065] r6:c06f9a08 r5:ffffffff r4:00000000 r3:dc8ba300 [ 46.810105] [<c00134b0>] (show_stack) from [<c04f2138>] (dump_stack+0x88/0xc8) [ 46.810126] [<c04f20b0>] (dump_stack) from [<c0013434>] (__div0+0x1c/0x20) [ 46.810136] r6:00000003 r5:00000000 r4:ed975010 r3:00000000 [ 46.810172] [<c0013418>] (__div0) from [<c020dc14>] (Ldiv0+0x8/0x10) [ 46.810193] [<c02b5e08>] (fimd_commit) from [<c02b1c38>] (exynos_drm_crtc_enable+0x78/0x7c) [ 46.810203] r9:ee14cc00 r8:c06ffcbc r7:c0748f94 r6:ed3e5340 r5:ed975020 r4:ee14cc00 [ 46.810248] [<c02b1bc0>] (exynos_drm_crtc_enable) from [<c028c0e8>] (drm_atomic_helper_commit_modeset_enables+0x98/0x1c8) [ 46.810258] r5:ee14cc00 r4:00000001 [ 46.810287] [<c028c050>] (drm_atomic_helper_commit_modeset_enables) from [<c028e6ac>] (drm_atomic_helper_commit+0x124/0x170) [ 46.810297] r8:00000000 r7:ee248000 r6:00000000 r5:ed3e5340 r4:0000000b r3:00000000 [ 46.810339] [<c028e588>] (drm_atomic_helper_commit) from [<c02b2794>] (exynos_atomic_commit+0x14/0x18) [ 46.810350] r8:ee14cc00 r7:00000000 r6:ed86f728 r5:ee248000 r4:ed3e5340 r3:c02b2780 [ 46.810390] [<c02b2780>] (exynos_atomic_commit) from [<c02af928>] (drm_atomic_commit+0x4c/0x6c) [ 46.810409] [<c02af8dc>] (drm_atomic_commit) from [<c028d250>] (drm_atomic_helper_set_config+0x31c/0x428) [ 46.810420] r5:ed3e5340 r4:00000003 [ 46.810452] [<c028cf34>] (drm_atomic_helper_set_config) from [<c029f14c>] (drm_mode_set_config_internal+0x60/0xdc) [ 46.810462] r10:00000000 r9:ee248000 r8:ed86f200 r7:ee14cc00 r6:00000002 r5:00000050 [ 46.810496] r4:ed832c00 [ 46.810521] [<c029f0ec>] (drm_mode_set_config_internal) from [<c0290c2c>] (drm_fb_helper_restore_fbdev_mode_unlocked+0xec/0x140) [ 46.810531] r7:ed86f728 r6:00000002 r5:00000050 r4:00000000 [ 46.810569] [<c0290b40>] (drm_fb_helper_restore_fbdev_mode_unlocked) from [<c02b2658>] (exynos_drm_fbdev_restore_mode+0x28/0x2c) [ 46.810579] r10:ee24814c r9:ed190780 r8:ee248034 r7:ee248000 r6:ee248058 r5:c0748f94 [ 46.810612] r4:ee248000 [ 46.810632] [<c02b2630>] (exynos_drm_fbdev_restore_mode) from [<c02b1068>] (exynos_drm_lastclose+0x10/0x14) [ 46.810650] [<c02b1058>] (exynos_drm_lastclose) from [<c0294564>] (drm_lastclose+0x3c/0x10c) [ 46.810666] [<c0294528>] (drm_lastclose) from [<c0294974>] (drm_release+0x340/0x4e0) [ 46.810676] r6:ee248058 r5:ec6404a8 r4:ec640400 r3:00000000 [ 46.810713] [<c0294634>] (drm_release) from [<c0103ca8>] (__fput+0xa0/0x1e4) [ 46.810723] r10:00000000 r9:00000008 r8:ee11a5b0 r7:edc0d720 r6:eda71410 r5:ee11a5b0 [ 46.810757] r4:ec640d00 [ 46.810778] [<c0103c08>] (__fput) from [<c0103e58>] (____fput+0x10/0x14) [ 46.810788] r10:00000000 r9:ec6ea000 r8:c000fc04 r7:ed8fb9c0 r6:c0718ef8 r5:00000000 [ 46.810821] r4:ed8fbdc4 [ 46.810844] [<c0103e48>] (____fput) from [<c00473b0>] (task_work_run+0xb8/0xfc) [ 46.810866] [<c00472f8>] (task_work_run) from [<c0012ec8>] (do_work_pending+0x88/0xa8) [ 46.810877] r7:00000006 r6:ec6ebfb0 r5:c000fc04 r4:ec6ea000 [ 46.810913] [<c0012e40>] (do_work_pending) from [<c000faa4>] (work_pending+0xc/0x20) [ 46.810923] r6:00000000 r5:00000001 r4:00000003 r3:00000000 I suspect that atomic merely exposed this bug (I suspect it was there all the time). With best wishes, Tobias

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2015