dri-devel June 2015

dri-devel@lists.freedesktop.org

188 participants
1140 discussions

Re: [v4] drm/panel: add s6e3ha2 AMOLED panel driver
by Hyungwon Hwang 26 Feb '16

26 Feb '16

Dear Theirry, Gentle ping. I modified as you reviewed before. Also I wrote the reason for using passing variable by reference for error checking. Can you share your opinion for that, and review this driver? Best regards, Hyungwon Hwang On Fri, 29 May 2015 18:47:02 +0900 Hyungwon Hwang <hyungwon.hwang7(a)gmail.com> wrote: > > This patch adds MIPI-DSI based S6E3HA2 panel driver. This panel has > 1440x2560 resolution in 5.7-inch physical panel. > > Signed-off-by: Donghwa Lee <dh09.lee(a)samsung.com> > Signed-off-by: Hyungwon Hwang <human.hwang(a)samsung.com> > Cc: Inki Dae <inki.dae(a)samsung.com> > --- > As Thierry Reding said in https://patchwork.kernel.org/patch/5714111/, > it can be confusing to check the result of a function call using a > variable which is not explicitly passed to function call. At the same > time, as Andrzej Hajda said, checking the result using the return > value in this driver makes the code too bloated. In the situation > where many simple function calls and the result checking for them are > needed, I thought that passing variable by reference with explicit > variable is the best. > > Changes for v2: > - Fix errata in documentation and source code comments > Changes for v3: > - Remove the term LCD to clarify the sort of this panel > - Rename lcd-en-gpios to panel-en-gpios to clarify the sort of this > panel > - Fix errata in documentation and source code comments > Changes for v4: > - Add support for brightness control > - Adjust the sequence of turning on/off > - Rename variable and properties for clarity > .../devicetree/bindings/panel/samsung,s6e3ha2.txt | 40 + > drivers/gpu/drm/panel/Kconfig | 11 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-s6e3ha2.c | 904 > +++++++++++++++++++++ > 4 files changed, 956 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/panel/samsung,s6e3ha2.txt > create mode 100644 drivers/gpu/drm/panel/panel-s6e3ha2.c > > diff --git > a/Documentation/devicetree/bindings/panel/samsung,s6e3ha2.txt > b/Documentation/devicetree/bindings/panel/samsung,s6e3ha2.txt new > file mode 100644 index 0000000..b8cacc0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/panel/samsung,s6e3ha2.txt > @@ -0,0 +1,40 @@ > +Samsung S6E3HA2 5.7" 1440x2560 AMOLED panel > + > +Required properties: > + - compatible: "samsung,s6e3ha2" > + - reg: virtual channel number assigned to the panel > + - vdd3-supply: core voltage supply > + - vci-supply: voltage supply for analog circuits > + - reset-gpio: GPIO spec for resetting > + - enable-gpio: GPIO spec for enabling > + - te-gpio: GPIO spec for receiving tearing effect synchronization > signal > + - display-timings: resolution, clock, timing information for the > panel [1] > + > +[1]: Documentation/devicetree/bindings/video/display-timing.txt > + > +Example: > + > +panel@0 { > + compatible = "samsung,s6e3ha2"; > + reg = <0>; > + vdd3-supply = <&ldo27_reg>; > + vci-supply = <&ldo28_reg>; > + reset-gpio = <&gpg0 0 GPIO_ACTIVE_LOW>; > + enable-gpio = <&gpf1 5 GPIO_ACTIVE_HIGH>; > + te-gpio = <&gpf1 3 GPIO_ACTIVE_LOW>; > + > + display-timings { > + timing-0 { > + clock-frequency = <0>; > + hactive = <1440>; > + vactive = <2560>; > + hfront-porch = <1>; > + hback-porch = <1>; > + hsync-len = <1>; > + vfront-porch = <1>; > + vback-porch = <15>; > + vsync-len = <1>; > + }; > + }; > +}; > + > diff --git a/drivers/gpu/drm/panel/Kconfig > b/drivers/gpu/drm/panel/Kconfig index 6d64c7b..7833073 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -43,4 +43,15 @@ config DRM_PANEL_SHARP_LQ101R1SX01 > To compile this driver as a module, choose M here: the > module will be called panel-sharp-lq101r1sx01. > > +config DRM_PANEL_S6E3HA2 > + tristate "S6E3HA2 DSI command mode panel" > + depends on OF > + depends on BACKLIGHT_CLASS_DEVICE > + depends on DRM_MIPI_DSI > + select VIDEOMODE_HELPERS > + Say Y here if you want to enable support for Samsung S6E3HA2 > + AMOLED panel module. This panel has a 1440x2560 resolution > and > + uses 32-bit RGB per pixel. It provides a 4 lane MIPI DSI > interface > + to the host. > + > endmenu > diff --git a/drivers/gpu/drm/panel/Makefile > b/drivers/gpu/drm/panel/Makefile index 4b2a043..16ff312 100644 > --- a/drivers/gpu/drm/panel/Makefile > +++ b/drivers/gpu/drm/panel/Makefile > @@ -2,3 +2,4 @@ obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o > obj-$(CONFIG_DRM_PANEL_LD9040) += panel-ld9040.o > obj-$(CONFIG_DRM_PANEL_S6E8AA0) += panel-s6e8aa0.o > obj-$(CONFIG_DRM_PANEL_SHARP_LQ101R1SX01) += > panel-sharp-lq101r1sx01.o +obj-$(CONFIG_DRM_PANEL_S6E3HA2) += > panel-s6e3ha2.o diff --git a/drivers/gpu/drm/panel/panel-s6e3ha2.c > b/drivers/gpu/drm/panel/panel-s6e3ha2.c > new file mode 100644 > index 0000000..8cf5b7e > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-s6e3ha2.c > @@ -0,0 +1,904 @@ > +/* > + * MIPI-DSI based s6e3ha2 AMOLED 5.7 inch panel driver. > + * > + * Copyright (c) 2014 Samsung Electronics Co., Ltd > + * > + * Donghwa Lee <dh09.lee(a)samsung.com> > + * > + * This program is free software; you can redistribute it and/or > modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > +*/ > + > +#include <drm/drmP.h> > +#include <drm/drm_mipi_dsi.h> > +#include <drm/drm_panel.h> > + > +#include <linux/of_gpio.h> > +#include <linux/gpio.h> > + > +#include <linux/gpio/consumer.h> > +#include <linux/regulator/consumer.h> > + > +#include <video/mipi_display.h> > +#include <video/of_videomode.h> > +#include <video/videomode.h> > +#include <linux/backlight.h> > + > +#define MIN_BRIGHTNESS 0 > +#define MAX_BRIGHTNESS 100 > +#define DEFAULT_BRIGHTNESS 80 > + > +#define MIN_GAMMA 2 > +#define MAX_GAMMA 350 > +#define NUM_GAMMA_STEPS 66 > +#define GAMMA_CMD_CNT 35 > +#define VINT_STATUS_MAX 10 > + > +static const u8 AOR_TBL[NUM_GAMMA_STEPS][2] = { > + { 0xe5, 0x90 }, { 0xcc, 0x90 }, { 0xb6, 0x90 }, { 0xa3, > 0x90 }, > + { 0x8e, 0x90 }, { 0x79, 0x90 }, { 0x66, 0x90 }, { 0x57, > 0x90 }, > + { 0x44, 0x90 }, { 0x35, 0x90 }, { 0x25, 0x90 }, { 0x14, > 0x90 }, > + { 0x05, 0x90 }, { 0xeb, 0x80 }, { 0xe0, 0x80 }, { 0xc7, > 0x80 }, > + { 0xa4, 0x80 }, { 0x92, 0x80 }, { 0x7b, 0x80 }, { 0x67, > 0x80 }, > + { 0x43, 0x80 }, { 0x2f, 0x80 }, { 0xfd, 0x70 }, { 0xdf, > 0x70 }, > + { 0xc7, 0x70 }, { 0xa4, 0x70 }, { 0x6f, 0x70 }, { 0x3d, > 0x70 }, > + { 0x14, 0x70 }, { 0xee, 0x60 }, { 0xb2, 0x60 }, { 0x73, > 0x60 }, > + { 0x34, 0x60 }, { 0xf4, 0x50 }, { 0xb5, 0x50 }, { 0x5f, > 0x50 }, > + { 0x0e, 0x50 }, { 0xb4, 0x40 }, { 0x62, 0x40 }, { 0xed, > 0x30 }, > + { 0xed, 0x30 }, { 0xed, 0x30 }, { 0xed, 0x30 }, { 0xed, > 0x30 }, > + { 0xed, 0x30 }, { 0xed, 0x30 }, { 0xed, 0x30 }, { 0xed, > 0x30 }, > + { 0xed, 0x30 }, { 0xed, 0x30 }, { 0xed, 0x30 }, { 0xed, > 0x30 }, > + { 0xed, 0x30 }, { 0xa7, 0x30 }, { 0x26, 0x30 }, { 0xb5, > 0x20 }, > + { 0x26, 0x20 }, { 0x8f, 0x10 }, { 0x03, 0x10 }, { 0x03, > 0x10 }, > + { 0x03, 0x10 }, { 0x03, 0x10 }, { 0x03, 0x10 }, { 0x03, > 0x10 }, > + { 0x03, 0x10 }, { 0x03, 0x10 }, > +}; > + > +static const u8 GAMMA_TBL[NUM_GAMMA_STEPS][GAMMA_CMD_CNT] = { > + { 0x00, 0xb5, 0x00, 0xc7, 0x00, 0xb1, 0x8c, 0x8c, 0x8b, 0x86, > 0x8a, > + 0x8a, 0x86, 0x92, 0x8e, 0x81, 0x97, 0x87, 0x96, 0x9b, 0x98, > 0x9d, > + 0x9d, 0x8f, 0xb5, 0x99, 0x8d, 0x5c, 0x51, 0x66, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb5, 0x00, 0xc6, 0x00, 0xb0, 0x8a, 0x89, 0x8a, 0x83, > 0x88, > + 0x88, 0x88, 0x93, 0x8e, 0x74, 0x8d, 0x7d, 0x9b, 0x9d, 0x9c, > 0x9a, > + 0x9d, 0x90, 0xc7, 0xaa, 0x9e, 0x59, 0x4d, 0x63, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc7, 0x00, 0xb2, 0x89, 0x88, 0x89, 0x85, > 0x89, > + 0x89, 0x88, 0x91, 0x8c, 0x81, 0x92, 0x89, 0x89, 0x96, 0x8f, > 0x93, > + 0x9c, 0x8b, 0xbe, 0xad, 0x9a, 0xce, 0xaa, 0xc2, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc6, 0x00, 0xb2, 0x88, 0x89, 0x88, 0x84, > 0x88, > + 0x88, 0x88, 0x90, 0x8c, 0x82, 0x90, 0x8a, 0x86, 0x93, 0x8c, > 0x91, > + 0x9b, 0x8d, 0xbc, 0xac, 0x99, 0xd3, 0xaf, 0xc7, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb6, 0x00, 0xc4, 0x00, 0xaf, 0x89, 0x88, 0x88, 0x84, > 0x88, > + 0x88, 0x87, 0x8e, 0x8a, 0x83, 0x90, 0x8a, 0x86, 0x93, 0x8c, > 0x91, > + 0x9a, 0x8c, 0xbb, 0xae, 0x98, 0xd6, 0xb2, 0xca, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb7, 0x00, 0xc4, 0x00, 0xb0, 0x89, 0x88, 0x88, 0x84, > 0x88, > + 0x88, 0x87, 0x8e, 0x8a, 0x85, 0x90, 0x88, 0x85, 0x91, 0x8a, > 0x94, > + 0x9b, 0x8e, 0xb5, 0xb0, 0x95, 0xda, 0xb5, 0xcd, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb0, 0x87, 0x88, 0x87, 0x85, > 0x88, > + 0x89, 0x87, 0x8e, 0x8a, 0x86, 0x8f, 0x88, 0x84, 0x91, 0x89, > 0x92, > + 0x99, 0x8d, 0xb5, 0xb0, 0x93, 0xd2, 0xaf, 0xc8, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb0, 0x88, 0x88, 0x87, 0x84, > 0x87, > + 0x88, 0x87, 0x8e, 0x8b, 0x87, 0x91, 0x88, 0x86, 0x90, 0x89, > 0x8f, > + 0x99, 0x8a, 0xb4, 0xb0, 0x93, 0xcd, 0xab, 0xc5, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb0, 0x89, 0x88, 0x88, 0x84, > 0x87, > + 0x88, 0x87, 0x8e, 0x8b, 0x83, 0x8d, 0x84, 0x88, 0x91, 0x8a, > 0x8f, > + 0x98, 0x8a, 0xb4, 0xb0, 0x93, 0xdb, 0xb7, 0xcf, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb0, 0x89, 0x88, 0x88, 0x84, > 0x87, > + 0x88, 0x88, 0x8d, 0x8a, 0x85, 0x8e, 0x85, 0x85, 0x8e, 0x88, > 0x92, > + 0x9a, 0x8c, 0xb2, 0xb0, 0x90, 0xc9, 0xa7, 0xc3, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb0, 0x89, 0x88, 0x88, 0x84, > 0x86, > + 0x87, 0x89, 0x8d, 0x8b, 0x85, 0x8e, 0x85, 0x87, 0x8e, 0x89, > 0x8f, > + 0x98, 0x8a, 0xb2, 0xb0, 0x91, 0xd2, 0xaf, 0xca, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb0, 0x88, 0x87, 0x87, 0x84, > 0x86, > + 0x87, 0x88, 0x8c, 0x8a, 0x86, 0x8f, 0x86, 0x87, 0x8e, 0x89, > 0x8e, > + 0x97, 0x88, 0xb1, 0xb1, 0x90, 0xd2, 0xaf, 0xca, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x83, > 0x85, > + 0x86, 0x88, 0x8c, 0x89, 0x85, 0x8d, 0x85, 0x88, 0x8d, 0x8a, > 0x8f, > + 0x9a, 0x87, 0xb3, 0xb1, 0x90, 0xd7, 0xb3, 0xcd, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x84, > 0x86, > + 0x87, 0x88, 0x8c, 0x8a, 0x85, 0x8c, 0x84, 0x88, 0x8d, 0x8a, > 0x8c, > + 0x96, 0x85, 0xb2, 0xb0, 0x92, 0xcc, 0xaa, 0xc6, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x83, > 0x85, > + 0x86, 0x88, 0x8c, 0x89, 0x84, 0x8b, 0x83, 0x87, 0x8d, 0x8a, > 0x8d, > + 0x96, 0x87, 0xb2, 0xb2, 0x8f, 0xd6, 0xb3, 0xcd, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x83, > 0x84, > + 0x85, 0x88, 0x8c, 0x89, 0x84, 0x8b, 0x84, 0x87, 0x8d, 0x8a, > 0x8b, > + 0x94, 0x84, 0xb3, 0xb1, 0x92, 0xc5, 0xa5, 0xc1, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x83, > 0x84, > + 0x85, 0x88, 0x8c, 0x89, 0x82, 0x89, 0x82, 0x86, 0x8c, 0x88, > 0x8b, > + 0x94, 0x84, 0xb6, 0xb2, 0x91, 0xd0, 0xae, 0xc9, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x83, > 0x84, > + 0x85, 0x87, 0x8b, 0x89, 0x83, 0x8a, 0x83, 0x85, 0x8b, 0x87, > 0x8b, > + 0x95, 0x85, 0xb4, 0xae, 0x8e, 0xbf, 0x9f, 0xbd, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x83, > 0x84, > + 0x84, 0x87, 0x8b, 0x8a, 0x84, 0x8a, 0x83, 0x83, 0x89, 0x85, > 0x8e, > + 0x97, 0x8a, 0xaf, 0xac, 0x8d, 0xb9, 0x9b, 0xb9, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x83, > 0x84, > + 0x84, 0x87, 0x8b, 0x8a, 0x82, 0x88, 0x82, 0x85, 0x8c, 0x88, > 0x8c, > + 0x94, 0x87, 0xb1, 0xaf, 0x8f, 0xc4, 0xa4, 0xc1, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x82, > 0x83, > + 0x85, 0x88, 0x8b, 0x8b, 0x84, 0x88, 0x82, 0x82, 0x89, 0x86, > 0x8c, > + 0x94, 0x84, 0xb1, 0xaf, 0x8e, 0xcf, 0xad, 0xc9, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x84, > 0x84, > + 0x85, 0x87, 0x8b, 0x8a, 0x84, 0x88, 0x82, 0x82, 0x89, 0x86, > 0x8a, > + 0x93, 0x84, 0xb0, 0xae, 0x8e, 0xc9, 0xa8, 0xc5, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x83, > 0x83, > + 0x85, 0x86, 0x8a, 0x8a, 0x84, 0x88, 0x81, 0x84, 0x8a, 0x88, > 0x8a, > + 0x91, 0x84, 0xb1, 0xae, 0x8b, 0xd5, 0xb2, 0xcc, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x83, > 0x83, > + 0x85, 0x86, 0x8a, 0x8a, 0x84, 0x87, 0x81, 0x84, 0x8a, 0x87, > 0x8a, > + 0x91, 0x85, 0xae, 0xac, 0x8a, 0xc3, 0xa3, 0xc0, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x88, 0x86, 0x87, 0x85, > 0x85, > + 0x86, 0x85, 0x88, 0x89, 0x84, 0x89, 0x82, 0x84, 0x87, 0x85, > 0x8b, > + 0x91, 0x88, 0xad, 0xab, 0x8a, 0xb7, 0x9b, 0xb6, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x83, > 0x83, > + 0x85, 0x86, 0x89, 0x8a, 0x84, 0x89, 0x83, 0x83, 0x86, 0x84, > 0x8b, > + 0x90, 0x84, 0xb0, 0xae, 0x8b, 0xce, 0xad, 0xc8, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x83, > 0x83, > + 0x85, 0x87, 0x89, 0x8a, 0x83, 0x87, 0x82, 0x85, 0x88, 0x87, > 0x89, > + 0x8f, 0x84, 0xac, 0xaa, 0x89, 0xb1, 0x98, 0xaf, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x83, > 0x83, > + 0x85, 0x86, 0x88, 0x89, 0x84, 0x88, 0x83, 0x82, 0x85, 0x84, > 0x8c, > + 0x91, 0x86, 0xac, 0xaa, 0x89, 0xc2, 0xa5, 0xbd, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x88, 0x86, 0x87, 0x84, > 0x84, > + 0x85, 0x87, 0x89, 0x8a, 0x83, 0x87, 0x82, 0x85, 0x88, 0x87, > 0x88, > + 0x8b, 0x82, 0xad, 0xaa, 0x8a, 0xc2, 0xa5, 0xbd, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x89, 0x87, 0x87, 0x83, > 0x83, > + 0x85, 0x86, 0x87, 0x89, 0x84, 0x88, 0x83, 0x82, 0x85, 0x84, > 0x8a, > + 0x8e, 0x84, 0xae, 0xac, 0x89, 0xda, 0xb7, 0xd0, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x88, 0x86, 0x87, 0x84, > 0x84, > + 0x85, 0x86, 0x87, 0x89, 0x84, 0x88, 0x83, 0x80, 0x83, 0x82, > 0x8b, > + 0x8e, 0x85, 0xac, 0xaa, 0x89, 0xc8, 0xaa, 0xc1, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x88, 0x86, 0x87, 0x84, > 0x84, > + 0x85, 0x86, 0x87, 0x89, 0x81, 0x85, 0x81, 0x84, 0x86, 0x84, > 0x8c, > + 0x8c, 0x84, 0xa9, 0xa8, 0x87, 0xa3, 0x92, 0xa1, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x88, 0x86, 0x87, 0x84, > 0x84, > + 0x85, 0x86, 0x87, 0x89, 0x84, 0x86, 0x83, 0x80, 0x83, 0x81, > 0x8c, > + 0x8d, 0x84, 0xaa, 0xaa, 0x89, 0xce, 0xaf, 0xc5, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x88, 0x86, 0x87, 0x84, > 0x84, > + 0x85, 0x86, 0x87, 0x89, 0x81, 0x83, 0x80, 0x83, 0x85, 0x85, > 0x8c, > + 0x8c, 0x84, 0xa8, 0xa8, 0x88, 0xb5, 0x9f, 0xb0, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x88, 0x86, 0x87, 0x84, > 0x84, > + 0x86, 0x86, 0x87, 0x88, 0x81, 0x83, 0x80, 0x83, 0x85, 0x85, > 0x8c, > + 0x8b, 0x84, 0xab, 0xa8, 0x86, 0xd4, 0xb4, 0xc9, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x88, 0x86, 0x87, 0x84, > 0x84, > + 0x86, 0x86, 0x87, 0x88, 0x81, 0x83, 0x80, 0x84, 0x84, 0x85, > 0x8b, > + 0x8a, 0x83, 0xa6, 0xa5, 0x84, 0xbb, 0xa4, 0xb3, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x88, 0x86, 0x87, 0x84, > 0x84, > + 0x86, 0x85, 0x86, 0x86, 0x82, 0x85, 0x81, 0x82, 0x83, 0x84, > 0x8e, > + 0x8b, 0x83, 0xa4, 0xa3, 0x8a, 0xa1, 0x93, 0x9d, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x88, 0x86, 0x87, 0x83, > 0x83, > + 0x85, 0x86, 0x87, 0x87, 0x82, 0x85, 0x81, 0x82, 0x82, 0x84, > 0x8e, > + 0x8b, 0x83, 0xa4, 0xa2, 0x86, 0xc1, 0xa9, 0xb7, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x88, 0x86, 0x87, 0x83, > 0x83, > + 0x85, 0x86, 0x87, 0x87, 0x82, 0x85, 0x81, 0x82, 0x82, 0x84, > 0x8d, > + 0x89, 0x82, 0xa2, 0xa1, 0x84, 0xa7, 0x98, 0xa1, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xb8, 0x00, 0xc3, 0x00, 0xb1, 0x88, 0x86, 0x87, 0x83, > 0x83, > + 0x85, 0x86, 0x87, 0x87, 0x82, 0x85, 0x81, 0x83, 0x83, 0x85, > 0x8c, > + 0x87, 0x7f, 0xa2, 0x9d, 0x88, 0x8d, 0x88, 0x8b, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xbb, 0x00, 0xc5, 0x00, 0xb4, 0x87, 0x86, 0x86, 0x84, > 0x83, > + 0x86, 0x87, 0x87, 0x87, 0x80, 0x82, 0x7f, 0x86, 0x86, 0x88, > 0x8a, > + 0x84, 0x7e, 0x9d, 0x9c, 0x82, 0x8d, 0x88, 0x8b, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xbd, 0x00, 0xc7, 0x00, 0xb7, 0x87, 0x85, 0x85, 0x84, > 0x83, > + 0x86, 0x86, 0x86, 0x88, 0x81, 0x83, 0x80, 0x83, 0x84, 0x85, > 0x8a, > + 0x85, 0x7e, 0x9c, 0x9b, 0x85, 0x80, 0x80, 0x80, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xc0, 0x00, 0xca, 0x00, 0xbb, 0x87, 0x86, 0x85, 0x83, > 0x83, > + 0x85, 0x86, 0x86, 0x88, 0x81, 0x83, 0x80, 0x84, 0x85, 0x86, > 0x89, > + 0x83, 0x7d, 0x9c, 0x99, 0x87, 0x7b, 0x7b, 0x7c, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xc4, 0x00, 0xcd, 0x00, 0xbe, 0x87, 0x86, 0x85, 0x83, > 0x83, > + 0x86, 0x85, 0x85, 0x87, 0x81, 0x82, 0x80, 0x82, 0x82, 0x83, > 0x8a, > + 0x85, 0x7f, 0x9f, 0x9b, 0x86, 0xb4, 0xa1, 0xac, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xc7, 0x00, 0xd0, 0x00, 0xc2, 0x87, 0x85, 0x85, 0x83, > 0x82, > + 0x85, 0x85, 0x85, 0x86, 0x82, 0x83, 0x80, 0x82, 0x82, 0x84, > 0x87, > + 0x86, 0x80, 0x9e, 0x9a, 0x87, 0xa7, 0x98, 0xa1, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xca, 0x00, 0xd2, 0x00, 0xc5, 0x87, 0x85, 0x84, 0x82, > 0x82, > + 0x84, 0x85, 0x85, 0x86, 0x81, 0x82, 0x7f, 0x82, 0x82, 0x84, > 0x88, > + 0x86, 0x81, 0x9d, 0x98, 0x86, 0x8d, 0x88, 0x8b, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xce, 0x00, 0xd6, 0x00, 0xca, 0x86, 0x85, 0x84, 0x83, > 0x83, > + 0x85, 0x84, 0x84, 0x85, 0x81, 0x82, 0x80, 0x81, 0x81, 0x82, > 0x89, > + 0x86, 0x81, 0x9c, 0x97, 0x86, 0xa7, 0x98, 0xa1, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xd1, 0x00, 0xd9, 0x00, 0xce, 0x86, 0x84, 0x83, 0x83, > 0x82, > + 0x85, 0x85, 0x85, 0x86, 0x81, 0x83, 0x81, 0x82, 0x82, 0x83, > 0x86, > + 0x83, 0x7f, 0x99, 0x95, 0x86, 0xbb, 0xa4, 0xb3, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xd4, 0x00, 0xdb, 0x00, 0xd1, 0x86, 0x85, 0x83, 0x83, > 0x82, > + 0x85, 0x84, 0x84, 0x85, 0x80, 0x83, 0x82, 0x80, 0x80, 0x81, > 0x87, > + 0x84, 0x81, 0x98, 0x93, 0x85, 0xae, 0x9c, 0xa8, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xd8, 0x00, 0xde, 0x00, 0xd6, 0x86, 0x84, 0x83, 0x81, > 0x81, > + 0x83, 0x85, 0x85, 0x85, 0x82, 0x83, 0x81, 0x81, 0x81, 0x83, > 0x86, > + 0x84, 0x80, 0x98, 0x91, 0x85, 0x7b, 0x7b, 0x7c, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xdc, 0x00, 0xe2, 0x00, 0xda, 0x85, 0x84, 0x83, 0x82, > 0x82, > + 0x84, 0x84, 0x84, 0x85, 0x81, 0x82, 0x82, 0x80, 0x80, 0x81, > 0x83, > + 0x82, 0x7f, 0x99, 0x93, 0x86, 0x94, 0x8b, 0x92, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xdf, 0x00, 0xe5, 0x00, 0xde, 0x85, 0x84, 0x82, 0x82, > 0x82, > + 0x84, 0x83, 0x83, 0x84, 0x81, 0x81, 0x80, 0x83, 0x82, 0x84, > 0x82, > + 0x81, 0x7f, 0x99, 0x92, 0x86, 0x7b, 0x7b, 0x7c, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xe4, 0x00, 0xe9, 0x00, 0xe3, 0x84, 0x83, 0x82, 0x81, > 0x81, > + 0x82, 0x83, 0x83, 0x84, 0x80, 0x81, 0x80, 0x83, 0x83, 0x84, > 0x80, > + 0x81, 0x7c, 0x99, 0x92, 0x87, 0xa1, 0x93, 0x9d, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xe4, 0x00, 0xe9, 0x00, 0xe3, 0x85, 0x84, 0x83, 0x81, > 0x81, > + 0x82, 0x82, 0x82, 0x83, 0x80, 0x81, 0x80, 0x81, 0x80, 0x82, > 0x83, > + 0x82, 0x80, 0x91, 0x8d, 0x83, 0x9a, 0x90, 0x96, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xe4, 0x00, 0xe9, 0x00, 0xe3, 0x84, 0x83, 0x82, 0x81, > 0x81, > + 0x82, 0x83, 0x83, 0x84, 0x80, 0x81, 0x80, 0x81, 0x80, 0x82, > 0x83, > + 0x81, 0x7f, 0x91, 0x8c, 0x82, 0x8d, 0x88, 0x8b, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xe4, 0x00, 0xe9, 0x00, 0xe3, 0x84, 0x83, 0x82, 0x81, > 0x81, > + 0x82, 0x83, 0x83, 0x83, 0x82, 0x82, 0x81, 0x81, 0x80, 0x82, > 0x82, > + 0x82, 0x7f, 0x94, 0x89, 0x84, 0x80, 0x80, 0x80, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xe4, 0x00, 0xe9, 0x00, 0xe3, 0x84, 0x83, 0x82, 0x81, > 0x81, > + 0x82, 0x83, 0x83, 0x83, 0x82, 0x82, 0x81, 0x81, 0x80, 0x82, > 0x83, > + 0x82, 0x7f, 0x91, 0x85, 0x81, 0x80, 0x80, 0x80, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xe4, 0x00, 0xe9, 0x00, 0xe3, 0x84, 0x83, 0x82, 0x81, > 0x81, > + 0x82, 0x83, 0x83, 0x83, 0x80, 0x80, 0x7f, 0x83, 0x82, 0x84, > 0x83, > + 0x82, 0x7f, 0x90, 0x84, 0x81, 0x9a, 0x90, 0x96, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xe4, 0x00, 0xe9, 0x00, 0xe3, 0x84, 0x83, 0x82, 0x80, > 0x80, > + 0x82, 0x83, 0x83, 0x83, 0x80, 0x80, 0x7f, 0x80, 0x80, 0x81, > 0x81, > + 0x82, 0x83, 0x7e, 0x80, 0x7c, 0xa4, 0x97, 0x9f, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xe9, 0x00, 0xec, 0x00, 0xe8, 0x84, 0x83, 0x82, 0x81, > 0x81, > + 0x82, 0x82, 0x82, 0x83, 0x7f, 0x7f, 0x7f, 0x81, 0x80, 0x82, > 0x83, > + 0x83, 0x84, 0x79, 0x7c, 0x79, 0xb1, 0xa0, 0xaa, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xed, 0x00, 0xf0, 0x00, 0xec, 0x83, 0x83, 0x82, 0x80, > 0x80, > + 0x81, 0x82, 0x82, 0x82, 0x7f, 0x7f, 0x7e, 0x81, 0x81, 0x82, > 0x80, > + 0x81, 0x81, 0x84, 0x84, 0x83, 0x80, 0x80, 0x80, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xf1, 0x00, 0xf4, 0x00, 0xf1, 0x83, 0x82, 0x82, 0x80, > 0x80, > + 0x81, 0x82, 0x82, 0x82, 0x80, 0x80, 0x80, 0x80, 0x80, 0x81, > 0x7d, > + 0x7e, 0x7f, 0x84, 0x84, 0x83, 0x80, 0x80, 0x80, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xf6, 0x00, 0xf7, 0x00, 0xf5, 0x82, 0x82, 0x81, 0x80, > 0x80, > + 0x80, 0x82, 0x82, 0x82, 0x80, 0x80, 0x80, 0x7f, 0x7f, 0x7f, > 0x82, > + 0x82, 0x82, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x00, 0xfa, 0x00, 0xfb, 0x00, 0xfa, 0x81, 0x81, 0x81, 0x80, > 0x80, > + 0x80, 0x82, 0x82, 0x82, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, > 0x80, > + 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x01, 0x00, 0x01, 0x00, 0x01, 0x00, 0x80, 0x80, 0x80, 0x80, > 0x80, > + 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, > 0x80, > + 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > + { 0x01, 0x00, 0x01, 0x00, 0x01, 0x00, 0x80, 0x80, 0x80, 0x80, > 0x80, > + 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, > 0x80, > + 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x00, 0x00, > 0x00, > + 0x00, 0x00 }, > +}; > + > +static const unsigned char VINT_TABLE[VINT_STATUS_MAX] = { > + 0x18, 0x19, 0x1A, 0x1B, 0x1C, > + 0x1D, 0x1E, 0x1F, 0x20, 0x21 > +}; > + > +struct s6e3ha2 { > + struct device *dev; > + struct drm_panel panel; > + struct backlight_device *bl_dev; > + > + struct regulator_bulk_data supplies[2]; > + struct gpio_desc *reset_gpio; > + struct gpio_desc *enable_gpio; > + struct videomode vm; > +}; > + > +static inline struct s6e3ha2 *panel_to_s6e3ha2(struct drm_panel > *panel) +{ > + return container_of(panel, struct s6e3ha2, panel); > +} > + > +static void s6e3ha2_dcs_write(struct mipi_dsi_device *dsi, int > *error, > + const u8 cmd, const void *data, size_t len) > +{ > + if (*error < 0) > + return; > + > + *error = mipi_dsi_dcs_write(dsi, cmd, data, len); > + if (*error < 0) > + dev_err(&dsi->dev, "error %d writing dcs seq: %*ph\n", > *error, > + (int)len, > data); +} > + > +#define s6e3ha2_dcs_write_seq_static(dsi, error, cmd, seq...) \ > +({\ > + static const u8 c = cmd;\ > + static const u8 d[] = { seq };\ > + s6e3ha2_dcs_write(dsi, error, c, d, ARRAY_SIZE(d));\ > +}) > + > +static inline void s6e3ha2_test_key_on_f0(struct mipi_dsi_device > *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xf0, 0x5a, 0x5a); > +} > + > +static inline void s6e3ha2_test_key_off_f0(struct mipi_dsi_device > *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xf0, 0xa5, 0xa5); > +} > + > +static inline void s6e3ha2_test_key_on_fc(struct mipi_dsi_device > *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xfc, 0x5a, 0x5a); > +} > + > +static inline void s6e3ha2_test_key_off_fc(struct mipi_dsi_device > *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xfc, 0xa5, 0xa5); > +} > + > +static inline void s6e3ha2_single_dsi_set1(struct mipi_dsi_device > *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xf2, 0x67); > +} > + > +static inline void s6e3ha2_single_dsi_set2(struct mipi_dsi_device > *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xf9, 0x09); > +} > + > +static inline void s6e3ha2_calibration_set1(struct mipi_dsi_device > *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xfd, 0x1c); > +} > + > +static inline void s6e3ha2_calibration_set2(struct mipi_dsi_device > *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xfe, 0x20, 0x39); > +} > + > +static inline void s6e3ha2_calibration_set3(struct mipi_dsi_device > *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xfe, 0xa0); > +} > + > +static inline void s6e3ha2_calibration_set4(struct mipi_dsi_device > *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xfe, 0x20); > +} > + > +static inline void s6e3ha2_calibration_set5(struct mipi_dsi_device > *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, > + 0xce, 0x03, 0x3B, 0x12, 0x62, 0x40, 0x80, > 0xC0, 0x28, > + 0x28, 0x28, 0x28, 0x39, 0xC5); > +} > + > +static inline void s6e3ha2_caps_elvss_set(struct mipi_dsi_device > *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xb6, 0x9c, 0x0a); > +} > + > +static inline void s6e3ha2_acl_off(struct mipi_dsi_device *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0x55, 0x00); > +} > + > +static inline void s6e3ha2_acl_off_opr(struct mipi_dsi_device *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xb5, 0x40); > +} > + > +static inline void s6e3ha2_test_global(struct mipi_dsi_device *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xb0, 0x07); > +} > + > +static inline void s6e3ha2_test(struct mipi_dsi_device *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xb8, 0x19); > +} > + > +static inline void s6e3ha2_touch_hsync_on1(struct mipi_dsi_device > *dsi, > + int > *error) { > + s6e3ha2_dcs_write_seq_static(dsi, error, > + 0xbd, 0x33, 0x11, 0x02, 0x16, 0x02, 0x16); > +} > + > +static inline void s6e3ha2_pentile_control(struct mipi_dsi_device > *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xc0, 0x00, 0x00, > 0xd8, 0xd8); > +} > + > +static inline void s6e3ha2_poc_global(struct mipi_dsi_device *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xb0, 0x20); > +} > + > +static inline void s6e3ha2_poc_setting(struct mipi_dsi_device *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xfe, 0x08); > +} > + > +static inline void s6e3ha2_pcd_set_off(struct mipi_dsi_device *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xcc, 0x40, 0x51); > +} > + > +static inline void s6e3ha2_err_fg_set(struct mipi_dsi_device *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xed, 0x44); > +} > + > +static inline void s6e3ha2_hbm_off(struct mipi_dsi_device *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0x53, 0x00); > +} > + > +static inline void s6e3ha2_te_start_setting(struct mipi_dsi_device > *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, > + 0xb9, 0x10, 0x09, 0xff, 0x00, 0x09); > +} > + > +static inline void s6e3ha2_gamma_update(struct mipi_dsi_device *dsi, > + int > *error) +{ > + s6e3ha2_dcs_write_seq_static(dsi, error, 0xf7, 0x03); > +} > + > +static inline unsigned int s6e3ha2_get_vint_idx(unsigned int brt) > +{ > + return (brt * (VINT_STATUS_MAX - 1)) / MAX_BRIGHTNESS; > +} > + > +static inline void s6e3ha2_set_vint(struct mipi_dsi_device *dsi, int > *error, > + unsigned int > brt) { > + unsigned int vint_idx = s6e3ha2_get_vint_idx(brt); > + unsigned char data[] = { 0x8b, VINT_TABLE[vint_idx] }; > + > + s6e3ha2_dcs_write(dsi, error, 0xf4, data, ARRAY_SIZE(data)); > +} > + > +static inline unsigned int s6e3ha2_get_brightness_idx(unsigned int > brt) +{ > + return (brt * (NUM_GAMMA_STEPS - 1)) / MAX_BRIGHTNESS; > +} > + > +static void s6e3ha2_update_gamma(struct mipi_dsi_device *dsi, int > *error, > + struct backlight_device *bl_dev, unsigned int > brt) +{ > + unsigned int index = s6e3ha2_get_brightness_idx(brt); > + > + s6e3ha2_dcs_write(dsi, error, 0xca, GAMMA_TBL[index], > + > GAMMA_CMD_CNT); > + s6e3ha2_dcs_write(dsi, error, 0xb2, AOR_TBL[index], > + > ARRAY_SIZE(AOR_TBL[0])); > + s6e3ha2_gamma_update(dsi, error); > + bl_dev->props.brightness = brt; > +} > + > +static inline int s6e3ha2_get_brightness(struct backlight_device > *bl_dev) +{ > + return bl_dev->props.brightness; > +} > + > +static int s6e3ha2_set_brightness(struct backlight_device *bl_dev) > +{ > + struct s6e3ha2 *ctx = (struct s6e3ha2 *)bl_get_data(bl_dev); > + struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); > + unsigned int brt = bl_dev->props.brightness; > + int error = 0; > + > + if (brt < MIN_BRIGHTNESS || brt > > bl_dev->props.max_brightness) { > + dev_err(&dsi->dev, "Invalid brightness: %u\n", brt); > + return -EINVAL; > + } > + > + if (bl_dev->props.power > FB_BLANK_NORMAL) { > + dev_err(&dsi->dev, > + "panel must be at least in fb blank normal > state\n"); > + return -EPERM; > + } > + > + s6e3ha2_test_key_on_f0(dsi, &error); > + s6e3ha2_update_gamma(dsi, &error, bl_dev, brt); > + s6e3ha2_set_vint(dsi, &error, brt); > + s6e3ha2_test_key_off_f0(dsi, &error); > + > + return error; > +} > + > +static const struct backlight_ops s6e3ha2_bl_ops = { > + .get_brightness = s6e3ha2_get_brightness, > + .update_status = s6e3ha2_set_brightness, > +}; > + > +static int s6e3ha2_panel_init(struct s6e3ha2 *ctx) > +{ > + struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); > + int error; > + > + error = mipi_dsi_dcs_exit_sleep_mode(dsi); > + if (error < 0) > + return error; > + > + usleep_range(5000, 6000); > + > + s6e3ha2_test_key_on_f0(dsi, &error); > + s6e3ha2_single_dsi_set1(dsi, &error); > + s6e3ha2_single_dsi_set2(dsi, &error); > + > + /* calibration enable */ > + s6e3ha2_test_key_on_fc(dsi, &error); > + s6e3ha2_calibration_set1(dsi, &error); > + s6e3ha2_calibration_set2(dsi, &error); > + s6e3ha2_calibration_set3(dsi, &error); > + s6e3ha2_calibration_set4(dsi, &error); > + s6e3ha2_calibration_set5(dsi, &error); > + > + msleep(120); > + > + /* common setting */ > + error = mipi_dsi_dcs_set_tear_on(dsi, > MIPI_DSI_DCS_TEAR_MODE_VBLANK); > + if (error < 0) > + return error; > + > + s6e3ha2_touch_hsync_on1(dsi, &error); > + s6e3ha2_pentile_control(dsi, &error); > + s6e3ha2_poc_global(dsi, &error); > + s6e3ha2_poc_setting(dsi, &error); > + s6e3ha2_test_key_off_fc(dsi, &error); > + > + /* pcd setting off for TB */ > + s6e3ha2_pcd_set_off(dsi, &error); > + s6e3ha2_err_fg_set(dsi, &error); > + s6e3ha2_te_start_setting(dsi, &error); > + s6e3ha2_test_key_off_f0(dsi, &error); > + > + return error; > +} > + > +static int s6e3ha2_power_off(struct s6e3ha2 *ctx) > +{ > + return regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), > ctx->supplies); > +} > + > +static int s6e3ha2_disable(struct drm_panel *panel) > +{ > + struct s6e3ha2 *ctx = panel_to_s6e3ha2(panel); > + struct mipi_dsi_device *dsi = to_mipi_dsi_device(panel->dev); > + int ret; > + > + ret = mipi_dsi_dcs_enter_sleep_mode(dsi); > + if (ret < 0) > + goto err; > + > + ret = mipi_dsi_dcs_set_display_off(dsi); > + if (ret < 0) > + goto err; > + > + msleep(40); > + > + ctx->bl_dev->props.power = FB_BLANK_NORMAL; > + > + return 0; > +err: > + dev_err(ctx->dev, "failed to power off: %d\n", ret); > + return ret; > +} > + > +static int s6e3ha2_unprepare(struct drm_panel *panel) > +{ > + struct s6e3ha2 *ctx = panel_to_s6e3ha2(panel); > + int ret; > + > + ret = s6e3ha2_power_off(ctx); > + if (ret != 0) { > + dev_err(ctx->dev, "failed to power off: %d\n", ret); > + return ret; > + } > + > + ctx->bl_dev->props.power = FB_BLANK_POWERDOWN; > + > + return 0; > +} > + > +static int s6e3ha2_power_on(struct s6e3ha2 *ctx) > +{ > + int ret; > + > + ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), > ctx->supplies); > + if (ret != 0) > + return ret; > + > + msleep(25); > + > + gpiod_set_value(ctx->enable_gpio, 0); > + usleep_range(5000, 6000); > + gpiod_set_value(ctx->enable_gpio, 1); > + > + gpiod_set_value(ctx->reset_gpio, 1); > + usleep_range(5000, 6000); > + gpiod_set_value(ctx->reset_gpio, 0); > + usleep_range(5000, 6000); > + > + return 0; > +} > +static int s6e3ha2_prepare(struct drm_panel *panel) > +{ > + struct s6e3ha2 *ctx = panel_to_s6e3ha2(panel); > + int ret; > + > + ret = s6e3ha2_power_on(ctx); > + if (ret < 0) { > + dev_err(ctx->dev, "failed to power on: %d\n", ret); > + return ret; > + } > + > + ret = s6e3ha2_panel_init(ctx); > + if (ret < 0) { > + dev_err(ctx->dev, "failed to initialize: %d\n", ret); > + s6e3ha2_power_off(ctx); > + return ret; > + } > + > + ctx->bl_dev->props.power = FB_BLANK_NORMAL; > + > + return 0; > +} > + > +static int s6e3ha2_enable(struct drm_panel *panel) > +{ > + struct s6e3ha2 *ctx = panel_to_s6e3ha2(panel); > + struct mipi_dsi_device *dsi = to_mipi_dsi_device(panel->dev); > + int error; > + > + s6e3ha2_test_key_on_f0(dsi, &error); > + > + /* brightness setting */ > + error = s6e3ha2_set_brightness(ctx->bl_dev); > + if (error < 0) > + goto err; > + > + s6e3ha2_caps_elvss_set(dsi, &error); > + s6e3ha2_acl_off(dsi, &error); > + s6e3ha2_acl_off_opr(dsi, &error); > + s6e3ha2_hbm_off(dsi, &error); > + > + /* elvss temp compensation */ > + s6e3ha2_test_global(dsi, &error); > + s6e3ha2_test(dsi, &error); > + s6e3ha2_test_key_off_f0(dsi, &error); > + > + error = mipi_dsi_dcs_set_display_on(dsi); > + if (error < 0) > + goto err; > + > + ctx->bl_dev->props.power = FB_BLANK_UNBLANK; > + > + return 0; > +err: > + dev_err(ctx->dev, "failed to enable: %d\n", error); > + return error; > +} > + > +static int s6e3ha2_get_modes(struct drm_panel *panel) > +{ > + struct drm_connector *connector = panel->connector; > + struct s6e3ha2 *ctx = panel_to_s6e3ha2(panel); > + struct drm_display_mode *mode; > + > + mode = drm_mode_create(connector->dev); > + if (!mode) { > + DRM_ERROR("failed to create a new display mode\n"); > + return 0; > + } > + > + drm_display_mode_from_videomode(&ctx->vm, mode); > + mode->vrefresh = 60; > + mode->width_mm = 71; > + mode->height_mm = 125; > + connector->display_info.width_mm = mode->width_mm; > + connector->display_info.height_mm = mode->height_mm; > + > + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; > + drm_mode_probed_add(connector, mode); > + > + return 1; > +} > + > +static const struct drm_panel_funcs s6e3ha2_funcs = { > + .disable = s6e3ha2_disable, > + .unprepare = s6e3ha2_unprepare, > + .prepare = s6e3ha2_prepare, > + .enable = s6e3ha2_enable, > + .get_modes = s6e3ha2_get_modes, > +}; > + > +static int s6e3ha2_probe(struct mipi_dsi_device *dsi) > +{ > + struct device *dev = &dsi->dev; > + struct s6e3ha2 *ctx; > + int ret; > + > + ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); > + if (!ctx) > + return -ENOMEM; > + > + mipi_dsi_set_drvdata(dsi, ctx); > + > + ctx->dev = dev; > + > + dsi->lanes = 4; > + dsi->format = MIPI_DSI_FMT_RGB888; > + dsi->mode_flags = MIPI_DSI_CLOCK_NON_CONTINUOUS; > + > + ret = of_get_videomode(dev->of_node, &ctx->vm, 0); > + if (ret < 0) > + return ret; > + > + ctx->supplies[0].supply = "vdd3"; > + ctx->supplies[1].supply = "vci"; > + > + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies), > + ctx->supplies); > + if (ret < 0) { > + dev_err(dev, "failed to get regulators: %d\n", ret); > + return ret; > + } > + > + ctx->reset_gpio = devm_gpiod_get(dev, "reset"); > + if (IS_ERR(ctx->reset_gpio)) { > + dev_err(dev, "cannot get reset-gpio %ld\n", > + PTR_ERR(ctx->reset_gpio)); > + return PTR_ERR(ctx->reset_gpio); > + } > + > + ret = gpiod_direction_output(ctx->reset_gpio, 0); > + if (ret < 0) { > + dev_err(dev, "cannot configure reset-gpio %d\n", ret); > + return ret; > + } > + > + ctx->enable_gpio = devm_gpiod_get(dev, "enable"); > + if (IS_ERR(ctx->enable_gpio)) { > + dev_err(dev, "cannot get enable-gpio %ld\n", > + PTR_ERR(ctx->enable_gpio)); > + return PTR_ERR(ctx->enable_gpio); > + } > + ret = gpiod_direction_output(ctx->enable_gpio, 1); > + > + ctx->bl_dev = backlight_device_register("s6e3ha2", dev, ctx, > + &s6e3ha2_bl_ops, > NULL); > + if (IS_ERR(ctx->bl_dev)) { > + dev_err(dev, "failed to register backlight device\n"); > + return PTR_ERR(ctx->bl_dev); > + } > + > + ctx->bl_dev->props.max_brightness = MAX_BRIGHTNESS; > + ctx->bl_dev->props.brightness = DEFAULT_BRIGHTNESS; > + ctx->bl_dev->props.power = FB_BLANK_POWERDOWN; > + > + drm_panel_init(&ctx->panel); > + ctx->panel.dev = dev; > + ctx->panel.funcs = &s6e3ha2_funcs; > + > + ret = drm_panel_add(&ctx->panel); > + if (ret < 0) > + goto unregister_backlight; > + > + ret = mipi_dsi_attach(dsi); > + if (ret < 0) > + goto remove_panel; > + > + return ret; > + > +remove_panel: > + drm_panel_remove(&ctx->panel); > + > +unregister_backlight: > + backlight_device_unregister(ctx->bl_dev); > + > + return ret; > +} > + > +static int s6e3ha2_remove(struct mipi_dsi_device *dsi) > +{ > + struct s6e3ha2 *ctx = mipi_dsi_get_drvdata(dsi); > + > + mipi_dsi_detach(dsi); > + drm_panel_remove(&ctx->panel); > + backlight_device_unregister(ctx->bl_dev); > + > + return 0; > +} > + > +static const struct of_device_id s6e3ha2_of_match[] = { > + { .compatible = "samsung,s6e3ha2" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, s6e3ha2_of_match); > + > +static struct mipi_dsi_driver s6e3ha2_driver = { > + .probe = s6e3ha2_probe, > + .remove = s6e3ha2_remove, > + .driver = { > + .name = "panel-s6e3ha2", > + .of_match_table = s6e3ha2_of_match, > + }, > +}; > +module_mipi_dsi_driver(s6e3ha2_driver); > + > +MODULE_AUTHOR("Donghwa Lee <dh09.lee(a)samsung.com>"); > +MODULE_AUTHOR("Hyungwon Hwang <human.hwang(a)samsung.com>"); > +MODULE_DESCRIPTION("MIPI-DSI based s6e3ha2 AMOLED Panel Driver"); > +MODULE_LICENSE("GPL v2"); > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel(a)lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel

2 1

[Bug 72087] New: Black levels incorrect during video playback at first
by bugzilla-daemon＠freedesktop.org 26 Feb '16

26 Feb '16

https://bugs.freedesktop.org/show_bug.cgi?id=72087 Priority: medium Bug ID: 72087 Assignee: dri-devel(a)lists.freedesktop.org Summary: Black levels incorrect during video playback at first Severity: normal Classification: Unclassified OS: Linux (All) Reporter: pyrodex(a)gmail.com Hardware: x86-64 (AMD64) Status: NEW Version: XOrg CVS Component: DRM/Radeon Product: DRI Created attachment 89920 --> https://bugs.freedesktop.org/attachment.cgi?id=89920&action=edit Xorg log file I am currently running XBMC nightly and have been working with fritsch via the XBMC forums to diagnose this issue. My current setup is as follows: AMD A6-3500 APU with Radeon(tm) HD Graphics 00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] BeaverCreek [Radeon HD 6530D] 00:01.1 Audio device: Advanced Micro Devices, Inc. [AMD/ATI] BeaverCreek HDMI Audio [Radeon HD 6500D and 6400G-6600G series] Ubuntu 13.10 running 2.13-rc1 with mesa git (10.0~git201311181342.37827~ubuntu13.10.1) My HTPC is connected to a Denon AVR-991 then connected to a Panasonic 50" Plasma. The Denon is setup for 0-255 levels and the HTPC via XBMC is set for 16-235 due to it being "darker" than normal after the leap from windows. Recently I've added an xrandr setting to turner Dither to ON since before the setting it would occasionally switch black levels through video play and with the new setting it ONLY does it on startup of video playback and then corrects itself 2-3 seconds later. I am in the process of taking a video now for reference and will upload it later today. -- You are receiving this mail because: You are the assignee for the bug.

1 8

[Bug 71194] New: Null Pointer dereference in drm_send_blank_event
by bugzilla-daemon＠freedesktop.org 26 Feb '16

26 Feb '16

https://bugs.freedesktop.org/show_bug.cgi?id=71194 Priority: medium Bug ID: 71194 Assignee: dri-devel(a)lists.freedesktop.org Summary: Null Pointer dereference in drm_send_blank_event Severity: normal Classification: Unclassified OS: Linux (All) Reporter: ronaldmik(a)gmail.com Hardware: x86-64 (AMD64) Status: NEW Version: XOrg CVS Component: DRM/Radeon Product: DRI Created attachment 88570 --> https://bugs.freedesktop.org/attachment.cgi?id=88570&action=edit Screenshot of TV with kernel panic affected kernels: 3.11.3, 3.11.6, 3.12-rc7, 3.12-drm-nightly (november 3rd) Reproduce: Start Xorg Start some gl application and see the kernel crashing -- You are receiving this mail because: You are the assignee for the bug.

1 6

[Bug 70409] New: Radeon 7730M discrete GPU use crashes DRI PRIME, appears to be using r600 driver
by bugzilla-daemon＠freedesktop.org 26 Feb '16

26 Feb '16

https://bugs.freedesktop.org/show_bug.cgi?id=70409 Priority: medium Bug ID: 70409 Assignee: dri-devel(a)lists.freedesktop.org Summary: Radeon 7730M discrete GPU use crashes DRI PRIME, appears to be using r600 driver Severity: normal Classification: Unclassified OS: Linux (All) Reporter: calcprogrammer1(a)gmail.com Hardware: x86-64 (AMD64) Status: NEW Version: XOrg CVS Component: DRM/Radeon Product: DRI I am trying to get DRI PRIME working on my AMD dual-GPU laptop. hp dv6z-7000 AMD A10-4600 APU with Radeon HD 7660G (ARUBA) AMD Radeon HD 7730M (VERDE) discrete GPU, 2GB VRAM Ubuntu GNOME 13.10 Custom-built kernel 3.11-rc7 from drm-next-3.13-wip branch (for DPM) I'm using the Ubuntu-provided xorg, mesa, glamor, and libdrm packages. I had to compile my own xserver-xorg-video-ati/radeon packages with glamor acceleration support enabled. With this I can confirm glamor acceleration is being used with the 7660G on r600 and it works well. Now, I want to enable DRI PRIME to use the 7730M with games. adam@Adam-dv6z-7000:~$ xrandr --listproviders Providers: number : 3 Provider 0: id: 0x6c cap: 0xf, Source Output, Sink Output, Source Offload, Sink Offload crtcs: 4 outputs: 3 associated providers: 2 name:radeon Provider 1: id: 0x45 cap: 0xf, Source Output, Sink Output, Source Offload, Sink Offload crtcs: 6 outputs: 0 associated providers: 2 name:radeon Provider 2: id: 0x45 cap: 0xf, Source Output, Sink Output, Source Offload, Sink Offload crtcs: 6 outputs: 0 associated providers: 2 name:radeon adam@Adam-dv6z-7000:~$ xrandr --setprovideroffloadsink 0x45 0x6C adam@Adam-dv6z-7000:~$ DRI_PRIME=1 glxinfo | grep renderer When I run that third line, X crashes immediately with a segfault and automatically restarts GDM to the login screen. I will attach a Xorg log to this bug report after I post it and run the commands. -- You are receiving this mail because: You are the assignee for the bug.

1 14

[Bug 67901] New: Black screen or freeze on radeon driver on AMD 6470M / Intel HD 3000
by bugzilla-daemon＠freedesktop.org 26 Feb '16

26 Feb '16

https://bugs.freedesktop.org/show_bug.cgi?id=67901 Priority: medium Bug ID: 67901 Assignee: dri-devel(a)lists.freedesktop.org Summary: Black screen or freeze on radeon driver on AMD 6470M / Intel HD 3000 Severity: normal Classification: Unclassified OS: All Reporter: xpressrazor(a)gmail.com Hardware: Other Status: NEW Version: unspecified Component: Drivers/DRI/R600 Product: Mesa I have hybrid graphics card setup (AMD 6470M / Intel HD 3000 sandy bridge). I followed http://www.phoronix.com/scan.php?page=news_item&px=MTQyNDE and installed 3.11 kernel on ubuntu 13.10 daily. I also installed mesa 9.2 using xorg-edgers ppa. When I tried to boot using radeon.dpm=1, it had shown a message about missing driver (CAICOS), therefore I replaced all drivers in /lib/firmware/radeon with the one downloaded from http://people.freedesktop.org/~agd5f/radeon_ucode/. I ran "update-initramfs -u", after which the message had gone. This time when I tried to boot using radeon.dpm=1 and it froze. I even tried to turn ON AMD graphics card using vgaswitcheroo (https://help.ubuntu.com/community/HybridGraphics). When I logout, and tried to login it sometimes showed black screen or sometimes froze. I had seen the development page (I don't remember where), and the hybrid graphics card switching was not fully fixed. Is this still the problem? Thanks !! $ lspci | grep VGA 00:02.0 VGA compatible controller: Intel Corporation 2nd Generation Core Processor Family Integrated Graphics Controller (rev 09) 01:00.0 VGA compatible controller: Advanced Micro Devices [AMD] nee ATI Seymour [Radeon HD 6400M/7400M Series] (rev ff) -- You are receiving this mail because: You are the assignee for the bug.

1 2

[Bug 43016] New: DVI is wrongly detected as Display Port
by bugzilla-daemon＠freedesktop.org 26 Feb '16

26 Feb '16

https://bugs.freedesktop.org/show_bug.cgi?id=43016 Bug #: 43016 Summary: DVI is wrongly detected as Display Port Classification: Unclassified Product: Mesa Version: unspecified Platform: x86 (IA32) OS/Version: other Status: NEW Severity: major Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: hysvats(a)gmail.com Created attachment 53622 --> https://bugs.freedesktop.org/attachment.cgi?id=53622 Xorg.log Driver Stack Details: ========================= 1) Kernel- 3.0.0-12-generice-pae 2) Libdrm-2.4.27 3) Mesa-7.12-devel (git-f1a677c) 4) Xorg-server-1.10.1 5) xf86-video-ati-master System Environment: =================== Asic : EG Madison Pro O.S. : Ubuntu-11.10 (32 bit) Processor: AMD Athlon 64 X2 5000+ @ 2.60GHz Chipset : ATI RS690 + SB600 Memory : 2048MB Steps to Reproduce: =================== 1) Connect the DFP With DVI to DVI Cable. 2) Xrandr -q Expected : xrandr output should list DVI observed : xrandr output list DisplayPort Output of xrandr -q Screen 0: minimum 320 x 200, current 1680 x 1050, maximum 8192 x 8192 DisplayPort-0 connected 1680x1050+0+0 (normal left inverted right x axis y axis) 473mm x 296mm 1680x1050 59.9*+ 1280x1024 76.0 75.0 70.0 60.0 1152x864 75.0 1024x768 75.1 70.1 60.0 832x624 74.6 800x600 75.0 60.3 56.2 640x480 72.8 75.0 60.0 720x400 70.1 DisplayPort-1 disconnected (normal left inverted right x axis y axis) VGA-0 disconnected (normal left inverted right x axis y axis) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 8

[Bug 40024] New: Power management does not work on ATI Mobility Radeon 9700
by bugzilla-daemon＠freedesktop.org 26 Feb '16

26 Feb '16

https://bugs.freedesktop.org/show_bug.cgi?id=40024 Summary: Power management does not work on ATI Mobility Radeon 9700 Product: Mesa Version: 7.10 Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r300 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: robegrassi(a)gmail.com Created an attachment (id=50139) --> (https://bugs.freedesktop.org/attachment.cgi?id=50139) output of dmesg Hi, I have an old Asus laptop with a Mobility Radeon 9700 card: $ lspci -nn | grep VGA 01:00.0 VGA compatible controller [0300]: ATI Technologies Inc RV350 [Mobility Radeon 9600 M10] [1002:4e50] I am using Xubuntu 11.04 with KMS and Gallium driver. I would like to set the card to a lower power state because the fan goes often high and the laptop gets hot. The problem is that these three files are missing: cat: /sys/class/drm/card0/device/power_method: No such file or directory cat: /sys/class/drm/card0/device/power_profile: No such file or directory cat: /sys/kernel/debug/dri/0/radeon_pm_info: No such file or directory Does it mean that my card does not support power management? Thank you very much for your help, Roberto -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 9

[Bug 36817] New: RV670 - Kernel fails to enable acceleration when RAM greater than 32-bit limit
by bugzilla-daemon＠freedesktop.org 26 Feb '16

26 Feb '16

https://bugs.freedesktop.org/show_bug.cgi?id=36817 Summary: RV670 - Kernel fails to enable acceleration when RAM greater than 32-bit limit Product: DRI Version: unspecified Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/Radeon AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: reg(a)achart.me.uk I sure hope I'm in the right place... Using a Radeon HD3870 that works fine under Windows (64-bit). After a supposed initial success using a pre-release version of KMS drivers (which may be a red herring), I have been unable to get 3D acceleration on any Ubuntu release from Lucid, unless I use a non-PAE kernel (I have 4GB RAM). My Ubuntu bug ticket (including logs) is here: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-ati/+bug/574884 Another bug that looks similar: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-ati/+bug/657576 A similar looking bug with a similar workaround (which I'll shortly try on mine) on SUSE: http://web.archiveorange.com/archive/v/wmeLDauZzOL6SFQx1uKY -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 2

[Bug 36598] New: [RS880] Slow resume from suspend generates kernel oops
by bugzilla-daemon＠freedesktop.org 26 Feb '16

26 Feb '16

https://bugs.freedesktop.org/show_bug.cgi?id=36598 Summary: [RS880] Slow resume from suspend generates kernel oops Product: DRI Version: XOrg CVS Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/Radeon AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: steve(a)stevemurphy.org Created an attachment (id=46075) --> (https://bugs.freedesktop.org/attachment.cgi?id=46075) dmesg output for boot and suspend, showing the issue around 78.3 I'm forwarding this bug from ubuntu - https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-ati/+bug/764788 Problem] Resume from suspend triggers a kernel oops due to the radeon kms module taking more than 10 seconds to resume [Discussion] When resuming from the suspend state, a popup box is displayed indicating an error has occured and "Your system might become unstable now and might need to be restarted.". In the dmesg output, the following lines are present before the kernel oops, showing that the radeon driver took 11408.919 msecs to resume and the kernel oops is due to resume taking longer than 10 seconds total (11430 msecs). Interesting lines in the dmesg output when the error occurs are below (with kernel.drm=0x04 set, adding a bit of verbosity when the radeon driver is restoring): [ 69.792851] PM: resume of drv:scsi_disk dev:2:0:0:0 complete after 2644.379 msecs [ 70.122093] [drm:output_poll_execute], [CONNECTOR:15:VGA-1] status updated from 2 to 2 [ 70.124058] [drm:radeon_atombios_connected_scratch_regs], DFP1 disconnected [ 70.124062] [drm:output_poll_execute], [CONNECTOR:17:HDMI-A-1] status updated from 2 to 2 [ 71.960104] [drm:radeon_atom_encoder_dpms], encoder dpms 21 to mode 3, devices 00000001, active_devices 00000000 [ 71.960113] [drm:radeon_atom_encoder_dpms], encoder dpms 30 to mode 3, devices 00000008, active_devices 00000000 [ 71.960136] [drm:radeon_compute_pll_avivo], 7187, pll dividers - fb: 130.5 ref: 2, post 13 [ 71.980174] [drm:drm_crtc_helper_set_mode], [ENCODER:12:LVDS-12] set [MODE:30:1366x768] [ 76.950136] [drm:avivo_crtc_load_lut], 0 [ 76.950200] [drm:radeon_atom_encoder_dpms], encoder dpms 31 to mode 0, devices 00000002, active_devices 00000002 [ 76.960133] [drm:radeon_atom_encoder_dpms], encoder dpms 31 to mode 3, devices 00000002, active_devices 00000002 [ 78.303704] [drm:radeon_atom_encoder_dpms], encoder dpms 21 to mode 3, devices 00000001, active_devices 00000000 [ 78.303713] [drm:radeon_atom_encoder_dpms], encoder dpms 30 to mode 3, devices 00000008, active_devices 00000000 [ 78.303734] [drm:avivo_crtc_load_lut], 0 [ 78.303790] [drm:radeon_atom_encoder_dpms], encoder dpms 31 to mode 0, devices 00000002, active_devices 00000002 [ 78.310132] PM: resume of drv:radeon dev:0000:01:05.0 complete after 11408.919 msecs [ 78.310148] PM: resume of drv:drm dev:controlD64 complete after 8513.702 msecs [ 78.310173] PM: resume of devices complete after 11409.422 msecs [ 78.330262] PM: resume devices took 11.430 seconds [ 78.330265] ------------[ cut here ]------------ [ 78.330272] WARNING: at /build/buildd/linux-2.6.38/kernel/power/suspend_test.c:53 suspend_test_finish+0x86/0x90() [ 78.330274] Hardware name: 1215T [ 78.330277] Component: resume devices, time: 11430 Upon investigating further, it looks like portions of the the following workarounds were discovered that allow resume from suspend to work as expected, by avoid the radeon driver: [Workarounds] 1. Add "nomodeset" to the linux command line in grub 2. Use the proprietary FGLRX driver. [System Environment] ASUS 1215T running a fresh install of 11.04 beta or 11.04 beta2. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 2

[Bug 35988] New: Power management not working on ATI M92 LP [Mobility Radeon HD 4300]
by bugzilla-daemon＠freedesktop.org 26 Feb '16

26 Feb '16

https://bugs.freedesktop.org/show_bug.cgi?id=35988 Summary: Power management not working on ATI M92 LP [Mobility Radeon HD 4300] Product: DRI Version: unspecified Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/Radeon AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: s.j.turner(a)uqconnect.net A launchpad user reports "If I deactivate the ATI restricted driver, and then restart my computer, GPU temp is between 70-80 degrees Celsius instead of the usual 40-50, without doing anything, no application running, no effects." lspci -nn | grep VGA 01:00.0 VGA compatible controller [0300]: ATI Technologies Inc M92 LP [Mobility Radeon HD 4300 Series] [1002:9552] MachineType: Hewlett-Packard HP ProBook 4710s This was originally reported on Ubuntu 9.10 "Karmic Koala" with a 2.6.31-based kernel (which of course does not have power management support), but persists on an Ubuntu 11.04 "Natty Narwhal" pre-release with a 2.6.38-based kernel. The problem is that this user reports "I've tried setting the power (management) profile settings and dynpm, but nothing has changed, still running above 70 degrees Celsius." -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 11

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2015