dri-devel June 2015

dri-devel@lists.freedesktop.org

188 participants
1140 discussions

[PATCH 0/2] drm/msm/dsi: Deletion of an unnecessary check
by SF Markus Elfring 27 Jun '15

27 Jun '15

From: Markus Elfring <elfring(a)users.sourceforge.net> Further update suggestions were taken into account after a patch was applied from static source code analysis. Markus Elfring (2): Delete an unnecessary check before the function call "dsi_destroy" One function call less in dsi_init() after error detection drivers/gpu/drm/msm/dsi/dsi.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) -- 2.4.4

1 2

[PATCH 0/2] drm/msm/mdp5: Refactor CTL code
by Hai Li 26 Jun '15

26 Jun '15

Instead of allocating CTL for each CRTC, we start to associate CTL to each display interface, which reflects real HW requirement. It also helps in making use of HW single FLUSH feature to sync between dual DSI pipes. Hai Li (2): drm/msm/mdp5: Allocate CTL for each display interface drm/msm/mdp5: Allocate CTL0/1 for dual DSI single FLUSH drivers/gpu/drm/msm/mdp/mdp5/mdp5_cmd_encoder.c | 12 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 26 +--- drivers/gpu/drm/msm/mdp/mdp5/mdp5_ctl.c | 179 ++++++++++++++++++------ drivers/gpu/drm/msm/mdp/mdp5/mdp5_ctl.h | 13 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c | 18 ++- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 38 +++-- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h | 8 +- 7 files changed, 200 insertions(+), 94 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation

1 2

[PATCH v2] drm/amdgpu: remove unnecessary check before kfree
by Maninder Singh 26 Jun '15

26 Jun '15

kfree(NULL) is safe and this check is probably not required Signed-off-by: Maninder Singh <maninder1.s(a)samsung.com> Reviewed-by: Vaneet Narang <v.narang(a)samsung.com> Reviewed-by: Christian Konig <christian.koenig(a)amd.com> --- v2: Chnged shortlog prefix - gpu/amdgpu drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index fec487d..a85cd08 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -1575,8 +1575,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev) amdgpu_fence_driver_fini(adev); amdgpu_fbdev_fini(adev); r = amdgpu_fini(adev); - if (adev->ip_block_enabled) - kfree(adev->ip_block_enabled); + kfree(adev->ip_block_enabled); adev->ip_block_enabled = NULL; adev->accel_working = false; /* free i2c buses */ -- 1.7.9.5

2 1

[PATCH v2] drm/amdgpu: use kzalloc for allocating one thing
by Maninder Singh 26 Jun '15

26 Jun '15

Use kzalloc rather than kcalloc(1.. for allocating one thing. Signed-off-by: Maninder Singh <maninder1.s(a)samsung.com> Reviewed-by: Vaneet Narang <v.narang(a)samsung.com> Reviewed-by: Christian Konig <christian.koenig(a)amd.com> --- v2: Chnged shortlog prefix - gpu/amdgpu drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index d3706a4..dd3415d 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c @@ -674,7 +674,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_tt *ttm) return 0; if (gtt && gtt->userptr) { - ttm->sg = kcalloc(1, sizeof(struct sg_table), GFP_KERNEL); + ttm->sg = kzalloc(sizeof(struct sg_table), GFP_KERNEL); if (!ttm->sg) return -ENOMEM; -- 1.7.9.5

2 1

[GIT PULL]: dma-buf changes for 4.2
by Sumit Semwal 26 Jun '15

26 Jun '15

Hi Linus, Very small pull request on dma-buf for 4.2 merge window. May I request you to please pull? The following changes since commit 5ebe6afaf0057ac3eaeb98defd5456894b446d22: Linux 4.1-rc2 (2015-05-03 19:22:23 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sumits/dma-buf.git tags/dma-buf-for-4.2 for you to fetch changes up to 5136629dc5a19701746abd7c8ad98ce0b84dda1d: dma-buf: Minor coding style fixes (2015-05-21 11:29:59 +0530) ---------------------------------------------------------------- Minor changes for 4.2 - add ref-counting for kernel modules as exporters - minor code style fixes ---------------------------------------------------------------- Jagan Teki (1): dma-buf: Minor coding style fixes Sumit Semwal (1): dma-buf: add ref counting for module as exporter drivers/dma-buf/dma-buf.c | 19 ++++++++++++++++--- drivers/dma-buf/reservation.c | 9 ++++++--- drivers/dma-buf/seqno-fence.c | 8 +++++++- include/linux/dma-buf.h | 10 ++++++++-- 4 files changed, 37 insertions(+), 9 deletions(-) Thanks and best regards, Sumit.

1 0

[PATCH] drm/msm: mdp4: Fix drm_framebuffer dereference crash
by Archit Taneja 26 Jun '15

26 Jun '15

mdp4_get_frame_format() can dereference a drm_framebuffer when it's NULL. Call it in mdp4_plane_mode_set only when we know fb is non-NULL. Signed-off-by: Archit Taneja <architt(a)codeaurora.org> --- drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c index 0d1dbb7..247a424 100644 --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c @@ -220,13 +220,15 @@ static int mdp4_plane_mode_set(struct drm_plane *plane, uint32_t op_mode = 0; uint32_t phasex_step = MDP4_VG_PHASE_STEP_DEFAULT; uint32_t phasey_step = MDP4_VG_PHASE_STEP_DEFAULT; - enum mdp4_frame_format frame_type = mdp4_get_frame_format(fb); + enum mdp4_frame_format frame_type; if (!(crtc && fb)) { DBG("%s: disabled!", mdp4_plane->name); return 0; } + frame_type = mdp4_get_frame_format(fb); + /* src values are in Q16 fixed point, convert to integer: */ src_x = src_x >> 16; src_y = src_y >> 16; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation

1 0

re: drm: rcar-du: Clarify error message when encoder initialization fails
by Dan Carpenter 26 Jun '15

26 Jun '15

Hello Laurent Pinchart, This is a semi-automatic email about new static checker warnings. The patch 64549cdf85a1: "drm: rcar-du: Clarify error message when encoder initialization fails" from May 26, 2015, leads to the following Smatch complaint: drivers/gpu/drm/rcar-du/rcar_du_kms.c:651 rcar_du_encoders_init_one() error: we previously assumed 'encoder' could be null (see line 613) drivers/gpu/drm/rcar-du/rcar_du_kms.c 612 613 if (encoder) { ^^^^^^^ Check for NULL. 614 /* 615 * If an encoder has been found, get its type based on its 616 * compatible string. 617 */ 618 unsigned int i; 619 620 for (i = 0; i < ARRAY_SIZE(encoders); ++i) { 621 if (of_device_is_compatible(encoder, 622 encoders[i].compatible)) { 623 enc_type = encoders[i].type; 624 break; 625 } 626 } 627 628 if (i == ARRAY_SIZE(encoders)) { 629 dev_warn(rcdu->dev, 630 "unknown encoder type for %s, skipping\n", 631 encoder->full_name); 632 of_node_put(encoder); 633 of_node_put(connector); 634 return -EINVAL; 635 } 636 } else { 637 /* 638 * If no encoder has been found the entity must be the 639 * connector. 640 */ 641 connector = entity; 642 } 643 644 ret = rcar_du_encoder_init(rcdu, enc_type, output, encoder, connector); 645 of_node_put(encoder); ^^^^^^^ Free? 646 of_node_put(connector); 647 648 if (ret && ret != -EPROBE_DEFER) 649 dev_warn(rcdu->dev, 650 "failed to initialize encoder %s (%d), skipping\n", 651 encoder->full_name, ret); ^^^^^^^^^^^^^^^^^^ Unchecked dereference. 652 653 return ret; regards, dan carpenter

1 0

[PATCH] drm/radeon: fix adding all VAs to the freed list on remove
by Christian König 26 Jun '15

26 Jun '15

From: Christian König <christian.koenig(a)amd.com> We only should do so when the BO_VA was actually mapped. Otherwise we get a nice error message on the next CS. Signed-off-by: Christian König <christian.koenig(a)amd.com> --- drivers/gpu/drm/radeon/radeon_vm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c index 3662157..53d57d9 100644 --- a/drivers/gpu/drm/radeon/radeon_vm.c +++ b/drivers/gpu/drm/radeon/radeon_vm.c @@ -1129,7 +1129,8 @@ void radeon_vm_bo_rmv(struct radeon_device *rdev, interval_tree_remove(&bo_va->it, &vm->va); spin_lock(&vm->status_lock); - if (list_empty(&bo_va->vm_status)) { + if (list_empty(&bo_va->vm_status) && + (bo_va->it.start || bo_va->it.last)) { bo_va->bo = radeon_bo_ref(bo_va->bo); list_add(&bo_va->vm_status, &vm->freed); } else { -- 1.9.1

2 1

[PATCH] drm/vblank: WARN_ON nested use of drm_vblank_on/off
by Daniel Vetter 26 Jun '15

26 Jun '15

We should never nest these since in theory kms drivers should know when a pipe is on/off and call the corresponding enable/disable functions for the vblank helper code only once. But for historical reasons (the shared-with-ums version of this code in modeset_pre/post needed to be able to cope with silly userspace that lost track of things) we still have this bit of "robustness" around. Enforce this with a WARN_ON, preparing to eventually rip out this special handling. Cc: Yogesh Mohan Marimuthu <yogesh.mohan.marimuthu(a)intel.com> Cc: Gaurav K Singh <gaurav.k.singh(a)intel.com> Cc: Michel Dänzer <michel.daenzer(a)amd.com> Cc: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- drivers/gpu/drm/drm_irq.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index f9cc68fbd2a3..3819465abe22 100644 --- a/drivers/gpu/drm/drm_irq.c +++ b/drivers/gpu/drm/drm_irq.c @@ -1219,6 +1219,8 @@ void drm_vblank_off(struct drm_device *dev, int crtc) vblank_disable_and_save(dev, crtc); wake_up(&vblank->queue); + WARN_ON(vblank->inmodeset); + /* * Prevent subsequent drm_vblank_get() from re-enabling * the vblank interrupt by bumping the refcount. @@ -1318,6 +1320,8 @@ void drm_vblank_on(struct drm_device *dev, int crtc) return; spin_lock_irqsave(&dev->vbl_lock, irqflags); + WARN_ON(!vblank->inmodeset); + /* Drop our private "prevent drm_vblank_get" refcount */ if (vblank->inmodeset) { atomic_dec(&vblank->refcount); -- 2.1.4

4 5

[PATCH 1/1] gpu/drm: use kzalloc for allocating one thing
by Maninder Singh 26 Jun '15

26 Jun '15

Use kzalloc rather than kcalloc(1.. for allocating one thing. Signed-off-by: Maninder Singh <maninder1.s(a)samsung.com> Reviewed-by: Vaneet Narang <v.narang(a)samsung.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index d3706a4..dd3415d 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c @@ -674,7 +674,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_tt *ttm) return 0; if (gtt && gtt->userptr) { - ttm->sg = kcalloc(1, sizeof(struct sg_table), GFP_KERNEL); + ttm->sg = kzalloc(sizeof(struct sg_table), GFP_KERNEL); if (!ttm->sg) return -ENOMEM; -- 1.7.9.5

3 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2015