dri-devel June 2015

dri-devel@lists.freedesktop.org

188 participants
1140 discussions

[Bug 91016] Piglit regression: shaders/glsl-floating-constant-120
by bugzilla-daemon＠freedesktop.org 22 Jun '15

22 Jun '15

https://bugs.freedesktop.org/show_bug.cgi?id=91016 --- Comment #4 from Mark Janes <mark.a.janes(a)intel.com> --- I was able to reproduce this bug using the old versions of piglit and mesa piglit: 1f39e07d44f7d78557d69c505168afb8eab913c6 mesa: c2a0600 After updating piglit to the latest revision, the test passes. This seems to be the correct behavior, based on Ian's comment. Based on this information, I think it is safe to conclude that this bug does not indicate a regression in mesa. Instead, it is caused by using a fixed version of mesa, but failing to pull in the corresponding piglit fix. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 91015] Piglit regression: spec/ARB_occlusion_query2/api
by bugzilla-daemon＠freedesktop.org 22 Jun '15

22 Jun '15

https://bugs.freedesktop.org/show_bug.cgi?id=91015 --- Comment #5 from Mark Janes <mark.a.janes(a)intel.com> --- I was able to reproduce this bug using the old versions of piglit and mesa piglit: 1f39e07d44f7d78557d69c505168afb8eab913c6 mesa: c2a0600 After updating piglit to the latest revision, the test skips. This seems to be the correct behavior, since g33 does not support occlusion query. Based on this information, it seems safe to conclude that this bug is the result of running an obsolete/buggy version of piglit, and does not indicate a regression in mesa. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 91016] Piglit regression: shaders/glsl-floating-constant-120
by bugzilla-daemon＠freedesktop.org 22 Jun '15

22 Jun '15

https://bugs.freedesktop.org/show_bug.cgi?id=91016 --- Comment #3 from Chad Versace <chad.versace(a)intel.com> --- Brian Wilson said: > It fails in the following Mesa commit: > c2a0600 i965: Don't set NirOptions for stages that will use the vec4 backend [May 2015-ish] Incorrect. The actual Mesa tree that Brian's team is validating is commit c1a0600 plus many patches. I've the pushed the full tree, patches included, to git://github.com/chadversary/mesa refs/tags/chadv/cros-gerrit-262788-patched Also, the Piglit being tested is the following commit plus a few incosequential patches. commit 4069bec62a8a99c44573395ea1597694eeee760f Author: Marek Olšák <marek.olsak(a)amd.com> AuthorDate: Thu Apr 30 14:11:26 2015 +0200 Commit: Marek Olšák <marek.olsak(a)amd.com> CommitDate: Thu Apr 30 22:41:02 2015 +0200 Subject: framework: use the correct executable for GLES parser tests Building that Piglit against recent Mesa, however, produces an error at linktime. The fix requires backporting Piglit commit 845ba0e4dfb9372307f5d3032abdd0860e76731b. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 91015] Piglit regression: spec/ARB_occlusion_query2/api
by bugzilla-daemon＠freedesktop.org 22 Jun '15

22 Jun '15

https://bugs.freedesktop.org/show_bug.cgi?id=91015 --- Comment #4 from Chad Versace <chad.versace(a)intel.com> --- Brian Wilson said: > It fails in the following Mesa commit: > c2a0600 i965: Don't set NirOptions for stages that will use the vec4 backend [May 2015-ish] Incorrect. The actual Mesa tree that Brian's team is validating is commit c1a0600 plus many patches. I've the pushed the full tree, patches included, to git://github.com/chadversary/mesa refs/tags/chadv/cros-gerrit-262788-patched Also, the Piglit being tested is the following commit plus a few incosequential patches. commit 4069bec62a8a99c44573395ea1597694eeee760f Author: Marek Olšák <marek.olsak(a)amd.com> AuthorDate: Thu Apr 30 14:11:26 2015 +0200 Commit: Marek Olšák <marek.olsak(a)amd.com> CommitDate: Thu Apr 30 22:41:02 2015 +0200 Subject: framework: use the correct executable for GLES parser tests Building that Piglit against recent Mesa, however, produces an error at linktime. The fix requires backporting Piglit commit 845ba0e4dfb9372307f5d3032abdd0860e76731b. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 91014] Piglit regression: spec/!OpenGL 1.2/texture-packed-formats
by bugzilla-daemon＠freedesktop.org 22 Jun '15

22 Jun '15

https://bugs.freedesktop.org/show_bug.cgi?id=91014 --- Comment #3 from Chad Versace <chad.versace(a)intel.com> --- Brian Wilson said: > It fails in the following Mesa commit: > c2a0600 i965: Don't set NirOptions for stages that will use the vec4 backend [May 2015-ish] Incorrect. The actual Mesa tree that Brian's team is validating is commit c1a0600 plus many patches. I've the pushed the full tree, patches included, to git://github.com/chadversary/mesa refs/tags/chadv/cros-gerrit-262788-patched Also, the Piglit being tested is the following commit plus a few incosequential patches. commit 4069bec62a8a99c44573395ea1597694eeee760f Author: Marek Olšák <marek.olsak(a)amd.com> AuthorDate: Thu Apr 30 14:11:26 2015 +0200 Commit: Marek Olšák <marek.olsak(a)amd.com> CommitDate: Thu Apr 30 22:41:02 2015 +0200 Subject: framework: use the correct executable for GLES parser tests Building that Piglit against recent Mesa, however, produces an error at linktime. The fix requires backporting Piglit commit 845ba0e4dfb9372307f5d3032abdd0860e76731b. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH libdrm 1/2] xf86drmMode: remove unused valgrind(VG) macros
by Emil Velikov 22 Jun '15

22 Jun '15

Signed-off-by: Emil Velikov <emil.l.velikov(a)gmail.com> --- xf86drmMode.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/xf86drmMode.c b/xf86drmMode.c index 1333da4..30ef6f2 100644 --- a/xf86drmMode.c +++ b/xf86drmMode.c @@ -53,14 +53,6 @@ #include <unistd.h> #include <errno.h> -#ifdef HAVE_VALGRIND -#include <valgrind.h> -#include <memcheck.h> -#define VG(x) x -#else -#define VG(x) -#endif - #define memclear(s) memset(&s, 0, sizeof(s)) #define U642VOID(x) ((void *)(unsigned long)(x)) -- 2.1.3

1 1

[PATCH libdrm] configure: Add flag to disable valgrind support.
by Matt Turner 22 Jun '15

22 Jun '15

--- configure.ac | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 78a0010..dd6c0ab 100644 --- a/configure.ac +++ b/configure.ac @@ -403,7 +403,15 @@ else fi AM_CONDITIONAL([HAVE_MANPAGES_STYLESHEET], [test "x$HAVE_MANPAGES_STYLESHEET" = "xyes"]) -PKG_CHECK_MODULES(VALGRIND, [valgrind], [have_valgrind=yes], [have_valgrind=no]) +AC_ARG_ENABLE(valgrind, + AS_HELP_STRING([--disable-valgrind], + [Disable valgrind support]), + [use_valgrind=$enableval], [use_valgrind=yes]) + +if test "x$use_valgrind" = "xyes"; then + PKG_CHECK_MODULES(VALGRIND, [valgrind], [have_valgrind=yes], [have_valgrind=no]) +fi + if test "x$have_valgrind" = "xyes"; then AC_DEFINE([HAVE_VALGRIND], 1, [Use valgrind intrinsics to suppress false warnings]) fi -- 2.3.6

2 2

[Bug 91015] Piglit regression: spec/ARB_occlusion_query2/api
by bugzilla-daemon＠freedesktop.org 22 Jun '15

22 Jun '15

https://bugs.freedesktop.org/show_bug.cgi?id=91015 --- Comment #3 from Ian Romanick <idr(a)freedesktop.org> --- The following two piglit commits are probably necessary: commit 49e326474d5ed487d04ff6bef1efae376e4a2492 Author: Eduardo Lima Mitev <elima(a)igalia.com> Date: Mon Feb 16 11:10:30 2015 +0100 arb_occlusion_query2: Checks that query obj passed to glBeginQuery matches target From the OpenGL 3.3 spec, section "2.14. ASYNCHRONOUS QUERIES", page 94: "[...] if id is the name of an existing query object whose type does not match target, [...] the error INVALID_OPERATION is generated." Similar wording exists in the OpenGL ES 3.0.0 spec, section "2.13. ASYNCHRONOUS QUERIES", page 82. This patch adds a check for this situation. Reviewed-by: Ian Romanick <ian.d.romanick(a)intel.com> commit 0eff6819639d8c84c98f8fa0bd0b254a69aead60 Author: Eduardo Lima Mitev <elima(a)igalia.com> Date: Sat Feb 14 13:29:52 2015 +0100 arb_occlusion_query2: expect an error when target mismatch in glBeginQuery() From the OpenGL 3.3 spec, section "2.14. ASYNCHRONOUS QUERIES", page 94: "[...] if id is the name of an existing query object whose type does not match target, [...] the error INVALID_OPERATION is generated." Similar wording exists in the OpenGL ES 3.0.0 spec, section "2.13. ASYNCHRONOUS QUERIES", page 82. Hence, trying to call BeginQuery on a query object which has already been bound to a different target should return GL_INVALID_OPERATION. Reviewed-by: Ian Romanick <ian.d.romanick(a)intel.com> -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 91016] Piglit regression: shaders/glsl-floating-constant-120
by bugzilla-daemon＠freedesktop.org 22 Jun '15

22 Jun '15

https://bugs.freedesktop.org/show_bug.cgi?id=91016 --- Comment #2 from Brian Wilson <brian.wilson(a)intel.com> --- This is the version of Piglit that is being used: http://cgit.freedesktop.org/piglit/commit/?id=1f39e07d44f7d78557d69c505168a… Here is the failing test output: 06/13 08:50:32.209 DEBUG| base_utils:0239| [stdout] + Running test [shaders/glsl-floating-constant-120] of expected runtime 0.0 sec: [bin/shader_runner tests/shaders/glsl-floating-constant-120.shader_test -auto] 06/13 08:50:32.310 DEBUG| base_utils:0239| [stderr] Failed to compile FS: 0:5(14): error: syntax error, unexpected NEW_IDENTIFIER, expecting ',' or ';' 06/13 08:50:32.312 DEBUG| base_utils:0239| [stderr] 06/13 08:50:32.314 DEBUG| base_utils:0239| [stdout] PIGLIT: {"result": "fail" } 06/13 08:50:32.315 DEBUG| base_utils:0239| [stdout] + fail :: shaders/glsl-floating-constant-120 -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 91015] Piglit regression: spec/ARB_occlusion_query2/api
by bugzilla-daemon＠freedesktop.org 22 Jun '15

22 Jun '15

https://bugs.freedesktop.org/show_bug.cgi?id=91015 --- Comment #2 from Brian Wilson <brian.wilson(a)intel.com> --- Version of Piglit being used: http://cgit.freedesktop.org/piglit/commit/?id=1f39e07d44f7d78557d69c505168a… Here's the failure output from the test: 06/13 08:38:48.586 DEBUG| base_utils:0239| [stdout] + Running test [spec/ARB_occlusion_query2/api] of expected runtime 0.0 sec: [bin/arb_occlusion_query2-api -fbo -auto] 06/13 08:38:48.691 DEBUG| base_utils:0239| [stderr] GL_CURRENT_QUERY(GL_SAMPLES_PASSED) returned 0 while GL_SAMPLES_PASSED active 06/13 08:38:48.692 DEBUG| base_utils:0239| [stdout] Unexpected GL error: GL_INVALID_OPERATION 0x502 06/13 08:38:48.694 DEBUG| base_utils:0239| [stdout] (Error at ../../../../../../piglit-2014.07.23/tests/spec/arb_occlusion_query2/api.c:119) 06/13 08:38:48.696 DEBUG| base_utils:0239| [stdout] Unexpected GL error: GL_INVALID_OPERATION 0x502 06/13 08:38:48.698 DEBUG| base_utils:0239| [stdout] (Error at ../../../../../../piglit-2014.07.23/tests/spec/arb_occlusion_query2/api.c:128) 06/13 08:38:48.699 DEBUG| base_utils:0239| [stdout] Unexpected GL error: GL_INVALID_OPERATION 0x502 06/13 08:38:48.703 DEBUG| base_utils:0239| [stdout] (Error at ../../../../../../piglit-2014.07.23/tests/spec/arb_occlusion_query2/api.c:63) 06/13 08:38:48.704 DEBUG| base_utils:0239| [stdout] Unexpected GL error: GL_NO_ERROR 0x0 06/13 08:38:48.707 DEBUG| base_utils:0239| [stdout] (Error at ../../../../../../piglit-2014.07.23/tests/spec/arb_occlusion_query2/api.c:66) 06/13 08:38:48.708 DEBUG| base_utils:0239| [stdout] Expected GL error: GL_INVALID_OPERATION 0x502 06/13 08:38:48.709 DEBUG| base_utils:0239| [stdout] PIGLIT: {"result": "fail" } 06/13 08:38:48.711 DEBUG| base_utils:0239| [stdout] + fail :: spec/ARB_occlusion_query2/api -- You are receiving this mail because: You are the assignee for the bug.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2015