dri-devel August 2015

dri-devel@lists.freedesktop.org

178 participants
1142 discussions

[PATCH 0/7] drm/cirrus: convert cirrus to atomic mode-setting
by John Hunter 05 Aug '15

05 Aug '15

From: Zhao Junwang <zhjwpku(a)gmail.com> This patch series aim to convert DRM_CIRRUS to atomic mode-setting. This mostly reference my previous patch series on DRM_BOCHS and Gustavo Padovan;s patch series on drm/exynos. Zhao Junwang (7): drm/cirrus: phase 1 - use the transitional helpers drm/cirrus: phase 2: wire up state reset, duplicate and destroy drm/cirrus: phase 3: atomic updates of planes drm/cirrus: add return 0 to make sure if (bo->pin_count) early_exit drm/cirrus: phase 3: use atomic .set_config helper drm/cirrus: atomic dpms support drm/cirrus: add DRIVER_ATOMIC to .driver_features drivers/gpu/drm/cirrus/cirrus_drv.c | 3 +- drivers/gpu/drm/cirrus/cirrus_drv.h | 3 +- drivers/gpu/drm/cirrus/cirrus_main.c | 5 +- drivers/gpu/drm/cirrus/cirrus_mode.c | 299 ++++++++++++++++++++-------------- drivers/gpu/drm/cirrus/cirrus_ttm.c | 2 + 5 files changed, 187 insertions(+), 125 deletions(-) -- 1.7.10.4

1 7

[PATCH 7/7] drm/cirrus: add DRIVER_ATOMIC to .driver_features
by John Hunter 05 Aug '15

05 Aug '15

From: Zhao Junwang <zhjwpku(a)gmail.com> Since driver is now fully atomic, we should add DRIVER_ATOMIC to .driver_features Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Cc: Gerd Hoffmann <kraxel(a)redhat.com> Cc: Matthew Garrett <mjg59(a)coreos.com> Cc: Dave Airlie <airlied(a)redhat.com> Cc: Zhao Junwang <zhaojunwang(a)pku.edu.cn> Signed-off-by: Zhao Junwang <zhjwpku(a)gmail.com> --- drivers/gpu/drm/cirrus/cirrus_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.c b/drivers/gpu/drm/cirrus/cirrus_drv.c index 80f1cd2..742647b 100644 --- a/drivers/gpu/drm/cirrus/cirrus_drv.c +++ b/drivers/gpu/drm/cirrus/cirrus_drv.c @@ -130,7 +130,7 @@ static const struct file_operations cirrus_driver_fops = { #endif }; static struct drm_driver driver = { - .driver_features = DRIVER_MODESET | DRIVER_GEM, + .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC, .load = cirrus_driver_load, .unload = cirrus_driver_unload, .set_busid = drm_pci_set_busid, -- 1.7.10.4

2 1

[RFC 00/21] drm: fb emulation: Step 3: Remove FB_KMS_HELPER config from drivers
by Archit Taneja 05 Aug '15

05 Aug '15

With the top level DRM_FBDEV_EMULATION option, drivers don't need to select DRM_FB_KMS_HELPER or other FB related config options in the driver. Even if FBDEV_EMULATION isn't select, the stubbed out versions of the drm_fb_helper functions will be called. There are some drivers which still need some FB stuff even after these changes. They are qxl, udl and nouveau. These are handled a bit differently compared to the other patches. Archit Taneja (21): drm/cirrus: Remove FB_KMS_HELPER and FB related config options drm/rockchip: Remove FB_KMS_HELPER and FB related config options drm/armada: Remove FB_KMS_HELPER and FB related config options drm/ast: Remove FB_KMS_HELPER and FB related config options drm/omap: Remove FB_KMS_HELPER and FB related config options drm/exynos: Remove FB_KMS_HELPER and FB related config options drm/gma500: Remove FB_KMS_HELPER and FB related config options drm/mgag200: Remove FB_KMS_HELPER and FB related config options drm/radeon: Remove FB_KMS_HELPER and FB related config options drm/qxl: Remove FB_KMS_HELPER and FB related config options drm/nouveau: Remove FB_KMS_HELPER and FB related config options drm/udl: Remove FB_KMS_HELPER and FB related config options drm/bochs: Remove FB_KMS_HELPER and FB related config options drm/amdgpu: Remove FB_KMS_HELPER and FB related config options drm/virtio: Remove FB_KMS_HELPER and FB related config options drm/fb_cma_helper: Remove FB_KMS_HELPER and FB related config options drm/atmel-hlcdc: Remove FB_KMS_HELPER config option drm/imx: Remove FB_KMS_HELPER config option drm/rcar-du: Remove FB_KMS_HELPER config option drm/shmobile: Remove FB_KMS_HELPER config option drm/tilcdc: Remove FB_KMS_HELPER config option drivers/gpu/drm/Kconfig | 4 ---- drivers/gpu/drm/amd/amdgpu/Kconfig | 4 ---- drivers/gpu/drm/armada/Kconfig | 4 ---- drivers/gpu/drm/ast/Kconfig | 4 ---- drivers/gpu/drm/atmel-hlcdc/Kconfig | 1 - drivers/gpu/drm/bochs/Kconfig | 4 ---- drivers/gpu/drm/cirrus/Kconfig | 4 ---- drivers/gpu/drm/exynos/Kconfig | 6 ------ drivers/gpu/drm/gma500/Kconfig | 4 ---- drivers/gpu/drm/imx/Kconfig | 1 - drivers/gpu/drm/mgag200/Kconfig | 4 ---- drivers/gpu/drm/nouveau/Kconfig | 7 +------ drivers/gpu/drm/omapdrm/Kconfig | 5 ----- drivers/gpu/drm/qxl/Kconfig | 5 ----- drivers/gpu/drm/qxl/qxl_fb.c | 4 ++++ drivers/gpu/drm/radeon/Kconfig | 4 ---- drivers/gpu/drm/rcar-du/Kconfig | 1 - drivers/gpu/drm/rockchip/Kconfig | 4 ---- drivers/gpu/drm/shmobile/Kconfig | 1 - drivers/gpu/drm/tilcdc/Kconfig | 1 - drivers/gpu/drm/udl/Kconfig | 5 ----- drivers/gpu/drm/udl/udl_fb.c | 10 ++++++++++ drivers/gpu/drm/virtio/Kconfig | 4 ---- 23 files changed, 15 insertions(+), 76 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation

5 32

[Bug 65963] screen goes blank, Linux hangs - Radeon 7870, Gallium, Glamor
by bugzilla-daemon＠freedesktop.org 05 Aug '15

05 Aug '15

https://bugs.freedesktop.org/show_bug.cgi?id=65963 --- Comment #31 from Damian Nowak <nowaker(a)geozone.pl> --- Well, so far so good! Haven't had any lock-up today. I'll keep testing. If nothing happens by the end of the week I'll close the ticket. Thanks. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 89699] Regression in 10.5.1 causes flickering/artifacting in a particular video game
by bugzilla-daemon＠freedesktop.org 05 Aug '15

05 Aug '15

https://bugs.freedesktop.org/show_bug.cgi?id=89699 Michel Dänzer <michel(a)daenzer.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #28 from Michel Dänzer <michel(a)daenzer.net> --- Probably fixed by http://cgit.freedesktop.org/mesa/mesa/commit/?id=b0528118dfb1af00e7d08cdb63… . -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 89699] Regression in 10.5.1 causes flickering/artifacting in a particular video game
by bugzilla-daemon＠freedesktop.org 05 Aug '15

05 Aug '15

https://bugs.freedesktop.org/show_bug.cgi?id=89699 --- Comment #27 from andre35822(a)yahoo.com --- I would like to notify everyone that I have tried the latest mesa available from git (both mesa and lib32-mesa from git, via the AUR on Arch Linux) and there seems to be no artificating! I do not know what you guys did but it seemed to have worked. Thank you so much, I appreciate it! I downloaded mesa-demo from official ach repo, I am not aware if that is okay but when I run glxinfo | grep "OpenGL version" it shows OpenGL version string: 3.0 Mesa 11.0.0-devel (git-d6d7515) -- You are receiving this mail because: You are the assignee for the bug.

1 0

i915 driver crashes on T540p if docking station attached
by Theodore Ts'o 04 Aug '15

04 Aug '15

Unfortunately the failure causes a series of recursive faults and I haven't been able to capture the stack trace, but on 4.2-rcX kernels, I can reliably cause the system to crash if my T540p is booted with the docking station attached. It will also crash if I boot the system first, and then insert the laptop into the dockstation. Unfortunately, I can't get a stack trace because there are a huge number of recursive/double faults, and the system dies so quickly that nothing ends up in the log files. If you really need a stack dump I can try to rig something, but modern Laptops don't have serial consoles any more, alas, so it's bit of a pain. I was able to bisect it down to this commit, however: 8c7b5ccb72987: "drm/i915: Use atomic helpers for computing changed flags:" Is there any chance Intel could add a Lenovo Dockstation with a Multistream DP output to part of your test hardware? Unfortunately it seems pretty common that I see regressions with my particular hardware. Maybe there aren't enough people using Thinkpads any more? :-( - Ted P.S. The git bisect log git bisect start # bad: [421d125c06c4be4c5005cb69840206bd09b71dd6] builddeb: sign the modules after splitting out the debuginfo files git bisect bad 421d125c06c4be4c5005cb69840206bd09b71dd6 # good: [b953c0d234bc72e8489d3bf51a276c5c4ec85345] Linux 4.1 git bisect good b953c0d234bc72e8489d3bf51a276c5c4ec85345 # good: [aeaa2122af4e53f3bfd28e8f294557bb95af43fc] drm/i915/skl: Add the INIT power domain to the MISC I/O power well git bisect good aeaa2122af4e53f3bfd28e8f294557bb95af43fc # bad: [4d70f38a760ad2879d2ebd84001c92980180f630] drm/i915/bios: remove a redundant NULL pointer check git bisect bad 4d70f38a760ad2879d2ebd84001c92980180f630 # bad: [27a1b688d9f1fa2abd14bfe6a8729a19fb3b1b25] drm/i915/bxt: Enable WaEnableYV12BugFixInHalfSliceChicken7 for Broxton git bisect bad 27a1b688d9f1fa2abd14bfe6a8729a19fb3b1b25 # good: [4be0731786de10d0e9ae1d159504c83c6b052647] drm/i915: Add crtc states before calling compute_config() git bisect good 4be0731786de10d0e9ae1d159504c83c6b052647 # good: [d5432a9d19b61ba6a2b3d88f3026e0ca60eb57a1] drm/i915: Stage new modeset state straight into atomic state git bisect good d5432a9d19b61ba6a2b3d88f3026e0ca60eb57a1 # bad: [a821fc46bc7bb6d4cf9a5f8d2787fd70231c2c10] drm/i915: Swap atomic state in legacy modeset git bisect bad a821fc46bc7bb6d4cf9a5f8d2787fd70231c2c10 # bad: [8c7b5ccb729870e606321b3703e2c2e698c49a95] drm/i915: Use atomic helpers for computing changed flags git bisect bad 8c7b5ccb729870e606321b3703e2c2e698c49a95 # good: [0f63cca2afdc38877e86acfa9821020f6e2213fd] drm/i915: Update crtc state active flag based on DPMS git bisect good 0f63cca2afdc38877e86acfa9821020f6e2213fd # good: [840bfe953384a134c8639f2964d9b74bfa671e16] drm/atomic: Make mode_fixup() optional for check_modeset() git bisect good 840bfe953384a134c8639f2964d9b74bfa671e16 # first bad commit: [8c7b5ccb729870e606321b3703e2c2e698c49a95] drm/i915: Use atomic helpers for computing changed flags

7 19

[PULL] topic/mst-fixes
by Daniel Vetter 04 Aug '15

04 Aug '15

Hi Linus, Special pull request for mst fixes since most of the patches touch code outside of i915 proper. DRM parts have also been reviewed by Thierry (nvidia) since Dave's enjoying vacations. Cheers, Daniel The following changes since commit 74d33293e467df61de1b1d8b2fbe29e550dec33b: Linux 4.2-rc5 (2015-08-02 18:34:55 -0700) are available in the git repository at: git://anongit.freedesktop.org/drm-intel tags/topic/mst-fixes-2015-08-04 for you to fetch changes up to 6ea76f3cade4734e73e3da842005820558b8b828: drm/atomic-helpers: Make encoder picking more robust (2015-08-04 11:10:41 +0200) ---------------------------------------------------------------- Daniel Vetter (4): drm/atomic-helper: Add an atomice best_encoder callback drm/i915: Fixup dp mst encoder selection drm/dp-mst: Remove debug WARN_ON drm/atomic-helpers: Make encoder picking more robust drivers/gpu/drm/drm_atomic_helper.c | 18 ++++++++++++------ drivers/gpu/drm/drm_dp_mst_topology.c | 1 - drivers/gpu/drm/i915/intel_dp_mst.c | 11 +++++++++++ include/drm/drm_crtc_helper.h | 3 +++ 4 files changed, 26 insertions(+), 7 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

1 0

[PATCH 0/2] drm/fb-helper: Silence defined but not used warning
by Geert Uytterhoeven 04 Aug '15

04 Aug '15

From: Geert Uytterhoeven <geert+renesas(a)glider.be> Hi, If CONFIG_MAGIC_SYSRQ is not set: drivers/gpu/drm/drm_fb_helper.c:390:13: warning: 'drm_fb_helper_force_kernel_mode' defined but not used [-Wunused-function] static bool drm_fb_helper_force_kernel_mode(void) ^ As just silencing this warning would require moving two functions (one of them having obsolete documentation) inside the #ifdef, I fixed the documentation first. This patch series is against next-20150803. Geert Uytterhoeven (2): drm/fb-helper: Clarify drm_fb_helper_restore_fbdev_mode*() drm/fb-helper: Move drm_fb_helper_force_kernel_mode() inside #ifdef drivers/gpu/drm/drm_fb_helper.c | 71 ++++++++++++++++------------------------- 1 file changed, 28 insertions(+), 43 deletions(-) -- 1.9.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

2 3

[PATCH 1/4] drm/atomic-helper: Add an atomice best_encoder callback
by Daniel Vetter 04 Aug '15

04 Aug '15

With legacy helpers all the routing was already set up when calling best_encoder and so could be inspected. But with atomic it's staged, hence we need a new atomic compliant callback for drivers which need to inspect the requested state and can't just decided the best encoder statically. This is needed to fix up i915 dp mst where we need to pick the right encoder depending upon the requested CRTC for the connector. v2: Don't forget to amend the kerneldoc Cc: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: Linus Torvalds <torvalds(a)linux-foundation.org> Cc: Theodore Ts'o <tytso(a)mit.edu> Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- drivers/gpu/drm/drm_atomic_helper.c | 7 ++++++- include/drm/drm_crtc_helper.h | 3 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index aac212297b49..8694ca9beee3 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -196,7 +196,12 @@ update_connector_routing(struct drm_atomic_state *state, int conn_idx) } funcs = connector->helper_private; - new_encoder = funcs->best_encoder(connector); + + if (funcs->atomic_best_encoder) + new_encoder = funcs->atomic_best_encoder(connector, + connector_state); + else + new_encoder = funcs->best_encoder(connector); if (!new_encoder) { DRM_DEBUG_ATOMIC("No suitable encoder found for [CONNECTOR:%d:%s]\n", diff --git a/include/drm/drm_crtc_helper.h b/include/drm/drm_crtc_helper.h index c8fc187061de..918aa68b5199 100644 --- a/include/drm/drm_crtc_helper.h +++ b/include/drm/drm_crtc_helper.h @@ -168,6 +168,7 @@ struct drm_encoder_helper_funcs { * @get_modes: get mode list for this connector * @mode_valid: is this mode valid on the given connector? (optional) * @best_encoder: return the preferred encoder for this connector + * @atomic_best_encoder: atomic version of @best_encoder * * The helper operations are called by the mid-layer CRTC helper. */ @@ -176,6 +177,8 @@ struct drm_connector_helper_funcs { enum drm_mode_status (*mode_valid)(struct drm_connector *connector, struct drm_display_mode *mode); struct drm_encoder *(*best_encoder)(struct drm_connector *connector); + struct drm_encoder *(*atomic_best_encoder)(struct drm_connector *connector, + struct drm_connector_state *connector_state); }; extern void drm_helper_disable_unused_functions(struct drm_device *dev); -- 2.5.0

4 8

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel August 2015