dri-devel January 2016

dri-devel@lists.freedesktop.org

194 participants
1200 discussions

[Bug 91136] [tahiti xt] portal2 glitchy without R600_DEBUG=switch_on_eop
by bugzilla-daemon＠freedesktop.org 21 Jul '16

21 Jul '16

https://bugs.freedesktop.org/show_bug.cgi?id=91136 Bug ID: 91136 Summary: [tahiti xt] portal2 glitchy without R600_DEBUG=switch_on_eop Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: sylvain.bertrand(a)gmail.com QA Contact: dri-devel(a)lists.freedesktop.org play "the reunion"/"propulsion flings" Without R600_DEBUG=switch_on_eop, glitches are unbearable. With R600_DEBUG=switch_on_eop, nearly 0 glitch. latest linux from agd5f linux 4.1 fixes. drm/llvm/mesa/xserver/xf86-video-ati straight from git (yesterday) -- You are receiving this mail because: You are the assignee for the bug.

1 8

[Bug 86720] Europa Universalis 4 freezing during game start (10.3.3)
by bugzilla-daemon＠freedesktop.org 20 Jul '16

20 Jul '16

https://bugs.freedesktop.org/show_bug.cgi?id=86720 Bug ID: 86720 Summary: Europa Universalis 4 freezing during game start (10.3.3) Product: Mesa Version: 10.3 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 Assignee: dri-devel(a)lists.freedesktop.org Reporter: buchno(a)riseup.net Created attachment 110028 --> https://bugs.freedesktop.org/attachment.cgi?id=110028&action=edit 134220 line strace from loading game to freeze to force quit. Europa Universalis 4 stops responding after loading from pressing "Play" in the nation select screen. Not present in Mesa 10.3.2, the problem was introduced in 10.3.3. Related to the radeon driver, as the Intel driver works without issue. OS: Arch Linux GPU: Radeon HD 6950 GPU Driver: xf86-video-ati 7.5.0 CPU: Intel i5-2500K -- You are receiving this mail because: You are the assignee for the bug.

1 40

Re: [PATCH 1/1] GPU-DRM-nouveau: Deletion of unnecessary checks before two function calls
by SF Markus Elfring 20 Jul '16

20 Jul '16

>> If you are convinced that dropping the null tests is a good idea, then you >> can submit the patch that makes the change to the relevant maintainers and >> mailing lists. Would you like to integrate the following proposal into your source code repository? Regards, Markus >From 29e61d5ccc44cd5e5961acff61b6938e0705044d Mon Sep 17 00:00:00 2001 From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Wed, 22 Oct 2014 15:45:22 +0200 Subject: [PATCH] GPU-DRM-nouveau: Deletion of unnecessary checks before two function calls A semantic patch approach was proposed with the subject "[PATCH with Coccinelle?] Deletion of unnecessary checks before specific function calls" on 2014-03-05. https://lkml.org/lkml/2014/3/5/344 http://article.gmane.org/gmane.comp.version-control.coccinelle/3513/ This patch pattern application was repeated with the help of the software "Coccinelle 1.0.0-rc22" on the source files for Linux 3.17.1. An extract of the automatically generated update suggestions is shown here. It was determined that the affected source code places call functions which perform input parameter validation already. It is therefore not needed that a similar safety check is repeated at the call site. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- drivers/gpu/drm/nouveau/core/core/handle.c | 3 +-- drivers/gpu/drm/nouveau/nouveau_drm.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/core/core/handle.c b/drivers/gpu/drm/nouveau/core/core/handle.c index a490b80..75d0c2c 100644 --- a/drivers/gpu/drm/nouveau/core/core/handle.c +++ b/drivers/gpu/drm/nouveau/core/core/handle.c @@ -219,8 +219,7 @@ nouveau_handle_get_cinst(struct nouveau_object *engctx, u32 cinst) void nouveau_handle_put(struct nouveau_handle *handle) { - if (handle) - nouveau_namedb_put(handle); + nouveau_namedb_put(handle); } int diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index 5723807..5c29079 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -512,8 +512,7 @@ nouveau_drm_unload(struct drm_device *dev) nouveau_vga_fini(drm); nvif_device_fini(&drm->device); - if (drm->hdmi_device) - pci_dev_put(drm->hdmi_device); + pci_dev_put(drm->hdmi_device); nouveau_cli_destroy(&drm->client); return 0; } -- 2.1.2

1 2

[PATCH] GPU-DRM: Delete an unnecessary check before drm_property_unreference_blob()
by SF Markus Elfring 20 Jul '16

20 Jul '16

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Sun, 5 Jul 2015 21:55:10 +0200 The drm_property_unreference_blob() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- drivers/gpu/drm/drm_crtc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 2d57fc5..6e4c8b0 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -4469,9 +4469,7 @@ static int drm_property_replace_global_blob(struct drm_device *dev, goto err_created; } - if (old_blob) - drm_property_unreference_blob(old_blob); - + drm_property_unreference_blob(old_blob); *replace = new_blob; return 0; -- 2.4.5

4 6

[PATCH] GPU-DRM-TTM: Delete an unnecessary check before the function call "ttm_tt_destroy"
by SF Markus Elfring 19 Jul '16

19 Jul '16

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Mon, 16 Nov 2015 15:40:58 +0100 The ttm_tt_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- drivers/gpu/drm/ttm/ttm_bo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 745e996..d6736e6 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -147,8 +147,7 @@ static void ttm_bo_release_list(struct kref *list_kref) BUG_ON(!list_empty(&bo->lru)); BUG_ON(!list_empty(&bo->ddestroy)); - if (bo->ttm) - ttm_tt_destroy(bo->ttm); + ttm_tt_destroy(bo->ttm); atomic_dec(&bo->glob->bo_count); if (bo->resv == &bo->ttm_resv) reservation_object_fini(&bo->ttm_resv); -- 2.6.2

3 7

[PATCH] GPU-DRM-Tegra: Delete an unnecessary check before the function call "vunmap"
by SF Markus Elfring 16 Jul '16

16 Jul '16

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Thu, 5 Feb 2015 10:12:51 +0100 The vunmap() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- drivers/gpu/drm/tegra/fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index e9c715d..803598e 100644 --- a/drivers/gpu/drm/tegra/fb.c +++ b/drivers/gpu/drm/tegra/fb.c @@ -66,7 +66,7 @@ static void tegra_fb_destroy(struct drm_framebuffer *framebuffer) struct tegra_bo *bo = fb->planes[i]; if (bo) { - if (bo->pages && bo->vaddr) + if (bo->pages) vunmap(bo->vaddr); drm_gem_object_unreference_unlocked(&bo->gem); -- 2.2.2

2 3

[PATCH] GPU-DRM-vc4: Delete unnecessary checks before two function calls
by SF Markus Elfring 15 Jul '16

15 Jul '16

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Fri, 6 Nov 2015 16:04:22 +0100 The following functions test whether their argument is NULL and then return immediately. * drm_fbdev_cma_hotplug_event * drm_fbdev_cma_restore_mode Thus the tests around their calls are not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- drivers/gpu/drm/vc4/vc4_drv.c | 3 +-- drivers/gpu/drm/vc4/vc4_kms.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 6e73060..df348c0 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.c +++ b/drivers/gpu/drm/vc4/vc4_drv.c @@ -54,8 +54,7 @@ static void vc4_lastclose(struct drm_device *dev) { struct vc4_dev *vc4 = to_vc4_dev(dev); - if (vc4->fbdev) - drm_fbdev_cma_restore_mode(vc4->fbdev); + drm_fbdev_cma_restore_mode(vc4->fbdev); } static const struct file_operations vc4_drm_fops = { diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c index 2e5597d..1778203 100644 --- a/drivers/gpu/drm/vc4/vc4_kms.c +++ b/drivers/gpu/drm/vc4/vc4_kms.c @@ -25,8 +25,7 @@ static void vc4_output_poll_changed(struct drm_device *dev) { struct vc4_dev *vc4 = to_vc4_dev(dev); - if (vc4->fbdev) - drm_fbdev_cma_hotplug_event(vc4->fbdev); + drm_fbdev_cma_hotplug_event(vc4->fbdev); } static const struct drm_mode_config_funcs vc4_mode_funcs = { -- 2.6.2

1 1

[Bug 92309] Box drawn around cursor in multiple 3D games
by bugzilla-daemon＠freedesktop.org 15 Jul '16

15 Jul '16

https://bugs.freedesktop.org/show_bug.cgi?id=92309 Bug ID: 92309 Summary: Box drawn around cursor in multiple 3D games Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: acutiator(a)outlook.com QA Contact: dri-devel(a)lists.freedesktop.org When playing Legend of Grimrock or Natural Selection 2 on the radeonsi drivers on Cape Verde there is a box drawn around the cursor. This does not occur in other games such as Risk of Rain, Starbound, and Left 4 Dead 2. This is when running Mesa 11.1.0-devel on Fedora 22, git 9932142. -- You are receiving this mail because: You are the assignee for the bug.

1 22

[Bug 62441] New: Bastion game runs slowly
by bugzilla-daemon＠freedesktop.org 15 Jul '16

15 Jul '16

https://bugs.freedesktop.org/show_bug.cgi?id=62441 Priority: medium Bug ID: 62441 Assignee: dri-devel(a)lists.freedesktop.org Summary: Bastion game runs slowly Severity: normal Classification: Unclassified OS: All Reporter: lvella(a)gmail.com Hardware: Other Status: NEW Version: unspecified Component: Drivers/DRI/R600 Product: Mesa Game Bastion (from Humble Indie Bundle V and Steam) runs very slowly on most parts, specially when the scene is full of special effects (rain, etc), rendering it unplayable. The only part where it runs at normal speed is at main menu and the very beginning of the game. -- You are receiving this mail because: You are the assignee for the bug.

1 8

[Bug 62967] New: Game Dungeon Defenders crash my whole system.
by bugzilla-daemon＠freedesktop.org 15 Jul '16

15 Jul '16

https://bugs.freedesktop.org/show_bug.cgi?id=62967 Priority: medium Bug ID: 62967 Assignee: dri-devel(a)lists.freedesktop.org Summary: Game Dungeon Defenders crash my whole system. Severity: normal Classification: Unclassified OS: All Reporter: lvella(a)gmail.com Hardware: x86-64 (AMD64) Status: NEW Version: XOrg CVS Component: DRM/Radeon Product: DRI Created attachment 77255 --> https://bugs.freedesktop.org/attachment.cgi?id=77255&action=edit glxinfo output When I run Dungeon Defenders, the game window pops up and the first intro animation runs very slowly (a red logo building in front of a white backgroud), then at the second animation, a seeming magic circle with purple fire, my computer halts and freezes completely, and I have to reboot. -- You are receiving this mail because: You are the assignee for the bug.

1 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2016