dri-devel January 2016

dri-devel@lists.freedesktop.org

194 participants
1200 discussions

[PATCH 0/8] drm/bochs: convert bochs to atomic mode-setting
by John Hunter 07 Mar '16

07 Mar '16

From: Zhao Junwang <zhjwpku(a)gmail.com> This patch series aim to convert DRM_BOCHS to atomic mode-setting. I did this mostly reference Gustavo Padovan's patch series on drm/exynos conversion. Zhao Junwang (8): drm/bochs: phase 1 - use the transitional helpers drm/bochs: phase 2: wire up state reset(), duplicate() and destroy drm/bochs: stop looking at legacy state drm/bochs: phase 3: for plane updates: switch to atomic helper internally drm/bochs: phase 3: use atomic .set_config helper drm/bochs: phase 3: provide a custom ->atomic_commit implementation drm/bochs: phase 3: switch to drm_atomic_helper_page_flip drm/bochs: atomic dpms support drivers/gpu/drm/bochs/bochs.h | 2 + drivers/gpu/drm/bochs/bochs_drv.c | 2 +- drivers/gpu/drm/bochs/bochs_kms.c | 221 +++++++++++++++++++++++-------------- drivers/gpu/drm/bochs/bochs_mm.c | 9 ++ 4 files changed, 148 insertions(+), 86 deletions(-) -- 1.7.10.4

6 29

[PATCH 1/4] drm: bridge/dw-hdmi: cache edid data
by Philipp Zabel 02 Mar '16

02 Mar '16

From: Sascha Hauer <s.hauer(a)pengutronix.de> Instead of rereading the edid data each time userspace asks for them, read them once and cache them in the previously unused edid field in struct dw_hdmi. When the connector is disconnected, drop the cached edid data. Signed-off-by: Sascha Hauer <s.hauer(a)pengutronix.de> Signed-off-by: Philipp Zabel <p.zabel(a)pengutronix.de> --- drivers/gpu/drm/bridge/dw-hdmi.c | 43 ++++++++++++++++++++++++---------------- 1 file changed, 26 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c index 6fbec99..b0ebf92 100644 --- a/drivers/gpu/drm/bridge/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/dw-hdmi.c @@ -117,7 +117,7 @@ struct dw_hdmi { int vic; - u8 edid[HDMI_EDID_LEN]; + struct edid *edid; bool cable_plugin; bool phy_enabled; @@ -1437,32 +1437,41 @@ dw_hdmi_connector_detect(struct drm_connector *connector, bool force) dw_hdmi_update_phy_mask(hdmi); mutex_unlock(&hdmi->mutex); - return hdmi_readb(hdmi, HDMI_PHY_STAT0) & HDMI_PHY_HPD ? - connector_status_connected : connector_status_disconnected; + if (hdmi_readb(hdmi, HDMI_PHY_STAT0) & HDMI_PHY_HPD) + return connector_status_connected; + + /* free previous EDID block */ + if (hdmi->edid) { + drm_mode_connector_update_edid_property(connector, NULL); + kfree(hdmi->edid); + hdmi->edid = NULL; + } + + return connector_status_disconnected; } static int dw_hdmi_connector_get_modes(struct drm_connector *connector) { struct dw_hdmi *hdmi = container_of(connector, struct dw_hdmi, connector); - struct edid *edid; int ret = 0; - if (!hdmi->ddc) - return 0; - - edid = drm_get_edid(connector, hdmi->ddc); - if (edid) { - dev_dbg(hdmi->dev, "got edid: width[%d] x height[%d]\n", - edid->width_cm, edid->height_cm); + if (hdmi->ddc && !hdmi->edid) { + hdmi->edid = drm_get_edid(connector, hdmi->ddc); + if (hdmi->edid) { + hdmi->sink_is_hdmi = drm_detect_hdmi_monitor(hdmi->edid); + hdmi->sink_has_audio = drm_detect_monitor_audio(hdmi->edid); + drm_mode_connector_update_edid_property(connector, + hdmi->edid); + dev_dbg(hdmi->dev, "got edid: width[%d] x height[%d]\n", + hdmi->edid->width_cm, hdmi->edid->height_cm); + } + } - hdmi->sink_is_hdmi = drm_detect_hdmi_monitor(edid); - hdmi->sink_has_audio = drm_detect_monitor_audio(edid); - drm_mode_connector_update_edid_property(connector, edid); - ret = drm_add_edid_modes(connector, edid); + if (hdmi->edid) { + ret = drm_add_edid_modes(connector, hdmi->edid); /* Store the ELD */ - drm_edid_to_eld(connector, edid); - kfree(edid); + drm_edid_to_eld(connector, hdmi->edid); } else { dev_dbg(hdmi->dev, "failed to get edid\n"); } -- 2.6.4

3 7

[RFC 0/2] drm/dsi: DSI for devices with different control bus
by Archit Taneja 02 Mar '16

02 Mar '16

We are currently restricted when it comes to supporting DSI on devices that have a non-DSI control bus. For example, DSI encoder chips are available in the market that are configured via i2c. Configuring their registers via DSI bus is either optional or not available at all. These devices still need to pass DSI parameters (data lanes, mode flags etc) to the DSI host they are connected to. We don't have a way to do that at the moment. The method presented in these patches is to provide an API to create a 'dummy' mipi_dsi_device. This device is populated with the desired DSI params, which are passed on to the host via mipi_dsi_attach(). This method will require the device driver to get a phandle to the DSI host since there is no parent-child relation between the two. Is there a better way to do this? Please let me know! Archit Taneja (2): drm/dsi: Create dummy DSI devices drm/dsi: Get DSI host by DT device node drivers/gpu/drm/drm_mipi_dsi.c | 108 ++++++++++++++++++++++++++++++++++++++++- include/drm/drm_mipi_dsi.h | 4 ++ 2 files changed, 110 insertions(+), 2 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation

8 83

[PATCH 3/3] drm: panel-simple: implement URT UMSH-8596MD-xT panel support
by Maciej S. Szmigiero 02 Mar '16

02 Mar '16

This patch implements support for United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panels in DRM panel-simple driver. Signed-off-by: Maciej Szmigiero <mail(a)maciej.szmigiero.name> --- This replaces "drm: panel-simple: add URT UMSH-8596MD-xT panel support" submission. drivers/gpu/drm/panel/panel-simple.c | 54 ++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index f97b73e..44d0deb9 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1096,6 +1096,42 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = { .bus_format = MEDIA_BUS_FMT_RGB666_1X18, }; +static const struct display_timing urt_umsh_8596md_timing = { + .pixelclock = { 33260000, 33260000, 33260000 }, + .hactive = { 800, 800, 800 }, + .hfront_porch = { 41, 41, 41 }, + .hback_porch = { 216 - 128, 216 - 128, 216 - 128 }, + .hsync_len = { 71, 128, 128 }, + .vactive = { 480, 480, 480 }, + .vfront_porch = { 10, 10, 10 }, + .vback_porch = { 35 - 2, 35 - 2, 35 - 2 }, + .vsync_len = { 2, 2, 2 }, + .flags = DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_NEGEDGE | + DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW, +}; + +static const struct panel_desc urt_umsh_8596md_lvds = { + .timings = &urt_umsh_8596md_timing, + .num_timings = 1, + .bpc = 6, + .size = { + .width = 152, + .height = 91, + }, + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, +}; + +static const struct panel_desc urt_umsh_8596md_parallel = { + .timings = &urt_umsh_8596md_timing, + .num_timings = 1, + .bpc = 6, + .size = { + .width = 152, + .height = 91, + }, + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, +}; + static const struct of_device_id platform_of_match[] = { { .compatible = "ampire,am800480r3tmqwa1h", @@ -1191,6 +1227,24 @@ static const struct of_device_id platform_of_match[] = { .compatible = "shelly,sca07010-bfn-lnn", .data = &shelly_sca07010_bfn_lnn, }, { + .compatible = "urt,umsh-8596md-t", + .data = &urt_umsh_8596md_parallel, + }, { + .compatible = "urt,umsh-8596md-1t", + .data = &urt_umsh_8596md_parallel, + }, { + .compatible = "urt,umsh-8596md-7t", + .data = &urt_umsh_8596md_parallel, + }, { + .compatible = "urt,umsh-8596md-11t", + .data = &urt_umsh_8596md_lvds, + }, { + .compatible = "urt,umsh-8596md-19t", + .data = &urt_umsh_8596md_lvds, + }, { + .compatible = "urt,umsh-8596md-20t", + .data = &urt_umsh_8596md_parallel, + }, { /* sentinel */ } };

3 9

[PATCH 0/7] drm/cirrus: convert cirrus to atomic mode-setting
by John Hunter 02 Mar '16

02 Mar '16

From: Zhao Junwang <zhjwpku(a)gmail.com> This patch series aim to convert DRM_CIRRUS to atomic mode-setting. This mostly reference my previous patch series on DRM_BOCHS and Gustavo Padovan;s patch series on drm/exynos. Zhao Junwang (7): drm/cirrus: phase 1 - use the transitional helpers drm/cirrus: phase 2: wire up state reset, duplicate and destroy drm/cirrus: phase 3: atomic updates of planes drm/cirrus: add return 0 to make sure if (bo->pin_count) early_exit drm/cirrus: phase 3: use atomic .set_config helper drm/cirrus: atomic dpms support drm/cirrus: add DRIVER_ATOMIC to .driver_features drivers/gpu/drm/cirrus/cirrus_drv.c | 3 +- drivers/gpu/drm/cirrus/cirrus_drv.h | 3 +- drivers/gpu/drm/cirrus/cirrus_main.c | 5 +- drivers/gpu/drm/cirrus/cirrus_mode.c | 299 ++++++++++++++++++++-------------- drivers/gpu/drm/cirrus/cirrus_ttm.c | 2 + 5 files changed, 187 insertions(+), 125 deletions(-) -- 1.7.10.4

2 8

i915 Skylake: "Invalid ROM contents"
by Andy Lutomirski 29 Feb '16

29 Feb '16

Typing: # cat /sys/devices/pci0000:00/0000:00:02.0/rom Provokes: i915 0000:00:02.0: Invalid ROM contents This is on a Dell XPS 13 9350 (Skylake). This is 4.3.0 plus some wireless-next bits. --Andy -- Andy Lutomirski AMA Capital Management, LLC

4 7

[PATCH 00/12] drm/dp: Extend DRM DP link helpers
by Thierry Reding 29 Feb '16

29 Feb '16

From: Thierry Reding <treding(a)nvidia.com> This set of patches extends the existing DRM DP link helpers by caching additional capabilities. It also reworks the helpers to make use of the existing parsing helpers to reduce code duplication. Thierry Thierry Reding (12): drm/dp: Add drm_dp_link_reset() implementation drm/dp: link: Track capabilities alongside settings drm/dp: Turn link capabilities into booleans drm/dp: Probe link using existing parsing helpers drm/dp: Read fast training capability from link drm/dp: Read TPS3 capability from sink drm/dp: Set channel coding on link configuration drm/dp: Read eDP version from DPCD drm/dp: Add helper to get post-cursor adjustments drm/dp: Enable alternate scrambler when supported drm/dp: Read AUX read interval from DPCD drm/dp: Add drm_dp_link_choose() helper drivers/gpu/drm/drm_dp_helper.c | 177 ++++++++++++++++++++++++++++++++++--- drivers/gpu/drm/msm/edp/edp_ctrl.c | 12 +-- drivers/gpu/drm/tegra/dpaux.c | 8 +- drivers/gpu/drm/tegra/sor.c | 33 ++++--- include/drm/drm_dp_helper.h | 77 +++++++++++++++- 5 files changed, 266 insertions(+), 41 deletions(-) -- 2.5.0

3 19

[Bug 87316] [radeonsi][bonaire][drm-next-3.19] unable to handle kernel NULL pointer dereference: radeon_fence_signaled
by bugzilla-daemon＠freedesktop.org 26 Feb '16

26 Feb '16

https://bugs.freedesktop.org/show_bug.cgi?id=87316 Bug ID: 87316 Summary: [radeonsi][bonaire][drm-next-3.19] unable to handle kernel NULL pointer dereference: radeon_fence_signaled Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/Radeon Assignee: dri-devel(a)lists.freedesktop.org Reporter: shawn.starr(a)rogers.com hardware: Dell Precision M6800 (GPU: FirePro M6100) kernel: drm-next-3.19 from agdf5's linux git repo mesa: master from 20141213 (10.5-dev) I was using DRI_PRIME prior, the kernel oops happened while the GPU was powered down awhile later, see full kernel log from boot to failure. kernel oops dump: [22485.963089] BUG: unable to handle kernel NULL pointer dereference at 0000000000000d48 [22485.967333] IP: [<ffffffffa015668e>] radeon_fence_signaled+0x3e/0x90 [radeon] [22485.971403] PGD 0 [22485.973433] Oops: 0000 [#1] SMP [22485.975511] Modules linked in: cpufreq_stats rfcomm xt_CHECKSUM iptable_mangle ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack tun bridge stp llc bnep snd_hda_codec_realtek snd_hda_codec_hdmi snd_hda_codec_generic snd_hda_intel snd_hda_controller x86_pkg_temp_thermal coretemp snd_hda_codec kvm_intel kvm arc4 iwlmvm snd_hwdep mac80211 snd_seq i915 uvcvideo iwlwifi snd_seq_device videobuf2_vmalloc videobuf2_core videobuf2_memops v4l2_common crct10dif_pclmul videodev cfg80211 btusb media crc32_pclmul snd_pcm bluetooth vfat fat snd_timer joydev dell_wmi sparse_keymap iTCO_wdt iTCO_vendor_support dell_laptop snd dcdbas ppdev sdhci_pci mei_me crc32c_intel cdc_acm wmi serio_raw pcspkr ie31200_edac mei ghash_clmulni_intel lpc_ich [22486.010804] mfd_core rfkill soundcore edac_core i2c_hid i2c_i801 shpchp i2c_designware_platform video i2c_designware_core parport_pc parport dw_dmac dw_dmac_core dell_smo8800 radeon i2c_algo_bit drm_kms_helper ttm drm e1000e sdhci_acpi sdhci mmc_core ptp pps_core [22486.022517] CPU: 7 PID: 717 Comm: systemd-logind Not tainted 3.18.0+ #1 [22486.026765] Hardware name: Dell Inc. Precision M6800/05NG6V, BIOS A11 11/20/2014 [22486.030890] task: ffff8800c588cb00 ti: ffff880804028000 task.ti: ffff880804028000 [22486.035282] RIP: 0010:[<ffffffffa015668e>] [<ffffffffa015668e>] radeon_fence_signaled+0x3e/0x90 [radeon] [22486.041831] RSP: 0018:ffff88080402b878 EFLAGS: 00010246 [22486.045102] RAX: 0000000000000000 RBX: ffff880803e46600 RCX: 000000010040000e [22486.048791] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 [22486.053330] RBP: ffff88080402b898 R08: 0000000063e8df01 R09: 000000010040000e [22486.057116] R10: ffffffffa01cc22d R11: ffff880763e8df00 R12: 0000000000000000 [22486.061664] R13: 0000000000000d40 R14: 0000000000000000 R15: ffff88080402ba38 [22486.066733] FS: 00007f294be348c0(0000) GS:ffff88082ebc0000(0000) knlGS:0000000000000000 [22486.069989] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [22486.074192] CR2: 0000000000000d48 CR3: 0000000807fa9000 CR4: 00000000001407e0 [22486.077843] Stack: [22486.080235] ffff88080402b898 ffff880763e8d580 ffff88079424e880 ffff880802949a20 [22486.084016] ffff88080402b8c8 ffffffffa01cc2b4 ffff88080402bb18 ffff880802949978 [22486.088606] ffff88080402bb18 ffff8807a3887f40 ffff88080402b9e8 ffffffffa01cc8a8 [22486.093200] Call Trace: [22486.094945] [<ffffffffa01cc2b4>] radeon_sa_bo_try_free+0x64/0x80 [radeon] [22486.099356] [<ffffffffa01cc8a8>] radeon_sa_bo_new+0x118/0x490 [radeon] [22486.102843] [<ffffffffa01559ab>] ? radeon_fence_activity+0x10b/0x1c0 [radeon] [22486.107423] [<ffffffffa0227567>] radeon_ib_get+0x37/0xe0 [radeon] [22486.110871] [<ffffffffa02337f3>] radeon_vce_get_destroy_msg+0x43/0x240 [radeon] [22486.115516] [<ffffffffa0234833>] radeon_vce_ib_test+0x63/0x100 [radeon] [22486.119946] [<ffffffffa02279fa>] radeon_ib_ring_tests+0x5a/0xc0 [radeon] [22486.123477] [<ffffffffa013a91d>] radeon_resume_kms+0x9d/0x260 [radeon] [22486.127830] [<ffffffffa0138143>] radeon_pmops_runtime_resume+0x73/0xb0 [radeon] [22486.131779] [<ffffffff813cef9f>] pci_pm_runtime_resume+0x7f/0xc0 [22486.136004] [<ffffffff8149d2f9>] vga_switcheroo_runtime_resume+0x39/0x40 [22486.139411] [<ffffffff8128e200>] ? kernfs_fop_release+0x60/0x60 [22486.142766] [<ffffffff814ae194>] __rpm_callback+0x34/0x90 [22486.146340] [<ffffffff814ae216>] rpm_callback+0x26/0xa0 [22486.149156] [<ffffffff814ae6f4>] rpm_resume+0x464/0x640 [22486.152313] [<ffffffff8175a836>] ? mutex_lock+0x16/0x40 [22486.154513] [<ffffffff814af76f>] __pm_runtime_resume+0x4f/0x80 [22486.157761] [<ffffffffa01622e3>] radeon_dp_detect+0x43/0x290 [radeon] [22486.161421] [<ffffffffa00a2171>] status_show+0x41/0x90 [drm] [22486.164584] [<ffffffff814a0a00>] dev_attr_show+0x20/0x60 [22486.167656] [<ffffffff8175a836>] ? mutex_lock+0x16/0x40 [22486.169910] [<ffffffff8128eec6>] sysfs_kf_seq_show+0xb6/0x150 [22486.172287] [<ffffffff8128d673>] kernfs_seq_show+0x23/0x30 [22486.175550] [<ffffffff81237185>] seq_read+0xf5/0x3d0 [22486.178653] [<ffffffff8128e0a5>] kernfs_fop_read+0xf5/0x160 [22486.181877] [<ffffffff81211e88>] vfs_read+0x98/0x180 [22486.184017] [<ffffffff81212a75>] SyS_read+0x55/0xd0 [22486.186276] [<ffffffff8175cae9>] system_call_fastpath+0x12/0x17 [22486.189533] Code: 48 89 fb 48 83 ec 08 8b 47 68 4c 8b 67 60 48 8b 7f 58 48 89 c2 48 89 c6 48 c1 e0 08 48 c1 e2 04 48 29 d0 4c 8d ac 07 40 0d 00 00 <49> 8b 45 08 49 39 c4 77 19 48 89 df e8 11 e6 36 e1 48 83 c4 08 [22486.198672] RIP [<ffffffffa015668e>] radeon_fence_signaled+0x3e/0x90 [radeon] [22486.202344] RSP <ffff88080402b878> [22486.204115] CR2: 0000000000000d48 [22486.211204] ---[ end trace 0f3b8a81fa241e74 ]--- -- You are receiving this mail because: You are the assignee for the bug.

1 2

[Bug 91061] [4.1-rc8][radeonsi] GPU lockup from chrome - radeon_ttm_bo_destroy
by bugzilla-daemon＠freedesktop.org 26 Feb '16

26 Feb '16

https://bugs.freedesktop.org/show_bug.cgi?id=91061 Bug ID: 91061 Summary: [4.1-rc8][radeonsi] GPU lockup from chrome - radeon_ttm_bo_destroy Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/Radeon Assignee: dri-devel(a)lists.freedesktop.org Reporter: shawn.starr(a)rogers.com Created attachment 116660 --> https://bugs.freedesktop.org/attachment.cgi?id=116660&action=edit Kernel stack dump Somehow triggered GPU lockup with Chrome Attachment contains crash stack from kernel DDX: xorg-x11-drv-ati-7.5.0-3.fc22.x86_64 Kernel: 4.1.0-0.rc8.git0.2.fc23.x86_64 Mesa: mesa-dri-drivers-10.7.0-0.devel.60.20150606.fc22.x86_64 (git master build, from specified date) -- You are receiving this mail because: You are the assignee for the bug.

1 3

[Bug 93594] Flickering Shadows in The Talos Principle
by bugzilla-daemon＠freedesktop.org 26 Feb '16

26 Feb '16

https://bugs.freedesktop.org/show_bug.cgi?id=93594 Bug ID: 93594 Summary: Flickering Shadows in The Talos Principle Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: haagch(a)frickel.club QA Contact: dri-devel(a)lists.freedesktop.org I haven't seen specifically this bug mentioned here yet. Apparently this has been an issue for some time and with latest mesa git and llvm svn 256490 it still happens. Video demonstrating the flickering (ignore the long pause): https://www.youtube.com/watch?v=UyZu_71LgGE My hardware: 01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Wimbledon XT [Radeon HD 7970M] (rev ff) Here is a trace (657MB uncompressed, 409MB compressed): http://haagch.frickel.club/files/talos.trace.xz Replaying the trace on radeonsi shows flickering shadows. When replaying the trace on intel, the shadows don't seem to flicker. -- You are receiving this mail because: You are the assignee for the bug.

1 27

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2016