dri-devel March 2016

dri-devel@lists.freedesktop.org

206 participants
1222 discussions

[PATCH 0/3] drm/omap: patches for v4.6 part 3
by Tomi Valkeinen 06 Mar '16

06 Mar '16

Hi, A few more patches for omapdrm for 4.6. These are based on the "drm/omap: patches for v4.6 part 2" series sent earlier. Tomi Laurent Pinchart (1): drm/omap: gem: Fix omap_gem_new() error path Tomi Valkeinen (2): drm/omap: remove -Werror from Makefile drm/omap: no need to select OMAP2_DSS drivers/gpu/drm/omapdrm/Kconfig | 1 - drivers/gpu/drm/omapdrm/Makefile | 2 +- drivers/gpu/drm/omapdrm/omap_gem.c | 34 ++++++++++++++++++---------------- 3 files changed, 19 insertions(+), 18 deletions(-) -- 2.5.0

2 7

[PATCHv12 00/17] HDMI CEC framework
by Hans Verkuil 05 Mar '16

05 Mar '16

From: Hans Verkuil <hans.verkuil(a)cisco.com> Hi all, The twelfth version of this patchset addresses the remaining comment I made when I posted the previous version and it makes some improvements to the tx_status after re-reading the CEC specification. See the changelog below. The cec-ctl and cec-compliance utilities used to test the CEC framework can be found here: http://git.linuxtv.org/cgit.cgi/hverkuil/v4l-utils.git/log/?h=cec I have no more items on my todo list, so if there are no more comments then I would like to merge this. Note: this patch series assumes that these two ADV fixes are applied first: https://patchwork.linuxtv.org/patch/32956/ https://patchwork.linuxtv.org/patch/32958/ I found these bugs while testing connect/disconnect behavior. Best regards, Hans Changes since v11 ================= - Add a new CEC_EVENT_PHYS_ADDR_CHANGED to report when the physical address of the CEC adapter changes. Since the physical address is obtained from the EDID the application has to be informed when the kernel (or userspace for that matter) sets that. - Add a new internal cec_set_phys_addr() function to change the physical address and post the event. - Modified the retry-transmit mechanism: the framework will do the retry if the low-level driver returns a TX_STATUS error, but does not set the CEC_TX_STATUS_MAX_RETRIES status bit. In that case the framework assumes that there is no hardware retry and it will retry itself. This used to be through the 'retries' pointer argument (set to 0 if there is no retry support) but that doesn't work for hardware that does retry for some error conditions but not for others. - Added the missing CEC_TX_STATUS_LOW_DRIVE bit and low_drive_cnt error counter. I missed that potential CEC bus error condition. - By passing a NULL pointer to cec_claim_log_addrs() drivers can clear the logical addresses. - When a source loses the HPD the source has to clear the logical addresses and update its physical address. Implement this in the cobalt driver. - Improve tx_status handling in the various low-level drivers. Changes since v10 ================= - Split the msg.status field into tx_status and rx_status. - Add counters for various CEC protocol errors that can occur during transmit. - Add tx_status bits for the ARB_LOST and NACK status and add a generic CEC_TX_STATUS_ERROR bit. - Add retry support to the CEC framework for hardware that does not have retry support. - Improve event handling: on open() generate events that report the initial CEC adapter status and the number of connected inputs. Also ensure that you never loose important events (intermediate events may be lost, but never the last event). The basic mechanism has been taken from the V4L2 event implementation which works very well. - CEC emulation support was added to vivid which makes it much easier to test CEC applications without having hardware present. - Improve handling of timings and timeouts in the cec framework. - Improve locking. - Fixed buggy rc cleanup. - All CEC messages are now fully supported in cec-funcs.h (specifically handling of UI Commands and short audio descriptors). Changes since v9 ================ - Updated cec.txt - Added a promiscuous capability to signal those adapters that can monitor all CEC traffic, not just directed and broadcast messages. I have one adapter that can do this. Added code in the framework to handle such messages correctly. - The status field is now value and no longer a bitmask. - Renamed the kernel config from CEC to MEDIA_CEC - The adap_transmit() callback now has a retries argument. - Use the new CEC_MAX_MSG_SIZE define instead of hardcoding it as 16 - Add support to wait for a reply after a broadcast message: this was forbidden, but it is a valid use-case. - Make sure you can't send a message to yourself. - Waiting for a transmit to succeed would never timeout (and couldn't be interrupted). Fixed. - The message status was not updated correctly if it was CEC_MSG_FEATURE_ABORTed. - Fixed a nasty kernel oops when deleting a cec adapter. - Removed the owner check: the module owner is NULL if it is compiled into the kernel instead of as a module. - Added separate register/unregister calls: this is safer and actually made it possible to drop the ugly 'cec_ready' v4l2_subdev op. Suggested by Russell, and that was a good idea. - Added missing support for 32-bit to 64-bit ioctl conversion. - Move the v4l2_subdev cec ops into a v4l2_subdev_cec_ops struct. Changes since v8 ================ - Addressed the comments Russell King made about how the cec character devices should be allocated/freed. - Updated the DocBook documentation. Changes since v7 ================ - I thought that the core thread could handle out-of-order messages, but that turned out to be wrong. After careful analysis I realized that I had to rewrite this part in cec.c in order to make it work. - Added new CEC-specific keys to input.h and use them in the CEC rc keymap. Replaced KEY_PLAY/PAUSE/STOP with KEY_PLAYCD/PAUSECD/STOPCD to clarify that these are media operations and not the Pause key on the keyboard. - Added CEC_PHYS_ADDR_INVALID (0xffff) - Added monitor support to monitor CEC traffic - Replaced CAP_TRANSMIT and CAP_RECEIVE by a single CAP_IO. - Replaced CAP_CDC by CAP_CDC_HPD since this only applies to the HPD part of the CDC messages. - Add CAP_IS_SOURCE. - Add ninputs field to cec_caps to export the number of inputs of the device. - Drop CEC_LOG_ADDRS_FL_HANDLE_MSGS and the flags field (see next change for more info). - Add CEC_CLAIM and CEC_RELEASE to explicitly start/stop processing CEC messages. This also implies ownership of the CEC interface, so other filehandles can only receive but not transmit. - Reworked event handling: report adapter state changes, input changes and if the message receive queue is full. - cec-funcs.h: added CDC HEC support. - Renamed G/S_ADAP ioctls to ADAP_G/S: this made it clearer which ioctls deal with the adapter configuration and which deal with CEC messages/events. - Clarified which CEC messages are passed on to userspace and which aren't. Specifically if CAP_ARC is set, then all ARC messages are handled by the kernel. If CAP_CDC_HPD is set, then all CDC hotplug messages are handled by the kernel. Otherwise these messages are passed on to userspace. Changes since v6 ================ - added cec-funcs.h to provide wrapper functions that fill in the cec_msg struct. This header is needed both by the kernel and by applications. - fix a missing rc_unregister_device call. - added CEC support for the adv7842 and cobalt drivers. - added CEC operand defines. Rename CEC message defines to CEC_MSG_ and operand defines now use CEC_OP_. - the CEC_VERSION defines are dropped since we now have the CEC_OP_VERSION defines. - ditto: CEC_PRIM_DEVTYPE_ is now CEC_OP_PRIM_DEVTYPE. - ditto: CEC_FL_ALL_DEVTYPE_ is now CEC_OP_ALL_DEVTYPE. - cec-ioc-g-adap-log-addrs.xml: document cec_versions field. - cec-ioc-g-caps.xml: drop vendor_id and version fields. - add MAINTAINERS entry. - add CDC support (not yet fully functional). - add a second debug level for message debugging. - fix a nasty kernel Oops in cec_transmit_msg while waiting for transmit completion (adap->tx_queue[idx].func wasn't set to NULL). - add support for CEC_MSG_REPORT_FEATURES (CEC 2.0 only). - correctly abort unsupported messages. - add support for the device power status feature. - add support for the audio return channel (preliminary). - add support for the CDC hotplug message (preliminary). - added osd_name to struct cec_log_addrs. - reported physical addresses are stored internally. - fix enabling/disabling the CEC adapter (internal fields weren't cleared correctly). - zero reserved fields. - return an error if you try to receive/transmit and the adapter isn't configured. - when creating the adapter provide the owner module and the parent device. - add a CEC_VENDOR_ID_NONE define to signal if no vendor ID was set. - add new capabilities: RC (remote control), ARC (audio return channel) and CDC (Capability Discovery and Control). - applications that want to handle messages for a logical address need to set the CEC_LOG_ADDRS_FL_HANDLE_MSGS flag. Otherwise the CEC core will be the one handling all messages. - Each logical address has its own all_device_types value. So this should be an array, not a single value. - I'm sure I've forgotten some changes... Changes since v5 ================ - drop struct cec_timeval in favour of a __u64 that keeps the timestamp in ns - remove userspace documentation from Documentation/cec.txt as userspace API is described in the DocBook - add missing documentation for the passthrough mode to the DocBook - add information about the number of events that can be queued - fix misspelling of reply - fix behaviour of posting an event in cec_received_msg, such that the behaviour is consistent with the documentation Changes since v4 ================ - add sequence numbering to transmitted messages - add sequence number handling to event hanlding - add passthrough mode - change reserved field sizes - fixed CEC version defines and addec CEC 2.0 commands - add DocBook documentation Changes since v3 ================ - remove the promiscuous mode - rewrite the devicetree patches - fixes, expansion and partial rewrite of the documentation - reorder of API structures and addition of reserved fields - use own struct to report time (32/64 bit safe) - fix of handling events - add cec.h to include/uapi/linux/Kbuild - fixes in the adv76xx driver (add missing methods, change adv7604 to adv76xx) - cleanup of debug messages in s5p-cec driver - remove non necessary claiming of a gpio in the s5p-cec driver - cleanup headers of the s5p-cec driver Changes since v2 ===============- - added promiscuous mode - added new key codes to the input framework - add vendor ID reporting - add the possibility to clear assigned logical addresses - cleanup of the rc cec map Changes since v1 ================ - documentation edited and moved to the Documentation folder - added key up/down message handling - add missing CEC commands to the cec.h file Background ========== The work on a common CEC framework was started over three years ago by Hans Verkuil. Unfortunately the work has stalled. As I have received the task of creating a driver for the CEC interface module present on the Exynos range of SoCs, I got in touch with Hans. He replied that the work stalled due to his lack of time. Original RFC by Hans Verkuil/Martin Bugge ========================================= https://www.mail-archive.com/linux-media@vger.kernel.org/msg28735.html Hans Verkuil (11): input.h: add BUS_CEC type cec: add HDMI CEC framework cec: add compat32 ioctl support cec.txt: add CEC framework documentation DocBook/media: add CEC documentation v4l2-subdev: add HDMI CEC ops cec: adv7604: add cec support. cec: adv7842: add cec support cec: adv7511: add cec support. cobalt: add cec support vivid: add CEC emulation Kamil Debski (6): dts: exynos4*: add HDMI CEC pin definition to pinctrl dts: exynos4: add node for the HDMI CEC device dts: exynos4412-odroid*: enable the HDMI CEC device HID: add HDMI CEC specific keycodes rc: Add HDMI CEC protocol handling cec: s5p-cec: Add s5p-cec driver Documentation/DocBook/device-drivers.tmpl | 3 + Documentation/DocBook/media/Makefile | 2 + Documentation/DocBook/media/v4l/biblio.xml | 10 + Documentation/DocBook/media/v4l/cec-api.xml | 76 + Documentation/DocBook/media/v4l/cec-func-close.xml | 59 + Documentation/DocBook/media/v4l/cec-func-ioctl.xml | 73 + Documentation/DocBook/media/v4l/cec-func-open.xml | 94 + Documentation/DocBook/media/v4l/cec-func-poll.xml | 89 + .../DocBook/media/v4l/cec-ioc-adap-g-caps.xml | 167 ++ .../DocBook/media/v4l/cec-ioc-adap-g-log-addrs.xml | 305 +++ .../DocBook/media/v4l/cec-ioc-adap-g-phys-addr.xml | 80 + .../DocBook/media/v4l/cec-ioc-adap-g-state.xml | 87 + .../DocBook/media/v4l/cec-ioc-adap-g-vendor-id.xml | 70 + Documentation/DocBook/media/v4l/cec-ioc-claim.xml | 71 + .../DocBook/media/v4l/cec-ioc-dqevent.xml | 280 +++ .../DocBook/media/v4l/cec-ioc-g-monitor.xml | 86 + .../DocBook/media/v4l/cec-ioc-g-passthrough.xml | 81 + .../DocBook/media/v4l/cec-ioc-receive.xml | 261 +++ Documentation/DocBook/media_api.tmpl | 6 +- Documentation/cec.txt | 359 ++++ .../devicetree/bindings/media/s5p-cec.txt | 31 + Documentation/video4linux/vivid.txt | 36 +- MAINTAINERS | 21 + arch/arm/boot/dts/exynos4.dtsi | 12 + arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 7 + arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 + arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 7 + drivers/media/Kconfig | 7 + drivers/media/Makefile | 2 + drivers/media/cec.c | 2185 ++++++++++++++++++++ drivers/media/i2c/adv7511.c | 384 +++- drivers/media/i2c/adv7604.c | 254 ++- drivers/media/i2c/adv7842.c | 268 ++- drivers/media/pci/cobalt/Kconfig | 1 + drivers/media/pci/cobalt/cobalt-driver.c | 115 +- drivers/media/pci/cobalt/cobalt-driver.h | 2 + drivers/media/pci/cobalt/cobalt-irq.c | 3 + drivers/media/pci/cobalt/cobalt-v4l2.c | 126 +- drivers/media/pci/cobalt/cobalt-v4l2.h | 2 + drivers/media/platform/Kconfig | 12 + drivers/media/platform/Makefile | 1 + drivers/media/platform/s5p-cec/Makefile | 2 + drivers/media/platform/s5p-cec/exynos_hdmi_cec.h | 38 + .../media/platform/s5p-cec/exynos_hdmi_cecctrl.c | 210 ++ drivers/media/platform/s5p-cec/regs-cec.h | 96 + drivers/media/platform/s5p-cec/s5p_cec.c | 296 +++ drivers/media/platform/s5p-cec/s5p_cec.h | 76 + drivers/media/platform/vivid/Kconfig | 1 + drivers/media/platform/vivid/vivid-core.c | 308 ++- drivers/media/platform/vivid/vivid-core.h | 23 + drivers/media/platform/vivid/vivid-vid-cap.c | 23 + drivers/media/platform/vivid/vivid-vid-common.c | 61 + drivers/media/platform/vivid/vivid-vid-common.h | 1 + drivers/media/rc/keymaps/Makefile | 1 + drivers/media/rc/keymaps/rc-cec.c | 174 ++ drivers/media/rc/rc-main.c | 1 + fs/compat_ioctl.c | 19 + include/media/cec.h | 201 ++ include/media/i2c/adv7511.h | 6 +- include/media/rc-core.h | 1 + include/media/rc-map.h | 5 +- include/media/v4l2-subdev.h | 22 + include/uapi/linux/Kbuild | 2 + include/uapi/linux/cec-funcs.h | 1852 +++++++++++++++++ include/uapi/linux/cec.h | 928 +++++++++ include/uapi/linux/input-event-codes.h | 28 + include/uapi/linux/input.h | 1 + 67 files changed, 10047 insertions(+), 68 deletions(-) create mode 100644 Documentation/DocBook/media/v4l/cec-api.xml create mode 100644 Documentation/DocBook/media/v4l/cec-func-close.xml create mode 100644 Documentation/DocBook/media/v4l/cec-func-ioctl.xml create mode 100644 Documentation/DocBook/media/v4l/cec-func-open.xml create mode 100644 Documentation/DocBook/media/v4l/cec-func-poll.xml create mode 100644 Documentation/DocBook/media/v4l/cec-ioc-adap-g-caps.xml create mode 100644 Documentation/DocBook/media/v4l/cec-ioc-adap-g-log-addrs.xml create mode 100644 Documentation/DocBook/media/v4l/cec-ioc-adap-g-phys-addr.xml create mode 100644 Documentation/DocBook/media/v4l/cec-ioc-adap-g-state.xml create mode 100644 Documentation/DocBook/media/v4l/cec-ioc-adap-g-vendor-id.xml create mode 100644 Documentation/DocBook/media/v4l/cec-ioc-claim.xml create mode 100644 Documentation/DocBook/media/v4l/cec-ioc-dqevent.xml create mode 100644 Documentation/DocBook/media/v4l/cec-ioc-g-monitor.xml create mode 100644 Documentation/DocBook/media/v4l/cec-ioc-g-passthrough.xml create mode 100644 Documentation/DocBook/media/v4l/cec-ioc-receive.xml create mode 100644 Documentation/cec.txt create mode 100644 Documentation/devicetree/bindings/media/s5p-cec.txt create mode 100644 drivers/media/cec.c create mode 100644 drivers/media/platform/s5p-cec/Makefile create mode 100644 drivers/media/platform/s5p-cec/exynos_hdmi_cec.h create mode 100644 drivers/media/platform/s5p-cec/exynos_hdmi_cecctrl.c create mode 100644 drivers/media/platform/s5p-cec/regs-cec.h create mode 100644 drivers/media/platform/s5p-cec/s5p_cec.c create mode 100644 drivers/media/platform/s5p-cec/s5p_cec.h create mode 100644 drivers/media/rc/keymaps/rc-cec.c create mode 100644 include/media/cec.h create mode 100644 include/uapi/linux/cec-funcs.h create mode 100644 include/uapi/linux/cec.h -- 2.7.0

2 21

[pull] radeon and amdgpu drm-next-4.6
by Alex Deucher 05 Mar '16

05 Mar '16

Hi Dave, Some more radeon and amdgpu stuff for drm-next. Mostly just bug fixes for new features and cleanups. The following changes since commit d2eaa59000c7717e68a75cf2c106f056d2bc30b4: Merge branch 'drm-rockchip-next-2016-02-18' of https://github.com/markyzq/kernel-drm-rockchip into drm-next (2016-02-19 13:10:18 +1000) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-next-4.6 for you to fetch changes up to 6157bd7a1009c2a6944fb3eee8ed2b3dea091fd8: drm/amdgpu: fix rb bitmap & cu bitmap calculation (2016-03-03 01:00:20 -0500) ---------------------------------------------------------------- Alex Deucher (3): drm/amdgpu/gfx: fix off by one in rb rework (v2) drm/radeon: update radeon acpi header drm/amdgpu: update radeon acpi header Christian König (3): drm/amdgpu: fix error handling in amdgpu_bo_list_set drm/amdgpu: fix VM faults caused by vm_grab_id() v4 drm/amdgpu: trace the pd_addr in vm_grab_id as well Dan Carpenter (1): drm/amd: cleanup get_mfd_cell_dev() Flora Cui (1): drm/amdgpu: fix rb bitmap & cu bitmap calculation Geert Uytterhoeven (1): drm/amd: Do not make DRM_AMD_ACP default to y Rex Zhu (1): drm/amd/powerplay: fix code style warning. drivers/gpu/drm/amd/acp/Kconfig | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu.h | 16 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 3 + drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 7 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 15 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 19 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 116 ++++++++++++++------------ drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 2 +- drivers/gpu/drm/amd/amdgpu/cikd.h | 3 - drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 28 +++---- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 22 +++-- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 +- drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/vid.h | 2 - drivers/gpu/drm/amd/include/amd_acpi.h | 2 + drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 4 +- drivers/gpu/drm/radeon/radeon_acpi.h | 2 + 18 files changed, 131 insertions(+), 121 deletions(-)

2 2

[PATCH] drm/amdgpu: delete set-but-not-read member has_uvd from amdgpu_device
by Nils Wallménius 05 Mar '16

05 Mar '16

Clean up leftover from radeon code. Signed-off-by: Nils Wallménius <nils.wallmenius(a)gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - drivers/gpu/drm/amd/amdgpu/cik.c | 2 -- drivers/gpu/drm/amd/amdgpu/vi.c | 4 ---- 3 files changed, 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index 0c42a85..cfd35b0 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h @@ -2053,7 +2053,6 @@ struct amdgpu_device { struct amdgpu_sdma sdma; /* uvd */ - bool has_uvd; struct amdgpu_uvd uvd; /* vce */ diff --git a/drivers/gpu/drm/amd/amdgpu/cik.c b/drivers/gpu/drm/amd/amdgpu/cik.c index 6b1f053..5da14a3 100644 --- a/drivers/gpu/drm/amd/amdgpu/cik.c +++ b/drivers/gpu/drm/amd/amdgpu/cik.c @@ -2025,8 +2025,6 @@ static int cik_common_early_init(void *handle) adev->asic_funcs = &cik_asic_funcs; - adev->has_uvd = true; - adev->rev_id = cik_get_rev_id(adev); adev->external_rev_id = 0xFF; switch (adev->asic_type) { diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index 1250035..9163f59 100644 --- a/drivers/gpu/drm/amd/amdgpu/vi.c +++ b/drivers/gpu/drm/amd/amdgpu/vi.c @@ -1071,26 +1071,22 @@ static int vi_common_early_init(void *handle) adev->external_rev_id = 0xFF; switch (adev->asic_type) { case CHIP_TOPAZ: - adev->has_uvd = false; adev->cg_flags = 0; adev->pg_flags = 0; adev->external_rev_id = 0x1; break; case CHIP_FIJI: - adev->has_uvd = true; adev->cg_flags = 0; adev->pg_flags = 0; adev->external_rev_id = adev->rev_id + 0x3c; break; case CHIP_TONGA: - adev->has_uvd = true; adev->cg_flags = 0; adev->pg_flags = 0; adev->external_rev_id = adev->rev_id + 0x14; break; case CHIP_CARRIZO: case CHIP_STONEY: - adev->has_uvd = true; adev->cg_flags = 0; /* Disable UVD pg */ adev->pg_flags = /* AMDGPU_PG_SUPPORT_UVD | */AMDGPU_PG_SUPPORT_VCE; -- 2.7.0

2 1

[PATCH 1/2] drm/amdgpu: Fix error handling in amdgpu_flip_work_func.
by Mario Kleiner 05 Mar '16

05 Mar '16

The patch e1d09dc0ccc6: "drm/amdgpu: Don't hang in amdgpu_flip_work_func on disabled crtc." from Feb 19, 2016, leads to the following static checker warning, as reported by Dan Carpenter in https://lists.freedesktop.org/archives/dri-devel/2016-February/101987.html drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:127 amdgpu_flip_work_func() warn: should this be 'repcnt == -1' drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:136 amdgpu_flip_work_func() error: double unlock 'spin_lock:&crtc->dev->event_lock' drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:136 amdgpu_flip_work_func() error: double unlock 'irqsave:flags' This patch fixes both reported problems: Change post-decrement of repcnt to pre-decrement, so it can't underflow anymore, but still performs up to three repetitions - three is the maximum one could expect in practice. Move the spin_unlock_irqrestore to where it actually belongs. Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com> Signed-off-by: Mario Kleiner <mario.kleiner.de(a)gmail.com> Cc: <stable(a)vger.kernel.org> # 4.4+ Cc: Michel Dänzer <michel.daenzer(a)amd.com> Cc: Alex Deucher <alexander.deucher(a)amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c index 8297bc3..1846d65 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c @@ -96,7 +96,7 @@ static void amdgpu_flip_work_func(struct work_struct *__work) * In practice this won't execute very often unless on very fast * machines because the time window for this to happen is very small. */ - while (amdgpuCrtc->enabled && repcnt--) { + while (amdgpuCrtc->enabled && --repcnt) { /* GET_DISTANCE_TO_VBLANKSTART returns distance to real vblank * start in hpos, and to the "fudged earlier" vblank start in * vpos. @@ -112,13 +112,13 @@ static void amdgpu_flip_work_func(struct work_struct *__work) break; /* Sleep at least until estimated real start of hw vblank */ - spin_unlock_irqrestore(&crtc->dev->event_lock, flags); min_udelay = (-hpos + 1) * max(vblank->linedur_ns / 1000, 5); if (min_udelay > vblank->framedur_ns / 2000) { /* Don't wait ridiculously long - something is wrong */ repcnt = 0; break; } + spin_unlock_irqrestore(&crtc->dev->event_lock, flags); usleep_range(min_udelay, 2 * min_udelay); spin_lock_irqsave(&crtc->dev->event_lock, flags); }; -- 1.9.1

3 3

[Bug 94387] Approx 35W more power usage in multi-screen
by bugzilla-daemon＠freedesktop.org 05 Mar '16

05 Mar '16

https://bugs.freedesktop.org/show_bug.cgi?id=94387 --- Comment #5 from Steve <netwiz(a)crc.id.au> --- Further digging in this BZ seems to show this as a similar problem to: https://bugzilla.kernel.org/show_bug.cgi?id=60523 /sys/class/drm/card0/device $ cat power_dpm_force_performance_level auto /sys/class/drm/card0/device $ echo low > power_dpm_force_performance_level -bash: echo: write error: Invalid argument /sys/class/drm/card0/device $ cat power_dpm_force_performance_level auto /sys/class/drm/card0/device $ echo high > power_dpm_force_performance_level -bash: echo: write error: Invalid argument /sys/class/drm/card0/device $ echo auto > power_dpm_force_performance_level -bash: echo: write error: Invalid argument Video card is: $ lspci -v -s 03:00.0 03:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Barts XT [Radeon HD 6870] (prog-if 00 [VGA controller]) Subsystem: Advanced Micro Devices, Inc. [AMD/ATI] Device 00d0 Flags: bus master, fast devsel, latency 0, IRQ 37 Memory at d0000000 (64-bit, prefetchable) [size=256M] Memory at fbcc0000 (64-bit, non-prefetchable) [size=128K] I/O ports at d000 [size=256] Expansion ROM at fbca0000 [disabled] [size=128K] Capabilities: [50] Power Management version 3 Capabilities: [58] Express Legacy Endpoint, MSI 00 Capabilities: [a0] MSI: Enable+ Count=1/1 Maskable- 64bit+ Capabilities: [100] Vendor Specific Information: ID=0001 Rev=1 Len=010 <?> Capabilities: [150] Advanced Error Reporting Kernel driver in use: radeon Kernel modules: radeon -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 94387] Approx 35W more power usage in multi-screen
by bugzilla-daemon＠freedesktop.org 05 Mar '16

05 Mar '16

https://bugs.freedesktop.org/show_bug.cgi?id=94387 --- Comment #4 from Steve <netwiz(a)crc.id.au> --- I've been digging more into this.... I have 3 x displays - 2 x DVI, 1 x DP. Looking into debugfs, I can see that the clocks never change from sclk 900MHz, mclk: 105000. ie: # cat /sys/kernel/debug/dri/64/radeon_pm_info uvd vclk: 0 dclk: 0 power level 2 sclk: 90000 mclk: 105000 vddc: 1175 vddci: 1150 My kernel options are: # for i in /sys/class/drm/card0/device/power_*; do echo "$i: `cat $i`"; done /sys/class/drm/card0/device/power_dpm_force_performance_level: auto /sys/class/drm/card0/device/power_dpm_state: balanced /sys/class/drm/card0/device/power_method: dpm /sys/class/drm/card0/device/power_profile: default # for i in /sys/module/radeon/parameters/*; do echo "$i: `cat $i`"; done /sys/module/radeon/parameters/agpmode: 0 /sys/module/radeon/parameters/aspm: -1 /sys/module/radeon/parameters/audio: 0 /sys/module/radeon/parameters/auxch: -1 /sys/module/radeon/parameters/backlight: -1 /sys/module/radeon/parameters/bapm: -1 /sys/module/radeon/parameters/benchmark: 0 /sys/module/radeon/parameters/connector_table: 0 /sys/module/radeon/parameters/deep_color: 0 /sys/module/radeon/parameters/disp_priority: 0 /sys/module/radeon/parameters/dpm: -1 /sys/module/radeon/parameters/dynclks: -1 /sys/module/radeon/parameters/fastfb: 0 /sys/module/radeon/parameters/gartsize: 1024 /sys/module/radeon/parameters/hard_reset: 0 /sys/module/radeon/parameters/hw_i2c: 0 /sys/module/radeon/parameters/lockup_timeout: 10000 /sys/module/radeon/parameters/modeset: 1 /sys/module/radeon/parameters/msi: -1 /sys/module/radeon/parameters/mst: 0 /sys/module/radeon/parameters/no_wb: 0 /sys/module/radeon/parameters/pcie_gen2: -1 /sys/module/radeon/parameters/r4xx_atom: 0 /sys/module/radeon/parameters/runpm: -1 /sys/module/radeon/parameters/test: 0 /sys/module/radeon/parameters/tv: 0 /sys/module/radeon/parameters/use_pflipirq: 2 /sys/module/radeon/parameters/vm_block_size: 12 /sys/module/radeon/parameters/vm_size: 8 /sys/module/radeon/parameters/vramlimit: 0 # cat /proc/cmdline BOOT_IMAGE=/boot/vmlinuz-4.4.3-300.fc23.x86_64 root=UUID=03ee98ed-d998-4518-b216-b77822a9319b ro quiet radeon.audio=0 radeon.tv=0 audit=0 selinux=0 # cat /proc/version Linux version 4.4.3-300.fc23.x86_64 (mockbuild(a)bkernel01.phx2.fedoraproject.org) (gcc version 5.3.1 20151207 (Red Hat 5.3.1-2) (GCC) ) #1 SMP Fri Feb 26 18:45:40 UTC 2016 -- You are receiving this mail because: You are the assignee for the bug.

1 0

[git pull] drm fixes
by Dave Airlie 04 Mar '16

04 Mar '16

Hi Linus, Hopefully not too big, I've held off on some vc4 fixes that came in that I think can wait next window. This contains one i915 patch twice, as I merged it locally for testing, and then pulled some stuff in on top, and then Jani sent to me, I didn't think it was worth redoing all the merges of what I had tested. The amdgpu/radeon fixes for some more power management and VM races. Two i915 fixes, one for the a recent regression, one another power management fix for skylake. Two tegra dma mask fixes for a regression. One ast fix for a typo I made transcribing the userspace driver, that I'd like to get into stable so I don't forget about it. Dave. The following changes since commit fc77dbd34c5c99bce46d40a2491937c3bcbd10af: Linux 4.5-rc6 (2016-02-28 08:41:20 -0800) are available in the git repository at: git://people.freedesktop.org/~airlied/linux drm-fixes for you to fetch changes up to 26bae5e04c3570728787f809b13546a8169fdf95: Merge tag 'drm/tegra/for-4.5-rc7' of git://anongit.freedesktop.org/tegra/linux into drm-fixes (2016-03-05 07:53:25 +1000) ---------------------------------------------------------------- Alex Deucher (5): drm/amdgpu/pm: update current crtc info after setting the powerstate drm/radeon/pm: update current crtc info after setting the powerstate drm/amdgpu/cz: enable/disable vce dpm even if vce pg is disabled drm/amdgpu/powerplay/cz: enable/disable vce dpm independent of vce pg drm/amdgpu/cz: remove commented out call to enable vce pg Alexandre Courbot (2): gpu: host1x: Set DMA mask gpu: host1x: Set DMA ops on device creation Arindam Nath (1): drm/amdgpu: return from atombios_dp_get_dpcd only when error Chris Wilson (2): drm/i915: Balance assert_rpm_wakelock_held() for !IS_ENABLED(CONFIG_PM) drm/i915: Balance assert_rpm_wakelock_held() for !IS_ENABLED(CONFIG_PM) Christian König (1): drm/amdgpu: apply gfx_v8 fixes to gfx_v7 as well Chunming Zhou (1): drm/amdgpu/gfx8: specify which engine to wait before vm flush Dave Airlie (3): Merge branch 'drm-fixes-4.5' of git://people.freedesktop.org/~agd5f/linux into drm-fixes Merge tag 'drm-intel-fixes-2016-03-03' of git://anongit.freedesktop.org/drm-intel into drm-fixes Merge tag 'drm/tegra/for-4.5-rc7' of git://anongit.freedesktop.org/tegra/linux into drm-fixes Imre Deak (1): drm/i915/skl: Fix power domain suspend sequence Rex Zhu (2): drm/amd/powerplay: export AMD_PP_EVENT_COMPLETE_INIT task to amdgpu. drm/amd/powerplay: send event to notify powerplay all modules are initialized. Timothy Pearson (1): drm/ast: Fix incorrect register check for DRAM width drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 6 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_powerplay.c | 4 ++- drivers/gpu/drm/amd/amdgpu/cz_dpm.c | 7 ++--- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 13 +++++++++ drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 3 +- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 5 +++- .../drm/amd/powerplay/eventmgr/eventactionchains.c | 1 + .../drm/amd/powerplay/hwmgr/cz_clockpowergating.c | 2 +- drivers/gpu/drm/ast/ast_main.c | 2 +- drivers/gpu/drm/i915/intel_runtime_pm.c | 32 ++++++++++------------ drivers/gpu/drm/radeon/radeon_pm.c | 8 +++--- drivers/gpu/host1x/bus.c | 2 ++ drivers/gpu/host1x/dev.c | 7 +++++ drivers/gpu/host1x/dev.h | 1 + 15 files changed, 60 insertions(+), 35 deletions(-)

1 0

[PATCH net-next v3 0/4] uapi: consolidate DIV_ROUND_UP definition
by Nicolas Dichtel 04 Mar '16

04 Mar '16

The inital goal was to consolidate ethtool.h uapi header. But I took the opportunity to remove all duplicate definitions of DIV_ROUND_UP. v3: add patch #2 and #3 v2: split the patch define DIV_ROUND_UP in uapi .../drm/vmwgfx/device_include/svga3d_surfacedefs.h | 20 +++++++++++--------- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 2 +- include/linux/kernel.h | 2 +- include/uapi/linux/ethtool.h | 7 ++++++- include/uapi/linux/kernel.h | 1 + include/uapi/linux/mroute6.h | 9 ++------- 6 files changed, 22 insertions(+), 19 deletions(-) Regards, Nicolas

3 6

[drm:radeon_dp_link_train] *ERROR* clock recovery failed -bisected
by Ken Moffat 04 Mar '16

04 Mar '16

On Thu, Mar 03, 2016 at 02:38:11AM +0000, Ken Moffat wrote: > One of my machines is an A10 Kaveri desktop, with a good old VGA > connection to the monitor. I've only just started trying to boot > any 4.5 kernel on it, but with 4.5.0-rc6 and now linus's tree from a > few hours ago (4.5.0-rc6-00018-gf983cd3) I get a blank screen, with > no video signal, as soon as it tries to switch to a framebuffer. > > Comparing the logs, the first bad attempt had a couple of new error > messages, everything else in the logs looked normal - > > Mar 1 19:31:10 deluxe kernel: [ 2.543163] fbcon: radeondrmfb (fb0) is primary device > Mar 1 19:31:10 deluxe kernel: [ 2.654179] [drm:radeon_dp_link_train] *ERROR* clock recovery reached max voltage > Mar 1 19:31:10 deluxe kernel: [ 2.654181] [drm:radeon_dp_link_train] *ERROR* clock recovery failed > Mar 1 19:31:10 deluxe kernel: [ 2.677142] Console: switching to colour frame buffer device 200x56 > Mar 1 19:31:10 deluxe kernel: [ 2.680435] radeon 0000:00:01.0: fb0: radeondrmfb frame buffer device > Bisection pointed to 092c96a8ab9d1bd60ada2ed385cc364ce084180e is the first bad commit commit 092c96a8ab9d1bd60ada2ed385cc364ce084180e Author: Alex Deucher <alexander.deucher(a)amd.com> Date: Thu Dec 17 10:23:34 2015 -0500 drm/radeon: fix dp link rate selection (v2) Need to properly handle the max link rate in the dpcd. This prevents some cases where 5.4 Ghz is selected when it shouldn't be. v2: simplify logic, add array bounds check Reviewed-by: Tom St Denis <tom.stdenis(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> I have now reverted that commit from that version of linus's tree and the machine everything is back to normal. This mobo does not have a DP connector. lspci reports the graphics part is 00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Kaveri [Radeon R7 Graphics] (prog-if 00 [VGA controller]) Subsystem: Gigabyte Technology Co., Ltd Kaveri [Radeon R7 Graphics] Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PER R- INTx- Latency: 0, Cache Line Size: 64 bytes Interrupt: pin A routed to IRQ 26 Region 0: Memory at c0000000 (64-bit, prefetchable) [size=256M] Region 2: Memory at d0000000 (64-bit, prefetchable) [size=8M] Region 4: I/O ports at f000 [size=256] Region 5: Memory at feb00000 (32-bit, non-prefetchable) [size=256K] Expansion ROM at feb40000 [disabled] [size=128K] Capabilities: [48] Vendor Specific Information: Len=08 <?> Capabilities: [50] Power Management version 3 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0-,D1+,D2+,D3hot+,D3cold-) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Capabilities: [58] Express (v2) Root Complex Integrated Endpoint, MSI 00 DevCap: MaxPayload 256 bytes, PhantFunc 0 ExtTag+ RBE+ DevCtl: Report errors: Correctable- Non-Fatal- Fatal- Unsupported- RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop+ MaxPayload 128 bytes, MaxReadReq 512 bytes DevSta: CorrErr- UncorrErr- FatalErr- UnsuppReq- AuxPwr- TransPend- DevCap2: Completion Timeout: Not Supported, TimeoutDis-, LTR-, OBFF Not Supported DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis-, LTR-, OBFF Disabled Capabilities: [a0] MSI: Enable+ Count=1/1 Maskable- 64bit+ Address: 00000000fee0f00c Data: 4172 Capabilities: [100 v1] Vendor Specific Information: ID=0001 Rev=1 Len=010 <?> Capabilities: [270 v1] #19 Capabilities: [2b0 v1] Address Translation Service (ATS) ATSCap: Invalidate Queue Depth: 00 ATSCtl: Enable-, Smallest Translation Unit: 00 Capabilities: [2c0 v1] Page Request Interface (PRI) PRICtl: Enable- Reset- PRISta: RF- UPRGI- Stopped+ Page Request Capacity: 00000020, Page Request Allocation: 00000000 Capabilities: [2d0 v1] Process Address Space ID (PASID) PASIDCap: Exec- Priv-, Max PASID Width: 10 PASIDCtl: Enable- Exec- Priv- Kernel driver in use: radeon I've attached my config. Please let me know if there is anything I can do to help fix this. ĸen -- This email was written using 100% recycled letters.

3 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel March 2016