dri-devel May 2016

dri-devel@lists.freedesktop.org

212 participants
1404 discussions

[PATCH 01/14] drm/amdgpu: use drm_crtc_send_vblank_event()
by Gustavo Padovan 02 May '16

02 May '16

From: Gustavo Padovan <gustavo.padovan(a)collabora.co.uk> Replace the legacy drm_send_vblank_event() with the new helper function. Signed-off-by: Gustavo Padovan <gustavo.padovan(a)collabora.co.uk> --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c index 6de2ce53..92c5a71 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c @@ -3370,7 +3370,7 @@ static int dce_v10_0_pageflip_irq(struct amdgpu_device *adev, /* wakeup usersapce */ if (works->event) - drm_send_vblank_event(adev->ddev, crtc_id, works->event); + drm_crtc_send_vblank_event(&amdgpu_crtc->base, works->event); spin_unlock_irqrestore(&adev->ddev->event_lock, flags); diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c index e9ccc6b..2f784f2 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c @@ -3366,7 +3366,7 @@ static int dce_v11_0_pageflip_irq(struct amdgpu_device *adev, /* wakeup usersapce */ if(works->event) - drm_send_vblank_event(adev->ddev, crtc_id, works->event); + drm_crtc_send_vblank_event(&amdgpu_crtc->base, works->event); spin_unlock_irqrestore(&adev->ddev->event_lock, flags); diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c index e56b55d..9155e3b 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c @@ -3379,7 +3379,7 @@ static int dce_v8_0_pageflip_irq(struct amdgpu_device *adev, /* wakeup usersapce */ if (works->event) - drm_send_vblank_event(adev->ddev, crtc_id, works->event); + drm_crtc_send_vblank_event(&amdgpu_crtc->base, works->event); spin_unlock_irqrestore(&adev->ddev->event_lock, flags); -- 2.5.5

8 29

[Bug 95241] Please edit the radeon manpages DRI section
by bugzilla-daemon＠freedesktop.org 02 May '16

02 May '16

https://bugs.freedesktop.org/show_bug.cgi?id=95241 Bug ID: 95241 Summary: Please edit the radeon manpages DRI section Product: DRI Version: unspecified Hardware: Other OS: other Status: NEW Severity: enhancement Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: leanhack(a)gmail.com Hello there i found out the radeon manpages isn't right in DRI section: Option "DRI" "integer" Define the maximum level of DRI to enable. Valid values are 2 for DRI2 or 3 for DRI3. The default is 2 for DRI2. Following that i couln't enable DRI3, cat .local/share/xorg/Xorg.0.log | grep -i dri3 will outputs: RADEON(0): DRI3 disabled But if one sets: Option "DRI3" "1" then cat .local/share/xorg/Xorg.0.log | grep -i dri3 will outputs: RADEON(0): DRI3 enabled So i think you should edit the manpages like so: Option "DRI3" "1" To enable DRI3 support... Thanks to all of you -- You are receiving this mail because: You are the assignee for the bug.

1 1

[CI-resend] drm: Restore double clflush on the last partial cacheline
by Chris Wilson 02 May '16

02 May '16

This effectively reverts commit afcd950cafea6e27b739fe7772cbbeed37d05b8b Author: Chris Wilson <chris(a)chris-wilson.co.uk> Date: Wed Jun 10 15:58:01 2015 +0100 drm: Avoid the double clflush on the last cache line in drm_clflush_virt_range() as we have observed issues with serialisation of the clflush operations on Baytrail+ Atoms with partial updates. Applying the double flush on the last cacheline forces that clflush to be ordered with respect to the previous clflush, and the mfence then protects against prefetches crossing the clflush boundary. The same issue can be demonstrated in userspace with igt/gem_exec_flush. Fixes: afcd950cafea6 (drm: Avoid the double clflush on the last cache...) Testcase: igt/gem_concurrent_blit Testcase: igt/gem_partial_pread_pwrite Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92845 Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: dri-devel(a)lists.freedesktop.org Cc: Akash Goel <akash.goel(a)intel.com> Cc: Imre Deak <imre.deak(a)intel.com> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Cc: Jason Ekstrand <jason.ekstrand(a)intel.com> Cc: stable(a)vger.kernel.org Reviewed-by: Mika Kuoppala <mika.kuoppala(a)intel.com> --- Just a quick resend to test this patch against BAT with the new gem_exec_flush test cases. -Chris --- drivers/gpu/drm/drm_cache.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c index 6743ff7dccfa..7f4a6c550319 100644 --- a/drivers/gpu/drm/drm_cache.c +++ b/drivers/gpu/drm/drm_cache.c @@ -136,6 +136,7 @@ drm_clflush_virt_range(void *addr, unsigned long length) mb(); for (; addr < end; addr += size) clflushopt(addr); + clflushopt(end - 1); /* force serialisation */ mb(); return; } -- 2.8.1

1 0

[PATCH] drm/amdgpu: use drm_mode_vrefresh() rather than mode->vrefresh
by Alex Deucher 02 May '16

02 May '16

This is a port of radeon commit: 3d2d98ee1af0cf6eebfbd6bff4c17d3601ac1284 drm/radeon: use drm_mode_vrefresh() rather than mode->vrefresh to amdgpu. Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Cc: stable(a)vger.kernel.org --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c index 7b7f4ab..fe36caf 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c @@ -150,7 +150,7 @@ u32 amdgpu_dpm_get_vrefresh(struct amdgpu_device *adev) list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) { amdgpu_crtc = to_amdgpu_crtc(crtc); if (crtc->enabled && amdgpu_crtc->enabled && amdgpu_crtc->hw_mode.clock) { - vrefresh = amdgpu_crtc->hw_mode.vrefresh; + vrefresh = drm_mode_vrefresh(&amdgpu_crtc->hw_mode); break; } } -- 2.5.5

1 0

[PATCH 00/13] staging/android: clean up SW_SYNC
by Gustavo Padovan 02 May '16

02 May '16

From: Gustavo Padovan <gustavo.padovan(a)collabora.co.uk> Hi, The following patches do a clean up on the sw_sync inteface. It starts by removing struct sync_timeline_ops, which was creating unecessary wrappers in the code and the start to organize the sync_timeline and sw_sync code better. sw_sync interface was moved to sw_sync.c along with sync_timeline - which is now internal to sw_sync. The next step after this work is the actual de-stage of SW_SYNC and the upstreaming of selftests for sw_sync and sync_file. Please review! Gustavo --- Gustavo Padovan (13): staging/android: store last signaled value on sync timeline staging/android: remove .{fence,timeline}_value_str() from timeline_ops staging/android: remove struct sync_timeline_ops staging/android: remove sw_sync_timeline and sw_sync_pt staging/android: remove sw_sync.[ch] files staging/android: rename android_fence to timeline_fence staging/android: remove unnecessary check for fence staging/android: remove size arg of sync_timeline_create() staging/android: bring struct sync_pt back staging/android: move sw_sync related code to sw_sync.c staging/android: clean up #includes in the sync framework staging/android: make sync_timeline internal to sw_sync staging/android: make sw_ioctl info internal to sw_sync.c drivers/staging/android/Kconfig | 16 +- drivers/staging/android/Makefile | 3 +- drivers/staging/android/sw_sync.c | 355 +++++++++++++++++++++++++++++---- drivers/staging/android/sw_sync.h | 59 ------ drivers/staging/android/sync.c | 221 -------------------- drivers/staging/android/sync.h | 95 ++------- drivers/staging/android/sync_debug.c | 152 +------------- drivers/staging/android/trace/sync.h | 12 +- drivers/staging/android/uapi/sw_sync.h | 32 --- include/linux/fence.h | 2 - 10 files changed, 350 insertions(+), 597 deletions(-) delete mode 100644 drivers/staging/android/sw_sync.h delete mode 100644 drivers/staging/android/sync.c delete mode 100644 drivers/staging/android/uapi/sw_sync.h -- 2.5.5

1 13

[RESEND PATCH v4 0/4] Add ANX7814 I2C bridge driver
by Enric Balletbo i Serra 02 May '16

02 May '16

Hi all, This is the fourth version of the patch, thanks to all that did some comments. In this version I basically added the comments made by Thierry, also it introduces a new patch in the series to add a new helper constant in drm_dp_helper.h. The devicetree binding also suffered a slight modification, one gpio is modelled as a regulator now, for that reason, I removed the ack from Rob, so please if you're ok with the change ack again. This patch set to introduces the anx7814 slimport transmitter driver. These new series will replace the old series that can be found here [1]. The reason why I introduce these new series is because the driver changed significantly. The old approach used a polled state machine ans was not really well using the kernel mode setting API. With this new driver I tried to use better the drm API and use an interrupt driven model. Waiting for new comments ... Changes since v3: - Introduce new patch to define the DP_PERCENT_DOWNSPREAD_0_5 constant needed by the driver. - Thierry Reding: - Add vendor name on symbols and files - Remove <linux/async.h> include - Improve anx78xx_aux_wait code (remove atomic case) - Fix msg->reply handling - Capitalize HPD/HDMI/DP - Don't return -EAGAIN on link training - Use symbolic constants defined instead of magic numbers - Move connector_to_anx78xx after the anx78xx declaration - Improve some coding style - Give the first parameter the proper name (irq) - Leave out the tab-padding in anx78xx_bridge_funcs - Put bridge_to_anx78xx together with the connector cast function. - The structure name should start in the first column - Remove messages for connector status changes - Free the EDID on unplug instead of on plug event - Use unsigned int for i in for loops. - Model v10 as regulator. - Remove the use of OR'ed errors - Simply pass adjusted_mode in bridge mode set. - Remove bridge_enable/disable mutex protection, not needed. - There's no need to set ->edid to NULL when remove the driver. Changes since v2: - Add Acked-by: Rob Herring <robh(a)kernel.org> for patch 0002 - Add Tested-by: Nicolas Boichat <drinkcat(a)chromium.org> - Add Reviewed-by: Nicolas Boichat <drinkcat(a)chromium.org> - Nicolas Boichat: - Get rid of wait_for macro since is only used once. - Do not replace the error code if it's readily available to you. Changes since v1: - Add Acked-by: Rob Herring <robh(a)kernel.org> for patch 0001 - Dan Carpenter: - Fix missing error code - Use meaningful names for goto exit paths - Rob Herring: - Rename cable-det-gpios for hpd-gpios as is more standard - Fix HDMI output for HDMI input - Use hpd instead cable_det as is the more standard name. - Daniel Kurtz: - Use regmap_bulk in aux_transfer - Fix gpio reset polarity. - Turn off v10 last so we mirror poweron sequence - Fix some error paths. - Remove mutex in anx78xx_detect - kbuild: - WARNING: PTR_ERR_OR_ZERO can be used [1] https://lwn.net/Articles/666885/ Enric Balletbo i Serra (4): drm/dp: Add define to set 0.5% down-spread in MAX_DOWNSPREAD register. of: Add vendor prefix for Analogix Semiconductor devicetree: Add ANX7814 SlimPort transmitter binding. drm: bridge: anx78xx: Add anx78xx driver support. .../devicetree/bindings/vendor-prefixes.txt | 1 + .../devicetree/bindings/video/bridge/anx7814.txt | 40 + drivers/gpu/drm/bridge/Kconfig | 10 + drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge/analogix-anx78xx.c | 1499 ++++++++++++++++++++ drivers/gpu/drm/bridge/analogix-anx78xx.h | 719 ++++++++++ include/drm/drm_dp_helper.h | 1 + 7 files changed, 2271 insertions(+) create mode 100644 Documentation/devicetree/bindings/video/bridge/anx7814.txt create mode 100644 drivers/gpu/drm/bridge/analogix-anx78xx.c create mode 100644 drivers/gpu/drm/bridge/analogix-anx78xx.h -- 2.1.0

3 6

[Bug 95017] [drm:radeon_ib_ring_tests] *ERROR* radeon: failed testing IB on GFX ring (-35).
by bugzilla-daemon＠freedesktop.org 02 May '16

02 May '16

https://bugs.freedesktop.org/show_bug.cgi?id=95017 --- Comment #9 from Ilia Mirkin <imirkin(a)alum.mit.edu> --- (In reply to Mathieu Malaterre from comment #8) > (In reply to Ilia Mirkin from comment #7) > > FWIW on nouveau we just default agpmode=0 in a #ifdef __powerpc__. Perhaps > > the same thing can work for radeon. > > Well radeon_agpmode is already set to 0 already[*]. My patch force to > PCI(-1) when user did not specify any value. > > [*]https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/radeon/ > radeon_drv.c#L173 Oh, the logic is flipped from nouveau... on nouveau, -1 == autodetect and 0 == no agp. So in your case, just set it to -1 instead of 0 for powerpc. i.e. #ifdef __powerpc__ int radeon_agpmode = -1; #else int radeon_agpmode = 0; #endif or something similar. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 95017] [drm:radeon_ib_ring_tests] *ERROR* radeon: failed testing IB on GFX ring (-35).
by bugzilla-daemon＠freedesktop.org 02 May '16

02 May '16

https://bugs.freedesktop.org/show_bug.cgi?id=95017 --- Comment #8 from Mathieu Malaterre <mathieu.malaterre(a)gmail.com> --- (In reply to Ilia Mirkin from comment #7) > FWIW on nouveau we just default agpmode=0 in a #ifdef __powerpc__. Perhaps > the same thing can work for radeon. Well radeon_agpmode is already set to 0 already[*]. My patch force to PCI(-1) when user did not specify any value. [*]https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/radeon/radeon_drv.c#L173 -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 95017] [drm:radeon_ib_ring_tests] *ERROR* radeon: failed testing IB on GFX ring (-35).
by bugzilla-daemon＠freedesktop.org 02 May '16

02 May '16

https://bugs.freedesktop.org/show_bug.cgi?id=95017 --- Comment #7 from Ilia Mirkin <imirkin(a)alum.mit.edu> --- FWIW on nouveau we just default agpmode=0 in a #ifdef __powerpc__. Perhaps the same thing can work for radeon. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] drm/amdgpu: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
by Muhammad Falak R Wani 02 May '16

02 May '16

The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structre. It is always safe to use RCU_INIT_POINTER() to NULL a pointer, instead of rcu_assign_pointer(). This results in slightly smaller/faster code. The following semantic patch was used: <smpl> @@ @@ - rcu_assign_pointer + RCU_INIT_POINTER (..., NULL) </smpl> Signed-off-by: Muhammad Falak R Wani <falakreyaz(a)gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c index d81f1f4..4500ff1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c @@ -198,7 +198,7 @@ void amdgpu_fence_process(struct amdgpu_ring *ring) /* There is always exactly one thread signaling this fence slot */ fence = rcu_dereference_protected(*ptr, 1); - rcu_assign_pointer(*ptr, NULL); + RCU_INIT_POINTER(*ptr, NULL); BUG_ON(!fence); -- 1.9.1

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2016