dri-devel June 2016

dri-devel@lists.freedesktop.org

231 participants
1446 discussions

[radeon-alex:amd-staging-4.6 396/989] drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/tonga_hwmgr.c:102:22: error: 'PP_ClockStretchAmountConversion' defined but not used
by kbuild test robot 15 Jun '16

15 Jun '16

tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-4.6 head: beebb009c05fd5a89617327a9cfb724f19cecf1b commit: 4ffed2cbfe6b56df802236a5b5671dd89ba23308 [396/989] drm/amd/dal: Treat warnings as errors config: x86_64-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 reproduce: git checkout 4ffed2cbfe6b56df802236a5b5671dd89ba23308 # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): >> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/tonga_hwmgr.c:102:22: error: 'PP_ClockStretchAmountConversion' defined but not used [-Werror=unused-const-variable=] static const uint8_t PP_ClockStretchAmountConversion[2][6] = { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/tonga_hwmgr.c:97:23: error: 'PP_ClockStretcherDDTTable' defined but not used [-Werror=unused-const-variable=] static const uint32_t PP_ClockStretcherDDTTable[2][4][4] = { ^~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/tonga_hwmgr.c:92:23: error: 'PP_ClockStretcherLookupTable' defined but not used [-Werror=unused-const-variable=] static const uint16_t PP_ClockStretcherLookupTable[2][4] = { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors vim +/PP_ClockStretchAmountConversion +102 drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/tonga_hwmgr.c c82baa28 yanyang1 2015-08-18 86 #define MC_SEQ_MISC0_GDDR5_MASK 0xf0000000 c82baa28 yanyang1 2015-08-18 87 #define MC_SEQ_MISC0_GDDR5_VALUE 5 c82baa28 yanyang1 2015-08-18 88 c82baa28 yanyang1 2015-08-18 89 typedef uint32_t PECI_RegistryValue; c82baa28 yanyang1 2015-08-18 90 c82baa28 yanyang1 2015-08-18 91 /* [2.5%,~2.5%] Clock stretched is multiple of 2.5% vs not and [Fmin, Fmax, LDO_REFSEL, USE_FOR_LOW_FREQ] */ 426d506e Nils Wallménius 2016-04-10 @92 static const uint16_t PP_ClockStretcherLookupTable[2][4] = { c82baa28 yanyang1 2015-08-18 93 {600, 1050, 3, 0}, c82baa28 yanyang1 2015-08-18 94 {600, 1050, 6, 1} }; c82baa28 yanyang1 2015-08-18 95 c82baa28 yanyang1 2015-08-18 96 /* [FF, SS] type, [] 4 voltage ranges, and [Floor Freq, Boundary Freq, VID min , VID max] */ 426d506e Nils Wallménius 2016-04-10 @97 static const uint32_t PP_ClockStretcherDDTTable[2][4][4] = { c82baa28 yanyang1 2015-08-18 98 { {265, 529, 120, 128}, {325, 650, 96, 119}, {430, 860, 32, 95}, {0, 0, 0, 31} }, c82baa28 yanyang1 2015-08-18 99 { {275, 550, 104, 112}, {319, 638, 96, 103}, {360, 720, 64, 95}, {384, 768, 32, 63} } }; c82baa28 yanyang1 2015-08-18 100 c82baa28 yanyang1 2015-08-18 101 /* [Use_For_Low_freq] value, [0%, 5%, 10%, 7.14%, 14.28%, 20%] (coming from PWR_CKS_CNTL.stretch_amount reg spec) */ 426d506e Nils Wallménius 2016-04-10 @102 static const uint8_t PP_ClockStretchAmountConversion[2][6] = { c82baa28 yanyang1 2015-08-18 103 {0, 1, 3, 2, 4, 5}, c82baa28 yanyang1 2015-08-18 104 {0, 2, 4, 5, 6, 5} }; c82baa28 yanyang1 2015-08-18 105 :::::: The code at line 102 was first introduced by commit :::::: 426d506e17afc5a07b44e6ca8098b54ea4cc566c drm/amd: Mark some tables as const :::::: TO: Nils Wallménius <nils.wallmenius(a)gmail.com> :::::: CC: Alex Deucher <alexander.deucher(a)amd.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

Re: [PATCH v7 00/12] Support non-lru page migration
by Minchan Kim 15 Jun '16

15 Jun '16

Hi Sergey, On Wed, Jun 15, 2016 at 04:59:09PM +0900, Sergey Senozhatsky wrote: > Hello Minchan, > > -next 4.7.0-rc3-next-20160614 > > > [ 315.146533] kasan: CONFIG_KASAN_INLINE enabled > [ 315.146538] kasan: GPF could be caused by NULL-ptr deref or user memory access > [ 315.146546] general protection fault: 0000 [#1] PREEMPT SMP KASAN > [ 315.146576] Modules linked in: lzo zram zsmalloc mousedev coretemp hwmon crc32c_intel r8169 i2c_i801 mii snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec snd_hda_core acpi_cpufreq snd_pcm snd_timer snd soundcore lpc_ich mfd_core processor sch_fq_codel sd_mod hid_generic usbhid hid ahci libahci libata ehci_pci ehci_hcd scsi_mod usbcore usb_common > [ 315.146785] CPU: 3 PID: 38 Comm: khugepaged Not tainted 4.7.0-rc3-next-20160614-dbg-00004-ga1c2cbc-dirty #488 > [ 315.146841] task: ffff8800bfaf2900 ti: ffff880112468000 task.ti: ffff880112468000 > [ 315.146859] RIP: 0010:[<ffffffffa02c413d>] [<ffffffffa02c413d>] zs_page_migrate+0x355/0xaa0 [zsmalloc] Thanks for the report! zs_page_migrate+0x355? Could you tell me what line is it? It seems to be related to obj_to_head. Could you test with [zsmalloc: keep first object offset in struct page] in mmotm? > [ 315.146892] RSP: 0000:ffff88011246f138 EFLAGS: 00010293 > [ 315.146906] RAX: 736761742d6f6e2c RBX: ffff880017ad9a80 RCX: 0000000000000000 > [ 315.146924] RDX: 1ffffffff064d704 RSI: ffff88000511469a RDI: ffffffff8326ba20 > [ 315.146942] RBP: ffff88011246f328 R08: 0000000000000001 R09: 0000000000000000 > [ 315.146959] R10: ffff88011246f0a8 R11: ffff8800bfc07fff R12: ffff88011246f300 > [ 315.146977] R13: ffffed0015523e6f R14: ffff8800aa91f378 R15: ffffea0000144500 > [ 315.146995] FS: 0000000000000000(0000) GS:ffff880113780000(0000) knlGS:0000000000000000 > [ 315.147015] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 315.147030] CR2: 00007f3f97911000 CR3: 0000000002209000 CR4: 00000000000006e0 > [ 315.147046] Stack: > [ 315.147052] 1ffff10015523e0f ffff88011246f240 ffff880005116800 00017f80e0000000 > [ 315.147083] ffff880017ad9aa8 736761742d6f6e2c 1ffff1002248de34 ffff880017ad9a90 > [ 315.147113] 0000069a1246f660 000000000000069a ffff880005114000 ffffea0002ff0180 > [ 315.147143] Call Trace: > [ 315.147154] [<ffffffffa02c3de8>] ? obj_to_head+0x9d/0x9d [zsmalloc] > [ 315.147175] [<ffffffff81d31dbc>] ? _raw_spin_unlock_irqrestore+0x47/0x5c > [ 315.147195] [<ffffffff812275b1>] ? isolate_freepages_block+0x2f9/0x5a6 > [ 315.147213] [<ffffffff8127f15c>] ? kasan_poison_shadow+0x2f/0x31 > [ 315.147230] [<ffffffff8127f66a>] ? kasan_alloc_pages+0x39/0x3b > [ 315.147246] [<ffffffff812267e6>] ? map_pages+0x1f3/0x3ad > [ 315.147262] [<ffffffff812265f3>] ? update_pageblock_skip+0x18d/0x18d > [ 315.147280] [<ffffffff81115972>] ? up_read+0x1a/0x30 > [ 315.147296] [<ffffffff8111ec7e>] ? debug_check_no_locks_freed+0x150/0x22b > [ 315.147315] [<ffffffff812842d1>] move_to_new_page+0x4dd/0x615 > [ 315.147332] [<ffffffff81283df4>] ? migrate_page+0x75/0x75 > [ 315.147347] [<ffffffff8122785e>] ? isolate_freepages_block+0x5a6/0x5a6 > [ 315.147366] [<ffffffff812851c1>] migrate_pages+0xadd/0x131a > [ 315.147382] [<ffffffff8122785e>] ? isolate_freepages_block+0x5a6/0x5a6 > [ 315.147399] [<ffffffff81226375>] ? kzfree+0x2b/0x2b > [ 315.147414] [<ffffffff812846e4>] ? buffer_migrate_page+0x2db/0x2db > [ 315.147431] [<ffffffff8122a6cf>] compact_zone+0xcdb/0x1155 > [ 315.147448] [<ffffffff812299f4>] ? compaction_suitable+0x76/0x76 > [ 315.147465] [<ffffffff8122ac29>] compact_zone_order+0xe0/0x167 > [ 315.147481] [<ffffffff8111f0ac>] ? debug_show_all_locks+0x226/0x226 > [ 315.147499] [<ffffffff8122ab49>] ? compact_zone+0x1155/0x1155 > [ 315.147515] [<ffffffff810d58d1>] ? finish_task_switch+0x3de/0x484 > [ 315.147533] [<ffffffff8122bcff>] try_to_compact_pages+0x2f1/0x648 > [ 315.147550] [<ffffffff8122bcff>] ? try_to_compact_pages+0x2f1/0x648 > [ 315.147568] [<ffffffff8122ba0e>] ? compaction_zonelist_suitable+0x3a6/0x3a6 > [ 315.147589] [<ffffffff811ee129>] ? get_page_from_freelist+0x2c0/0x129a > [ 315.147608] [<ffffffff811ef1ed>] __alloc_pages_direct_compact+0xea/0x30d > [ 315.147626] [<ffffffff811ef103>] ? get_page_from_freelist+0x129a/0x129a > [ 315.147645] [<ffffffff811f0422>] __alloc_pages_nodemask+0x840/0x16b6 > [ 315.147663] [<ffffffff810dba27>] ? try_to_wake_up+0x696/0x6c8 > [ 315.149147] [<ffffffff811efbe2>] ? warn_alloc_failed+0x226/0x226 > [ 315.150615] [<ffffffff810dba69>] ? wake_up_process+0x10/0x12 > [ 315.152078] [<ffffffff810dbaf4>] ? wake_up_q+0x89/0xa7 > [ 315.153539] [<ffffffff81128b6f>] ? rwsem_wake+0x131/0x15c > [ 315.155007] [<ffffffff812922e7>] ? khugepaged+0x4072/0x484f > [ 315.156471] [<ffffffff8128e449>] khugepaged+0x1d4/0x484f > [ 315.157940] [<ffffffff8128e275>] ? hugepage_vma_revalidate+0xef/0xef > [ 315.159402] [<ffffffff810d58d1>] ? finish_task_switch+0x3de/0x484 > [ 315.160870] [<ffffffff81d31df8>] ? _raw_spin_unlock_irq+0x27/0x45 > [ 315.162341] [<ffffffff8111cde6>] ? trace_hardirqs_on_caller+0x3d2/0x492 > [ 315.163814] [<ffffffff8111112e>] ? prepare_to_wait_event+0x3f7/0x3f7 > [ 315.165295] [<ffffffff81d27ad5>] ? __schedule+0xa4d/0xd16 > [ 315.166763] [<ffffffff810ccde3>] kthread+0x252/0x261 > [ 315.168214] [<ffffffff8128e275>] ? hugepage_vma_revalidate+0xef/0xef > [ 315.169646] [<ffffffff810ccb91>] ? kthread_create_on_node+0x377/0x377 > [ 315.171056] [<ffffffff81d3277f>] ret_from_fork+0x1f/0x40 > [ 315.172462] [<ffffffff810ccb91>] ? kthread_create_on_node+0x377/0x377 > [ 315.173869] Code: 03 b5 60 fe ff ff e8 2e fc ff ff a8 01 74 4c 48 83 e0 fe bf 01 00 00 00 48 89 85 38 fe ff ff e8 41 18 e1 e0 48 8b 85 38 fe ff ff <f0> 0f ba 28 00 73 29 bf 01 00 00 00 41 bc f5 ff ff ff e8 ea 27 > [ 315.175573] RIP [<ffffffffa02c413d>] zs_page_migrate+0x355/0xaa0 [zsmalloc] > [ 315.177084] RSP <ffff88011246f138> > [ 315.186572] ---[ end trace 0962b8ee48c98bbc ]--- > > > > > [ 315.186577] BUG: sleeping function called from invalid context at include/linux/sched.h:2960 > [ 315.186580] in_atomic(): 1, irqs_disabled(): 0, pid: 38, name: khugepaged > [ 315.186581] INFO: lockdep is turned off. > [ 315.186583] Preemption disabled at:[<ffffffffa02c3f1d>] zs_page_migrate+0x135/0xaa0 [zsmalloc] > > [ 315.186594] CPU: 3 PID: 38 Comm: khugepaged Tainted: G D 4.7.0-rc3-next-20160614-dbg-00004-ga1c2cbc-dirty #488 > [ 315.186599] 0000000000000000 ffff88011246ed58 ffffffff814d56bf ffff8800bfaf2900 > [ 315.186604] 0000000000000004 ffff88011246ed98 ffffffff810d5e6a 0000000000000000 > [ 315.186609] ffff8800bfaf2900 ffffffff81e39820 0000000000000b90 0000000000000000 > [ 315.186614] Call Trace: > [ 315.186618] [<ffffffff814d56bf>] dump_stack+0x68/0x92 > [ 315.186622] [<ffffffff810d5e6a>] ___might_sleep+0x3bd/0x3c9 > [ 315.186625] [<ffffffff810d5fd1>] __might_sleep+0x15b/0x167 > [ 315.186630] [<ffffffff810ac4c1>] exit_signals+0x7a/0x34f > [ 315.186633] [<ffffffff810ac447>] ? get_signal+0xd9b/0xd9b > [ 315.186636] [<ffffffff811aee21>] ? irq_work_queue+0x101/0x11c > [ 315.186640] [<ffffffff8111f0ac>] ? debug_show_all_locks+0x226/0x226 > [ 315.186645] [<ffffffff81096357>] do_exit+0x34d/0x1b4e > [ 315.186648] [<ffffffff81130e16>] ? vprintk_emit+0x4b1/0x4d3 > [ 315.186652] [<ffffffff8109600a>] ? is_current_pgrp_orphaned+0x8c/0x8c > [ 315.186655] [<ffffffff81122c56>] ? lock_acquire+0xec/0x147 > [ 315.186658] [<ffffffff811321ef>] ? kmsg_dump+0x12/0x27a > [ 315.186662] [<ffffffff81132448>] ? kmsg_dump+0x26b/0x27a > [ 315.186666] [<ffffffff81036507>] oops_end+0x9d/0xa4 > [ 315.186669] [<ffffffff8103662c>] die+0x55/0x5e > [ 315.186672] [<ffffffff81032aa0>] do_general_protection+0x16c/0x337 > [ 315.186676] [<ffffffff81d33abf>] general_protection+0x1f/0x30 > [ 315.186681] [<ffffffffa02c413d>] ? zs_page_migrate+0x355/0xaa0 [zsmalloc] > [ 315.186686] [<ffffffffa02c4136>] ? zs_page_migrate+0x34e/0xaa0 [zsmalloc] > [ 315.186691] [<ffffffffa02c3de8>] ? obj_to_head+0x9d/0x9d [zsmalloc] > [ 315.186695] [<ffffffff81d31dbc>] ? _raw_spin_unlock_irqrestore+0x47/0x5c > [ 315.186699] [<ffffffff812275b1>] ? isolate_freepages_block+0x2f9/0x5a6 > [ 315.186702] [<ffffffff8127f15c>] ? kasan_poison_shadow+0x2f/0x31 > [ 315.186706] [<ffffffff8127f66a>] ? kasan_alloc_pages+0x39/0x3b > [ 315.186709] [<ffffffff812267e6>] ? map_pages+0x1f3/0x3ad > [ 315.186712] [<ffffffff812265f3>] ? update_pageblock_skip+0x18d/0x18d > [ 315.186716] [<ffffffff81115972>] ? up_read+0x1a/0x30 > [ 315.186719] [<ffffffff8111ec7e>] ? debug_check_no_locks_freed+0x150/0x22b > [ 315.186723] [<ffffffff812842d1>] move_to_new_page+0x4dd/0x615 > [ 315.186726] [<ffffffff81283df4>] ? migrate_page+0x75/0x75 > [ 315.186730] [<ffffffff8122785e>] ? isolate_freepages_block+0x5a6/0x5a6 > [ 315.186733] [<ffffffff812851c1>] migrate_pages+0xadd/0x131a > [ 315.186737] [<ffffffff8122785e>] ? isolate_freepages_block+0x5a6/0x5a6 > [ 315.186740] [<ffffffff81226375>] ? kzfree+0x2b/0x2b > [ 315.186743] [<ffffffff812846e4>] ? buffer_migrate_page+0x2db/0x2db > [ 315.186747] [<ffffffff8122a6cf>] compact_zone+0xcdb/0x1155 > [ 315.186751] [<ffffffff812299f4>] ? compaction_suitable+0x76/0x76 > [ 315.186754] [<ffffffff8122ac29>] compact_zone_order+0xe0/0x167 > [ 315.186757] [<ffffffff8111f0ac>] ? debug_show_all_locks+0x226/0x226 > [ 315.186761] [<ffffffff8122ab49>] ? compact_zone+0x1155/0x1155 > [ 315.186764] [<ffffffff810d58d1>] ? finish_task_switch+0x3de/0x484 > [ 315.186768] [<ffffffff8122bcff>] try_to_compact_pages+0x2f1/0x648 > [ 315.186771] [<ffffffff8122bcff>] ? try_to_compact_pages+0x2f1/0x648 > [ 315.186775] [<ffffffff8122ba0e>] ? compaction_zonelist_suitable+0x3a6/0x3a6 > [ 315.186780] [<ffffffff811ee129>] ? get_page_from_freelist+0x2c0/0x129a > [ 315.186783] [<ffffffff811ef1ed>] __alloc_pages_direct_compact+0xea/0x30d > [ 315.186787] [<ffffffff811ef103>] ? get_page_from_freelist+0x129a/0x129a > [ 315.186791] [<ffffffff811f0422>] __alloc_pages_nodemask+0x840/0x16b6 > [ 315.186794] [<ffffffff810dba27>] ? try_to_wake_up+0x696/0x6c8 > [ 315.186798] [<ffffffff811efbe2>] ? warn_alloc_failed+0x226/0x226 > [ 315.186801] [<ffffffff810dba69>] ? wake_up_process+0x10/0x12 > [ 315.186804] [<ffffffff810dbaf4>] ? wake_up_q+0x89/0xa7 > [ 315.186807] [<ffffffff81128b6f>] ? rwsem_wake+0x131/0x15c > [ 315.186811] [<ffffffff812922e7>] ? khugepaged+0x4072/0x484f > [ 315.186815] [<ffffffff8128e449>] khugepaged+0x1d4/0x484f > [ 315.186819] [<ffffffff8128e275>] ? hugepage_vma_revalidate+0xef/0xef > [ 315.186822] [<ffffffff810d58d1>] ? finish_task_switch+0x3de/0x484 > [ 315.186826] [<ffffffff81d31df8>] ? _raw_spin_unlock_irq+0x27/0x45 > [ 315.186829] [<ffffffff8111cde6>] ? trace_hardirqs_on_caller+0x3d2/0x492 > [ 315.186832] [<ffffffff8111112e>] ? prepare_to_wait_event+0x3f7/0x3f7 > [ 315.186836] [<ffffffff81d27ad5>] ? __schedule+0xa4d/0xd16 > [ 315.186840] [<ffffffff810ccde3>] kthread+0x252/0x261 > [ 315.186843] [<ffffffff8128e275>] ? hugepage_vma_revalidate+0xef/0xef > [ 315.186846] [<ffffffff810ccb91>] ? kthread_create_on_node+0x377/0x377 > [ 315.186851] [<ffffffff81d3277f>] ret_from_fork+0x1f/0x40 > [ 315.186854] [<ffffffff810ccb91>] ? kthread_create_on_node+0x377/0x377 > [ 315.186869] note: khugepaged[38] exited with preempt_count 4 > > > > [ 340.319852] NMI watchdog: BUG: soft lockup - CPU#2 stuck for 22s! [jbd2/zram0-8:405] > [ 340.319856] Modules linked in: lzo zram zsmalloc mousedev coretemp hwmon crc32c_intel r8169 i2c_i801 mii snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec snd_hda_core acpi_cpufreq snd_pcm snd_timer snd soundcore lpc_ich mfd_core processor sch_fq_codel sd_mod hid_generic usbhid hid ahci libahci libata ehci_pci ehci_hcd scsi_mod usbcore usb_common > [ 340.319900] irq event stamp: 834296 > [ 340.319902] hardirqs last enabled at (834295): [<ffffffff81280b07>] quarantine_put+0xa1/0xe6 > [ 340.319911] hardirqs last disabled at (834296): [<ffffffff81d31e68>] _raw_write_lock_irqsave+0x13/0x4c > [ 340.319917] softirqs last enabled at (833836): [<ffffffff81d3455e>] __do_softirq+0x406/0x48f > [ 340.319922] softirqs last disabled at (833831): [<ffffffff8109914a>] irq_exit+0x6a/0x113 > [ 340.319929] CPU: 2 PID: 405 Comm: jbd2/zram0-8 Tainted: G D 4.7.0-rc3-next-20160614-dbg-00004-ga1c2cbc-dirty #488 > [ 340.319935] task: ffff8800bb512900 ti: ffff8800a69c0000 task.ti: ffff8800a69c0000 > [ 340.319937] RIP: 0010:[<ffffffff814ed772>] [<ffffffff814ed772>] delay_tsc+0x0/0xa4 > [ 340.319943] RSP: 0018:ffff8800a69c70f8 EFLAGS: 00000206 > [ 340.319945] RAX: 0000000000000001 RBX: ffff8800aa91f300 RCX: 0000000000000000 > [ 340.319947] RDX: 0000000000000003 RSI: ffffffff81ed2840 RDI: 0000000000000001 > [ 340.319949] RBP: ffff8800a69c7100 R08: 0000000000000001 R09: 0000000000000000 > [ 340.319951] R10: ffff8800a69c70e8 R11: 000000007e7516b9 R12: ffff8800aa91f310 > [ 340.319954] R13: ffff8800aa91f308 R14: 000000001f3306fa R15: 0000000000000000 > [ 340.319956] FS: 0000000000000000(0000) GS:ffff880113700000(0000) knlGS:0000000000000000 > [ 340.319959] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 340.319961] CR2: 00007fc99caba080 CR3: 00000000b9796000 CR4: 00000000000006e0 > [ 340.319963] Stack: > [ 340.319964] ffffffff814ed89c ffff8800a69c7148 ffffffff8112795d ffffed0015523e60 > [ 340.319970] 000000009e857390 ffff8800aa91f300 ffff8800bbe21cc0 ffff8800047d6f80 > [ 340.319975] ffff8800a69c72b0 ffff8800aa91f300 ffff8800a69c7168 ffffffff81d31bed > [ 340.319980] Call Trace: > [ 340.319983] [<ffffffff814ed89c>] ? __delay+0xa/0xc > [ 340.319988] [<ffffffff8112795d>] do_raw_spin_lock+0x197/0x257 > [ 340.319991] [<ffffffff81d31bed>] _raw_spin_lock+0x35/0x3c > [ 340.319998] [<ffffffffa02c6062>] ? zs_free+0x191/0x27a [zsmalloc] > [ 340.320003] [<ffffffffa02c6062>] zs_free+0x191/0x27a [zsmalloc] > [ 340.320008] [<ffffffffa02c5ed1>] ? free_zspage+0xe8/0xe8 [zsmalloc] > [ 340.320012] [<ffffffff810d58d1>] ? finish_task_switch+0x3de/0x484 > [ 340.320015] [<ffffffff810d58a6>] ? finish_task_switch+0x3b3/0x484 > [ 340.320021] [<ffffffff81d27ad5>] ? __schedule+0xa4d/0xd16 > [ 340.320024] [<ffffffff81d28086>] ? preempt_schedule+0x1f/0x21 > [ 340.320028] [<ffffffff81d27ff9>] ? preempt_schedule_common+0xb7/0xe8 > [ 340.320034] [<ffffffffa02d3f0e>] zram_free_page+0x112/0x1f6 [zram] > [ 340.320039] [<ffffffffa02d5e6c>] zram_make_request+0x45d/0x89f [zram] > [ 340.320045] [<ffffffffa02d5a0f>] ? zram_rw_page+0x21d/0x21d [zram] > [ 340.320048] [<ffffffff81493657>] ? blk_exit_rl+0x39/0x39 > [ 340.320053] [<ffffffff8148fe3f>] ? handle_bad_sector+0x192/0x192 > [ 340.320056] [<ffffffff8127f83e>] ? kasan_slab_alloc+0x12/0x14 > [ 340.320059] [<ffffffff8127ca68>] ? kmem_cache_alloc+0xf3/0x101 > [ 340.320062] [<ffffffff81494e37>] generic_make_request+0x2bc/0x496 > [ 340.320066] [<ffffffff81494b7b>] ? blk_plug_queued_count+0x103/0x103 > [ 340.320069] [<ffffffff8111ec7e>] ? debug_check_no_locks_freed+0x150/0x22b > [ 340.320072] [<ffffffff81495309>] submit_bio+0x2f8/0x324 > [ 340.320075] [<ffffffff81495011>] ? generic_make_request+0x496/0x496 > [ 340.320078] [<ffffffff811190fc>] ? lockdep_init_map+0x1ef/0x4b0 > [ 340.320082] [<ffffffff814880a4>] submit_bio_wait+0xff/0x138 > [ 340.320085] [<ffffffff81487fa5>] ? bio_add_page+0x292/0x292 > [ 340.320090] [<ffffffff814ab82c>] blkdev_issue_discard+0xee/0x148 > [ 340.320093] [<ffffffff814ab73e>] ? __blkdev_issue_discard+0x399/0x399 > [ 340.320097] [<ffffffff8111f0ac>] ? debug_show_all_locks+0x226/0x226 > [ 340.320101] [<ffffffff81404de8>] ext4_free_data_callback+0x2cc/0x8bc > [ 340.320104] [<ffffffff81404de8>] ? ext4_free_data_callback+0x2cc/0x8bc > [ 340.320107] [<ffffffff81404b1c>] ? ext4_mb_release_context+0x10aa/0x10aa > [ 340.320111] [<ffffffff81122c56>] ? lock_acquire+0xec/0x147 > [ 340.320115] [<ffffffff813c8a6a>] ? ext4_journal_commit_callback+0x203/0x220 > [ 340.320119] [<ffffffff813c8a61>] ext4_journal_commit_callback+0x1fa/0x220 > [ 340.320124] [<ffffffff81438bf5>] jbd2_journal_commit_transaction+0x3753/0x3c20 > [ 340.320128] [<ffffffff814354a2>] ? journal_submit_commit_record+0x777/0x777 > [ 340.320132] [<ffffffff8111f0ac>] ? debug_show_all_locks+0x226/0x226 > [ 340.320135] [<ffffffff811205a5>] ? __lock_acquire+0x14f9/0x33b8 > [ 340.320139] [<ffffffff81d31db0>] ? _raw_spin_unlock_irqrestore+0x3b/0x5c > [ 340.320143] [<ffffffff8111cde6>] ? trace_hardirqs_on_caller+0x3d2/0x492 > [ 340.320146] [<ffffffff81d31dbc>] ? _raw_spin_unlock_irqrestore+0x47/0x5c > [ 340.320151] [<ffffffff81156945>] ? try_to_del_timer_sync+0xa5/0xce > [ 340.320154] [<ffffffff8111cde6>] ? trace_hardirqs_on_caller+0x3d2/0x492 > [ 340.320157] [<ffffffff8143febd>] kjournald2+0x246/0x6e1 > [ 340.320160] [<ffffffff8143febd>] ? kjournald2+0x246/0x6e1 > [ 340.320163] [<ffffffff8143fc77>] ? commit_timeout+0xb/0xb > [ 340.320167] [<ffffffff8111112e>] ? prepare_to_wait_event+0x3f7/0x3f7 > [ 340.320171] [<ffffffff810ccde3>] kthread+0x252/0x261 > [ 340.320174] [<ffffffff8143fc77>] ? commit_timeout+0xb/0xb > [ 340.320177] [<ffffffff810ccb91>] ? kthread_create_on_node+0x377/0x377 > [ 340.320181] [<ffffffff81d3277f>] ret_from_fork+0x1f/0x40 > [ 340.320185] [<ffffffff810ccb91>] ? kthread_create_on_node+0x377/0x377 > [ 340.320186] Code: 5c 5d c3 55 48 8d 04 bd 00 00 00 00 65 48 8b 15 8d 59 b2 7e 48 69 d2 fa 00 00 00 48 89 e5 f7 e2 48 8d 7a 01 e8 22 01 00 00 5d c3 <55> 48 89 e5 41 56 41 55 41 54 53 49 89 fd bf 01 00 00 00 e8 ed > > -ss

1 0

[PATCH] amdgpu: use NULL instead of 0 for pointer
by Arnd Bergmann 15 Jun '16

15 Jun '16

In the AMD powerplay driver, a pointer is checked for validity by comparing against an integer '0', which causes a harmless warning when building with "make W=1": drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/processpptables.c:1502:16: error: ordered comparison of pointer with integer zero [-Werror=extra] This changes the code to the more conventional "if (pointer)" check. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c index 2f1a14fe05b1..b64f42d2c3ae 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c @@ -1499,7 +1499,7 @@ int get_number_of_vce_state_table_entries( const ATOM_PPLIB_VCE_State_Table *vce_table = get_vce_state_table(hwmgr, table); - if (vce_table > 0) + if (vce_table) return vce_table->numEntries; return 0; -- 2.9.0

3 2

[Bug 96360] VM fault with kernel 4.7-rc1 on Alien: Isolation
by bugzilla-daemon＠freedesktop.org 15 Jun '16

15 Jun '16

https://bugs.freedesktop.org/show_bug.cgi?id=96360 Bug ID: 96360 Summary: VM fault with kernel 4.7-rc1 on Alien: Isolation Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/Radeon Assignee: dri-devel(a)lists.freedesktop.org Reporter: alexandre.f.demers(a)gmail.com Created attachment 124312 --> https://bugs.freedesktop.org/attachment.cgi?id=124312&action=edit VM faults in dmesg triggered by Alien: Isolation Hi, I've recently begun playing Alien: Isolation now that the compute shaders are available when combining latest Mesa with a 4.7-git kernel. However, my computer freezes after sometime. Poking dmesg got me a repeating VM fault which goes on as long as I'm in the game (playing, not the menu or while loading). Setup: GPU -> R9 280X Kernel -> 4.7-rc1 Distribution -> Archlinux 64 Mesa, drm, ddx -> using latest code from git repositories I'll try with a 4.6 kernel to see if this bug was introduced in or exposed by the 4.7 branch. Attaching dmesg -- You are receiving this mail because: You are the assignee for the bug.

1 15

[GIT PULL][drm-next] Please pull new drm/arm/malidp driver
by Liviu Dudau 15 Jun '16

15 Jun '16

Hi Dave, I would like to add the Mali DP driver to the drm-next tree. It has got several reviews and now the Acks from the relevant people. The tree is based on drm-intel/topic/drm-misc tree with tag topic/drm-misc-2016-06-14 and also needs two patches from Daniel to function correctly [1][2]. Hope this helps in staging the commits correctly. Many thanks, Liviu [1] https://lists.freedesktop.org/archives/dri-devel/2016-June/110855.html [2] https://lists.freedesktop.org/archives/dri-devel/2016-June/110922.html The following changes since commit 0d841ac0ec213f70ab59d65129e80f229846fadf: drm/virtio: Don't reinvent a flipping wheel (2016-06-14 16:32:47 +0200) are available in the git repository at: git://linux-arm.org/linux-ld.git for-upstream/mali-dp for you to fetch changes up to 59ba2422b4308b02438506d35d5042df5d42c249: MAINTAINERS: Add entry for Mali-DP driver (2016-06-15 17:30:23 +0100) ---------------------------------------------------------------- Liviu Dudau (3): dt/bindings: display: Add DT bindings for Mali Display Processors. drm/arm: Add support for Mali Display Processors MAINTAINERS: Add entry for Mali-DP driver .../devicetree/bindings/display/arm,malidp.txt | 65 ++ MAINTAINERS | 10 +- drivers/gpu/drm/arm/Kconfig | 16 + drivers/gpu/drm/arm/Makefile | 2 + drivers/gpu/drm/arm/malidp_crtc.c | 216 +++++++ drivers/gpu/drm/arm/malidp_drv.c | 512 +++++++++++++++ drivers/gpu/drm/arm/malidp_drv.h | 54 ++ drivers/gpu/drm/arm/malidp_hw.c | 691 +++++++++++++++++++++ drivers/gpu/drm/arm/malidp_hw.h | 241 +++++++ drivers/gpu/drm/arm/malidp_planes.c | 298 +++++++++ drivers/gpu/drm/arm/malidp_regs.h | 172 +++++ 11 files changed, 2276 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/display/arm,malidp.txt create mode 100644 drivers/gpu/drm/arm/malidp_crtc.c create mode 100644 drivers/gpu/drm/arm/malidp_drv.c create mode 100644 drivers/gpu/drm/arm/malidp_drv.h create mode 100644 drivers/gpu/drm/arm/malidp_hw.c create mode 100644 drivers/gpu/drm/arm/malidp_hw.h create mode 100644 drivers/gpu/drm/arm/malidp_planes.c create mode 100644 drivers/gpu/drm/arm/malidp_regs.h

1 0

[Bug 95427] gem_userptr_blits@mlocked-* should skip due to memory pre-condition not met
by bugzilla-daemon＠freedesktop.org 15 Jun '16

15 Jun '16

1 0

[Bug 90400] [KBL APL SKL BSW BDW]igt/gem_ppgtt/flink-and-close-vma-leak fails
by bugzilla-daemon＠freedesktop.org 15 Jun '16

15 Jun '16

https://bugs.freedesktop.org/show_bug.cgi?id=90400 Chris Wilson <chris(a)chris-wilson.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|IGT |DRM/Intel Assignee|dri-devel(a)lists.freedesktop |intel-gfx-bugs(a)lists.freede |.org |sktop.org QA Contact| |intel-gfx-bugs(a)lists.freede | |sktop.org --- Comment #16 from Chris Wilson <chris(a)chris-wilson.co.uk> --- It's still a kernel bug. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 90400] [KBL APL SKL BSW BDW]igt/gem_ppgtt/flink-and-close-vma-leak fails
by bugzilla-daemon＠freedesktop.org 15 Jun '16

15 Jun '16

1 0

[PULL] topic/drm-misc
by Daniel Vetter 15 Jun '16

15 Jun '16

Hi Dave, More misc stuff all over: - best_encoder cleanup from Boris. - drm_simple_display_pipe helpers from Noralf. Looks really neat imo, and there's 2-3 in-flight drivers which look like they could/should use it. Anyway, with this we have now helpers and everything in place to write drivers for simple hw with fewer complexity in the driver than what fbdev would need. That was the last complaint I've heard from embedded folks after we made atomic happen. Mission accomplished! - nonblocking commit helpers for atomic, plus a bunch of driver patches for that. - Prep patch from Laurent for cleaned up pixel format functions. - More of Gustavo's cleanup for drm vblank functions. - and a few oddball things in between Plus the merge of docs-next to prep the docbook->sphinx conversion as discussed. Jon cc'ed as fyi. A bit much for -misc, but I also thinks that's it with bigger core stuff for 4.8, it should all be much calmer. Only things outstanding: - Thierry is working on a small series to make delayed fbdev setup (to handle armsoc init ordering fun with componentized drivers better) generic, and nuke the driver copypasta. - Laurent has some pixel format cleanup, not sure when that'll be ready, but also small. - fences for atomic, but looks like the userspace (hwc) is a hold-up because google doesn't want to release it early. oh well. Maybe a bit more prep work from Gustavo in that area ... Oh and this pull contains one patch committed by Thierry, we're starting to play around with group maintainership and what makes sense and what not. If it does make sense, then longer-term I think we'll create a new drm-misc.git for it. Cheers, Daniel The following changes since commit 3c85f20a289d044f303f473ee6ab7502303fc3b0: Merge tag 'omapdrm-4.8' of git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux into drm-next (2016-06-09 12:20:11 +1000) are available in the git repository at: git://anongit.freedesktop.org/drm-intel tags/topic/drm-misc-2016-06-14 for you to fetch changes up to 0d841ac0ec213f70ab59d65129e80f229846fadf: drm/virtio: Don't reinvent a flipping wheel (2016-06-14 16:32:47 +0200) ---------------------------------------------------------------- Boris Brezillon (19): drm: mediatek: Rely on the default ->best_encoder() behavior drm: msm: Rely on the default ->best_encoder() behavior where appropriate drm: sti: Rely on the default ->best_encoder() behavior drm: arc: Rely on the default ->best_encoder() behavior drm: atmel-hlcdc: Rely on the default ->best_encoder() behavior drm: exynos: Rely on the default ->best_encoder() behavior drm: fsl-dcu: Rely on the default ->best_encoder() behavior drm: rcar-du: Rely on the default ->best_encoder() behavior drm: rockchip: Rely on the default ->best_encoder() behavior drm: sun4i: Rely on the default ->best_encoder() behavior drm: tegra: Rely on the default ->best_encoder() behavior drm: vc4: Rely on the default ->best_encoder() behavior drm: virtgpu: Rely on the default ->best_encoder() behavior drm: omap: Rely on the default ->best_encoder() behavior drm/bridge: anx78xx: Rely on the default ->best_encoder() behavior drm/bridge: ptn3460: Rely on the default ->best_encoder() behavior drm/bridge: ps8622: Rely on the default ->best_encoder() behavior drm/bridge: dw-hdmi: Use drm_atomic_helper_best_encoder() drm: i915: Rely on the default ->best_encoder() behavior where appropriate Brian Norris (1): drm/rockchip: fix compile warnings for 64-bit Daniel Vetter (19): drm/atomic-helper: Annotate a bunch more RETURNS: sections drm: Replace fb_helper->atomic with mode_config->atomic_commit drm/arc: Nuke event_list drm/fsl-du: Implement some semblance of vblank event handling drm/hisilicon: Implement some semblance of vblank event handling drm/atomic: kerneldoc for drm_atomic_crtc_needs_modeset drm/atomic-helper: Massage swap_state signature somewhat drm/arc: Actually bother with handling atomic events. drm/sun4i: Implement some semblance of vblank event handling drm/atomic: Add struct drm_crtc_commit to track async updates drm/atomic-helper: roll out commit synchronization drm/atomic-helper: nonblocking commit support drm/arc: Implement nonblocking commit correctly drm/hdlcd: Use helper support for nonblocking commits drm/rockchip: Disarm vop->is_enabled drm/rockchip: Fix crtc_state->event signalling drm/rockchip: convert to helper nonblocking atomic commit drm/rockchip: Nuke pending event handling in preclose drm/virtio: Don't reinvent a flipping wheel Gustavo Padovan (9): drm/nouveau: replace legacy vblank helpers drm: remove legacy drm_send_vblank_event() drm: remove legacy drm_arm_vblank_event() drm: make drm_vblank_{get,put}() static drm/amdgpu: use drm_crtc_vblank_{on,off}() drm/radeon: use drm_crtc_vblank_{on,off}() drm/amdgpu: use crtc directly in drm_crtc_vblank_put() drm/radeon: use crtc directly in drm_crtc_vblank_put() drm/gma500: use drm_crtc_vblank_{on,off}() Laurent Pinchart (1): drm: Move format-related helpers to drm_fourcc.c Liviu Dudau (1): drm: Fix comment making reference to non-existing function Lukas Wunner (1): drm: Remove dev_pm_ops from drm_class Noralf Trønnes (1): drm: Add helper for simple display pipeline Rob Clark (1): drm/prime: fix error path deadlock fail Sudip Mukherjee (1): drm: fb: cma: fix memory leak Thierry Reding (1): drm/dsi: Add uevent callback Tobias Jakobi (1): drm/exynos: use logical AND in exynos_drm_plane_check_size() Tomeu Vizoso (3): drm/rockchip: Drop drm_driver.load/unload callbacks drm/rockchip: Use atomic PM helpers drm/rockchip: Resume DP early Wei Yongjun (1): drm/i915: Fix missing unlock on error in i915_ppgtt_info() Documentation/DocBook/gpu.tmpl | 11 + drivers/gpu/drm/Makefile | 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 4 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 4 +- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 4 +- drivers/gpu/drm/arc/arcpgu.h | 1 - drivers/gpu/drm/arc/arcpgu_crtc.c | 16 +- drivers/gpu/drm/arc/arcpgu_drv.c | 27 +- drivers/gpu/drm/arc/arcpgu_hdmi.c | 18 - drivers/gpu/drm/arm/hdlcd_drv.c | 8 +- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 12 - drivers/gpu/drm/bridge/analogix-anx78xx.c | 8 - drivers/gpu/drm/bridge/dw-hdmi.c | 11 +- drivers/gpu/drm/bridge/nxp-ptn3460.c | 8 - drivers/gpu/drm/bridge/parade-ps8622.c | 10 - drivers/gpu/drm/drm_atomic.c | 22 + drivers/gpu/drm/drm_atomic_helper.c | 493 +++++++++++++++++++-- drivers/gpu/drm/drm_crtc.c | 292 +----------- drivers/gpu/drm/drm_drv.c | 2 - drivers/gpu/drm/drm_fb_cma_helper.c | 1 + drivers/gpu/drm/drm_fb_helper.c | 6 +- drivers/gpu/drm/drm_fops.c | 6 + drivers/gpu/drm/drm_fourcc.c | 320 +++++++++++++ drivers/gpu/drm/drm_irq.c | 80 +--- drivers/gpu/drm/drm_mipi_dsi.c | 16 + drivers/gpu/drm/drm_prime.c | 10 +- drivers/gpu/drm/drm_simple_kms_helper.c | 205 +++++++++ drivers/gpu/drm/drm_sysfs.c | 71 --- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 9 - drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 +- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 9 - drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 8 - drivers/gpu/drm/exynos/exynos_hdmi.c | 8 - drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 23 +- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 9 - drivers/gpu/drm/gma500/gma_display.c | 2 +- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 20 +- drivers/gpu/drm/i915/i915_debugfs.c | 4 +- drivers/gpu/drm/i915/intel_crt.c | 1 - drivers/gpu/drm/i915/intel_display.c | 10 +- drivers/gpu/drm/i915/intel_dp.c | 1 - drivers/gpu/drm/i915/intel_drv.h | 1 - drivers/gpu/drm/i915/intel_dsi.c | 1 - drivers/gpu/drm/i915/intel_dvo.c | 1 - drivers/gpu/drm/i915/intel_fbdev.c | 2 - drivers/gpu/drm/i915/intel_hdmi.c | 1 - drivers/gpu/drm/i915/intel_lvds.c | 1 - drivers/gpu/drm/i915/intel_sdvo.c | 1 - drivers/gpu/drm/i915/intel_tv.c | 1 - drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- drivers/gpu/drm/mediatek/mtk_dsi.c | 9 - drivers/gpu/drm/msm/edp/edp_connector.c | 10 - drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 8 - drivers/gpu/drm/msm/mdp/mdp4/mdp4_lvds_connector.c | 9 - drivers/gpu/drm/msm/msm_atomic.c | 2 +- drivers/gpu/drm/nouveau/nouveau_display.c | 22 +- drivers/gpu/drm/nouveau/nouveau_display.h | 3 +- drivers/gpu/drm/omapdrm/omap_connector.c | 10 - drivers/gpu/drm/omapdrm/omap_drv.c | 2 +- drivers/gpu/drm/radeon/atombios_crtc.c | 4 +- drivers/gpu/drm/radeon/radeon_display.c | 2 +- drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 4 +- drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 12 - drivers/gpu/drm/rcar-du/rcar_du_encoder.h | 3 - drivers/gpu/drm/rcar-du/rcar_du_hdmicon.c | 1 - drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +- drivers/gpu/drm/rcar-du/rcar_du_lvdscon.c | 1 - drivers/gpu/drm/rcar-du/rcar_du_vgacon.c | 3 - drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 15 +- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 9 - drivers/gpu/drm/rockchip/inno_hdmi.c | 9 - drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 194 +++----- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 12 +- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 72 +-- drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 5 +- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 68 +-- drivers/gpu/drm/sti/sti_drv.c | 2 +- drivers/gpu/drm/sti/sti_dvo.c | 10 - drivers/gpu/drm/sti/sti_hda.c | 10 - drivers/gpu/drm/sti/sti_hdmi.c | 10 - drivers/gpu/drm/sun4i/sun4i_crtc.c | 12 + drivers/gpu/drm/sun4i/sun4i_rgb.c | 10 - drivers/gpu/drm/sun4i/sun4i_tv.c | 9 - drivers/gpu/drm/tegra/drm.c | 2 +- drivers/gpu/drm/tegra/drm.h | 2 - drivers/gpu/drm/tegra/dsi.c | 1 - drivers/gpu/drm/tegra/hdmi.c | 1 - drivers/gpu/drm/tegra/output.c | 8 - drivers/gpu/drm/tegra/rgb.c | 1 - drivers/gpu/drm/tegra/sor.c | 1 - drivers/gpu/drm/vc4/vc4_dpi.c | 9 - drivers/gpu/drm/vc4/vc4_hdmi.c | 9 - drivers/gpu/drm/vc4/vc4_kms.c | 2 +- drivers/gpu/drm/virtio/virtgpu_display.c | 81 +--- include/drm/drmP.h | 10 +- include/drm/drm_atomic.h | 16 + include/drm/drm_atomic_helper.h | 14 +- include/drm/drm_crtc.h | 161 ++++++- include/drm/drm_fb_helper.h | 11 - include/drm/drm_fourcc.h | 37 ++ include/drm/drm_mipi_dsi.h | 2 + include/drm/drm_modeset_helper_vtables.h | 39 ++ include/drm/drm_simple_kms_helper.h | 94 ++++ 107 files changed, 1609 insertions(+), 1242 deletions(-) create mode 100644 drivers/gpu/drm/drm_fourcc.c create mode 100644 drivers/gpu/drm/drm_simple_kms_helper.c create mode 100644 include/drm/drm_fourcc.h create mode 100644 include/drm/drm_simple_kms_helper.h -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

2 2

[PATCH] drm/atomic-helpers: Clear up cleanup_done a bit
by Daniel Vetter 15 Jun '16

15 Jun '16

It's not obvious at first sight that this is a fastpath, make that clearer with a goto. Fallout from a discussion with Liviu on irc. v2: Drop bogus hunks that crept in. Cc: Liviu.Dudau(a)arm.com Acked-by: Liviu.Dudau(a)arm.com Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- drivers/gpu/drm/drm_atomic_helper.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 716aa535eb98..0556c95b7ddb 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -1579,11 +1579,8 @@ void drm_atomic_helper_commit_cleanup_done(struct drm_atomic_state *state) /* commit_list borrows our reference, need to remove before we * clean up our drm_atomic_state. But only after it actually * completed, otherwise subsequent commits won't stall properly. */ - if (try_wait_for_completion(&commit->flip_done)) { - list_del(&commit->commit_entry); - spin_unlock(&crtc->commit_lock); - continue; - } + if (try_wait_for_completion(&commit->flip_done)) + goto del_commit: spin_unlock(&crtc->commit_lock); @@ -1597,6 +1594,7 @@ void drm_atomic_helper_commit_cleanup_done(struct drm_atomic_state *state) crtc->base.id, crtc->name); spin_lock(&crtc->commit_lock); +del_commit: list_del(&commit->commit_entry); spin_unlock(&crtc->commit_lock); } -- 2.8.1

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2016