dri-devel July 2016

dri-devel@lists.freedesktop.org

199 participants
1323 discussions

[PATCH v2 1/1] gpu: drm: msm_drv: add missing of_node_put after calling of_parse_phandle
by Peter Chen 04 Jul '16

04 Jul '16

of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen <peter.chen(a)nxp.com> --- Changes for v2: - There are two missings in the code, handle it both in one patch drivers/gpu/drm/msm/msm_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 9c65409..46c6037 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -284,6 +284,7 @@ static int msm_init_vram(struct drm_device *dev) if (node) { struct resource r; ret = of_address_to_resource(node, 0, &r); + of_node_put(node); if (ret) return ret; size = r.end - r.start; @@ -819,6 +820,7 @@ static int add_components(struct device *dev, struct component_match **matchptr, break; component_match_add(dev, matchptr, compare_of, node); + of_node_put(node); } return 0; -- 1.9.1

1 0

[PATCH 1/1] gpu: drm: msm_drv: add missing of_node_put after calling of_parse_phandle
by Peter Chen 04 Jul '16

04 Jul '16

of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen <peter.chen(a)nxp.com> --- drivers/gpu/drm/msm/msm_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 9c65409..d9ba6c4 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -284,6 +284,7 @@ static int msm_init_vram(struct drm_device *dev) if (node) { struct resource r; ret = of_address_to_resource(node, 0, &r); + of_node_put(node); if (ret) return ret; size = r.end - r.start; -- 1.9.1

1 0

[PATCH 1/2] drm/amdgpu: remove unneeded conversions to bool
by Andrew F. Davis 04 Jul '16

04 Jul '16

Found with scripts/coccinelle/misc/boolconv.cocci. Signed-off-by: Andrew F. Davis <afd(a)ti.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 8 ++++---- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/vi.c | 14 +++++++------- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c index 1a5cbaf..f3c8c37 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c @@ -5144,13 +5144,13 @@ static int gfx_v8_0_set_powergating_state(void *handle, case CHIP_POLARIS11: if (adev->pg_flags & AMD_PG_SUPPORT_GFX_SMG) polaris11_enable_gfx_static_mg_power_gating(adev, - state == AMD_PG_STATE_GATE ? true : false); + state == AMD_PG_STATE_GATE); else if (adev->pg_flags & AMD_PG_SUPPORT_GFX_DMG) polaris11_enable_gfx_dynamic_mg_power_gating(adev, - state == AMD_PG_STATE_GATE ? true : false); + state == AMD_PG_STATE_GATE); else polaris11_enable_gfx_quick_mg_power_gating(adev, - state == AMD_PG_STATE_GATE ? true : false); + state == AMD_PG_STATE_GATE); break; default: break; @@ -5583,7 +5583,7 @@ static int gfx_v8_0_set_clockgating_state(void *handle, case CHIP_CARRIZO: case CHIP_STONEY: gfx_v8_0_update_gfx_clock_gating(adev, - state == AMD_CG_STATE_GATE ? true : false); + state == AMD_CG_STATE_GATE); break; default: break; diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c index 9945d5b..6c3c730 100644 --- a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c @@ -1406,9 +1406,9 @@ static int gmc_v8_0_set_clockgating_state(void *handle, switch (adev->asic_type) { case CHIP_FIJI: fiji_update_mc_medium_grain_clock_gating(adev, - state == AMD_CG_STATE_GATE ? true : false); + state == AMD_CG_STATE_GATE); fiji_update_mc_light_sleep(adev, - state == AMD_CG_STATE_GATE ? true : false); + state == AMD_CG_STATE_GATE); break; default: break; diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c index 532ea88..e57cab6 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c @@ -1547,9 +1547,9 @@ static int sdma_v3_0_set_clockgating_state(void *handle, case CHIP_CARRIZO: case CHIP_STONEY: sdma_v3_0_update_sdma_medium_grain_clock_gating(adev, - state == AMD_CG_STATE_GATE ? true : false); + state == AMD_CG_STATE_GATE); sdma_v3_0_update_sdma_medium_grain_light_sleep(adev, - state == AMD_CG_STATE_GATE ? true : false); + state == AMD_CG_STATE_GATE); break; default: break; diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index a65c960..d3404ef 100644 --- a/drivers/gpu/drm/amd/amdgpu/vi.c +++ b/drivers/gpu/drm/amd/amdgpu/vi.c @@ -1393,22 +1393,22 @@ static int vi_common_set_clockgating_state(void *handle, switch (adev->asic_type) { case CHIP_FIJI: vi_update_bif_medium_grain_light_sleep(adev, - state == AMD_CG_STATE_GATE ? true : false); + state == AMD_CG_STATE_GATE); vi_update_hdp_medium_grain_clock_gating(adev, - state == AMD_CG_STATE_GATE ? true : false); + state == AMD_CG_STATE_GATE); vi_update_hdp_light_sleep(adev, - state == AMD_CG_STATE_GATE ? true : false); + state == AMD_CG_STATE_GATE); vi_update_rom_medium_grain_clock_gating(adev, - state == AMD_CG_STATE_GATE ? true : false); + state == AMD_CG_STATE_GATE); break; case CHIP_CARRIZO: case CHIP_STONEY: vi_update_bif_medium_grain_light_sleep(adev, - state == AMD_CG_STATE_GATE ? true : false); + state == AMD_CG_STATE_GATE); vi_update_hdp_medium_grain_clock_gating(adev, - state == AMD_CG_STATE_GATE ? true : false); + state == AMD_CG_STATE_GATE); vi_update_hdp_light_sleep(adev, - state == AMD_CG_STATE_GATE ? true : false); + state == AMD_CG_STATE_GATE); break; default: break; -- 2.9.0

2 2

[PATCH 1/1] gpu: drm: exynos_hdmi: add missing of_node_put after calling of_parse_phandle
by Peter Chen 04 Jul '16

04 Jul '16

of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen <peter.chen(a)nxp.com> --- drivers/gpu/drm/exynos/exynos_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 58de5a4..e9591c7 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -1828,6 +1828,7 @@ static int hdmi_probe(struct platform_device *pdev) DRM_ERROR("Failed to find ddc node in device tree\n"); return -ENODEV; } + of_node_put(dev->of_node); out_get_ddc_adpt: hdata->ddc_adpt = of_find_i2c_adapter_by_node(ddc_node); @@ -1846,6 +1847,7 @@ out_get_ddc_adpt: ret = -ENODEV; goto err_ddc; } + of_node_put(dev->of_node); out_get_phy_port: if (hdata->drv_data->is_apb_phy) { -- 1.9.1

1 0

[PATCH 1/1] gpu: drm: arcpgu_drv: add missing of_node_put after calling of_parse_phandle
by Peter Chen 04 Jul '16

04 Jul '16

1 0

[Bug 96768] Black screen past login with RX 480, Ubuntu 16.04 and AMDgpu-pro 16.30
by bugzilla-daemon＠freedesktop.org 04 Jul '16

04 Jul '16

https://bugs.freedesktop.org/show_bug.cgi?id=96768 Bug ID: 96768 Summary: Black screen past login with RX 480, Ubuntu 16.04 and AMDgpu-pro 16.30 Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu-pro Assignee: dri-devel(a)lists.freedesktop.org Reporter: pyrignis(a)gmail.com Created attachment 124845 --> https://bugs.freedesktop.org/attachment.cgi?id=124845&action=edit output of the dmesg command Symptoms: Login screen renders properly Past login, the screen turns black, with the pointer visible and a blank pixel in the upper left corner. On some occasion the pointer turns from the arrow to the vertical bar. crtl+alt+F<whaterver> works and brings the user to the tty. all symptoms are reverted when the llvm driver is used. System: Ubuntu 16.04 Gnome edition (but even with unity installed and configured as default the symptoms are the same) AMD Radeon RX 480 8G AMDgpu-pro 16.30 4.4 kernel The dmesg file is the output of the command after a tty return with ctrl+alt+F4. original description here: https://www.phoronix.com/forums/forum/linux-graphics-x-org-drivers/amd-linu… -- You are receiving this mail because: You are the assignee for the bug.

1 1

[GIT PULL] drm/mediatek: MT8173 gamma & dither support
by Bibby Hsieh 04 Jul '16

04 Jul '16

Hi Dave, Please consider merging this tag, which contains the v2 MT8173 gamma & dither function patches I sent on 2016-06-17, rebased onto v4.7-rc1. There have been no further comments. Thanks Bibby The following changes since commit 1a695a905c18548062509178b98bc91e67510864: Linux 4.7-rc1 (2016-05-29 16:29:24 GMT) are available in the git repository at: git@github.com:BibbyHsieh/linux4.7-rc1.git for you to fetch changes up to dd0eb773bc125f5e6bca735d19c08500dc3730f9: drm/mediatek: Add gamma correction ------------------------------------------------------------------------- This is MT8173 gamma & dither support PATCH v2, based on 4.7-rc1. Changes since v1: -According to the suggestion from Daniel, we used the new atomic color management. -Applied gamma function at GAMMA engine (path 2). -Made dithering function support hardware mirroring well. -Removed the bpc variable from mtk_drm_crtc struct. ------------------------------------------------------------------------- Bibby Hsieh (2): drm/mediatek: Add gamma correction drm/mediatek: set mt8173 dithering function drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 +- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 3 +- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 26 ++++- drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 1 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 147 ++++++++++++++++++++++++++- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 16 ++- 6 files changed, 184 insertions(+), 12 deletions(-) -- 1.7.9.5

4 4

[PATCH] drm/mediatek: fix error handling
by Christophe JAILLET 03 Jul '16

03 Jul '16

This is likely that checking 'phy_provider' instead of 'phy' is expected here. Signed-off-by: Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> --- drivers/gpu/drm/mediatek/mtk_mipi_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c index cf8f38d..1c366f8 100644 --- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c +++ b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c @@ -431,7 +431,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev) phy_set_drvdata(phy, mipi_tx); phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); - if (IS_ERR(phy)) { + if (IS_ERR(phy_provider)) { ret = PTR_ERR(phy_provider); return ret; } -- 2.7.4

2 1

[PULL] drm-amdkfd-next
by Oded Gabbay 03 Jul '16

03 Jul '16

Hi Dave, A few amdkfd patches for 4.8. One patch replaces deprecated kernel api call (create_workqueue) and the other patch properly cleans up resources in case of failing to create a process object. Thanks, Oded The following changes since commit dac2c48ca5ac9bb2d6339aaa733c60d5b801ee86: Merge branch 'for-next' of http://git.agner.ch/git/linux-drm-fsl-dcu into drm-next (2016-07-02 16:21:35 +1000) are available in the git repository at: git://people.freedesktop.org/~gabbayo/linux tags/drm-amdkfd-next-2016-07-03 for you to fetch changes up to 7fd5e03ca6b41a591bd9fda083362b8a07cfb5f7: drm/amdkfd: destroy mutex if process creation fails (2016-07-03 08:05:45 +0300) ---------------------------------------------------------------- Bhaktipriya Shridhar (1): drm/amdkfd: Remove create_workqueue() Oded Gabbay (1): drm/amdkfd: destroy mutex if process creation fails drivers/gpu/drm/amd/amdkfd/kfd_process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

1 0

[Bug 93740] weston client egl corruption above certain window size.
by bugzilla-daemon＠freedesktop.org 02 Jul '16

02 Jul '16

https://bugs.freedesktop.org/show_bug.cgi?id=93740 Bug ID: 93740 Summary: weston client egl corruption above certain window size. Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: adf.lists(a)gmail.com QA Contact: dri-devel(a)lists.freedesktop.org Apologies if this isn't a radeonsi issue. Before today I've never tested weston so have no knowledge of past behavior. R9285. Issue happens with weston alone or started from within X. Weston its self renders OK. If I start weston-simple-egl it renders OK, but if I enlarge its window the output becomes corrupted, not totally, I can see the triangle is enlarged, but there is lots of random looking memory rendered as well. If shrink it back down it renders OK once it hits original size and is OK smaller. Output from kodi/mpv is also 90% junk. In the case of mpv I can reduce the vid window down in size, and when it hits the small size that simple-egl starts at it also starts to render OK. All the wayland/weston code is release. Mesa/llvm gits. -- You are receiving this mail because: You are the assignee for the bug.

1 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel July 2016