dri-devel September 2016

dri-devel@lists.freedesktop.org

225 participants
1445 discussions

[PATCH v4 0/4] New debugfs API for capturing CRC of frames
by Tomeu Vizoso 05 Sep '16

05 Sep '16

Hi, this series basically takes the facility for continuously capturing CRCs of frames from the i915 driver and into the DRM core. The idea is that test suites such as IGT use this information to check that frames that are exected to be identical, also have identical CRC values. Other drivers for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. Thanks, Tomeu Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Add API for capturing frame CRCs drm/i915: Use new CRC debugfs API drm/i915: Put "cooked" vlank counters in frame CRC lines Documentation/gpu/drm-uapi.rst | 6 + drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/drm_crtc.c | 12 + drivers/gpu/drm/drm_debugfs.c | 36 +- drivers/gpu/drm/drm_debugfs_crc.c | 368 ++++++++++++ drivers/gpu/drm/drm_drv.c | 9 + drivers/gpu/drm/drm_internal.h | 10 + drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 892 +---------------------------- drivers/gpu/drm/i915/i915_irq.c | 69 ++- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 7 + drivers/gpu/drm/i915/intel_pipe_crc.c | 1001 +++++++++++++++++++++++++++++++++ include/drm/drmP.h | 5 + include/drm/drm_crtc.h | 41 ++ include/drm/drm_debugfs_crc.h | 74 +++ 16 files changed, 1619 insertions(+), 917 deletions(-) create mode 100644 drivers/gpu/drm/drm_debugfs_crc.c create mode 100644 drivers/gpu/drm/i915/intel_pipe_crc.c create mode 100644 include/drm/drm_debugfs_crc.h -- 2.7.4

2 10

[PATCH 0/4] Backported vlv fixes for 4.7.y
by Lyude 05 Sep '16

05 Sep '16

Hope this didn't take too long! Here's the backported versions of the patches you had trouble applying to stable. The patch for FBC won't be necessary as that is already present in 4.7.y. Cheers, Lyude Lyude (4): drm/i915/vlv: Make intel_crt_reset() per-encoder drm/i915/vlv: Reset the ADPA in vlv_display_power_well_init() drm/i915/vlv: Disable HPD in valleyview_crt_detect_hotplug() drm/i915: Enable polling when we don't have hpd drivers/gpu/drm/i915/i915_drv.c | 3 + drivers/gpu/drm/i915/i915_drv.h | 5 ++ drivers/gpu/drm/i915/intel_crt.c | 28 ++++++-- drivers/gpu/drm/i915/intel_drv.h | 4 +- drivers/gpu/drm/i915/intel_hotplug.c | 117 ++++++++++++++++++++++++++++---- drivers/gpu/drm/i915/intel_runtime_pm.c | 9 +++ 6 files changed, 148 insertions(+), 18 deletions(-) -- 2.7.4

3 7

drm timing problems in sama5d3 Xplained.
by Alex Vazquez 05 Sep '16

05 Sep '16

Hi All. I am using DRM in a sama5d3 Xplained with display TM43 and I've found with the following problem: I deleted the network interfaces in the device tree for my system to boot faster. My problem is that now the startup script run before the driver has loaded correctly. I explain better: The startup script begin to appear before the creation of the framebuffer message appears. (See LogKernel.txt) atmel-hlcdc-display-controller atmel-hlcdc-dc: fb0: frame buffer device 1 - I can't use the framebuffer until the message is not displayed. (This did not matter. I want to use drm.) 2 - DRM don't work fine. If I try to paint on the screen (using planes) before the message it is created framebuffer appears, nothing appears on the display. This problem I can replicate with the demo atmel if I remove network interfaces in the device tree and adding a startup script that uses drm. I add the demo with the modified device tree so you can prove that occurs. https://drive.google.com/file/d/0B3EMwEbIHhkAbDhGMU1BcEVoYkU/view?usp=shari… You only need to add the startup script in /etc/rcS.d/ #!/bin/sh > modetest -M atmel-hlcdc -P 26:480x272+0+0@AR15 I also tested with the latest version of kernel 4.8 RC3 and the problem is still happening. Thanks! Regards!

2 1

[PATCH v5 0/4] New debugfs API for capturing CRC of frames
by Tomeu Vizoso 05 Sep '16

05 Sep '16

Hi, this series basically takes the facility for continuously capturing CRCs of frames from the i915 driver and into the DRM core. The idea is that test suites such as IGT use this information to check that frames that are exected to be identical, also have identical CRC values. Other drivers for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. Thanks, Tomeu Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Add API for capturing frame CRCs drm/i915: Use new CRC debugfs API drm/i915: Put "cooked" vlank counters in frame CRC lines Documentation/gpu/drm-uapi.rst | 6 + drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/drm_crtc.c | 29 +- drivers/gpu/drm/drm_debugfs.c | 34 +- drivers/gpu/drm/drm_debugfs_crc.c | 351 ++++++++++++ drivers/gpu/drm/drm_drv.c | 15 + drivers/gpu/drm/drm_internal.h | 10 + drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 886 +---------------------------- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 3 +- drivers/gpu/drm/i915/i915_irq.c | 83 ++- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 7 + drivers/gpu/drm/i915/intel_pipe_crc.c | 1005 +++++++++++++++++++++++++++++++++ include/drm/drm_crtc.h | 41 ++ include/drm/drm_debugfs_crc.h | 78 +++ 17 files changed, 1642 insertions(+), 914 deletions(-) create mode 100644 drivers/gpu/drm/drm_debugfs_crc.c create mode 100644 drivers/gpu/drm/i915/intel_pipe_crc.c create mode 100644 include/drm/drm_debugfs_crc.h -- 2.7.4

1 4

[PATCH 0/6] drm/i915: Enable preliminary support for nonblocking modeset.:
by Maarten Lankhorst 05 Sep '16

05 Sep '16

From: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> This is still broken on SKL. IGT detects that nonblocking modesetting is supported by a check that does a nonblocking modeset followed by a synchronous commit. The nonblocking modeset works, but the synchronous commit immediately after to serialize the state fails on invalid watermark values. kms_atomic_transition nonblocking modeset tests pass on my BDW NUC. Maarten Lankhorst (6): drm/i915: Convert intel_hdmi to use atomic state drm/i915: Pass atomic state to intel_audio_codec_enable drm/edid: Remove drm_select_eld drm/i915: Update atomic modeset state synchronously drm/i915: Pass atomic state to verify_connector_state drm/i915: Enable support for nonblocking modeset drivers/gpu/drm/drm_edid.c | 26 ------------------- drivers/gpu/drm/i915/intel_audio.c | 15 ++++++----- drivers/gpu/drm/i915/intel_ddi.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 47 ++++++++++++++++----------------- drivers/gpu/drm/i915/intel_dp.c | 11 ++++---- drivers/gpu/drm/i915/intel_drv.h | 4 ++- drivers/gpu/drm/i915/intel_hdmi.c | 50 ++++++++++++++++-------------------- include/drm/drm_edid.h | 1 - 8 files changed, 63 insertions(+), 93 deletions(-) -- 2.7.4

1 6

[PATCH] drm/imx: Fix of_node ref counting
by Christophe JAILLET 05 Sep '16

05 Sep '16

This code is spurious. It takes a ref on a node, then call 'of_node_put' on it and then store this node somewhere. It is likely that taking the ref on the parent node and releasing the child node was expected instead. So, use 'of_get_next_parent' instead. It does all this in just one function call. Signed-off-by: Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> --- Un-tested --- drivers/gpu/drm/imx/imx-drm-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index 438bac8fbc2b..60fb388c80f8 100644 --- a/drivers/gpu/drm/imx/imx-drm-core.c +++ b/drivers/gpu/drm/imx/imx-drm-core.c @@ -449,10 +449,8 @@ static int compare_of(struct device *dev, void *data) } /* Special case for LDB, one device for two channels */ - if (of_node_cmp(np->name, "lvds-channel") == 0) { - np = of_get_parent(np); - of_node_put(np); - } + if (of_node_cmp(np->name, "lvds-channel") == 0) + np = of_get_next_parent(np); return dev->of_node == np; } -- 2.7.4

2 2

[PATCH] drm/atomic: Reject properties not part of the object.
by Maarten Lankhorst 05 Sep '16

05 Sep '16

The legacy setprop ioctl doesn't attempt to set properties that are not enumerated on the object. The atomic ioctl does, fix this by validating first. Signed-off-by: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> --- drivers/gpu/drm/drm_atomic.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 5cb2e22d5d55..a5126e5c05ee 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -1609,7 +1609,7 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, struct drm_crtc_state *crtc_state; unsigned plane_mask; int ret = 0; - unsigned int i, j; + unsigned int i, j, k; /* disallow for drivers not supporting atomic: */ if (!drm_core_check_feature(dev, DRIVER_ATOMIC)) @@ -1691,6 +1691,15 @@ retry: goto out; } + for (k = 0; k < obj->properties->count; k++) + if (obj->properties->properties[k]->base.id == prop_id) + break; + + if (k == obj->properties->count) { + ret = -EINVAL; + goto out; + } + prop = drm_property_find(dev, prop_id); if (!prop) { drm_mode_object_unreference(obj); -- 2.7.4

1 0

Re: [PATCH] drm/gma500: remove the process of stolen page in page fault handler.
by jiang.biao2＠zte.com.cn 05 Sep '16

05 Sep '16

JiangBiao162664/user/zte_ltd Wrote 2016/08/31 10:27:34: > JiangBiao162664/user/zte_ltd > 2016/08/31 10:27 > > From > Patrik Jakobsson <patrik.r.jakobsson(a)gmail.com>, > Re: [PATCH] drm/gma500: remove the process of stolen page in page > fault handler. > > Patrik Jakobsson <patrik.r.jakobsson(a)gmail.com> wrote on 2016/08/30 18:21:08: > > > Patrik Jakobsson <patrik.r.jakobsson(a)gmail.com> > > 2016/08/30 18:21 > > > > From > > jiang.biao2(a)zte.com.cn, > > cc > > dri-devel <dri-devel(a)lists.freedesktop.org> > > Re: [PATCH] drm/gma500: remove the process of stolen page in page > fault handler. > > > > On Tue, Aug 30, 2016 at 7:10 AM, <jiang.biao2(a)zte.com.cn> wrote: > > > > > > Direct gtt range is used in the page fault scene in current driver, > > > instead of stolen page. So no need to keep relative process. > > > > Hi > > > > Are you saying that we don't use stolen memory? Afaik stolen memory > > should be accessed through the stolen range so we do need this. > > > > -Patrik > > > As far as I can see, the stolen memory is only used by fbdev driver > in gma500, > but the fbdev driver maps the stloen memory directly in psbfb_vm_fault, not > using psb_gem_fault to map the stolen memory. > The only scenario using the psb_gem_fault is the gtt range created by > psb_gem_create, which alloc the gtt range without stolen memory backed. > If I missed something, pls enlighten me. > Thanks a lot. Hi Patrik, Could you please help to confirm my question? Thank you very much.

2 2

[PATCH 0/5] rk3399 support ddr frequency scaling
by Lin Huang 05 Sep '16

05 Sep '16

rk3399 platform have dfi controller can monitor ddr load, and dcf controller to handle ddr register so we can get the right ddr frequency and make ddr controller happy work(which will implement in bl31). So we do ddr frequency scaling with following flow: kernel bl31 monitor ddr load | | get_target_rate | | pass rate to bl31 clk_set_rate(ddr) --------------------->run dcf flow | | | | wait dcf interrupt<-------------------trigger dcf interrupt | | return Lin Huang (5): Documentation: bindings: add dt documentation for dfi controller PM / devfreq: event: support rockchip dfi controller Documentation: bindings: add dt documentation for rk3399 dmc PM / devfreq: rockchip: add devfreq driver for rk3399 dmc drm/rockchip: Add dmc notifier in vop driver Following patch: clk: rockchip: add new clock-type for the ddrclk clk: rockchip: rk3399: add SCLK_DDRCLK ID for ddrc clk: rockchip: rk3399: add ddrc clock support have applied to: http://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/v4.… .../bindings/devfreq/event/rockchip-dfi.txt | 19 + .../devicetree/bindings/devfreq/rk3399_dmc.txt | 173 ++++++++ drivers/devfreq/Kconfig | 11 + drivers/devfreq/Makefile | 1 + drivers/devfreq/event/Kconfig | 7 + drivers/devfreq/event/Makefile | 1 + drivers/devfreq/event/rockchip-dfi.c | 256 +++++++++++ drivers/devfreq/rk3399_dmc.c | 480 +++++++++++++++++++++ drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 116 +++++ 9 files changed, 1064 insertions(+) create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt create mode 100644 Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt create mode 100644 drivers/devfreq/event/rockchip-dfi.c create mode 100644 drivers/devfreq/rk3399_dmc.c -- 2.6.6

4 12

[PATCH v9 0/5] rk3399 support ddr frequency scaling
by Lin Huang 05 Sep '16

05 Sep '16

rk3399 platform have dfi controller can monitor ddr load, and dcf controller to handle ddr register so we can get the right ddr frequency and make ddr controller happy work(which will implement in bl31). So we do ddr frequency scaling with following flow: kernel bl31 monitor ddr load | | get_target_rate | | pass rate to bl31 clk_set_rate(ddr) --------------------->run dcf flow | | | | wait dcf interrupt<-------------------trigger dcf interrupt | | return Lin Huang (5): Documentation: bindings: add dt documentation for dfi controller PM / devfreq: event: support rockchip dfi controller Documentation: bindings: add dt documentation for rk3399 dmc PM / devfreq: rockchip: add devfreq driver for rk3399 dmc drm/rockchip: Add dmc notifier in vop driver Following patch: clk: rockchip: add new clock-type for the ddrclk clk: rockchip: rk3399: add SCLK_DDRCLK ID for ddrc clk: rockchip: rk3399: add ddrc clock support have applied to: http://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/v4.… .../bindings/devfreq/event/rockchip-dfi.txt | 19 + .../devicetree/bindings/devfreq/rk3399_dmc.txt | 202 +++++++++ drivers/devfreq/Kconfig | 11 + drivers/devfreq/Makefile | 1 + drivers/devfreq/event/Kconfig | 7 + drivers/devfreq/event/Makefile | 1 + drivers/devfreq/event/rockchip-dfi.c | 256 +++++++++++ drivers/devfreq/rk3399_dmc.c | 480 +++++++++++++++++++++ drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 116 +++++ 9 files changed, 1093 insertions(+) create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt create mode 100644 Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt create mode 100644 drivers/devfreq/event/rockchip-dfi.c create mode 100644 drivers/devfreq/rk3399_dmc.c -- 2.6.6

2 7

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2016