dri-devel February 2017

dri-devel@lists.freedesktop.org

200 participants
1445 discussions

Do no reset the max link parameters when userspace reprobes modes
by Manasi Navare 07 Feb '17

07 Feb '17

Hi, I am working on a solution for handling link failures during or after the modeset. In case of link failure, the max link rate/lane count values are updated to lower link rate/lane count as per the spec and uevent is sent to the userspace with link-status BAD. The userspace is expected to first retry the existing mode and do a a full reprobe if this fails. When userspace reprobes the modes, it calls drmModeGetConnector() IOCTL, that eventually calls drm_helper_probe_single_connector_modes(). This helper function calls the connector->func->detect() which in case of i915 calls intel_dp_detect() which calls intel_dp_long_pulse() that resets the max_link_rate and max_link_lane_count values. Now during the link training retry, it uses the reset values of link rate/lane count instead of using the lowered link rate/lane count values from link failure. For this to work properly, we should not reset the link rate/lane count values during the fill_modes() operation from userspace. However the current driver calls the long pulse handler again during fill_modes and resets all the values as per DPCD reads which fails to retrain the link at lower rate. How can we handle this situation? Do we need to call long pulse handler again during fill_modes()? Any ideas/suggestions? Regards Manasi

1 0

[Bug 43698] New: On PPC, OpenGL programs use incorrect texture colors.
by bugzilla-daemon＠freedesktop.org 06 Feb '17

06 Feb '17

https://bugs.freedesktop.org/show_bug.cgi?id=43698 Bug #: 43698 Summary: On PPC, OpenGL programs use incorrect texture colors. Classification: Unclassified Product: Mesa Version: git Platform: PowerPC OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r300 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: ghostlydeath(a)gmail.com Created attachment 54298 --> https://bugs.freedesktop.org/attachment.cgi?id=54298 PrBoom With git b1a8b7b0196c73bcfe488cbfc9e9fcd1d7ce7d9b. Texture colors are incorrect, they appear to be ABGR instead of RGBA, thus blue becomes green, red becomes alpha, etc. The only thing that is not affected is glxgears, but that does not use any textures. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 30

[Bug 98869] Electronic Super Joy graphic artefacts (regression)
by bugzilla-daemon＠freedesktop.org 06 Feb '17

06 Feb '17

1 0

[Bug 98869] Electronic Super Joy graphic artefacts (regression)
by bugzilla-daemon＠freedesktop.org 06 Feb '17

06 Feb '17

https://bugs.freedesktop.org/show_bug.cgi?id=98869 --- Comment #17 from cosiekvfj(a)o2.pl --- 172bfdaa9e80342ade3f023f72d455d76713b866 Is cause of the problem! https://cgit.freedesktop.org/mesa/mesa/commit/?h=12.0&id=172bfdaa9e80342ade… -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH -next] drm: mxsfb: fix error return code in mxsfb_load()
by Wei Yongjun 06 Feb '17

06 Feb '17

From: Wei Yongjun <weiyongjun1(a)huawei.com> Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun <weiyongjun1(a)huawei.com> --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c index cdfbe02..28a75cb 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c @@ -221,6 +221,7 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags) mxsfb->fbdev = drm_fbdev_cma_init(drm, 32, drm->mode_config.num_connector); if (IS_ERR(mxsfb->fbdev)) { + ret = PTR_ERR(mxsfb->fbdev); mxsfb->fbdev = NULL; dev_err(drm->dev, "Failed to init FB CMA area\n"); goto err_cma;

3 2

[pull] drm/msm: msm-next for 4.11
by Rob Clark 06 Feb '17

06 Feb '17

Hi Dave, The big things this time around are: 1) support for hw cursor on newer mdp5 devices (snapdragon 820+, tested on db820c) 2) dsi encoder cleanup 3) gpu dt bindings cleanup so we can get the gpu nodes merged upstream The following changes since commit 99743ae4c5f52f8f8ceb17783056fcc9b4f8b64c: Merge branch 'drm-etnaviv-next' of https://git.pengutronix.de/git/lst/linux into drm-next (2017-02-03 05:41:58 +1000) are available in the git repository at: git://people.freedesktop.org/~robclark/linux msm-next for you to fetch changes up to 21c42da18ef128ca8fb4cc4ead888f5c61e3916a: drm/msm: return -EFAULT if copy_from_user() fails (2017-02-06 11:28:45 -0500) ---------------------------------------------------------------- Archit Taneja (22): drm/msm/mdp5: cfg: Add pipe_cursor block drm/msm/mdp5: Update generated headers drm/msm/dsi: Update generated headers drm/msm/dsi: Set msm_dsi->encoders before initializing bridge drm/msm: Construct only one encoder for DSI drm/msm: Set encoder's mode of operation using a kms func drm/msm/mdp5: Prepare for merging video and command encoders drm/msm/mdp5: Create single encoder per interface (INTF) drm/msm/mdp5: cfg: Change count to unsigned int drm/msm/mdp5: Create only as many CRTCs as we need drm/msm/mdp5: Prepare CRTC/LM for empty stages drm/msm/mdp5: Use plane helpers to configure src/dst rectangles drm/msm/mdp5: Configure COLOR3_OUT propagation drm/msm/mdp5: Misc cursor plane bits drm/msm/mdp5: Add cursor planes drm/msm/mdp5: Refactor mdp5_plane_atomic_check drm/msm/mdp5: Add support for legacy cursor updates drm/msm/dsi: Don't error if a DSI host doesn't have a device connected drm/msm/dsi: Add 8x96 info in dsi_cfg drm/msm/dsi: Add a PHY op that initializes version specific stuff drm/msm/dsi: Reset both PHYs before clock operation for dual DSI drm/msm/dsi: Add PHY/PLL for 8x96 Dan Carpenter (1): drm/msm: return -EFAULT if copy_from_user() fails Hai Li (4): drm/msm/dsi: Return more timings from PHY to host drm/msm/dsi: Pass down use case to PHY drm/msm/dsi: Move PHY operations out of host drm/msm/dsi: Add new method to calculate 14nm PHY timings Rob Clark (5): drm/msm: remove qcom,gpu-pwrlevels bindings drm/msm: drop qcom,chipid drm/msm: drop quirks binding drm/msm: drop _clk suffix from clk names drm/msm: let gpu wire up it's own fault handler .../devicetree/bindings/display/msm/gpu.txt | 38 +- drivers/gpu/drm/msm/Kconfig | 7 + drivers/gpu/drm/msm/Makefile | 2 + drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 21 +- drivers/gpu/drm/msm/adreno/adreno_device.c | 62 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 1 - drivers/gpu/drm/msm/adreno/adreno_gpu.h | 4 +- drivers/gpu/drm/msm/dsi/dsi.c | 18 +- drivers/gpu/drm/msm/dsi/dsi.h | 51 +- drivers/gpu/drm/msm/dsi/dsi.xml.h | 269 ++++- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 25 + drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + drivers/gpu/drm/msm/dsi/dsi_host.c | 97 +- drivers/gpu/drm/msm/dsi/dsi_manager.c | 254 +++-- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 239 ++++- drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 20 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 169 +++ drivers/gpu/drm/msm/dsi/phy/dsi_phy_20nm.c | 5 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 6 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 5 +- drivers/gpu/drm/msm/dsi/pll/dsi_pll.c | 12 + drivers/gpu/drm/msm/dsi/pll/dsi_pll.h | 11 + drivers/gpu/drm/msm/dsi/pll/dsi_pll_14nm.c | 1104 ++++++++++++++++++++ drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c | 28 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5.xml.h | 48 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c | 10 + drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h | 3 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_cmd_encoder.c | 135 +-- drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 73 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_ctl.c | 14 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_ctl.h | 4 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c | 77 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 123 ++- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h | 45 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_pipe.c | 8 + drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 181 +++- drivers/gpu/drm/msm/mdp/mdp_kms.h | 1 + drivers/gpu/drm/msm/msm_atomic.c | 26 +- drivers/gpu/drm/msm/msm_drv.c | 20 + drivers/gpu/drm/msm/msm_drv.h | 12 +- drivers/gpu/drm/msm/msm_gem_submit.c | 13 +- drivers/gpu/drm/msm/msm_gpu.c | 7 +- drivers/gpu/drm/msm/msm_iommu.c | 7 +- drivers/gpu/drm/msm/msm_kms.h | 3 + drivers/gpu/drm/msm/msm_mmu.h | 9 + 45 files changed, 2712 insertions(+), 556 deletions(-) create mode 100644 drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c create mode 100644 drivers/gpu/drm/msm/dsi/pll/dsi_pll_14nm.c

1 0

[PATCH] dim: use annotated tags everywhere
by Daniel Vetter 06 Feb '17

06 Feb '17

Kinda no reason only to use them for drm-intel-next ... Acked-by: Jani Nikula <jani.nikula(a)linux.intel.com> Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- dim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dim b/dim index 20eac8c58c58..457bf93d8a11 100755 --- a/dim +++ b/dim @@ -1232,9 +1232,9 @@ function dim_pull_request repo="drm-intel" else tag=$branch-$today - $DRY git tag -f $tag $branch@{upstream} + $DRY git tag -f -a $tag $branch@{upstream} $DRY git push -f $remote $tag - prep_pull_mail + prep_pull_mail $tag repo=`branch_to_repo $branch` fi -- 2.11.0

1 0

[PATCH] drm/panel: simple: ensure Sharp lq123p1jx31 isn't turned off too soon
by Douglas Anderson 06 Feb '17

06 Feb '17

The Sharp lq123p1jx31 has a requirement that the VDD is on for at least 300 ms before being turned off. At the moment nothing anywhere in the kernel is ensuring this. The simplest way to ensure this is to add a "disable" timing of 150 ms. With this the we know that there will be at least 300 ms between the regulator/gpio being turned on and being turned off. Specifically, here's what happens after this change: * prepare: enable regulator, delay 110 ms (10 for regulator, then 100) * enable: delay 50 ms * disable: delay 150 ms, then disable regulator * unprepare: delay 550 ms (50 for regulator, 500 to off=>on too quick) As you can see, even giving the regulator 10 ms (the max the panel spec allows) for ramping up we are sure that the regulator was on for 300 ms now. Signed-off-by: Douglas Anderson <dianders(a)chromium.org> --- drivers/gpu/drm/panel/panel-simple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 89eb0422821c..dbaadfa6b823 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1622,6 +1622,7 @@ static const struct panel_desc sharp_lq123p1jx31 = { .delay = { .prepare = 110, .enable = 50, + .disable = 150, .unprepare = 550, }, }; -- 2.11.0.483.g087da7b7c-goog

3 3

[PATCH] drm: Micro-optimise drm_mm_for_each_node_in_range()
by Chris Wilson 06 Feb '17

06 Feb '17

As we require valid start/end parameters, we can replace the initial potential NULL with a pointer to the drm_mm.head_node and so reduce the test on every iteration from a NULL + address comparison to just an address comparison. add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-26 (-26) function old new delta i915_gem_evict_for_node 719 693 -26 (No other users outside of the test harness.) Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahtinen(a)linux.intel.com> --- drivers/gpu/drm/drm_mm.c | 2 +- drivers/gpu/drm/selftests/test-drm_mm.c | 10 ++++++---- include/drm/drm_mm.h | 5 ++++- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index 8bfb0b327267..f794089d30ac 100644 --- a/drivers/gpu/drm/drm_mm.c +++ b/drivers/gpu/drm/drm_mm.c @@ -170,7 +170,7 @@ struct drm_mm_node * __drm_mm_interval_first(const struct drm_mm *mm, u64 start, u64 last) { return drm_mm_interval_tree_iter_first((struct rb_root *)&mm->interval_tree, - start, last); + start, last) ?: (struct drm_mm_node *)&mm->head_node; } EXPORT_SYMBOL(__drm_mm_interval_first); diff --git a/drivers/gpu/drm/selftests/test-drm_mm.c b/drivers/gpu/drm/selftests/test-drm_mm.c index 1e71bc182ca9..2958f596081e 100644 --- a/drivers/gpu/drm/selftests/test-drm_mm.c +++ b/drivers/gpu/drm/selftests/test-drm_mm.c @@ -839,16 +839,18 @@ static bool assert_contiguous_in_range(struct drm_mm *mm, n++; } - drm_mm_for_each_node_in_range(node, mm, 0, start) { - if (node) { + if (start > 0) { + node = __drm_mm_interval_first(mm, 0, start - 1); + if (node->allocated) { pr_err("node before start: node=%llx+%llu, start=%llx\n", node->start, node->size, start); return false; } } - drm_mm_for_each_node_in_range(node, mm, end, U64_MAX) { - if (node) { + if (end < U64_MAX) { + node = __drm_mm_interval_first(mm, end, U64_MAX); + if (node->allocated) { pr_err("node after end: node=%llx+%llu, end=%llx\n", node->start, node->size, end); return false; diff --git a/include/drm/drm_mm.h b/include/drm/drm_mm.h index d81b0ba9921f..f262da180117 100644 --- a/include/drm/drm_mm.h +++ b/include/drm/drm_mm.h @@ -459,10 +459,13 @@ __drm_mm_interval_first(const struct drm_mm *mm, u64 start, u64 last); * but using the internal interval tree to accelerate the search for the * starting node, and so not safe against removal of elements. It assumes * that @end is within (or is the upper limit of) the drm_mm allocator. + * If [@start, @end] are beyond the range of the drm_mm, the iterator may walk + * over the special _unallocated_ &drm_mm.head_node, and may even continue + * indefinitely. */ #define drm_mm_for_each_node_in_range(node__, mm__, start__, end__) \ for (node__ = __drm_mm_interval_first((mm__), (start__), (end__)-1); \ - node__ && node__->start < (end__); \ + node__->start < (end__); \ node__ = list_next_entry(node__, node_list)) void drm_mm_scan_init_with_range(struct drm_mm_scan *scan, -- 2.11.0

3 3

[Bug 99637] VLC video has corrupted colors when using VDPAU output on Radeon SI
by bugzilla-daemon＠freedesktop.org 06 Feb '17

06 Feb '17

https://bugs.freedesktop.org/show_bug.cgi?id=99637 Bug ID: 99637 Summary: VLC video has corrupted colors when using VDPAU output on Radeon SI Product: Mesa Version: 17.0 Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: freedesktop(a)mattwhitlock.name QA Contact: dri-devel(a)lists.freedesktop.org Two reports of this so far on Gentoo when using Mesa 17.0.0 RC2. See a screenshot here: https://bugs.gentoo.org/attachment.cgi?id=461558 I am reporting this bug upstream (i.e., here) at the request of Gentoo dev Matt Turner. Here is the Gentoo bug report: https://bugs.gentoo.org/show_bug.cgi?id=607368 The problem disappears upon downgrading to Mesa 13.0.3. Mateusz Lenik, the reporter of the bug on Gentoo's tracker, is using a Polaris 10 card, and I am using a Tobago (Bonaire Pro) card. We are both using the "radeonsi" VDPAU driver. -- You are receiving this mail because: You are the assignee for the bug.

1 6

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel February 2017