dri-devel April 2017

dri-devel@lists.freedesktop.org

208 participants
1518 discussions

[Bug 104551] Unable to resume from suspend AMD Radeon HD 6570
by bugzilla-daemon＠bugzilla.kernel.org 02 Apr '17

02 Apr '17

https://bugzilla.kernel.org/show_bug.cgi?id=104551 Ignacio Taranto (itaranto7(a)gmail.com) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |itaranto7(a)gmail.com --- Comment #8 from Ignacio Taranto (itaranto7(a)gmail.com) --- Created attachment 255721 --> https://bugzilla.kernel.org/attachment.cgi?id=255721&action=edit NVIDIA GTX 650 suspend to RAM S1 I'm updating the title of the bug since I'm no longer using an AMD card on this machine. Instead, I'm using a NVIDIA GTX 650 now. OS: openSUSE Leap 42.2 Motherboard: Gigabyte H61M-USB3-B3 rev1.0 Kernel version: 4.4.57-18.3-default Driver version: 375.39 I'm attaching the kernel log from journalctl after suspending to RAM (S1). After waking up from suspend, I got a black screen. I had to use the REISUB magic command to reboot properly. Although I tested with S1 I'll send and update with S3. -- You are receiving this mail because: You are watching the assignee of the bug.

1 0

[Bug 100306] System randomly freezes or crashes to the login screen, glitches until rebooted
by bugzilla-daemon＠freedesktop.org 02 Apr '17

02 Apr '17

https://bugs.freedesktop.org/show_bug.cgi?id=100306 MirceaKitsune <sonichedgehog_hyperblast00(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #11 from MirceaKitsune <sonichedgehog_hyperblast00(a)yahoo.com> --- To my stupefaction, the exact same issue has been re-introduced and is happening again. After another openSUSE Tumbleweed snapshot and several package updates, I believe approximately 2 days ago, the freeze occurs once more. I can however confirm that for approximately 8 days before that, the problem went away as I had one week of uninterrupted uptime. Can someone please analyze what changes fit this time pattern? -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 98897] Macbook pro 11,5 screen flicker when AC adapter plugged in
by bugzilla-daemon＠freedesktop.org 02 Apr '17

02 Apr '17

https://bugs.freedesktop.org/show_bug.cgi?id=98897 --- Comment #26 from extr15 <extr15(a)126.com> --- I can now compile a single radeon module, ref: http://www.codewhirl.com/2012/04/how-to-compile-a-single-module-in-ubuntu-l… however, neither attachment 128481 nor attachment 128780 work for me. the screen still flicker whether plugged in AC adapter or not. I am macbookpro 11,5, and ubuntu 16.04. uname -a: 4.8.0-36-generic #36~16.04.1-Ubuntu SMP Sun Feb 5 09:39:57 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux tail /var/log/Xorg.0.log: [ 877.072] (WW) RADEON(0): radeon_dri2_flip_event_handler: Pageflip completion event has impossible msc 52285 < target_msc 52286 [ 877.222] (WW) RADEON(0): radeon_dri2_flip_event_handler: Pageflip completion event has impossible msc 52294 < target_msc 52295 [ 878.838] (WW) RADEON(0): radeon_dri2_flip_event_handler: Pageflip completion event has impossible msc 52391 < target_msc 52392 anyone helps? thanks! -- You are receiving this mail because: You are the assignee for the bug.

1 0

[RFC] drm: atomic-rmfb semantics
by Rob Clark 02 Apr '17

02 Apr '17

We possibly missed the boat on redefining rmfb semantics for atomic userspace to something more sane, unless perhaps the few existing atomic userspaces (CrOS?) could confirm that this change won't cause problems (in which case we could just call this a bug-fix, drop the cap, and delete some code?). The old semantics of rmfb shutting down the display is kind of pointless in an atomic world, and it is more awkward for userspace that creates and destroys the fb every frame, since they need to defer the rmfb. Since we have better ways for userspace to shut down the display pipe and the legacy behaviour of rmfb is awkward, provide a way for atomic userspace to simply make rmfb an unref. Signed-off-by: Rob Clark <robdclark(a)gmail.com> --- drivers/gpu/drm/drm_framebuffer.c | 2 +- drivers/gpu/drm/drm_ioctl.c | 9 +++++++++ include/drm/drm_file.h | 8 ++++++++ include/uapi/drm/drm.h | 7 +++++++ 4 files changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c index e4909ae..c5127dd0 100644 --- a/drivers/gpu/drm/drm_framebuffer.c +++ b/drivers/gpu/drm/drm_framebuffer.c @@ -383,7 +383,7 @@ int drm_mode_rmfb(struct drm_device *dev, * so run this in a separate stack as there's no way to correctly * handle this after the fb is already removed from the lookup table. */ - if (drm_framebuffer_read_refcount(fb) > 1) { + if (drm_framebuffer_read_refcount(fb) > 1 && !file_priv->atomic_rmfb) { struct drm_mode_rmfb_work arg; INIT_WORK_ONSTACK(&arg.work, drm_mode_rmfb_work_fn); diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index a7c61c2..b42348f 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c @@ -318,6 +318,15 @@ drm_setclientcap(struct drm_device *dev, void *data, struct drm_file *file_priv) file_priv->atomic = req->value; file_priv->universal_planes = req->value; break; + case DRM_CLIENT_CAP_ATOMIC_RMFB: + if (!drm_core_check_feature(dev, DRIVER_ATOMIC)) + return -EINVAL; + if (req->value > 1) + return -EINVAL; + file_priv->atomic = req->value; + file_priv->universal_planes = req->value; + file_priv->atomic_rmfb = req->value; + break; default: return -EINVAL; } diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h index 5dd27ae..2a41c29 100644 --- a/include/drm/drm_file.h +++ b/include/drm/drm_file.h @@ -181,6 +181,14 @@ struct drm_file { unsigned atomic:1; /** + * @atomic_rmfb: + * + * True if client wants new semantics for rmfb, ie. simply dropping + * refcnt without tearing down the display. + */ + unsigned atomic_rmfb:1; + + /** * @is_master: * * This client is the creator of @master. Protected by struct diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index b2c5284..4063cc8 100644 --- a/include/uapi/drm/drm.h +++ b/include/uapi/drm/drm.h @@ -678,6 +678,13 @@ struct drm_get_cap { */ #define DRM_CLIENT_CAP_ATOMIC 3 +/** + * DRM_CLIENT_CAP_ATOMIC_RMFB + * + * If set to 1, the DRM core will not shutdown display pipe on rmfb ioctl. + */ +#define DRM_CLIENT_CAP_ATOMIC_RMFB 4 + /** DRM_IOCTL_SET_CLIENT_CAP ioctl argument type */ struct drm_set_client_cap { __u64 capability; -- 2.9.3

2 4

[Bug 98897] Macbook pro 11,5 screen flicker when AC adapter plugged in
by bugzilla-daemon＠freedesktop.org 02 Apr '17

02 Apr '17

https://bugs.freedesktop.org/show_bug.cgi?id=98897 --- Comment #25 from extr15 <extr15(a)126.com> --- (In reply to berg from comment #20) > Created attachment 128481 [details] [review] > Setting correct core and memory clock for M370X in MBP 11,5 > > No screen flickering after testing out this patch I made on the v4.9 branch. > I confirmed the GPU configuration on this page > https://en.wikipedia.org/wiki/AMD_Radeon_Rx_300_series. Set mclk and sclk > accordingly; assuming that mclk is for memory and sclk is for the GPU clock. > > Noticeably everything is running very nicely. No strange behaviour so far > and both GPU and CPU temps are OK. > > In addition. My CPU turbo boost is also working, which it previously wasn't > on 3.8.6. Test at your own risk. hi berg, thanks for your attachment. I am new to linux kernel, and I don't how to apply your attachment, i.e. how to compile a single radeon.ko ? I find a radeon.ko under "/lib/modules/4.8.0-36-generic/kernel/drivers/gpu/drm/radeon", so I want to compile it, likes here: https://bugzilla.kernel.org/show_bug.cgi?id=105051#c37 I modify si_dpm.c and write a Makefile: obj-m += si_dpm.o all: make -C /lib/modules/$(shell uname -r)/build M=$(PWD) modules clean: make -C /lib/modules/$(shell uname -r)/build M=$(PWD) clean but when make I get: /si_dpm.c:24:18: fatal error: drmP.h: No such file or directory compilation terminated. so could you tell me how to compile a single .ko or if any tutorial I can follow, or I have to compile all the kernel? thanks! -- You are receiving this mail because: You are the assignee for the bug.

1 0

[radeon-alex:drm-next-4.12-wip 190/320] drivers/gpu/drm/amd/amdgpu/amdgpu.h:981:28: error: 'NGG_BUF_MAX' undeclared here (not in a function)
by kbuild test robot 02 Apr '17

02 Apr '17

tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.12-wip head: aaee136fb4cee7136f1436bc5303d2dcff3bba5c commit: bce23e00f3369ce8c32c90f087e37c01f83002d1 [190/320] drm/amdgpu: add NGG parameters config: alpha-allyesconfig (attached as .config) compiler: alpha-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout bce23e00f3369ce8c32c90f087e37c01f83002d1 # save the attached .config to linux build tree make.cross ARCH=alpha All errors (new ones prefixed by >>): In file included from arch/alpha/include/asm/pgtable.h:18:0, from include/linux/mm.h:68, from include/linux/scatterlist.h:7, from include/linux/dma-mapping.h:10, from include/drm/drmP.h:37, from drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c:26: >> arch/alpha/include/uapi/asm/setup.h:27:18: error: expected identifier before '(' token #define ZERO_PGE (PAGE_OFFSET+KERNEL_START_PHYS+0x0A000) ^ arch/alpha/include/uapi/asm/setup.h:37:17: note: in expansion of macro 'ZERO_PGE' #define PARAM ZERO_PGE ^~~~~~~~ drivers/gpu/drm/amd/amdgpu/amdgpu.h:976:2: note: in expansion of macro 'PARAM' PARAM, ^~~~~ In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c:27:0: >> drivers/gpu/drm/amd/amdgpu/amdgpu.h:981:28: error: 'NGG_BUF_MAX' undeclared here (not in a function) struct amdgpu_ngg_buf buf[NGG_BUF_MAX]; ^~~~~~~~~~~ vim +/NGG_BUF_MAX +981 drivers/gpu/drm/amd/amdgpu/amdgpu.h 970 }; 971 972 enum { 973 PRIM = 0, 974 POS, 975 CNTL, > 976 PARAM, 977 NGG_BUF_MAX 978 }; 979 980 struct amdgpu_ngg { > 981 struct amdgpu_ngg_buf buf[NGG_BUF_MAX]; 982 uint32_t gds_reserve_addr; 983 uint32_t gds_reserve_size; 984 bool init; --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[PATCH] drm/nouveau: enable interrupts on cards with 32 intr lines
by Adam Borowski 02 Apr '17

02 Apr '17

The code attempts to enable them, but hits an undefined behaviour by shifting by the entire register's width: int lines = 32; u32 mask = (1 << lines) - 1; // 00000000 on x86 u32 mask = (1 << lines) - 1; // ffffffff on arm (32) u32 mask = (1 << lines) - 1; // 00000000 on arm64 u32 mask = (1ULL << lines) - 1; // ffffffff everywhere Signed-off-by: Adam Borowski <kilobyte(a)angband.pl> --- To be honest, I can't tell the difference other than UBSAN stopping its complaints, but the current code is obviously wrong. drivers/gpu/drm/nouveau/nvkm/subdev/gpio/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/base.c index 77c649723ad7..4a57defc99b3 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/base.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/base.c @@ -164,7 +164,7 @@ static int nvkm_gpio_fini(struct nvkm_subdev *subdev, bool suspend) { struct nvkm_gpio *gpio = nvkm_gpio(subdev); - u32 mask = (1 << gpio->func->lines) - 1; + u32 mask = (1ULL << gpio->func->lines) - 1; gpio->func->intr_mask(gpio, NVKM_GPIO_TOGGLED, mask, 0); gpio->func->intr_stat(gpio, &mask, &mask); -- 2.11.0

1 0

[PATCH 1/6] virtio: wrap find_vqs
by Michael S. Tsirkin 01 Apr '17

01 Apr '17

We are going to add more parameters to find_vqs, let's wrap the call so we don't need to tweak all drivers every time. Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> --- drivers/block/virtio_blk.c | 3 +-- drivers/char/virtio_console.c | 6 +++--- drivers/crypto/virtio/virtio_crypto_core.c | 3 +-- drivers/gpu/drm/virtio/virtgpu_kms.c | 3 +-- drivers/net/caif/caif_virtio.c | 3 +-- drivers/net/virtio_net.c | 3 +-- drivers/rpmsg/virtio_rpmsg_bus.c | 2 +- drivers/scsi/virtio_scsi.c | 3 +-- drivers/virtio/virtio_balloon.c | 3 +-- drivers/virtio/virtio_input.c | 3 +-- include/linux/virtio_config.h | 9 +++++++++ net/vmw_vsock/virtio_transport.c | 6 +++--- 12 files changed, 24 insertions(+), 23 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 1d4c9f8..c08c30c 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -455,8 +455,7 @@ static int init_vq(struct virtio_blk *vblk) } /* Discover virtqueues and write information to configuration. */ - err = vdev->config->find_vqs(vdev, num_vqs, vqs, callbacks, names, - &desc); + err = virtio_find_vqs(vdev, num_vqs, vqs, callbacks, names, &desc); if (err) goto out; diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index e9b7e0b..5da4c8e 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -1945,9 +1945,9 @@ static int init_vqs(struct ports_device *portdev) } } /* Find the queues. */ - err = portdev->vdev->config->find_vqs(portdev->vdev, nr_queues, vqs, - io_callbacks, - (const char **)io_names, NULL); + err = virtio_find_vqs(portdev->vdev, nr_queues, vqs, + io_callbacks, + (const char **)io_names, NULL); if (err) goto free; diff --git a/drivers/crypto/virtio/virtio_crypto_core.c b/drivers/crypto/virtio/virtio_crypto_core.c index 21472e4..a111cd72 100644 --- a/drivers/crypto/virtio/virtio_crypto_core.c +++ b/drivers/crypto/virtio/virtio_crypto_core.c @@ -119,8 +119,7 @@ static int virtcrypto_find_vqs(struct virtio_crypto *vi) names[i] = vi->data_vq[i].name; } - ret = vi->vdev->config->find_vqs(vi->vdev, total_vqs, vqs, callbacks, - names, NULL); + ret = virtio_find_vqs(vi->vdev, total_vqs, vqs, callbacks, names, NULL); if (ret) goto err_find; diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c b/drivers/gpu/drm/virtio/virtgpu_kms.c index 4918668..1e1c90b 100644 --- a/drivers/gpu/drm/virtio/virtgpu_kms.c +++ b/drivers/gpu/drm/virtio/virtgpu_kms.c @@ -175,8 +175,7 @@ int virtio_gpu_driver_load(struct drm_device *dev, unsigned long flags) DRM_INFO("virgl 3d acceleration not supported by guest\n"); #endif - ret = vgdev->vdev->config->find_vqs(vgdev->vdev, 2, vqs, - callbacks, names, NULL); + ret = virtio_find_vqs(vgdev->vdev, 2, vqs, callbacks, names, NULL); if (ret) { DRM_ERROR("failed to find virt queues\n"); goto err_vqs; diff --git a/drivers/net/caif/caif_virtio.c b/drivers/net/caif/caif_virtio.c index bc0eb47..6122768 100644 --- a/drivers/net/caif/caif_virtio.c +++ b/drivers/net/caif/caif_virtio.c @@ -679,8 +679,7 @@ static int cfv_probe(struct virtio_device *vdev) goto err; /* Get the TX virtio ring. This is a "guest side vring". */ - err = vdev->config->find_vqs(vdev, 1, &cfv->vq_tx, &vq_cbs, &names, - NULL); + err = virtio_find_vqs(vdev, 1, &cfv->vq_tx, &vq_cbs, &names, NULL); if (err) goto err; diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index ea9890d..6802169 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -2079,8 +2079,7 @@ static int virtnet_find_vqs(struct virtnet_info *vi) names[txq2vq(i)] = vi->sq[i].name; } - ret = vi->vdev->config->find_vqs(vi->vdev, total_vqs, vqs, callbacks, - names, NULL); + ret = virtio_find_vqs(vi->vdev, total_vqs, vqs, callbacks, names, NULL); if (ret) goto err_find; diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c index 5e66e08..f7cade0 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -869,7 +869,7 @@ static int rpmsg_probe(struct virtio_device *vdev) init_waitqueue_head(&vrp->sendq); /* We expect two virtqueues, rx and tx (and in this order) */ - err = vdev->config->find_vqs(vdev, 2, vqs, vq_cbs, names, NULL); + err = virtio_find_vqs(vdev, 2, vqs, vq_cbs, names, NULL); if (err) goto free_vrp; diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 939c47d..e9222dc 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi/virtio_scsi.c @@ -870,8 +870,7 @@ static int virtscsi_init(struct virtio_device *vdev, } /* Discover virtqueues and write information to configuration. */ - err = vdev->config->find_vqs(vdev, num_vqs, vqs, callbacks, names, - &desc); + err = virtio_find_vqs(vdev, num_vqs, vqs, callbacks, names, &desc); if (err) goto out; diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 34adf9b..408c174 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -418,8 +418,7 @@ static int init_vqs(struct virtio_balloon *vb) * optionally stat. */ nvqs = virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_STATS_VQ) ? 3 : 2; - err = vb->vdev->config->find_vqs(vb->vdev, nvqs, vqs, callbacks, names, - NULL); + err = virtio_find_vqs(vb->vdev, nvqs, vqs, callbacks, names, NULL); if (err) return err; diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c index 79f1293..3a0468f 100644 --- a/drivers/virtio/virtio_input.c +++ b/drivers/virtio/virtio_input.c @@ -173,8 +173,7 @@ static int virtinput_init_vqs(struct virtio_input *vi) static const char * const names[] = { "events", "status" }; int err; - err = vi->vdev->config->find_vqs(vi->vdev, 2, vqs, cbs, names, - NULL); + err = virtio_find_vqs(vi->vdev, 2, vqs, cbs, names, NULL); if (err) return err; vi->evt = vqs[0]; diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h index 8355bab..47f3d80 100644 --- a/include/linux/virtio_config.h +++ b/include/linux/virtio_config.h @@ -179,6 +179,15 @@ struct virtqueue *virtio_find_single_vq(struct virtio_device *vdev, return vq; } +static inline +int virtio_find_vqs(struct virtio_device *vdev, unsigned nvqs, + struct virtqueue *vqs[], vq_callback_t *callbacks[], + const char * const names[], + struct irq_affinity *desc) +{ + return vdev->config->find_vqs(vdev, nvqs, vqs, callbacks, names, desc); +} + /** * virtio_device_ready - enable vq use in probe function * @vdev: the device diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index 68675a1..97e26e2 100644 --- a/net/vmw_vsock/virtio_transport.c +++ b/net/vmw_vsock/virtio_transport.c @@ -573,9 +573,9 @@ static int virtio_vsock_probe(struct virtio_device *vdev) vsock->vdev = vdev; - ret = vsock->vdev->config->find_vqs(vsock->vdev, VSOCK_VQ_MAX, - vsock->vqs, callbacks, names, - NULL); + ret = virtio_find_vqs(vsock->vdev, VSOCK_VQ_MAX, + vsock->vqs, callbacks, names, + NULL); if (ret < 0) goto out; -- MST

5 7

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2017