dri-devel May 2017

dri-devel@lists.freedesktop.org

207 participants
1452 discussions

[PATCH] drm/i915: use memdup_user_nul
by Geliang Tang 08 May '17

08 May '17

Use memdup_user_nul() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang <geliangtang(a)gmail.com> --- drivers/gpu/drm/i915/i915_debugfs.c | 13 +++---------- drivers/gpu/drm/i915/intel_pipe_crc.c | 13 +++---------- 2 files changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index d689e51..e56b636 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -3704,16 +3704,10 @@ static ssize_t i915_displayport_test_active_write(struct file *file, if (len == 0) return 0; - input_buffer = kmalloc(len + 1, GFP_KERNEL); - if (!input_buffer) - return -ENOMEM; + input_buffer = memdup_user_nul(ubuf, len); + if (IS_ERR(input_buffer)) + return PTR_ERR(input_buffer); - if (copy_from_user(input_buffer, ubuf, len)) { - status = -EFAULT; - goto out; - } - - input_buffer[len] = '\0'; DRM_DEBUG_DRIVER("Copied %d bytes from user\n", (unsigned int)len); drm_connector_list_iter_begin(dev, &conn_iter); @@ -3739,7 +3733,6 @@ static ssize_t i915_displayport_test_active_write(struct file *file, } } drm_connector_list_iter_end(&conn_iter); -out: kfree(input_buffer); if (status < 0) return status; diff --git a/drivers/gpu/drm/i915/intel_pipe_crc.c b/drivers/gpu/drm/i915/intel_pipe_crc.c index 206ee4f..813dd3c 100644 --- a/drivers/gpu/drm/i915/intel_pipe_crc.c +++ b/drivers/gpu/drm/i915/intel_pipe_crc.c @@ -842,19 +842,12 @@ static ssize_t display_crc_ctl_write(struct file *file, const char __user *ubuf, return -E2BIG; } - tmpbuf = kmalloc(len + 1, GFP_KERNEL); - if (!tmpbuf) - return -ENOMEM; - - if (copy_from_user(tmpbuf, ubuf, len)) { - ret = -EFAULT; - goto out; - } - tmpbuf[len] = '\0'; + tmpbuf = memdup_user_nul(ubuf, len); + if (IS_ERR(tmpbuf)) + return PTR_ERR(tmpbuf); ret = display_crc_ctl_parse(dev_priv, tmpbuf, len); -out: kfree(tmpbuf); if (ret < 0) return ret; -- 2.9.3

2 1

[PATCH 0/3] drm: tackle byteorder issues, take three ...
by Gerd Hoffmann 08 May '17

08 May '17

Hi, Ok, next round. Patches 1+2 are unmodified, driver updates are left out for now. Patch #3 adds a new drm_mode_legacy_fb_format_he() function instead of changing drm_mode_legacy_fb_format behavior, so we keep things working for now. Comments? Suggestions how to handle the drm_mode_legacy_fb_format() call in drm_mode_addfb() ? Add some driver flag? Gerd Hoffmann (3): drm: fourcc byteorder: drop DRM_FORMAT_BIG_ENDIAN drm: fourcc byteorder: add DRM_FORMAT_CPU_* drm: fourcc byteorder: add drm_mode_legacy_fb_format_he include/drm/drm_fourcc.h | 15 +++++++++++ include/uapi/drm/drm_fourcc.h | 2 -- drivers/gpu/drm/drm_fourcc.c | 57 ++++++++++++++++++++++++++++++++++++--- drivers/gpu/drm/drm_framebuffer.c | 2 +- 4 files changed, 70 insertions(+), 6 deletions(-) -- 2.9.3

5 11

[PATCH v2] drm/rockchip: analogix_dp: add supports for regulators in edp IP
by Randy Li 07 May '17

07 May '17

I found if eDP_AVDD_1V0 and eDP_AVDD_1V8 are not been power at RK3288, once trying to enable the pclk clock, the kernel would dead. This patch would try to enable them first. The eDP_AVDD_1V8 is used for eDP phy, and the eDP_AVDD_1V0 are used both for eDP phy and controller. Change-Id: I4e8a34609d5b292d7da77385ff15bebbf258090c Signed-off-by: Randy Li <ayaka(a)soulik.info> Signed-off-by: Randy Li <randy.li(a)rock-chips.com> --- .../display/rockchip/analogix_dp-rockchip.txt | 4 ++ drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 52 ++++++++++++++++++++++ 2 files changed, 56 insertions(+) diff --git a/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt index 47665a1..0dbbfb3 100644 --- a/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt +++ b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt @@ -34,6 +34,10 @@ Optional property for different chips: - clock-names: from common clock binding: Required elements: "grf" +- vcc-supply: Regulator for eDP_AVDD_1V0. + +- vccio-supply: Regulator for eDP_AVDD_1V8. + For the below properties, please refer to Analogix DP binding document: * Documentation/devicetree/bindings/display/bridge/analogix_dp.txt - phys (required) diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c index d8fa7a9..2dad625 100644 --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c @@ -17,6 +17,7 @@ #include <linux/of_device.h> #include <linux/of_graph.h> #include <linux/regmap.h> +#include <linux/regulator/consumer.h> #include <linux/reset.h> #include <linux/clk.h> @@ -70,6 +71,8 @@ struct rockchip_dp_device { struct clk *grfclk; struct regmap *grf; struct reset_control *rst; + struct regulator *vcc_supply; + struct regulator *vccio_supply; struct work_struct psr_work; spinlock_t psr_lock; @@ -146,6 +149,24 @@ static int rockchip_dp_poweron(struct analogix_dp_plat_data *plat_data) cancel_work_sync(&dp->psr_work); + if (!IS_ERR(dp->vcc_supply)) { + ret = regulator_enable(dp->vcc_supply); + if (ret) { + dev_err(dp->dev, + "failed to enable vcc regulator: %d\n", ret); + return ret; + } + } + + if (!IS_ERR(dp->vccio_supply)) { + ret = regulator_enable(dp->vccio_supply); + if (ret) { + dev_err(dp->dev, + "failed to enable vccio regulator: %d\n", ret); + return ret; + } + } + ret = clk_prepare_enable(dp->pclk); if (ret < 0) { dev_err(dp->dev, "failed to enable pclk %d\n", ret); @@ -168,6 +189,11 @@ static int rockchip_dp_powerdown(struct analogix_dp_plat_data *plat_data) clk_disable_unprepare(dp->pclk); + if (!IS_ERR(dp->vccio_supply)) + regulator_disable(dp->vccio_supply); + if (!IS_ERR(dp->vcc_supply)) + regulator_disable(dp->vcc_supply); + return 0; } @@ -323,6 +349,32 @@ static int rockchip_dp_init(struct rockchip_dp_device *dp) return PTR_ERR(dp->rst); } + dp->vcc_supply = devm_regulator_get_optional(dev, "vcc"); + dp->vccio_supply = devm_regulator_get_optional(dev, "vccio"); + + if (IS_ERR(dp->vcc_supply)) { + dev_err(dev, "failed to get vcc regulator: %ld\n", + PTR_ERR(dp->vcc_supply)); + } else { + ret = regulator_enable(dp->vcc_supply); + if (ret) { + dev_err(dev, + "failed to enable vcc regulator: %d\n", ret); + return ret; + } + } + if (IS_ERR(dp->vccio_supply)) { + dev_err(dev, "failed to get vccio regulator: %ld\n", + PTR_ERR(dp->vccio_supply)); + } else { + ret = regulator_enable(dp->vccio_supply); + if (ret) { + dev_err(dev, + "failed to enable vccio regulator: %d\n", ret); + return ret; + } + } + ret = clk_prepare_enable(dp->pclk); if (ret < 0) { dev_err(dp->dev, "failed to enable pclk %d\n", ret); -- 2.9.3

1 0

[PATCH v2 1/2] drm/i915: intel_crtc_page_flip: Add intel_state local variable
by Hans de Goede 07 May '17

07 May '17

Add intel_state local variable to avoid recalling to_intel_plane_state all the time. Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- drivers/gpu/drm/i915/intel_display.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index ed1f4f272b4f..3664707950c7 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -12146,6 +12146,8 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *old_fb = crtc->primary->fb; struct drm_i915_gem_object *obj = intel_fb_obj(fb); struct intel_crtc *intel_crtc = to_intel_crtc(crtc); + struct intel_plane_state *intel_state = + to_intel_plane_state(crtc->primary->state); struct drm_plane *primary = crtc->primary; enum pipe pipe = intel_crtc->pipe; struct intel_flip_work *work; @@ -12262,8 +12264,8 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc, goto cleanup_pending; } - work->old_vma = to_intel_plane_state(primary->state)->vma; - to_intel_plane_state(primary->state)->vma = vma; + work->old_vma = intel_state->vma; + intel_state->vma = vma; work->gtt_offset = i915_ggtt_offset(vma) + intel_crtc->dspaddr_offset; work->rotation = crtc->primary->state->rotation; @@ -12276,8 +12278,7 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc, * be on the safe side and do this immediately before scheduling the * flip. */ - intel_fbc_pre_update(intel_crtc, intel_crtc->config, - to_intel_plane_state(primary->state)); + intel_fbc_pre_update(intel_crtc, intel_crtc->config, intel_state); if (mmio_flip) { INIT_WORK(&work->mmio_work, intel_mmio_flip_work_func); @@ -12320,7 +12321,7 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc, cleanup_request: i915_add_request_no_flush(request); cleanup_unpin: - to_intel_plane_state(primary->state)->vma = work->old_vma; + intel_state->vma = work->old_vma; intel_unpin_fb_vma(vma); cleanup_pending: atomic_dec(&intel_crtc->unpin_work_count); -- 2.12.2

1 1

[PATCH 0/2] rcar-du, vsp1: rcar-gen3: Add support for colorkey alpha blending
by agheorghe 07 May '17

07 May '17

Currently, rcar-du supports colorkeying only for rcar-gen2 and it uses some hw capability of the display unit(DU) which is not available on gen3. In order to implement colorkeying for gen3 we need to use the colorkey capability of the VSPD, hence the need to change both drivers rcar-du and vsp1. This patchset had been developed and tested on top of v4.9/rcar-3.5.1 from git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git agheorghe (2): v4l: vsp1: Add support for colorkey alpha blending drm: rcar-du: Add support for colorkey alpha blending drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 + drivers/gpu/drm/rcar-du/rcar_du_kms.c | 8 ++++++++ drivers/gpu/drm/rcar-du/rcar_du_plane.c | 3 --- drivers/gpu/drm/rcar-du/rcar_du_plane.h | 6 ++++++ drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 22 ++++++++++++++++++++++ drivers/gpu/drm/rcar-du/rcar_du_vsp.h | 5 +++++ drivers/media/platform/vsp1/vsp1_drm.c | 3 +++ drivers/media/platform/vsp1/vsp1_rpf.c | 10 ++++++++-- drivers/media/platform/vsp1/vsp1_rwpf.h | 3 +++ include/media/vsp1.h | 3 +++ 10 files changed, 59 insertions(+), 5 deletions(-) -- 1.9.1

5 6

[Bug 100437] IO_PAGE_FAULT is spammed in dmesg
by bugzilla-daemon＠freedesktop.org 07 May '17

07 May '17

https://bugs.freedesktop.org/show_bug.cgi?id=100437 Gjorgji Jankovski <j.gjorgji(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #4 from Gjorgji Jankovski <j.gjorgji(a)gmail.com> --- This is definitely not fixed yet, at least for me. Ryzen 7 1700 MSI B350 TOMAHAWK RX 480 Fedora 26 Kernel: 4.11.0-1.fc26.x86_64 My error message is this: [ 2.339023] AMD-Vi: Event logged [ [ 2.339024] IO_PAGE_FAULT device=23:00.0 domain=0x0003 address=0x000000f4001f0400 flags=0x0010] Reappears a lot in dmesg. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH 1/2] drm: Make fbdev inherit the crtc's initial rotation
by Hans de Goede 06 May '17

06 May '17

Hi All, So I recently bought a (second-hand) Bay Trail tablet which has its LCD mounted upside-down. As such I've ported Ville Syrjala's patches to deal with this to current mainline and I'm hereby posting them upstream for merging. These patches fix the kernel-console as well as the boot-splash (at leats plymouth does not reset the rotation) being upside down as soon as a native kms driver such as the i915 driver is loaded. This fixes the orientation of the displayed image from boot till the Xserver or a Wayland compositor takes over. I've a patch for iio-sensor-proxy which fixes the rotation under Xorg / Wayland when using a desktop environment which honors iio-sensor-proxy's rotation detection: https://github.com/hadess/iio-sensor-proxy/pull/162 Regards, Hans

3 13

I2C failures with recent laptops and docking stations
by Sanford Rockowitz 06 May '17

06 May '17

The following bug was just posted: i915 failures with recent chips and docking stations <https://bugs.freedesktop.org/show_bug.cgi?id=100954> and follows up this thread <https://lists.freedesktop.org/archives/intel-gfx/2017-May/127350.html>in the intel-gfx mailing list. Per suggestion of Jani Nikula of Intel, I'm also posting a brief summary to this list. I am the developer of ddcutil <http://www.ddcutil.com>, a Linux utility that manages monitor settings using DDC/CI. I am seeing a pattern of user error reports in which I2C communication is not working when a system with a recent Intel chip, using the i915 driver, is plugged into a docking station. ddcutil looks for displays by examining all non-SMBus /dev/i2c devices on the system. If checks for the presence of slave address x50 and x37. If they exist it tries to read the EDID on x50 and a Virtual Control Panel feature value on x37. Examining one of the user logs, I see that two /dev/i2c-n devices have udev sysattr name DPMST. When ddcutil probes those /dev/i2c devices, slave addresses x50 and x37 appear active, but reading the EDID fails. Per Jani Nikola, this is likely a bug in the core drm DP MST code. Sanford Rockowitz

1 0

Re: [PATCH 1/3] RFC: drm: Restrict vblank ioctl to master
by Rainer Hochecker 06 May '17

06 May '17

We have been using this for years now and did not observe issues you mentioned. I would be surprised if a child window refreshes in a different rate than the main window Am 13.07.2016 11:44 schrieb "Michel Dänzer" <michel(a)daenzer.net>: On 13.07.2016 15:50, Rainer Hochecker wrote: > Whatever action is taken, it is fine for Kodi. GLX+OML_sync_control is > not an option anymore because we need EGL for vaapi. But we can fall > back to the invisible window for getting vsync. I never tried using EGL > and GLX in the same application, different windows. Any reason why this > should not work? An invisible window may not synchronize with the same output refresh cycle as your output window. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

4 5

[Bug 194721] New: Reading /sys/bus/pci/devices/0000:01:00.0/config wakes up Radeon dGPU
by bugzilla-daemon＠bugzilla.kernel.org 05 May '17

05 May '17

https://bugzilla.kernel.org/show_bug.cgi?id=194721 Bug ID: 194721 Summary: Reading /sys/bus/pci/devices/0000:01:00.0/config wakes up Radeon dGPU Product: Drivers Version: 2.5 Kernel Version: 4.8 and newer Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: eugene.shalygin(a)gmail.com Regression: No Created attachment 254957 --> https://bugzilla.kernel.org/attachment.cgi?id=254957&action=edit dmesg In ArchLinux with kernel 4.8 and newer accessing file /sys/bus/pci/devices/0000:01:00.0/config wakes up dGPU (like DRI_PRIME=1 glxinfo would do). Since many program read that file at startup, this is highly annoying. $ lspci 00:00.0 Host bridge: Intel Corporation Xeon E3-1200 v3/4th Gen Core Processor DRAM Controller (rev 06) 00:01.0 PCI bridge: Intel Corporation Xeon E3-1200 v3/4th Gen Core Processor PCI Express x16 Controller (rev 06) 00:02.0 VGA compatible controller: Intel Corporation 4th Gen Core Processor Integrated Graphics Controller (rev 06) 00:03.0 Audio device: Intel Corporation Xeon E3-1200 v3/4th Gen Core Processor HD Audio Controller (rev 06) 00:14.0 USB controller: Intel Corporation 8 Series/C220 Series Chipset Family USB xHCI (rev 05) 00:16.0 Communication controller: Intel Corporation 8 Series/C220 Series Chipset Family MEI Controller #1 (rev 04) 00:1a.0 USB controller: Intel Corporation 8 Series/C220 Series Chipset Family USB EHCI #2 (rev 05) 00:1b.0 Audio device: Intel Corporation 8 Series/C220 Series Chipset High Definition Audio Controller (rev 05) 00:1c.0 PCI bridge: Intel Corporation 8 Series/C220 Series Chipset Family PCI Express Root Port #1 (rev d5) 00:1c.1 PCI bridge: Intel Corporation 8 Series/C220 Series Chipset Family PCI Express Root Port #2 (rev d5) 00:1c.2 PCI bridge: Intel Corporation 8 Series/C220 Series Chipset Family PCI Express Root Port #3 (rev d5) 00:1c.3 PCI bridge: Intel Corporation 8 Series/C220 Series Chipset Family PCI Express Root Port #4 (rev d5) 00:1d.0 USB controller: Intel Corporation 8 Series/C220 Series Chipset Family USB EHCI #1 (rev 05) 00:1f.0 ISA bridge: Intel Corporation HM87 Express LPC Controller (rev 05) 00:1f.2 SATA controller: Intel Corporation 8 Series/C220 Series Chipset Family 6-port SATA Controller 1 [AHCI mode] (rev 05) 00:1f.3 SMBus: Intel Corporation 8 Series/C220 Series Chipset Family SMBus Controller (rev 05) 01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Neptune XT [Radeon HD 8970M] 03:00.0 PCI bridge: Texas Instruments XIO2213A/B/XIO2221 PCI Express to PCI Bridge [Cheetah Express] (rev 01) 04:00.0 FireWire (IEEE 1394): Texas Instruments XIO2213A/B/XIO2221 IEEE-1394b OHCI Controller [Cheetah Express] (rev 01) 05:00.0 Unassigned class [ff00]: Realtek Semiconductor Co., Ltd. RTL8411 PCI Express Card Reader (rev 01) 05:00.2 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 0a) 06:00.0 Network controller: Intel Corporation Wireless 7260 (rev bb) At the same time on the almost identical machine running Gentoo: $ diff -U 1 lspci.txt lspci.txt.gentoo --- lspci.txt 2017-02-27 09:55:03.885457274 +0100 +++ lspci.txt.gentoo 2017-02-27 09:55:21.978499749 +0100 @@ -16,3 +16,3 @@ 00:1f.3 SMBus: Intel Corporation 8 Series/C220 Series Chipset Family SMBus Controller (rev 05) -01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Neptune XT [Radeon HD 8970M] +01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Neptune XT [Radeon HD 8970M] (rev ff) 03:00.0 PCI bridge: Texas Instruments XIO2213A/B/XIO2221 PCI Express to PCI Bridge [Cheetah Express] (rev 01) @@ -21,2 +21,2 @@ 05:00.2 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 0a) -06:00.0 Network controller: Intel Corporation Wireless 7260 (rev bb) +06:00.0 Network controller: Intel Corporation Wireless 7260 (rev 73) this does not happen. Rebuilding kernel with copied from the Gentoo machine config changed nothing. The attached dmesg output contains several such events at the end of the file. When the dGPU is disabled using acpi_call and its example turn_off_gpu.sh script, accessing the /sys/bus/pci/devices/0000:01:00.0/config hangs a process (it does not react to SIGKILL). -- You are receiving this mail because: You are watching the assignee of the bug.

1 8

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2017