dri-devel May 2017

dri-devel@lists.freedesktop.org

207 participants
1452 discussions

Probing modes and validating them
by Jose Abreu 02 May '17

02 May '17

Hi All, Is there any callback available, at the crtc level, that can validate the probed modes before making them available for userspace? I mean: I know that there is connector->mode_valid(), but I couldn't find any equivalent crtc->mode_valid(). I found mode_fixup() but this is called after giving the mode to userspace, which is not what I need. For reference here is the situation I'm facing: ARCPGU is a DRM driver that uses ADV7511 as connector/bridge. The PGU encodes raw video into a stream that ADV can understands and in order to do this it needs a pixel clock. Currently this pixel clock value is fixed, so technically arcpgu driver supports only one video mode. There is a patch currently on discussion that adds more supported frequencies for arcpgu, but there are still some frequencies that will not be supported. This is NOT a limitation in ADV7511, so it doesn't make sense to limit the available modes in adv, we could instead limit the modes in the crtc level (i.e. the pgu). In order to know if a mode can be displayed or not it is as simple as call clk_round_rate() and check if the returned frequency is the same. But in order to do this I need some sort of callback that is called at the crtc level and before delivering modes to userspace. I believe this would be a good addition to arcpgu because this way we wouldn't "fool" userspace by delivering modes that will fail in atomic check. The user may still specify manually a mode, this will still fail in atomic check, but the difference is that this mode will not be in the probed list. Best regards, Jose Miguel Abreu

3 3

[PATCH v4 1/9] drm/atomic: Handle aspect ratio and scaling mode in core
by Maarten Lankhorst 02 May '17

02 May '17

This is required to for i915 to convert connector properties to atomic. Signed-off-by: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Cc: dri-devel(a)lists.freedesktop.org --- drivers/gpu/drm/drm_atomic.c | 8 ++++++++ include/drm/drm_connector.h | 3 +++ 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index f32506a7c1d6..052cfe2376f8 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -1123,6 +1123,10 @@ int drm_atomic_connector_set_property(struct drm_connector *connector, */ if (state->link_status != DRM_LINK_STATUS_GOOD) state->link_status = val; + } else if (property == config->aspect_ratio_property) { + state->picture_aspect_ratio = val; + } else if (property == config->scaling_mode_property) { + state->scaling_mode = val; } else if (connector->funcs->atomic_set_property) { return connector->funcs->atomic_set_property(connector, state, property, val); @@ -1199,6 +1203,10 @@ drm_atomic_connector_get_property(struct drm_connector *connector, *val = state->tv.hue; } else if (property == config->link_status_property) { *val = state->link_status; + } else if (property == config->aspect_ratio_property) { + *val = state->picture_aspect_ratio; + } else if (property == config->scaling_mode_property) { + *val = state->scaling_mode; } else if (connector->funcs->atomic_get_property) { return connector->funcs->atomic_get_property(connector, state, property, val); diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index 4eeda120e46d..3b819cd1d858 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -326,6 +326,9 @@ struct drm_connector_state { struct drm_atomic_state *state; struct drm_tv_connector_state tv; + + unsigned int picture_aspect_ratio; + unsigned int scaling_mode; }; /** -- 2.7.4

2 5

[PATCH 1/3] drm/vc4: Turn the V3D clock on at runtime.
by Eric Anholt 02 May '17

02 May '17

For the Raspberry Pi's bindings, the power domain also implicitly turns on the clock and deasserts reset, but for the new Cygnus port we start representing the clock in the devicetree. Signed-off-by: Eric Anholt <eric(a)anholt.net> --- .../devicetree/bindings/display/brcm,bcm-vc4.txt | 3 ++ drivers/gpu/drm/vc4/vc4_drv.h | 1 + drivers/gpu/drm/vc4/vc4_v3d.c | 33 ++++++++++++++++++++++ 3 files changed, 37 insertions(+) diff --git a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt index ca02d3e4db91..bc1756f4f791 100644 --- a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt +++ b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt @@ -59,6 +59,9 @@ Required properties for V3D: - interrupts: The interrupt number See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt +Optional properties for V3D: +- clocks: The clock the unit runs on + Required properties for DSI: - compatible: Should be "brcm,bcm2835-dsi0" or "brcm,bcm2835-dsi1" - reg: Physical base address and length of the DSI block's registers diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h index 81d2bc08e766..08d5c2213c80 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.h +++ b/drivers/gpu/drm/vc4/vc4_drv.h @@ -189,6 +189,7 @@ struct vc4_v3d { struct vc4_dev *vc4; struct platform_device *pdev; void __iomem *regs; + struct clk *clk; }; struct vc4_hvs { diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c index 7cc346ad9b0b..2442622e6bff 100644 --- a/drivers/gpu/drm/vc4/vc4_v3d.c +++ b/drivers/gpu/drm/vc4/vc4_v3d.c @@ -16,6 +16,7 @@ * this program. If not, see <http://www.gnu.org/licenses/>. */ +#include "linux/clk.h" #include "linux/component.h" #include "linux/pm_runtime.h" #include "vc4_drv.h" @@ -164,6 +165,9 @@ static int vc4_v3d_runtime_suspend(struct device *dev) vc4_irq_uninstall(vc4->dev); + if (v3d->clk) + clk_disable_unprepare(v3d->clk); + return 0; } @@ -172,6 +176,13 @@ static int vc4_v3d_runtime_resume(struct device *dev) struct vc4_v3d *v3d = dev_get_drvdata(dev); struct vc4_dev *vc4 = v3d->vc4; + if (v3d->clk) { + int ret = clk_prepare_enable(v3d->clk); + + if (ret != 0) + return ret; + } + vc4_v3d_init_hw(vc4->dev); vc4_irq_postinstall(vc4->dev); @@ -202,12 +213,34 @@ static int vc4_v3d_bind(struct device *dev, struct device *master, void *data) vc4->v3d = v3d; v3d->vc4 = vc4; + v3d->clk = devm_clk_get(dev, "v3d_clk"); + if (IS_ERR(v3d->clk)) { + int ret = PTR_ERR(v3d->clk); + + if (ret == -ENODEV) { + /* bcm2835 didn't have a clock reference in the DT. */ + ret = 0; + v3d->clk = NULL; + } else { + if (ret != -EPROBE_DEFER) + dev_err(dev, "Failed to get V3D clock: %d\n", + ret); + return ret; + } + } + if (V3D_READ(V3D_IDENT0) != V3D_EXPECTED_IDENT0) { DRM_ERROR("V3D_IDENT0 read 0x%08x instead of 0x%08x\n", V3D_READ(V3D_IDENT0), V3D_EXPECTED_IDENT0); return -EINVAL; } + if (v3d->clk) { + ret = clk_prepare_enable(v3d->clk); + if (ret != 0) + return ret; + } + /* Reset the binner overflow address/size at setup, to be sure * we don't reuse an old one. */ -- 2.11.0

5 17

[PATCH libdrm v2] Header: Add rotation property fields
by Robert Foss 02 May '17

02 May '17

From: Sean Paul <seanpaul(a)chromium.org> >From drm_crtc.h, for use with the plane "rotation" property. Signed-off-by: Sean Paul <seanpaul(a)chromium.org> Signed-off-by: Robert Foss <robert.foss(a)collabora.com> Reviewed-by: Sumit Semwal <sumit.semwal(a)linaro.org> --- Changes since v1: - Added r-b include/drm/drm.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/include/drm/drm.h b/include/drm/drm.h index 1e7a4bc7a505..656c90045161 100644 --- a/include/drm/drm.h +++ b/include/drm/drm.h @@ -74,6 +74,14 @@ extern "C" { #define _DRM_LOCK_IS_CONT(lock) ((lock) & _DRM_LOCK_CONT) #define _DRM_LOCKING_CONTEXT(lock) ((lock) & ~(_DRM_LOCK_HELD|_DRM_LOCK_CONT)) +/* Rotation property bits */ +#define DRM_ROTATE_0 0 +#define DRM_ROTATE_90 1 +#define DRM_ROTATE_180 2 +#define DRM_ROTATE_270 3 +#define DRM_REFLECT_X 4 +#define DRM_REFLECT_Y 5 + typedef unsigned int drm_context_t; typedef unsigned int drm_drawable_t; typedef unsigned int drm_magic_t; -- 2.11.0.453.g787f75f05

5 8

[PATCH v5 0/5] replace hwmon_device_register for hwmon_device_register_with_info
by Oscar Salvador 02 May '17

02 May '17

This v5 drops a check for attr_set. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild complains. v4 -> v5: * Drops a check for attr_set in "nouveau_temp_is_visible". This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Oscar Salvador (5): nouveau_hwmon: Add config for all sensors and their settings nouveau_hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string nouveau_hwmon: Remove old code, add .write/.read operations nouveau_hwmon: Add support for auto_point attributes nouveau_hwmon: Change permissions to numeric drivers/gpu/drm/nouveau/nouveau_hwmon.c | 953 +++++++++++++++++--------------- 1 file changed, 499 insertions(+), 454 deletions(-) -- 2.1.4

3 11

[Bug 99784] AMD 7470m When VGA plugged into laptop, only one monitor working at a time
by bugzilla-daemon＠freedesktop.org 02 May '17

02 May '17

https://bugs.freedesktop.org/show_bug.cgi?id=99784 --- Comment #12 from lazanet96(a)gmail.com --- Problem persists with Ubuntu 17.10 / DRM 2.49.0 / 4.11.0-041100rc8-lowlatency, LLVM 4.0.0 Tested all resolution options for all three of the monitors, and has been able to output either on HDMI and VGA or HDMI and LVDS (internal). I have no idea what else could I test (or which code could I look at). Would setting drm.debug flag to 0x4 in GRUB provide some more relevant data? Also, I have found this forum thread about the same issue, which dates from 2013: https://ubuntuforums.org/showthread.php?t=2194601 -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 100896] Can't set screen scaling modes for external monitors.
by bugzilla-daemon＠freedesktop.org 02 May '17

02 May '17

https://bugs.freedesktop.org/show_bug.cgi?id=100896 Bug ID: 100896 Summary: Can't set screen scaling modes for external monitors. Product: DRI Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: General Assignee: dri-devel(a)lists.freedesktop.org Reporter: haakobja(a)gmail.com My PC is connected to my TV using HDMI and the xorg-modesetting driver. Recently I've begun testing some older games using wine, only to discover that screen scaling is not available. I now it is available for Radeon hardware, but it would be nice to also be able to use it using the modesetting driver. This issue is related to bug #90989. A bit offtopic, but I think when setting "screen scaling" to "full aspect" or "full" it should be able to use every resolution lower than the desktop resolution. Also I would like to be able to change the screen refresh rate when using "screen scaling" -- You are receiving this mail because: You are the assignee for the bug.

1 1

[REGRESSION][v4.11-rc7] drm/nouveau: initial support (display-only) for GP107
by Joseph Salisbury 01 May '17

01 May '17

Hi Ben, A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug: commit da2ba564a6dcf46df4f828624ff55531ff11d5b0 Author: Ben Skeggs <bskeggs(a)redhat.com> Date: Thu Apr 6 10:35:26 2017 +1000 drm/nouveau: initial support (display-only) for GP107 The regression was introduced as of v4.11-rc7. I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request? Thanks, Joe [0] http://pad.lv/1685865

1 0

[PATCH] drm/vmwgfx: Handle vmalloc() failure in vmw_local_fifo_reserve()
by Dan Carpenter 01 May '17

01 May '17

If vmalloc() fails then we need to a bit of cleanup before returning. Fixes: fb1d9738ca05 ("drm/vmwgfx: Add DRM driver for VMware Virtual GPU") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c index b6a0806b06bf..a1c68e6a689e 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c @@ -368,6 +368,8 @@ static void *vmw_local_fifo_reserve(struct vmw_private *dev_priv, return fifo_state->static_buffer; else { fifo_state->dynamic_buffer = vmalloc(bytes); + if (!fifo_state->dynamic_buffer) + goto out_err; return fifo_state->dynamic_buffer; } }

2 1

[PATCH 0/4] drm/dp: Fine-tuning for three function implementations
by SF Markus Elfring 01 May '17

01 May '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Mon, 1 May 2017 18:38:08 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Use seq_putc() in drm_dp_mst_dump_topology() Combine two seq_printf() calls into one call in drm_dp_mst_dump_topology() Replace six seq_printf() calls by seq_puts() in drm_dp_mst_dump_topology() Adjust four checks for null pointers drivers/gpu/drm/drm_dp_mst_topology.c | 35 +++++++++++++++++------------------ 1 file changed, 17 insertions(+), 18 deletions(-) -- 2.12.2

2 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2017