dri-devel September 2017

dri-devel@lists.freedesktop.org

210 participants
1526 discussions

[PATCH libdrm 1/1] amdgpu: Do not write beyond allocated memory when parsing ids
by Jan Vesely 05 Sep '17

05 Sep '17

Fixes crash when/usr/share/libdrm/amdgpu.ids contains ASIC_ID_TABLE_NUM_ENTRIES + 1 entries. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102432 Signed-off-by: Jan Vesely <jan.vesely(a)rutgers.edu> --- Compile tested only. amdgpu/amdgpu_asic_id.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/amdgpu/amdgpu_asic_id.c b/amdgpu/amdgpu_asic_id.c index 3a88896b..e8218974 100644 --- a/amdgpu/amdgpu_asic_id.c +++ b/amdgpu/amdgpu_asic_id.c @@ -186,19 +186,20 @@ int amdgpu_parse_asic_ids(struct amdgpu_asic_id **p_asic_id_table) table_size++; } - /* end of table */ - id = asic_id_table + table_size; - memset(id, 0, sizeof(struct amdgpu_asic_id)); - if (table_size != table_max_size) { id = realloc(asic_id_table, (table_size + 1) * sizeof(struct amdgpu_asic_id)); - if (!id) + if (!id) { r = -ENOMEM; - else - asic_id_table = id; + goto free; + } + asic_id_table = id; } + /* end of table */ + id = asic_id_table + table_size; + memset(id, 0, sizeof(struct amdgpu_asic_id)); + free: free(line); -- 2.13.5

2 1

[RFC PATCH] drm/nouveau/therm: initial implementation of new gp1xx temperature sensor
by Rhys Kidd 05 Sep '17

05 Sep '17

Signed-off-by: Rhys Kidd <rhyskidd(a)gmail.com> --- .../gpu/drm/nouveau/include/nvkm/subdev/therm.h | 1 + drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 6 +++ drivers/gpu/drm/nouveau/nvkm/subdev/therm/Kbuild | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c | 3 +- drivers/gpu/drm/nouveau/nvkm/subdev/therm/gp100.c | 57 ++++++++++++++++++++++ 5 files changed, 67 insertions(+), 1 deletion(-) create mode 100644 drivers/gpu/drm/nouveau/nvkm/subdev/therm/gp100.c diff --git a/drivers/gpu/drm/nouveau/include/nvkm/subdev/therm.h b/drivers/gpu/drm/nouveau/include/nvkm/subdev/therm.h index b268b96faece..adf14731ea15 100644 --- a/drivers/gpu/drm/nouveau/include/nvkm/subdev/therm.h +++ b/drivers/gpu/drm/nouveau/include/nvkm/subdev/therm.h @@ -96,4 +96,5 @@ int g84_therm_new(struct nvkm_device *, int, struct nvkm_therm **); int gt215_therm_new(struct nvkm_device *, int, struct nvkm_therm **); int gf119_therm_new(struct nvkm_device *, int, struct nvkm_therm **); int gm107_therm_new(struct nvkm_device *, int, struct nvkm_therm **); +int gp100_therm_new(struct nvkm_device *, int, struct nvkm_therm **); #endif diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c index 7bdc7a5ae723..a6221b0996bf 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c @@ -2166,6 +2166,7 @@ nv130_chipset = { .ltc = gp100_ltc_new, .mc = gp100_mc_new, .mmu = gf100_mmu_new, + .therm = gp100_therm_new, .secboot = gm200_secboot_new, .pci = gp100_pci_new, .pmu = gp100_pmu_new, @@ -2200,6 +2201,7 @@ nv132_chipset = { .ltc = gp100_ltc_new, .mc = gp100_mc_new, .mmu = gf100_mmu_new, + .therm = gp100_therm_new, .secboot = gp102_secboot_new, .pci = gp100_pci_new, .pmu = gp102_pmu_new, @@ -2234,6 +2236,7 @@ nv134_chipset = { .ltc = gp100_ltc_new, .mc = gp100_mc_new, .mmu = gf100_mmu_new, + .therm = gp100_therm_new, .secboot = gp102_secboot_new, .pci = gp100_pci_new, .pmu = gp102_pmu_new, @@ -2268,6 +2271,7 @@ nv136_chipset = { .ltc = gp100_ltc_new, .mc = gp100_mc_new, .mmu = gf100_mmu_new, + .therm = gp100_therm_new, .secboot = gp102_secboot_new, .pci = gp100_pci_new, .pmu = gp102_pmu_new, @@ -2302,6 +2306,7 @@ nv137_chipset = { .ltc = gp100_ltc_new, .mc = gp100_mc_new, .mmu = gf100_mmu_new, + .therm = gp100_therm_new, .secboot = gp102_secboot_new, .pci = gp100_pci_new, .pmu = gp102_pmu_new, @@ -2332,6 +2337,7 @@ nv13b_chipset = { .ltc = gp100_ltc_new, .mc = gp10b_mc_new, .mmu = gf100_mmu_new, + .therm = gp100_therm_new, .secboot = gp10b_secboot_new, .pmu = gm20b_pmu_new, .timer = gk20a_timer_new, diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/Kbuild b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/Kbuild index 135758ba3e28..3ef1b396a946 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/Kbuild +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/Kbuild @@ -11,3 +11,4 @@ nvkm-y += nvkm/subdev/therm/g84.o nvkm-y += nvkm/subdev/therm/gt215.o nvkm-y += nvkm/subdev/therm/gf119.o nvkm-y += nvkm/subdev/therm/gm107.o +nvkm-y += nvkm/subdev/therm/gp100.o diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c index 952a7cb0a59a..f27fc6d0d4c6 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c @@ -341,7 +341,8 @@ nvkm_therm_init(struct nvkm_subdev *subdev) { struct nvkm_therm *therm = nvkm_therm(subdev); - therm->func->init(therm); + if (therm->func->init) + therm->func->init(therm); if (therm->suspend >= 0) { /* restore the pwm value only when on manual or auto mode */ diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/gp100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/gp100.c new file mode 100644 index 000000000000..b83d4af8c8bb --- /dev/null +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/gp100.c @@ -0,0 +1,57 @@ +/* + * Copyright 2017 Rhys Kidd + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + * + * Authors: Rhys Kidd + */ +#include "priv.h" + +static int +gp100_temp_get(struct nvkm_therm *therm) +{ + struct nvkm_device *device = therm->subdev.device; + struct nvkm_subdev *subdev = &therm->subdev; + u32 tsensor = nvkm_rd32(device, 0x20460); + u32 status = (tsensor & 0x60000000) >> 29; + u32 t_f24_8 = (tsensor & 0x0001fff8); + + /* device SHADOWed */ + if (status & 0x00000002) + nvkm_error(subdev, "Reading temperature from SHADOWed sensor\n"); + + /* device valid */ + if (status & 0x00000001) + return t_f24_8 / 256; + else + return -ENODEV; +} + +static const struct nvkm_therm_func +gp100_therm = { + .temp_get = gp100_temp_get, + .program_alarms = nvkm_therm_program_alarms_polling, +}; + +int +gp100_therm_new(struct nvkm_device *device, int index, + struct nvkm_therm **ptherm) +{ + return nvkm_therm_new_(&gp100_therm, device, index, ptherm); +} \ No newline at end of file -- 2.11.0

3 4

[Bug 102522] [radeonsi, bisected] commit 147d7fb772 causes full-window map to flash green in Crea
by bugzilla-daemon＠freedesktop.org 05 Sep '17

05 Sep '17

https://bugs.freedesktop.org/show_bug.cgi?id=102522 Bug ID: 102522 Summary: [radeonsi, bisected] commit 147d7fb772 causes full-window map to flash green in Crea Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: Kaelyn.Alexi+fdo(a)gmail.com QA Contact: dri-devel(a)lists.freedesktop.org Created attachment 133944 --> https://bugs.freedesktop.org/attachment.cgi?id=133944&action=edit Output of "glxinfo -s -l" In the game Crea (http://store.steampowered.com/app/280520 and https://www.humblebundle.com/store/crea), when opening the map to the full-window, non-overlay view on recent Mesa, the screen constantly flashes with a green hatching that makes the map impossible to make out. The flashing seems to occur between frames, since the snapshots taken by glretrace don't reflect the issue even though replaying a trace does. The problem first shows up with commit 147d7fb772 "st/mesa: add a winsys buffers list in st_context". The apitrace https://drive.google.com/file/d/0B-61xmxFzL-fTklGMzRiSERlTUE/view?usp=shari… shows the game loading and me bringing up the map; once the non-overlay map mode is reached is when the green flashing starts for me (when Mesa is at or past the aforementioned commit, including 17.2.0-rc5). I'm running Gentoo Linux on a Ryzen 1800X with a Radeon RX480, and Mesa was compiled against LLVM 4.0.1 (though I usually use Mesa and LLVM git), using gcc 6.4.0 for building everything. And I'm running Xorg 1.19.3 and kernel 4.12.7. -- You are receiving this mail because: You are the assignee for the bug.

1 1

[PATCH 1/2] selftests: sync: add test that waits on a destroyed timeline
by Gustavo Padovan 04 Sep '17

04 Sep '17

From: Emilio López <emilio.lopez(a)collabora.co.uk> If a sw_sync_timeline is destroyed the fences associated to it need to be signalled. This test checks that. Cc: Shuah Khan <shuah(a)kernel.org> Cc: linux-kselftest(a)vger.kernel.org Signed-off-by: Emilio López <emilio.lopez(a)collabora.co.uk> Signed-off-by: Gustavo Padovan <gustavo.padovan(a)collabora.com> --- tools/testing/selftests/sync/sync_test.c | 1 + tools/testing/selftests/sync/sync_wait.c | 58 ++++++++++++++++++++++++++++++++ tools/testing/selftests/sync/synctest.h | 1 + 3 files changed, 60 insertions(+) diff --git a/tools/testing/selftests/sync/sync_test.c b/tools/testing/selftests/sync/sync_test.c index 62fa666e501a..5d93c9dcc290 100644 --- a/tools/testing/selftests/sync/sync_test.c +++ b/tools/testing/selftests/sync/sync_test.c @@ -79,6 +79,7 @@ int main(void) err += RUN_TEST(test_fence_one_timeline_merge); err += RUN_TEST(test_fence_merge_same_fence); err += RUN_TEST(test_fence_multi_timeline_wait); + err += RUN_TEST(test_fence_wait_on_destroyed_timeline); err += RUN_TEST(test_stress_two_threads_shared_timeline); err += RUN_TEST(test_consumer_stress_multi_producer_single_consumer); err += RUN_TEST(test_merge_stress_random_merge); diff --git a/tools/testing/selftests/sync/sync_wait.c b/tools/testing/selftests/sync/sync_wait.c index d69b752f6550..82ad9f519959 100644 --- a/tools/testing/selftests/sync/sync_wait.c +++ b/tools/testing/selftests/sync/sync_wait.c @@ -25,6 +25,7 @@ * OTHER DEALINGS IN THE SOFTWARE. */ +#include <pthread.h> #include "sync.h" #include "sw_sync.h" #include "synctest.h" @@ -89,3 +90,60 @@ int test_fence_multi_timeline_wait(void) return 0; } + +struct fds_test { + int timeline; + int fencesig, fencekill; + int result; +}; + +static int test_fence_wait_on_destroyed_timeline_thread(void *d) +{ + struct fds_test *data = d; + int ret; + + /* in case of errors */ + data->result = 1; + + ret = sw_sync_timeline_inc(data->timeline, 100); + ASSERT(ret == 0, "Failure advancing timeline\n"); + + ret = sync_wait(data->fencekill, -1); + ASSERT(ret == 1, "Failure waiting on fence\n"); + + /* no errors occurred */ + data->result = 0; + return 0; +} + +int test_fence_wait_on_destroyed_timeline(void) +{ + struct fds_test data; + pthread_t thread; + int valid; + + data.timeline = sw_sync_timeline_create(); + valid = sw_sync_timeline_is_valid(data.timeline); + ASSERT(valid, "Failure allocating timeline\n"); + + data.fencesig = sw_sync_fence_create(data.timeline, "allocFence", 100); + data.fencekill = sw_sync_fence_create(data.timeline, "allocFence", 200); + + /* Spawn a thread to wait on a fence when the timeline is killed */ + pthread_create(&thread, NULL, (void *(*)(void *)) + test_fence_wait_on_destroyed_timeline_thread, &data); + + /* Wait for the thread to spool up */ + sync_wait(data.fencesig, -1); + + /* Kill the timeline */ + sw_sync_timeline_destroy(data.timeline); + + /* wait for the thread to clean up */ + pthread_join(thread, NULL); + + sw_sync_fence_destroy(data.fencesig); + sw_sync_fence_destroy(data.fencekill); + + return data.result; +} diff --git a/tools/testing/selftests/sync/synctest.h b/tools/testing/selftests/sync/synctest.h index e7d1d57dba7a..1cbe1e3658b3 100644 --- a/tools/testing/selftests/sync/synctest.h +++ b/tools/testing/selftests/sync/synctest.h @@ -53,6 +53,7 @@ int test_fence_merge_same_fence(void); /* Fence wait tests */ int test_fence_multi_timeline_wait(void); +int test_fence_wait_on_destroyed_timeline(void); /* Stress test - parallelism */ int test_stress_two_threads_shared_timeline(void); -- 2.13.5

2 2

[PATCH libdrm] libdrm_amdgpu: add kernel semaphore support
by Dave Airlie 04 Sep '17

04 Sep '17

From: Dave Airlie <airlied(a)redhat.com> This adds kernel semaphore support to the command submission interface in what should be a backwards compatible manner, it adds a new command submission API. Signed-off-by: Dave Airlie <airlied(a)redhat.com> --- amdgpu/amdgpu.h | 29 ++++++++++++- amdgpu/amdgpu_cs.c | 118 +++++++++++++++++++++++++++++++++++++++++++++++++---- 2 files changed, 138 insertions(+), 9 deletions(-) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index 1901fa8..649b66e 100644 --- a/amdgpu/amdgpu.h +++ b/amdgpu/amdgpu.h @@ -369,6 +369,16 @@ struct amdgpu_cs_request { struct amdgpu_cs_fence_info fence_info; }; +struct amdgpu_cs_request_syncobj { + /* + * + */ + uint32_t number_in_syncobj; + uint32_t number_out_syncobj; + uint32_t *in_syncobj; + uint32_t *out_syncobj; +}; + /** * Structure which provide information about GPU VM MC Address space * alignments requirements @@ -886,6 +896,12 @@ int amdgpu_cs_submit(amdgpu_context_handle context, struct amdgpu_cs_request *ibs_request, uint32_t number_of_requests); +int amdgpu_cs_submit_syncobj(amdgpu_context_handle context, + uint64_t flags, + struct amdgpu_cs_request *ibs_request, + struct amdgpu_cs_request_syncobj *ibs_syncobj, + uint32_t number_of_requests); + /** * Query status of Command Buffer Submission * @@ -1328,8 +1344,19 @@ int amdgpu_cs_destroy_semaphore(amdgpu_semaphore_handle sem); */ const char *amdgpu_get_marketing_name(amdgpu_device_handle dev); + +int amdgpu_cs_create_syncobj(amdgpu_device_handle dev, + uint32_t *syncobj); +int amdgpu_cs_export_syncobj(amdgpu_device_handle dev, + uint32_t syncobj, + int *shared_fd); +int amdgpu_cs_import_syncobj(amdgpu_device_handle dev, + int shared_fd, + uint32_t *syncobj); +int amdgpu_cs_destroy_syncobj(amdgpu_device_handle dev, + uint32_t syncobj); + #ifdef __cplusplus } #endif - #endif /* #ifdef _AMDGPU_H_ */ diff --git a/amdgpu/amdgpu_cs.c b/amdgpu/amdgpu_cs.c index 868eb7b..339c5f9 100644 --- a/amdgpu/amdgpu_cs.c +++ b/amdgpu/amdgpu_cs.c @@ -168,7 +168,8 @@ int amdgpu_cs_query_reset_state(amdgpu_context_handle context, * \sa amdgpu_cs_submit() */ static int amdgpu_cs_submit_one(amdgpu_context_handle context, - struct amdgpu_cs_request *ibs_request) + struct amdgpu_cs_request *ibs_request, + struct amdgpu_cs_request_syncobj *syncobj_request) { union drm_amdgpu_cs cs; uint64_t *chunk_array; @@ -176,10 +177,13 @@ static int amdgpu_cs_submit_one(amdgpu_context_handle context, struct drm_amdgpu_cs_chunk_data *chunk_data; struct drm_amdgpu_cs_chunk_dep *dependencies = NULL; struct drm_amdgpu_cs_chunk_dep *sem_dependencies = NULL; + struct drm_amdgpu_cs_chunk_sem *in_syncobj_dependencies = NULL; + struct drm_amdgpu_cs_chunk_sem *out_syncobj_dependencies = NULL; struct list_head *sem_list; amdgpu_semaphore_handle sem, tmp; - uint32_t i, size, sem_count = 0; + uint32_t i, j, size, sem_count = 0; bool user_fence; + uint32_t sem_size = 0; int r = 0; if (ibs_request->ip_type >= AMDGPU_HW_IP_NUM) @@ -194,7 +198,11 @@ static int amdgpu_cs_submit_one(amdgpu_context_handle context, } user_fence = (ibs_request->fence_info.handle != NULL); - size = ibs_request->number_of_ibs + (user_fence ? 2 : 1) + 1; + if (syncobj_request) { + sem_size += syncobj_request->number_in_syncobj ? 1 : 0; + sem_size += syncobj_request->number_out_syncobj ? 1 : 0; + } + size = ibs_request->number_of_ibs + (user_fence ? 2 : 1) + 1 + sem_size; chunk_array = alloca(sizeof(uint64_t) * size); chunks = alloca(sizeof(struct drm_amdgpu_cs_chunk) * size); @@ -306,6 +314,45 @@ static int amdgpu_cs_submit_one(amdgpu_context_handle context, chunks[i].chunk_data = (uint64_t)(uintptr_t)sem_dependencies; } + if (syncobj_request) { + if (syncobj_request->number_in_syncobj) { + in_syncobj_dependencies = malloc(sizeof(struct drm_amdgpu_cs_chunk_sem) * syncobj_request->number_in_syncobj); + if (!in_syncobj_dependencies) { + r = -ENOMEM; + goto error_unlock; + } + for (j = 0; j < syncobj_request->number_in_syncobj; j++) { + struct drm_amdgpu_cs_chunk_sem *dep = &in_syncobj_dependencies[j]; + dep->handle = syncobj_request->in_syncobj[j]; + } + i = cs.in.num_chunks++; + + /* dependencies chunk */ + chunk_array[i] = (uint64_t)(uintptr_t)&chunks[i]; + chunks[i].chunk_id = AMDGPU_CHUNK_ID_SYNCOBJ_IN; + chunks[i].length_dw = sizeof(struct drm_amdgpu_cs_chunk_sem) / 4 * syncobj_request->number_in_syncobj; + chunks[i].chunk_data = (uint64_t)(uintptr_t)in_syncobj_dependencies; + } + if (syncobj_request->number_out_syncobj) { + out_syncobj_dependencies = malloc(sizeof(struct drm_amdgpu_cs_chunk_sem) * syncobj_request->number_out_syncobj); + if (!out_syncobj_dependencies) { + r = -ENOMEM; + goto error_unlock; + } + for (j = 0; j < syncobj_request->number_out_syncobj; j++) { + struct drm_amdgpu_cs_chunk_sem *dep = &out_syncobj_dependencies[j]; + dep->handle = syncobj_request->out_syncobj[j]; + } + i = cs.in.num_chunks++; + + /* dependencies chunk */ + chunk_array[i] = (uint64_t)(uintptr_t)&chunks[i]; + chunks[i].chunk_id = AMDGPU_CHUNK_ID_SYNCOBJ_OUT; + chunks[i].length_dw = sizeof(struct drm_amdgpu_cs_chunk_sem) / 4 * syncobj_request->number_out_syncobj; + chunks[i].chunk_data = (uint64_t)(uintptr_t)out_syncobj_dependencies; + } + } + r = drmCommandWriteRead(context->dev->fd, DRM_AMDGPU_CS, &cs, sizeof(cs)); if (r) @@ -317,31 +364,48 @@ error_unlock: pthread_mutex_unlock(&context->sequence_mutex); free(dependencies); free(sem_dependencies); + free(in_syncobj_dependencies); + free(out_syncobj_dependencies); return r; } -int amdgpu_cs_submit(amdgpu_context_handle context, - uint64_t flags, - struct amdgpu_cs_request *ibs_request, - uint32_t number_of_requests) +int amdgpu_cs_submit_syncobj(amdgpu_context_handle context, + uint64_t flags, + struct amdgpu_cs_request *ibs_request, + struct amdgpu_cs_request_syncobj *ibs_syncobj, + uint32_t number_of_requests) { uint32_t i; int r; + bool has_syncobj = ibs_syncobj ? true : false; if (!context || !ibs_request) return -EINVAL; r = 0; for (i = 0; i < number_of_requests; i++) { - r = amdgpu_cs_submit_one(context, ibs_request); + r = amdgpu_cs_submit_one(context, ibs_request, has_syncobj ? ibs_syncobj : NULL); if (r) break; ibs_request++; + if (has_syncobj) + ibs_syncobj++; } return r; } +int amdgpu_cs_submit(amdgpu_context_handle context, + uint64_t flags, + struct amdgpu_cs_request *ibs_request, + uint32_t number_of_requests) +{ + return amdgpu_cs_submit_syncobj(context, flags, + ibs_request, NULL, + number_of_requests); +} + + /** * Calculate absolute timeout. * @@ -596,3 +660,41 @@ int amdgpu_cs_destroy_semaphore(amdgpu_semaphore_handle sem) { return amdgpu_cs_unreference_sem(sem); } + +int amdgpu_cs_create_syncobj(amdgpu_device_handle dev, + uint32_t *handle) +{ + if (NULL == dev) + return -EINVAL; + + return drmSyncobjCreate(dev->fd, 0, handle); +} + +int amdgpu_cs_destroy_syncobj(amdgpu_device_handle dev, + uint32_t handle) +{ + if (NULL == dev) + return -EINVAL; + + return drmSyncobjDestroy(dev->fd, handle); +} + +int amdgpu_cs_export_syncobj(amdgpu_device_handle dev, + uint32_t handle, + int *shared_fd) +{ + if (NULL == dev) + return -EINVAL; + + return drmSyncobjHandleToFD(dev->fd, handle, shared_fd); +} + +int amdgpu_cs_import_syncobj(amdgpu_device_handle dev, + int shared_fd, + uint32_t *handle) +{ + if (NULL == dev) + return -EINVAL; + + return drmSyncobjFDToHandle(dev->fd, shared_fd, handle); +} -- 2.9.4

5 23

[Bug 97942] [IGT][BYT/BXT] gem_mmap_gtt subtest basic-wc fails due to Test assertion failure
by bugzilla-daemon＠freedesktop.org 04 Sep '17

04 Sep '17

https://bugs.freedesktop.org/show_bug.cgi?id=97942 Elizabeth <elizabethx.de.la.torre.mena(a)intel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[IGT] [BYT] [BXT] [BYT] |[IGT][BYT/BXT] gem_mmap_gtt |/gem_mmap_gtt subtest |subtest basic-wc fails due |basic-wc fails due to Test |to Test assertion failure |assertion failure | -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH 0/6] drm/tinydrm: Support device unplug
by Noralf Trønnes 04 Sep '17

04 Sep '17

This adds device unplug support to drm_fb_helper, drm_fb_cma_helper (fbdev) and tinydrm. My motivation for doing this is to make tinydrm useable with USB devices. This discussion gave insight into the problem: [PATCH v5 2/6] drm/bridge: Add a devm_ allocator for panel bridge. https://lists.freedesktop.org/archives/dri-devel/2017-August/149376.html Noralf. Noralf Trønnes (6): drm/fb-helper: Avoid NULL ptr dereference in fb_set_suspend() drm/fb-helper: Support device unplug drm/fb-cma-helper: Support device unplug drm/tinydrm: Embed drm_device in tinydrm_device drm/tinydrm/mi0283qt: Let the display pipe handle power drm/tinydrm: Support device unplug drivers/gpu/drm/drm_fb_cma_helper.c | 139 +++++++++---------- drivers/gpu/drm/drm_fb_helper.c | 207 +++++++++++++++++++++++++++- drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 109 ++++++++++----- drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 2 +- drivers/gpu/drm/tinydrm/mi0283qt.c | 77 +++-------- drivers/gpu/drm/tinydrm/mipi-dbi.c | 27 ++-- drivers/gpu/drm/tinydrm/repaper.c | 19 ++- drivers/gpu/drm/tinydrm/st7586.c | 25 ++-- include/drm/drm_fb_cma_helper.h | 1 + include/drm/drm_fb_helper.h | 35 +++++ include/drm/tinydrm/tinydrm.h | 14 +- 11 files changed, 460 insertions(+), 195 deletions(-) -- 2.7.4

4 39

Re: [PATCH] dma-fence: fix dma_fence_get_rcu_safe
by Christian König 04 Sep '17

04 Sep '17

I really wonder what's wrong with my mail client, but it looks like this patch never made it at least to dri-devel. Forwarding manually now, Christian. Am 04.09.2017 um 15:16 schrieb Christian König: > From: Christian König <christian.koenig(a)amd.com> > > The logic is buggy and unnecessary complex. When dma_fence_get_rcu() fails to > acquire a reference it doesn't necessary mean that there is no fence at all. > > It usually mean that the fence was replaced by a new one and in this situation > we certainly want to have the new one as result and *NOT* NULL. > > Signed-off-by: Christian König <christian.koenig(a)amd.com> > Cc: Chris Wilson <chris(a)chris-wilson.co.uk> > Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> > Cc: Sumit Semwal <sumit.semwal(a)linaro.org> > Cc: linux-media(a)vger.kernel.org > Cc: dri-devel(a)lists.freedesktop.org > Cc: linaro-mm-sig(a)lists.linaro.org > --- > include/linux/dma-fence.h | 23 ++--------------------- > 1 file changed, 2 insertions(+), 21 deletions(-) > > diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h > index a5195a7..37f3d67 100644 > --- a/include/linux/dma-fence.h > +++ b/include/linux/dma-fence.h > @@ -246,27 +246,8 @@ dma_fence_get_rcu_safe(struct dma_fence * __rcu *fencep) > struct dma_fence *fence; > > fence = rcu_dereference(*fencep); > - if (!fence || !dma_fence_get_rcu(fence)) > - return NULL; > - > - /* The atomic_inc_not_zero() inside dma_fence_get_rcu() > - * provides a full memory barrier upon success (such as now). > - * This is paired with the write barrier from assigning > - * to the __rcu protected fence pointer so that if that > - * pointer still matches the current fence, we know we > - * have successfully acquire a reference to it. If it no > - * longer matches, we are holding a reference to some other > - * reallocated pointer. This is possible if the allocator > - * is using a freelist like SLAB_TYPESAFE_BY_RCU where the > - * fence remains valid for the RCU grace period, but it > - * may be reallocated. When using such allocators, we are > - * responsible for ensuring the reference we get is to > - * the right fence, as below. > - */ > - if (fence == rcu_access_pointer(*fencep)) > - return rcu_pointer_handoff(fence); > - > - dma_fence_put(fence); > + if (!fence || dma_fence_get_rcu(fence)) > + return fence; > } while (1); > } >

1 0

[PATCH v3 0/3] drm/bridge/synopsys: dsi: Various cleanups
by Philippe CORNU 04 Sep '17

04 Sep '17

Version 3: - Add devm_reset_control_get_optional_exclusive (Philipp Zabel). Version 2: - Put back Synopsys mipi dsi unused registers. - Add devm_reset_control_get_exclusive to follow explicit reset API. - Add a missing commit message & reviewed-by. Version 1: - Initial commit The purpose of this set of patches is to clean up the mipi dsi dw Synopsys drm bridge. Philippe CORNU (3): drm/bridge/synopsys: dsi: Constify funcs structures drm/bridge/synopsys: dsi: Register list clean up drm/bridge/synopsys: dsi: explicitly request exclusive reset control drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 104 +++++++++++++++----------- 1 file changed, 60 insertions(+), 44 deletions(-) -- 1.9.1

3 11

rk3288: Enable HDMI hang boot and no Linux log
by Jagan Teki 04 Sep '17

04 Sep '17

Hi, Is linux-next support HDMI on rk3288? I'm trying to enable hdmi (with ddc-i2c-bus) statically along with Linux boot logo. Observed an kernel boot hang, didn't find whats wrong because DWC MHL PHY as detected from the log. Here is the full log[1] please let me know if I miss any? Log: ----- [ 1.983832] rockchip-drm display-subsystem: bound ff930000.vop (ops 0xc0f53418) [ 1.992170] rockchip-drm display-subsystem: bound ff940000.vop (ops 0xc0f53418) [ 2.000416] dwhdmi-rockchip ff980000.hdmi: Detected HDMI TX controller v2.00a with HDCP (DWC MHL PHY) [ 2.011210] rockchip-drm display-subsystem: bound ff980000.hdmi (ops 0xc0f551f4) [ 2.019490] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 2.026888] [drm] No driver support for vblank timestamp query. [ 2.033516] [drm] Cannot find any crtc or sizes [ 2.038731] [drm] Initialized rockchip 1.0.0 20140818 for display-subsystem on minor 0 [ 2.047818] hctosys: unable to open rtc device (rtc0) [ 2.053958] mmcblk0: p1 [ 2.057009] ttyS2 - failed to request DMA [1] https://paste.ubuntu.com/25464674/ thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India.

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2017