dri-devel October 2018

dri-devel@lists.freedesktop.org

277 participants
1898 discussions

[PATCH] drm/ast: change resolution may cause screen blurred
by Y.C. Chen 01 Oct '18

01 Oct '18

From: "Y.C. Chen" <yc_chen(a)aspeedtech.com> The value of pitches is not correct while calling mode_set. The issue we found so far on following system: - Debian8 with XFCE Desktop - Ubuntu with KDE Desktop - SUSE15 with KDE Desktop Signed-off-by: Y.C. Chen <yc_chen(a)aspeedtech.com> --- drivers/gpu/drm/ast/ast_mode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index 5e77d45..f06aae7 100644 --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu/drm/ast/ast_mode.c @@ -568,6 +568,7 @@ static int ast_crtc_do_set_base(struct drm_crtc *crtc, } ast_bo_unreserve(bo); + ast_set_offset_reg(crtc); ast_set_start_address_crt1(crtc, (u32)gpu_addr); return 0; -- 1.8.3.1

2 1

[PATCH] drm/cma-helper: Fix crash in fbdev error path
by Noralf Trønnes 01 Oct '18

01 Oct '18

Sergey Suloev reported a crash happening in drm_client_dev_hotplug() when fbdev had failed to register. [ 9.124598] vc4_hdmi 3f902000.hdmi: ASoC: Failed to create component debugfs directory [ 9.147667] vc4_hdmi 3f902000.hdmi: vc4-hdmi-hifi <-> 3f902000.hdmi mapping ok [ 9.155184] vc4_hdmi 3f902000.hdmi: ASoC: no DMI vendor name! [ 9.166544] vc4-drm soc:gpu: bound 3f902000.hdmi (ops vc4_hdmi_ops [vc4]) [ 9.173840] vc4-drm soc:gpu: bound 3f806000.vec (ops vc4_vec_ops [vc4]) [ 9.181029] vc4-drm soc:gpu: bound 3f004000.txp (ops vc4_txp_ops [vc4]) [ 9.188519] vc4-drm soc:gpu: bound 3f400000.hvs (ops vc4_hvs_ops [vc4]) [ 9.195690] vc4-drm soc:gpu: bound 3f206000.pixelvalve (ops vc4_crtc_ops [vc4]) [ 9.203523] vc4-drm soc:gpu: bound 3f207000.pixelvalve (ops vc4_crtc_ops [vc4]) [ 9.215032] vc4-drm soc:gpu: bound 3f807000.pixelvalve (ops vc4_crtc_ops [vc4]) [ 9.274785] vc4-drm soc:gpu: bound 3fc00000.v3d (ops vc4_v3d_ops [vc4]) [ 9.290246] [drm] Initialized vc4 0.0.0 20140616 for soc:gpu on minor 0 [ 9.297464] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 9.304600] [drm] Driver supports precise vblank timestamp query. [ 9.382856] vc4-drm soc:gpu: [drm:drm_fb_helper_fbdev_setup [drm_kms_helper]] *ERROR* Failed to set fbdev configuration [ 10.404937] Unable to handle kernel paging request at virtual address 00330a656369768a [ 10.441620] [00330a656369768a] address between user and kernel address ranges [ 10.449087] Internal error: Oops: 96000004 [#1] PREEMPT SMP [ 10.454762] Modules linked in: brcmfmac vc4 drm_kms_helper cfg80211 drm rfkill smsc95xx brcmutil usbnet drm_panel_orientation_quirks raspberrypi_hwmon bcm2835_dma crc32_ce pwm_bcm2835 bcm2835_rng virt_dma rng_core i2c_bcm2835 ip_tables x_tables ipv6 [ 10.477296] CPU: 2 PID: 45 Comm: kworker/2:1 Not tainted 4.19.0-rc5 #3 [ 10.483934] Hardware name: Raspberry Pi 3 Model B Rev 1.2 (DT) [ 10.489966] Workqueue: events output_poll_execute [drm_kms_helper] [ 10.596515] Process kworker/2:1 (pid: 45, stack limit = 0x000000007e8924dc) [ 10.603590] Call trace: [ 10.606259] drm_client_dev_hotplug+0x5c/0xb0 [drm] [ 10.611303] drm_kms_helper_hotplug_event+0x30/0x40 [drm_kms_helper] [ 10.617849] output_poll_execute+0xc4/0x1e0 [drm_kms_helper] [ 10.623616] process_one_work+0x1c8/0x318 [ 10.627695] worker_thread+0x48/0x428 [ 10.631420] kthread+0xf8/0x128 [ 10.634615] ret_from_fork+0x10/0x18 [ 10.638255] Code: 54000220 f9401261 aa1303e0 b4000141 (f9400c21) [ 10.644456] ---[ end trace c75b4a4b0e141908 ]--- The reason for this is that drm_fbdev_cma_init() removes the drm_client when fbdev registration fails, but it doesn't remove the client from the drm_device client list. So the client list now has a pointer that points into the unknown and we have a 'use after free' situation. It was decided during the drm_client API discussions that a client should not be allowed to remove itself. This was based on the experience with the fbdev/fbcon locking horror show. So the solution is to just leave the drm_client hanging around doing nothing (it doesn't have any callbacks), and let it be removed when drm_dev_unregister() is called. Fixes: 894a677f4b3e ("drm/cma-helper: Use the generic fbdev emulation") Reported-by: Sergey Suloev <ssuloev(a)orpaltech.com> Cc: Stefan Wahren <stefan.wahren(a)i2se.com> Cc: Eric Anholt <eric(a)anholt.net> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Signed-off-by: Noralf Trønnes <noralf(a)tronnes.org> --- This bug is in 4.19 so it should go into drm-misc-fixes right? (I have never applied a fix before) Noralf. drivers/gpu/drm/drm_fb_cma_helper.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c index 47e0e2f6642d..d82bb4776e3c 100644 --- a/drivers/gpu/drm/drm_fb_cma_helper.c +++ b/drivers/gpu/drm/drm_fb_cma_helper.c @@ -168,22 +168,21 @@ struct drm_fbdev_cma *drm_fbdev_cma_init(struct drm_device *dev, fb_helper = &fbdev_cma->fb_helper; ret = drm_client_new(dev, &fb_helper->client, "fbdev", NULL); - if (ret) - goto err_free; + if (ret) { + kfree(fbdev_cma); + return ERR_PTR(ret); + } ret = drm_fb_helper_fbdev_setup(dev, fb_helper, &drm_fb_cma_helper_funcs, preferred_bpp, max_conn_count); if (ret) - goto err_client_put; + /* + * A drm_client is not allowed to remove itself, so it has to + * stay around until drm_dev_unregister(). + */ + return ERR_PTR(ret); return fbdev_cma; - -err_client_put: - drm_client_release(&fb_helper->client); -err_free: - kfree(fbdev_cma); - - return ERR_PTR(ret); } EXPORT_SYMBOL_GPL(drm_fbdev_cma_init); -- 2.15.1

2 1

[GIT PULL] exynos-drm-next
by Inki Dae 01 Oct '18

01 Oct '18

Hi Dave, Adding out-bridge support for the use of LVDS bridge device to MIPI-DSI driver, Samsung 16x16 tiled format support to scalder and gsc drivers and configurable plane alpha and pixel blend mode supports to mixer driver including one cleanup for removing exynos specific suspend_state. As for Samsung 16x16 tiled format support, I picked one patch up, which adds DRM_FORMAT_MOD_SAMSUNG_16_16_TILE definition to drm_forcc.h header file. The only user of this format is exynos so I requested ack-by[1] to relevant maintainers on 27 Aug. but no any response. [1] https://patchwork.freedesktop.org/patch/243921/ Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 0320ac5188eab5c6e8b92b110d1eae967ac272d2: Merge tag 'du-next-20180914' of git://linuxtv.org/pinchartl/media into drm-next (2018-09-20 14:12:07 +1000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos tags/exynos-drm-next-for-v4.20 for you to fetch changes up to 6ac99a328ee16d3f8cc253f1df62623cee3e9ea5: drm/exynos: mixer: Make plane alpha configurable (2018-10-01 11:49:59 +0900) ---------------------------------------------------------------- Add out-bridge support - This patch series enables out-bridge for LVDS bridge device support, and also includes two cleanups and one relevant dt binding update for this. Add Samsung 16x16 tiled format support - This patch series adds Samsung 16x16 tiled format to scaler and gsc drivers. As for this, it adds Samsung specific format to drm_forcc.h header. For the git-pull request with relevant patches, I requested ack-by[1] to relevant maintainers but there was no any response. I'm pretty sure no problem to go to mainline though Exynos tree because the only user of it is Exynos. [1] https://patchwork.freedesktop.org/patch/243921/ Add configurable plane alpha and pixel blend mode support - This patch series makes mixer driver to be configuragle for pixel blend mode and plane alpha, which also includes one fixup to set all default values correctly after reset. One cleanup - This patch replaces drm_atomic_helper_suspend/resume() with drm_mode_config_helper_suspend/resume() to remove exynos specific suspend_state. ---------------------------------------------------------------- Andrzej Hajda (1): dt-bindings: exynos_dsim: update of graph bindings Andrzej Pietrasiewicz (2): drm: drm_fourcc: add Samsung 16x16 tile format drm/exynos: scaler: Add support for tiled formats Christoph Manszewski (3): drm/exynos: drm_plane: Correct exynos_drm_plane_reset drm/exynos: mixer: Make pixel blend mode configurable drm/exynos: mixer: Make plane alpha configurable Maciej Purski (3): drm/exynos: rename bridge_node to in_bridge_node drm/exynos: move connector creation to attach callback drm/exynos: enable out_bridge in exynos_dsi_enable Marek Szyprowski (1): drm/exynos: gsc: Add support for tiled formats Souptick Joarder (1): gpu/drm/exynos: Convert drm_atomic_helper_suspend/resume() .../bindings/display/exynos/exynos_dsim.txt | 25 +--- drivers/gpu/drm/exynos/exynos_drm_drv.c | 26 +--- drivers/gpu/drm/exynos/exynos_drm_drv.h | 3 +- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 107 +++++++++------- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 17 --- drivers/gpu/drm/exynos/exynos_drm_fbdev.h | 10 -- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 46 +++++-- drivers/gpu/drm/exynos/exynos_drm_plane.c | 16 ++- drivers/gpu/drm/exynos/exynos_drm_scaler.c | 137 ++++++++++++--------- drivers/gpu/drm/exynos/exynos_mixer.c | 56 ++++++--- drivers/gpu/drm/exynos/regs-mixer.h | 5 +- include/uapi/drm/drm_fourcc.h | 9 ++ 12 files changed, 249 insertions(+), 208 deletions(-)

1 0

[PATCH v2] drm/bochs: Replace drm_gem_object_unreference_unlocked with put function
by Thomas Zimmermann 01 Oct '18

01 Oct '18

This patch unifies the naming of DRM functions for reference counting of struct drm_gem_object. The resulting code is more aligned with the rest of the Linux kernel interfaces. v2: * rebase onto fbdev rework Signed-off-by: Thomas Zimmermann <tzimmermann(a)suse.de> --- drivers/gpu/drm/bochs/bochs_mm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c index a61c1ecb2bdc..e6ccf7fa92d4 100644 --- a/drivers/gpu/drm/bochs/bochs_mm.c +++ b/drivers/gpu/drm/bochs/bochs_mm.c @@ -414,7 +414,7 @@ int bochs_dumb_create(struct drm_file *file, struct drm_device *dev, return ret; ret = drm_gem_handle_create(file, gobj, &handle); - drm_gem_object_unreference_unlocked(gobj); + drm_gem_object_put_unlocked(gobj); if (ret) return ret; @@ -454,6 +454,6 @@ int bochs_dumb_mmap_offset(struct drm_file *file, struct drm_device *dev, bo = gem_to_bochs_bo(obj); *offset = bochs_bo_mmap_offset(bo); - drm_gem_object_unreference_unlocked(obj); + drm_gem_object_put_unlocked(obj); return 0; } -- 2.19.0

2 1

[PATCH v3 0/3] drm/msm: Replace {un/reference} with {put, get} functions
by Thomas Zimmermann 01 Oct '18

01 Oct '18

This patch set replaces functions named {un,reference} by their {put,get} counterparts. Affected data types are struct struct drm_framebuffer, struct drm_gem_object, and struct drm_device. With the reference-counting functions being named {put,get}, the DRM interface is more aligned to Linux kernel nameing standard. The patch set does not change driver-internal interfaces. Changes since v2: * fixed an instance in a6xx_destroy() Changes since v1: * rebased on 4.18 * adapted to changes in msm_drv.c and adreno/a5xx_gpu.c Thomas Zimmermann (3): drm/msm: Replace drm_framebuffer_{un/reference} with put,get functions drm/msm: Replace drm_gem_object_{un/reference} with put,get functions drm/msm: Replace drm_dev_unref with drm_dev_put drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 4 ++-- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +- drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 4 ++-- drivers/gpu/drm/msm/msm_drv.c | 8 ++++---- drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++-- 8 files changed, 14 insertions(+), 14 deletions(-) -- 2.19.0

3 5

[RFC PATCH] drm: Add new fb flags to pass interlaced alternate field
by Satish Kumar Nagireddy 01 Oct '18

01 Oct '18

This patch adds two new framebuffer flags, so that application can communicate alternate interlaced field information to DRM. This patch also modifies the validation of framebuffer flags in DRM core framework. This is to ensure that application is setting the right framebuffer flags. Signed-off-by: Satish Kumar Nagireddy <satish.nagireddy.nagireddy(a)xilinx.com> --- drivers/gpu/drm/drm_framebuffer.c | 3 ++- include/uapi/drm/drm_mode.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c index 28a0108..d330256 100644 --- a/drivers/gpu/drm/drm_framebuffer.c +++ b/drivers/gpu/drm/drm_framebuffer.c @@ -241,7 +241,8 @@ drm_internal_framebuffer_create(struct drm_device *dev, struct drm_framebuffer *fb; int ret; - if (r->flags & ~(DRM_MODE_FB_INTERLACED | DRM_MODE_FB_MODIFIERS)) { + if (r->flags & ~(DRM_MODE_FB_INTERLACED | DRM_MODE_FB_MODIFIERS | + DRM_MODE_FB_ALTERNATE_TOP | DRM_MODE_FB_ALTERNATE_BOTTOM)) { DRM_DEBUG_KMS("bad framebuffer flags 0x%08x\n", r->flags); return ERR_PTR(-EINVAL); } diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index ce7efe2..b857ed4 100644 --- a/include/uapi/drm/drm_mode.h +++ b/include/uapi/drm/drm_mode.h @@ -388,6 +388,8 @@ struct drm_mode_fb_cmd { #define DRM_MODE_FB_INTERLACED (1<<0) /* for interlaced framebuffers */ #define DRM_MODE_FB_MODIFIERS (1<<1) /* enables ->modifer[] */ +#define DRM_MODE_FB_ALTERNATE_TOP (1<<2) /* for alternate top field */ +#define DRM_MODE_FB_ALTERNATE_BOTTOM (1<<3) /* for alternate bottom field */ struct drm_mode_fb_cmd2 { __u32 fb_id; -- 2.7.4

2 1

[Bug 107991] RX580 ~ ring gfx timeout ~ particular shaders created by a dolphin-emu game can bring down AMDGPU
by bugzilla-daemon＠freedesktop.org 01 Oct '18

01 Oct '18

https://bugs.freedesktop.org/show_bug.cgi?id=107991 Bug ID: 107991 Summary: RX580 ~ ring gfx timeout ~ particular shaders created by a dolphin-emu game can bring down AMDGPU Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: major Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: kyle.devir(a)mykolab.com QA Contact: dri-devel(a)lists.freedesktop.org Created attachment 141652 --> https://bugs.freedesktop.org/attachment.cgi?id=141652&action=edit dolphin-emu apitrace I have successfully captured an apitrace that intercepted the crashy frame before the driver crashed. The issues occur at very specific parts of Fire Emblem: Path of Radiance, where the frames / shaders / textures generated by dolphin-emu cause the driver to crash. -- You are receiving this mail because: You are the assignee for the bug.

1 11

[GIT PULL] exynos-drm-fixes
by Inki Dae 01 Oct '18

01 Oct '18

Hi Dave, Just one fixup patch to avoid Exynos DRM driver from being broken with enhancement patch series of IOMMU framework[1]. This patch just makes it reuse default IOMMU domain instead of allocating a fake one. Ps. We'd like to push this one to help enhancing the IOMMU and DMA-IOMMU frameworks in v4.20 Please kindly let me know if there is any problem. [1] https://www.spinics.net/lists/arm-kernel/msg676098.html Thanks, Inki Dae The following changes since commit fcb1349a2af5a3c4a1d789bb5d1a9b3e582652a3: Merge branch 'drm-fixes-4.19' of git://people.freedesktop.org/~agd5f/linux into drm-fixes (2018-09-28 09:30:22 +1000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos tags/exynos-drm-fixes-for-v4.19-rc7 for you to fetch changes up to 1feda5eb77fc279a4c4eb93b9a0ac3bf7254b57a: drm/exynos: Use selected dma_dev default iommu domain instead of a fake one (2018-10-01 09:25:31 +0900) ---------------------------------------------------------------- Use default iommu domain instead of fake one - This patch makes it to reuse default IOMMU domain instead of allocating a fake IOMMU domain, and allows some design changes for enhancement of IOMMU framework[1] without breaking Exynos DRM. [1] https://www.spinics.net/lists/arm-kernel/msg676098.html ---------------------------------------------------------------- Marek Szyprowski (1): drm/exynos: Use selected dma_dev default iommu domain instead of a fake one drivers/gpu/drm/exynos/exynos_drm_iommu.h | 34 ++++++------------------------- 1 file changed, 6 insertions(+), 28 deletions(-)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2018