dri-devel May 2018

dri-devel@lists.freedesktop.org

268 participants
1833 discussions

[PATCH] drivers: omap2: Kconfig: make FB_OMAP2_DSS_INIT depend on OF
by Anders Roxell 04 May '18

04 May '18

Commit 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST") broke compilation without CONFIG_OF selected. CC drivers/video/fbdev/core/fbmem.o drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c: In function ‘omapdss_update_prop’: drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c:68:2: error: implicit declaration of function ‘of_update_property’; did you mean ‘of_get_property’? [-Werror=implicit-function-declaration] of_update_property(node, prop); ^~~~~~~~~~~~~~~~~~ of_get_property cc1: some warnings being treated as errors scripts/Makefile.build:312: recipe for target 'drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.o' failed make[7]: *** [drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.o] Error 1 scripts/Makefile.build:559: recipe for target 'drivers/video/fbdev/omap2/omapfb/dss' failed make[6]: *** [drivers/video/fbdev/omap2/omapfb/dss] Error 2 make[6]: *** Waiting for unfinished jobs.... Add OF dependency in order to make all configurations work again. of_update_property() has no inline stub, and that that could be added as an alternative. Signed-off-by: Anders Roxell <anders.roxell(a)linaro.org> --- drivers/video/fbdev/omap2/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/omap2/Kconfig b/drivers/video/fbdev/omap2/Kconfig index 82008699d253..4de381f2452e 100644 --- a/drivers/video/fbdev/omap2/Kconfig +++ b/drivers/video/fbdev/omap2/Kconfig @@ -1,4 +1,4 @@ -if ARCH_OMAP2PLUS || COMPILE_TEST +if OF && (ARCH_OMAP2PLUS || COMPILE_TEST) source "drivers/video/fbdev/omap2/omapfb/Kconfig" -- 2.17.0

4 6

[PATCH 1/8] lib/scatterlist: add sg_set_dma_addr() helper
by Christian König 04 May '18

04 May '18

Use this function to set an sg entry to point to device resources mapped using dma_map_resource(). The page pointer is set to NULL and only the DMA address, length and offset values are valid. Signed-off-by: Christian König <christian.koenig(a)amd.com> --- include/linux/scatterlist.h | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h index 22b2131bcdcd..f944ee4e482c 100644 --- a/include/linux/scatterlist.h +++ b/include/linux/scatterlist.h @@ -149,6 +149,29 @@ static inline void sg_set_buf(struct scatterlist *sg, const void *buf, sg_set_page(sg, virt_to_page(buf), buflen, offset_in_page(buf)); } +/** + * sg_set_dma_addr - Set sg entry to point at specified dma address + * @sg: SG entry + * @address: DMA address to set + * @len: Length of data + * @offset: Offset into page + * + * Description: + * Use this function to set an sg entry to point to device resources mapped + * using dma_map_resource(). The page pointer is set to NULL and only the DMA + * address, length and offset values are valid. + * + **/ +static inline void sg_set_dma_addr(struct scatterlist *sg, dma_addr_t address, + unsigned int len, unsigned int offset) +{ + sg_set_page(sg, NULL, len, offset); + sg->dma_address = address; +#ifdef CONFIG_NEED_SG_DMA_LENGTH + sg->dma_length = len; +#endif +} + /* * Loop over each sg element, following the pointer to a new list if necessary */ -- 2.14.1

12 81

[PATCH v1 0/3] Couple more DRM plane features on Tegra
by Dmitry Osipenko 04 May '18

04 May '18

Hi, This series improves DRM plane support by supporting zPos on older Tegra's and enabling plane scaling filters (up to Tegra210). Dmitry Osipenko (3): drm/tegra: dc: Enable plane scaling filters drm/tegra: plane: Implement zPos plane property for older Tegra's drm/tegra: dc: Rename supports_blending to has_legacy_blending drivers/gpu/drm/tegra/dc.c | 205 ++++++++++++++++++++++++++-------- drivers/gpu/drm/tegra/dc.h | 9 +- drivers/gpu/drm/tegra/plane.c | 193 +++++++++++++++++++++++--------- drivers/gpu/drm/tegra/plane.h | 13 ++- 4 files changed, 313 insertions(+), 107 deletions(-) -- 2.17.0

2 9

[PATCH 0/5] [PATCH 0/5] drm: Fix rounding errors and use scaling in i915, v2.
by Maarten Lankhorst 04 May '18

04 May '18

There were some small rounding errors in when clamping with 1.0001 and 0.9999 scaling, solve these and add a testcase for drm helpers, which can be used to prevent more of these errors in the future. The new handling in drm_rect_clip_scaled rounds scaling towards 1.0x but because the rounding error is only 1 pixel with the new math, we won't ever get in a situation where we go from 1.001 to .999 Maarten Lankhorst (5): drm/rect: Round above 1 << 16 upwards to correct scale calculation functions. drm/rect: Handle rounding errors in drm_rect_clip_scaled, v3. drm/i915: Do not adjust scale when out of bounds, v2. drm/selftests: Rename the Kconfig option to CONFIG_DRM_DEBUG_SELFTEST drm/selftests: Add drm helper selftest drivers/gpu/drm/Kconfig | 9 +- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_atomic_helper.c | 2 +- drivers/gpu/drm/drm_rect.c | 62 ++++- drivers/gpu/drm/i915/intel_sprite.c | 144 +++------- drivers/gpu/drm/selftests/Makefile | 2 +- .../gpu/drm/selftests/drm_helper_selftests.h | 9 + drivers/gpu/drm/selftests/test-drm-helper.c | 247 ++++++++++++++++++ include/drm/drm_rect.h | 3 +- 9 files changed, 348 insertions(+), 132 deletions(-) create mode 100644 drivers/gpu/drm/selftests/drm_helper_selftests.h create mode 100644 drivers/gpu/drm/selftests/test-drm-helper.c -- 2.17.0

2 11

[PULL] drm-misc-next
by Maarten Lankhorst 04 May '18

04 May '18

drm-misc-next-2018-05-04: drm-misc-next for v4.18: Ignore the dma-fence changes, they have been immediately reverted. :) Core Changes: - Rounding behavior when clipping a visible plane has changed slightly. We now consistently try to round towards the 1.0x scale to prevent running into hw limits. Driver Changes: - Add a drm driver for broadcom V3D V3.x+. (Eric) - Add syncobj support to vc4. (Stefan) - Assorted bugfixes. The following changes since commit 741c3aeb82c78e173aa7155aaffb971e5c73ab3c: drm/bridge/synopsys: dsi: use adjusted_mode in mode_set (2018-04-26 08:24:26 +0200) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-next-2018-05-04 for you to fetch changes up to 7420e04963587dc8f6d4e8b7e79b3ad7ab5c5300: drm/selftests: Add drm helper selftest (2018-05-04 11:36:45 +0200) ---------------------------------------------------------------- drm-misc-next for v4.18: Ignore the dma-fence changes, they have been immediately reverted. Core Changes: - Rounding behavior when clipping a visible plane has changed slightly. We now consistently try to round towards the 1.0x scale to prevent running into hw limits. Driver Changes: - Add a drm driver for broadcom V3D V3.x+. (Eric) - Add syncobj support to vc4. (Stefan) - Assorted bugfixes. ---------------------------------------------------------------- Colin Ian King (1): gpu: drm: sti: fix spelling mistake: "initialze" -> "initialize" Daniel Vetter (13): dma-fence: Some kerneldoc polish for dma-fence.h drm: Drop DRM_CONTROL_ALLOW from ioctls drm/i915: Drop DRM_CONTROL_ALLOW drm/vmwgfx: Drop DRM_CONTROL_ALLOW dma-fence: remove fill_driver_data callback dma-fence: Make ->enable_signaling optional dma-fence: Allow wait_any_timeout for all fences dma-fence: Make ->wait callback optional drm: Remove unecessary dma_fence_ops drm/qxl: Remove unecessary dma_fence_ops Revert 190c462d5be19ba622a82f5fd0625087c870a1e6..bf3012ada1b2222e770de5c35c1bb16f73b3a01d" drm/msm: Don't setup control node debugfs files drm: remove all control node code Eric Anholt (6): drm: Make the prime vmap/vunmap hooks optional. drm/vc4: Skip ULPS latching when we're in that ULPS state already. drm/panel: Enable DSI transactions on the RPi panel. drm/vc4: Add a pad field to align drm_vc4_submit_cl to 64 bits. dt-bindings: Add a new binding for Broadcom V3D 3.x and newer GPUs. drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+ Gerd Hoffmann (4): qxl: remove qxl_io_log() qxl: move qxl_send_monitors_config() qxl: hook monitors_config updates into crtc, not encoder. qxl: drop dummy functions Jia-Ju Bai (1): gpu: drm: bridge: adv7511: Replace mdelay with usleep_range in adv7511_probe Kristian H. Kristensen (1): drm/rockchip: Disable blending for win0 Linus Walleij (3): drm/pl111: Support the Versatile Express drm/pl111: Enable device-specific assigned memory drm/pl111: Fix module probe bug Maarten Lankhorst (5): drm/rect: Round above 1 << 16 upwards to correct scale calculation functions. drm/rect: Handle rounding errors in drm_rect_clip_scaled, v3. drm/i915: Do not adjust scale when out of bounds, v2. drm/selftests: Rename the Kconfig option to CONFIG_DRM_DEBUG_SELFTEST drm/selftests: Add drm helper selftest Manasi Navare (1): drm/dp: Rename the edp_sdp_header as dp_sdp_header Peter Rosin (1): drm/bridge: adv7511: fix spelling of driver name in Kconfig Philippe CORNU (3): drm/stm: ltdc: fix deferred endpoint management drm/stm: ltdc: add mode_valid() drm/stm: ltdc: fix warnings in ltdc_plane_create() Satendra Singh Thakur (1): drm/atomic: Handling the case when setting old crtc for plane Stefan Schake (3): drm/vc4: Syncobj import support drm/vc4: Export fence through syncobj drm/vc4: Enable syncobj support Tom Callaway (1): drm/tinydrm/mi0283qt: Always set rotation value Vaishali Thakkar (1): drm/vc4: make function vc4_allocate_bin_bo static Ville Syrjälä (2): drm: Don't pass the index to drm_property_add_enum() drm/rect: Fix drm_rect_rotation_inv() docs .../devicetree/bindings/gpu/brcm,bcm-v3d.txt | 28 + Documentation/gpu/drivers.rst | 1 + MAINTAINERS | 8 + drivers/gpu/drm/Kconfig | 11 +- drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/bridge/adv7511/Kconfig | 2 +- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +- drivers/gpu/drm/drm_atomic.c | 4 +- drivers/gpu/drm/drm_atomic_helper.c | 2 +- drivers/gpu/drm/drm_connector.c | 6 +- drivers/gpu/drm/drm_drv.c | 10 - drivers/gpu/drm/drm_framebuffer.c | 3 +- drivers/gpu/drm/drm_ioc32.c | 4 +- drivers/gpu/drm/drm_ioctl.c | 76 ++- drivers/gpu/drm/drm_prime.c | 8 +- drivers/gpu/drm/drm_property.c | 27 +- drivers/gpu/drm/drm_rect.c | 74 ++- drivers/gpu/drm/drm_sysfs.c | 4 +- drivers/gpu/drm/gma500/cdv_device.c | 4 +- drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 +- drivers/gpu/drm/i915/Kconfig.debug | 2 +- drivers/gpu/drm/i915/i915_drv.c | 8 +- drivers/gpu/drm/i915/intel_sdvo.c | 5 +- drivers/gpu/drm/i915/intel_sprite.c | 144 ++--- drivers/gpu/drm/msm/adreno/adreno_device.c | 1 - drivers/gpu/drm/msm/msm_debugfs.c | 3 - drivers/gpu/drm/nouveau/nouveau_display.c | 4 +- .../gpu/drm/panel/panel-raspberrypi-touchscreen.c | 14 +- drivers/gpu/drm/pl111/Makefile | 1 + drivers/gpu/drm/pl111/pl111_drm.h | 1 + drivers/gpu/drm/pl111/pl111_drv.c | 34 +- drivers/gpu/drm/pl111/pl111_versatile.c | 56 +- drivers/gpu/drm/pl111/pl111_vexpress.c | 134 +++++ drivers/gpu/drm/pl111/pl111_vexpress.h | 29 + drivers/gpu/drm/qxl/qxl_cmd.c | 36 +- drivers/gpu/drm/qxl/qxl_display.c | 276 +++------ drivers/gpu/drm/qxl/qxl_drv.h | 3 - drivers/gpu/drm/qxl/qxl_fb.c | 2 - drivers/gpu/drm/qxl/qxl_irq.c | 3 +- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 13 +- drivers/gpu/drm/selftests/Makefile | 2 +- drivers/gpu/drm/selftests/drm_helper_selftests.h | 9 + drivers/gpu/drm/selftests/test-drm-helper.c | 247 ++++++++ drivers/gpu/drm/sti/sti_crtc.c | 2 +- drivers/gpu/drm/stm/ltdc.c | 53 +- drivers/gpu/drm/tinydrm/mi0283qt.c | 41 +- drivers/gpu/drm/v3d/Kconfig | 9 + drivers/gpu/drm/v3d/Makefile | 18 + drivers/gpu/drm/v3d/v3d_bo.c | 389 ++++++++++++ drivers/gpu/drm/v3d/v3d_debugfs.c | 191 ++++++ drivers/gpu/drm/v3d/v3d_drv.c | 371 ++++++++++++ drivers/gpu/drm/v3d/v3d_drv.h | 294 +++++++++ drivers/gpu/drm/v3d/v3d_fence.c | 58 ++ drivers/gpu/drm/v3d/v3d_gem.c | 668 +++++++++++++++++++++ drivers/gpu/drm/v3d/v3d_irq.c | 206 +++++++ drivers/gpu/drm/v3d/v3d_mmu.c | 122 ++++ drivers/gpu/drm/v3d/v3d_regs.h | 295 +++++++++ drivers/gpu/drm/v3d/v3d_sched.c | 228 +++++++ drivers/gpu/drm/v3d/v3d_trace.h | 82 +++ drivers/gpu/drm/v3d/v3d_trace_points.c | 9 + drivers/gpu/drm/vc4/vc4_drv.c | 3 +- drivers/gpu/drm/vc4/vc4_drv.h | 1 + drivers/gpu/drm/vc4/vc4_dsi.c | 5 + drivers/gpu/drm/vc4/vc4_gem.c | 57 +- drivers/gpu/drm/vc4/vc4_v3d.c | 3 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 8 +- include/drm/drm_device.h | 1 - include/drm/drm_dp_helper.h | 8 +- include/drm/drm_file.h | 13 - include/drm/drm_ioctl.h | 7 - include/drm/drm_property.h | 2 +- include/drm/drm_rect.h | 3 +- include/linux/dma-fence.h | 236 +++++--- include/uapi/drm/v3d_drm.h | 194 ++++++ include/uapi/drm/vc4_drm.h | 13 +- 75 files changed, 4274 insertions(+), 622 deletions(-) create mode 100644 Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.txt create mode 100644 drivers/gpu/drm/pl111/pl111_vexpress.c create mode 100644 drivers/gpu/drm/pl111/pl111_vexpress.h create mode 100644 drivers/gpu/drm/selftests/drm_helper_selftests.h create mode 100644 drivers/gpu/drm/selftests/test-drm-helper.c create mode 100644 drivers/gpu/drm/v3d/Kconfig create mode 100644 drivers/gpu/drm/v3d/Makefile create mode 100644 drivers/gpu/drm/v3d/v3d_bo.c create mode 100644 drivers/gpu/drm/v3d/v3d_debugfs.c create mode 100644 drivers/gpu/drm/v3d/v3d_drv.c create mode 100644 drivers/gpu/drm/v3d/v3d_drv.h create mode 100644 drivers/gpu/drm/v3d/v3d_fence.c create mode 100644 drivers/gpu/drm/v3d/v3d_gem.c create mode 100644 drivers/gpu/drm/v3d/v3d_irq.c create mode 100644 drivers/gpu/drm/v3d/v3d_mmu.c create mode 100644 drivers/gpu/drm/v3d/v3d_regs.h create mode 100644 drivers/gpu/drm/v3d/v3d_sched.c create mode 100644 drivers/gpu/drm/v3d/v3d_trace.h create mode 100644 drivers/gpu/drm/v3d/v3d_trace_points.c create mode 100644 include/uapi/drm/v3d_drm.h

1 0

[PATCH] drm/tegra: hub: Use state directly
by Stefan Schake 04 May '18

04 May '18

Using drm_atomic_get_private_obj_state after state has been swapped will return old state. Fixes: 0281c4149021 ("drm/tegra: hub: Use private object for global state") Signed-off-by: Stefan Schake <stschake(a)gmail.com> --- drivers/gpu/drm/tegra/hub.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c index 9a3f23d4780f..bdd2cdd0745c 100644 --- a/drivers/gpu/drm/tegra/hub.c +++ b/drivers/gpu/drm/tegra/hub.c @@ -683,12 +683,11 @@ void tegra_display_hub_atomic_commit(struct drm_device *drm, { struct tegra_drm *tegra = drm->dev_private; struct tegra_display_hub *hub = tegra->hub; - struct tegra_display_hub_state *hub_state; + struct tegra_display_hub_state *hub_state = + to_tegra_display_hub_state(hub->base.state); struct device *dev = hub->client.dev; int err; - hub_state = tegra_display_hub_get_state(hub, state); - if (hub_state->clk) { err = clk_set_rate(hub_state->clk, hub_state->rate); if (err < 0) -- 2.14.1

2 2

[Bug 199025] Suspend hangs. Never fully suspends and impossible to return to running state.
by bugzilla-daemon＠bugzilla.kernel.org 04 May '18

04 May '18

https://bugzilla.kernel.org/show_bug.cgi?id=199025 Chen Yu (yu.c.chen(a)intel.com) changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Hibernation/Suspend |Video(DRI - non Intel) Assignee|rjw(a)rjwysocki.net |drivers_video-dri@kernel-bu | |gs.osdl.org Product|Power Management |Drivers -- You are receiving this mail because: You are watching the assignee of the bug.

1 0

drm SPDX updates
by Dirk Hohndel (VMware) 04 May '18

04 May '18

This series clarifies licenses, removes unnecessary boilerplate and addas SPDX headers for files in drm that are copyrighted by VMware. /D

3 11

[PATCH v1] i915: Convert to use match_string() helper
by Andy Shevchenko 04 May '18

04 May '18

The new helper returns index of the matching string in an array. We are going to use it here. Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> --- drivers/gpu/drm/i915/intel_pipe_crc.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pipe_crc.c b/drivers/gpu/drm/i915/intel_pipe_crc.c index 4f367c16e9e5..39a4e4edda07 100644 --- a/drivers/gpu/drm/i915/intel_pipe_crc.c +++ b/drivers/gpu/drm/i915/intel_pipe_crc.c @@ -766,13 +766,12 @@ display_crc_ctl_parse_object(const char *buf, enum intel_pipe_crc_object *o) { int i; - for (i = 0; i < ARRAY_SIZE(pipe_crc_objects); i++) - if (!strcmp(buf, pipe_crc_objects[i])) { - *o = i; - return 0; - } + i = match_string(pipe_crc_objects, ARRAY_SIZE(pipe_crc_objects), buf); + if (i < 0) + return i; - return -EINVAL; + *o = i; + return 0; } static int display_crc_ctl_parse_pipe(struct drm_i915_private *dev_priv, @@ -798,13 +797,12 @@ display_crc_ctl_parse_source(const char *buf, enum intel_pipe_crc_source *s) return 0; } - for (i = 0; i < ARRAY_SIZE(pipe_crc_sources); i++) - if (!strcmp(buf, pipe_crc_sources[i])) { - *s = i; - return 0; - } + i = match_string(pipe_crc_sources, ARRAY_SIZE(pipe_crc_sources), buf); + if (i < 0) + return i; - return -EINVAL; + *s = i; + return 0; } static int display_crc_ctl_parse(struct drm_i915_private *dev_priv, -- 2.17.0

2 1

[Bug 106199] Cannot get back into DM after logoff (Linux 4.16.2+)
by bugzilla-daemon＠freedesktop.org 04 May '18

04 May '18

https://bugs.freedesktop.org/show_bug.cgi?id=106199 Bug ID: 106199 Summary: Cannot get back into DM after logoff (Linux 4.16.2+) Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: mabo(a)elbmurf.de Created attachment 139031 --> https://bugs.freedesktop.org/attachment.cgi?id=139031&action=edit LightDM ant soccer Starting with Linux 4.16.2, when I logoff from KDE Plasma, I don’t get back into SDDM (just a black screen) or back into LightDM (wild random blocky screen, see attachment). I have a RX 580, DC is on. Same result on Linux 4.17rc2. Distro is Antergos/Arch. Monitor is connected via DP. Using SDDM, I can press ctrl + alt + F1 etc. to theoretically get to a tty prompt but the screen does stay black. But then, after pressing ctrl + alt + del numerous times, at least my system does a proper reboot. In LightDM, this does not work and I have to use the reset button. Worked with Linux 4.16.1 before. -- You are receiving this mail because: You are the assignee for the bug.

1 11

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2018