dri-devel February 2019

dri-devel@lists.freedesktop.org

256 participants
1976 discussions

[pull] ttm, amdgpu drm-next-5.1
by Alex Deucher 01 Feb '19

01 Feb '19

Hi Dave, Daniel, More stuff for 5.1. Mostly bug fixes. ttm: - Replace ref/unref naming with get/put amdgpu: - Revert DC clang fix, causes a segfault with some compiler versions - SR-IOV fix - PCIE fix for vega20 - Misc DC fixes The following changes since commit 10117450735c7a7c0858095fb46a860e7037cb9a: drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines (2019-01-25 16:15:37 -0500) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux drm-next-5.1 for you to fetch changes up to 47dd8048a1bf5b2fb96e5abe99b4f1dcd208ea4d: drm/amdgpu: Show XGMI node and hive message per device only once (2019-01-29 15:16:18 -0500) ---------------------------------------------------------------- Alex Deucher (1): Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines" Eric Huang (1): drm/amd/powerplay: add override pcie parameters for Vega20 Fatemeh Darbehani (1): drm/amd/display: Add Vline1 interrupt source to InterruptManager Martin Tsai (1): drm/amd/display: Poll pending down rep before clear payload allocation table Nicholas Kazlauskas (3): drm/amd/display: Enable vblank interrupt during CRC capture drm/amd/display: Re-enable CRC capture following modeset drm/amd/display: Don't leak memory when updating streams Thomas Zimmermann (7): drm/ast: Replace ttm_bo_unref with ttm_bo_put drm/nouveau: Replace ttm_bo_reference with ttm_bo_get drm/nouveau: Replace ttm_bo_unref with ttm_bo_put drm/vmwgfx: Replace ttm_bo_reference with ttm_bo_get drm/vmwgfx: Replace ttm_bo_unref with ttm_bo_put drm/mgag200: Replace ttm_bo_unref with ttm_bo_put drm/ttm: Remove ttm_bo_reference and ttm_bo_unref shaoyunl (1): drm/amdgpu: Show XGMI node and hive message per device only once wentalou (2): drm/amdgpu: csa_vaddr should not larger than AMDGPU_GMC_HOLE_START drm/amdgpu: sriov restrict max_pfn below AMDGPU_GMC_HOLE drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 7 +-- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 6 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 29 ++++++++- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 48 ++++++++------- .../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 7 +++ drivers/gpu/drm/amd/display/dc/calcs/Makefile | 2 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 10 +-- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 5 ++ drivers/gpu/drm/amd/display/dc/dc_stream.h | 14 ++++- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c | 72 +++++----------------- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.h | 12 +++- drivers/gpu/drm/amd/display/dc/dm_helpers.h | 7 +++ drivers/gpu/drm/amd/display/dc/dml/Makefile | 2 +- .../drm/amd/display/dc/inc/hw/timing_generator.h | 13 +++- drivers/gpu/drm/amd/display/dc/irq_types.h | 8 +++ drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 46 ++++++++++++++ drivers/gpu/drm/ast/ast_main.c | 6 +- drivers/gpu/drm/mgag200/mgag200_main.c | 8 +-- drivers/gpu/drm/nouveau/nouveau_bo.h | 12 ++-- drivers/gpu/drm/nouveau/nouveau_gem.c | 3 +- drivers/gpu/drm/ttm/ttm_bo.c | 9 --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 11 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 11 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 9 +-- drivers/gpu/drm/vmwgfx/vmwgfx_mob.c | 21 ++++--- drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 9 ++- drivers/gpu/drm/vmwgfx/vmwgfx_validation.c | 6 +- include/drm/ttm/ttm_bo_api.h | 28 --------- 28 files changed, 239 insertions(+), 182 deletions(-)

1 0

[drm-tip:drm-tip 891/897] drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:160:9: warning: #pragma pack (pop) encountered without matching #pragma pack (push)
by kbuild test robot 01 Feb '19

01 Feb '19

tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: 3f287cb6d4ae4689eb7c53e4c25f0fba3df16438 commit: 0a2fe4901d16d28bb8ad5f7032e9579f85e7e594 [891/897] Merge remote-tracking branch 'drm/drm-next' into drm-tip config: riscv-allmodconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 8.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 0a2fe4901d16d28bb8ad5f7032e9579f85e7e594 # save the attached .config to linux build tree GCC_VERSION=8.2.0 make.cross ARCH=riscv All warnings (new ones prefixed by >>): >> drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:160:9: warning: #pragma pack (pop) encountered without matching #pragma pack (push) [-Wpragmas] #pragma pack(pop) ^~~~ vim +160 drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c bf75572a Josip Pavic 2019-01-08 117 bf75572a Josip Pavic 2019-01-08 118 struct iram_table_v_2_2 { bf75572a Josip Pavic 2019-01-08 119 /* flags */ bf75572a Josip Pavic 2019-01-08 120 uint16_t flags; /* 0x00 U16 */ bf75572a Josip Pavic 2019-01-08 121 bf75572a Josip Pavic 2019-01-08 122 /* parameters for ABM2.2 algorithm */ bf75572a Josip Pavic 2019-01-08 123 uint8_t min_reduction[NUM_AMBI_LEVEL][NUM_AGGR_LEVEL]; /* 0x02 U0.8 */ bf75572a Josip Pavic 2019-01-08 124 uint8_t max_reduction[NUM_AMBI_LEVEL][NUM_AGGR_LEVEL]; /* 0x16 U0.8 */ bf75572a Josip Pavic 2019-01-08 125 uint8_t bright_pos_gain[NUM_AMBI_LEVEL][NUM_AGGR_LEVEL]; /* 0x2a U2.6 */ bf75572a Josip Pavic 2019-01-08 126 uint8_t dark_pos_gain[NUM_AMBI_LEVEL][NUM_AGGR_LEVEL]; /* 0x3e U2.6 */ bf75572a Josip Pavic 2019-01-08 127 uint8_t hybridFactor[NUM_AGGR_LEVEL]; /* 0x52 U0.8 */ bf75572a Josip Pavic 2019-01-08 128 uint8_t contrastFactor[NUM_AGGR_LEVEL]; /* 0x56 U0.8 */ bf75572a Josip Pavic 2019-01-08 129 uint8_t deviation_gain[NUM_AGGR_LEVEL]; /* 0x5a U0.8 */ bf75572a Josip Pavic 2019-01-08 130 uint8_t iir_curve[NUM_AMBI_LEVEL]; /* 0x5e U0.8 */ bf75572a Josip Pavic 2019-01-08 131 uint8_t pad[29]; /* 0x63 U0.8 */ bf75572a Josip Pavic 2019-01-08 132 bf75572a Josip Pavic 2019-01-08 133 /* parameters for crgb conversion */ bf75572a Josip Pavic 2019-01-08 134 uint16_t crgb_thresh[NUM_POWER_FN_SEGS]; /* 0x80 U3.13 */ bf75572a Josip Pavic 2019-01-08 135 uint16_t crgb_offset[NUM_POWER_FN_SEGS]; /* 0x90 U1.15 */ bf75572a Josip Pavic 2019-01-08 136 uint16_t crgb_slope[NUM_POWER_FN_SEGS]; /* 0xa0 U4.12 */ bf75572a Josip Pavic 2019-01-08 137 bf75572a Josip Pavic 2019-01-08 138 /* parameters for custom curve */ bf75572a Josip Pavic 2019-01-08 139 /* thresholds for brightness --> backlight */ bf75572a Josip Pavic 2019-01-08 140 uint16_t backlight_thresholds[NUM_BL_CURVE_SEGS]; /* 0xb0 U16.0 */ bf75572a Josip Pavic 2019-01-08 141 /* offsets for brightness --> backlight */ bf75572a Josip Pavic 2019-01-08 142 uint16_t backlight_offsets[NUM_BL_CURVE_SEGS]; /* 0xd0 U16.0 */ bf75572a Josip Pavic 2019-01-08 143 bf75572a Josip Pavic 2019-01-08 144 /* For reading PSR State directly from IRAM */ bf75572a Josip Pavic 2019-01-08 145 uint8_t psr_state; /* 0xf0 */ bf75572a Josip Pavic 2019-01-08 146 uint8_t dmcu_mcp_interface_version; /* 0xf1 */ bf75572a Josip Pavic 2019-01-08 147 uint8_t dmcu_abm_feature_version; /* 0xf2 */ bf75572a Josip Pavic 2019-01-08 148 uint8_t dmcu_psr_feature_version; /* 0xf3 */ bf75572a Josip Pavic 2019-01-08 149 uint16_t dmcu_version; /* 0xf4 */ bbf854dc David Francis 2018-11-26 150 uint8_t dmcu_state; /* 0xf6 */ bbf854dc David Francis 2018-11-26 151 bbf854dc David Francis 2018-11-26 152 uint16_t blRampReduction; /* 0xf7 */ bbf854dc David Francis 2018-11-26 153 uint16_t blRampStart; /* 0xf9 */ bbf854dc David Francis 2018-11-26 154 uint8_t dummy5; /* 0xfb */ bbf854dc David Francis 2018-11-26 155 uint8_t dummy6; /* 0xfc */ bbf854dc David Francis 2018-11-26 156 uint8_t dummy7; /* 0xfd */ bbf854dc David Francis 2018-11-26 157 uint8_t dummy8; /* 0xfe */ bbf854dc David Francis 2018-11-26 158 uint8_t dummy9; /* 0xff */ bbf854dc David Francis 2018-11-26 159 }; 099139be Josip Pavic 2018-12-11 @160 #pragma pack(pop) bbf854dc David Francis 2018-11-26 161 :::::: The code at line 160 was first introduced by commit :::::: 099139bef026faefebc508ddb77d397cf55f1b15 drm/amd/display: Pack DMCU iRAM alignment :::::: TO: Josip Pavic <Josip.Pavic(a)amd.com> :::::: CC: Alex Deucher <alexander.deucher(a)amd.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[pull] radeon, amdgpu drm-fixes-5.0
by Alex Deucher 01 Feb '19

01 Feb '19

Hi Dave, Daniel, Sorry this is a bit late. I had Internet issues yesterday. A few fixes for 5.0: - Fix radeon crash on SI with VM passthrough - Fencing fix for shared buffers - Fix power hwmon reporting on APUs - Powerplay fix for APUs The following changes since commit f0e7ce1eef5854584dfb59b3824a67edee37580f: Merge tag 'drm-msm-fixes-2019-01-24' of git://people.freedesktop.org/~robclark/linux into drm-fixes (2019-01-25 07:45:00 +1000) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux drm-fixes-5.0 for you to fetch changes up to 6e11ea9de9576a644045ffdc2067c09bc2012eda: drm/amdgpu: Transfer fences to dmabuf importer (2019-01-30 12:52:44 -0500) ---------------------------------------------------------------- Alex Deucher (2): drm/amdgpu: Add missing power attribute to APU check drm/radeon: check if device is root before getting pci speed caps Chris Wilson (1): drm/amdgpu: Transfer fences to dmabuf importer Gustavo A. R. Silva (1): drm/amd/powerplay: Fix missing break in switch drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c | 59 ++++++++++++++++++++--- drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 1 + drivers/gpu/drm/radeon/ci_dpm.c | 5 +- drivers/gpu/drm/radeon/si_dpm.c | 5 +- 5 files changed, 60 insertions(+), 13 deletions(-)

1 0

[PATCH v2] drm/vmwgfx: Fix an uninitialized fence handle value
by Thomas Hellstrom 01 Feb '19

01 Feb '19

if vmw_execbuf_fence_commands() fails, The handle value will be uninitialized and a bogus fence handle might be copied to user-space. Fixes: 2724b2d54cda: ("drm/vmwgfx: Use new validation interface for the modesetting code v2") Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com> Signed-off-by: Thomas Hellstrom <thellstrom(a)vmware.com> Reviewed-by: Brian Paul <brianp(a)vmware.com> #v1 Reviewed-by: Sinclair Yeh <syeh(a)vmware.com> #v1 --- v2: Also initialize the ret local variable, to silence compilatior warnings. Call vmw_execbuf_copy_fence_user regardless of the value of ret, to propagate the correct error code to user-space. --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index b351fb5214d3..5e257a600cea 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -2554,8 +2554,8 @@ void vmw_kms_helper_validation_finish(struct vmw_private *dev_priv, user_fence_rep) { struct vmw_fence_obj *fence = NULL; - uint32_t handle; - int ret; + uint32_t handle = 0; + int ret = 0; if (file_priv || user_fence_rep || vmw_validation_has_bos(ctx) || out_fence) -- 2.19.0.rc1

2 1

[PATCH] drm/vmwgfx: Return error code from vmw_execbuf_copy_fence_user
by Thomas Hellstrom 01 Feb '19

01 Feb '19

The function was unconditionally returning 0, and a caller would have to rely on the returned fence pointer being NULL to detect errors. However, the function vmw_execbuf_copy_fence_user() would expect a non-zero error code in that case and would BUG otherwise. So make sure we return a proper non-zero error code if the fence pointer returned is NULL. Fixes: ae2a104058e2: ("vmwgfx: Implement fence objects") Signed-off-by: Thomas Hellstrom <thellstrom(a)vmware.com> --- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c index f2d13a72c05d..88b8178d4687 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c @@ -3570,7 +3570,7 @@ int vmw_execbuf_fence_commands(struct drm_file *file_priv, *p_fence = NULL; } - return 0; + return ret; } /** -- 2.19.0.rc1

2 1

linux-next: build warning after merge of the drm tree
by Stephen Rothwell 01 Feb '19

01 Feb '19

Hi all, After merging the drm tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:160:9: warning: #pragma pack (pop) encountered without matching #pragma pack (push) [-Wpragmas] #pragma pack(pop) ^~~~ Introduced by commit 1411fd85416f ("Merge remote-tracking branch 'drm/drm-next'") Commits 099139bef026 ("drm/amd/display: Pack DMCU iRAM alignment") from Linus' tree and c591d8429df2 ("drm/amd/display: Pack DMCU iRAM alignment") from the drm tree are identical, but then commit bf75572a2536 ("drm/amd/display: Create switching mechanism for ABM 2.2") added more code before the "#pragma(pop)" and so git's automatic merge resolution ended up adding the "#pragma(pop)" line twice. I will fix up the merge resolution for tomorrow. This will need to be reported to Linus when the drm tree is merged (or a back merge of Linus' tree will need to be done - and well commented :-)). -- Cheers, Stephen Rothwell

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel February 2019