dri-devel April 2019

dri-devel@lists.freedesktop.org

307 participants
2114 discussions

[PATCH 2/7] drm/meson: fix possible object reference leak
by Wen Yang 04 Apr '19

04 Apr '19

The call to of_graph_get_remote_port returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: drivers/gpu/drm/meson/meson_dw_hdmi.c:725:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 722, but without a corresponding object release within this function. Signed-off-by: Wen Yang <wen.yang99(a)zte.com.cn> Cc: Neil Armstrong <narmstrong(a)baylibre.com> Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Kevin Hilman <khilman(a)baylibre.com> Cc: dri-devel(a)lists.freedesktop.org Cc: linux-amlogic(a)lists.infradead.org Cc: linux-arm-kernel(a)lists.infradead.org Cc: linux-kernel(a)vger.kernel.org (open list) --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c index 563953e..109a933 100644 --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c @@ -720,13 +720,10 @@ static bool meson_hdmi_connector_is_available(struct device *dev) /* If the endpoint node exists, consider it enabled */ remote = of_graph_get_remote_port(ep); - if (remote) { - of_node_put(ep); - return true; - } - of_node_put(ep); of_node_put(remote); + if (remote) + return true; return false; } -- 2.9.5

2 1

[PATCH v5 0/3] drm/panel: Support Rocktech jh057n00900 DSI panel
by Guido Günther 04 Apr '19

04 Apr '19

v4 fixes up the DT binding example and uses a wider cc list since I failed to extend that when touching more files. The panel is a 5.5" 720x1440 TFT LCD MIPI DSI panel with built in touchscreen and backlight as found in the Librem 5 devkit. These patches are against linux next as of 2019-03-22. v3 got acked by Sam Ravnborg: https://lists.freedesktop.org/archives/dri-devel/2019-March/209326.html Changes from v4 * As per review comments from Fabio Estevam * Add missing unit name in dt binding docs Changes from v3 * Forward to next-20190322 * Add MAINTAINERS entry Changes from v2 * As per review comments from Sam Ravnborg * Lowercase sentinel * Drop '_panel' postfix * DRM_DEV_ logging instead of plain DRM_ * Add Reviewed-by: * Add "panel-rocktech-" to the driver name following the pattern from other drm panel drivers. Changes from v1 * As per review comments from Sam Ravnborg * Make SPDX-License-Identifier match MODULE_LICENSE * Sort include files alphabetically * Drop drmP.h and use individual includes * Drop superfuous 'x' in mode printout on error path * Allpixelson_set: Add proper space around '*' * Drop superfluous put_device(&ctx->backlight->dev); * Add /* Sentinel */ in jh057n_of_match * Drop jh057n->enabled * Drop drm_display_info_set_bus_formats * Kconfig: Depend on BACKLIGHT_CLASS_DEVICE which somehow got lost * Move jh057n_enable close to jh057n_disable Guido Günther (3): dt-bindings: Add vendor prefix for ROCKTECH DISPLAYS LIMITED dt-bindings: Add Rocktech jh057n00900 panel bindings drm/panel: Add Rocktech jh057n00900 panel driver .../display/panel/rocktech,jh057n00900.txt | 18 + .../devicetree/bindings/vendor-prefixes.txt | 1 + MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 13 + drivers/gpu/drm/panel/Makefile | 1 + .../drm/panel/panel-rocktech-jh057n00900.c | 386 ++++++++++++++++++ 6 files changed, 425 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt create mode 100644 drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c -- 2.20.1

4 17

[Bug 109648] AMD Raven hang during va-api decoding
by bugzilla-daemon＠freedesktop.org 04 Apr '19

04 Apr '19

https://bugs.freedesktop.org/show_bug.cgi?id=109648 Bug ID: 109648 Summary: AMD Raven hang during va-api decoding Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: major Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: xanto(a)egaming.ro QA Contact: dri-devel(a)lists.freedesktop.org Created attachment 143383 --> https://bugs.freedesktop.org/attachment.cgi?id=143383&action=edit dmesg Hello, After fixing https://bugs.freedesktop.org/show_bug.cgi?id=109107, hardware decode on Ryzen 2700u started working again. However, at the next update at mesa git 67426cc the GPU is hanging completely if I try to watch videos on chromium-vaapi, with the following error: [ 215.259576] amdgpu 0000:04:00.0: [mmhub] VMC page fault (src_id:0 ring:40 vmid:5 pasid:32770, for process chromium-vaapi pid 2877 thread chromium-v:cs0 pid 2946) [ 215.259583] amdgpu 0000:04:00.0: in page starting at address 0x0000800110352000 from 18 [ 215.259585] amdgpu 0000:04:00.0: VM_L2_PROTECTION_FAULT_STATUS:0x00540451 [ 225.212368] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring vcn_dec timeout, signaled seq=46, emitted seq=48 [ 225.212466] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* Process information: process chromium-vaapi pid 2877 thread chromium-v:cs0 pid 2946 Graphical interface is hanged completely however music keeps hanging in the background, so I was able to ssh into the system and dump the dmesg log. Fedora repos: che-mesa, rpmfusion, fedora-rawhide-kernel-nodebug Mesa-git installed is build from: sha 67426cc Full dmesg log attached. -- You are receiving this mail because: You are the assignee for the bug.

1 7

[PATCH v2 0/6] drm/cirrus: rewrite and modernize driver.
by Gerd Hoffmann 04 Apr '19

04 Apr '19

v2: - It's a little series now. It moves tinydrm converters to drm_fb_helpers.c first. - Added support for RG24 and XR24. Without bpp module parameter, instead the driver will convert formats if needed. - A bunch of little tweaks here and there (embedded struct drm_driver, use more drm helpers, ...) Gerd Hoffmann (6): drm: move tinydrm_memcpy() to drm_fb_helper.c drm: add dstclip parameter to drm_fb_memcpy() drm: move tinydrm_xrgb8888_to_rgb565() to drm_fb_helper.c drm: add dstclip parameter to drm_fb_xrgb8888_to_rgb565() drm: add drm_fb_xrgb8888_to_rgb888() function to drm_fb_helper.c drm/cirrus: rewrite and modernize driver. drivers/gpu/drm/cirrus/cirrus_drv.h | 251 ------- include/drm/drm_fb_helper.h | 11 + include/drm/tinydrm/tinydrm-helpers.h | 5 - drivers/gpu/drm/cirrus/cirrus.c | 621 ++++++++++++++++++ drivers/gpu/drm/cirrus/cirrus_drv.c | 161 ----- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 309 --------- drivers/gpu/drm/cirrus/cirrus_main.c | 328 --------- drivers/gpu/drm/cirrus/cirrus_mode.c | 617 ----------------- drivers/gpu/drm/cirrus/cirrus_ttm.c | 343 ---------- drivers/gpu/drm/drm_fb_helper.c | 127 ++++ .../gpu/drm/tinydrm/core/tinydrm-helpers.c | 69 -- drivers/gpu/drm/tinydrm/mipi-dbi.c | 5 +- drivers/gpu/drm/cirrus/Kconfig | 2 +- drivers/gpu/drm/cirrus/Makefile | 3 - 14 files changed, 763 insertions(+), 2089 deletions(-) delete mode 100644 drivers/gpu/drm/cirrus/cirrus_drv.h create mode 100644 drivers/gpu/drm/cirrus/cirrus.c delete mode 100644 drivers/gpu/drm/cirrus/cirrus_drv.c delete mode 100644 drivers/gpu/drm/cirrus/cirrus_fbdev.c delete mode 100644 drivers/gpu/drm/cirrus/cirrus_main.c delete mode 100644 drivers/gpu/drm/cirrus/cirrus_mode.c delete mode 100644 drivers/gpu/drm/cirrus/cirrus_ttm.c -- 2.18.1

3 14

'sleeping function called from invalid context' in virtio_gpu_cmd_get_edid_cb
by Max Filippov 04 Apr '19

04 Apr '19

Hello, I get the following warning during v5.1-rc3 bootup on QEMU with virtio-gpu-pci BUG: sleeping function called from invalid context at mm/slab.h:418 in_atomic(): 1, irqs_disabled(): 0, pid: 14, name: kworker/0:1 Preemption disabled at: virtio_gpu_cmd_get_edid_cb+0x4c/0x9c CPU: 0 PID: 14 Comm: kworker/0:1 Not tainted 5.1.0-rc3-00007-g2c6e21bcbbae #6 Workqueue: events virtio_gpu_dequeue_ctrl_func Call Trace: ___might_sleep+0xfc/0x11c __might_sleep+0x42/0x64 __kmalloc+0x66/0x1f0 kvmalloc_node+0x66/0x7c drm_property_create_blob$part$0+0x14/0x8c drm_property_replace_global_blob+0x40/0xdc drm_connector_update_edid_property+0x58/0x74 virtio_gpu_cmd_get_edid_cb+0x62/0x9c virtio_gpu_dequeue_ctrl_func+0xd1/0x188 process_one_work+0x1a0/0x388 worker_thread+0x1e8/0x3b4 kthread+0xe8/0x100 ret_from_kernel_thread+0xc/0x18 Looks like virtio_gpu_cmd_get_edid_cb calls drm_connector_update_edid_property under the spinlock and the latter function may sleep. -- Thanks. -- Max

1 0

[Bug 110138] Adaptive Sync, VRR, FreeSync out of range
by bugzilla-daemon＠freedesktop.org 04 Apr '19

04 Apr '19

https://bugs.freedesktop.org/show_bug.cgi?id=110138 grmat(a)sub.red changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from grmat(a)sub.red --- > I think this patch should fix your issue Indeed it does, thanks! :) I've seen it is already in for 5.1. Don't you think it should be backported for 5.0 as well? I'm not sure if the issue could damage the display but for what I can tell, it's a serious bug and surely looks disturbing to users. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PULL] drm-intel-fixes
by Rodrigo Vivi 04 Apr '19

04 Apr '19

Hi Dave and Daniel, Here goes drm-intel-fixes-2019-04-04: Only one fix for DSC (backoff after drm_modeset_lock deadlock) and GVT's fixes including vGPU display plane size calculation, shadow mm pin count, error recovery path for workload create and one kerneldoc fix. Thanks, Rodrigo. The following changes since commit 79a3aaa7b82e3106be97842dedfd8429248896e6: Linux 5.1-rc3 (2019-03-31 14:39:29 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2019-04-04 for you to fetch changes up to 57cbec02f9b10992319ca578797c8059ac47d71e: Merge tag 'gvt-fixes-2019-04-04' of https://github.com/intel/gvt-linux into drm-intel-fixes (2019-04-03 18:00:42 -0700) ---------------------------------------------------------------- Only one fix for DSC (backoff after drm_modeset_lock deadlock) and GVT's fixes including vGPU display plane size calculation, shadow mm pin count, error recovery path for workload create and one kerneldoc fix. ---------------------------------------------------------------- Chris Wilson (2): drm/i915: Always backoff after a drm_modeset_lock() deadlock drm/i915/gvt: Fix kerneldoc typo for intel_vgpu_emulate_hotplug Rodrigo Vivi (1): Merge tag 'gvt-fixes-2019-04-04' of https://github.com/intel/gvt-linux into drm-intel-fixes Xiong Zhang (1): drm/i915/gvt: Correct the calculation of plane size Yan Zhao (2): drm/i915/gvt: do not deliver a workload if its creation fails drm/i915/gvt: do not let pin count of shadow mm go negative drivers/gpu/drm/i915/gvt/display.c | 2 +- drivers/gpu/drm/i915/gvt/dmabuf.c | 8 ++------ drivers/gpu/drm/i915/gvt/gtt.c | 2 +- drivers/gpu/drm/i915/gvt/scheduler.c | 5 +++-- drivers/gpu/drm/i915/i915_debugfs.c | 5 ++++- 5 files changed, 11 insertions(+), 11 deletions(-)

1 0

[PATCH] drm/bridge: ti-tfp410: Fall back to HPD polling if HPD irq is not available
by Peter Ujfalusi 04 Apr '19

04 Apr '19

In case either the HPD gpio is not specified or when the HPD gpio can not be used as interrupt we should tell the core that the HPD needs to be polled for detecting hotplug. Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)ti.com> --- drivers/gpu/drm/bridge/ti-tfp410.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index 285be4a0f4bd..6fc831eb3804 100644 --- a/drivers/gpu/drm/bridge/ti-tfp410.c +++ b/drivers/gpu/drm/bridge/ti-tfp410.c @@ -31,6 +31,7 @@ struct tfp410 { struct i2c_adapter *ddc; struct gpio_desc *hpd; + int hpd_irq; struct delayed_work hpd_work; struct gpio_desc *powerdown; @@ -124,8 +125,10 @@ static int tfp410_attach(struct drm_bridge *bridge) return -ENODEV; } - if (dvi->hpd) + if (dvi->hpd_irq >= 0) dvi->connector.polled = DRM_CONNECTOR_POLL_HPD; + else + dvi->connector.polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT; drm_connector_helper_add(&dvi->connector, &tfp410_con_helper_funcs); @@ -324,10 +327,15 @@ static int tfp410_init(struct device *dev, bool i2c) return PTR_ERR(dvi->powerdown); } - if (dvi->hpd) { + if (dvi->hpd) + dvi->hpd_irq = gpiod_to_irq(dvi->hpd); + else + dvi->hpd_irq = -ENXIO; + + if (dvi->hpd_irq >= 0) { INIT_DELAYED_WORK(&dvi->hpd_work, tfp410_hpd_work_func); - ret = devm_request_threaded_irq(dev, gpiod_to_irq(dvi->hpd), + ret = devm_request_threaded_irq(dev, dvi->hpd_irq, NULL, tfp410_hpd_irq_thread, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "hdmi-hpd", dvi); -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2 3

[PATCH] drm/nouveau: Remove duplicate ACPI_VIDEO_NOTIFY_PROBE definition
by Bjorn Helgaas 04 Apr '19

04 Apr '19

From: Bjorn Helgaas <bhelgaas(a)google.com> Commit 3a6536c51d5d ("drm/nouveau: Intercept ACPI_VIDEO_NOTIFY_PROBE") added a definition of ACPI_VIDEO_NOTIFY_PROBE because <acpi/video.h> didn't supply one. Later, commit eff4a751cce5 ("ACPI / video: Move ACPI_VIDEO_NOTIFY_* defines to acpi/video.h") moved ACPI_VIDEO_NOTIFY_PROBE and other definitions to <acpi/video.h>, so the copy in nouveau_display.c is now unnecessary. Remove the unnecessary definition from nouveau_display.c. Signed-off-by: Bjorn Helgaas <bhelgaas(a)google.com> CC: Hans de Goede <hdegoede(a)redhat.com> --- drivers/gpu/drm/nouveau/nouveau_display.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c index 55c0fa451163..832da8e0020d 100644 --- a/drivers/gpu/drm/nouveau/nouveau_display.c +++ b/drivers/gpu/drm/nouveau/nouveau_display.c @@ -358,15 +358,6 @@ nouveau_display_hpd_work(struct work_struct *work) #ifdef CONFIG_ACPI -/* - * Hans de Goede: This define belongs in acpi/video.h, I've submitted a patch - * to the acpi subsys to move it there from drivers/acpi/acpi_video.c . - * This should be dropped once that is merged. - */ -#ifndef ACPI_VIDEO_NOTIFY_PROBE -#define ACPI_VIDEO_NOTIFY_PROBE 0x81 -#endif - static int nouveau_display_acpi_ntfy(struct notifier_block *nb, unsigned long val, void *data) -- 2.21.0.392.gf8f6787159e-goog

2 1

[PATCH] drm/i915: Fix context IDs not released on driver hot unbind
by Janusz Krzysztofik 04 Apr '19

04 Apr '19

From: Janusz Krzysztofik <janusz.krzysztofik(a)intel.com> In case the driver gets unbound while a device is open, kernel panic may be forced if a list of allocated context IDs is not empty. When a device is open, the list may happen to be not empty because a context ID, once allocated by a context ID allocator to a context assosiated with that open file descriptor, is released as late as on device close. On the other hand, there is a need to release all allocated context IDs and destroy the context ID allocator on driver unbind, even if a device is open, in order to free memory resources consumed and prevent from memory leaks. The purpose of the forced kernel panic was to protect the context ID allocator from being silently destroyed if not all allocated IDs had been released. Before forcing the kernel panic on non-empty list of allocated context IDs, do that unlikely on non-empty list of contexts that should be freed by preceding drain of work queue (there must be another bug if that list happens to be not empty). If empty, we may assume that remaining contexts are idle (not pinned) and their IDs can be safely released. Once done, release context IDs of each of those remaining contexts unless it happens a context is unlikely pinned. Force kernel panic in that case, there must be still another bug in the driver code. Now the kernel panic protecting the allocator should not pop up as the list it checks should be empty. If it unlikely happens to be not empty, there must be still another bug. Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik(a)intel.com> --- drivers/gpu/drm/i915/i915_gem_context.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c index 280813a4bf82..18d004d94e43 100644 --- a/drivers/gpu/drm/i915/i915_gem_context.c +++ b/drivers/gpu/drm/i915/i915_gem_context.c @@ -611,6 +611,8 @@ void i915_gem_contexts_lost(struct drm_i915_private *dev_priv) void i915_gem_contexts_fini(struct drm_i915_private *i915) { + struct i915_gem_context *ctx, *cn; + lockdep_assert_held(&i915->drm.struct_mutex); if (i915->preempt_context) @@ -618,6 +620,14 @@ void i915_gem_contexts_fini(struct drm_i915_private *i915) destroy_kernel_context(&i915->kernel_context); /* Must free all deferred contexts (via flush_workqueue) first */ + GEM_BUG_ON(!llist_empty(&i915->contexts.free_list)); + + /* Release all remaining HW IDs before ID allocator is destroyed */ + list_for_each_entry_safe(ctx, cn, &i915->contexts.hw_id_list, + hw_id_link) { + GEM_BUG_ON(atomic_read(&ctx->hw_id_pin_count)); + release_hw_id(ctx); + } GEM_BUG_ON(!list_empty(&i915->contexts.hw_id_list)); ida_destroy(&i915->contexts.hw_ida); } -- 2.20.1

3 6

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2019