dri-devel April 2019

dri-devel@lists.freedesktop.org

307 participants
2114 discussions

[PATCH] drm/gamma: Clarify gamma lut uapi
by Daniel Vetter 02 Apr '19

02 Apr '19

Interpreting it as a 0.16 fixed point means we can't accurately represent 1.0. Which is one of the values we really should be able to represent. Since most (all?) luts have lower precision this will only affect rounding of 0xffff. Cc: Uma Shankar <uma.shankar(a)intel.com> Cc: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Cc: Shashank Sharma <shashank.sharma(a)intel.com> Cc: "Kumar, Kiran S" <kiran.s.kumar(a)intel.com> Cc: Kausal Malladi <kausalmalladi(a)gmail.com> Cc: Lionel Landwerlin <lionel.g.landwerlin(a)intel.com> Cc: Matt Roper <matthew.d.roper(a)intel.com> Cc: Rob Bradford <robert.bradford(a)intel.com> Cc: Daniel Stone <daniels(a)collabora.com> Cc: Stefan Schake <stschake(a)gmail.com> Cc: Eric Anholt <eric(a)anholt.net> Cc: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Cc: Harry Wentland <harry.wentland(a)amd.com> Cc: Leo Li <sunpeng.li(a)amd.com> Cc: amd-gfx(a)lists.freedesktop.org Cc: James (Qian) Wang <james.qian.wang(a)arm.com> Cc: Liviu Dudau <liviu.dudau(a)arm.com> Cc: Mali DP Maintainers <malidp(a)foss.arm.com> Cc: CK Hu <ck.hu(a)mediatek.com> Cc: Philipp Zabel <p.zabel(a)pengutronix.de> Cc: Yannick Fertre <yannick.fertre(a)st.com> Cc: Philippe Cornu <philippe.cornu(a)st.com> Cc: Benjamin Gaignard <benjamin.gaignard(a)linaro.org> Cc: Vincent Abriou <vincent.abriou(a)st.com> Cc: Tomi Valkeinen <tomi.valkeinen(a)ti.com> Cc: Boris Brezillon <bbrezillon(a)kernel.org> Signed-off-by: Daniel Vetter <daniel.vetter(a)ffwll.ch>Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- include/uapi/drm/drm_mode.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index 09d72966899a..83cd1636b9be 100644 --- a/include/uapi/drm/drm_mode.h +++ b/include/uapi/drm/drm_mode.h @@ -621,7 +621,8 @@ struct drm_color_ctm { struct drm_color_lut { /* - * Data is U0.16 fixed point format. + * Values are mapped linearly to 0.0 - 1.0 range, with 0x0 == 0.0 and + * 0xffff == 1.0. */ __u16 red; __u16 green; -- 2.20.1

8 7

[PATCH 0/3] drm: some qemu driver unload fixes.
by Gerd Hoffmann 02 Apr '19

02 Apr '19

Gerd Hoffmann (3): drm/virtio: add missing drm_atomic_helper_shutdown() call. drm/bochs: add missing drm_atomic_helper_shutdown() call. drm/cirrus: add missing drm_helper_force_disable_all() call. drivers/gpu/drm/bochs/bochs_kms.c | 1 + drivers/gpu/drm/cirrus/cirrus_mode.c | 1 + drivers/gpu/drm/virtio/virtgpu_display.c | 1 + 3 files changed, 3 insertions(+) -- 2.18.1

3 5

[RFC][PATCH 00/11] DRM driver for fbdev devices
by Thomas Zimmermann 02 Apr '19

02 Apr '19

Hi, this RFC patch set implements fbdevdrm, a DRM driver on top of fbdev drivers. I'd appreciate feedback on the code and the idea in general. The fbdev subsystem is considered legacy and will probably be removed at some point. This would mean the loss of a signifanct number of drivers. Some of the affected hardware is probably not in use any longer, but some hardware is still around and provides good(-enough) framebuffers. OTOH, userspace programs that want to support a wide range of graphics hardware have to implement support for both DRM and fbdev interfaces. Such software would benefit from a single interface. The fbdevdrm driver provides a way of running drivers for old and new hardware from the DRM subsystem and interfaces. It's not intended to add new features or drivers to fbdev. Instead fbdevdrm is supposed to be a template for converting fbdev drivers to DRM. It contains a number of comments (labeled 'DRM porting note') that explain the required steps. The license is fairly liberal to allow for combination with existing fbdev code. I tested the current patch set with the following drivers: atyfb, aty128fb, matroxfb, pm2fb, s3fb, savagefb, sisfb, tdfxfb and tridentfb. I was able to successfully start with fbcon enabled and then run weston or X. Thomas Zimmermann (11): drm/fbdevdrm: Add driver skeleton drm/fbdevdrm: Add fbdevdrm device drm/fbdevdrm: Add memory management drm/fbdevdrm: Add file operations drm/fbdevdrm: Add GEM and dumb interfaces drm/fbdevdrm: Add modesetting infrastructure drm/fbdevdrm: Add DRM <-> fbdev pixel-format conversion drm/fbdevdrm: Add mode conversion DRM <-> fbdev drm/fbdevdrm: Add primary plane drm/fbdevdrm: Add CRTC drm/fbdevdrm: Detect and validate display modes drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/fbdevdrm/Kconfig | 13 + drivers/gpu/drm/fbdevdrm/Makefile | 11 + drivers/gpu/drm/fbdevdrm/fbdevdrm_bo.c | 276 ++++++++ drivers/gpu/drm/fbdevdrm/fbdevdrm_bo.h | 58 ++ drivers/gpu/drm/fbdevdrm/fbdevdrm_device.c | 96 +++ drivers/gpu/drm/fbdevdrm/fbdevdrm_device.h | 55 ++ drivers/gpu/drm/fbdevdrm/fbdevdrm_drv.c | 347 +++++++++ drivers/gpu/drm/fbdevdrm/fbdevdrm_format.c | 441 ++++++++++++ drivers/gpu/drm/fbdevdrm/fbdevdrm_format.h | 26 + drivers/gpu/drm/fbdevdrm/fbdevdrm_modes.c | 195 +++++ drivers/gpu/drm/fbdevdrm/fbdevdrm_modes.h | 53 ++ drivers/gpu/drm/fbdevdrm/fbdevdrm_modeset.c | 746 ++++++++++++++++++++ drivers/gpu/drm/fbdevdrm/fbdevdrm_modeset.h | 38 + drivers/gpu/drm/fbdevdrm/fbdevdrm_primary.c | 498 +++++++++++++ drivers/gpu/drm/fbdevdrm/fbdevdrm_primary.h | 27 + drivers/gpu/drm/fbdevdrm/fbdevdrm_ttm.c | 202 ++++++ drivers/gpu/drm/fbdevdrm/fbdevdrm_ttm.h | 35 + 19 files changed, 3120 insertions(+) create mode 100644 drivers/gpu/drm/fbdevdrm/Kconfig create mode 100644 drivers/gpu/drm/fbdevdrm/Makefile create mode 100644 drivers/gpu/drm/fbdevdrm/fbdevdrm_bo.c create mode 100644 drivers/gpu/drm/fbdevdrm/fbdevdrm_bo.h create mode 100644 drivers/gpu/drm/fbdevdrm/fbdevdrm_device.c create mode 100644 drivers/gpu/drm/fbdevdrm/fbdevdrm_device.h create mode 100644 drivers/gpu/drm/fbdevdrm/fbdevdrm_drv.c create mode 100644 drivers/gpu/drm/fbdevdrm/fbdevdrm_format.c create mode 100644 drivers/gpu/drm/fbdevdrm/fbdevdrm_format.h create mode 100644 drivers/gpu/drm/fbdevdrm/fbdevdrm_modes.c create mode 100644 drivers/gpu/drm/fbdevdrm/fbdevdrm_modes.h create mode 100644 drivers/gpu/drm/fbdevdrm/fbdevdrm_modeset.c create mode 100644 drivers/gpu/drm/fbdevdrm/fbdevdrm_modeset.h create mode 100644 drivers/gpu/drm/fbdevdrm/fbdevdrm_primary.c create mode 100644 drivers/gpu/drm/fbdevdrm/fbdevdrm_primary.h create mode 100644 drivers/gpu/drm/fbdevdrm/fbdevdrm_ttm.c create mode 100644 drivers/gpu/drm/fbdevdrm/fbdevdrm_ttm.h -- 2.21.0

6 31

[PATCH v2 0/2] arm64: meson-gxm: Add support for the Mali T820 GPU
by Neil Armstrong 02 Apr '19

02 Apr '19

This patchset adds : - Optional reset properties in the midgard bindings - Mali T820 Node in Amlogic Meson GXM DTSI Changes since v1: - Updated midgard DT wording following the recently submitted bifrost bindings Christian Hewitt (1): arm64: dts: meson-gxm: Add Mali-T820 node Neil Armstrong (1): dt-bindings: gpu: mali-midgard: Add resets property .../bindings/gpu/arm,mali-midgard.txt | 14 ++++++++++ arch/arm64/boot/dts/amlogic/meson-gxm.dtsi | 27 +++++++++++++++++++ 2 files changed, 41 insertions(+) -- 2.20.1

3 5

[patch] drm/ttm: capture overflow of mapping boundary in ttm_bo_kmap()
by Hillf Danton 02 Apr '19

02 Apr '19

Simply complain if the combined result of start_page and num_pages goes over the pages bo has. Let me know if the added warning is too heavy a hammer. Cc: Christian Koenig <christian.koenig(a)amd.com> Cc: Huang Rui <ray.huang(a)amd.com> Cc: Junwei Zhang <Jerry.Zhang(a)amd.com> Signed-off-by: Hillf Danton <hdanton(a)sina.com> --- --- a/drivers/gpu/drm/ttm/ttm_bo_util.c 2019-04-02 09:27:24.521761100 +0800 +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c 2019-04-02 09:37:52.108898500 +0800 @@ -631,6 +631,8 @@ int ttm_bo_kmap(struct ttm_buffer_object return -EINVAL; if (start_page > bo->num_pages) return -EINVAL; + if (WARN_ON(start_page > bo->num_pages - num_pages)) + return -EINVAL; (void) ttm_mem_io_lock(man, false); ret = ttm_mem_io_reserve(bo->bdev, &bo->mem); --

1 0

[PATCH 0/2] drm: Add ASPEED BMC 'GFX' driver
by Joel Stanley 02 Apr '19

02 Apr '19

This driver is for the ASPEED BMC SoC's GFX display hardware. This driver runs on the ARM based BMC systems, unlike the ast driver which runs on a host CPU and is is for a PCIe graphics device that happens to live in the BMC's silicon, but is otherwise available for use by the BMC. I submitted a RFC about a year ago. https://patchwork.kernel.org/patch/10339605/ I've fixed all of the issues I had in the RFC, and made the cleanups that Eric suggested in that review. This version is based on next-20190327. Joel Stanley (2): dt-bindings: gpu: Add ASPEED GFX bindings document drm: Add ASPEED GFX driver .../devicetree/bindings/gpu/aspeed-gfx.txt | 41 +++ drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/aspeed/Kconfig | 15 + drivers/gpu/drm/aspeed/Makefile | 3 + drivers/gpu/drm/aspeed/aspeed_gfx.h | 104 +++++++ drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c | 248 ++++++++++++++++ drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 269 ++++++++++++++++++ drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 49 ++++ 9 files changed, 732 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpu/aspeed-gfx.txt create mode 100644 drivers/gpu/drm/aspeed/Kconfig create mode 100644 drivers/gpu/drm/aspeed/Makefile create mode 100644 drivers/gpu/drm/aspeed/aspeed_gfx.h create mode 100644 drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c create mode 100644 drivers/gpu/drm/aspeed/aspeed_gfx_drv.c create mode 100644 drivers/gpu/drm/aspeed/aspeed_gfx_out.c -- 2.20.1

4 6

[PATCH] drm/mediatek: Fix an error code in mtk_hdmi_dt_parse_pdata()
by Dan Carpenter 02 Apr '19

02 Apr '19

We don't want to overwrite "ret", it already holds the correct error code. The "regmap" variable might be a valid pointer as this point. Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index 915cc84621ae..543a25e5765e 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -1480,7 +1480,6 @@ static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi, if (IS_ERR(regmap)) ret = PTR_ERR(regmap); if (ret) { - ret = PTR_ERR(regmap); dev_err(dev, "Failed to get system configuration registers: %d\n", ret); -- 2.17.1

2 1

[PATCH v2] drm: etnaviv: fix strncpy sizeof argument
by Bo YU 02 Apr '19

02 Apr '19

Calling strncpy with a maximum size argument of 64 bytes on destination array "domain->name" of size 64 bytes might leave the destination string unterminated. Detected by CoverityScan, CID# 1443992: Memory - illegal accesses (BUFFER_SIZE_WARNING) Fixes: 9e2c2e2730126 (drm/etnaviv: add infrastructure to query perf counter) Signed-off-by: Bo YU <tsu.yubo(a)gmail.com> --- v2: accroding to Russell's suggestion, replace strncpy with strlcpy --- drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c index 4227a4006c34..ce178f23e86a 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c @@ -414,7 +414,7 @@ int etnaviv_pm_query_dom(struct etnaviv_gpu *gpu, domain->id = domain->iter; domain->nr_signals = dom->nr_signals; - strncpy(domain->name, dom->name, sizeof(domain->name)); + strlcpy(domain->name, dom->name, sizeof(domain->name)); domain->iter++; if (domain->iter == meta->nr_domains) -- 2.11.0

1 1

[PATCH] fbdev: fix divide error in fb_var_to_videomode
by shile.zhang＠linux.alibaba.com 02 Apr '19

02 Apr '19

From: Shile Zhang <shile.zhang(a)linux.alibaba.com> To fix following divide-by-zero error found by Syzkaller: divide error: 0000 [#1] SMP PTI CPU: 7 PID: 8447 Comm: test Kdump: loaded Not tainted 4.19.24-8.al7.x86_64 #1 Hardware name: Alibaba Cloud Alibaba Cloud ECS, BIOS rel-1.12.0-0-ga698c8995f-prebuilt.qemu.org 04/01/2014 RIP: 0010:fb_var_to_videomode+0xae/0xc0 Code: 04 44 03 46 78 03 4e 7c 44 03 46 68 03 4e 70 89 ce d1 ee 69 c0 e8 03 00 00 f6 c2 01 0f 45 ce 83 e2 02 8d 34 09 0f 45 ce 31 d2 <41> f7 f0 31 d2 f7 f1 89 47 08 f3 c3 66 0f 1f 44 00 00 0f 1f 44 00 RSP: 0018:ffffb7e189347bf0 EFLAGS: 00010246 RAX: 00000000e1692410 RBX: ffffb7e189347d60 RCX: 0000000000000000 RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffb7e189347c10 RBP: ffff99972a091c00 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000100 R13: 0000000000010000 R14: 00007ffd66baf6d0 R15: 0000000000000000 FS: 00007f2054d11740(0000) GS:ffff99972fbc0000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f205481fd20 CR3: 00000004288a0001 CR4: 00000000001606a0 Call Trace: fb_set_var+0x257/0x390 ? lookup_fast+0xbb/0x2b0 ? fb_open+0xc0/0x140 ? chrdev_open+0xa6/0x1a0 do_fb_ioctl+0x445/0x5a0 do_vfs_ioctl+0x92/0x5f0 ? __alloc_fd+0x3d/0x160 ksys_ioctl+0x60/0x90 __x64_sys_ioctl+0x16/0x20 do_syscall_64+0x5b/0x190 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x7f20548258d7 Code: 44 00 00 48 8b 05 b9 15 2d 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 89 15 2d 00 f7 d8 64 89 01 48 It can be triggered easily with following test code: #include <linux/fb.h> #include <fcntl.h> #include <sys/ioctl.h> int main(void) { struct fb_var_screeninfo var = {.activate = 0x100, .pixclock = 60}; int fd = open("/dev/fb0", O_RDWR); if (fd < 0) return 1; if (ioctl(fd, FBIOPUT_VSCREENINFO, &var)) return 1; return 0; } Signed-off-by: Shile Zhang <shile.zhang(a)linux.alibaba.com> --- drivers/video/fbdev/core/modedb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video/fbdev/core/modedb.c b/drivers/video/fbdev/core/modedb.c index 283d9307..ac04987 100644 --- a/drivers/video/fbdev/core/modedb.c +++ b/drivers/video/fbdev/core/modedb.c @@ -935,6 +935,9 @@ void fb_var_to_videomode(struct fb_videomode *mode, if (var->vmode & FB_VMODE_DOUBLE) vtotal *= 2; + if (!htotal || !vtotal) + return; + hfreq = pixclock/htotal; mode->refresh = hfreq/vtotal; } -- 1.8.3.1

5 5

[PATCH] virtgpu: Update kernel header
by Gurchetan Singh 01 Apr '19

01 Apr '19

Generated using make headers_install. This brings in the in/out fence support for explicit synchronization. Signed-off-by: Gurchetan Singh <gurchetansingh(a)chromium.org> --- include/drm/virtgpu_drm.h | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/include/drm/virtgpu_drm.h b/include/drm/virtgpu_drm.h index 9a781f06..acb21912 100644 --- a/include/drm/virtgpu_drm.h +++ b/include/drm/virtgpu_drm.h @@ -47,6 +47,13 @@ extern "C" { #define DRM_VIRTGPU_WAIT 0x08 #define DRM_VIRTGPU_GET_CAPS 0x09 +#define VIRTGPU_EXECBUF_FENCE_FD_IN 0x01 +#define VIRTGPU_EXECBUF_FENCE_FD_OUT 0x02 +#define VIRTGPU_EXECBUF_FLAGS (\ + VIRTGPU_EXECBUF_FENCE_FD_IN |\ + VIRTGPU_EXECBUF_FENCE_FD_OUT |\ + 0) + struct drm_virtgpu_map { __u64 offset; /* use for mmap system call */ __u32 handle; @@ -54,16 +61,18 @@ struct drm_virtgpu_map { }; struct drm_virtgpu_execbuffer { - __u32 flags; /* for future use */ + __u32 flags; __u32 size; __u64 command; /* void* */ __u64 bo_handles; __u32 num_bo_handles; - __u32 pad; + __s32 fence_fd; /* in/out fence fd (see VIRTGPU_EXECBUF_FENCE_FD_IN/OUT) */ }; #define VIRTGPU_PARAM_3D_FEATURES 1 /* do we have 3D features in the hw */ #define VIRTGPU_PARAM_CAPSET_QUERY_FIX 2 /* do we have the capset fix */ +#define VIRTGPU_PARAM_NO_TRANSFER 3 /* have VIRTIO_GPU_F_NO_TRANSFER */ +#define VIRTGPU_PARAM_HOST_COHERENT 4 /* have VIRTIO_GPU_F_HOST_COHERENT */ struct drm_virtgpu_getparam { __u64 param; @@ -137,7 +146,7 @@ struct drm_virtgpu_get_caps { DRM_IOWR(DRM_COMMAND_BASE + DRM_VIRTGPU_MAP, struct drm_virtgpu_map) #define DRM_IOCTL_VIRTGPU_EXECBUFFER \ - DRM_IOW(DRM_COMMAND_BASE + DRM_VIRTGPU_EXECBUFFER,\ + DRM_IOWR(DRM_COMMAND_BASE + DRM_VIRTGPU_EXECBUFFER,\ struct drm_virtgpu_execbuffer) #define DRM_IOCTL_VIRTGPU_GETPARAM \ -- 2.20.1

2 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2019