dri-devel May 2019

dri-devel@lists.freedesktop.org

299 participants
2118 discussions

[PATCH AUTOSEL 5.0 27/99] drm/amdgpu: shadow in shadow_list without tbo.mem.start cause page fault in sriov TDR
by Sasha Levin 07 May '19

07 May '19

From: wentalou <Wentao.Lou(a)amd.com> [ Upstream commit b575f10dbd6f84c2c8744ff1f486bfae1e4f6f38 ] shadow was added into shadow_list by amdgpu_bo_create_shadow. meanwhile, shadow->tbo.mem was not fully configured. tbo.mem would be fully configured by amdgpu_vm_sdma_map_table until calling amdgpu_vm_clear_bo. If sriov TDR occurred between amdgpu_bo_create_shadow and amdgpu_vm_sdma_map_table, amdgpu_device_recover_vram would deal with shadow without tbo.mem.start. Signed-off-by: Wentao Lou <Wentao.Lou(a)amd.com> Reviewed-by: Christian König <christian.koenig(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 7ff3a28fc903..5336b2c9b615 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -3150,6 +3150,7 @@ static int amdgpu_device_recover_vram(struct amdgpu_device *adev) /* No need to recover an evicted BO */ if (shadow->tbo.mem.mem_type != TTM_PL_TT || + shadow->tbo.mem.start == AMDGPU_BO_INVALID_OFFSET || shadow->parent->tbo.mem.mem_type != TTM_PL_VRAM) continue; -- 2.20.1

1 0

[PATCH AUTOSEL 5.0 23/99] drm/amd/display: extending AUX SW Timeout
by Sasha Levin 07 May '19

07 May '19

From: Martin Leung <martin.leung(a)amd.com> [ Upstream commit f4bbebf8e7eb4d294b040ab2d2ba71e70e69b930 ] [Why] AUX takes longer to reply when using active DP-DVI dongle on some asics resulting in up to 2000+ us edid read (timeout). [How] 1. Adjust AUX poll to match spec 2. Extend the SW timeout. This does not affect normal operation since we exit the loop as soon as AUX acks. Signed-off-by: Martin Leung <martin.leung(a)amd.com> Reviewed-by: Jun Lei <Jun.Lei(a)amd.com> Acked-by: Joshua Aberback <Joshua.Aberback(a)amd.com> Acked-by: Leo Li <sunpeng.li(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 9 ++++++--- drivers/gpu/drm/amd/display/dc/dce/dce_aux.h | 6 +++--- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c index aaeb7faac0c4..e0fff5744b5f 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c @@ -189,6 +189,12 @@ static void submit_channel_request( 1, 0); } + + REG_UPDATE(AUX_INTERRUPT_CONTROL, AUX_SW_DONE_ACK, 1); + + REG_WAIT(AUX_SW_STATUS, AUX_SW_DONE, 0, + 10, aux110->timeout_period/10); + /* set the delay and the number of bytes to write */ /* The length include @@ -241,9 +247,6 @@ static void submit_channel_request( } } - REG_UPDATE(AUX_INTERRUPT_CONTROL, AUX_SW_DONE_ACK, 1); - REG_WAIT(AUX_SW_STATUS, AUX_SW_DONE, 0, - 10, aux110->timeout_period/10); REG_UPDATE(AUX_SW_CONTROL, AUX_SW_GO, 1); } diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.h b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.h index f7caab85dc80..2c6f50b4245a 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.h +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.h @@ -69,11 +69,11 @@ enum { /* This is the timeout as defined in DP 1.2a, * at most within ~240usec. That means, * increasing this timeout will not affect normal operation, * and we'll timeout after - * SW_AUX_TIMEOUT_PERIOD_MULTIPLIER * AUX_TIMEOUT_PERIOD = 1600usec. + * SW_AUX_TIMEOUT_PERIOD_MULTIPLIER * AUX_TIMEOUT_PERIOD = 2400usec. * This timeout is especially important for - * resume from S3 and CTS. + * converters, resume from S3, and CTS. */ - SW_AUX_TIMEOUT_PERIOD_MULTIPLIER = 4 + SW_AUX_TIMEOUT_PERIOD_MULTIPLIER = 6 }; struct aux_engine_dce110 { struct aux_engine base; -- 2.20.1

1 0

[PATCH AUTOSEL 5.0 22/99] drm/ttm: fix dma_fence refcount imbalance on error path
by Sasha Levin 07 May '19

07 May '19

From: Lin Yi <teroincn(a)163.com> [ Upstream commit 543c364d8eeeb42c0edfaac9764f4e9f3d777ec1 ] the ttm_bo_add_move_fence takes a reference to the struct dma_fence, but failed to release it on the error path, leading to a memory leak. add dma_fence_put before return when error occur. Signed-off-by: Lin Yi <teroincn(a)163.com> Reviewed-by: Christian König <christian.koenig(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/ttm/ttm_bo.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 996cadd83f24..d8e1b3f12904 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -881,8 +881,10 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo, reservation_object_add_shared_fence(bo->resv, fence); ret = reservation_object_reserve_shared(bo->resv, 1); - if (unlikely(ret)) + if (unlikely(ret)) { + dma_fence_put(fence); return ret; + } dma_fence_put(bo->moving); bo->moving = fence; -- 2.20.1

1 0

[Bug 88275] [865G] Intel OpenGL rendering isn't starting
by bugzilla-daemon＠freedesktop.org 07 May '19

07 May '19

https://bugs.freedesktop.org/show_bug.cgi?id=88275 Timothy Arceri <t_arceri(a)yahoo.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mesa-dev(a)lists.freedesktop. |dri-devel(a)lists.freedesktop |org |.org Component|Mesa core |Drivers/DRI/i915 -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 44344] [i915g] state_tracker/st_glsl_to_tgsi.cpp:3082:simplify_cmp: Assertion `inst->dst.index < 4096' failed.
by bugzilla-daemon＠freedesktop.org 07 May '19

07 May '19

https://bugs.freedesktop.org/show_bug.cgi?id=44344 Timothy Arceri <t_arceri(a)yahoo.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Mesa core |Drivers/Gallium/i915g Assignee|mesa-dev(a)lists.freedesktop. |dri-devel(a)lists.freedesktop |org |.org -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 110630] Random Horizontal green lines after screen resize
by bugzilla-daemon＠freedesktop.org 06 May '19

06 May '19

https://bugs.freedesktop.org/show_bug.cgi?id=110630 --- Comment #5 from Axel Davy <davyaxel0(a)gmail.com> --- Created attachment 144182 --> https://bugs.freedesktop.org/attachment.cgi?id=144182&action=edit Xorg log (after having the issue) -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 110630] Random Horizontal green lines after screen resize
by bugzilla-daemon＠freedesktop.org 06 May '19

06 May '19

https://bugs.freedesktop.org/show_bug.cgi?id=110630 --- Comment #4 from Axel Davy <davyaxel0(a)gmail.com> --- Created attachment 144181 --> https://bugs.freedesktop.org/attachment.cgi?id=144181&action=edit dmesg (after capturing the issue) -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 110630] Random Horizontal green lines after screen resize
by bugzilla-daemon＠freedesktop.org 06 May '19

06 May '19

https://bugs.freedesktop.org/show_bug.cgi?id=110630 --- Comment #3 from Axel Davy <davyaxel0(a)gmail.com> --- Yes sure, Here is a video: http://dev.ipol.im/~adavy/green_lines.mp4 -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 110630] Random Horizontal green lines after screen resize
by bugzilla-daemon＠freedesktop.org 06 May '19

06 May '19

https://bugs.freedesktop.org/show_bug.cgi?id=110630 --- Comment #2 from Alex Deucher <alexdeucher(a)gmail.com> --- Can you get a picture or video of the lines? Please attach your dmesg output and xorg log (if using X). -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 110630] Random Horizontal green lines after screen resize
by bugzilla-daemon＠freedesktop.org 06 May '19

06 May '19

https://bugs.freedesktop.org/show_bug.cgi?id=110630 Axel Davy <davyaxel0(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Horizontal green lines |Random Horizontal green | |lines after screen resize --- Comment #1 from Axel Davy <davyaxel0(a)gmail.com> --- Hi there, AMD Radeon RX 480. Linux 5.0.13 Full HD screen with hdmi Archlinux KDE Xorg It's a problem I had noticed for some time, but couldn't figure out what was triggering it. Sometimes after screen mode change there is random green lines appearing on the screen (random location, but about one third of the bottom of the screen). It seems i can replicate it on my system by changing the resolution in the system settings from 1920x1080 to 1280x1024. When going back to full hd, the green lines sometimes remain. Shutting down the screen and resuming it helps (but if still at 1280x1024, the lines remain). The random line disappear when the screen doesn't refresh (cursor not moving, nothing drawing on the background). No particular message appear in the dmesg after changing resolution. I assume this is not enough, please indicate me what would help. -- You are receiving this mail because: You are the assignee for the bug.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2019